nexmo-voice 0.0.2 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dcde1288aaa42a8c6fe96875317a2d7d80490f43
-  data.tar.gz: 0824bef538f1f8a2bcbf967eabba1273927ee943
+  metadata.gz: 7ed1c1f753d58c6150bf9ebd530581db7a4a8087
+  data.tar.gz: da4b358a220faa34f0a9a1de37a0bc5f084a3826
 SHA512:
-  metadata.gz: 9900632c2417fa020fb7b41a837e5138ec7f2f3e13573f1697208c998e509169eddcc26e7de98c8a34d35b0a75a33e9f6c53ad23d3b45d1a78e718d80a54f7a7
-  data.tar.gz: 249e2583124f011ca64b05e0dc59e474c3a9d5b4d3bda1ed5a21324539db6cee7a1526287bc08894ede8772201514ca93a5dd0918b2edeb4fe9f817dd1fa5dcd
+  metadata.gz: e2d5bf776ca0a39bc00b4817d649bb52964b2827785d178d686bdd226034a3bd2ba3c632edf8ab125e6e0b076c0b02f94863a1d84c3dee1bdf54f2dafa44037c
+  data.tar.gz: 4d4f695d64b4493226e82c7103ea75b61741fd4858a64fcb6bb2348b8b39f37208eea990c93871733cd0f5c1ea14f25583c283977241704c7087d82fdfb38796

data/CHANGELOG.md

@@ -0,0 +1,5 @@
+# Changelog
+
+## 0.1.0
+
+* Support timeout `Nexmo::Voice::Client.new 'your_key', 'your_secret', timeout: 2`

data/README.md

@@ -21,7 +21,9 @@ Or install it yourself as:
 ```ruby
   # Initialize your client
   client = Nexmo::Voice::Client.new 'your_key', 'your_secret'
-  
+  # or initialize with timeout(default: 10 seconds)
+  client = Nexmo::Voice::Client.new 'your_key', 'your_secret', timeout: 2
+
   # Make a tts call with minimum options
   options = {
     to: 'recipient_number',

data/lib/nexmo/voice.rb

@@ -9,23 +9,23 @@ module Nexmo
     BASE_URL = 'https://api.nexmo.com'
 
     class Client
-      attr_accessor :api_key, :api_secret,
+      attr_accessor :nexmo_adaptor, :api_config,
         :calls, :ttses
 
-      def initialize(api_key, api_secret)
-        @api_key, @api_secret = api_key, api_secret
+      def initialize(api_key, api_secret, options = {})
+        @nexmo_adaptor = RestClient::Resource.new(BASE_URL, timeout: options.fetch(:timeout, 10))
+
+        @api_config = {
+          api_key: api_key,
+          api_secret: api_secret
+        }
+
         @calls = Calls.new(self)
         @ttses = Ttses.new(self)
       end
 
       def get(resource, entity = {})
-        uri = "#{BASE_URL}#{resource.class::RELATIVE_URL}"
-        params = entity.merge({
-          api_key: @api_key,
-          api_secret: @api_secret
-        })
-
-        RestClient.get(uri, params: params)
+        @nexmo_adaptor[resource.class::RELATIVE_URL].get(params: entity.merge(@api_config))
       end
     end
 

data/lib/nexmo/voice/version.rb

@@ -1,5 +1,5 @@
 module Nexmo
   module Voice
-    VERSION = "0.0.2"
+    VERSION = "0.1.0"
   end
 end

data/spec/nexmo/voice/calls_spec.rb

@@ -3,20 +3,28 @@ require 'spec_helper'
 describe Nexmo::Voice::Calls do
   let(:client) { Nexmo::Voice::Client.new('api_key', 'api_secret') }
   let(:entity) { { to: '8618000000001', answer_url: 'http://test.com/answer_url' } }
-
-  before do
-    response_json = {
+  let(:response_json) {
+    {
       'call-id' => 'd7d74aed5c754a992586c5baf01ed24d',
       'to' => '8618600000001',
       'status' => '0',
       'error-text' => 'Success'
     }
-    stub_request(:get, %r(https://api.nexmo.com/call/json.*)).to_return(body: response_json)
-  end
+  }
 
   it 'not raises errors' do
+    stub_request(:get, %r(https://api.nexmo.com/call/json.*)).to_return(body: response_json)
+
     expect {
       client.calls.create(entity)
     }.not_to raise_error
   end
+
+  it 'timeouts' do
+    stub_request(:get, %r(https://api.nexmo.com/call/json.*)).to_timeout
+
+    expect {
+      client.calls.create(entity)
+    }.to raise_error
+  end
 end

data/spec/nexmo/voice/ttses_spec.rb

@@ -3,21 +3,29 @@ require 'spec_helper'
 describe Nexmo::Voice::Ttses do
   let(:client) { Nexmo::Voice::Client.new('api_key', 'api_secret') }
   let(:entity) { { to: '8618000000001', text: 'Hello from gem' } }
-
-  before do
-    response_json = {
+  let(:response_json) {
+    {
       'call-id' => 'd7d74aed5c754a992586c5baf01ed24d',
       'to' => '8618600000001',
       'status' => '0',
       'error-text' => 'Success'
     }
-    stub_request(:get, %r(https://api.nexmo.com/tts/json.*)).to_return(body: response_json)
-  end
+  }
 
   it 'not raises errors' do
+    stub_request(:get, %r(https://api.nexmo.com/tts/json.*)).to_return(body: response_json)
+
     expect {
       client.ttses.create(entity)
     }.not_to raise_error
   end
+
+  it 'timeouts' do
+    stub_request(:get, %r(https://api.nexmo.com/tts/json.*)).to_timeout
+
+    expect {
+      client.calls.create(entity)
+    }.to raise_error
+  end
 end
 

data/spec/nexmo/voice_spec.rb

@@ -11,11 +11,16 @@ RSpec.describe Nexmo::Voice::Client do
   let(:api_secret) { 'test_api_secret' }
   let(:client) { Nexmo::Voice::Client.new api_key, api_secret }
 
-  it 'sets the api_key' do
-    expect(client.api_key).to eq api_key
+  it 'sets the api_config' do
+    expect(client.api_config).to match({ api_key: api_key, api_secret: api_secret })
   end
 
-  it 'sets the api_secret' do
-    expect(client.api_secret).to eq api_secret
+  it 'sets the default timeout' do
+    expect(client.nexmo_adaptor.timeout).to eq 10
+  end
+
+  it 'sets the timeout' do
+    another_client = Nexmo::Voice::Client.new api_key, api_secret, timeout: 2
+    expect(another_client.nexmo_adaptor.timeout).to eq 2
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nexmo-voice
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors:
 - fahchen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-26 00:00:00.000000000 Z
+date: 2016-01-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -89,6 +89,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -122,7 +123,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: A Ruby wrapper for the Nexmo Voice API.