newshound 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 65debb3ae756e51f870de0872ff54d2332ee71e9c05aa6ac174c9525336c46b5
-  data.tar.gz: 8667bbc9ff8695b5191bccbbe066190bb9e6f86f7c7ef0d6508a312420258167
+  metadata.gz: 17482571ea8f7d999aa1325c6263939d19d2028f8b1ee493dbf937db079ca7cb
+  data.tar.gz: 60fb33436b5c573feae6c5fbbf85c4e5c0b5e7a402f4ebb4af0a6d9627aaee27
 SHA512:
-  metadata.gz: 7bb18eaf72c010172a7c80c13f782b6736620cef9855ee81f0faaa2ad32d1659b02d0970a4381adad7b42d72eb80663b8c93e0eefebd58d61ec75d45c2c31081
-  data.tar.gz: '07722335323043284857b615205ec4def0f167f4f77308ffce3eeb1911afe85c963e6a62987f88d88d59e8385a4998d30e33835211c6c7d70f52e111f46ae5bb'
+  metadata.gz: b1d0e8d16a32eec46f8053cd86b2d0bcef597724eef9075e227b054ef3b41fe562bc821c70cad5360b7151ead08599a226a4591c485811d90ebca7d7599261ee
+  data.tar.gz: bceefac2030c25e5a833f6b0e4debdc69cc30412b2af500f7cd3e0164b46300eb301f3fbf54aad3c277452f3ea8ae3e7856f105c9040a38cedad0f3d70399380

data/CHANGELOG.md

@@ -5,45 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.2.2] - 2025-10-23
-
-### Added
-
-- CI workflow to run tests on Ruby 3.0-3.4 (b3ebc7a)
-- Separate linter job for RuboCop (b3ebc7a)
-- Coverage reporting with SimpleCov (b3ebc7a)
-- CI workflow to run tests on Ruby 3.0-3.4 (782cc57)
-- Separate linter job for RuboCop (782cc57)
-- Coverage reporting with SimpleCov (782cc57)
-- .claude/settings.local.json to .gitignore (701d802)
-- Reissue gem dependency for automated versioning (feac98a)
-- Git trailer support for changelog management (feac98a)
-- Initial CHANGELOG.md with Keep a Changelog format (feac98a)
-- CODEOWNERS file for SOFware/engineers (1a0a1f5)
-- Newshound::Exceptions::Base for standard API to interact with exception data (9dce846)
-- Configuration exception_source to allow for future alternative exception backends (9dce846)
-- SolidErrors support (8b5b48a)
-
-### Changed
-
-- Replaced RuboCop with StandardRB for simpler linting (09292ed)
-- Updated GitHub Actions workflow to use standardrb (09292ed)
-- Auto-corrected all StandardRB violations (09292ed)
-- Simplified test setup by removing unused mocks (701d802)
-- Rakefile to use reissue tasks instead of manual versioning (feac98a)
-- Removed Ruby 3.0 from test matrix (now testing 3.1-3.4) (4beafd2)
-- Updated gemspec required_ruby_version to >= 3.1.0 (4beafd2)
+## [0.2.3] - 2025-10-29
 
 ### Fixed
 
-- Workflow now only runs once per PR (removed duplicate triggers) (09292ed)
-- Mock ActiveRecord::Base.connection and its methods (701d802)
-- Mock connection.execute to return database-like results (701d802)
-- Mock connection.quote and connection.select_value properly (701d802)
-- Name and email in gemspec authors (ab44f30)
-
-### Removed
+- Updated styling in banner injector to attempt to keep newshound banner above other application's menus, instead of hovering over them.
 
-- Dependency on exception-track (8b5b48a)
+### Changed
 
-## [0.2.2] - Unreleased
+- Consolidated exception data extraction in ExceptionTrack and SolidErrors (55cffd3)

data/README.md

@@ -207,7 +207,7 @@ This gem uses [Reissue](https://github.com/rails/reissue) for release management
 the following steps as you would with any other ruby gem:
 
 ```bash
-bundle exec rake bump:checksum
+bundle exec rake build:checksum
 ```
 And then create a new release:
 ```bash

data/checksums/newshound-0.2.3.gem.sha512

@@ -0,0 +1 @@
+4b38b6628a214ff2cf66a400e184a5659a2ba82ccf46efde37293d93dd77534ffe87d3dd41220e0cac43aabaed66318cbdb70b8cbf66988f744f04ead452bbc5

data/lib/newshound/exceptions/exception_track.rb

@@ -12,53 +12,41 @@ module Newshound
         details = parse_exception_details(exception)
 
         <<~TEXT
-          *#{number}. #{exception_title(exception)}*
+          *#{number}. #{details[:title]}*
           • *Time:* #{exception.created_at.strftime("%I:%M %p")}
           #{format_controller(details)}
-          #{format_message(exception, details)}
+          #{format_message(details)}
         TEXT
       end
 
       def format_for_banner(exception)
         details = parse_exception_details(exception)
 
-        # Extract message
-        message = if details["message"].present?
-          details["message"].to_s
-        elsif exception.respond_to?(:message) && exception.message.present?
-          exception.message.to_s
-        else
-          +""
-        end
-
-        # Extract location
-        location = if details["controller_name"] && details["action_name"]
-          "#{details["controller_name"]}##{details["action_name"]}"
-        else
-          +""
-        end
-
         {
-          title: exception_title(exception),
-          message: message.truncate(100),
-          location: location,
+          title: details[:title],
+          message: details[:message].truncate(100),
+          location: details[:location],
           time: exception.created_at.strftime("%I:%M %p")
         }
       end
 
       private
 
-      def exception_title(exception)
-        if exception.respond_to?(:title) && exception.title.present?
-          exception.title
-        elsif exception.respond_to?(:exception_class) && exception.exception_class.present?
-          exception.exception_class
-        else
-          "Unknown Exception"
-        end
+      def parse_exception_details(exception)
+        body_data = parse_body(exception)
+        controller_name = body_data["controller_name"]
+        action_name = body_data["action_name"]
+
+        {
+          title: exception.try(:title).presence || exception.try(:exception_class).presence || "Unknown Exception",
+          message: body_data["message"].presence&.to_s || exception.try(:message).presence&.to_s || +"",
+          location: (controller_name && action_name) ? "#{controller_name}##{action_name}" : +"",
+          controller_name: controller_name,
+          action_name: action_name
+        }
       end
 
-      def parse_exception_details(exception)
+      def parse_body(exception)
         return {} unless exception.respond_to?(:body) && exception.body.present?
 
         JSON.parse(exception.body)
@@ -67,24 +55,15 @@ module Newshound
       end
 
       def format_controller(details)
-        return +"" unless details["controller_name"] && details["action_name"]
+        return +"" unless details in {controller_name: String, action_name: String}
 
-        "• *Controller:* #{details["controller_name"]}##{details["action_name"]}\n"
+        "• *Controller:* #{details[:location]}\n"
       end
 
-      def format_message(exception, details = nil)
-        details ||= parse_exception_details(exception)
-
-        # Try to get message from different sources
-        message = if details["message"].present?
-          details["message"]
-        elsif exception.respond_to?(:message) && exception.message.present?
-          exception.message
-        end
-
-        return +"" unless message.present?
+      def format_message(details)
+        return +"" unless details in {message: String}
 
-        message = message.to_s.truncate(100)
+        message = details[:message].to_s.truncate(100)
         "• *Message:* `#{message}`"
       end
     end

data/lib/newshound/exceptions/solid_errors.rb

@@ -9,60 +9,50 @@ module Newshound
       end
 
       def format_for_report(exception, number)
-        context = parse_context(exception)
+        details = parse_exception_details(exception)
 
         <<~TEXT
-          *#{number}. #{exception_title(exception)}*
+          *#{number}. #{details[:title]}*
           • *Time:* #{exception.created_at.strftime("%I:%M %p")}
-          #{format_controller(context)}
-          #{format_message(exception, context)}
+          #{format_controller(details)}
+          #{format_message(details)}
         TEXT
       end
 
       def format_for_banner(exception)
-        context = parse_context(exception)
-
-        # Extract message
-        message = if exception.respond_to?(:message) && exception.message.present?
-          exception.message.to_s
-        elsif context["message"].present?
-          context["message"].to_s
-        else
-          +""
-        end
-
-        # Extract location from context
-        location = if context["controller"] && context["action"]
-          "#{context["controller"]}##{context["action"]}"
-        else
-          +""
-        end
+        details = parse_exception_details(exception)
 
         {
-          title: exception_title(exception),
-          message: message.truncate(100),
-          location: location,
+          title: details[:title],
+          message: details[:message].truncate(100),
+          location: details[:location],
           time: exception.created_at.strftime("%I:%M %p")
         }
       end
 
       private
 
-      def exception_title(exception)
-        if exception.respond_to?(:error_class) && exception.error_class.present?
-          exception.error_class
-        else
-          "Unknown Exception"
-        end
+      def parse_exception_details(exception)
+        context_data = parse_context(exception)
+        controller = context_data["controller"]
+        action = context_data["action"]
+
+        {
+          title: exception.try(:error_class).presence || "Unknown Exception",
+          message: exception.try(:message).presence&.to_s || context_data["message"].presence&.to_s || +"",
+          location: (controller && action) ? "#{controller}##{action}" : +"",
+          controller: controller,
+          action: action
+        }
       end
 
       def parse_context(exception)
         return {} unless exception.respond_to?(:context) && exception.context.present?
 
-        # SolidErrors context might be a hash or JSON string
-        if exception.context.is_a?(Hash)
+        case exception.context
+        when Hash
           exception.context
-        elsif exception.context.is_a?(String)
+        when String
           JSON.parse(exception.context)
         else
           {}
@@ -71,25 +61,16 @@ module Newshound
         {}
       end
 
-      def format_controller(context)
-        return +"" unless context["controller"] && context["action"]
+      def format_controller(details)
+        return +"" unless details in {controller: String, action: String}
 
-        "• *Controller:* #{context["controller"]}##{context["action"]}\n"
+        "• *Controller:* #{details[:location]}\n"
       end
 
-      def format_message(exception, context = nil)
-        context ||= parse_context(exception)
-
-        # Try to get message from different sources
-        message = if exception.respond_to?(:message) && exception.message.present?
-          exception.message
-        elsif context["message"].present?
-          context["message"]
-        end
-
-        return +"" unless message.present?
+      def format_message(details)
+        return +"" unless details in {message: String}
 
-        message = message.to_s.truncate(100)
+        message = details[:message].to_s.truncate(100)
         "• *Message:* `#{message}`"
       end
     end

data/lib/newshound/middleware/banner_injector.rb

@@ -117,7 +117,7 @@ module Newshound
         <<~CSS
           <style>
             body {
-              padding-top: 0;
+              padding-top: 50px;
               transition: padding-top 0.3s ease-out;
             }
             .newshound-banner {

data/lib/newshound/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Newshound
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: newshound
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Savannah Moore
@@ -52,6 +52,7 @@ files:
 - README.md
 - Rakefile
 - TRANSPORT_USAGE.md
+- checksums/newshound-0.2.3.gem.sha512
 - lib/generators/newshound/install/install_generator.rb
 - lib/generators/newshound/install/templates/newshound.rb
 - lib/newshound.rb