newrelic_rpm 9.22.0 → 9.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 002be7971239046fa416e4760bcf3032c7494fd74b5600eec63e0c1d9b8a1a6b
-  data.tar.gz: 603a67f73b504580e3a5db28e046b914f4b957a50b9eaab29fe4aee87c92822b
+  metadata.gz: c3bc35eb6cc82a0dd1ba947b3270d18b515da940533c11362ff531cfbeb05575
+  data.tar.gz: afd55578e5580b8bfb50280259c007c8c6e039a3d2029d9b8be2a2b2b4ea289c
 SHA512:
-  metadata.gz: 4fca3a0ad0b86891bdb6bf0c306d9ce55e4c6fc215e74fc943178d8ed5116ab781ea2d879e7b78918b73313e460c5e876e714ab47828f4315b8894c35845eae2
-  data.tar.gz: 51a42bdb53145e747ebb91c6492e0710cc8d4a272929dd316e48deb5e8e0c70a185292d6185eeb531e776721dd05aef444131c8c3bb9e08988ad353a5c682a68
+  metadata.gz: 75bd39b66cf822e975b2e704360eea2bc3ac44fbd2f63ed38b069a7115ae1a502a29c149adca19f3d057fe1332f3e5122afcdec4f42aec9182195d432db1f206
+  data.tar.gz: 44a1abc2d6f0ce8c28ac20e0912b21a1081baa474e455c561c3f4ace6ade983d2fd1922174ef3922fc51d99f7a771b0d13756fc10f14c8a4f420b5cb84ec4a20

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # New Relic Ruby Agent Release Notes
 
+## v9.23.0
+
+- **Feature: Add sidekiq.ignore_retry_errors configuration option**
+
+  A new configuration option, `sidekiq.ignore_retry_errors`, has been added to control if Sidekiq job retries are captured. Retry errors are captured by default, but now if `sidekiq.ignore_retry_errors` is set to `true`, the agent will ignore exceptions raised during Sidekiq's retry attempts and will only report the error if the job permanently fails. Thank you [DonGiulio](https://github.com/DonGiulio) for recognizing this improvement and contributing a solution. [PR#3317](https://github.com/newrelic/newrelic-ruby-agent/pull/3317)
+
+- **Feature: Deprecation notice for recording deployments using Capistrano**
+
+  Sending application deployment information using a Capistrano recipe is deprecated and will be removed in agent version 10.0.0. For recording deployments, please see our guide to [Change Tracking](https://docs.newrelic.com/docs/change-tracking/change-tracking-introduction/) for a list of available options.
+
+- **Feature: Use remote parent sampling configurations for decisions in more scenarios**
+
+  Previously, the `distributed_tracing.sampler.remote_parent_sampled` and `distributed_tracing.sampler.remote_parent_not_sampled` configuration options were used for the sampling decision only when the `traceparent` and `tracestate` headers were present. Now, these configuration options are applied in cases when the `tracestate` header is missing and when only the `newrelic` header is available. This change makes distributed trace sampling more consistent and predictable. [PR#3306](https://github.com/newrelic/newrelic-ruby-agent/pull/3306)
+
 ## v9.22.0
 
 - **Feature: One-step instrumentation for Kubernetes**

data/lib/new_relic/agent/configuration/default_source.rb

@@ -2140,6 +2140,13 @@ module NewRelic
             argument array elements and job argument scalars will be excluded.
           SIDEKIQ_ARGS_EXCLUDE
         },
+        :'sidekiq.ignore_retry_errors' => {
+          :default => false,
+          :public => true,
+          :type => Boolean,
+          :allowed_from_server => false,
+          :description => %Q(If `true`, the agent will ignore exceptions raised during Sidekiq's retry attempts and will only report the error if the job permanently fails.)
+        },
         # Slow SQL
         :'slow_sql.enabled' => {
           :default => value_of(:'transaction_tracer.enabled'),
@@ -2510,7 +2517,7 @@ module NewRelic
           :description => 'Number of seconds betwixt connections to the New Relic span event collection services.'
         },
         # TODO: Sync with the other agents to see what the config should be named, how it should be enabled, how it should be described
-        :'opentelemetry_bridge.enabled' => {
+        :'opentelemetry.enabled' => {
           :default => false,
           :public => false,
           :type => Boolean,

data/lib/new_relic/agent/distributed_tracing/trace_context_payload.rb

@@ -96,6 +96,16 @@ module NewRelic
         @timestamp = timestamp
       end
 
+      # This is an invalid instance of the TraceContextPayload that is used to
+      # help us determine the sampling decision for an incoming trace when the
+      # tracestate header is missing. Creating an invalid instance allows us
+      # to call methods like .sampled on it without throwing errors.
+      # The timestamp value will represent the time it was created/when this
+      # class was initialized.
+      #
+      # @api private
+      INVALID = create
+
       def parent_type
         @parent_type_string ||= PARENT_TYPES[@parent_type_id]
       end

data/lib/new_relic/agent/instrumentation/sidekiq.rb

@@ -40,13 +40,19 @@ DependencyDetection.defer do
         end
       end
 
-      if config.respond_to?(:error_handlers)
+      if config.respond_to?(:error_handlers) && !NewRelic::Agent.config[:'sidekiq.ignore_retry_errors']
         # Sidekiq 3.0.0 - 7.1.4 expect error_handlers to have 2 arguments
         # Sidekiq 7.1.5+ expect error_handlers to have 3 arguments
         config.error_handlers << proc do |error, _ctx, *_|
           NewRelic::Agent.notice_error(error)
         end
       end
+
+      if config.respond_to?(:death_handlers) && NewRelic::Agent.config[:'sidekiq.ignore_retry_errors']
+        config.death_handlers << proc do |_, error|
+          NewRelic::Agent.notice_error(error)
+        end
+      end
     end
   end
 end

data/lib/new_relic/agent/opentelemetry_bridge.rb

@@ -8,7 +8,7 @@ module NewRelic
       def initialize
         # no-op without OpenTelemetry API & config
         return unless defined?(OpenTelemetry) &&
-          NewRelic::Agent.config[:'opentelemetry_bridge.enabled']
+          NewRelic::Agent.config[:'opentelemetry.enabled']
 
         OpenTelemetryBridge.install
       end

data/lib/new_relic/agent/transaction/distributed_tracing.rb

@@ -161,6 +161,25 @@ module NewRelic
           transaction.parent_span_id = payload.id
 
           unless payload.sampled.nil?
+            if payload.sampled == true
+              set_priority_and_sampled_newrelic_header(NewRelic::Agent.config[:'distributed_tracing.sampler.remote_parent_sampled'], payload)
+            elsif payload.sampled == false
+              set_priority_and_sampled_newrelic_header(NewRelic::Agent.config[:'distributed_tracing.sampler.remote_parent_not_sampled'], payload)
+            else
+              transaction.sampled = payload.sampled
+              transaction.priority = payload.priority if payload.priority
+            end
+          end
+        end
+
+        def set_priority_and_sampled_newrelic_header(config, payload)
+          if config == 'always_on'
+            transaction.sampled = true
+            transaction.priority = 2.0
+          elsif config == 'always_off'
+            transaction.sampled = false
+            transaction.priority = 0
+          else # case for 'default' value
             transaction.sampled = payload.sampled
             transaction.priority = payload.priority if payload.priority
           end

data/lib/new_relic/agent/transaction/trace_context.rb

@@ -132,11 +132,17 @@ module NewRelic
           transaction.trace_id = header_data.trace_id
           transaction.parent_span_id = header_data.parent_id
 
-          return false unless payload = assign_trace_state_payload
+          trace_flags = header_data.trace_parent['trace_flags']
+          payload = assign_trace_state_payload
 
-          transaction.distributed_tracer.parent_transaction_id = payload.transaction_id
+          if payload
+            determine_sampling_decision(payload, trace_flags)
+          else
+            determine_sampling_decision(TraceContextPayload::INVALID, trace_flags)
+            return false
+          end
 
-          determine_sampling_decision(payload, header_data.trace_parent['trace_flags'])
+          transaction.distributed_tracer.parent_transaction_id = payload.transaction_id
 
           NewRelic::Agent.increment_metric(ACCEPT_SUCCESS_METRIC)
           true

data/lib/new_relic/version.rb

@@ -6,7 +6,7 @@
 module NewRelic
   module VERSION # :nodoc:
     MAJOR = 9
-    MINOR = 22
+    MINOR = 23
     TINY = 0
 
     STRING = "#{MAJOR}.#{MINOR}.#{TINY}"

data/newrelic.yml

@@ -791,6 +791,10 @@ common: &default_settings
   # will be included.
   # sidekiq.args.include: []
 
+  # If true, the agent will ignore exceptions raised during Sidekiq's retry
+  # attempts and will only report the error if the job permanently fails.
+  # sidekiq.ignore_retry_errors: false
+
   # If true, the agent collects slow SQL queries.
   # slow_sql.enabled: true
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: newrelic_rpm
 version: !ruby/object:Gem::Version
-  version: 9.22.0
+  version: 9.23.0
 platform: ruby
 authors:
 - Tanna McClure