newrelic_rpm 9.1.0 → 9.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 86b089be72e8fdf6af07082365c42ecfcbc6cc0c88df45cbac8238dca375af9c
-  data.tar.gz: e41f270e6d423755657678a0211cab7cb2a294d7f514d486b447b4c09c650fd7
+  metadata.gz: 24d17293feea3a15b482164d50f81a2f90a5540f25fee4d90e8472c1eb9d2f14
+  data.tar.gz: f8a2475b3a782c509dd417a7174b3067da223bc834236c97a99456bb96660ecc
 SHA512:
-  metadata.gz: f58684a973dd62ac5fb9b50309fd9ffc71ad2d14d2120902c8de8a3c1647abc99c376caeec6955708c5bbbc6989c687b753684523e02a0624dccc0a894285380
-  data.tar.gz: 4e6e538da76646d35f55af94bc037603cf3bb643396a21304ddc887d56d02802cd36a50aaaeafad03ea4c1f579248710919eff2e458b78d610c5820e219d8f34
+  metadata.gz: 6b2673019061b94d7800b6025ab88c9f6f096322f1309f3fac2d08c999731574f76997782b603327c4e2cb8ced6b45bfb02e47c2086f575dffe839607a8c92de
+  data.tar.gz: 7f7d7e8f5982346f59d22a19bfdabacbbf5a57fd907cc694078534ff45e1cadeaee8631d2a110a64e06874f94258cf0050c15534a9d5482f13fe295005fb22e9

data/.rubocop.yml

@@ -6,7 +6,7 @@ require:
   # Default performance configurations: https://github.com/rubocop/rubocop-performance/blob/master/config/default.yml
   - rubocop-performance
   # Default rake configurations: https://github.com/rubocop/rubocop-rake/blob/master/config/default.yml
-  <%= '- rubocop-rake' if RUBY_VERSION >= '2.4.0' %>
+  - rubocop-rake
 
 AllCops:
   TargetRubyVersion: 2.7
@@ -239,10 +239,6 @@ Layout/ClosingParenthesisIndentation:
 Layout/CommentIndentation:
   Enabled: true
 
-# Disabling for now
-Layout/ConditionPosition:
-  Enabled: false
-
 Layout/DefEndAlignment:
   Enabled: true
   EnforcedStyleAlignWith: start_of_line
@@ -261,19 +257,9 @@ Layout/EmptyComment:
   AllowBorderComment: true
   AllowMarginComment: true
 
-# Disabling for now
-Layout/EmptyLineAfterMagicComment:
-  Enabled: false
-
 Layout/EmptyLineAfterMultilineCondition:
   Enabled: false
 
-# Disabling for now
-Layout/EmptyLineBetweenDefs:
-  Enabled: false
-  # AllowAdjacentOneLineDefs: false
-  # NumberOfEmptyLines: 1
-
 Layout/EmptyLines:
   Enabled: true
 
@@ -362,10 +348,6 @@ Layout/HashAlignment:
 Layout/HeredocArgumentClosingParenthesis:
   Enabled: false
 
-# Disabling for now
-Layout/HeredocIndentation:
-  Enabled: false
-
 Layout/IndentationConsistency:
   Enabled: true
   EnforcedStyle: normal
@@ -505,11 +487,6 @@ Layout/SpaceBeforeFirstArg:
 Layout/SpaceBeforeSemicolon:
   Enabled: true
 
-# Disabling for now
-Layout/SpaceInLambdaLiteral:
-  Enabled: false
-  # EnforcedStyle: require_no_space
-
 Layout/SpaceInsideArrayLiteralBrackets:
   Enabled: true
   EnforcedStyle: no_space
@@ -533,10 +510,6 @@ Layout/SpaceInsideParens:
   Enabled: true
   EnforcedStyle: no_space
 
-# Disabling for now
-Layout/SpaceInsidePercentLiteralDelimiters:
-  Enabled: false
-
 Layout/SpaceInsideRangeLiteral:
   Enabled: true
 
@@ -563,40 +536,24 @@ Lint/AmbiguousAssignment:
 Lint/AmbiguousBlockAssociation:
   Enabled: false
 
-# Disabling for now
-Lint/AmbiguousOperator:
-  Enabled: false
-
 Lint/AmbiguousOperatorPrecedence:
   Enabled: false
 
 Lint/AmbiguousRange:
   Enabled: false
 
-# Disabling for now
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false
-
-# Disabling for now
 Lint/AssignmentInCondition:
   Enabled: false
-  # AllowSafeAssignment: true
 
 Lint/BigDecimalNew:
   Enabled: true
 
-# Disabling for now
 Lint/BinaryOperatorWithIdenticalOperands:
   Enabled: false
 
-# Disabling for now
-Lint/BooleanSymbol:
-  Enabled: false
-
 Lint/CircularArgumentReference:
   Enabled: true
 
-# Disabling for now
 Lint/ConstantDefinitionInBlock:
   Enabled: false
 
@@ -606,10 +563,6 @@ Lint/ConstantResolution:
 Lint/Debugger:
   Enabled: true
 
-# Disabling for now
-Lint/DeprecatedClassMethods:
-  Enabled: false
-
 Lint/DeprecatedConstants:
   Enabled: true
 
@@ -622,20 +575,12 @@ Lint/DisjunctiveAssignmentInConstructor:
 Lint/DuplicateBranch:
   Enabled: false
 
-# Disabling for now
-Lint/DuplicateCaseCondition:
-  Enabled: false
-
 Lint/DuplicateElsifCondition:
   Enabled: true
 
 Lint/DuplicateHashKey:
   Enabled: true
 
-# Disabling for now
-Lint/DuplicateMethods:
-  Enabled: false
-
 Lint/DuplicateRegexpCharacterClassElement:
   Enabled: true
 
@@ -660,11 +605,6 @@ Lint/EmptyClass:
 Lint/EmptyConditionalBody:
   Enabled: false
 
-# Disabling for now
-Lint/EmptyEnsure:
-  Enabled: false
-  # AutoCorrect: true
-
 Lint/EmptyExpression:
   Enabled: true
 
@@ -681,10 +621,6 @@ Lint/EmptyWhen:
   Enabled: true
   AllowComments: true
 
-# Disabling for now
-Lint/EnsureReturn:
-  Enabled: false
-
 Lint/ErbNewArguments:
   Enabled: true
 

data/.simplecov

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'securerandom'
 
 if ENV['CI']

data/Brewfile

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 brew 'elasticsearch'
 brew 'imagemagick'
 brew 'memcached'

data/CHANGELOG.md

@@ -1,5 +1,38 @@
 # New Relic Ruby Agent Release Notes
 
+## v9.2.1
+
+  Version 9.2.1 fixes a bug causing the agent to continue storing data on finished transactions, and a bug preventing errors from being expected.
+
+- **Bugfix: Finished transactions continue to store data on different threads**
+
+  Previously, when a new thread was spawned the agent would continue using the current transaction to record data on, even if this transaction had finished already in a different thread. Now the agent will only use the current transaction in the new thread if it is not yet finished. Thank you to [@fcheung](https://github.com/fcheung) for reporting this bug and providing us with an extremely helpful reproduction to debug. [PR#1969](https://github.com/newrelic/newrelic-ruby-agent/pull/1969)
+
+
+- **Bugfix: Expected Errors passed to notice_error are expected again**
+
+  A bug was introduced in 9.1.0 that caused to agent not to mark errors as expected if the error was passed in to `notice_error` using the `expected: true` parameter. This has been fixed and errors will now be marked as expected, as expected. Thank you very much to [@eiskrenkov](https://github.com/eiskrenkov) for finding this bug and contributing a fix for it! [PR#1954](https://github.com/newrelic/newrelic-ruby-agent/pull/1954)
+
+
+
+## v9.2.0
+
+  Version 9.2.0 of the agent introduces some performance improvements for working with high numbers of nested actions, and deprecates instrumentation for the `memcached` and `memcache-client` gems (with `dalli` still being supported).
+
+- **Feature: Enhance performance for handling high numbers of nested actions**
+
+  With [Issue#1910](https://github.com/newrelic/newrelic-ruby-agent/issues/1910) community members [@parkerfinch](https://github.com/parkerfinch) and [@travisbell](https://github.com/travisbell) informed us of some CPU spikes and process hangs seen only when using the agent's thread instrumentation, which was enabled by default with v9.0. When thread instrumentation is enabled, instrumented actions taking place within threads are seen and reported on by the agent whereas they would have previously gone unnoticed. This is a great improvement to the agent's usefulness in an async context, and also makes it easier for higher numbers of nested actions to be observed. 
+  For example, if an instrumented background job framework (Sidekiq, Resque) kicks off a job that the agent notices and then that job in turn performs actions such as database queries that the agent also instruments, nested actions are seen. However, with very high (10,000+) numbers of actions nested within a single instrumented outer action, the agent would struggle to efficiently crunch through all of the collected data at the time when the outer action finished. 
+  The agent should now be much more efficient when any observed action with lots of nested actions is finished. Our performance testing was conducted with hundreds of thousands of nested actions taking place, and we hope that the benefits of thread tracing can now be enjoyed without any drawbacks. Thanks very much [@parkerfinch](https://github.com/parkerfinch) and [@travisbell](https://github.com/travisbell)! [PR#1927](https://github.com/newrelic/newrelic-ruby-agent/pull/1927)
+
+- **Feature: The agent configuration will now reflect whether module prepending or method chaining was used for instrumentation**
+
+  For `:'instrumentation.*'` configuration parameters that are set to :auto (the default), the agent will automatically determine whether to use module prepending or method chaining. The agent will now update its in-memory configuration to give each relevant parameter a value of either :prepend or :chain so that the result of the determination can be introspected. This is intended to help 3rd party libraries that wish to further enhance the agent's instrumentation capabilities by prepending or chaining additional logic. Environment variable, YAML file, and server-side configuration based values are not impacted. [PR#1930](https://github.com/newrelic/newrelic-ruby-agent/pull/1930)
+
+- **Feature: Deprecate memcached and memcache-client instrumentation**
+
+  Instrumentation for the memcached and memcache-client libraries is deprecated and will be removed during the next major release.
+
 ## v9.1.0
 
   Version 9.1.0 of the agent delivers support for two new [errors inbox](https://docs.newrelic.com/docs/errors-inbox/errors-inbox/) features: error fingerprinting and user tracking, identifies the Amazon Timestream data store, removes Distributed Tracing warnings from agent logs when using Sidekiq, fixes bugs, and is tested against the recently released JRuby 9.4.2.0.

data/Guardfile

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require './test/multiverse/lib/multiverse/bundler_patch'
 
 test_folders = Dir.glob('test/new_relic/*').select { |f| File.directory?(f) }

data/bin/newrelic

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 # executes one of the commands in the new_relic/commands directory
 # pass the name of the command as an argument
 

data/bin/newrelic_cmd

@@ -1,5 +1,6 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
+
 # This command has been renamed "newrelic"
 # executes one of the commands in the new_relic/commands directory
 # pass the name of the command as an argument