newrelic_rpm 9.0.0 → 9.2.0

data/lib/new_relic/dependency_detection.rb

@@ -35,19 +35,6 @@ module DependencyDetection
     @items.find { |i| i.name == name }
   end
 
-  def installed?(name)
-    item = dependency_by_name(name)
-    item && item.executed
-  end
-
-  def items
-    @items
-  end
-
-  def items=(new_items)
-    @items = new_items
-  end
-
   class Dependent
     attr_reader :executed
     attr_accessor :name
@@ -83,7 +70,7 @@ module DependencyDetection
     # Given "NewRelic::Agent::Instrumentation::NetHTTP::Prepend"
     # Will extract "NetHTTP" which is in the 2nd to last spot
     def extract_supportability_name(instrumenting_module)
-      instrumenting_module.to_s.split("::")[-2]
+      instrumenting_module.to_s.split('::')[-2]
     end
 
     def log_and_instrument(method, instrumenting_module, supportability_name)
@@ -94,20 +81,20 @@ module DependencyDetection
     end
 
     def prepend_instrument(target_class, instrumenting_module, supportability_name = nil)
-      log_and_instrument("Prepend", instrumenting_module, supportability_name) do
+      log_and_instrument('Prepend', instrumenting_module, supportability_name) do
         target_class.send(:prepend, instrumenting_module)
       end
     end
 
     def chain_instrument(instrumenting_module, supportability_name = nil)
-      log_and_instrument("MethodChaining", instrumenting_module, supportability_name) do
+      log_and_instrument('MethodChaining', instrumenting_module, supportability_name) do
         instrumenting_module.instrument!
       end
     end
 
     def chain_instrument_target(target, instrumenting_module, supportability_name = nil)
       NewRelic::Agent.logger.info("Installing deferred #{target} instrumentation")
-      log_and_instrument("MethodChaining", instrumenting_module, supportability_name) do
+      log_and_instrument('MethodChaining', instrumenting_module, supportability_name) do
         instrumenting_module.instrument!(target)
       end
     end

data/lib/new_relic/environment_report.rb

@@ -52,7 +52,7 @@ module NewRelic
         # though so try it if the above fails.
         Bundler.load.specs.map do |spec|
           version = (spec.respond_to?(:version) && spec.version)
-          spec.name + (version ? "(#{version})" : "")
+          spec.name + (version ? "(#{version})" : '')
         end
       end
     end
@@ -118,19 +118,19 @@ module NewRelic
     def record_value(data, key, value)
       data[key] = value
 
-      Agent.record_metric("Supportability/EnvironmentReport/success", 0.0)
+      Agent.record_metric('Supportability/EnvironmentReport/success', 0.0)
       Agent.record_metric("Supportability/EnvironmentReport/success/#{key}", 0.0)
     end
 
     def record_empty_value(key, value)
       Agent.logger.debug("EnvironmentReport ignoring value for #{key.inspect} which came back falsey: #{value.inspect}")
-      Agent.record_metric("Supportability/EnvironmentReport/empty", 0.0)
+      Agent.record_metric('Supportability/EnvironmentReport/empty', 0.0)
       Agent.record_metric("Supportability/EnvironmentReport/empty/#{key}", 0.0)
     end
 
     def rescue_initialize(key, exception)
       Agent.logger.debug("EnvironmentReport failed to retrieve value for #{key.inspect}: #{exception}")
-      Agent.record_metric("Supportability/EnvironmentReport/error", 0.0)
+      Agent.record_metric('Supportability/EnvironmentReport/error', 0.0)
       Agent.record_metric("Supportability/EnvironmentReport/error/#{key}", 0.0)
     end
   end

data/lib/new_relic/helper.rb

@@ -63,7 +63,8 @@ module NewRelic
         raise NewRelic::CommandRunFailedError.new("Failed to run command '#{command}': #{message}")
       end
 
-      output.chomp if output
+      # needs else branch coverage
+      output.chomp if output # rubocop:disable Style/SafeNavigation
     end
 
     # TODO: Open3 defers the actual execution of a binary to Process.spawn,

data/lib/new_relic/language_support.rb

@@ -62,7 +62,7 @@ module NewRelic
           #
           # Can't help if the constant isn't a class...
           if result.is_a?(Module)
-            expected_name = "#{namespace}::#{name}".gsub(/^Object::/, "")
+            expected_name = "#{namespace}::#{name}".gsub(/^Object::/, '')
             return unless expected_name == result.to_s
           end
 

data/lib/new_relic/latest_changes.rb

@@ -26,12 +26,12 @@ EOS
     # * This is a patch item (3.7.1.188)
     def self.read_patch(patch_level, changelog = default_changelog)
       latest = extract_latest_changes(File.read(changelog))
-      changes = ["## v#{patch_level}", ""]
+      changes = ["## v#{patch_level}", '']
 
       current_item = nil
       latest.each do |line|
-        if line =~ /^\s*\*.*/
-          if line =~ /\(#{patch_level}\)/
+        if /^\s*\*.*/.match?(line)
+          if /\(#{patch_level}\)/.match?(line)
             # Found a patch level item, so start tracking the lines!
             current_item = line
           else
@@ -52,12 +52,12 @@ EOS
       changes = []
       version_count = 0
       contents.each_line do |line|
-        if line =~ /##\s+v[\d.]+/
+        if /##\s+v[\d.]+/.match?(line)
           version_count += 1
         end
         break if version_count >= 2
 
-        changes << line.sub(/^  \* /, "* ").chomp
+        changes << line.sub(/^  \* /, '* ').chomp
       end
       changes
     end

data/lib/new_relic/noticed_error.rb

@@ -15,18 +15,20 @@ class NewRelic::NoticedError
     :stack_trace, :attributes_from_notice_error, :attributes,
     :expected
 
-  attr_reader :exception_id, :is_internal
+  attr_reader :error_group, :exception_id, :is_internal
 
   STRIPPED_EXCEPTION_REPLACEMENT_MESSAGE = "Message removed by New Relic 'strip_exception_messages' setting"
   UNKNOWN_ERROR_CLASS_NAME = 'Error'
   NIL_ERROR_MESSAGE = '<no message>'
 
-  USER_ATTRIBUTES = "userAttributes"
-  AGENT_ATTRIBUTES = "agentAttributes"
-  INTRINSIC_ATTRIBUTES = "intrinsics"
+  USER_ATTRIBUTES = 'userAttributes'
+  AGENT_ATTRIBUTES = 'agentAttributes'
+  INTRINSIC_ATTRIBUTES = 'intrinsics'
 
   DESTINATION = NewRelic::Agent::AttributeFilter::DST_ERROR_COLLECTOR
 
+  AGENT_ATTRIBUTE_ERROR_GROUP = :'error.group.name'
+
   ERROR_PREFIX_KEY = 'error'
   ERROR_MESSAGE_KEY = "#{ERROR_PREFIX_KEY}.message"
   ERROR_CLASS_KEY = "#{ERROR_PREFIX_KEY}.class"
@@ -141,21 +143,9 @@ class NewRelic::NoticedError
   end
 
   def build_agent_attributes(merged_attributes)
-    agent_attributes = if @attributes
-      @attributes.agent_attributes_for(DESTINATION)
-    else
-      NewRelic::EMPTY_HASH
-    end
-
-    # It's possible to override the request_uri from the transaction attributes
-    # with a uri passed to notice_error. Add it to merged_attributes filter and
-    # merge with the transaction attributes, possibly overriding the request_uri
-    if request_uri
-      merged_attributes.add_agent_attribute(:'request.uri', request_uri, DESTINATION)
-      agent_attributes.merge(merged_attributes.agent_attributes_for(DESTINATION))
-    end
+    return NewRelic::EMPTY_HASH unless @attributes
 
-    agent_attributes
+    @attributes.agent_attributes_for(DESTINATION)
   end
 
   def build_intrinsic_attributes
@@ -197,4 +187,16 @@ class NewRelic::NoticedError
       @message = exception.to_s
     end
   end
+
+  def error_group=(name)
+    return if name.nil? || name.empty?
+
+    if agent_attributes.frozen?
+      processed_attributes[AGENT_ATTRIBUTES] = agent_attributes.merge(AGENT_ATTRIBUTE_ERROR_GROUP => name)
+    else
+      agent_attributes[AGENT_ATTRIBUTE_ERROR_GROUP] = name
+    end
+
+    @error_group = name
+  end
 end

data/lib/new_relic/rack/browser_monitoring.rb

@@ -26,11 +26,11 @@ module NewRelic
       ATTACHMENT = 'attachment'.freeze
       TEXT_HTML = 'text/html'.freeze
 
-      BODY_START = "<body".freeze
-      HEAD_START = "<head".freeze
-      GT = ">".freeze
+      BODY_START = '<body'.freeze
+      HEAD_START = '<head'.freeze
+      GT = '>'.freeze
 
-      ALREADY_INSTRUMENTED_KEY = "newrelic.browser_monitoring_already_instrumented"
+      ALREADY_INSTRUMENTED_KEY = 'newrelic.browser_monitoring_already_instrumented'
       CHARSET_RE = /<\s*meta[^>]+charset\s*=[^>]*>/im.freeze
       X_UA_COMPATIBLE_RE = /<\s*meta[^>]+http-equiv\s*=\s*['"]x-ua-compatible['"][^>]*>/im.freeze
 
@@ -40,7 +40,7 @@ module NewRelic
 
         js_to_inject = NewRelic::Agent.browser_timing_header
         if (js_to_inject != NewRelic::EMPTY_STR) && should_instrument?(env, status, headers)
-          response_string = autoinstrument_source(response, headers, js_to_inject)
+          response_string = autoinstrument_source(response, js_to_inject)
           if headers.key?(CONTENT_LENGTH)
             content_length = response_string ? response_string.bytesize : 0
             headers[CONTENT_LENGTH] = content_length.to_s
@@ -69,11 +69,17 @@ module NewRelic
 
       private
 
-      def autoinstrument_source(response, headers, js_to_inject)
+      def autoinstrument_source(response, js_to_inject)
         source = gather_source(response)
         close_old_response(response)
-        return nil unless source
+        return unless source
 
+        modify_source(source, js_to_inject)
+      rescue => e
+        NewRelic::Agent.logger.debug("Skipping RUM instrumentation on exception: #{e.class} - #{e.message}")
+      end
+
+      def modify_source(source, js_to_inject)
         # Only scan the first 50k (roughly) then give up.
         beginning_of_source = source[0..SCAN_LIMIT]
         meta_tag_positions = find_meta_tag_positions(beginning_of_source)
@@ -81,26 +87,24 @@ module NewRelic
           if insertion_index = find_insertion_index(meta_tag_positions, beginning_of_source, body_start)
             source = source_injection(source, insertion_index, js_to_inject)
           else
-            NewRelic::Agent.logger.debug("Skipping RUM instrumentation. Could not properly determine location to inject script.")
+            NewRelic::Agent.logger.debug('Skipping RUM instrumentation. Could not properly determine location to ' \
+                                         'inject script.')
           end
         else
           msg = "Skipping RUM instrumentation. Unable to find <body> tag in first #{SCAN_LIMIT} bytes of document."
           NewRelic::Agent.logger.log_once(:warn, :rum_insertion_failure, msg)
           NewRelic::Agent.logger.debug(msg)
         end
-
         source
-      rescue => e
-        NewRelic::Agent.logger.debug("Skipping RUM instrumentation on exception.", e)
-        nil
       end
 
       def html?(headers)
-        headers[CONTENT_TYPE] && headers[CONTENT_TYPE].include?(TEXT_HTML)
+        # needs else branch coverage
+        headers[CONTENT_TYPE] && headers[CONTENT_TYPE].include?(TEXT_HTML) # rubocop:disable Style/SafeNavigation
       end
 
       def attachment?(headers)
-        headers[CONTENT_DISPOSITION] && headers[CONTENT_DISPOSITION].include?(ATTACHMENT)
+        headers[CONTENT_DISPOSITION]&.include?(ATTACHMENT)
       end
 
       def streaming?(env, headers)
@@ -150,12 +154,12 @@ module NewRelic
 
       def find_x_ua_compatible_position(beginning_of_source)
         match = X_UA_COMPATIBLE_RE.match(beginning_of_source)
-        match.end(0) if match
+        match&.end(0)
       end
 
       def find_charset_position(beginning_of_source)
         match = CHARSET_RE.match(beginning_of_source)
-        match.end(0) if match
+        match&.end(0)
       end
 
       def find_end_of_head_open(beginning_of_source)

data/lib/new_relic/recipes/capistrano3.rb

@@ -8,7 +8,7 @@ require_relative 'helpers/send_deployment'
 namespace :newrelic do
   include SendDeployment
   # notifies New Relic of a deployment
-  desc "Record a deployment in New Relic (newrelic.com)"
+  desc 'Record a deployment in New Relic (newrelic.com)'
   task :notice_deployment do
     if fetch(:newrelic_role)
       on roles(fetch(:newrelic_role)) do

data/lib/new_relic/recipes/capistrano_legacy.rb

@@ -5,9 +5,9 @@
 make_notify_task = proc do
   namespace(:newrelic) do
     # on all deployments, notify New Relic
-    desc("Record a deployment in New Relic (newrelic.com)")
+    desc('Record a deployment in New Relic (newrelic.com)')
     task(:notice_deployment, :roles => :app, :except => {:no_release => true}) do
-      rails_env = fetch(:newrelic_rails_env, fetch(:rails_env, "production"))
+      rails_env = fetch(:newrelic_rails_env, fetch(:rails_env, 'production'))
 
       require 'new_relic/cli/command'
 
@@ -36,14 +36,14 @@ make_notify_task = proc do
           :license_key => license_key
         }
 
-        logger.debug("Uploading deployment to New Relic")
+        logger.debug('Uploading deployment to New Relic')
         deployment = NewRelic::Cli::Deployments.new(deploy_options)
         deployment.run
-        logger.info("Uploaded deployment information to New Relic")
+        logger.info('Uploaded deployment information to New Relic')
       rescue NewRelic::Cli::Command::CommandFailure => e
         logger.info(e.message)
       rescue Capistrano::CommandError
-        logger.info("Unable to notify New Relic of the deployment... skipping")
+        logger.info('Unable to notify New Relic of the deployment... skipping')
       rescue => e
         logger.info("Error creating New Relic deployment (#{e})\n#{e.backtrace.join("\n")}")
       end
@@ -51,7 +51,7 @@ make_notify_task = proc do
 
     def lookup_changelog(changelog)
       if !changelog
-        logger.debug("Getting log of changes for New Relic Deployment details")
+        logger.debug('Getting log of changes for New Relic Deployment details')
         from_revision = source.next_revision(current_revision)
 
         if scm == :git

data/lib/new_relic/recipes/helpers/send_deployment.rb

@@ -5,9 +5,9 @@
 module SendDeployment
   def send_deployment_notification_to_newrelic
     require 'new_relic/cli/command'
-    debug("Uploading deployment to New Relic")
+    debug('Uploading deployment to New Relic')
     NewRelic::Cli::Deployments.new(deploy_options).run
-    info("Uploaded deployment information to New Relic")
+    info('Uploaded deployment information to New Relic')
   rescue NewRelic::Cli::Command::CommandFailure => e
     info(e.message)
   rescue => e
@@ -34,7 +34,7 @@ module SendDeployment
   end
 
   def fetch_environment
-    fetch(:newrelic_rails_env, fetch(:rack_env, fetch(:rails_env, fetch(:stage, "production"))))
+    fetch(:newrelic_rails_env, fetch(:rack_env, fetch(:rails_env, fetch(:stage, 'production'))))
   end
 
   def fetch_rev
@@ -59,9 +59,9 @@ module SendDeployment
     current_revision = fetch(:current_revision)
     return unless current_revision && previous_revision
 
-    debug("Retrieving changelog for New Relic Deployment details")
+    debug('Retrieving changelog for New Relic Deployment details')
 
-    if Rake::Task.task_defined?("git:check")
+    if Rake::Task.task_defined?('git:check')
       log_command = "git --no-pager log --no-color --pretty=format:'  * %an: %s' " +
         "--abbrev-commit --no-merges #{previous_revision}..#{current_revision}"
       `#{log_command}`

data/lib/new_relic/supportability_helper.rb

@@ -44,8 +44,10 @@ module NewRelic
       :record_metric,
       :recording_web_transaction?,
       :require_test_helper,
+      :set_error_group_callback,
       :set_sql_obfuscator,
       :set_transaction_name,
+      :set_user_id,
       :shutdown,
       :start_segment,
       :trace,

data/lib/new_relic/version.rb

@@ -6,7 +6,7 @@
 module NewRelic
   module VERSION # :nodoc:
     MAJOR = 9
-    MINOR = 0
+    MINOR = 2
     TINY = 0
 
     STRING = "#{MAJOR}.#{MINOR}.#{TINY}"

data/lib/newrelic_rpm.rb

@@ -21,16 +21,16 @@ if defined?(Rails::VERSION)
   module NewRelic
     class Railtie < Rails::Railtie
       if ENV['NEW_RELIC_DEFER_RAILS_INITIALIZATION']
-        initializer "newrelic_rpm.include_method_tracers", before: :load_config_initializers do |app|
+        initializer 'newrelic_rpm.include_method_tracers', before: :load_config_initializers do |app|
           Module.send(:include, NewRelic::Agent::MethodTracer::ClassMethods)
           Module.send(:include, NewRelic::Agent::MethodTracer)
         end
 
-        initializer "newrelic_rpm.start_plugin", after: :load_config_initializers do |app|
+        initializer 'newrelic_rpm.start_plugin', after: :load_config_initializers do |app|
           NewRelic::Control.instance.init_plugin(config: app.config)
         end
       else
-        initializer "newrelic_rpm.start_plugin", before: :load_config_initializers do |app|
+        initializer 'newrelic_rpm.start_plugin', before: :load_config_initializers do |app|
           NewRelic::Control.instance.init_plugin(config: app.config)
         end
       end

data/lib/sequel/extensions/new_relic_instrumentation.rb

@@ -32,7 +32,7 @@ module Sequel
   module NewRelicInstrumentation
     module Naming
       def self.query_method_name
-        if Sequel::VERSION >= "4.35.0"
+        if Sequel::VERSION >= '4.35.0'
           :log_connection_yield
         else
           :log_yield
@@ -86,13 +86,13 @@ module Sequel
         if THREAD_SAFE_CONNECTION_POOL_CLASSES.include?(self.pool.class)
           self[sql].explain
         else
-          NewRelic::Agent.logger.log_once(:info, :sequel_explain_skipped, "Not running SQL explains because Sequel is not in recognized multi-threaded mode")
+          NewRelic::Agent.logger.log_once(:info, :sequel_explain_skipped, 'Not running SQL explains because Sequel is not in recognized multi-threaded mode')
           nil
         end
       end
     end
   end # module NewRelicInstrumentation
 
-  NewRelic::Agent.logger.debug("Registering the :new_relic_instrumentation extension.")
+  NewRelic::Agent.logger.debug('Registering the :new_relic_instrumentation extension.')
   Database.register_extension(:new_relic_instrumentation, NewRelicInstrumentation)
 end # module Sequel

data/lib/sequel/plugins/new_relic_instrumentation.rb

@@ -54,7 +54,7 @@ module Sequel
       module ClassMethods
         extend Sequel::Plugins::NewRelicInstrumentation::MethodWrapping
 
-        wrap_sequel_method :[], "get"
+        wrap_sequel_method :[], 'get'
         wrap_sequel_method :all
         wrap_sequel_method :first
         wrap_sequel_method :create

data/lib/tasks/config.rake

@@ -7,9 +7,9 @@ include Format
 
 namespace :newrelic do
   namespace :config do
-    GENERAL = "general"
-    DISABLING = "disabling"
-    ATTRIBUTES = "attributes"
+    GENERAL = 'general'
+    DISABLING = 'disabling'
+    ATTRIBUTES = 'attributes'
 
     # these configuration options are not able to be set using environment variables
     NON_ENV_CONFIGS = ['error_collector.ignore_classes', 'error_collector.ignore_messages', 'error_collector.expected_classes', 'error_collector.expected_messages']
@@ -18,21 +18,21 @@ namespace :newrelic do
       GENERAL => 'These settings are available for agent configuration. Some settings depend on your New Relic subscription level.',
       DISABLING => 'Use these settings to toggle instrumentation types during agent startup.',
       ATTRIBUTES => '[Attributes](/docs/features/agent-attributes) are key-value pairs containing information that determines the properties of an event or transaction. These key-value pairs can be viewed within transaction traces in APM, traced errors in APM, transaction events in dashboards, and page views in dashboards. You can customize exactly which attributes will be sent to each of these destinations',
-      "transaction_tracer" => 'The [transaction traces](/docs/apm/traces/transaction-traces/transaction-traces) feature collects detailed information from a selection of transactions, including a summary of the calling sequence, a breakdown of time spent, and a list of SQL queries and their query plans (on mysql and postgresql). Available features depend on your New Relic subscription level.',
-      "error_collector" => "The agent collects and reports all uncaught exceptions by default. These configuration options allow you to customize the error collection.\n\nFor information on ignored and expected errors, [see this page on Error Analytics in APM](/docs/agents/manage-apm-agents/agent-data/manage-errors-apm-collect-ignore-or-mark-expected/). To set expected errors via the `NewRelic::Agent.notice_error` Ruby method, [consult the Ruby Agent API](/docs/agents/ruby-agent/api-guides/sending-handled-errors-new-relic/).",
-      "browser_monitoring" => "The browser monitoring [page load timing](/docs/browser/new-relic-browser/page-load-timing/page-load-timing-process) feature (sometimes referred to as real user monitoring or RUM) gives you insight into the performance real users are experiencing with your website. This is accomplished by measuring the time it takes for your users' browsers to download and render your web pages by injecting a small amount of JavaScript code into the header and footer of each page.",
-      "analytics_events" => '[New Relic dashboards](/docs/query-your-data/explore-query-data/dashboards/introduction-new-relic-one-dashboards) is a resource to gather and visualize data about your software and what it says about your business. With it you can quickly and easily create real-time dashboards to get immediate answers about end-user experiences, clickstreams, mobile activities, and server transactions.'
+      'transaction_tracer' => 'The [transaction traces](/docs/apm/traces/transaction-traces/transaction-traces) feature collects detailed information from a selection of transactions, including a summary of the calling sequence, a breakdown of time spent, and a list of SQL queries and their query plans (on mysql and postgresql). Available features depend on your New Relic subscription level.',
+      'error_collector' => "The agent collects and reports all uncaught exceptions by default. These configuration options allow you to customize the error collection.\n\nFor information on ignored and expected errors, [see this page on Error Analytics in APM](/docs/agents/manage-apm-agents/agent-data/manage-errors-apm-collect-ignore-or-mark-expected/). To set expected errors via the `NewRelic::Agent.notice_error` Ruby method, [consult the Ruby Agent API](/docs/agents/ruby-agent/api-guides/sending-handled-errors-new-relic/).",
+      'browser_monitoring' => "The browser monitoring [page load timing](/docs/browser/new-relic-browser/page-load-timing/page-load-timing-process) feature (sometimes referred to as real user monitoring or RUM) gives you insight into the performance real users are experiencing with your website. This is accomplished by measuring the time it takes for your users' browsers to download and render your web pages by injecting a small amount of JavaScript code into the header and footer of each page.",
+      'analytics_events' => '[New Relic dashboards](/docs/query-your-data/explore-query-data/dashboards/introduction-new-relic-one-dashboards) is a resource to gather and visualize data about your software and what it says about your business. With it you can quickly and easily create real-time dashboards to get immediate answers about end-user experiences, clickstreams, mobile activities, and server transactions.'
     }
 
     NAME_OVERRIDES = {
-      "slow_sql" => "Slow SQL",
-      "custom_insights_events" => "Custom Events"
+      'slow_sql' => 'Slow SQL',
+      'custom_insights_events' => 'Custom Events'
     }
 
-    desc "Describe available New Relic configuration settings"
+    desc 'Describe available New Relic configuration settings'
     task :docs, [:format] => [] do |t, args|
-      require File.expand_path(File.join(File.dirname(__FILE__), "..", "new_relic", "agent", "configuration", "default_source.rb"))
-      format = args[:format] || "text"
+      require File.expand_path(File.join(File.dirname(__FILE__), '..', 'new_relic', 'agent', 'configuration', 'default_source.rb'))
+      format = args[:format] || 'text'
       output(format)
     end
   end

data/lib/tasks/coverage_report.rake

@@ -1,10 +1,10 @@
-# frozen_string_literal: true
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 if ENV['CI']
   namespace :coverage do
-    desc "Collates all result sets generated by the different test runners"
+    desc 'Collates all result sets generated by the different test runners'
     task :report do
       require 'simplecov'
       require 'fileutils'
@@ -19,10 +19,10 @@ if ENV['CI']
       Dir['lib/coverage_{[!r][!e][!s][!u][!l][!t][!s]}*'].each { |dir| FileUtils.rm_rf(dir) }
     end
 
-    desc "Removes all coverage_* directories"
+    desc 'Removes all coverage_* directories'
     task :clear do
       require 'fileutils'
-      Dir["lib/coverage_*"].each { |dir| FileUtils.rm_rf(dir) }
+      Dir['lib/coverage_*'].each { |dir| FileUtils.rm_rf(dir) }
     end
   end
 end

data/lib/tasks/helpers/format.rb

@@ -66,24 +66,24 @@ module Format
 
   def format_description(value)
     description = ''
-    description += "<b>DEPRECATED</b> " if value[:deprecated]
+    description += '<b>DEPRECATED</b> ' if value[:deprecated]
     description += value[:description]
     description
   end
 
   def format_env_var(key)
-    return "None" if NON_ENV_CONFIGS.include?(key)
+    return 'None' if NON_ENV_CONFIGS.include?(key)
 
-    "NEW_RELIC_#{key.tr(".", "_").upcase}"
+    "NEW_RELIC_#{key.tr('.', '_').upcase}"
   end
 
   def format_name(key)
     name = NAME_OVERRIDES[key]
     return name if name
 
-    key.split("_")
+    key.split('_')
       .each { |fragment| fragment[0] = fragment[0].upcase }
-      .join(" ")
+      .join(' ')
   end
 
   def format_sections(key, value)
@@ -98,7 +98,7 @@ module Format
 
   def format_type(type)
     if type == NewRelic::Agent::Configuration::Boolean
-      "Boolean"
+      'Boolean'
     else
       type
     end
@@ -110,11 +110,11 @@ module Format
   end
 
   def section_key(key, components)
-    if key =~ /^disable_/ # "disable_httpclient"
+    if /^disable_/.match?(key) # "disable_httpclient"
       DISABLING
-    elsif components.length >= 2 && !(components[1] == "attributes") # "analytics_events.enabled"
+    elsif components.length >= 2 && !(components[1] == 'attributes') # "analytics_events.enabled"
       components.first
-    elsif components[1] == "attributes" # "transaction_tracer.attributes.enabled"
+    elsif components[1] == 'attributes' # "transaction_tracer.attributes.enabled"
       ATTRIBUTES
     else
       GENERAL

data/lib/tasks/helpers/removers.rb

@@ -11,21 +11,21 @@ module Removers
       `echo "drop database #{database}" | mysql -u root`
     end
   rescue => error
-    puts "ERROR: Cannot get MySQL databases..."
+    puts 'ERROR: Cannot get MySQL databases...'
     puts error.message
   end
 
   def remove_generated_gemfiles
-    file_path = File.expand_path("test/multiverse/suites")
-    Dir.glob(File.join(file_path, "**", "Gemfile*")).each do |fn|
+    file_path = File.expand_path('test/multiverse/suites')
+    Dir.glob(File.join(file_path, '**', 'Gemfile*')).each do |fn|
       puts "Removing #{fn.gsub(file_path, '.../suites')}"
       FileUtils.rm(fn)
     end
   end
 
   def remove_generated_gemfile_lockfiles
-    file_path = File.expand_path("test/environments")
-    Dir.glob(File.join(file_path, "**", "Gemfile.lock")).each do |fn|
+    file_path = File.expand_path('test/environments')
+    Dir.glob(File.join(file_path, '**', 'Gemfile.lock')).each do |fn|
       puts "Removing #{fn.gsub(file_path, '.../environments')}"
       FileUtils.rm(fn)
     end

data/lib/tasks/install.rake

@@ -3,13 +3,13 @@
 # frozen_string_literal: true
 
 namespace :newrelic do
-  desc "Install a default config/newrelic.yml file"
+  desc 'Install a default config/newrelic.yml file'
   task :install do
-    load File.expand_path(File.join(File.dirname(__FILE__), "..", "..", "install.rb"))
+    load File.expand_path(File.join(File.dirname(__FILE__), '..', '..', 'install.rb'))
   end
 
-  desc "Gratefulness is always appreciated"
+  desc 'Gratefulness is always appreciated'
   task :thanks do
-    puts "The Ruby agent team is grateful to Jim Weirich for his kindness and his code. He will be missed."
+    puts 'The Ruby agent team is grateful to Jim Weirich for his kindness and his code. He will be missed.'
   end
 end