newrelic_rpm 8.9.0 → 8.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e16c313766a7d9c51bc1a1c3031f666747b4a3aefa773cf226d28510d90d6658
-  data.tar.gz: cb464a40400ce3b4a41178f737fa804952bfe22de66dc88f73deccaa256520a6
+  metadata.gz: 5293c4968708ee7ff95720c57446722d8649e7095fd44f03b88f562d156b7cbf
+  data.tar.gz: df7b918b393af7aa8852bbb2867e0f7468a0ce7e78316f3a0cb8e0cedeb2aaeb
 SHA512:
-  metadata.gz: 93915783c6110bbc027d03d614b5ad582ba0bf73b93933d4a93f11a7e698fd82436c74b3b941c27846e6e1ae408b7d8929b9c1d7dcae0e6103ed3ded2836c9c2
-  data.tar.gz: f7a5196e10ecd5dd88ed16b218cdcb760511d3747f1c821ccc7f4b6c5e22c28a1e08d581022513d04e6540d6d5cd62419cc587c05c8154d4a7abe6a574944a97
+  metadata.gz: 863115396ffd0b911d11da3d0ccbe8a4e7bc98f6d406080261c4a41272a78139406146524e0f3f121ae0f729635235b40c8666caf8b70b9e20182d82b178789c
+  data.tar.gz: 24f7b15184ec2fd778712a215e4f6fc7d029c37b3cfb3f1efe9d0d085999abe2e795b6f644c6ac420904de3a5c7759797e462c94deb73173566c536c8bf3cb54

data/.gitignore

@@ -16,6 +16,7 @@ tags
 *.swo
 
 coverage
+coverage_*
 /doc/
 /log/
 /lerg/

data/.rubocop.yml

@@ -1,5 +1,12 @@
+inherit_from: .rubocop_todo.yml
+
 require:
+  # Default minitest configurations: https://github.com/rubocop/rubocop-minitest/blob/master/config/default.yml
+  - rubocop-minitest
+  # Default performance configurations: https://github.com/rubocop/rubocop-performance/blob/master/config/default.yml
   - rubocop-performance
+  # Default rake configurations: https://github.com/rubocop/rubocop-rake/blob/master/config/default.yml
+  <%= '- rubocop-rake' if RUBY_VERSION >= '2.4.0' %>
 
 AllCops:
   TargetRubyVersion: 2.7
@@ -256,7 +263,9 @@ Layout/LineEndStringConcatenationIndentation:
   Enabled: false
 
 Layout/LineLength:
-  Enabled: false
+  # TODO: get this down to something closer to the 80 col ideal
+  #       we should be able to manage 120
+  Max: 576
 
 Layout/MultilineArrayBraceLayout:
   Enabled: true
@@ -1361,9 +1370,6 @@ Style/FormatString:
 Style/FormatStringToken:
   Enabled: false
 
-Style/FrozenStringLiteralComment:
-  Enabled: false
-
 # Disabling for now
 Style/GlobalStdStream:
   Enabled: false
@@ -1468,18 +1474,27 @@ Style/MapToHash:
   Enabled: false
 
 Style/MethodCallWithArgsParentheses:
-  Enabled: false
+  Enabled: true
+  AllowedMethods:
+    - puts
+    - require
+    - raise
+    - include
+    - fail
+    - print
+    - add_dependency
+    - add_development_dependency
+  AllowedPatterns: [^assert, ^refute]
 
-# Disabling for now
 Style/MethodCallWithoutArgsParentheses:
   Enabled: false
-  IgnoredMethods: []
+  AllowedMethods: []
 
 Style/MethodCalledOnDoEndBlock:
   Enabled: false
 
 Style/MethodDefParentheses:
-  Enabled: false
+  Enabled: true
 
 Style/MinMax:
   Enabled: false

data/.rubocop_todo.yml

@@ -0,0 +1,243 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2022-09-09 22:01:39 UTC using RuboCop version 1.36.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: empty_lines, no_empty_lines
+Layout/EmptyLinesAroundBlockBody:
+  Exclude:
+    - 'test/multiverse/suites/active_record/db/schema.rb'
+    - 'test/multiverse/suites/active_record_pg/db/schema.rb'
+
+# Offense count: 52
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/AssertEmptyLiteral:
+  Enabled: false
+
+# Offense count: 13
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/AssertEqual:
+  Exclude:
+    - 'test/multiverse/suites/config_file_loading/config_file_loading_test.rb'
+    - 'test/new_relic/agent/configuration/default_source_test.rb'
+    - 'test/new_relic/agent/error_trace_aggregator_test.rb'
+    - 'test/new_relic/agent/method_tracer_helpers_test.rb'
+    - 'test/new_relic/agent/method_tracer_test.rb'
+    - 'test/new_relic/agent/transaction_sampler_test.rb'
+    - 'test/new_relic/metric_data_test.rb'
+
+# Offense count: 145
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/AssertInDelta:
+  Enabled: false
+
+# Offense count: 22
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/AssertIncludes:
+  Exclude:
+    - 'test/agent_helper.rb'
+    - 'test/multiverse/suites/rails/active_support_logger_test.rb'
+    - 'test/multiverse/suites/sequel/sequel_plugin_test.rb'
+    - 'test/multiverse/suites/sinatra_agent_disabled/shim_test.rb'
+    - 'test/new_relic/agent/audit_logger_test.rb'
+    - 'test/new_relic/agent/configuration/manager_test.rb'
+    - 'test/new_relic/agent/configuration/orphan_configuration_test.rb'
+    - 'test/new_relic/agent/error_trace_aggregator_test.rb'
+    - 'test/new_relic/agent/javascript_instrumentor_test.rb'
+    - 'test/new_relic/agent/method_visibility_test.rb'
+    - 'test/new_relic/agent/sampler_test.rb'
+    - 'test/new_relic/agent/tracer_state_test.rb'
+    - 'test/new_relic/control/instance_methods_test.rb'
+    - 'test/new_relic/environment_report_test.rb'
+    - 'test/new_relic/metric_data_test.rb'
+
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/AssertKindOf:
+  Exclude:
+    - 'test/new_relic/agent/agent_test.rb'
+    - 'test/new_relic/agent/pipe_channel_manager_test.rb'
+    - 'test/new_relic/agent_test.rb'
+
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/AssertNil:
+  Exclude:
+    - 'test/multiverse/suites/agent_only/log_events_test.rb'
+
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/AssertPathExists:
+  Exclude:
+    - 'infinite_tracing/test/support/fixtures.rb'
+    - 'test/multiverse/suites/mongo/helpers/mongo_server_test.rb'
+
+# Offense count: 140
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/AssertPredicate:
+  Enabled: false
+
+# Offense count: 6
+Minitest/AssertRaisesCompoundBody:
+  Exclude:
+    - 'test/new_relic/agent/collector_response_code_test.rb'
+    - 'test/new_relic/agent/new_relic_service_test.rb'
+    - 'test/new_relic/cli/commands/deployments_test.rb'
+
+# Offense count: 9
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/AssertRespondTo:
+  Exclude:
+    - 'test/multiverse/suites/sequel/sequel_plugin_test.rb'
+    - 'test/multiverse/suites/sinatra_agent_disabled/shim_test.rb'
+    - 'test/new_relic/agent/configuration/default_source_test.rb'
+    - 'test/new_relic/collection_helper_test.rb'
+    - 'test/new_relic/data_container_tests.rb'
+
+# Offense count: 35
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/AssertTruthy:
+  Exclude:
+    - 'test/multiverse/suites/agent_only/error_events_test.rb'
+    - 'test/multiverse/suites/rack/puma_rack_urlmap_test.rb'
+    - 'test/multiverse/suites/sequel/sequel_safety_test.rb'
+    - 'test/new_relic/agent/commands/thread_profiler_session_test.rb'
+    - 'test/new_relic/agent/configuration/environment_source_test.rb'
+    - 'test/new_relic/agent/configuration/manager_test.rb'
+    - 'test/new_relic/agent/configuration/security_policy_source_test.rb'
+    - 'test/new_relic/agent/configuration/yaml_source_test.rb'
+    - 'test/new_relic/agent/distributed_tracing/distributed_trace_payload_test.rb'
+    - 'test/new_relic/agent/distributed_tracing/trace_context_payload_test.rb'
+    - 'test/new_relic/agent/priority_sampled_buffer_test.rb'
+    - 'test/new_relic/agent/transaction/distributed_tracing_test.rb'
+    - 'test/new_relic/agent_test.rb'
+    - 'test/new_relic/gem_notifications_tests.rb'
+    - 'test/new_relic/language_support_test.rb'
+
+# Offense count: 27
+Minitest/AssertWithExpectedArgument:
+  Exclude:
+    - 'infinite_tracing/test/infinite_tracing/worker_test.rb'
+    - 'test/agent_helper.rb'
+    - 'test/multiverse/suites/grpc/grpc_client_test.rb'
+    - 'test/multiverse/suites/rails/error_tracing_test.rb'
+    - 'test/multiverse/suites/sidekiq/sidekiq_instrumentation_test.rb'
+    - 'test/new_relic/agent/agent_test.rb'
+    - 'test/new_relic/agent/configuration/default_source_test.rb'
+    - 'test/new_relic/agent/configuration/orphan_configuration_test.rb'
+    - 'test/new_relic/agent/datastores/redis_test.rb'
+    - 'test/new_relic/agent/distributed_tracing/distributed_tracing_cross_agent_test.rb'
+    - 'test/new_relic/agent/method_tracer_helpers_test.rb'
+    - 'test/new_relic/control_test.rb'
+
+# Offense count: 4
+Minitest/DuplicateTestRun:
+  Exclude:
+    - 'test/multiverse/suites/rails/error_tracing_test.rb'
+    - 'test/multiverse/suites/sinatra/ignoring_test.rb'
+
+# Offense count: 38
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/LiteralAsActualArgument:
+  Exclude:
+    - 'test/multiverse/suites/rails/active_support_logger_test.rb'
+    - 'test/new_relic/agent/configuration/environment_source_test.rb'
+    - 'test/new_relic/agent/connect/request_builder_test.rb'
+    - 'test/new_relic/agent/error_trace_aggregator_test.rb'
+    - 'test/new_relic/agent/instrumentation/controller_instrumentation_test.rb'
+    - 'test/new_relic/agent/new_relic_service_test.rb'
+    - 'test/new_relic/agent/samplers/cpu_sampler_test.rb'
+    - 'test/new_relic/agent/samplers/memory_sampler_test.rb'
+    - 'test/new_relic/agent/stats_test.rb'
+    - 'test/new_relic/agent/transaction/abstract_segment_test.rb'
+    - 'test/new_relic/agent/transaction/datastore_segment_test.rb'
+    - 'test/new_relic/agent/transaction_sampler_test.rb'
+    - 'test/new_relic/gem_notifications_tests.rb'
+    - 'test/new_relic/marshalling_test_cases.rb'
+    - 'test/new_relic/noticed_error_test.rb'
+
+# Offense count: 260
+Minitest/MultipleAssertions:
+  Max: 28
+
+# Offense count: 9
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/RefuteEqual:
+  Exclude:
+    - 'test/agent_helper.rb'
+    - 'test/multiverse/suites/config_file_loading/config_file_loading_test.rb'
+    - 'test/new_relic/agent/agent_test.rb'
+    - 'test/new_relic/agent/configuration/manager_test.rb'
+    - 'test/new_relic/marshalling_test_cases.rb'
+
+# Offense count: 121
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/RefuteFalse:
+  Enabled: false
+
+# Offense count: 16
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/RefuteIncludes:
+  Exclude:
+    - 'test/multiverse/suites/datamapper/datamapper_test.rb'
+    - 'test/multiverse/suites/grpc/grpc_server_test.rb'
+    - 'test/multiverse/suites/mongo/helpers/mongo_operation_tests.rb'
+    - 'test/multiverse/suites/mongo/mongo2_instrumentation_test.rb'
+    - 'test/multiverse/suites/rack/rack_cascade_test.rb'
+    - 'test/new_relic/agent/configuration/manager_test.rb'
+    - 'test/new_relic/control/instance_methods_test.rb'
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/RefutePathExists:
+  Exclude:
+    - 'test/multiverse/suites/mongo/helpers/mongo_server_test.rb'
+
+# Offense count: 96
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/RefutePredicate:
+  Enabled: false
+
+# Offense count: 27
+# This cop supports safe autocorrection (--autocorrect).
+Minitest/TestMethodName:
+  Enabled: false
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Rake/Desc:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/tasks/config.rake'
+
+# Offense count: 15
+Rake/MethodDefinitionInTask:
+  Exclude:
+    - 'Rakefile'
+    - 'infinite_tracing/tasks/proto.rake'
+    - 'lib/tasks/config.rake'
+    - 'lib/tasks/tests.rake'
+
+# Offense count: 2
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: always, always_true, never
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - 'test/multiverse/suites/active_record/db/schema.rb'
+    - 'test/multiverse/suites/active_record_pg/db/schema.rb'
+
+# Offense count: 26
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: IgnoreMacros, AllowedMethods, IgnoredMethods, AllowedPatterns, IgnoredPatterns, IncludedMacros, AllowParenthesesInMultilineCall, AllowParenthesesInChaining, AllowParenthesesInCamelCaseMethod, AllowParenthesesInStringInterpolation, EnforcedStyle.
+# SupportedStyles: require_parentheses, omit_parentheses
+Style/MethodCallWithArgsParentheses:
+  Exclude:
+    - 'test/multiverse/suites/active_record/db/schema.rb'
+    - 'test/multiverse/suites/active_record_pg/db/schema.rb'

data/.simplecov

@@ -1,5 +1,13 @@
+# frozen_string_literal: true
+require 'securerandom'
+
+random = SecureRandom.uuid
+SimpleCov.command_name(random)
+SimpleCov.coverage_dir("coverage_#{random}")
+
 SimpleCov.start do
-  enable_coverage :branch
+  enable_coverage(:branch)
   SimpleCov.root(File.join(File.dirname(__FILE__), '/lib'))
-  track_files "**/*.rb"
+  track_files("**/*.rb")
+  formatter(SimpleCov::Formatter::SimpleFormatter)
 end

data/.snyk

@@ -0,0 +1,11 @@
+exclude:
+  global:
+    # The project Dockerfile is only used to orchestrate container usage for
+    # local development with containers that are not to be exposed to the
+    # outside world. We use vanilla "ruby" images and do not layer on any
+    # additional software dependencies or configurations ourselves that would
+    # change the original "ruby" images' security profile. We defer all
+    # security mitigation for the images to the "ruby" image maintainers (who
+    # themselves are periodically updating their base Ubuntu layers to mitigate
+    # issues).
+    - Dockerfile

data/Brewfile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 brew 'imagemagick'
 brew 'memcached'
 tap 'mongodb/brew'

data/CHANGELOG.md

@@ -1,6 +1,84 @@
 # New Relic Ruby Agent Release Notes #
 
 
+  ## v8.10.1
+
+
+  * **Bugfix: Missing unscoped metrics when instrumentation.thread.tracing is enabled**
+    
+    Previously, when `instrumentation.thread.tracing` was set to true, some puma applications encountered a bug where a varying number of unscoped metrics would be missing. The agent now will correctly store and send all unscoped metrics.
+    
+    Thank you to @texpert for providing details of their situation to help resolve the issue.
+  
+  
+  * **Bugfix: gRPC instrumentation causes ArgumentError when other Google gems are present**
+
+    Previously, when the agent had gRPC instrumentation enabled in an application using other gems (such as google-ads-googleads), the instrumentation could cause the error `ArgumentError: wrong number of arguments (given 3, expected 2)`. The gRPC instrumentation has been updated to prevent this issue from occurring in the future. 
+
+    Thank you to @FeminismIsAwesome for bringing this issue to our attention.
+
+
+  ## v8.10.0
+
+
+  * **New gRPC instrumentation**
+
+    The agent will now instrument [gRPC](https://grpc.io/) activity performed by clients and servers that use the [grpc](https://rubygems.org/gems/grpc) RubyGem. Instrumentation is automatic and enabled by default, so gRPC users should not need to modify any existing application code or agent configuration to benefit from the instrumentation. The instrumentation makes use of distributed tracing for a comprehensive overview of all gRPC traffic taking place across multiple monitored applications. This allows you to observe your client and server activity using any service that adheres to the W3C standard.
+
+    The following new configuration parameters have been added for gRPC. All are optional.
+
+    | Configuration name | Default | Behavior |
+    | ----------- | ----------- |----------- |
+    | `instrumentation.grpc_client` | auto | Set to 'disabled' to disable, set to 'chain' if there are module prepending conflicts |
+    | `instrumentation.grpc_server` | auto | Set to 'disabled' to disable, set to 'chain' if there are module prepending conflicts |
+    | `instrumentation.grpc.host_denylist` | "" |  Provide a comma delimited list of host regex patterns (ex: "private.com$,exception.*") |
+
+
+  * **Code-level metrics functionality is enabled by default**
+
+    The code-level metrics functionality for the Ruby agent's [CodeStream integration](https://docs.newrelic.com/docs/apm/agents/ruby-agent/features/ruby-codestream-integration) is now enabled by default after we have received positive feedback and no open bugs for the past two releases.
+
+
+  * **Performance: Rework timing range overlap calculations for multiple transaction segments**
+
+    Many thanks to GitHub community members @bmulholland and @hkdnet. @bmulholland alerted us to [rmosolgo/graphql-ruby#3945](https://github.com/rmosolgo/graphql-ruby/issues/3945). That Issue essentially notes that the New Relic Ruby agent incurs a significant perfomance hit when the `graphql` RubyGem (which ships with New Relic Ruby agent support) is used with DataLoader to generate a high number of transactions. Then @hkdnet diagnosed the root cause in the Ruby agent and put together both a proof of concept fix and a full blown PR to resolve the problem. The agent keeps track multiple segments that are concurrently in play for a given transaction in order to merge the ones whose start and stop times intersect. The logic for doing this find-and-merge operation has been reworked to a) be deferred entirely until the transaction is ready to be recorded, and b) made more performant when it is needed. GraphQL DataLoader users and other users who generate lots of activity for monitoring within a short amount of time will hopefully see some good performance gains from these changes.
+
+
+  * **Performance: Make frozen string literals the default for the agent**
+
+    The Ruby `frozen_string_literal: true` magic source code comment has now been applied consistently across all Ruby files belonging to the agent. This can provide a performance boost, given that Ruby can rely on the strings remaining immutable. Previously only about a third of the agent's code was freezing string literals by default. Now that 100% of the code freezes string literals by default, we have internally observed some related performance gains through testing. We are hopeful that these will translate into some real world gains in production capacities.
+
+
+  * **Bugfix: Error when setting the yaml configuration with `transaction_tracer.transaction_threshold: apdex_f`**
+    
+    Originally, the agent was only checking the `transaction_tracer.transaction_threshold` from the newrelic.yml correctly if it was on two lines. 
+
+    Example:
+
+    ```
+    # newrelic.yml
+    transaction_tracer:
+      transaction_threshold: apdex_f 
+    ```
+
+    When this was instead changed to be on one line, the agent was not able to correctly identify the value of apdex_f. 
+
+    Example:
+    ```
+    # newrelic.yml
+    transaction_tracer.transaction_threshold: apdex_f
+    ```
+    This would cause prevent transactions from finishing due to the error `ArgumentError: comparison of Float with String failed`. This has now been corrected and the agent is able to process newrelic.yml with a one line `transaction_tracer.transaction_threshold: apdex_f` correctly now. 
+    
+    Thank you to @oboxodo for bringing this to our attention.
+
+
+  * **Bugfix: Don't modify frozen Logger**
+
+    Previously the agent would modify each instance of the Logger class by adding a unique instance variable as part of the instrumentation. This could cause the error `FrozenError: can't modify frozen Logger` to be thrown if the Logger instance had been frozen. The agent will now check if the object is frozen before attempting to modify the object. Thanks to @mkcosta for bringing this issue to our attention.
+
+
+
   ## v8.9.0
   
   

data/Guardfile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require './test/multiverse/lib/multiverse/bundler_patch'
 
 test_folders = Dir.glob("test/new_relic/*").select { |f| File.directory?(f) }

data/Rakefile

@@ -1,3 +1,8 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
+
 require 'rubygems'
 require 'rake/testtask'
 require 'yard'

data/Thorfile

@@ -0,0 +1,6 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
+
+Dir["./lib/tasks/**/*.thor"].sort.each { |f| load f }

data/bin/newrelic

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 # executes one of the commands in the new_relic/commands directory
 # pass the name of the command as an argument
 
@@ -9,5 +10,5 @@ begin
 rescue NewRelic::Cli::Command::CommandFailure => failure
   STDERR.puts failure.message
   STDERR.puts failure.options if failure.options
-  exit 1
+  exit(1)
 end

data/bin/newrelic_cmd

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 # This command has been renamed "newrelic"
 # executes one of the commands in the new_relic/commands directory
 # pass the name of the command as an argument

data/bin/nrdebug

@@ -3,6 +3,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 require 'tempfile'
 require 'rbconfig'
@@ -178,10 +179,10 @@ class ProcessReport
   def open
     if @path
       File.open(@path, "w") do |f|
-        yield f
+        yield(f)
       end
     else
-      yield $stdout
+      yield($stdout)
     end
   end
 

data/init.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 # This is the initialization for the New Relic Ruby Agent when used as
 # a plugin
@@ -24,7 +25,7 @@ begin
     Rails.configuration
   end
 
-  NewRelic::Control.instance.init_plugin :config => current_config
+  NewRelic::Control.instance.init_plugin(:config => current_config)
 rescue => e
-  ::NewRelic::Agent.logger.error "Error initializing New Relic plugin. Agent is disabled.", e
+  ::NewRelic::Agent.logger.error("Error initializing New Relic plugin. Agent is disabled.", e)
 end

data/install.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 if __FILE__ == $0 || $0 =~ /script\/plugin/ || File.basename($0) == 'rake'
   $LOAD_PATH << File.expand_path(File.join(File.dirname(__FILE__), 'lib'))

data/lib/new_relic/agent/adaptive_sampler.rb

@@ -1,11 +1,12 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 module NewRelic
   module Agent
     class AdaptiveSampler
-      def initialize target_samples = 10, period_duration = 60
+      def initialize(target_samples = 10, period_duration = 60)
         @target = target_samples
         @seen = 0
         @seen_last = 0
@@ -84,7 +85,7 @@ module NewRelic
             end
           end
           if target_changed
-            NewRelic::Agent.logger.debug "Sampling target set to: #{target}"
+            NewRelic::Agent.logger.debug("Sampling target set to: #{target}")
           end
         end
       end
@@ -99,7 +100,7 @@ module NewRelic
             end
           end
           if period_changed
-            NewRelic::Agent.logger.debug "Sampling period set to: #{period_duration}"
+            NewRelic::Agent.logger.debug("Sampling period set to: #{period_duration}")
           end
         end
       end

data/lib/new_relic/agent/agent/shutdown.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 module NewRelic
   module Agent
@@ -9,7 +10,7 @@ module NewRelic
       # data.
       def shutdown
         return unless started?
-        ::NewRelic::Agent.logger.info "Starting Agent shutdown"
+        ::NewRelic::Agent.logger.info("Starting Agent shutdown")
 
         stop_event_loop
         trap_signals_for_litespeed
@@ -26,7 +27,7 @@ module NewRelic
             graceful_disconnect
           end
         rescue => e
-          ::NewRelic::Agent.logger.error e
+          ::NewRelic::Agent.logger.error(e)
         end
       end
     end

data/lib/new_relic/agent/agent/special_startup.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 module NewRelic
   module Agent
@@ -10,8 +11,8 @@ module NewRelic
       # before connecting, otherwise the parent process sends useless data
       def using_forking_dispatcher?
         # TODO: MAJOR VERSION - remove :rainbows
-        if [:puma, :passenger, :rainbows, :unicorn].include? Agent.config[:dispatcher]
-          ::NewRelic::Agent.logger.info "Deferring startup of agent reporting thread because #{Agent.config[:dispatcher]} may fork."
+        if [:puma, :passenger, :rainbows, :unicorn].include?(Agent.config[:dispatcher])
+          ::NewRelic::Agent.logger.info("Deferring startup of agent reporting thread because #{Agent.config[:dispatcher]} may fork.")
           true
         else
           false