newrelic_rpm 8.9.0 → 8.10.0

data/lib/new_relic/agent/instrumentation/memcache/dalli.rb

@@ -15,7 +15,7 @@ module NewRelic
           def instrument!
             if supports_datastore_instances?
               instrument_methods(::Dalli::Client, dalli_methods)
-              instrument_multi_method :get_multi
+              instrument_multi_method(:get_multi)
               instrument_send_multiget
               instrument_server_for_key
             else
@@ -23,19 +23,19 @@ module NewRelic
             end
           end
 
-          def instrument_multi_method method_name
-            visibility = NewRelic::Helper.instance_method_visibility ::Dalli::Client, method_name
+          def instrument_multi_method(method_name)
+            visibility = NewRelic::Helper.instance_method_visibility(::Dalli::Client, method_name)
             method_name_without = :"#{method_name}_without_newrelic_trace"
 
             ::Dalli::Client.class_eval do
-              alias_method method_name_without, method_name
+              alias_method(method_name_without, method_name)
 
-              define_method method_name do |*args, &block|
-                get_multi_with_newrelic_tracing(method_name) { __send__ method_name_without, *args, &block }
+              define_method(method_name) do |*args, &block|
+                get_multi_with_newrelic_tracing(method_name) { __send__(method_name_without, *args, &block) }
               end
 
-              __send__ visibility, method_name
-              __send__ visibility, method_name_without
+              __send__(visibility, method_name)
+              __send__(visibility, method_name_without)
             end
           end
 
@@ -43,10 +43,10 @@ module NewRelic
             ::Dalli::Ring.class_eval do
               include NewRelic::Agent::Instrumentation::Memcache::Tracer
 
-              alias_method :server_for_key_without_newrelic_trace, :server_for_key
+              alias_method(:server_for_key_without_newrelic_trace, :server_for_key)
 
-              def server_for_key key
-                server_for_key_with_newrelic_tracing { server_for_key_without_newrelic_trace key }
+              def server_for_key(key)
+                server_for_key_with_newrelic_tracing { server_for_key_without_newrelic_trace(key) }
               end
             end
           end
@@ -61,14 +61,14 @@ module NewRelic
 
               # TODO: Dalli - 3.1.0 renamed send_multiget to piplined_get, but the method is otherwise the same
               if Gem::Version.new(::Dalli::VERSION) >= Gem::Version.new('3.1.0')
-                alias_method :pipelined_get_without_newrelic_trace, :pipelined_get
-                def pipelined_get keys
-                  send_multiget_with_newrelic_tracing(keys) { pipelined_get_without_newrelic_trace keys }
+                alias_method(:pipelined_get_without_newrelic_trace, :pipelined_get)
+                def pipelined_get(keys)
+                  send_multiget_with_newrelic_tracing(keys) { pipelined_get_without_newrelic_trace(keys) }
                 end
               else
-                alias_method :send_multiget_without_newrelic_trace, :send_multiget
-                def send_multiget keys
-                  send_multiget_with_newrelic_tracing(keys) { send_multiget_without_newrelic_trace keys }
+                alias_method(:send_multiget_without_newrelic_trace, :send_multiget)
+                def send_multiget(keys)
+                  send_multiget_with_newrelic_tracing(keys) { send_multiget_without_newrelic_trace(keys) }
                 end
               end
             end
@@ -86,8 +86,8 @@ module NewRelic
           end
 
           def instrument!
-            instrument_methods ::Dalli::Client, dalli_cas_methods
-            instrument_multi_method :get_multi_cas
+            instrument_methods(::Dalli::Client, dalli_cas_methods)
+            instrument_multi_method(:get_multi_cas)
           end
         end
       end

data/lib/new_relic/agent/instrumentation/memcache/helper.rb

@@ -6,8 +6,8 @@
 module NewRelic::Agent::Instrumentation
   module Memcache
     module Helper
-      DATASTORE_INSTANCES_SUPPORTED_VERSION = Gem::Version.new '2.6.4'
-      BINARY_PROTOCOL_SUPPORTED_VERSION = Gem::Version.new '3.0.2'
+      DATASTORE_INSTANCES_SUPPORTED_VERSION = Gem::Version.new('2.6.4')
+      BINARY_PROTOCOL_SUPPORTED_VERSION = Gem::Version.new('3.0.2')
 
       def supports_datastore_instances?
         DATASTORE_INSTANCES_SUPPORTED_VERSION <= Gem::Version.new(::Dalli::VERSION)
@@ -38,20 +38,20 @@ module NewRelic::Agent::Instrumentation
 
       def instrument_methods(client_class, requested_methods = METHODS)
         supported_methods_for(client_class, requested_methods).each do |method_name|
-          visibility = NewRelic::Helper.instance_method_visibility client_class, method_name
+          visibility = NewRelic::Helper.instance_method_visibility(client_class, method_name)
           method_name_without = :"#{method_name}_without_newrelic_trace"
 
           client_class.class_eval do
             include NewRelic::Agent::Instrumentation::Memcache::Tracer
 
-            alias_method method_name_without, method_name
+            alias_method(method_name_without, method_name)
 
-            define_method method_name do |*args, &block|
-              with_newrelic_tracing(method_name, *args) { __send__ method_name_without, *args, &block }
+            define_method(method_name) do |*args, &block|
+              with_newrelic_tracing(method_name, *args) { __send__(method_name_without, *args, &block) }
             end
 
-            __send__ visibility, method_name
-            __send__ visibility, method_name_without
+            __send__(visibility, method_name)
+            __send__(visibility, method_name_without)
           end
         end
       end

data/lib/new_relic/agent/instrumentation/memcache/instrumentation.rb

@@ -12,16 +12,17 @@ module NewRelic::Agent::Instrumentation
       MULTIGET_METRIC_NAME = "get_multi_request"
       MEMCACHED = "Memcached"
 
-      def with_newrelic_tracing operation, *args
-        segment = NewRelic::Agent::Tracer.start_datastore_segment \
+      def with_newrelic_tracing(operation, *args)
+        segment = NewRelic::Agent::Tracer.start_datastore_segment( \
           product: MEMCACHED,
           operation: operation
+        )
 
         begin
           NewRelic::Agent::Tracer.capture_segment_error(segment) { yield }
         ensure
           if NewRelic::Agent.config[:capture_memcache_keys]
-            segment.notice_nosql_statement "#{operation} #{args.first.inspect}"
+            segment.notice_nosql_statement("#{operation} #{args.first.inspect}")
           end
           segment.finish if segment
         end
@@ -37,14 +38,15 @@ module NewRelic::Agent::Instrumentation
               end
             end
           rescue => e
-            ::NewRelic::Agent.logger.warn "Unable to set instance info on datastore segment: #{e.message}"
+            ::NewRelic::Agent.logger.warn("Unable to set instance info on datastore segment: #{e.message}")
           end
         end
       end
 
-      def get_multi_with_newrelic_tracing method_name
-        segment = NewRelic::Agent::Tracer.start_segment \
+      def get_multi_with_newrelic_tracing(method_name)
+        segment = NewRelic::Agent::Tracer.start_segment( \
           name: "Ruby/Memcached/Dalli/#{method_name}"
+        )
 
         begin
           NewRelic::Agent::Tracer.capture_segment_error(segment) { yield }
@@ -53,35 +55,36 @@ module NewRelic::Agent::Instrumentation
         end
       end
 
-      def send_multiget_with_newrelic_tracing keys
-        segment = ::NewRelic::Agent::Tracer.start_datastore_segment \
+      def send_multiget_with_newrelic_tracing(keys)
+        segment = ::NewRelic::Agent::Tracer.start_datastore_segment( \
           product: MEMCACHED,
           operation: MULTIGET_METRIC_NAME
+        )
 
         begin
           assign_instance_to(segment, self)
           NewRelic::Agent::Tracer.capture_segment_error(segment) { yield }
         ensure
           if ::NewRelic::Agent.config[:capture_memcache_keys]
-            segment.notice_nosql_statement "#{MULTIGET_METRIC_NAME} #{keys.inspect}"
+            segment.notice_nosql_statement("#{MULTIGET_METRIC_NAME} #{keys.inspect}")
           end
           segment.finish if segment
         end
       end
 
-      def assign_instance_to segment, server
+      def assign_instance_to(segment, server)
         host = port_path_or_id = nil
-        if server.hostname.start_with? SLASH
+        if server.hostname.start_with?(SLASH)
           host = LOCALHOST
           port_path_or_id = server.hostname
         else
           host = server.hostname
           port_path_or_id = server.port
         end
-        segment.set_instance_info host, port_path_or_id
+        segment.set_instance_info(host, port_path_or_id)
       rescue => e
-        ::NewRelic::Agent.logger.debug "Failed to retrieve memcached instance info: #{e.message}"
-        segment.set_instance_info UNKNOWN, UNKNOWN
+        ::NewRelic::Agent.logger.debug("Failed to retrieve memcached instance info: #{e.message}")
+        segment.set_instance_info(UNKNOWN, UNKNOWN)
       end
     end
   end

data/lib/new_relic/agent/instrumentation/memcache/prepend.rb

@@ -10,7 +10,7 @@ module NewRelic::Agent::Instrumentation
 
       module_function
 
-      def client_prepender client_class
+      def client_prepender(client_class)
         Module.new do
           extend Helper
           include NewRelic::Agent::Instrumentation::Memcache::Tracer
@@ -24,28 +24,28 @@ module NewRelic::Agent::Instrumentation
       end
 
       def dalli_cas_prependers
-        yield ::Dalli::Client, dalli_client_prepender(dalli_cas_methods)
-        yield ::Dalli::Client, dalli_get_multi_prepender(:get_multi_cas)
+        yield(::Dalli::Client, dalli_client_prepender(dalli_cas_methods))
+        yield(::Dalli::Client, dalli_get_multi_prepender(:get_multi_cas))
       end
 
       def dalli_prependers
         if supports_datastore_instances?
-          yield ::Dalli::Client, dalli_client_prepender(dalli_methods)
-          yield ::Dalli::Client, dalli_get_multi_prepender(:get_multi)
+          yield(::Dalli::Client, dalli_client_prepender(dalli_methods))
+          yield(::Dalli::Client, dalli_get_multi_prepender(:get_multi))
 
           if supports_binary_protocol?
-            yield ::Dalli::Protocol::Binary, dalli_server_prepender
+            yield(::Dalli::Protocol::Binary, dalli_server_prepender)
           else
-            yield ::Dalli::Server, dalli_server_prepender
+            yield(::Dalli::Server, dalli_server_prepender)
           end
 
-          yield ::Dalli::Ring, dalli_ring_prepender
+          yield(::Dalli::Ring, dalli_ring_prepender)
         else
-          yield ::Dalli::Client, dalli_client_prepender(client_methods)
+          yield(::Dalli::Client, dalli_client_prepender(client_methods))
         end
       end
 
-      def dalli_client_prepender supported_methods
+      def dalli_client_prepender(supported_methods)
         Module.new do
           extend Helper
           include NewRelic::Agent::Instrumentation::Memcache::Tracer
@@ -58,7 +58,7 @@ module NewRelic::Agent::Instrumentation
         end
       end
 
-      def dalli_get_multi_prepender method_name
+      def dalli_get_multi_prepender(method_name)
         Module.new do
           extend Helper
           include NewRelic::Agent::Instrumentation::Memcache::Tracer
@@ -74,7 +74,7 @@ module NewRelic::Agent::Instrumentation
           extend Helper
           include NewRelic::Agent::Instrumentation::Memcache::Tracer
 
-          def server_for_key key
+          def server_for_key(key)
             server_for_key_with_newrelic_tracing { super }
           end
         end
@@ -87,11 +87,11 @@ module NewRelic::Agent::Instrumentation
 
           # TODO: Dalli - 3.1.0 renamed send_multiget to piplined_get, but the method is otherwise the same
           if Gem::Version.new(::Dalli::VERSION) >= Gem::Version.new('3.1.0')
-            def pipelined_get keys
+            def pipelined_get(keys)
               send_multiget_with_newrelic_tracing(keys) { super }
             end
           else
-            def send_multiget keys
+            def send_multiget(keys)
               send_multiget_with_newrelic_tracing(keys) { super }
             end
           end

data/lib/new_relic/agent/instrumentation/memcache.rb

@@ -75,7 +75,7 @@ DependencyDetection.defer do
   depends_on { ::NewRelic::Agent::Instrumentation::Memcache::DalliCAS.should_instrument? }
 
   executes do
-    ::NewRelic::Agent.logger.info 'Installing Dalli CAS Client Memcache instrumentation'
+    ::NewRelic::Agent.logger.info('Installing Dalli CAS Client Memcache instrumentation')
     if use_prepend?
       prepend_module = ::NewRelic::Agent::Instrumentation::Memcache::Prepend
       prepend_module.dalli_cas_prependers do |client_class, instrumenting_module|

data/lib/new_relic/agent/instrumentation/middleware_proxy.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 require 'new_relic/agent/method_tracer'
 require 'new_relic/agent/transaction'

data/lib/new_relic/agent/instrumentation/mongo.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 DependencyDetection.defer do
   named :mongo
@@ -18,7 +19,7 @@ DependencyDetection.defer do
   end
 
   executes do
-    NewRelic::Agent.logger.info 'Installing Mongo instrumentation'
+    NewRelic::Agent.logger.info('Installing Mongo instrumentation')
     install_mongo_command_subscriber
   end
 

data/lib/new_relic/agent/instrumentation/mongodb_command_subscriber.rb

@@ -1,6 +1,8 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
+
 require 'new_relic/agent/datastores/mongo/event_formatter'
 
 module NewRelic
@@ -13,7 +15,7 @@ module NewRelic
         def started(event)
           begin
             return unless NewRelic::Agent::Tracer.tracing_enabled?
-            segments[event.operation_id] = start_segment event
+            segments[event.operation_id] = start_segment(event)
           rescue Exception => e
             log_notification_error('started', e)
           end
@@ -40,12 +42,12 @@ module NewRelic
             if error_key = error_key_present?(event)
               # taking the last error as there can potentially be many
               attributes = event.reply[error_key][-1]
-              segment.notice_error Mongo::Error.new("%s (%s)" % [attributes["errmsg"], attributes["code"]])
+              segment.notice_error(Mongo::Error.new("%s (%s)" % [attributes["errmsg"], attributes["code"]]))
 
             # failing commands return a CommandFailed event with an error message
             # in the form of "% (%s)" for the message and code
-            elsif event.is_a? Mongo::Monitoring::Event::CommandFailed
-              segment.notice_error Mongo::Error.new(event.message)
+            elsif event.is_a?(Mongo::Monitoring::Event::CommandFailed)
+              segment.notice_error(Mongo::Error.new(event.message))
             end
             segment.finish
           rescue Exception => e
@@ -58,9 +60,9 @@ module NewRelic
 
         private
 
-        def start_segment event
-          host = host_from_address event.address
-          port_path_or_id = port_path_or_id_from_address event.address
+        def start_segment(event)
+          host = host_from_address(event.address)
+          port_path_or_id = port_path_or_id_from_address(event.address)
           segment = NewRelic::Agent::Tracer.start_datastore_segment(
             product: MONGODB,
             operation: operation(event.command_name),
@@ -107,31 +109,31 @@ module NewRelic
         LOCALHOST = "localhost".freeze
 
         def host_from_address(address)
-          if unix_domain_socket? address.host
+          if unix_domain_socket?(address.host)
             LOCALHOST
           else
             address.host
           end
         rescue => e
-          NewRelic::Agent.logger.debug "Failed to retrieve Mongo host: #{e}"
+          NewRelic::Agent.logger.debug("Failed to retrieve Mongo host: #{e}")
           UNKNOWN
         end
 
         def port_path_or_id_from_address(address)
-          if unix_domain_socket? address.host
+          if unix_domain_socket?(address.host)
             address.host
           else
             address.port
           end
         rescue => e
-          NewRelic::Agent.logger.debug "Failed to retrieve Mongo port_path_or_id: #{e}"
+          NewRelic::Agent.logger.debug("Failed to retrieve Mongo port_path_or_id: #{e}")
           UNKNOWN
         end
 
         SLASH = "/".freeze
 
         def unix_domain_socket?(host)
-          host.start_with? SLASH
+          host.start_with?(SLASH)
         end
       end
     end

data/lib/new_relic/agent/instrumentation/net_http/chain.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 require_relative 'instrumentation'
 

data/lib/new_relic/agent/instrumentation/net_http/instrumentation.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 module NewRelic
   module Agent
@@ -17,18 +18,18 @@ module NewRelic
 
           begin
             response = nil
-            segment.add_request_headers wrapped_request
+            segment.add_request_headers(wrapped_request)
 
             # RUBY-1244 Disable further tracing in request to avoid double
             # counting if connection wasn't started (which calls request again).
             NewRelic::Agent.disable_all_tracing do
-              response = NewRelic::Agent::Tracer.capture_segment_error segment do
+              response = NewRelic::Agent::Tracer.capture_segment_error(segment) do
                 yield
               end
             end
 
-            wrapped_response = NewRelic::Agent::HTTPClients::NetHTTPResponse.new response
-            segment.process_response_headers wrapped_response
+            wrapped_response = NewRelic::Agent::HTTPClients::NetHTTPResponse.new(response)
+            segment.process_response_headers(wrapped_response)
             response
           ensure
             segment.finish

data/lib/new_relic/agent/instrumentation/net_http/prepend.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 require_relative 'instrumentation'
 

data/lib/new_relic/agent/instrumentation/net_http.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 require_relative 'net_http/chain'
 require_relative 'net_http/prepend'
@@ -13,7 +14,7 @@ DependencyDetection.defer do
   end
 
   executes do
-    ::NewRelic::Agent.logger.info 'Installing Net:HTTP Wrappers'
+    ::NewRelic::Agent.logger.info('Installing Net:HTTP Wrappers')
     require 'new_relic/agent/http_clients/net_http_wrappers'
   end
 

data/lib/new_relic/agent/instrumentation/notifications_subscriber.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 module NewRelic
   module Agent
@@ -26,11 +27,11 @@ module NewRelic
           instance_variable_names.each do |name|
             if notifier.instance_variable_defined?(name)
               subscribers = notifier.instance_variable_get(name)
-              if subscribers.is_a? Array
+              if subscribers.is_a?(Array)
                 # Rails 5 @subscribers, and Rails 6 @other_subscribers is a
                 # plain array of subscriber objects
                 all_subscribers += subscribers
-              elsif subscribers.is_a? Hash
+              elsif subscribers.is_a?(Hash)
                 # Rails 6 @string_subscribers is a Hash mapping the pattern
                 # string of a subscriber to an array of subscriber objects
                 subscribers.values.each { |array| all_subscribers += array }
@@ -55,7 +56,7 @@ module NewRelic
         end
 
         def push_segment(id, segment)
-          segment_stack[id].push segment
+          segment_stack[id].push(segment)
         end
 
         def pop_segment(id)
@@ -85,7 +86,7 @@ module NewRelic
             def exception_object(payload)
               exception_class, message = payload[:exception]
               return nil unless exception_class
-              NewRelic::Agent::NoticibleError.new exception_class, message
+              NewRelic::Agent::NoticibleError.new(exception_class, message)
             end
           else
             def exception_object(payload)

data/lib/new_relic/agent/instrumentation/padrino/chain.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 module NewRelic
   module Agent

data/lib/new_relic/agent/instrumentation/padrino/instrumentation.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 module NewRelic::Agent::Instrumentation
   module Padrino

data/lib/new_relic/agent/instrumentation/padrino/prepend.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 module NewRelic::Agent::Instrumentation
   module PadrinoTracer

data/lib/new_relic/agent/instrumentation/padrino.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 # Our Padrino instrumentation relies heavily on the fact that Padrino is
 # built on Sinatra. Although it wires up a lot of its own routing logic,
@@ -22,7 +23,7 @@ DependencyDetection.defer do
   depends_on { defined?(::Padrino) && defined?(::Padrino::Routing::InstanceMethods) }
 
   executes do
-    ::NewRelic::Agent.logger.info 'Installing Padrino instrumentation'
+    ::NewRelic::Agent.logger.info('Installing Padrino instrumentation')
     if use_prepend?
       prepend_instrument ::Padrino::Application, NewRelic::Agent::Instrumentation::PadrinoTracer::Prepend
     else

data/lib/new_relic/agent/instrumentation/passenger_instrumentation.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 DependencyDetection.defer do
   @name = :passenger
@@ -10,10 +11,10 @@ DependencyDetection.defer do
   end
 
   executes do
-    ::NewRelic::Agent.logger.debug "Installing Passenger event hooks."
+    ::NewRelic::Agent.logger.debug("Installing Passenger event hooks.")
 
     ::PhusionPassenger.on_event(:stopping_worker_process) do
-      ::NewRelic::Agent.logger.debug "Passenger stopping this process, shutdown the agent."
+      ::NewRelic::Agent.logger.debug("Passenger stopping this process, shutdown the agent.")
       NewRelic::Agent.instance.shutdown
     end
 

data/lib/new_relic/agent/instrumentation/queue_time.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 module NewRelic
   module Agent

data/lib/new_relic/agent/instrumentation/rack/chain.rb

@@ -1,12 +1,13 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 module NewRelic::Agent::Instrumentation
   module Rack
     module Chain
-      def self.instrument! builder_class
-        NewRelic::Agent::Instrumentation::RackBuilder.track_deferred_detection builder_class
+      def self.instrument!(builder_class)
+        NewRelic::Agent::Instrumentation::RackBuilder.track_deferred_detection(builder_class)
 
         builder_class.class_eval do
           include ::NewRelic::Agent::Instrumentation::RackBuilder
@@ -15,26 +16,26 @@ module NewRelic::Agent::Instrumentation
             with_deferred_dependency_detection { to_app_without_newrelic }
           end
 
-          alias_method :to_app_without_newrelic, :to_app
-          alias_method :to_app, :to_app_with_newrelic_deferred_dependency_detection
+          alias_method(:to_app_without_newrelic, :to_app)
+          alias_method(:to_app, :to_app_with_newrelic_deferred_dependency_detection)
 
           if ::NewRelic::Agent::Instrumentation::RackHelpers.middleware_instrumentation_enabled?
-            ::NewRelic::Agent.logger.info "Installing #{builder_class} middleware instrumentation"
+            ::NewRelic::Agent.logger.info("Installing #{builder_class} middleware instrumentation")
 
             def run_with_newrelic(app, *args)
               run_with_tracing(app) { |wrapped_app| run_without_newrelic(wrapped_app, *args) }
             end
 
-            alias_method :run_without_newrelic, :run
-            alias_method :run, :run_with_newrelic
+            alias_method(:run_without_newrelic, :run)
+            alias_method(:run, :run_with_newrelic)
 
             def use_with_newrelic(middleware_class, *args, &block)
               use_with_tracing(middleware_class) { |wrapped_class| use_without_newrelic(wrapped_class, *args, &block) }
             end
             ruby2_keywords(:use_with_newrelic) if respond_to?(:ruby2_keywords, true)
 
-            alias_method :use_without_newrelic, :use
-            alias_method :use, :use_with_newrelic
+            alias_method(:use_without_newrelic, :use)
+            alias_method(:use, :use_with_newrelic)
           end
         end
       end
@@ -42,9 +43,9 @@ module NewRelic::Agent::Instrumentation
 
     module URLMap
       module Chain
-        def self.instrument! url_map_class
+        def self.instrument!(url_map_class)
           url_map_class.class_eval do
-            alias_method :initialize_without_newrelic, :initialize
+            alias_method(:initialize_without_newrelic, :initialize)
 
             def initialize(map = {})
               traced_map = ::NewRelic::Agent::Instrumentation::RackURLMap.generate_traced_map(map)

data/lib/new_relic/agent/instrumentation/rack/helpers.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
+# frozen_string_literal: true
 
 module NewRelic::Agent::Instrumentation
   module RackHelpers