newrelic_rpm 8.3.0 → 8.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e880b2a64a110a0142d2181c5fd00e21bf9556fd5e5c7040392b4bcd10af94a7
-  data.tar.gz: 738a4b0f51093ec199afdb7fafee94fce2401df4da9202403bc04f59707c626b
+  metadata.gz: b90db359ee9a4ce0043d52c3e1a391d6045e3aa292dff13964faee417c9c76e8
+  data.tar.gz: 87def45d9de621a59941831397f503e1c95922027fb07ef1c136d4b4dc186224
 SHA512:
-  metadata.gz: f59e04082bbb62a3f99d63a13891d8adf9980c4c189a985928482fc4af2304786b03735da26e1683fcd2d2d78499719f3329d14bd5d2149f86e1f2f900c2df1e
-  data.tar.gz: c95d5c11979da021f14d1923b851cde1f47f49c8fbc7d1e4d362280209939760ed254e02ef0d106d674181415eeec7a94940ec8053e781063c61e304a6a481ac
+  metadata.gz: 282d678c98d42998e7aef885e909cf9973eb9665c541fbeb24b5113d52b3ff312f5e12adcf808c17348dbe3fe4226aaee47f858f2c7c34588ddf323c7452998f
+  data.tar.gz: '00285b8f884e8e3fd11debaf64c82dc674dcdc7176274b796dcc552abd23501911fd3b67fb4c691cfc280fedbed499f06463e12d27f3fcb6e60ff38f4038e309'

data/.gitignore

@@ -8,7 +8,6 @@ Guard*
 pkg/
 *.gem
 !rails
-Manifest*
 .idea/
 tmp/
 TAGS
@@ -37,3 +36,4 @@ yarn.lock
 errors.txt
 .history/
 vendor/
+Brewfile.lock.json

data/Brewfile

@@ -0,0 +1,10 @@
+brew 'imagemagick'
+brew 'memcached'
+tap 'mongodb/brew'
+brew 'mongodb-community'
+brew 'mysql'
+brew 'openssl'
+brew 'pkg-config'
+brew 'postgresql'
+brew 'rabbitmq'
+brew 'redis'

data/CHANGELOG.md

@@ -1,5 +1,24 @@
 # New Relic Ruby Agent Release Notes #
 
+  ## v8.4.0
+
+  * **Provide basic support for Rails 7.0**
+
+  This release includes Rails 7.0 as a tested Rails version. Updates build upon the agent's current Rails instrumentation and do not include additional instrumentation for new features.
+
+  * **Improve the performance of NewRelic::Agent::GuidGenerator#generate_guid**
+
+  This method is called by many basic operations within the agent including transactions, datastore segments, and external request segments. Thank you, @jdelstrother for contributing this performance improvement!
+
+  * **Documentation: Development environment prep instructions**
+
+  The multiverse collection of test suites requires a variety of data handling software (MySQL, Redis, memcached, etc.) to be available on the machine running the tests. The [project documentation](test/multiverse/README.md) has been updated to outline the relevant software packages, and a `Brewfile` file has been added to automate software installation with Homebrew.
+
+  * **Bugfix: Add ControllerInstrumentation::Shims to Sinatra framework**
+
+    When the agent is disabled by setting the configuration settings `enabled`, `agent_enabled`, and/or `monitor_mode` to false, the agent loads shims for public controller instrumentation methods. These shims were missing for the Sinatra framework, causing applications to crash if the agent was disabled. Thank you, @NC-piercej for bringing this to our attention!
+
+
   ## v8.3.0
 
   * **Updated the agent to support Ruby 3.1.0**

data/CONTRIBUTING.md

@@ -31,7 +31,7 @@ incorrect.
 
 If you are planning on contributing a new feature or an otherwise complex
 contribution, we kindly ask you to start a conversation with the maintainer team
-by opening up an Github issue first.
+by opening up a GitHub issue first.
 
 
 ### General Guidelines
@@ -94,7 +94,7 @@ includes unreleased work. Please create all new branches off of `dev`.
     - Fork the repository inside GitHub
     - `git clone git@github.com:<gh username>/newrelic-ruby-agent.git`
 1. Pick a Ruby version
-    - Use rbenv or rvm to install any version of Ruby between 2.2 up to 3.1
+    - Use rbenv, rvm, chruby, asdf, etc. to install any version of Ruby between 2.2 up to the latest stable version
 1. Install development dependencies
     - `bundle install`
 1. Check that your env is setup correctly

data/Rakefile

@@ -31,10 +31,10 @@ namespace :test do
     Performance::Runner.new(options).run_and_report
   end
 
-  desc "Run agent within existing mini environments"
-  task :env, [:env1, :env2, :env3, :env4, :env5, :env6] => [] do |t, args|
+  desc "Run agent within existing mini environment(s): env[name1,name2,name3,etc.]"
+  task :env do |t, args|
     require File.expand_path(File.join(File.dirname(__FILE__), 'test', 'environments', 'lib', 'environments', 'runner'))
-    Environments::Runner.new(args.map { |_, v| v }).run_and_report
+    Environments::Runner.new(args.to_a).run_and_report
   end
 
   Rake::TestTask.new(:intentional_fail) do |t|

data/lib/new_relic/agent/configuration/default_source.rb

@@ -123,11 +123,9 @@ module NewRelic
             when defined?(::NewRelic::TEST) then :test
             when defined?(::Rails::VERSION)
               case Rails::VERSION::MAJOR
-              when 0..2
-                :rails
               when 3
                 :rails3
-              when 4..6
+              when 4..7
                 :rails_notifications
               else
                 ::NewRelic::Agent.logger.warn "Detected untested Rails version #{Rails::VERSION::STRING}"

data/lib/new_relic/agent/guid_generator.rb

@@ -5,8 +5,6 @@
 module NewRelic
   module Agent
     module GuidGenerator
-      HEX_DIGITS = (0..15).map { |i| i.to_s(16) }
-
       module_function
 
       # This method intentionally does not use SecureRandom, because it relies
@@ -15,11 +13,8 @@ module NewRelic
       # The guids generated by this method may not be _secure_, but they are
       # random enough for our purposes.
       def generate_guid length = 16
-        guid = ''
-        length.times do |a|
-          guid << HEX_DIGITS[rand(16)]
-        end
-        guid
+        guid = rand(16**length).to_s(16)
+        guid.length < length ? guid.rjust(length, "0") : guid
       end
     end
   end

data/lib/new_relic/agent/instrumentation/active_storage.rb

@@ -13,7 +13,7 @@ DependencyDetection.defer do
   end
 
   executes do
-    ::NewRelic::Agent.logger.info 'Installing ActiveStorage 5 instrumentation'
+    ::NewRelic::Agent.logger.info 'Installing ActiveStorage instrumentation'
   end
 
   executes do

data/lib/new_relic/agent/parameter_filtering.rb

@@ -9,10 +9,20 @@ module NewRelic
 
       ACTION_DISPATCH_PARAMETER_FILTER = "action_dispatch.parameter_filter".freeze
 
-      RAILS_FILTER_CLASS = if defined?(ActiveSupport::ParameterFilter)
-        ActiveSupport::ParameterFilter
-      elsif defined?(ActionDispatch::Http::ParameterFilter)
-        ActionDispatch::Http::ParameterFilter
+      if defined?(Rails) && Gem::Version.new(::Rails::VERSION::STRING) >= Gem::Version.new('5.0.0')
+        Rails.application.config.to_prepare do
+          RAILS_FILTER_CLASS = if defined?(ActiveSupport::ParameterFilter)
+            ActiveSupport::ParameterFilter
+          elsif defined?(ActionDispatch::Http::ParameterFilter)
+            ActionDispatch::Http::ParameterFilter
+          end
+        end
+      else
+        RAILS_FILTER_CLASS = if defined?(ActiveSupport::ParameterFilter)
+          ActiveSupport::ParameterFilter
+        elsif defined?(ActionDispatch::Http::ParameterFilter)
+          ActionDispatch::Http::ParameterFilter
+        end
       end
 
       def apply_filters(env, params)

data/lib/new_relic/control/frameworks/sinatra.rb

@@ -8,6 +8,12 @@ module NewRelic
     module Frameworks
       # Contains basic control logic for Sinatra
       class Sinatra < NewRelic::Control::Frameworks::Ruby
+        protected
+
+        def install_shim
+          super
+          ::Sinatra::Base.class_eval { include NewRelic::Agent::Instrumentation::ControllerInstrumentation::Shim }
+        end
       end
     end
   end

data/lib/new_relic/version.rb

@@ -10,7 +10,7 @@ module NewRelic
     end
 
     MAJOR = 8
-    MINOR = 3
+    MINOR = 4
     TINY = 0
 
     begin

data/newrelic_rpm.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |s|
   s.version = NewRelic::VERSION::STRING
   s.required_ruby_version = '>= 2.2.0'
   s.required_rubygems_version = Gem::Requirement.new("> 1.3.1") if s.respond_to? :required_rubygems_version=
-  s.authors = ["Tanna McClure", "Kayla Reopelle"]
+  s.authors = ["Tanna McClure", "Kayla Reopelle", "James Bunch"]
   s.licenses = ['Apache-2.0']
   s.description = <<-EOS
 New Relic is a performance management system, developed by New Relic,

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: newrelic_rpm
 version: !ruby/object:Gem::Version
-  version: 8.3.0
+  version: 8.4.0
 platform: ruby
 authors:
 - Tanna McClure
 - Kayla Reopelle
+- James Bunch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-10 00:00:00.000000000 Z
+date: 2022-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -232,6 +233,7 @@ files:
 - ".project"
 - ".rubocop.yml"
 - ".yardopts"
+- Brewfile
 - CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile