newrelic_rpm 8.2.0 → 8.3.0

data/lib/new_relic/version.rb

@@ -3,16 +3,15 @@
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
 
-
 module NewRelic
-  module VERSION #:nodoc:
+  module VERSION # :nodoc:
     def self.build_version_string(*parts)
       parts.compact.join('.')
     end
 
     MAJOR = 8
-    MINOR = 2
-    TINY  = 0
+    MINOR = 3
+    TINY = 0
 
     begin
       require File.join(File.dirname(__FILE__), 'build')

data/lib/sequel/extensions/newrelic_instrumentation.rb

@@ -3,13 +3,12 @@
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
 
-require 'sequel' unless defined?( Sequel )
-require 'newrelic_rpm' unless defined?( NewRelic )
+require 'sequel' unless defined?(Sequel)
+require 'newrelic_rpm' unless defined?(NewRelic)
 require 'new_relic/agent/instrumentation/sequel_helper'
 require 'new_relic/agent/datastores/metric_helper'
 
 module Sequel
-
   # New Relic's Sequel instrumentation is implemented via a plugin for
   # Sequel::Models, and an extension for Sequel::Databases. Every database
   # handle that Sequel knows about when New Relic is loaded will automatically
@@ -31,7 +30,6 @@ module Sequel
   # `disable_activerecord_instrumentation` setting.
   #
   module NewRelicInstrumentation
-
     module Naming
       def self.query_method_name
         if Sequel::VERSION >= "4.35.0"
@@ -42,7 +40,7 @@ module Sequel
       end
     end
 
-    define_method Naming.query_method_name do |*args, &blk| #THREAD_LOCAL_ACCESS
+    define_method Naming.query_method_name do |*args, &blk| # THREAD_LOCAL_ACCESS
       sql = args.first
 
       product = NewRelic::Agent::Instrumentation::SequelHelper.product_name_from_adapter(self.class.adapter_scheme)
@@ -86,7 +84,7 @@ module Sequel
     def explainer_for sql
       Proc.new do |*|
         if THREAD_SAFE_CONNECTION_POOL_CLASSES.include?(self.pool.class)
-          self[ sql ].explain
+          self[sql].explain
         else
           NewRelic::Agent.logger.log_once(:info, :sequel_explain_skipped, "Not running SQL explains because Sequel is not in recognized multi-threaded mode")
           nil
@@ -97,5 +95,4 @@ module Sequel
 
   NewRelic::Agent.logger.debug "Registering the :newrelic_instrumentation extension."
   Database.register_extension(:newrelic_instrumentation, NewRelicInstrumentation)
-
 end # module Sequel

data/lib/sequel/plugins/newrelic_instrumentation.rb

@@ -3,23 +3,21 @@
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
 
-require 'sequel' unless defined?( Sequel )
-require 'newrelic_rpm' unless defined?( NewRelic )
+require 'sequel' unless defined?(Sequel)
+require 'newrelic_rpm' unless defined?(NewRelic)
 require 'new_relic/agent/instrumentation/sequel_helper'
 require 'new_relic/agent/datastores/metric_helper'
 
 module Sequel
   module Plugins
-
     # Sequel::Model instrumentation for the New Relic agent.
     module NewrelicInstrumentation
-
       # Meta-programming for creating method tracers for the Sequel::Model plugin.
       module MethodWrapping
         # Install a method named +method_name+ that will trace execution
         # with a metric name derived from +operation_name+ (or +method_name+ if +operation_name+
         # isn't specified).
-        def wrap_sequel_method(method_name, operation_name=method_name)
+        def wrap_sequel_method(method_name, operation_name = method_name)
           define_method(method_name) do |*args, &block|
             klass = self.is_a?(Class) ? self : self.class
             product = NewRelic::Agent::Instrumentation::SequelHelper.product_name_from_adapter(db.adapter_scheme)
@@ -36,7 +34,6 @@ module Sequel
             end
           end
         end
-
       end # module MethodTracer
 
       # Methods to be added to Sequel::Model instances.
@@ -51,10 +48,8 @@ module Sequel
         wrap_sequel_method :update_fields
         wrap_sequel_method :update_only
         wrap_sequel_method :save
-
       end # module InstanceMethods
 
-
       # Methods to be added to Sequel::Model classes.
       module ClassMethods
         extend Sequel::Plugins::NewrelicInstrumentation::MethodWrapping
@@ -64,7 +59,6 @@ module Sequel
         wrap_sequel_method :first
         wrap_sequel_method :create
       end # module ClassMethods
-
     end # module NewRelicInstrumentation
   end # module Plugins
 end # module Sequel

data/lib/tasks/all.rb

@@ -3,6 +3,6 @@
 # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
 
 # This is required to load in task definitions
-Dir.glob(File.join(File.dirname(__FILE__),'*.rake')) do |file|
+Dir.glob(File.join(File.dirname(__FILE__), '*.rake')) do |file|
   load file
 end

data/lib/tasks/config.rake

@@ -2,22 +2,22 @@ namespace :newrelic do
   namespace :config do
     desc "Describe available New Relic configuration settings."
 
-    GENERAL    = "general"
-    DISABLING  = "disabling"
+    GENERAL = "general"
+    DISABLING = "disabling"
     ATTRIBUTES = "attributes"
 
     SECTION_DESCRIPTIONS = {
-      GENERAL              => 'These settings are available for agent configuration. Some settings depend on your New Relic subscription level.',
-      DISABLING            => 'Use these settings to toggle instrumentation types during agent startup.',
-      ATTRIBUTES           => '[Attributes](/docs/features/agent-attributes) are key-value pairs containing information that determines the properties of an event or transaction. These key-value pairs can be viewed within transaction traces in APM, traced errors in APM, transaction events in dashboards, and page views in dashboards. You can customize exactly which attributes will be sent to each of these destinations',
+      GENERAL => 'These settings are available for agent configuration. Some settings depend on your New Relic subscription level.',
+      DISABLING => 'Use these settings to toggle instrumentation types during agent startup.',
+      ATTRIBUTES => '[Attributes](/docs/features/agent-attributes) are key-value pairs containing information that determines the properties of an event or transaction. These key-value pairs can be viewed within transaction traces in APM, traced errors in APM, transaction events in dashboards, and page views in dashboards. You can customize exactly which attributes will be sent to each of these destinations',
       "transaction_tracer" => 'The [transaction traces](/docs/apm/traces/transaction-traces/transaction-traces) feature collects detailed information from a selection of transactions, including a summary of the calling sequence, a breakdown of time spent, and a list of SQL queries and their query plans (on mysql and postgresql). Available features depend on your New Relic subscription level.',
-      "error_collector"    => 'The agent collects and reports all uncaught exceptions by default. These configuration options allow you to customize the error collection.',
+      "error_collector" => 'The agent collects and reports all uncaught exceptions by default. These configuration options allow you to customize the error collection.',
       "browser_monitoring" => 'The Browser monitoring [page load timing](/docs/browser/new-relic-browser/page-load-timing/page-load-timing-process) feature (sometimes referred to as real user monitoring or RUM) gives you insight into the performance real users are experiencing with your website. This is accomplished by measuring the time it takes for your users\' browsers to download and render your web pages by injecting a small amount of JavaScript code into the header and footer of each page.',
-      "analytics_events"   => '[New Relic dashboards](/docs/query-your-data/explore-query-data/dashboards/introduction-new-relic-one-dashboards) is a resource to gather and visualize data about your software and what it says about your business. With it you can quickly and easily create real-time dashboards to get immediate answers about end-user experiences, clickstreams, mobile activities, and server transactions.'
+      "analytics_events" => '[New Relic dashboards](/docs/query-your-data/explore-query-data/dashboards/introduction-new-relic-one-dashboards) is a resource to gather and visualize data about your software and what it says about your business. With it you can quickly and easily create real-time dashboards to get immediate answers about end-user experiences, clickstreams, mobile activities, and server transactions.'
     }
 
     NAME_OVERRIDES = {
-      "slow_sql"     => "Slow SQL"
+      "slow_sql" => "Slow SQL"
     }
 
     def output(format)
@@ -29,7 +29,7 @@ namespace :newrelic do
     end
 
     def build_config_hash
-      sections = Hash.new {|hash, key| hash[key] = []}
+      sections = Hash.new { |hash, key| hash[key] = [] }
       NewRelic::Agent::Configuration::DEFAULTS.each do |key, value|
         next unless value[:public]
 
@@ -37,20 +37,20 @@ namespace :newrelic do
         key = key.to_s
         components = key.split(".")
 
-        if key.match(/^disable_/)           # "disable_httpclient"
+        if key.match(/^disable_/) # "disable_httpclient"
           section_key = DISABLING
-        elsif components.length == 2        # "analytics_events.enabled"
+        elsif components.length == 2 # "analytics_events.enabled"
           section_key = components.first
         elsif components[1] == "attributes" # "transaction_tracer.attributes.enabled"
           section_key = ATTRIBUTES
         end
 
         sections[section_key] << {
-          :key         => key,
-          :type        => format_type(value[:type]),
+          :key => key,
+          :type => format_type(value[:type]),
           :description => format_description(value),
-          :default     => format_default_value(value),
-          :env_var     => format_env_var(key)
+          :default => format_default_value(value),
+          :env_var => format_env_var(key)
         }
       end
       sections
@@ -60,10 +60,10 @@ namespace :newrelic do
       sections = []
       sections << pluck(GENERAL, config_hash)
       sections << pluck("transaction_tracer", config_hash)
-      sections << pluck("error_collector",    config_hash)
+      sections << pluck("error_collector", config_hash)
       sections << pluck("browser_monitoring", config_hash)
-      sections << pluck("analytics_events",   config_hash)
-      sections.concat(config_hash.to_a.sort_by { |a| a.first})
+      sections << pluck("analytics_events", config_hash)
+      sections.concat(config_hash.to_a.sort_by { |a| a.first })
 
       add_data_to_sections(sections)
 
@@ -82,9 +82,9 @@ namespace :newrelic do
       name = NAME_OVERRIDES[key]
       return name if name
 
-      key.split("_").
-          each { |fragment| fragment[0] = fragment[0].upcase }.
-          join(" ")
+      key.split("_")
+        .each { |fragment| fragment[0] = fragment[0].upcase }
+        .join(" ")
     end
 
     def format_type(type)

data/lib/tasks/multiverse.rb

@@ -42,10 +42,9 @@ namespace :test do
   end
 
   namespace :multiverse do
-
     def remove_local_multiverse_databases
-      list_databases_command = %{echo "show databases" | mysql -u root}
-      databases = `#{list_databases_command}`.chomp!.split("\n").select{|s| s =~ /multiverse/}
+      list_databases_command = %(echo "show databases" | mysql -u root)
+      databases = `#{list_databases_command}`.chomp!.split("\n").select { |s| s =~ /multiverse/ }
       databases.each do |database|
         puts "Dropping #{database}"
         `echo "drop database #{database}" | mysql -u root`
@@ -58,7 +57,7 @@ namespace :test do
     def remove_generated_gemfiles
       file_path = File.expand_path "test/multiverse/suites"
       Dir.glob(File.join file_path, "**", "Gemfile*").each do |fn|
-        puts "Removing #{fn.gsub(file_path,'.../suites')}"
+        puts "Removing #{fn.gsub(file_path, '.../suites')}"
         FileUtils.rm fn
       end
     end
@@ -66,7 +65,7 @@ namespace :test do
     def remove_generated_gemfile_lockfiles
       file_path = File.expand_path "test/environments"
       Dir.glob(File.join file_path, "**", "Gemfile.lock").each do |fn|
-        puts "Removing #{fn.gsub(file_path,'.../environments')}"
+        puts "Removing #{fn.gsub(file_path, '.../environments')}"
         FileUtils.rm fn
       end
     end
@@ -99,6 +98,5 @@ namespace :test do
     task :prime, [:suite] => [:env] do |_, args|
       Multiverse::Runner.prime(args.suite, Multiverse::Runner.parse_args(args))
     end
-
   end
 end

data/lib/tasks/tests.rake

@@ -9,26 +9,23 @@ if defined? Rake::TestTask
       matches = tasks.map { |t| /(seed=.*?)[,\]]/.match(t) }.compact
       if matches.any?
         matches.first[1]
-      else
-        nil
       end
     end
 
     tasks = Rake.application.top_level_tasks
     ENV["TESTOPTS"] ||= ""
-    if tasks.any? { |t| t.include?("verbose")}
+    if tasks.any? { |t| t.include?("verbose") }
       ENV["TESTOPTS"] += " -v"
     end
     if seed = look_for_seed(tasks)
       ENV["TESTOPTS"] += " --" + seed
     end
 
-    agent_home = File.expand_path(File.join(File.dirname(__FILE__),'..','..'))
+    agent_home = File.expand_path(File.join(File.dirname(__FILE__), '..', '..'))
 
     Rake::TestTask.new(:newrelic) do |t|
-      
       file_pattern = ENV["file"]
-      file_pattern = file_pattern.split(",").map{|f| "#{agent_home}/#{f}".gsub("//", "/")} if file_pattern
+      file_pattern = file_pattern.split(",").map { |f| "#{agent_home}/#{f}".gsub("//", "/") } if file_pattern
       file_pattern ||= "#{agent_home}/test/new_relic/**/*_test.rb"
 
       t.libs << "#{agent_home}/test"
@@ -36,6 +33,5 @@ if defined? Rake::TestTask
       t.pattern = Array(file_pattern)
       t.verbose = true
     end
-
   end
 end

data/newrelic_rpm.gemspec

@@ -8,11 +8,10 @@ require 'new_relic/latest_changes'
 Gem::Specification.new do |s|
   s.name = "newrelic_rpm"
   s.version = NewRelic::VERSION::STRING
-  s.required_ruby_version = '>= 2.0.0'
+  s.required_ruby_version = '>= 2.2.0'
   s.required_rubygems_version = Gem::Requirement.new("> 1.3.1") if s.respond_to? :required_rubygems_version=
-  s.authors = [ "Aaron Huntsman", "Tanna McClure", "Kayla Reopelle" ]
-  s.date = Time.now.strftime('%Y-%m-%d')
-  s.licenses    = ['Apache-2.0']
+  s.authors = ["Tanna McClure", "Kayla Reopelle"]
+  s.licenses = ['Apache-2.0']
   s.description = <<-EOS
 New Relic is a performance management system, developed by New Relic,
 Inc (http://www.newrelic.com).  New Relic provides you with deep
@@ -20,9 +19,9 @@ information about the performance of your web application as it runs
 in production. The New Relic Ruby agent is dual-purposed as a either a
 Gem or plugin, hosted on
 https://github.com/newrelic/newrelic-ruby-agent/
-EOS
+  EOS
   s.email = "support@newrelic.com"
-  s.executables = [ "mongrel_rpm", "newrelic_cmd", "newrelic", "nrdebug" ]
+  s.executables = ["mongrel_rpm", "newrelic_cmd", "newrelic", "nrdebug"]
   s.extra_rdoc_files = [
     "CHANGELOG.md",
     "LICENSE",
@@ -32,11 +31,11 @@ EOS
   ]
 
   s.metadata = {
-    'bug_tracker_uri'   => 'https://github.com/newrelic/newrelic-ruby-agent/issues',
-    'changelog_uri'     => 'https://github.com/newrelic/newrelic-ruby-agent/blob/main/CHANGELOG.md',
+    'bug_tracker_uri' => 'https://github.com/newrelic/newrelic-ruby-agent/issues',
+    'changelog_uri' => 'https://github.com/newrelic/newrelic-ruby-agent/blob/main/CHANGELOG.md',
     'documentation_uri' => 'https://docs.newrelic.com/docs/agents/ruby-agent',
-    'source_code_uri'   => 'https://github.com/newrelic/newrelic-ruby-agent',
-    "homepage_uri"      => "https://newrelic.com/ruby",
+    'source_code_uri' => 'https://github.com/newrelic/newrelic-ruby-agent',
+    "homepage_uri" => "https://newrelic.com/ruby"
   }
 
   file_list = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features|infinite_tracing|\.github)/(?!agent_helper.rb)}) }
@@ -50,8 +49,8 @@ EOS
   s.summary = "New Relic Ruby Agent"
 
   s.add_development_dependency 'rake', '12.3.3'
-  s.add_development_dependency 'rb-inotify', '0.9.10'   # locked to support < Ruby 2.3 (and listen 3.0.8)
-  s.add_development_dependency 'listen', '3.0.8'        # locked to support < Ruby 2.3
+  s.add_development_dependency 'rb-inotify', '0.9.10' # locked to support < Ruby 2.3 (and listen 3.0.8)
+  s.add_development_dependency 'listen', '3.0.8' # locked to support < Ruby 2.3
   s.add_development_dependency 'minitest', '4.7.5'
   s.add_development_dependency 'mocha', '~> 1.9.0'
   s.add_development_dependency 'yard'
@@ -61,4 +60,6 @@ EOS
   s.add_development_dependency 'guard-minitest', '~> 2.4.0'
   s.add_development_dependency 'hometown', '~> 0.2.5'
   s.add_development_dependency 'bundler'
+  s.add_development_dependency 'rubocop'
+  s.add_development_dependency 'rubocop-performance'
 end

data/recipes/newrelic.rb

@@ -7,4 +7,4 @@
 # the lib directory.  We have to make them available from
 # both locations
 
-require File.join(File.dirname(__FILE__),'..','lib','new_relic','recipes')
+require File.join(File.dirname(__FILE__), '..', 'lib', 'new_relic', 'recipes')