newrelic_rpm 8.12.0 → 8.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5b512b5154279638e712582a488b0021e9aa834163183b3172e8489701bdcc0c
-  data.tar.gz: d44c55615a3b25be8900bf565ed29f5270be9bf6905f163f4bce9865610526cb
+  metadata.gz: 4c5439c88f9169482c8899f11dc1f44062a80416ec8c8afa6e29fc426adf716e
+  data.tar.gz: 496c2021677de4853c07550f43d76fc78c73cd3dcae8b5e632f72e7f8e1db68f
 SHA512:
-  metadata.gz: 861c112f97dd3c843127264c3a50a34f5601a50addd7378ceec59c8663e58130d5da152f89e2e91cb47ccc6b70cc56f7ad22484357597c4d4b5ae08d01687142
-  data.tar.gz: 584f780e7fdc1029b1d97494a545f488c627c59e3fe1a5729cb7f8f3463ad1cf969ada3f77dbf01c1e4e53fa2c84189a88e22f59c1e1d0ab9abfeb8a00d3fbc9
+  metadata.gz: fdc8298c1fc3f96a1ed63a919ff5aed1bfbdf423a9e1f4b69afb21b9729000e53c4f28c59a776e854875160c4accc9b0b6eff5a019b435c6582eadeba688bb05
+  data.tar.gz: 9375a116af17397f6c05dc6d0a9d413ff147f097647340e1dd4f635f457398caf437034ad92a64ba10cbe4e7ee5db076cc9bdc447c32ecaf20f5ad6cf1f9948b

data/.rubocop.yml

@@ -1331,12 +1331,15 @@ Style/MethodCallWithArgsParentheses:
     - add_development_dependency
     - expect
     - fail
+    - gem
     - include
     - print
     - puts
+    - pp
     - raise
     - require
     - skip
+    - source
     - stub
   AllowedPatterns: [^assert, ^refute]
 

data/.rubocop_todo.yml

@@ -14,15 +14,9 @@ Metrics/AbcSize:
     - test/**/*
     - infinite_tracing/test/**/*
 
-# Offense count: 145
 # This cop supports safe autocorrection (--autocorrect).
 Minitest/AssertInDelta:
-  Enabled: false
-
-# Offense count: 145
-# This cop supports safe autocorrection (--autocorrect).
-Minitest/AssertPredicate:
-  Enabled: false
+  Enabled: true
 
 # Offense count: 7
 Minitest/AssertRaisesCompoundBody:
@@ -50,3 +44,16 @@ Minitest/RefutePredicate:
 # This cop supports safe autocorrection (--autocorrect).
 Minitest/TestMethodName:
   Enabled: false
+
+Minitest/RefuteRespondTo:
+  Exclude:
+    - 'test/new_relic/cli/commands/deployments_test.rb'
+
+Minitest/EmptyLineBeforeAssertionMethods:
+  Exclude:
+    - 'test/new_relic/agent_test.rb'
+    - 'test/new_relic/cli/commands/deployments_test.rb'
+
+Style/RedundantStringEscape:
+  Exclude:
+    - 'test/new_relic/agent/logging_test.rb'

data/CHANGELOG.md

@@ -1,5 +1,47 @@
 # New Relic Ruby Agent Release Notes #
 
+  ## v8.13.1
+
+  Version 8.13.1 of the agent provides a bugfix for Redis v5.0 instrumentation.
+
+  * **Fix NoMethodError when using Sidekiq v7.0 with Redis Client v0.11**
+
+    In some cases, the `RedisClient` object cannot directly access methods like db, port, or path. These methods are always available on the `client.config` object. This raised a `NoMethodError` in environments that used Sidekiq v7.0 and [Redis Client](https://rubygems.org/gems/redis-client) v0.11. Thank you to [fcheung](https://github.com/fcheung) and [@stevenou](https://github.com/stevenou) for bringing this to our attention! [Issue#1639](https://github.com/newrelic/newrelic-ruby-agent/issues/1639)
+
+
+  ## v8.13.0
+
+  Version 8.13.0 of the agent updates our Rack, Redis, and Sidekiq instrumentation. It also delivers some bugfixes.
+
+  * **Support for Redis v5.0**
+
+    Redis v5.0 restructures where some of our instrumented methods are located and how they are named. It also introduces a new [instrumentation middleware API](https://github.com/redis-rb/redis-client#instrumentation-and-middlewares). This API is used for pipelined and multi calls to maintain reporting parity with previous Redis versions. However, it is introduced later in the chain, so you may see errors that used to appear at the segment level on the transaction instead. The agent's behavior when used with older supported Redis versions will remain unaffected. [PR#1611](https://github.com/newrelic/newrelic-ruby-agent/pull/1611)
+
+  * **Support for Sidekiq v7.0**
+
+    Sidekiq v7.0 removed Delayed Extensions and began offering client and server [middleware](https://github.com/mperham/sidekiq/blob/main/docs/middleware.md) classes to inherit from. The agent's Sidekiq instrumentation has been updated accordingly. The agent's behavior when used with older Sidekiq versions will remain unaffected. [PR#1615](https://github.com/newrelic/newrelic-ruby-agent/pull/1615) **NOTE:** an issue was discovered with Sidekiq v7.0+ and addressed by Ruby agent v8.13.1. If you are using Sidekiq, please skip Ruby agent v8.13.0 and use v8.13.1 or above.
+
+  * **Support for Rack v3.0: Rack::Builder#new accepting a block**
+
+    Via [rack/rack#1942](https://github.com/rack/rack/pull/1942) (released with Rack v3.0), `Rack::Builder#run` now optionally accepts a block instead of an app argument. The agent's instrumentation has been updated to support the use of a block with `Rack::Builder#run`. [PR#1600](https://github.com/newrelic/newrelic-ruby-agent/pull/1600)
+
+  * **Bugfix: Correctly identify Unicorn, Rainbows and FastCGI with Rack v3.0**
+
+    Unicorn, Rainbows, or FastCGI web applications using Rack v3.0 may previously have had the "dispatcher" value incorrectly reported as "Webrick" instead of "Unicorn", "Rainbows", or "FastCGI". This issue has now been addressed. [PR#1585](https://github.com/newrelic/newrelic-ruby-agent/pull/1585)
+
+  * **Bugfix: add_method_tracer fails to record code level metric attributes on private methods**
+
+    When using `add_method_tracer` on a private method, the agent was unable to record code level metrics for the method. This resulted in the following being logged to the newrelic_agent.log file.
+    ```
+    WARN : Unable to determine source code info for 'Example', method 'private_method' - NameError: undefined method 'private_method' for class '#<Class:Example>'
+    ```
+    Thank you [@jdelStrother](https://github.com/jdelStrother) for bringing this issue to our attention and suggesting a fix! [PR#1593](https://github.com/newrelic/newrelic-ruby-agent/pull/1593)
+
+
+  * **Bugfix: Category is a required keyword arg for NewRelic::Agent::Tracer.in_transaction**
+
+    When support for Ruby 2.0 was dropped in version 8.0.0 of the agent, the agent API methods were updated to use the required keyword argument feature built into Ruby, rather than manually raising ArgumentErrors. The API method `NewRelic::Agent::Tracer.in_transaction` removed the ArgumentError raised by the agent, but did not update the method arguments to identify `:category` as a required keyword argument. This is now resolved. Thank you [@tatzsuzuki](https://github.com/tatzsuzuki) for bringing this to our attention. [PR#1587](https://github.com/newrelic/newrelic-ruby-agent/pull/1587)
+
   ## v8.12.0
 
   Version 8.12.0 of the agent delivers new Elasticsearch instrumentation, increases the default number of recorded Custom Events, announces the deprecation of Ruby 2.3, and brings some valuable code cleanup.

data/README.md

@@ -1,4 +1,4 @@
-[![Blue banner - Community Plus: This code is currently maintained by New Relic engineering teams and delivered here in GitHub. See the README for troubleshooting and defect reporting instructions.](https://github.com/newrelic/opensource-website/raw/master/src/images/categories/Community_Plus.png)](https://opensource.newrelic.com/oss-category/#community-plus)
+[![Blue banner - Community Plus: This code is currently maintained by New Relic engineering teams and delivered here in GitHub. See the README for troubleshooting and defect reporting instructions.](https://github.com/newrelic/opensource-website/raw/main/src/images/categories/Community_Plus.png)](https://opensource.newrelic.com/oss-category/#community-plus)
 
 # New Relic Ruby Agent
 
@@ -76,12 +76,11 @@ For complete documentation on installing the New Relic Ruby agent, see the follo
 
 ### Recording Deploys
 
-The Ruby agent supports* recording deployments in New Relic via a command line
+The Ruby agent supports recording deployments in New Relic via a command line
 tool or Capistrano recipes. For more information on these features, see
 [our deployment documentation](http://docs.newrelic.com/docs/ruby/recording-deployments-with-the-ruby-agent)
 for more information.
 
-*There is a [known issue](https://github.com/newrelic/newrelic-ruby-agent/issues/715) that prevents newly generated New Relic API keys from recording deploys.
 
 ## Support
 

data/lib/new_relic/agent/agent_logger.rb

@@ -132,7 +132,7 @@ module NewRelic
       end
 
       def wants_stdout?
-        ::NewRelic::Agent.config[:log_file_path].casecmp("STDOUT").zero?
+        ::NewRelic::Agent.config[:log_file_path].casecmp(NewRelic::STANDARD_OUT) == 0
       end
 
       def find_or_create_file_path(path_setting, root)

data/lib/new_relic/agent/audit_logger.rb

@@ -95,7 +95,7 @@ module NewRelic
       end
 
       def wants_stdout?
-        ::NewRelic::Agent.config[:'audit_log.path'].casecmp("STDOUT").zero?
+        ::NewRelic::Agent.config[:'audit_log.path'].casecmp(NewRelic::STANDARD_OUT) == 0
       end
 
       def create_log_formatter