newrelic_rpm 8.12.0 → 8.13.0

data/lib/new_relic/local_environment.rb

@@ -71,10 +71,10 @@ module NewRelic
         thin
         mongrel
         litespeed
+        unicorn
         webrick
         fastcgi
         rainbows
-        unicorn
       ]
       # TODO: MAJOR VERSION - remove rainbows
       while dispatchers.any? && @discovered_dispatcher.nil?

data/lib/new_relic/rack/browser_monitoring.rb

@@ -104,6 +104,7 @@ module NewRelic
       end
 
       def streaming?(env, headers)
+        # Chunked transfer encoding is a streaming data transfer mechanism available only in HTTP/1.1
         return true if headers && headers['Transfer-Encoding'] == 'chunked'
 
         defined?(ActionController::Live) &&

data/lib/new_relic/version.rb

@@ -6,7 +6,7 @@
 module NewRelic
   module VERSION # :nodoc:
     MAJOR = 8
-    MINOR = 12
+    MINOR = 13
     TINY = 0
 
     STRING = "#{MAJOR}.#{MINOR}.#{TINY}"

data/lib/tasks/helpers/prompt.rb

@@ -15,7 +15,7 @@ module Prompt
     puts
     print "Do you wish to continue? ('y' to continue, return to cancel) [n] "
     continue = STDIN.gets.chomp
-    if continue.casecmp('y').zero?
+    if continue.casecmp('y') == 0
       system(command)
     else
       puts 'Cancelled'

data/lib/tasks/instrumentation_generator/README.md

@@ -58,6 +58,6 @@ Furthermore, we also create very similar snippets inside the default source conf
 
 ## Outcome
 
-A prototype outside the agent has been created that generates the required files to create new instrumentation. This prototype accepts three arguments: name (name of the library), method (method to instrument), args (arguments for the method).
+A prototype outside the agent was first created. This prototype generated the required files to add instrumentation. The prototype accepted three arguments: name (name of the library), method (method to instrument), args (arguments for the method). This prototype has evolved into the current directory.
 
-The Ruby gem Thor, a toolkit for building powerful command-line interfaces used in Bundler, Vagrant, Rails and others powers this CLI.
+This project leverages the Ruby gem Thor, a toolkit for building powerful command-line interfaces used in Bundler, Vagrant, Rails and others powers this CLI.

data/lib/tasks/instrumentation_generator/TODO.md

@@ -22,12 +22,12 @@
 
 # - [ ] Append a new method to instrument to an existing instrumentation class (with tests?)
 
-# - [ ] Documentation: examples of what to add in each gap
-
-# - [ ] Good examples of tests, instrumentation, etc. as comments
+# - [ ] Documentation: examples of what to add in each gap (Good examples of tests, instrumentation, etc. as comments to guide users)
 
 # - [ ] Handle multi-word gem names (camel case for classes, handle hyphens, concurrent-ruby as example)
 
-# - [ ] Make sure multiple arguments can be passed to the command line
+# - [ ] Allow multiple method arguments to be passed to the command line
+
+# - [ ] Add tests for the instrumentation_generator code
 
-# - [ ] Add tests
+# - [ ] See if instrumentation PRs can get automatically generated when an already instrumented library adds methods to its codebase

data/newrelic_rpm.gemspec

@@ -51,7 +51,7 @@ https://github.com/newrelic/newrelic-ruby-agent/
   s.add_development_dependency 'httparty' unless ENV['CI'] # for perf tests and Gabby
   s.add_development_dependency 'minitest', "#{RUBY_VERSION >= '2.7.0' ? '5.3.3' : '4.7.5'}"
   s.add_development_dependency 'minitest-stub-const', '0.6'
-  s.add_development_dependency 'mocha', '~> 1.14.0'
+  s.add_development_dependency 'mocha', '~> 1.16'
   s.add_development_dependency 'pry' unless ENV['CI']
   s.add_development_dependency 'rake', '12.3.3'
   s.add_development_dependency 'rubocop' unless ENV['CI'] && RUBY_VERSION < '3.0.0'

data/test/agent_helper.rb

@@ -48,6 +48,7 @@ end
 
 def assert_has_traced_error(error_class)
   errors = harvest_error_traces!
+
   refute_nil errors.find { |e| e.exception_class_name == error_class.name }, \
     "Didn't find error of class #{error_class}"
 end
@@ -83,6 +84,7 @@ end
 unless defined? assert_includes
   def assert_includes(collection, member, msg = nil)
     msg = "Expected #{collection.inspect} to include #{member.inspect}"
+
     assert_includes collection, member, msg
   end
 end
@@ -90,6 +92,7 @@ end
 unless defined? assert_not_includes
   def assert_not_includes(collection, member, msg = nil)
     msg = "Expected #{collection.inspect} not to include #{member.inspect}"
+
     refute_includes collection, member, msg
   end
 end
@@ -107,6 +110,7 @@ end
 
 def assert_log_contains(log, message)
   lines = log.array
+
   assert (lines.any? { |line| line.match(message) })
 end
 
@@ -117,6 +121,7 @@ def assert_audit_log_contains(audit_log_contents, needle)
   regex = /[:"]/
   needle = needle.gsub(regex, '')
   haystack = audit_log_contents.gsub(regex, '')
+
   assert_includes(haystack, needle, "Expected log to contain '#{needle}'")
 end
 
@@ -136,10 +141,12 @@ def assert_audit_log_contains_object(audit_log_contents, o, format = :json)
       assert_audit_log_contains_object(audit_log_contents, k, format)
     end
   when Array
+
     o.each do |el|
       assert_audit_log_contains_object(audit_log_contents, el, format)
     end
   when NilClass
+
     assert_audit_log_contains(audit_log_contents, format == :json ? "null" : "nil")
   else
     assert_audit_log_contains(audit_log_contents, o.inspect)
@@ -148,6 +155,7 @@ end
 
 def compare_metrics(expected, actual)
   actual.delete_if { |a| a.include?('GC/Transaction/') }
+
   assert_equal(expected.to_a.sort, actual.to_a.sort, "extra: #{(actual - expected).to_a.inspect}; missing: #{(expected - actual).to_a.inspect}")
 end
 
@@ -206,6 +214,7 @@ def assert_stats_has_values_with_call_count(expected_value, actual_value, msg)
   if expected_value.to_s =~ /([<>]=?)\s*(\d+)/
     operator = Regexp.last_match(1).to_sym
     count = Regexp.last_match(2).to_i
+
     assert_operator(actual_value, operator, count, msg)
   # == comparison
   else
@@ -229,6 +238,7 @@ def assert_metrics_recorded(expected)
 
       assert(actual_stats, msg) # rubocop:disable Minitest/AssertWithExpectedArgument
     end
+
     assert_stats_has_values(actual_stats, expected_spec, expected_attrs)
   end
 end
@@ -246,6 +256,7 @@ end
 #
 def assert_metrics_recorded_exclusive(expected, options = {})
   expected = _normalize_metric_expectations(expected)
+
   assert_metrics_recorded(expected)
 
   recorded_metrics = NewRelic::Agent.instance.stats_engine.to_h.keys
@@ -300,6 +311,7 @@ def assert_metrics_not_recorded(not_expected)
       found_but_not_expected << spec
     end
   end
+
   assert_empty(found_but_not_expected, "Found unexpected metrics: #{format_metric_spec_list(found_but_not_expected)}")
 end
 
@@ -328,11 +340,13 @@ end
 
 def assert_truthy(expected, msg = nil)
   msg ||= "Expected #{expected.inspect} to be truthy"
+
   refute !expected, msg
 end
 
 def assert_falsy(expected, msg = nil)
   msg ||= "Expected #{expected.inspect} to be falsy"
+
   refute expected, msg
 end
 
@@ -888,6 +902,7 @@ def assert_event_attributes(event, test_name, expected_attributes, non_expected_
   event_attrs.each do |name, actual_value|
     msg << "  #{name}: #{actual_value.inspect}\n"
   end
+
   assert_empty(incorrect_attributes, msg)
 
   non_expected_attributes.each do |name|
@@ -950,6 +965,7 @@ end
 # the expectations against it.
 def assert_segment_noticed_error(txn, segment_name, error_classes, error_message)
   error_segment = txn.segments.reverse.detect { |s| s.noticed_error }
+
   assert error_segment, "Expected at least one segment with a noticed_error"
 
   assert_match_or_equal segment_name, error_segment.name
@@ -967,6 +983,7 @@ end
 
 def refute_transaction_noticed_error(txn, error_class)
   error_segment = txn.segments.reverse.detect { |s| s.noticed_error }
+
   assert error_segment, "Expected at least one segment with a noticed_error"
   assert_empty txn.exceptions, "Expected transaction to NOT notice any segment errors"
 end
@@ -984,6 +1001,7 @@ def refute_raises(*exp)
   rescue Exception => e
     puts "EXCEPTION RAISED: #{e.inspect}\n#{e.backtrace}"
     exp = exp.first if exp.size == 1
+
     flunk(msg || "unexpected exception raised: #{e}")
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: newrelic_rpm
 version: !ruby/object:Gem::Version
-  version: 8.12.0
+  version: 8.13.0
 platform: ruby
 authors:
 - Tanna McClure
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-10-26 00:00:00.000000000 Z
+date: 2022-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -61,14 +61,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.14.0
+        version: '1.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.14.0
+        version: '1.16'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -341,7 +341,9 @@ files:
 - lib/new_relic/agent/instrumentation/rake/prepend.rb
 - lib/new_relic/agent/instrumentation/redis.rb
 - lib/new_relic/agent/instrumentation/redis/chain.rb
+- lib/new_relic/agent/instrumentation/redis/constants.rb
 - lib/new_relic/agent/instrumentation/redis/instrumentation.rb
+- lib/new_relic/agent/instrumentation/redis/middleware.rb
 - lib/new_relic/agent/instrumentation/redis/prepend.rb
 - lib/new_relic/agent/instrumentation/resque.rb
 - lib/new_relic/agent/instrumentation/resque/chain.rb
@@ -351,6 +353,9 @@ files:
 - lib/new_relic/agent/instrumentation/sequel.rb
 - lib/new_relic/agent/instrumentation/sequel_helper.rb
 - lib/new_relic/agent/instrumentation/sidekiq.rb
+- lib/new_relic/agent/instrumentation/sidekiq/client.rb
+- lib/new_relic/agent/instrumentation/sidekiq/extensions/delayed_class.rb
+- lib/new_relic/agent/instrumentation/sidekiq/server.rb
 - lib/new_relic/agent/instrumentation/sinatra.rb
 - lib/new_relic/agent/instrumentation/sinatra/chain.rb
 - lib/new_relic/agent/instrumentation/sinatra/ignorer.rb