newrelic_rpm 6.9.0.363 → 6.10.0.364

data/lib/new_relic/agent/transaction/external_request_segment.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+# frozen_string_literal: true
 
 require 'new_relic/agent/transaction/segment'
 require 'new_relic/agent/http_clients/uri_util'
@@ -14,12 +15,16 @@ module NewRelic
       #
       # @api public
       class ExternalRequestSegment < Segment
-        NR_SYNTHETICS_HEADER = 'X-NewRelic-Synthetics'.freeze
-        EXTERNAL_TRANSACTION_PREFIX = 'ExternalTransaction/'.freeze
-        SLASH = '/'.freeze
-        APP_DATA_KEY = 'NewRelicAppData'.freeze
+        NR_SYNTHETICS_HEADER = 'X-NewRelic-Synthetics'
+        APP_DATA_KEY = 'NewRelicAppData'
+
+        EXTERNAL_ALL = "External/all"
+        EXTERNAL_ALL_WEB = "External/allWeb"
+        EXTERNAL_ALL_OTHER = "External/allOther"
+        MISSING_STATUS_CODE = "MissingHTTPStatusCode"
 
         attr_reader :library, :uri, :procedure
+        attr_reader :http_status_code
 
         def initialize library, uri, procedure, start_time = nil # :nodoc:
           @library = library
@@ -27,6 +32,7 @@ module NewRelic
           @procedure = procedure
           @host_header = nil
           @app_data = nil
+          @http_status_code = nil
           super(nil, nil, start_time)
         end
 
@@ -176,8 +182,23 @@ module NewRelic
           super
         end
 
+        def process_response_headers response # :nodoc:
+          set_http_status_code response
+          read_response_headers response
+        end
+
         private
 
+        # Only sets the http_status_code if response.status_code is non-empty value
+        def set_http_status_code response
+          if response.respond_to? :status_code
+            @http_status_code = response.status_code if response.has_status_code?
+          else
+            NewRelic::Agent.logger.warn "Cannot extract HTTP Status Code from response #{response.class.to_s}"
+            NewRelic::Agent.record_metric "#{name}/#{MISSING_STATUS_CODE}", 1
+          end
+        end
+
         def insert_synthetics_header request, header
           request[NR_SYNTHETICS_HEADER] = header
         end
@@ -197,8 +218,6 @@ module NewRelic
           end
         end
 
-        EXTERNAL_ALL = "External/all".freeze
-
         def add_unscoped_metrics
           @unscoped_metrics = [ EXTERNAL_ALL,
             "External/#{host}/all",
@@ -210,9 +229,6 @@ module NewRelic
           end
         end
 
-        EXTERNAL_ALL_WEB = "External/allWeb".freeze
-        EXTERNAL_ALL_OTHER = "External/allOther".freeze
-
         def suffixed_rollup_metric
           if Transaction.recording_web_transaction?
             EXTERNAL_ALL_WEB

data/lib/new_relic/agent/transaction_error_primitive.rb

@@ -32,16 +32,17 @@ module NewRelic
       SYNTHETICS_JOB_ID_KEY          = "nr.syntheticsJobId".freeze
       SYNTHETICS_MONITOR_ID_KEY      = "nr.syntheticsMonitorId".freeze
       PRIORITY_KEY                   = "priority".freeze
+      SPAN_ID_KEY                    = "spanId".freeze
 
-      def create noticed_error, payload
+      def create noticed_error, payload, span_id
         [
-          intrinsic_attributes_for(noticed_error, payload),
+          intrinsic_attributes_for(noticed_error, payload, span_id),
           noticed_error.custom_attributes,
           noticed_error.agent_attributes
         ]
       end
 
-      def intrinsic_attributes_for noticed_error, payload
+      def intrinsic_attributes_for noticed_error, payload, span_id
         attrs = {
           TYPE_KEY => SAMPLE_TYPE,
           ERROR_CLASS_KEY => noticed_error.exception_class_name,
@@ -50,6 +51,7 @@ module NewRelic
           TIMESTAMP_KEY => noticed_error.timestamp.to_f
         }
 
+        attrs[SPAN_ID_KEY] = span_id if span_id
         attrs[PORT_KEY] = noticed_error.request_port if noticed_error.request_port
 
         if payload

data/lib/new_relic/cli/commands/install.rb

@@ -40,8 +40,8 @@ class NewRelic::Cli::Install < NewRelic::Cli::Command
 
   def run
     dest_file = File.expand_path(@dest_dir + "/newrelic.yml")
-    if File.exist?(dest_file)
-      raise NewRelic::Cli::Command::CommandFailure, "newrelic.yml file already exists.  Move it out of the way."
+    if File.exist?(dest_file) && !@force
+      raise NewRelic::Cli::Command::CommandFailure, "newrelic.yml file already exists.  Use --force flag to overwrite."
     end
     File.open(dest_file, 'w') { | out | out.puts(content) }
 
@@ -73,6 +73,7 @@ Visit support.newrelic.com if you are experiencing installation issues.
 
   def options
     OptionParser.new "Usage: #{$0} #{self.class.command} [ OPTIONS] 'application name'", 40 do |o|
+      o.on("-f", "--force", "Overwrite newrelic.yml if it exists") { | e | @force = true }
       o.on("-l", "--license_key=NAME", String,
              "Use the given license key") { | e | @license_key = e }
       o.on("-d", "--destdir=name", String,

data/lib/new_relic/noticed_error.rb

@@ -1,6 +1,7 @@
 # encoding: utf-8
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+# frozen_string_literal: true
 
 require 'new_relic/helper'
 require 'new_relic/agent/attribute_filter'
@@ -17,9 +18,20 @@ class NewRelic::NoticedError
 
   attr_reader   :exception_id, :is_internal
 
-  STRIPPED_EXCEPTION_REPLACEMENT_MESSAGE = "Message removed by New Relic 'strip_exception_messages' setting".freeze
-  UNKNOWN_ERROR_CLASS_NAME = 'Error'.freeze
-  NIL_ERROR_MESSAGE = '<no message>'.freeze
+  STRIPPED_EXCEPTION_REPLACEMENT_MESSAGE = "Message removed by New Relic 'strip_exception_messages' setting"
+  UNKNOWN_ERROR_CLASS_NAME = 'Error'
+  NIL_ERROR_MESSAGE = '<no message>'
+
+  USER_ATTRIBUTES = "userAttributes"
+  AGENT_ATTRIBUTES = "agentAttributes"
+  INTRINSIC_ATTRIBUTES = "intrinsics"
+
+  DESTINATION = NewRelic::Agent::AttributeFilter::DST_ERROR_COLLECTOR
+
+  ERROR_PREFIX_KEY   = 'error'
+  ERROR_MESSAGE_KEY  = "#{ERROR_PREFIX_KEY}.message"
+  ERROR_CLASS_KEY    = "#{ERROR_PREFIX_KEY}.class"
+  ERROR_EXPECTED_KEY = "#{ERROR_PREFIX_KEY}.expected"
 
   def initialize(path, exception, timestamp = Time.now)
     @exception_id = exception.object_id
@@ -77,12 +89,6 @@ class NewRelic::NoticedError
       processed_attributes ]
   end
 
-  USER_ATTRIBUTES = "userAttributes".freeze
-  AGENT_ATTRIBUTES = "agentAttributes".freeze
-  INTRINSIC_ATTRIBUTES = "intrinsics".freeze
-
-  DESTINATION = NewRelic::Agent::AttributeFilter::DST_ERROR_COLLECTOR
-
   # Note that we process attributes lazily and store the result. This is because
   # there is a possibility that a noticed error will be discarded and not sent back
   # as a traced error or TransactionError.
@@ -131,6 +137,16 @@ class NewRelic::NoticedError
     end
   end
 
+  def build_error_attributes
+    @attributes_from_notice_error ||= {}
+    @attributes_from_notice_error.merge!({
+      ERROR_MESSAGE_KEY => string(message),
+      ERROR_CLASS_KEY => string(exception_class_name)
+    })
+    
+    @attributes_from_notice_error[ERROR_EXPECTED_KEY] = true if expected
+  end
+
   def build_agent_attributes(merged_attributes)
     agent_attributes = if @attributes
       @attributes.agent_attributes_for(DESTINATION)
@@ -177,6 +193,9 @@ class NewRelic::NoticedError
     if exception.nil?
       @exception_class_name = UNKNOWN_ERROR_CLASS_NAME
       @message = NIL_ERROR_MESSAGE
+    elsif exception.is_a? NewRelic::Agent::NoticibleError
+      @exception_class_name = exception.class_name
+      @message = exception.message
     else
       if defined?(Rails::VERSION::MAJOR) && Rails::VERSION::MAJOR < 5 && exception.respond_to?(:original_exception)
         exception = exception.original_exception || exception

data/lib/new_relic/rack/browser_monitoring.rb

@@ -37,7 +37,8 @@ module NewRelic::Rack
       if (js_to_inject != "") && should_instrument?(env, status, headers)
         response_string = autoinstrument_source(response, headers, js_to_inject)
         if headers.key?(CONTENT_LENGTH)
-          headers[CONTENT_LENGTH] = response_string.size.to_s
+          content_length = response_string ? response_string.bytesize : 0
+          headers[CONTENT_LENGTH] = content_length.to_s
         end
 
         env[ALREADY_INSTRUMENTED_KEY] = true

data/lib/new_relic/version.rb

@@ -11,7 +11,7 @@ module NewRelic
     end
 
     MAJOR = 6
-    MINOR = 9
+    MINOR = 10
     TINY  = 0
 
     begin

data/lib/tasks/multiverse.rb

@@ -43,11 +43,36 @@ namespace :test do
 
   namespace :multiverse do
 
+    def remove_local_multiverse_databases
+      list_databases_command = %{echo "show databases" | mysql -u root}
+      databases = `#{list_databases_command}`.chomp!.split("\n").select{|s| s =~ /multiverse/}
+      databases.each do |database|
+        puts "Dropping #{database}"
+        `echo "drop database #{database}" | mysql -u root`
+      end
+    rescue => error
+      puts "ERROR: Cannot get MySQL databases..."
+      puts error.message
+    end
+
+    def remove_generated_gemfiles
+      file_path = File.expand_path "test/multiverse/suites"
+      Dir.glob(File.join file_path, "**", "Gemfile*").each do |fn|
+        puts "Removing #{fn.gsub(file_path,'.../suites')}"
+        FileUtils.rm fn
+      end
+    end
+
     task :env do
       # ENV['SUITES_DIRECTORY'] = File.expand_path('../../test/multiverse/suites', __FILE__)
       require File.expand_path('../../../test/multiverse/lib/multiverse', __FILE__)
     end
 
+    task :clobber do
+      remove_local_multiverse_databases
+      remove_generated_gemfiles
+    end
+
     desc "Clean cached gemfiles from Bundler.bundle_path"
     task :clean_gemfile_cache do
       glob = File.expand_path 'multiverse-cache/Gemfile.*.lock', Bundler.bundle_path

data/lib/tasks/tests.rake

@@ -33,7 +33,7 @@ if defined? Rake::TestTask
 
       t.libs << "#{agent_home}/test"
       t.libs << "#{agent_home}/lib"
-      t.pattern = file_pattern
+      t.pattern = Array(file_pattern).join(",")
       t.verbose = true
     end
 

data/test/agent_helper.rb

@@ -6,25 +6,56 @@
 # itself, and should be usable from within any multiverse suite.
 
 require 'json'
+require 'net/http'
+begin
+  require 'net/http/status' 
+rescue LoadError
+  # NOP -- Net::HTTP::STATUS_CODES was introduced in Ruby 2.5
+end
+
+module MiniTest
+  module Assertions
+    # The failure message is backwards.  This patch reverses the message
+    # Note: passing +msg+ caused two failure messages to be shown on failure
+    # and was more confusing than patching here.
+    def assert_match matcher, obj, msg = nil
+      msg = message(msg) { "Expected #{mu_pp obj} to match #{mu_pp matcher}" }
+      assert_respond_to matcher, :"=~"
+      matcher = Regexp.new Regexp.escape matcher if String === matcher
+      assert matcher =~ obj, msg
+    end
+  end
+end
 
 class ArrayLogDevice
-  def initialize( array=[] )
+  def initialize array=[]
     @array = array
   end
   attr_reader :array
 
-  def write( message )
+  def write message
     @array << message
   end
 
   def close; end
 end
 
-def assert_between(floor, ceiling, value, message="expected #{floor} <= #{value} <= #{ceiling}")
+def fake_guid length=16
+  NewRelic::Agent::GuidGenerator.generate_guid length
+end
+
+def assert_match matcher, obj, msg = nil
+  msg = message(msg) { "Expected #{mu_pp matcher} to match #{mu_pp obj}" }
+  assert_respond_to matcher, :"=~"
+  matcher = Regexp.new Regexp.escape matcher if String === matcher
+  assert matcher =~ obj, msg
+end
+
+def assert_between floor, ceiling, value, message="expected #{floor} <= #{value} <= #{ceiling}"
   assert((floor <= value && value <= ceiling), message)
 end
 
-def assert_in_delta(expected, actual, delta)
+def assert_in_delta expected, actual, delta
   assert_between((expected - delta), (expected + delta), actual)
 end
 
@@ -36,7 +67,7 @@ def reset_error_traces!
   NewRelic::Agent.instance.error_collector.error_trace_aggregator.reset!
 end
 
-def assert_has_traced_error(error_class)
+def assert_has_traced_error error_class
   errors = harvest_error_traces!
   assert \
     errors.find {|e| e.exception_class_name == error_class.name} != nil, \
@@ -63,38 +94,38 @@ def last_error_event
   harvest_error_events!.last.last
 end
 
-unless defined?( assert_block )
-  def assert_block(*msgs)
+unless defined? assert_block
+  def assert_block *msgs
     assert yield, *msgs
   end
 end
 
-unless defined?( assert_includes )
-  def assert_includes( collection, member, msg=nil )
+unless defined? assert_includes
+  def assert_includes collection, member, msg=nil
     msg = "Expected #{collection.inspect} to include #{member.inspect}"
     assert_block( msg ) { collection.include?(member) }
   end
 end
 
-unless defined?( assert_not_includes )
-  def assert_not_includes( collection, member, msg=nil )
+unless defined? assert_not_includes
+  def assert_not_includes collection, member, msg=nil
     msg = "Expected #{collection.inspect} not to include #{member.inspect}"
     assert !collection.include?(member), msg
   end
 end
 
-unless defined?( assert_empty )
-  def assert_empty(collection, msg=nil)
+unless defined? assert_empty
+  def assert_empty collection, msg=nil
     assert collection.empty?, msg
   end
 end
 
-def assert_equal_unordered(left, right)
+def assert_equal_unordered left, right
   assert_equal(left.length, right.length, "Lengths don't match. #{left.length} != #{right.length}")
   left.each { |element| assert_includes(right, element) }
 end
 
-def assert_audit_log_contains(audit_log_contents, needle)
+def assert_audit_log_contains audit_log_contents, needle
   # Original request bodies dumped to the log have symbol keys, but once
   # they go through a dump/load, they're strings again, so we strip
   # double-quotes and colons from the log, and the strings we searching for.
@@ -112,7 +143,7 @@ end
 # orderings of the key/value pairs in Hashes that were embedded in the request
 # body). So, this method traverses an object graph and only makes assertions
 # about the terminal (non-Array-or-Hash) nodes therein.
-def assert_audit_log_contains_object(audit_log_contents, o, format = :json)
+def assert_audit_log_contains_object audit_log_contents, o, format = :json
   case o
   when Hash
     o.each do |k,v|
@@ -130,12 +161,12 @@ def assert_audit_log_contains_object(audit_log_contents, o, format = :json)
   end
 end
 
-def compare_metrics(expected, actual)
+def compare_metrics expected, actual
   actual.delete_if {|a| a.include?('GC/Transaction/') }
   assert_equal(expected.to_a.sort, actual.to_a.sort, "extra: #{(actual - expected).to_a.inspect}; missing: #{(expected - actual).to_a.inspect}")
 end
 
-def metric_spec_from_specish(specish)
+def metric_spec_from_specish specish
   spec = case specish
   when String then NewRelic::MetricSpec.new(specish)
   when Array  then NewRelic::MetricSpec.new(*specish)
@@ -143,7 +174,7 @@ def metric_spec_from_specish(specish)
   spec
 end
 
-def _normalize_metric_expectations(expectations)
+def _normalize_metric_expectations expectations
   case expectations
   when Array
     hash = {}
@@ -157,7 +188,7 @@ def _normalize_metric_expectations(expectations)
   end
 end
 
-def dump_stats(stats)
+def dump_stats stats
   str =  "  Call count:           #{stats.call_count}\n"
   str << "  Total call time:      #{stats.total_call_time}\n"
   str << "  Total exclusive time: #{stats.total_exclusive_time}\n"
@@ -170,7 +201,7 @@ def dump_stats(stats)
   str
 end
 
-def assert_stats_has_values(stats, expected_spec, expected_attrs)
+def assert_stats_has_values stats, expected_spec, expected_attrs
   expected_attrs.each do |attr, expected_value|
     actual_value = stats.send(attr)
     if attr == :call_count
@@ -183,7 +214,7 @@ def assert_stats_has_values(stats, expected_spec, expected_attrs)
   end
 end
 
-def assert_metrics_recorded(expected)
+def assert_metrics_recorded expected
   expected = _normalize_metric_expectations(expected)
   expected.each do |specish, expected_attrs|
     expected_spec = metric_spec_from_specish(specish)
@@ -214,7 +245,7 @@ end
 # the :ignore_filter option. This will allow you to specify a Regex that
 # allowlists broad swathes of metric territory (e.g. 'Supportability/').
 #
-def assert_metrics_recorded_exclusive(expected, options={})
+def assert_metrics_recorded_exclusive expected, options={}
   expected = _normalize_metric_expectations(expected)
   assert_metrics_recorded(expected)
 
@@ -252,7 +283,7 @@ def clear_metrics!
   NewRelic::Agent.instance.stats_engine.reset_for_test!
 end
 
-def assert_metrics_not_recorded(not_expected)
+def assert_metrics_not_recorded not_expected
   not_expected = _normalize_metric_expectations(not_expected)
   found_but_not_expected = []
   not_expected.each do |specish, _|
@@ -266,7 +297,7 @@ end
 
 alias :refute_metrics_recorded :assert_metrics_not_recorded
 
-def assert_no_metrics_match(regex)
+def assert_no_metrics_match regex
   matching_metrics = []
   NewRelic::Agent.instance.stats_engine.to_h.keys.map(&:to_s).each do |metric|
     matching_metrics << metric if metric.match regex
@@ -281,30 +312,30 @@ end
 
 alias :refute_metrics_match :assert_no_metrics_match
 
-def format_metric_spec_list(specs)
+def format_metric_spec_list specs
   spec_strings = specs.map do |spec|
     "#{spec.name} (#{spec.scope.empty? ? '<unscoped>' : spec.scope})"
   end
   "[\n  #{spec_strings.join(",\n  ")}\n]"
 end
 
-def assert_truthy(expected, msg = nil)
+def assert_truthy expected, msg=nil
   msg ||= "Expected #{expected.inspect} to be truthy"
   assert !!expected, msg
 end
 
-def assert_falsy(expected, msg = nil)
+def assert_falsy expected, msg=nil
   msg ||= "Expected #{expected.inspect} to be falsy"
   assert !expected, msg
 end
 
-unless defined?( assert_false )
-  def assert_false(expected)
+unless defined? assert_false
+  def assert_false expected
     assert_equal false, expected
   end
 end
 
-unless defined?(refute)
+unless defined? refute
   alias refute assert_false
 end
 
@@ -326,7 +357,7 @@ end
 # With a transaction name plus category:
 #   in_transaction('foobar', :category => :controller) { ... }
 #
-def in_transaction(*args, &blk)
+def in_transaction *args, &blk
   opts     = (args.last && args.last.is_a?(Hash)) ? args.pop : {}
   category = (opts && opts.delete(:category)) || :other
 
@@ -360,30 +391,55 @@ end
 # that transaction to work with.  The same arguements as provided to in_transaction
 # may be supplied.
 def with_segment *args, &blk
-  in_transaction(*args) do |txn|
-    yield txn.current_segment, txn
+  segment = nil
+  txn = in_transaction(*args) do |txn|
+    segment = txn.current_segment
+    yield segment, txn
+  end
+  [segment, txn]
+end
+
+# building error attributes on segments are deferred until it's time
+# to publish/harvest them as spans, so for testing, we'll explicitly
+# build 'em as appropriate so we can test 'em
+def build_deferred_error_attributes segment
+  return unless segment.noticed_error
+  segment.noticed_error.build_error_attributes
+end
+
+def capture_segment_with_error
+  begin
+    segment_with_error = nil
+    with_segment do |segment|
+      segment_with_error = segment
+      raise "oops!"
+    end            
+  rescue Exception => exception
+    assert segment_with_error, "expected to have a segment_with_error"
+    build_deferred_error_attributes segment_with_error
+    return segment_with_error, exception
   end
 end
 
-def stub_transaction_guid(guid)
+def stub_transaction_guid guid
   NewRelic::Agent::Transaction.tl_current.instance_variable_set(:@guid, guid)
 end
 
 # Convenience wrapper around in_transaction that sets the category so that it
 # looks like we are in a web transaction
-def in_web_transaction(name='dummy')
+def in_web_transaction name='dummy'
   in_transaction(name, :category => :controller, :request => stub(:path => '/')) do |txn|
     yield txn
   end
 end
 
-def in_background_transaction(name='silly')
+def in_background_transaction name='silly'
   in_transaction(name, :category => :task) do |txn|
     yield txn
   end
 end
 
-def refute_contains_request_params(attributes)
+def refute_contains_request_params attributes
   attributes.keys.each do |key|
     refute_match(/^request\.parameters\./, key.to_s)
   end
@@ -402,7 +458,7 @@ def last_transaction_trace_request_params
   end
 end
 
-def find_sql_trace(metric_name)
+def find_sql_trace metric_name
   NewRelic::Agent.agent.sql_sampler.sql_traces.values.detect do |trace|
     trace.database_metric_name == metric_name
   end
@@ -412,7 +468,7 @@ def last_sql_trace
   NewRelic::Agent.agent.sql_sampler.sql_traces.values.last
 end
 
-def find_last_transaction_node(transaction_sample=nil)
+def find_last_transaction_node transaction_sample=nil
   if transaction_sample
     root_node = transaction_sample.root_node
   else
@@ -425,7 +481,7 @@ def find_last_transaction_node(transaction_sample=nil)
   return last_node
 end
 
-def find_node_with_name(transaction_sample, name)
+def find_node_with_name transaction_sample, name
   transaction_sample.root_node.each_node do |node|
     if node.metric_name == name
       return node
@@ -435,7 +491,7 @@ def find_node_with_name(transaction_sample, name)
   nil
 end
 
-def find_node_with_name_matching(transaction_sample, regex)
+def find_node_with_name_matching transaction_sample, regex
   transaction_sample.root_node.each_node do |node|
     if node.metric_name.match regex
       return node
@@ -445,7 +501,7 @@ def find_node_with_name_matching(transaction_sample, regex)
   nil
 end
 
-def find_all_nodes_with_name_matching(transaction_sample, regexes)
+def find_all_nodes_with_name_matching transaction_sample, regexes
   regexes = [regexes].flatten
   matching_nodes = []
 
@@ -460,7 +516,7 @@ def find_all_nodes_with_name_matching(transaction_sample, regexes)
   matching_nodes
 end
 
-def with_config(config_hash, at_start=true)
+def with_config config_hash, at_start=true
   config = NewRelic::Agent::Configuration::DottedHash.new(config_hash, true)
   NewRelic::Agent.config.add_config_for_testing(config, at_start)
   NewRelic::Agent.instance.refresh_attribute_filter
@@ -479,13 +535,13 @@ def with_server_source config_hash, at_start=true
   end
 end
 
-def with_config_low_priority(config_hash)
+def with_config_low_priority config_hash
   with_config(config_hash, false) do
     yield
   end
 end
 
-def with_transaction_renaming_rules(rule_specs)
+def with_transaction_renaming_rules rule_specs
   original_engine = NewRelic::Agent.agent.instance_variable_get(:@transaction_rules)
   begin
     new_engine = NewRelic::Agent::RulesEngine.create_transaction_rules('transaction_name_rules' => rule_specs)
@@ -511,7 +567,7 @@ unless Time.respond_to?(:__original_now)
   end
 end
 
-def nr_freeze_time(now=Time.now)
+def nr_freeze_time now=Time.now
   Time.__frozen_now = now
 end
 
@@ -519,11 +575,11 @@ def nr_unfreeze_time
   Time.__frozen_now = nil
 end
 
-def advance_time(seconds)
+def advance_time seconds
   Time.__frozen_now = Time.now + seconds
 end
 
-def with_constant_defined(constant_symbol, implementation=Module.new)
+def with_constant_defined constant_symbol, implementation=Module.new
   const_path = constant_path(constant_symbol.to_s)
 
   if const_path
@@ -543,7 +599,7 @@ def with_constant_defined(constant_symbol, implementation=Module.new)
   end
 end
 
-def constant_path(name, opts={})
+def constant_path name, opts={}
   allow_partial = opts[:allow_partial]
   path = [Object]
   parts = name.gsub(/^::/, '').split('::')
@@ -556,13 +612,13 @@ def constant_path(name, opts={})
   path
 end
 
-def get_parent(constant_name)
+def get_parent constant_name
   parent_name = constant_name.gsub(/::[^:]*$/, '')
   const_path = constant_path(parent_name)
   const_path ? const_path[-1] : nil
 end
 
-def undefine_constant(constant_symbol)
+def undefine_constant constant_symbol
   const_str = constant_symbol.to_s
   parent = get_parent(const_str)
   const_name = const_str.gsub(/.*::/, '')
@@ -586,11 +642,11 @@ ensure
   NewRelic::Agent.logger = orig_logger
 end
 
-def create_agent_command(args = {})
+def create_agent_command args={}
   NewRelic::Agent::Commands::AgentCommand.new([-1, { "name" => "command_name", "arguments" => args}])
 end
 
-def wait_for_backtrace_service_poll(opts={})
+def wait_for_backtrace_service_poll opts={}
   defaults = {
     :timeout => 10.0,
     :service => NewRelic::Agent.agent.agent_command_router.backtrace_service,
@@ -616,7 +672,7 @@ def wait_for_backtrace_service_poll(opts={})
   end
 end
 
-def with_array_logger(level=:info)
+def with_array_logger level=:info
   orig_logger = NewRelic::Agent.logger
   config = { :log_level => level }
   logdev = ArrayLogDevice.new
@@ -711,11 +767,11 @@ end
 
 # Changes ENV settings to given and runs given block and restores ENV 
 # to original values before returning.
-def with_environment(env, &block)
+def with_environment env, &block
   EnvUpdater.inject(env) { yield }
 end
 
-def with_argv(argv)
+def with_argv argv
   old_argv = ARGV.dup
   ARGV.clear
   ARGV.concat(argv)
@@ -728,7 +784,7 @@ def with_argv(argv)
   end
 end
 
-def with_ignore_error_filter(filter, &blk)
+def with_ignore_error_filter filter, &blk
   original_filter = NewRelic::Agent.ignore_error_filter
   NewRelic::Agent.ignore_error_filter(&filter)
 
@@ -737,7 +793,7 @@ ensure
   NewRelic::Agent::ErrorCollector.ignore_error_filter = original_filter
 end
 
-def json_dump_and_encode(object)
+def json_dump_and_encode object
   Base64.encode64(::JSON.dump(object))
 end
 
@@ -745,7 +801,7 @@ def get_last_analytics_event
   NewRelic::Agent.agent.transaction_event_aggregator.harvest![1].last
 end
 
-def swap_instance_method(target, method_name, new_method_implementation, &blk)
+def swap_instance_method target, method_name, new_method_implementation, &blk
   old_method_implementation = target.instance_method(method_name)
   target.send(:define_method, method_name, new_method_implementation)
   yield
@@ -760,7 +816,7 @@ def cross_agent_tests_dir
   File.expand_path(File.join(File.dirname(__FILE__), 'fixtures', 'cross_agent_tests'))
 end
 
-def load_cross_agent_test(name)
+def load_cross_agent_test name
   test_file_path = File.join(cross_agent_tests_dir, "#{name}.json")
   data = File.read(test_file_path)
   data.gsub!('callCount', 'call_count')
@@ -769,13 +825,13 @@ def load_cross_agent_test(name)
   data
 end
 
-def each_cross_agent_test(options)
+def each_cross_agent_test options
   options = {:dir => nil, :pattern => "*"}.update(options)
   path = File.join [cross_agent_tests_dir, options[:dir], options[:pattern]].compact
   Dir.glob(path).each { |file| yield file}
 end
 
-def assert_event_attributes(event, test_name, expected_attributes, non_expected_attributes)
+def assert_event_attributes event, test_name, expected_attributes, non_expected_attributes
   incorrect_attributes = []
 
   event_attrs = event[0]
@@ -803,7 +859,7 @@ def assert_event_attributes(event, test_name, expected_attributes, non_expected_
   end
 end
 
-def attributes_for(sample, type)
+def attributes_for sample, type
   sample.attributes.instance_variable_get("@#{type}_attributes")
 end
 
@@ -815,3 +871,100 @@ def reset_buffers_and_caches
   NewRelic::Agent.drop_buffered_data
   uncache_trusted_account_key
 end
+
+def message_for_status_code code
+  # Net::HTTP::STATUS_CODES was introduced in Ruby 2.5 
+  if defined?(Net::HTTP::STATUS_CODES)
+    return Net::HTTP::STATUS_CODES[code]
+  end
+
+  case code
+  when 200 then "OK"
+  when 404 then "Not Found"
+  when 403 then "Forbidden"
+  else "Unknown"  
+  end
+end
+
+# wraps the given headers in a Net::HTTPResponse which has accompanying 
+# http status code associated with it.
+# a "status_code" may be passed in the headers to alter the HTTP Status Code
+# that is wrapped in the response.
+def mock_http_response headers, wrap_it=true
+  status_code = (headers.delete("status_code") || 200).to_i
+  net_http_resp = Net::HTTPResponse.new(1.0, status_code, message_for_status_code(status_code))
+  headers.each do |key, value|
+    net_http_resp.add_field key.to_s, value
+  end
+  return net_http_resp unless wrap_it
+  NewRelic::Agent::HTTPClients::NetHTTPResponse.new(net_http_resp)
+end
+
+# +expected+ can be a string or regular expression
+def assert_match_or_equal expected, value
+  if expected.is_a?(Regexp)
+    assert_match expected, value
+  else
+    assert_equal expected, value
+  end
+end
+
+# selects the last segment with a noticed_error and checks 
+# the expectations against it.
+def assert_segment_noticed_error txn, segment_name, error_classes, error_message
+  error_segment = txn.segments.reverse.detect{|s| s.noticed_error}
+  assert error_segment, "Expected at least one segment with a noticed_error"
+
+  assert_match_or_equal segment_name, error_segment.name
+
+  noticed_error = error_segment.noticed_error
+
+  assert_match_or_equal error_classes, noticed_error.exception_class_name
+  assert_match_or_equal error_message, noticed_error.message
+end
+
+def assert_transaction_noticed_error txn, error_classes
+  refute_empty txn.exceptions, "Expected transaction to notice the error"
+  assert_match_or_equal error_classes, txn.exceptions.keys.first.class.name
+end
+
+def refute_transaction_noticed_error txn, error_class
+  error_segment = txn.segments.reverse.detect{|s| s.noticed_error}
+  assert error_segment, "Expected at least one segment with a noticed_error"
+  assert_empty txn.exceptions, "Expected transaction to NOT notice any segment errors"
+end
+
+def refute_raises *exp
+  msg = "#{exp.pop}.\n" if String === exp.last
+
+  begin
+    yield
+  rescue MiniTest::Skip => e
+    puts "SKIP REPORTS: #{e.inspect}"
+    return e if exp.include? MiniTest::Skip
+    raise e
+  rescue Exception => e
+    puts "EXCEPTION RAISED: #{e.inspect}\n#{e.backtrace}"
+    exp = exp.first if exp.size == 1
+    flunk msg || "unexpected exception raised: #{e}"
+  end
+end
+
+def assert_implements instance, method, *args
+  fail_message = "expected #{instance.class}##{method} method to be implemented"
+  refute_raises NotImplementedError, fail_message do
+    instance.send(method, *args)
+  end
+end
+
+def defer_testing_to_min_supported_rails test_file, min_rails_version, supports_jruby=true
+  if defined?(::Rails) &&
+    defined?(::Rails::VERSION::STRING) &&
+    (::Rails::VERSION::STRING.to_f >= min_rails_version) &&
+    (supports_jruby || !NewRelic::LanguageSupport.jruby?)
+
+    yield
+  else
+    puts "Skipping tests in #{test_file} because Rails >= #{min_rails_version} is unavailable"
+  end
+end