newrelic_rpm 6.15.0 → 8.0.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (156) hide show
  1. checksums.yaml +4 -4
  2. data/.gitignore +2 -0
  3. data/CHANGELOG.md +260 -22
  4. data/CONTRIBUTING.md +13 -2
  5. data/README.md +4 -2
  6. data/lib/new_relic/agent/adaptive_sampler.rb +2 -2
  7. data/lib/new_relic/agent/agent.rb +8 -7
  8. data/lib/new_relic/agent/autostart.rb +1 -2
  9. data/lib/new_relic/agent/commands/thread_profiler_session.rb +7 -3
  10. data/lib/new_relic/agent/configuration/default_source.rb +456 -233
  11. data/lib/new_relic/agent/configuration/event_harvest_config.rb +28 -12
  12. data/lib/new_relic/agent/configuration/manager.rb +3 -4
  13. data/lib/new_relic/agent/configuration/server_source.rb +3 -2
  14. data/lib/new_relic/agent/configuration/yaml_source.rb +22 -1
  15. data/lib/new_relic/agent/connect/request_builder.rb +4 -2
  16. data/lib/new_relic/agent/custom_event_aggregator.rb +2 -1
  17. data/lib/new_relic/agent/database.rb +5 -2
  18. data/lib/new_relic/agent/datastores/mongo.rb +5 -10
  19. data/lib/new_relic/agent/datastores/redis.rb +0 -4
  20. data/lib/new_relic/agent/datastores.rb +7 -7
  21. data/lib/new_relic/agent/distributed_tracing/cross_app_payload.rb +5 -5
  22. data/lib/new_relic/agent/distributed_tracing/cross_app_tracing.rb +10 -6
  23. data/lib/new_relic/agent/distributed_tracing/distributed_trace_attributes.rb +0 -1
  24. data/lib/new_relic/agent/distributed_tracing/distributed_trace_payload.rb +1 -1
  25. data/lib/new_relic/agent/distributed_tracing/trace_context_payload.rb +1 -1
  26. data/lib/new_relic/agent/distributed_tracing.rb +0 -66
  27. data/lib/new_relic/agent/error_collector.rb +52 -37
  28. data/lib/new_relic/agent/error_filter.rb +167 -0
  29. data/lib/new_relic/agent/event_loop.rb +6 -6
  30. data/lib/new_relic/agent/external.rb +0 -32
  31. data/lib/new_relic/agent/http_clients/abstract.rb +2 -2
  32. data/lib/new_relic/agent/instrumentation/action_controller_subscriber.rb +1 -1
  33. data/lib/new_relic/agent/instrumentation/active_merchant.rb +3 -3
  34. data/lib/new_relic/agent/instrumentation/active_record_notifications.rb +0 -16
  35. data/lib/new_relic/agent/instrumentation/active_record_subscriber.rb +1 -3
  36. data/lib/new_relic/agent/instrumentation/bunny/chain.rb +45 -0
  37. data/lib/new_relic/agent/instrumentation/bunny/instrumentation.rb +152 -0
  38. data/lib/new_relic/agent/instrumentation/bunny/prepend.rb +35 -0
  39. data/lib/new_relic/agent/instrumentation/bunny.rb +10 -152
  40. data/lib/new_relic/agent/instrumentation/controller_instrumentation.rb +2 -1
  41. data/lib/new_relic/agent/instrumentation/curb/chain.rb +93 -0
  42. data/lib/new_relic/agent/instrumentation/curb/instrumentation.rb +222 -0
  43. data/lib/new_relic/agent/instrumentation/curb/prepend.rb +63 -0
  44. data/lib/new_relic/agent/instrumentation/curb.rb +9 -241
  45. data/lib/new_relic/agent/instrumentation/delayed_job/chain.rb +38 -0
  46. data/lib/new_relic/agent/instrumentation/delayed_job/instrumentation.rb +53 -0
  47. data/lib/new_relic/agent/instrumentation/delayed_job/prepend.rb +34 -0
  48. data/lib/new_relic/agent/instrumentation/delayed_job_instrumentation.rb +8 -50
  49. data/lib/new_relic/agent/instrumentation/excon.rb +4 -22
  50. data/lib/new_relic/agent/instrumentation/grape/chain.rb +25 -0
  51. data/lib/new_relic/agent/instrumentation/grape/instrumentation.rb +100 -0
  52. data/lib/new_relic/agent/instrumentation/grape/prepend.rb +17 -0
  53. data/lib/new_relic/agent/instrumentation/grape.rb +13 -113
  54. data/lib/new_relic/agent/instrumentation/httpclient/chain.rb +25 -0
  55. data/lib/new_relic/agent/instrumentation/httpclient/instrumentation.rb +38 -0
  56. data/lib/new_relic/agent/instrumentation/httpclient/prepend.rb +17 -0
  57. data/lib/new_relic/agent/instrumentation/httpclient.rb +8 -30
  58. data/lib/new_relic/agent/instrumentation/httprb/chain.rb +22 -0
  59. data/lib/new_relic/agent/instrumentation/httprb/instrumentation.rb +30 -0
  60. data/lib/new_relic/agent/instrumentation/httprb/prepend.rb +15 -0
  61. data/lib/new_relic/agent/instrumentation/httprb.rb +29 -0
  62. data/lib/new_relic/agent/instrumentation/memcache/chain.rb +16 -0
  63. data/lib/new_relic/agent/instrumentation/memcache/dalli.rb +38 -121
  64. data/lib/new_relic/agent/instrumentation/memcache/helper.rb +56 -0
  65. data/lib/new_relic/agent/instrumentation/memcache/instrumentation.rb +88 -0
  66. data/lib/new_relic/agent/instrumentation/memcache/prepend.rb +88 -0
  67. data/lib/new_relic/agent/instrumentation/memcache.rb +54 -69
  68. data/lib/new_relic/agent/instrumentation/middleware_proxy.rb +2 -0
  69. data/lib/new_relic/agent/instrumentation/mongo.rb +3 -134
  70. data/lib/new_relic/agent/instrumentation/net_http/chain.rb +25 -0
  71. data/lib/new_relic/agent/instrumentation/{net_prepend.rb → net_http/instrumentation.rb} +3 -3
  72. data/lib/new_relic/agent/instrumentation/net_http/prepend.rb +21 -0
  73. data/lib/new_relic/agent/instrumentation/net_http.rb +44 -0
  74. data/lib/new_relic/agent/instrumentation/padrino/chain.rb +34 -0
  75. data/lib/new_relic/agent/instrumentation/padrino/instrumentation.rb +27 -0
  76. data/lib/new_relic/agent/instrumentation/padrino/prepend.rb +20 -0
  77. data/lib/new_relic/agent/instrumentation/padrino.rb +18 -53
  78. data/lib/new_relic/agent/instrumentation/queue_time.rb +4 -4
  79. data/lib/new_relic/agent/instrumentation/rack/chain.rb +58 -0
  80. data/lib/new_relic/agent/instrumentation/rack/helpers.rb +32 -0
  81. data/lib/new_relic/agent/instrumentation/rack/instrumentation.rb +73 -0
  82. data/lib/new_relic/agent/instrumentation/rack/prepend.rb +37 -0
  83. data/lib/new_relic/agent/instrumentation/rack.rb +29 -139
  84. data/lib/new_relic/agent/instrumentation/rails/action_controller.rb +5 -5
  85. data/lib/new_relic/agent/instrumentation/rails/action_web_service.rb +1 -1
  86. data/lib/new_relic/agent/instrumentation/rails3/action_controller.rb +5 -41
  87. data/lib/new_relic/agent/instrumentation/rake/chain.rb +25 -0
  88. data/lib/new_relic/agent/instrumentation/rake/instrumentation.rb +144 -0
  89. data/lib/new_relic/agent/instrumentation/rake/prepend.rb +14 -0
  90. data/lib/new_relic/agent/instrumentation/rake.rb +13 -154
  91. data/lib/new_relic/agent/instrumentation/redis/chain.rb +34 -0
  92. data/lib/new_relic/agent/instrumentation/redis/instrumentation.rb +65 -0
  93. data/lib/new_relic/agent/instrumentation/redis/prepend.rb +24 -0
  94. data/lib/new_relic/agent/instrumentation/redis.rb +12 -107
  95. data/lib/new_relic/agent/instrumentation/resque/chain.rb +22 -0
  96. data/lib/new_relic/agent/instrumentation/resque/helper.rb +19 -0
  97. data/lib/new_relic/agent/instrumentation/resque/instrumentation.rb +35 -0
  98. data/lib/new_relic/agent/instrumentation/resque/prepend.rb +16 -0
  99. data/lib/new_relic/agent/instrumentation/resque.rb +21 -32
  100. data/lib/new_relic/agent/instrumentation/sidekiq.rb +6 -1
  101. data/lib/new_relic/agent/instrumentation/sinatra/chain.rb +55 -0
  102. data/lib/new_relic/agent/instrumentation/sinatra/ignorer.rb +29 -34
  103. data/lib/new_relic/agent/instrumentation/sinatra/instrumentation.rb +124 -0
  104. data/lib/new_relic/agent/instrumentation/sinatra/prepend.rb +33 -0
  105. data/lib/new_relic/agent/instrumentation/sinatra.rb +20 -158
  106. data/lib/new_relic/agent/instrumentation/typhoeus/chain.rb +22 -0
  107. data/lib/new_relic/agent/instrumentation/typhoeus/instrumentation.rb +82 -0
  108. data/lib/new_relic/agent/instrumentation/typhoeus/prepend.rb +14 -0
  109. data/lib/new_relic/agent/instrumentation/typhoeus.rb +10 -89
  110. data/lib/new_relic/agent/javascript_instrumentor.rb +15 -10
  111. data/lib/new_relic/agent/messaging.rb +10 -24
  112. data/lib/new_relic/agent/method_tracer.rb +132 -138
  113. data/lib/new_relic/agent/monitors/cross_app_monitor.rb +6 -1
  114. data/lib/new_relic/agent/new_relic_service.rb +24 -22
  115. data/lib/new_relic/agent/pipe_channel_manager.rb +10 -6
  116. data/lib/new_relic/agent/pipe_service.rb +1 -1
  117. data/lib/new_relic/agent/samplers/cpu_sampler.rb +1 -1
  118. data/lib/new_relic/agent/span_event_aggregator.rb +2 -2
  119. data/lib/new_relic/agent/sql_sampler.rb +4 -4
  120. data/lib/new_relic/agent/stats_engine/stats_hash.rb +1 -1
  121. data/lib/new_relic/agent/stats_engine.rb +1 -1
  122. data/lib/new_relic/agent/supported_versions.rb +1 -1
  123. data/lib/new_relic/agent/threading/backtrace_service.rb +4 -5
  124. data/lib/new_relic/agent/threading/thread_profile.rb +1 -1
  125. data/lib/new_relic/agent/tracer.rb +15 -37
  126. data/lib/new_relic/agent/transaction/abstract_segment.rb +3 -3
  127. data/lib/new_relic/agent/transaction/message_broker_segment.rb +5 -11
  128. data/lib/new_relic/agent/transaction.rb +8 -32
  129. data/lib/new_relic/agent/transaction_time_aggregator.rb +5 -5
  130. data/lib/new_relic/agent/vm/snapshot.rb +1 -1
  131. data/lib/new_relic/agent/worker_loop.rb +5 -5
  132. data/lib/new_relic/agent.rb +10 -13
  133. data/lib/new_relic/cli/commands/deployments.rb +2 -2
  134. data/lib/new_relic/constants.rb +0 -4
  135. data/lib/new_relic/control/frameworks/rails.rb +11 -9
  136. data/lib/new_relic/control/instance_methods.rb +1 -0
  137. data/lib/new_relic/dependency_detection.rb +116 -10
  138. data/lib/new_relic/noticed_error.rb +5 -9
  139. data/lib/new_relic/supportability_helper.rb +1 -2
  140. data/lib/new_relic/version.rb +2 -2
  141. data/lib/newrelic_rpm.rb +10 -34
  142. data/lib/tasks/all.rb +1 -1
  143. data/lib/tasks/config.html.erb +14 -25
  144. data/lib/tasks/config.rake +8 -7
  145. data/newrelic.yml +593 -3
  146. data/newrelic_rpm.gemspec +1 -1
  147. data/test/agent_helper.rb +27 -2
  148. metadata +56 -14
  149. data/cert/cacert.pem +0 -1177
  150. data/lib/new_relic/agent/datastores/mongo/statement_formatter.rb +0 -53
  151. data/lib/new_relic/agent/instrumentation/excon/connection.rb +0 -49
  152. data/lib/new_relic/agent/instrumentation/http.rb +0 -49
  153. data/lib/new_relic/agent/instrumentation/merb/controller.rb +0 -44
  154. data/lib/new_relic/agent/instrumentation/merb/errors.rb +0 -33
  155. data/lib/new_relic/agent/instrumentation/net.rb +0 -70
  156. data/lib/new_relic/control/frameworks/merb.rb +0 -29
@@ -0,0 +1,20 @@
1
+ # encoding: utf-8
2
+ # This file is distributed under New Relic's license terms.
3
+ # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
4
+
5
+ module NewRelic::Agent::Instrumentation
6
+ module Padrino
7
+ module Prepend
8
+ include NewRelic::Agent::Instrumentation::Sinatra
9
+ include NewRelic::Agent::Instrumentation::Padrino
10
+
11
+ def dispatch
12
+ dispatch_with_tracing { super }
13
+ end
14
+
15
+ def invoke_route(*args, &block)
16
+ invoke_route_with_tracing(*args) { super }
17
+ end
18
+ end
19
+ end
20
+ end
@@ -2,69 +2,34 @@
2
2
  # This file is distributed under New Relic's license terms.
3
3
  # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
4
4
 
5
- require 'new_relic/agent/instrumentation/sinatra'
5
+ # Our Padrino instrumentation relies heavily on the fact that Padrino is
6
+ # built on Sinatra. Although it wires up a lot of its own routing logic,
7
+ # we only need to patch into Padrino's dispatch to get things started.
8
+ #
9
+ # Parts of the Sinatra instrumentation (such as the TransactionNamer) are
10
+ # aware of Padrino as a potential target in areas where both Sinatra and
11
+ # Padrino run through the same code.
12
+
13
+ require_relative 'sinatra'
14
+ require_relative 'padrino/chain'
15
+ require_relative 'padrino/instrumentation'
16
+ require_relative 'padrino/prepend'
6
17
 
7
18
  DependencyDetection.defer do
8
19
  @name = :padrino
20
+ configure_with :sinatra
9
21
 
10
- depends_on do
11
- !NewRelic::Agent.config[:disable_sinatra] &&
12
- defined?(::Padrino) && defined?(::Padrino::Routing::InstanceMethods)
13
- end
22
+ depends_on { defined?(::Padrino) && defined?(::Padrino::Routing::InstanceMethods) }
14
23
 
15
24
  executes do
16
25
  ::NewRelic::Agent.logger.info 'Installing Padrino instrumentation'
17
-
18
- # Our Padrino instrumentation relies heavily on the fact that Padrino is
19
- # built on Sinatra. Although it wires up a lot of its own routing logic,
20
- # we only need to patch into Padrino's dispatch to get things started.
21
- #
22
- # Parts of the Sinatra instrumentation (such as the TransactionNamer) are
23
- # aware of Padrino as a potential target in areas where both Sinatra and
24
- # Padrino run through the same code.
25
- module ::Padrino::Routing::InstanceMethods
26
- include NewRelic::Agent::Instrumentation::Sinatra
27
-
28
- alias dispatch_without_newrelic dispatch!
29
- alias dispatch! dispatch_with_newrelic
30
-
31
- # Padrino 0.13 mustermann routing
32
- if private_method_defined?(:invoke_route)
33
- include NewRelic::Agent::Instrumentation::Padrino
34
-
35
- alias invoke_route_without_newrelic invoke_route
36
- alias invoke_route invoke_route_with_newrelic
37
- end
26
+ if use_prepend?
27
+ prepend_instrument ::Padrino::Routing::InstanceMethods, NewRelic::Agent::Instrumentation::Padrino::Prepend
28
+ else
29
+ chain_instrument NewRelic::Agent::Instrumentation::Padrino::Chain
38
30
  end
39
31
  end
40
32
  end
41
33
 
42
- module NewRelic
43
- module Agent
44
- module Instrumentation
45
- module Padrino
46
34
 
47
- def invoke_route_with_newrelic(*args, &block)
48
- begin
49
- env["newrelic.last_route"] = args[0].original_path
50
- rescue => e
51
- ::NewRelic::Agent.logger.debug("Failed determining last route in Padrino", e)
52
- end
53
35
 
54
- begin
55
- txn_name = ::NewRelic::Agent::Instrumentation::Sinatra::TransactionNamer.transaction_name_for_route(env, request)
56
- unless txn_name.nil?
57
- ::NewRelic::Agent::Transaction.set_default_transaction_name(
58
- "#{self.class.name}/#{txn_name}", :sinatra)
59
- end
60
- rescue => e
61
- ::NewRelic::Agent.logger.debug("Failed during invoke_route to set transaction name", e)
62
- end
63
-
64
- invoke_route_without_newrelic(*args, &block)
65
- end
66
-
67
- end
68
- end
69
- end
70
- end
@@ -15,7 +15,7 @@ module NewRelic
15
15
  ALL_QUEUE_METRIC = 'WebFrontend/QueueTime'.freeze
16
16
  # any timestamps before this are thrown out and the parser
17
17
  # will try again with a larger unit (2000/1/1 UTC)
18
- EARLIEST_ACCEPTABLE_TIME = Time.at(946684800)
18
+ EARLIEST_ACCEPTABLE_TIME = Time.at(946684800).to_f
19
19
 
20
20
  CANDIDATE_HEADERS = [
21
21
  REQUEST_START_HEADER,
@@ -27,7 +27,7 @@ module NewRelic
27
27
 
28
28
  module_function
29
29
 
30
- def parse_frontend_timestamp(headers, now=Time.now)
30
+ def parse_frontend_timestamp(headers, now=Process.clock_gettime(Process::CLOCK_REALTIME))
31
31
  earliest = nil
32
32
 
33
33
  CANDIDATE_HEADERS.each do |header|
@@ -40,7 +40,7 @@ module NewRelic
40
40
  end
41
41
 
42
42
  if earliest && earliest > now
43
- NewRelic::Agent.logger.debug("Negative queue time detected, treating as zero: start=#{earliest.to_f} > now=#{now.to_f}")
43
+ NewRelic::Agent.logger.debug("Negative queue time detected, treating as zero: start=#{earliest.to_f} > now=#{now}")
44
44
  earliest = now
45
45
  end
46
46
 
@@ -59,7 +59,7 @@ module NewRelic
59
59
  def parse_timestamp(string)
60
60
  DIVISORS.each do |divisor|
61
61
  begin
62
- t = Time.at(string.to_f / divisor)
62
+ t = (string.to_f / divisor)
63
63
  return t if t > EARLIEST_ACCEPTABLE_TIME
64
64
  rescue RangeError
65
65
  # On Ruby versions built with a 32-bit time_t, attempting to
@@ -0,0 +1,58 @@
1
+ # encoding: utf-8
2
+ # This file is distributed under New Relic's license terms.
3
+ # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
4
+
5
+ module NewRelic::Agent::Instrumentation
6
+ module Rack
7
+ module Chain
8
+ def self.instrument! builder_class
9
+ NewRelic::Agent::Instrumentation::RackBuilder.track_deferred_detection builder_class
10
+
11
+ builder_class.class_eval do
12
+ include ::NewRelic::Agent::Instrumentation::RackBuilder
13
+
14
+ def to_app_with_newrelic_deferred_dependency_detection
15
+ with_deferred_dependency_detection { to_app_without_newrelic }
16
+ end
17
+
18
+ alias_method :to_app_without_newrelic, :to_app
19
+ alias_method :to_app, :to_app_with_newrelic_deferred_dependency_detection
20
+
21
+ if ::NewRelic::Agent::Instrumentation::RackHelpers.middleware_instrumentation_enabled?
22
+ ::NewRelic::Agent.logger.info "Installing #{builder_class} middleware instrumentation"
23
+
24
+ def run_with_newrelic(app, *args)
25
+ run_with_tracing(app) { |wrapped_app| run_without_newrelic(wrapped_app, *args) }
26
+ end
27
+
28
+ alias_method :run_without_newrelic, :run
29
+ alias_method :run, :run_with_newrelic
30
+
31
+ def use_with_newrelic(middleware_class, *args, &block)
32
+ use_with_tracing(middleware_class) { |wrapped_class| use_without_newrelic(wrapped_class, *args, &block) }
33
+ end
34
+ ruby2_keywords(:use_with_newrelic) if respond_to?(:ruby2_keywords, true)
35
+
36
+ alias_method :use_without_newrelic, :use
37
+ alias_method :use, :use_with_newrelic
38
+ end
39
+ end
40
+ end
41
+ end
42
+
43
+ module URLMap
44
+ module Chain
45
+ def self.instrument! url_map_class
46
+ url_map_class.class_eval do
47
+ alias_method :initialize_without_newrelic, :initialize
48
+
49
+ def initialize(map = {})
50
+ traced_map = ::NewRelic::Agent::Instrumentation::RackURLMap.generate_traced_map(map)
51
+ initialize_without_newrelic(traced_map)
52
+ end
53
+ end
54
+ end
55
+ end
56
+ end
57
+ end
58
+ end
@@ -0,0 +1,32 @@
1
+ # encoding: utf-8
2
+ # This file is distributed under New Relic's license terms.
3
+ # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
4
+
5
+ module NewRelic::Agent::Instrumentation
6
+ module RackHelpers
7
+ def self.version_supported?
8
+ rack_version_supported? || puma_rack_version_supported?
9
+ end
10
+
11
+ def self.rack_version_supported?
12
+ return false unless defined? ::Rack
13
+
14
+ version = Gem::Version.new(::Rack.release)
15
+ min_version = Gem::Version.new('1.1.0')
16
+ version >= min_version
17
+ end
18
+
19
+ def self.puma_rack_version_supported?
20
+ return false unless defined? ::Puma::Const::PUMA_VERSION
21
+
22
+ version = Gem::Version.new(::Puma::Const::PUMA_VERSION)
23
+ min_version = Gem::Version.new('2.12.0')
24
+ version >= min_version
25
+ end
26
+
27
+ def self.middleware_instrumentation_enabled?
28
+ version_supported? && !::NewRelic::Agent.config[:disable_middleware_instrumentation]
29
+ end
30
+ end
31
+ end
32
+
@@ -0,0 +1,73 @@
1
+ # encoding: utf-8
2
+ # This file is distributed under New Relic's license terms.
3
+ # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
4
+
5
+ module NewRelic
6
+ module Agent
7
+ module Instrumentation
8
+ module RackBuilder
9
+
10
+ def self.track_deferred_detection builder_class
11
+ class << builder_class
12
+ attr_accessor :_nr_deferred_detection_ran
13
+ end
14
+ builder_class._nr_deferred_detection_ran = false
15
+ end
16
+
17
+ def deferred_dependency_check
18
+ return if self.class._nr_deferred_detection_ran
19
+
20
+ NewRelic::Agent.logger.info "Doing deferred dependency-detection before Rack startup"
21
+ DependencyDetection.detect!
22
+ self.class._nr_deferred_detection_ran = true
23
+ end
24
+
25
+ def check_for_late_instrumentation(app)
26
+ return if defined?(@checked_for_late_instrumentation) && @checked_for_late_instrumentation
27
+ @checked_for_late_instrumentation = true
28
+ if middleware_instrumentation_enabled?
29
+ if ::NewRelic::Agent::Instrumentation::MiddlewareProxy.needs_wrapping?(app)
30
+ ::NewRelic::Agent.logger.info("We weren't able to instrument all of your Rack middlewares.",
31
+ "To correct this, ensure you 'require \"newrelic_rpm\"' before setting up your middleware stack.")
32
+ end
33
+ end
34
+ end
35
+
36
+ # We patch the #to_app method for a reason that actually has nothing to do with
37
+ # instrumenting rack itself. It happens to be a convenient and
38
+ # easy-to-hook point that happens late in the startup sequence of almost
39
+ # every application, making it a good place to do a final call to
40
+ # DependencyDetection.detect!, since all libraries are likely loaded at
41
+ # this point.
42
+ def with_deferred_dependency_detection
43
+ deferred_dependency_check
44
+ yield.tap{ |result| check_for_late_instrumentation(result) }
45
+ end
46
+
47
+ def middleware_instrumentation_enabled?
48
+ ::NewRelic::Agent::Instrumentation::RackHelpers.middleware_instrumentation_enabled?
49
+ end
50
+
51
+ def run_with_tracing app
52
+ return yield(app) unless middleware_instrumentation_enabled?
53
+ yield ::NewRelic::Agent::Instrumentation::MiddlewareProxy.wrap(app, true)
54
+ end
55
+
56
+ def use_with_tracing middleware_class
57
+ return if middleware_class.nil?
58
+ return yield(middleware_class) unless middleware_instrumentation_enabled?
59
+ yield ::NewRelic::Agent::Instrumentation::MiddlewareProxy.for_class(middleware_class)
60
+ end
61
+ end
62
+
63
+ module RackURLMap
64
+ def self.generate_traced_map(map)
65
+ map.inject({}) do |traced_map, (url, handler)|
66
+ traced_map[url] = NewRelic::Agent::Instrumentation::MiddlewareProxy.wrap(handler, true)
67
+ traced_map
68
+ end
69
+ end
70
+ end
71
+ end
72
+ end
73
+ end
@@ -0,0 +1,37 @@
1
+ # encoding: utf-8
2
+ # This file is distributed under New Relic's license terms.
3
+ # See https://github.com/newrelic/newrelic-ruby-agent/blob/main/LICENSE for complete details.
4
+
5
+ module NewRelic::Agent::Instrumentation
6
+ module Rack
7
+
8
+ module URLMap
9
+ module Prepend
10
+ def initialize(map = {})
11
+ super ::NewRelic::Agent::Instrumentation::RackURLMap.generate_traced_map(map)
12
+ end
13
+ end
14
+ end
15
+
16
+ module Prepend
17
+ include ::NewRelic::Agent::Instrumentation::RackBuilder
18
+
19
+ def self.prepended builder_class
20
+ NewRelic::Agent::Instrumentation::RackBuilder.track_deferred_detection builder_class
21
+ end
22
+
23
+ def to_app
24
+ with_deferred_dependency_detection { super }
25
+ end
26
+
27
+ def run(app, *args)
28
+ run_with_tracing(app) { |wrapped_app| super(wrapped_app, *args) }
29
+ end
30
+
31
+ def use(middleware_class, *args, &blk)
32
+ use_with_tracing(middleware_class) { |wrapped_class| super(wrapped_class, *args, &blk) }
33
+ end
34
+ ruby2_keywords(:use) if respond_to?(:ruby2_keywords, true)
35
+ end
36
+ end
37
+ end
@@ -4,134 +4,10 @@
4
4
 
5
5
  require 'new_relic/agent/instrumentation/controller_instrumentation'
6
6
 
7
- module NewRelic
8
- module Agent
9
- module Instrumentation
10
- module RackHelpers
11
- def self.version_supported?
12
- rack_version_supported? || puma_rack_version_supported?
13
- end
14
-
15
- def self.rack_version_supported?
16
- return false unless defined? ::Rack
17
-
18
- version = Gem::Version.new(::Rack.release)
19
- min_version = Gem::Version.new('1.1.0')
20
- version >= min_version
21
- end
22
-
23
- def self.puma_rack_version_supported?
24
- return false unless defined? ::Puma::Const::PUMA_VERSION
25
-
26
- version = Gem::Version.new(::Puma::Const::PUMA_VERSION)
27
- min_version = Gem::Version.new('2.12.0')
28
- version >= min_version
29
- end
30
-
31
- def self.middleware_instrumentation_enabled?
32
- version_supported? && !::NewRelic::Agent.config[:disable_middleware_instrumentation]
33
- end
34
-
35
- def self.check_for_late_instrumentation(app)
36
- return if defined?(@checked_for_late_instrumentation) && @checked_for_late_instrumentation
37
- @checked_for_late_instrumentation = true
38
- if middleware_instrumentation_enabled?
39
- if ::NewRelic::Agent::Instrumentation::MiddlewareProxy.needs_wrapping?(app)
40
- ::NewRelic::Agent.logger.info("We weren't able to instrument all of your Rack middlewares.",
41
- "To correct this, ensure you 'require \"newrelic_rpm\"' before setting up your middleware stack.")
42
- end
43
- end
44
- end
45
-
46
- def self.instrument_builder builder_class
47
- ::NewRelic::Agent.logger.info "Installing deferred #{builder_class} instrumentation"
48
-
49
- builder_class.class_eval do
50
- class << self
51
- attr_accessor :_nr_deferred_detection_ran
52
- end
53
- self._nr_deferred_detection_ran = false
54
-
55
- include ::NewRelic::Agent::Instrumentation::RackBuilder
56
-
57
- alias_method :to_app_without_newrelic, :to_app
58
- alias_method :to_app, :to_app_with_newrelic_deferred_dependency_detection
59
-
60
- if ::NewRelic::Agent::Instrumentation::RackHelpers.middleware_instrumentation_enabled?
61
- ::NewRelic::Agent.logger.info "Installing #{builder_class} middleware instrumentation"
62
- alias_method :run_without_newrelic, :run
63
- alias_method :run, :run_with_newrelic
64
-
65
- alias_method :use_without_newrelic, :use
66
- alias_method :use, :use_with_newrelic
67
- end
68
- end
69
-
70
- def self.instrument_url_map url_map_class
71
- url_map_class.class_eval do
72
- alias_method :initialize_without_newrelic, :initialize
73
-
74
- def initialize(map = {})
75
- traced_map = ::NewRelic::Agent::Instrumentation::RackURLMap.generate_traced_map(map)
76
- initialize_without_newrelic(traced_map)
77
- end
78
- end
79
- end
80
- end
81
- end
82
-
83
- module RackBuilder
84
-
85
- def run_with_newrelic(app, *args)
86
- if ::NewRelic::Agent::Instrumentation::RackHelpers.middleware_instrumentation_enabled?
87
- wrapped_app = ::NewRelic::Agent::Instrumentation::MiddlewareProxy.wrap(app, true)
88
- run_without_newrelic(wrapped_app, *args)
89
- else
90
- run_without_newrelic(app, *args)
91
- end
92
- end
93
-
94
- def use_with_newrelic(middleware_class, *args, &blk)
95
- return if middleware_class.nil?
96
- if ::NewRelic::Agent::Instrumentation::RackHelpers.middleware_instrumentation_enabled?
97
- wrapped_middleware_class = ::NewRelic::Agent::Instrumentation::MiddlewareProxy.for_class(middleware_class)
98
- use_without_newrelic(wrapped_middleware_class, *args, &blk)
99
- else
100
- use_without_newrelic(middleware_class, *args, &blk)
101
- end
102
- end
103
-
104
- # We patch this method for a reason that actually has nothing to do with
105
- # instrumenting rack itself. It happens to be a convenient and
106
- # easy-to-hook point that happens late in the startup sequence of almost
107
- # every application, making it a good place to do a final call to
108
- # DependencyDetection.detect!, since all libraries are likely loaded at
109
- # this point.
110
- def to_app_with_newrelic_deferred_dependency_detection
111
- unless self.class._nr_deferred_detection_ran
112
- NewRelic::Agent.logger.info "Doing deferred dependency-detection before Rack startup"
113
- DependencyDetection.detect!
114
- self.class._nr_deferred_detection_ran = true
115
- end
116
-
117
- result = to_app_without_newrelic
118
- ::NewRelic::Agent::Instrumentation::RackHelpers.check_for_late_instrumentation(result)
119
-
120
- result
121
- end
122
- end
123
-
124
- module RackURLMap
125
- def self.generate_traced_map(map)
126
- map.inject({}) do |traced_map, (url, handler)|
127
- traced_map[url] = NewRelic::Agent::Instrumentation::MiddlewareProxy.wrap(handler, true)
128
- traced_map
129
- end
130
- end
131
- end
132
- end
133
- end
134
- end
7
+ require_relative 'rack/helpers'
8
+ require_relative 'rack/instrumentation'
9
+ require_relative 'rack/chain'
10
+ require_relative 'rack/prepend'
135
11
 
136
12
  DependencyDetection.defer do
137
13
  named :rack
@@ -141,20 +17,27 @@ DependencyDetection.defer do
141
17
  end
142
18
 
143
19
  executes do
144
- ::NewRelic::Agent::Instrumentation::RackHelpers.instrument_builder ::Rack::Builder
20
+ if use_prepend?
21
+ prepend_instrument ::Rack::Builder, NewRelic::Agent::Instrumentation::Rack::Prepend
22
+ else
23
+ chain_instrument_target ::Rack::Builder, NewRelic::Agent::Instrumentation::Rack::Chain
24
+ end
145
25
  end
146
26
  end
147
27
 
148
-
149
28
  DependencyDetection.defer do
150
29
  named :puma_rack
151
30
 
152
31
  depends_on do
153
- defined?(::Puma::Rack::Builder) && !NewRelic::Agent.config[:disable_puma_rack]
32
+ defined?(::Puma::Rack::Builder)
154
33
  end
155
34
 
156
35
  executes do
157
- ::NewRelic::Agent::Instrumentation::RackHelpers.instrument_builder ::Puma::Rack::Builder
36
+ if use_prepend?
37
+ prepend_instrument ::Puma::Rack::Builder, NewRelic::Agent::Instrumentation::Rack::Prepend
38
+ else
39
+ chain_instrument_target ::Puma::Rack::Builder, NewRelic::Agent::Instrumentation::Rack::Chain
40
+ end
158
41
  end
159
42
  end
160
43
 
@@ -166,12 +49,16 @@ DependencyDetection.defer do
166
49
  end
167
50
 
168
51
  depends_on do
169
- ::NewRelic::Agent::Instrumentation::RackHelpers.middleware_instrumentation_enabled? &&
170
- !::NewRelic::Agent.config[:disable_rack]
52
+ ::NewRelic::Agent::Instrumentation::RackHelpers.middleware_instrumentation_enabled?
171
53
  end
172
54
 
173
55
  executes do
174
- ::NewRelic::Agent::Instrumentation::RackHelpers.instrument_url_map ::Rack::URLMap
56
+ if use_prepend?
57
+ prepend_instrument ::Rack::URLMap, NewRelic::Agent::Instrumentation::Rack::URLMap::Prepend
58
+ else
59
+ chain_instrument_target ::Rack::URLMap, NewRelic::Agent::Instrumentation::Rack::URLMap::Chain
60
+ ::NewRelic::Agent::Instrumentation::RackHelpers.instrument_url_map
61
+ end
175
62
  end
176
63
  end
177
64
 
@@ -179,15 +66,18 @@ DependencyDetection.defer do
179
66
  named :puma_rack_urlmap
180
67
 
181
68
  depends_on do
182
- defined? Puma::Rack::URLMap
69
+ defined?(Puma::Rack::URLMap)
183
70
  end
184
71
 
185
72
  depends_on do
186
- ::NewRelic::Agent::Instrumentation::RackHelpers.middleware_instrumentation_enabled? &&
187
- !::NewRelic::Agent.config[:disable_puma_rack]
73
+ ::NewRelic::Agent::Instrumentation::RackHelpers.middleware_instrumentation_enabled?
188
74
  end
189
75
 
190
76
  executes do
191
- ::NewRelic::Agent::Instrumentation::RackHelpers.instrument_url_map ::Puma::Rack::URLMap
77
+ if use_prepend?
78
+ prepend_instrument ::Puma::Rack::URLMap, NewRelic::Agent::Instrumentation::Rack::URLMap::Prepend
79
+ else
80
+ chain_instrument_target ::Puma::Rack::URLMap, NewRelic::Agent::Instrumentation::Rack::URLMap::Chain
81
+ end
192
82
  end
193
83
  end
@@ -20,13 +20,13 @@ DependencyDetection.defer do
20
20
  executes do
21
21
  ActionView::PartialTemplate.class_eval do
22
22
  include NewRelic::Agent::MethodTracer
23
- add_method_tracer :render, 'View/#{path_without_extension[%r{^(/.*/)?(.*)$},2]}.#{@view.template_format}.#{extension}/Partial'
23
+ add_method_tracer :render, -> (*) { "View/#{path_without_extension[%r{^(/.*/)?(.*)$},2]}.#{@view.template_format}.#{extension}/Partial" }
24
24
  end
25
25
 
26
26
  # this is for template rendering, as opposed to partial rendering.
27
27
  ActionView::Template.class_eval do
28
28
  include NewRelic::Agent::MethodTracer
29
- add_method_tracer :render, 'View/#{(path_without_extension || @view.controller.newrelic_metric_path)[%r{^(/.*/)?(.*)$},2]}.#{@view.template_format}.#{extension}/Rendering'
29
+ add_method_tracer :render, -> (*) { "View/#{(path_without_extension || @view.controller.newrelic_metric_path)[%r{^(/.*/)?(.*)$},2]}.#{@view.template_format}.#{extension}/Rendering" }
30
30
  end
31
31
  end
32
32
  end
@@ -47,7 +47,7 @@ DependencyDetection.defer do
47
47
  executes do
48
48
  ActionController::Base.class_eval do
49
49
  include NewRelic::Agent::MethodTracer
50
- add_method_tracer :render, 'View/#{newrelic_metric_path}/Rendering'
50
+ add_method_tracer :render, -> (*) { "View/#{newrelic_metric_path}/Rendering" }
51
51
  end
52
52
  end
53
53
  end
@@ -68,12 +68,12 @@ DependencyDetection.defer do
68
68
  executes do
69
69
  ActionView::RenderablePartial.module_eval do
70
70
  include NewRelic::Agent::MethodTracer
71
- add_method_tracer :render_partial, 'View/#{path[%r{^(/.*/)?(.*)$},2]}/Partial'
71
+ add_method_tracer :render_partial, -> (*) { "View/#{path[%r{^(/.*/)?(.*)$},2]}/Partial" }
72
72
  end
73
73
 
74
74
  ActionView::Template.class_eval do
75
75
  include NewRelic::Agent::MethodTracer
76
- add_method_tracer :render, 'View/#{path[%r{^(/.*/)?(.*)$},2]}/Rendering'
76
+ add_method_tracer :render, -> (*) { "View/#{path[%r{^(/.*/)?(.*)$},2]}/Rendering" }
77
77
  end
78
78
  end
79
79
  end
@@ -38,7 +38,7 @@ DependencyDetection.defer do
38
38
  if defined?(ActionController) && defined?(ActionController::Base)
39
39
  ActionController::Base.class_eval do
40
40
  if method_defined? :perform_invocation
41
- add_method_tracer :perform_invocation, 'WebService/#{controller_name}/#{args.first}'
41
+ add_method_tracer :perform_invocation, -> (*args) { "WebService/#{controller_name}/#{args.first}" }
42
42
  end
43
43
  end
44
44
  end
@@ -84,52 +84,16 @@ DependencyDetection.defer do
84
84
  end
85
85
  end
86
86
  end
87
- DependencyDetection.defer do
88
- @name = :rails30_view
89
-
90
- depends_on do
91
- defined?(::Rails::VERSION::MAJOR) && defined?(::Rails::VERSION::MINOR) &&
92
- ::Rails::VERSION::MAJOR.to_i == 3 && ::Rails::VERSION::MINOR.to_i == 0
93
- end
94
-
95
- depends_on do
96
- !NewRelic::Agent.config[:disable_view_instrumentation]
97
- end
98
-
99
- executes do
100
- ::NewRelic::Agent.logger.info 'Installing Rails 3.0 view instrumentation'
101
- end
102
-
103
- executes do
104
- ActionView::Template.class_eval do
105
- include NewRelic::Agent::MethodTracer
106
- def render_with_newrelic(*args, &block)
107
- options = if @virtual_path && @virtual_path.starts_with?('/') # file render
108
- {:file => true }
109
- else
110
- {}
111
- end
112
- str = "View/#{NewRelic::Agent::Instrumentation::Rails3::ActionView::NewRelic.template_metric(@identifier, options)}/#{NewRelic::Agent::Instrumentation::Rails3::ActionView::NewRelic.render_type(@identifier)}"
113
- trace_execution_scoped str do
114
- render_without_newrelic(*args, &block)
115
- end
116
- end
117
-
118
- alias_method :render_without_newrelic, :render
119
- alias_method :render, :render_with_newrelic
120
-
121
- end
122
- end
123
- end
124
87
 
88
+ # Though this uses the name :rails31_view, it is used only for rails 3.2 now
89
+ # Rails 3.1 is no longer supported by the agent.
125
90
  DependencyDetection.defer do
126
91
  @name = :rails31_view
127
92
 
128
- # We can't be sure that this will work with future versions of Rails 3.
129
- # Currently enabled for Rails 3.1 and 3.2
93
+ # Enabled for Rails 3.2
130
94
  depends_on do
131
95
  defined?(::Rails::VERSION::MAJOR) && defined?(::Rails::VERSION::MINOR) &&
132
- ::Rails::VERSION::MAJOR.to_i == 3 && ([1,2].member?(::Rails::VERSION::MINOR.to_i))
96
+ ::Rails::VERSION::MAJOR.to_i == 3 && ::Rails::VERSION::MINOR.to_i == 2
133
97
  end
134
98
 
135
99
  depends_on do
@@ -137,7 +101,7 @@ DependencyDetection.defer do
137
101
  end
138
102
 
139
103
  executes do
140
- ::NewRelic::Agent.logger.info 'Installing Rails 3.1/3.2 view instrumentation'
104
+ ::NewRelic::Agent.logger.info 'Installing Rails 3.2 view instrumentation'
141
105
  end
142
106
 
143
107
  executes do