newrelic_rpm 5.5.0.348 → 6.2.0.354

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b17c73d708623383395fecf3a60a063566a12b59a10d2b18d686deef72f31773
-  data.tar.gz: f9b9275cf1f9f980175454d8ed5f06a4fa2d173c4edf52e136580c96b2e05eda
+  metadata.gz: 61ee707dd3738565b01b05857ed9ae7de00a6ab3e9cc0522ba5d651819c24634
+  data.tar.gz: e8b630ad8f1c69a51dae797a046f90bd8d87683dcc4a2fb97f2960dcf6f90b4b
 SHA512:
-  metadata.gz: 8cc16f8281e2e00829add33da0ba8053afbfe29e56b9e901c40d40cd44be982df5859492a26041aed7593b687316848113dcc02b646816e2812132bda4a86db5
-  data.tar.gz: 7eecd067c7606152a08e6485c6f0a642f5e73081812b011f89ba8d2b3fdd74df66ee0686e385d078ec4a4286e396a1ee9206bbc9c2585925596b9b7e90101015
+  metadata.gz: 9ee286b42523ceca71287a9463a6e6a66e825f27956fd460c72aacb640780a20db0e5c688951f2d0a4bb648a4d8bd5dad98220d1f5a98e9abcc51843bd71aa1e
+  data.tar.gz: 1a5070f668fd0b4f802ee71fe3909c123d0b38a53a1491ec07a496177cf9f392015c95ae62284b086a4fd27952fa0e62a7d720813de09449f5b4b8b8c4331a5e

data/.gitignore

@@ -25,4 +25,5 @@ lib/new_relic/build.rb
 .bundle
 .yardoc
 artifacts/
+test/performance/log/
 test/performance/script/log/

data/.travis.yml

@@ -9,9 +9,13 @@ language: ruby
 sudo: required
 
 before_install:
-  - sudo apt-get update && sudo apt-get install --only-upgrade openssl && sudo apt-get install --only-upgrade libssl-dev
+  # RUBY-2072 Prevent Travis setup failure before our test even starts
+  - jdk_switcher use oraclejdk8
+  - sudo rm -f /etc/apt/sources.list.d/travis_ci_zeromq3.list
   - gem --version
-  - gem update --system
+  - ./test/script/before_install/update_rubygems.sh
+  - rvm @global do gem uninstall bundler --all --executables || true
+  - gem install bundler -v=1.17.3
   - ./test/script/before_install/gemstash_mirror.sh
   - bundle --version
 
@@ -19,7 +23,11 @@ install: bundle install
 
 addons:
   apt:
+    update: true
     packages:
+      - openssl
+      - libssl-dev
+      - build-essential
       - haveged
 
 before_script: ./test/script/before_script/install_mongodb.sh
@@ -39,8 +47,9 @@ notifications:
 
 rvm:
   # Run slowest builds first to try and optimize overall cycle time.
-  - jruby-9.1.13.0
-  - 2.5.0
+  - jruby-9.2.6.0
+  - 2.6.1
+  - 2.5.3
   - 2.4.2
   - 2.3.5
   - 2.2.8
@@ -58,11 +67,6 @@ env:
     - TESTOPTS="-v"
     - VERBOSE = 1
   matrix:
-    # RUBY-1668 rails21, rails22, and rails23 are all excluded below
-    - TYPE=UNIT ENVIRONMENT=rails21
-    - TYPE=UNIT ENVIRONMENT=rails22
-    - TYPE=UNIT ENVIRONMENT=rails23
-
     - TYPE=UNIT ENVIRONMENT=rails30
     - TYPE=UNIT ENVIRONMENT=rails31
     - TYPE=UNIT ENVIRONMENT=rails32
@@ -88,31 +92,31 @@ matrix:
   fast_finish: true
   exclude:
     # Unsupported Rails/Ruby combinations
+    # 2.6
+    - rvm: 2.6.1
+      env: TYPE=UNIT ENVIRONMENT=rails30
+    - rvm: 2.6.1
+      env: TYPE=UNIT ENVIRONMENT=rails31
+    - rvm: 2.6.1
+      env: TYPE=UNIT ENVIRONMENT=rails32
+    - rvm: 2.6.1
+      env: TYPE=UNIT ENVIRONMENT=rails40
+    - rvm: 2.6.1
+      env: TYPE=UNIT ENVIRONMENT=rails41
+
     # 2.5
-    - rvm: 2.5.0
-      env: TYPE=UNIT ENVIRONMENT=rails21
-    - rvm: 2.5.0
-      env: TYPE=UNIT ENVIRONMENT=rails22
-    - rvm: 2.5.0
-      env: TYPE=UNIT ENVIRONMENT=rails23
-    - rvm: 2.5.0
+    - rvm: 2.5.3
       env: TYPE=UNIT ENVIRONMENT=rails30
-    - rvm: 2.5.0
+    - rvm: 2.5.3
       env: TYPE=UNIT ENVIRONMENT=rails31
-    - rvm: 2.5.0
+    - rvm: 2.5.3
       env: TYPE=UNIT ENVIRONMENT=rails32
-    - rvm: 2.5.0
+    - rvm: 2.5.3
       env: TYPE=UNIT ENVIRONMENT=rails40
-    - rvm: 2.5.0
+    - rvm: 2.5.3
       env: TYPE=UNIT ENVIRONMENT=rails41
 
     # 2.4
-    - rvm: 2.4.2
-      env: TYPE=UNIT ENVIRONMENT=rails21
-    - rvm: 2.4.2
-      env: TYPE=UNIT ENVIRONMENT=rails22
-    - rvm: 2.4.2
-      env: TYPE=UNIT ENVIRONMENT=rails23
     - rvm: 2.4.2
       env: TYPE=UNIT ENVIRONMENT=rails30
     - rvm: 2.4.2
@@ -124,78 +128,26 @@ matrix:
     - rvm: 2.4.2
       env: TYPE=UNIT ENVIRONMENT=rails41
 
-    # 2.3
-    - rvm: 2.3.5
-      env: TYPE=UNIT ENVIRONMENT=rails21
-    - rvm: 2.3.5
-      env: TYPE=UNIT ENVIRONMENT=rails22
-    - rvm: 2.3.5
-      env: TYPE=UNIT ENVIRONMENT=rails23
-
-    # 2.2
-    - rvm: 2.2.8
-      env: TYPE=UNIT ENVIRONMENT=rails21
-    - rvm: 2.2.8
-      env: TYPE=UNIT ENVIRONMENT=rails22
-    - rvm: 2.2.8
-      env: TYPE=UNIT ENVIRONMENT=rails23
-
     # 2.1
-    - rvm: 2.1.10
-      env: TYPE=UNIT ENVIRONMENT=rails21
-    - rvm: 2.1.10
-      env: TYPE=UNIT ENVIRONMENT=rails22
-    - rvm: 2.1.10
-      env: TYPE=UNIT ENVIRONMENT=rails23
     - rvm: 2.1.10
       env: TYPE=UNIT ENVIRONMENT=rails50
     - rvm: 2.1.10
       env: TYPE=UNIT ENVIRONMENT=rails51
 
     # 2.0
-    - rvm: 2.0.0-p648
-      env: TYPE=UNIT ENVIRONMENT=rails21
-    - rvm: 2.0.0-p648
-      env: TYPE=UNIT ENVIRONMENT=rails22
-    - rvm: 2.0.0-p648
-      env: TYPE=UNIT ENVIRONMENT=rails23
     - rvm: 2.0.0-p648
       env: TYPE=UNIT ENVIRONMENT=rails50
     - rvm: 2.0.0-p648
       env: TYPE=UNIT ENVIRONMENT=rails51
 
-    # jruby 9.0
-    - rvm: jruby-9.1.13.0
-      env: TYPE=UNIT ENVIRONMENT=rails21
-    - rvm: jruby-9.1.13.0
-      env: TYPE=UNIT ENVIRONMENT=rails22
-    - rvm: jruby-9.1.13.0
-      env: TYPE=UNIT ENVIRONMENT=rails23
-    - rvm: jruby-9.1.13.0
+    # jruby 9.2.6.0 (Compatible with MRI 2.5)
+    - rvm: jruby-9.2.6.0
       env: TYPE=UNIT ENVIRONMENT=rails30
-    - rvm: jruby-9.1.13.0
+    - rvm: jruby-9.2.6.0
       env: TYPE=UNIT ENVIRONMENT=rails31
-    - rvm: jruby-9.1.13.0
+    - rvm: jruby-9.2.6.0
       env: TYPE=UNIT ENVIRONMENT=rails32
-
-  # Travis (and only Travis) has been throwing difficult-to-reproduce
-  # errors in various JRuby tests.  These appeared after a build image
-  # update, and they seem to be unrelated to any agent code changes.
-  # So, we'll allow these specific test runs to fail while we track
-  # the issue (RUBY-1869).
-  #
-  allow_failures:
-    - rvm: jruby-9.1.13.0
+    - rvm: jruby-9.2.6.0
       env: TYPE=UNIT ENVIRONMENT=rails40
-    - rvm: jruby-9.1.13.0
+    - rvm: jruby-9.2.6.0
       env: TYPE=UNIT ENVIRONMENT=rails41
-    - rvm: jruby-9.1.13.0
-      env: TYPE=UNIT ENVIRONMENT=rails42
-    - rvm: jruby-9.1.13.0
-      env: TYPE=UNIT ENVIRONMENT=rails50
-    - rvm: jruby-9.1.13.0
-      env: TYPE=UNIT ENVIRONMENT=rails51
-    - rvm: jruby-9.1.13.0
-      env: TYPE=UNIT ENVIRONMENT=norails
-    - rvm: jruby-9.1.13.0
-      env: TYPE=FUNCTIONAL GROUP=background_2

data/.yardopts

@@ -12,6 +12,7 @@ lib/new_relic/agent/stats_engine/metric_stats.rb
 lib/new_relic/agent/datastores.rb
 lib/new_relic/agent/messaging.rb
 lib/new_relic/agent/sql_sampler.rb
+lib/new_relic/agent/tracer.rb
 lib/new_relic/agent/transaction.rb
 lib/new_relic/agent/transaction_sampler.rb
 lib/new_relic/rack/agent_hooks.rb

data/CHANGELOG.md

@@ -1,5 +1,154 @@
 # New Relic Ruby Agent Release Notes #
 
+## v6.2.0
+
+  * Bugfix for superfluous `Empty JSON response` error messages
+
+    Version 6.1.0 of the agent frequently logged error messages about an empty 
+    JSON response, when no error had occurred.  These logs no longer appear. 
+
+  * Bugfix for `Unable to calculate elapsed transaction time` warning messages
+
+    Ruby Agent versions 5.4 through 6.1, when running in jruby without 
+    ObjectSpace enabled, would occasionally log a warning indicating that the 
+    agent was unable to calculate the elapsed transaction time.  When this log
+    statement appeared, the affected transactions would not be included in the 
+    data displayed on the capacity analysis page.  These transactions are now 
+    correctly recorded.
+
+## v6.1.0
+
+   * Performance monitoring on Kubernetes
+
+     This release adds Transaction event attributes that provide
+     context between your Kubernetes cluster and services. For details
+     on the benefits, see this [blog
+     post](https://blog.newrelic.com/engineering/monitoring-application-performance-in-kubernetes/).
+
+   * Bugfix for Bunny instrumentation when popping empty queues
+
+     When a customer calls `Bunny::Queue#pop` on an empty queue, Bunny
+     returns a `nil` value.  Previous Ruby Agent versions raised a
+     `NoMethodError` when trying to process this result.  Now, the
+     agent correctly skips processing for `nil` values.  Thanks to
+     Matt Campbell for the contribution.
+
+## v6.0.0
+
+   * Tracer API for flexible custom instrumentation
+
+     With agent version 6.0, we are introducing the `Tracer` class, an
+     officially supported public API for more flexible custom
+     instrumentation.  By calling its `in_transaction` method, you can
+     instrument an arbitrary section of Ruby code without needing to
+     juggle any explicit state.  Behind the scenes, the agent will
+     make sure that the measured code results in an APM segment inside
+     a transaction.
+
+     The same API contains additional methods for creating
+     transactions and segments, and for interacting with the current
+     transaction.  For more details, see the [custom instrumentation
+     documentation](https://docs.newrelic.com/docs/agents/ruby-agent/api-guides/ruby-custom-instrumentation).
+
+     If you were previously using any of the agent's private,
+     undocumented APIs, such as `Transaction.wrap` or
+     `Transaction.start/stop`, you will need to update your code to
+     use the Tracer API.
+
+     The full list of APIs that were removed or deprecated are:
+       * `External.start_segment`
+       * `Transaction.create_segment`
+       * `Transaction.start`
+       * `Transaction.stop`
+       * `Transaction.start_datastore_segment`
+       * `Transaction.start_segment`
+       * `Transaction.wrap`
+       * `TransactionState.current_transaction`
+
+     If are you using any of these APIs, please see the [upgrade guide](https://docs.newrelic.com/docs/agents/ruby-agent/troubleshooting/update-private-api-calls-public-tracer-api) for a list of replacements.
+
+   * Agent detects Rails 6.0
+
+     The agent properly detects Rails 6.0 and no longer logs an error when
+     started in a Rails 6.0 environment. This does not include full Rails 6.0
+     support, which will be coming in a future release. Thanks to Jacob Bednarz
+     for the contribution.
+
+## v5.7.0
+
+   * Ruby 2.6 support
+
+     We have tested the agent with the official release of Ruby 2.6.0
+     made on December 25, 2018, and it looks great! Feel free to use
+     agent v5.7 to measure the performance of your Ruby 2.6
+     applications.
+
+   * Support for loading Sequel core standalone
+
+     Earlier versions of the agent required users of the Sequel data
+     mapping library to load the _entire_ library.  The agent will now
+     enable Sequel instrumentation when an application loads Sequel's
+     core standalone; i.e., without the `Sequel::Model` class.  Thanks
+     to Vasily Kolesnikov for the contribution!
+
+   * Grape 1.2 support
+
+     With agent versions 5.6 and earlier, Grape 1.2 apps reported
+     their transactions under the name `Proc#call` instead of the name
+     of the API endpoint.  Starting with agent version 5.7, all
+     existing versions of Grape will report the correct transaction
+     name.  Thanks to Masato Ohba for the contribution!
+
+## v5.6.0
+
+  * Bugfix for transactions with `ActionController::Live`
+
+    Previously, transactions containing `ActionController::Live` resulted in
+    incorrect calculations of capacity analysis as well as error backtraces
+    appearing in agent logs in agent versions 5.4 and later. The agent now
+    correctly calculates capacity for transactions with `ActionController::Live`.
+
+  * Add ability to exclude attributes from span events and transaction
+    segments
+
+    Agent versions 5.5 and lower could selectively exclude attributes
+    from page views, error traces, transaction traces, and
+    transaction events.  With agent version 5.6 and higher, you can
+    also exclude attributes from span events (via the
+    `span_events.include/exclude` options) and from transaction
+    segments (via the `transaction_segments.include/exclude` options).
+
+    As with other attribute destinations, these new options will
+    inherit values from the top-level `attributes.include/exclude`
+    settings. See the
+    [documentation](https://docs.newrelic.com/docs/agents/ruby-agent/attributes/enabling-disabling-attributes-ruby)
+    for more information.
+
+  * Increasing backoff sequence on failing to connect to New Relic
+
+    If the agent cannot reach New Relic, it will now wait for an
+    increasing amount of time after each failed attempt.  We are also
+    starting with a shorter delay initially, which will help customer
+    apps bounce back more quickly from transient network errors.
+
+  * Truncation of long stack traces
+
+    Previous versions of the agent would truncate long stack traces to
+    50 frames.  To give customers more flexibility, we have added the
+    `error_collector.max_backtrace_frames` configuration option.
+    Thanks to Patrick Tulskie for the contribution!
+
+  * Update link in documentation
+
+    The community forum link in `README.md` now goes to the updated
+    location.  Thanks to Sam Killgallon for the contribution!
+
+  * Active Storage instrumentation
+
+    The agent now provides instrumentation for Active Storage, introduced in
+    Rails 5.2. Customers will see Active Storage operations represented as
+    segments within transaction traces.
+
 ## v5.5.0
 
   * Bugfix for `perform` instrumentation with curb gem

data/README.md

@@ -127,7 +127,7 @@ You can find more detailed documentation [on our website](http://newrelic.com/do
 and specifically in the [Ruby category](http://newrelic.com/docs/ruby).
 
 If you can't find what you're looking for there, reach out to us on our [support
-site](http://support.newrelic.com/) or our [community forum](http://forum.newrelic.com)
+site](http://support.newrelic.com/) or our [community forum](https://discuss.newrelic.com/)
 and we'll be happy to help you.
 
 Find a bug? Contact us via [support.newrelic.com](http://support.newrelic.com/),

data/config.dot

@@ -18,6 +18,7 @@ digraph AgentEnabled {
   "[error_collector.capture_source]"
   "[error_collector.enabled]"
   "[error_collector.ignore_errors]"
+  "[error_collector.max_backtrace_frames]"
   "[browser_monitoring.auto_instrument]"
   "[license_key]"
   "[verify_certificate]"

data/lib/new_relic/agent/agent.rb

@@ -262,7 +262,7 @@ module NewRelic
         # should not record sql in the current thread. Returns the
         # previous value, if there is one
         def set_record_sql(should_record) #THREAD_LOCAL_ACCESS
-          state = TransactionState.tl_get
+          state = Tracer.state
           prev = state.record_sql
           state.record_sql = should_record
           prev.nil? || prev
@@ -273,13 +273,13 @@ module NewRelic
         # children of a transaction without affecting the tracing of
         # the whole transaction
         def push_trace_execution_flag(should_trace=false) #THREAD_LOCAL_ACCESS
-          TransactionState.tl_get.push_traced(should_trace)
+          Tracer.state.push_traced(should_trace)
         end
 
         # Pop the current trace execution status.  Restore trace execution status
         # to what it was before we pushed the current flag.
         def pop_trace_execution_flag #THREAD_LOCAL_ACCESS
-          TransactionState.tl_get.pop_traced
+          Tracer.state.pop_traced
         end
 
         # Herein lies the corpse of the former 'start' method. May
@@ -543,7 +543,7 @@ module NewRelic
           @sql_sampler.reset!
 
           if Agent.config[:clear_transaction_state_after_fork]
-            TransactionState.tl_clear
+            Tracer.clear_state
           end
         end
 
@@ -624,7 +624,7 @@ module NewRelic
           # is the worker thread that gathers data and talks to the
           # server.
           def handle_force_disconnect(error)
-            ::NewRelic::Agent.logger.warn "New Relic forced this agent to disconnect (#{error.message})"
+            ::NewRelic::Agent.logger.warn "Agent received a ForceDisconnectException from the server, disconnecting. (#{error.message})"
             disconnect
           end
 
@@ -632,7 +632,7 @@ module NewRelic
           # it and disconnecting the agent, since we are now in an
           # unknown state.
           def handle_other_error(error)
-            ::NewRelic::Agent.logger.error "Unhandled error in worker thread, disconnecting this agent process:"
+            ::NewRelic::Agent.logger.error "Unhandled error in worker thread, disconnecting."
             # These errors are fatal (that is, they will prevent the agent from
             # reporting entirely), so we really want backtraces when they happen
             ::NewRelic::Agent.logger.log_exception(:error, error)
@@ -727,12 +727,14 @@ module NewRelic
             force || (!connected? && !disconnected?)
           end
 
-          # Retry period is a minute for each failed attempt that
-          # we've made. This should probably do some sort of sane TCP
-          # backoff to prevent hammering the server, but a minute for
-          # each attempt seems to work reasonably well.
+          # Per the spec at
+          # /agents/agent-specs/Collector-Response-Handling.md, retry
+          # connections after a specific backoff sequence to prevent
+          # hammering the server.
+          CONNECT_RETRY_PERIODS = [15, 15, 30, 60, 120, 300]
+
           def connect_retry_period
-            [600, connect_attempts * 60].min
+            CONNECT_RETRY_PERIODS[connect_attempts] || 300
           end
 
           def note_connect_failure
@@ -1117,6 +1119,8 @@ module NewRelic
             @agent_command_router.check_for_and_handle_agent_commands
           rescue ForceRestartException, ForceDisconnectException
             raise
+          rescue UnrecoverableServerException => e
+            NewRelic::Agent.logger.warn("get_agent_commands message was rejected by remote service, discarding. Error: ", e)
           rescue ServerConnectionException => e
             log_remote_unavailable(:get_agent_commands, e)
           rescue => e