newrelic_rpm 3.7.2.190.beta → 3.7.2.192

data/test/new_relic/agent/method_tracer_test.rb

@@ -110,6 +110,29 @@ class NewRelic::Agent::MethodTracerTest < MiniTest::Unit::TestCase
     assert_equal 1, stats.call_count
   end
 
+  def test_trace_execution_scoped_with_no_metrics_skips_out
+    self.class.trace_execution_scoped([]) do
+      advance_time 0.05
+    end
+
+    assert_empty @stats_engine.metrics
+  end
+
+  def test_trace_execution_scoped_records_metric_data_from_callback
+    metric = "hello"
+    callback_metric = "goodbye"
+    callback = Proc.new { callback_metric }
+    options = { :additional_metrics_callback => callback }
+
+    self.class.trace_execution_scoped(metric, options) do
+      advance_time 0.05
+    end
+
+    stats = @stats_engine.get_stats(callback_metric)
+    check_time 0.05, stats.total_call_time
+    assert_equal 1, stats.call_count
+  end
+
   def test_trace_execution_scoped_pushes_transaction_scope
     self.class.trace_execution_scoped('yeap') do
       'ptoo'

data/test/new_relic/agent/transaction_sampler_test.rb

@@ -788,22 +788,11 @@ class NewRelic::Agent::TransactionSamplerTest < MiniTest::Unit::TestCase
     end
   end
 
-  def test_build_database_statement_uses_override_obfuscation_adapter_if_connection_config_is_nil
-    with_config(:override_sql_obfuscation_adapter => 'GumbyDB') do
-      config = nil
-      sql = "SELECT * FROM \"horses\" WHERE \"name\" = 'pokey'"
-      statement = @sampler.build_database_statement(sql, config, Proc.new {})
-      assert_equal 'GumbyDB', statement.adapter
-    end
-  end
-
-  def test_build_database_statement_uses_override_obfuscation_adapter_if_connection_config_adapter_is_mysql
-    with_config(:override_sql_obfuscation_adapter => 'GumbyDB') do
-      config = {:adapter => 'mysql'}
-      sql = "SELECT * FROM \"horses\" WHERE \"name\" = 'pokey'"
-      statement = @sampler.build_database_statement(sql, config, nil)
-      assert_equal 'GumbyDB', statement.adapter
-    end
+  def test_build_database_statement_uses_adapter_from_connection_config
+    config = { :adapter => 'GumbyDB' }
+    sql = "SELECT * FROM \"horses\" WHERE \"name\" = 'pokey'"
+    statement = @sampler.build_database_statement(sql, config, Proc.new {})
+    assert_equal 'GumbyDB', statement.adapter
   end
 
   def test_harvest_prepare_samples

data/test/new_relic/json_wrapper_test.rb

@@ -3,10 +3,9 @@
 # See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
 
 require File.expand_path(File.join(File.dirname(__FILE__),'..','test_helper'))
-require 'test/unit'
 require 'newrelic_rpm'
 
-class JSONWrapperTest < Test::Unit::TestCase
+class JSONWrapperTest < MiniTest::Unit::TestCase
   def test_json_roundtrip
     obj = [
       99, 'luftballons',
@@ -32,7 +31,7 @@ class JSONWrapperTest < Test::Unit::TestCase
     def test_normalize_string_returns_munged_copy_if_ascii_8bit
       string = (0..255).to_a.pack("C*")
       result = NewRelic::JSONWrapper.normalize_string(string)
-      assert_not_same(string, result)
+      refute_same(string, result)
       assert_equal(Encoding.find('ISO-8859-1'), result.encoding)
       assert_equal(string, result.dup.force_encoding('ASCII-8BIT'))
     end
@@ -40,7 +39,7 @@ class JSONWrapperTest < Test::Unit::TestCase
     def test_normalize_string_returns_munged_copy_if_invalid_utf8
       string = (0..255).to_a.pack("C*").force_encoding('UTF-8')
       result = NewRelic::JSONWrapper.normalize_string(string)
-      assert_not_same(result, string)
+      refute_same(result, string)
       assert_equal(Encoding.find('ISO-8859-1'), result.encoding)
       assert_equal(string, result.dup.force_encoding('UTF-8'))
     end
@@ -48,7 +47,7 @@ class JSONWrapperTest < Test::Unit::TestCase
     def test_normalize_string_returns_munged_copy_if_other_convertible_encoding
       string = "i want a pony".encode('UTF-16LE')
       result = NewRelic::JSONWrapper.normalize_string(string)
-      assert_not_same(result, string)
+      refute_same(result, string)
       assert_equal(Encoding.find('UTF-8'), result.encoding)
       assert_equal(string, result.encode('UTF-16LE'))
     end
@@ -61,7 +60,7 @@ class JSONWrapperTest < Test::Unit::TestCase
       string = "Jyv+AOQ-skyl+AOQ-".force_encoding("UTF-7")
       assert string.valid_encoding?
       result = NewRelic::JSONWrapper.normalize_string(string)
-      assert_not_same(result, string)
+      refute_same(result, string)
       assert_equal(Encoding.find('ISO-8859-1'), result.encoding)
       assert_equal('Jyv+AOQ-skyl+AOQ-'.force_encoding('ISO-8859-1'), result)
     end

data/test/performance/suites/trace_execution_scoped.rb

@@ -0,0 +1,32 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+class TestClass
+  def method_1
+    trace_execution_scoped(['a', 'b']) do
+    end
+  end
+
+  def method_2
+    callback = Proc.new { ['c', 'd'] }
+    trace_execution_scoped(['a', 'b'], { :additional_metrics_callback => callback }) do
+    end
+  end
+end
+
+class TraceExecutionScopedTests < Performance::TestCase
+  def setup
+    @test_class = TestClass.new
+    TestClass.instance_eval('include NewRelic::Agent::MethodTracer')
+    require 'new_relic/agent/method_tracer'
+  end
+
+  def test_without_callback
+    iterations.times { @test_class.method_1 }
+  end
+
+  def test_with_callback
+    iterations.times { @test_class.method_2 }
+  end
+end

metadata

@@ -1,8 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: newrelic_rpm
 version: !ruby/object:Gem::Version
-  version: 3.7.2.190.beta
-  prerelease: 10
+  version: 3.7.2.192
+  prerelease: 
 platform: ruby
 authors:
 - Jason Clark
@@ -40,7 +40,7 @@ cert_chain:
   cHUySWFQWE92bTNUOEc0TzZxWnZobkxoL1VpZW4rK0RqOGVGQmVjVFBvTThw
   VmpLM3BoNQpuL0V3dVpDY0U2Z2h0Q0NNCi0tLS0tRU5EIENFUlRJRklDQVRF
   LS0tLS0K
-date: 2014-01-24 00:00:00.000000000 Z
+date: 2014-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -626,6 +626,12 @@ files:
 - test/multiverse/suites/httpclient/httpclient_test.rb
 - test/multiverse/suites/mongo/Envfile
 - test/multiverse/suites/mongo/config/newrelic.yml
+- test/multiverse/suites/mongo/helpers/mongo_operation_tests.rb
+- test/multiverse/suites/mongo/helpers/mongo_replica_set.rb
+- test/multiverse/suites/mongo/helpers/mongo_replica_set_test.rb
+- test/multiverse/suites/mongo/helpers/mongo_server.rb
+- test/multiverse/suites/mongo/helpers/mongo_server_test.rb
+- test/multiverse/suites/mongo/mongo_connection_test.rb
 - test/multiverse/suites/mongo/mongo_instrumentation_test.rb
 - test/multiverse/suites/mongo/mongo_unsupported_version_test.rb
 - test/multiverse/suites/net_http/Envfile
@@ -851,6 +857,7 @@ files:
 - test/performance/suites/rum_autoinsertion.rb
 - test/performance/suites/startup.rb
 - test/performance/suites/thread_profiling.rb
+- test/performance/suites/trace_execution_scoped.rb
 - test/performance/suites/transaction_tracing.rb
 - test/rum/basic.result.html
 - test/rum/basic.source.html
@@ -979,29 +986,30 @@ files:
 - lib/new_relic/build.rb
 homepage: http://www.github.com/newrelic/rpm
 licenses: []
-post_install_message: ! "# New Relic Ruby Agent Release Notes #\n\n## v3.7.1 ##\n\n*
-  MongoDB support\n\n  The Ruby agent provides support for the mongo gem, versions
-  1.8 and 1.9!\n  Mongo calls are captured for transaction traces along with their
-  parameters,\n  and time spent in Mongo shows up on the Database tab.\n\n  Support
-  for more Mongo gems and more UI goodness will be coming, so watch\n  http://docs.newrelic.com/docs/ruby/mongo
-  for up-to-date status.\n\n* Harvest thread restarts for forked and daemonized processes\n\n
-  \ Historically framework specific code was necessary for the Ruby agent to\n  successfully
-  report data after an app forked or daemonized. Gems or scripts\n  with daemonizing
-  modes had to wait for agent support or find workarounds.\n\n  With 3.7.1 setting
-  `restart_thread_in_children: true` in your newrelic.yml\n  automatically restarts
-  the agent in child processes without requiring custom\n  code. For now the feature
-  is opt-in, but future releases may default it on.\n\n* Fix for missing HTTP time\n\n
-  \ The agent previously did not include connection establishment time for\n  outgoing
-  Net::HTTP requests. This has been corrected, and reported HTTP\n  timings should
-  now be more accurate.\n\n* Fix for Mongo ensure_index instrumentation (3.7.1.182)\n\n
-  \ The Mongo instrumentation for ensure_index in 3.7.1.180 was not properly\n  calling
-  through to the uninstrumented version of this method. This has been\n  fixed in
-  3.7.1.182. Thanks to Yuki Miyauchi for the fix!\n\n* Correct first reported metric
-  timespan for forking dispatchers (3.7.1.188)\n\n  The first time a newly-forked
-  process (in some configurations) reported metric\n  data, it would use the startup
-  time of the parent process as the start time\n  for that metric data instead of
-  its own start time. This has been fixed.\n\nSee https://github.com/newrelic/rpm/blob/master/CHANGELOG
-  for a full list of\nchanges.\n"
+post_install_message: ! "# New Relic Ruby Agent Release Notes #\n\n## v3.7.2 ##\n\n*
+  Mongo instrumentation improvements\n\n  Users of the 'mongo' MongoDB client gem
+  will get more detailed instrumentation\n  including support for some operations
+  that were not previously captured, and\n  separation of aggregate metrics for web
+  transactions from background jobs.\n\n  An issue with ensure_index when passed a
+  symbol or string was also fixed.\n  Thanks Maxime RETY for the report!\n\n* More
+  accurate error tracing in Rails 4\n\n  Traced errors in Rails 4 applications will
+  now be correctly associated with\n  the transaction they occurred in, and custom
+  attributes attached to the\n  transaction will be correctly attached to the traced
+  error as well.\n\n* More accurate partial-rendering metrics for Rails 4\n\n  View
+  partials are now correctly treated as sub-components of the containing\n  template
+  render in Rails 4 applications, meaning that the app server breakdown\n  graphs
+  for Rails 4 transactions should be more accurate and useful.\n\n* Improved Unicorn
+  4.8.0 compatibility\n\n  A rare issue that could lead to spurrious traced errors
+  on app startup for\n  applications using Unicorn 4.8.0 has been fixed.\n\n* meta_request
+  gem compatibility\n\n  An incompatibility with the meta_request gem has been fixed.\n\n*
+  Typhoeus 0.6.4+ compatibility\n\n  A potential crash with Typhoeus 0.6.4+ when passing
+  a URI object instead of a\n  String instance to one of Typhoeus's HTTP request methods
+  has been fixed.\n\n* Sequel single threaded mode fix\n\n  The agent will no longer
+  attempt to run EXPLAIN queries for slow SQL\n  statements issued using the Sequel
+  gem in single-threaded mode, since\n  doing so could potentially cause crashes.\n\n*
+  Additional functionality for add_custom_parameters\n\n  Calling add_custom_parameters
+  adds parameters to the system codenamed\n  Rubicon. For more information, see http://newrelic.com/software-analytics\n\nSee
+  https://github.com/newrelic/rpm/blob/master/CHANGELOG for a full list of\nchanges.\n"
 rdoc_options:
 - --line-numbers
 - --inline-source