newrelic_rpm 3.7.0.177 → 3.7.1.180

data/test/new_relic/agent/datastores/mongo/metric_generator_test.rb

@@ -0,0 +1,43 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','..','test_helper'))
+require 'new_relic/agent/datastores/mongo/metric_generator'
+
+class NewRelic::Agent::Datastores::Mongo::MetricGeneratorTest < Test::Unit::TestCase
+  include ::NewRelic::TestHelpers::MongoMetricBuilder
+
+  def setup
+    @payload = { :collection => 'tribbles' }
+  end
+
+  def test_generate_metrics_for_includes_all_web_for_web_requests
+    NewRelic::Agent::Transaction.stubs(:recording_web_transaction?).returns(true)
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricGenerator.generate_metrics_for(:insert, @payload)
+
+    assert_includes metrics, 'Datastore/allWeb'
+  end
+
+  def test_generate_metrics_for_does_not_include_all_other_for_web_requests
+    NewRelic::Agent::Transaction.stubs(:recording_web_transaction?).returns(true)
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricGenerator.generate_metrics_for(:insert, @payload)
+
+    refute metrics.include? 'Datastore/allOther'
+  end
+
+  def test_generate_metrics_for_includes_all_other_for_other_requests
+    NewRelic::Agent::Transaction.stubs(:recording_web_transaction?).returns(false)
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricGenerator.generate_metrics_for(:insert, @payload)
+
+    assert_includes metrics, 'Datastore/allOther'
+  end
+
+  def test_generate_metrics_for_does_not_include_all_web_for_other_requests
+    NewRelic::Agent::Transaction.stubs(:recording_web_transaction?).returns(false)
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricGenerator.generate_metrics_for(:insert, @payload)
+
+    refute metrics.include? 'Datastore/allWeb'
+  end
+
+end

data/test/new_relic/agent/datastores/mongo/metric_translator_test.rb

@@ -0,0 +1,301 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+require 'new_relic/agent/datastores/mongo/metric_translator'
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','..','test_helper'))
+
+class NewRelic::Agent::Datastores::Mongo::MetricTranslatorTest < Test::Unit::TestCase
+  include ::NewRelic::TestHelpers::MongoMetricBuilder
+
+  def setup
+    @database_name = 'multiverse'
+    @collection_name = 'tribbles'
+  end
+
+  def test_metrics_for_insert
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:insert, { :collection => @collection_name })
+    expected = build_test_metrics(:insert)
+
+    assert_equal expected, metrics
+  end
+
+  def test_build_metrics_includes_web
+    expected = 'Datastore/allWeb'
+    metrics = build_test_metrics('test')
+
+    assert metrics.include? expected
+  end
+
+  def test_build_metrics_includes_other
+    expected = 'Datastore/allOther'
+    metrics = build_test_metrics('test', :other)
+
+    assert metrics.include? expected
+  end
+
+  def test_metrics_for_find
+    payload = { :database   => @database_name,
+                :collection => @collection_name,
+                :selector   => { "name" => "soterios johnson" } }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:find)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_find_one
+    payload = { :database   => @database_name,
+                :collection => @collection_name,
+                :selector   => {},
+                :limit      => -1 }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:findOne)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_remove
+    payload = { :database   => @database_name,
+                :collection => @collection_name,
+                :selector   => { "name" => "soterios johnson" } }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:remove, payload)
+    expected = build_test_metrics(:remove)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_update
+    payload = { :database   => @database_name,
+                :collection => @collection_name,
+                :selector   => { "name" => "soterios johnson" },
+                :document   => { "name" => "codemonkey" } }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:update, payload)
+    expected = build_test_metrics(:update)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_distinct
+    payload = { :database   => @database_name,
+                :collection => "$cmd",
+                :limit      => -1,
+                :selector   => { :distinct => @collection_name,
+                                 :key      => "name",
+                                 :query    => nil } }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:distinct, payload)
+    expected = build_test_metrics(:distinct)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_count
+    payload = { :database   => @database_name,
+                :collection => "$cmd",
+                :limit      => -1,
+                :selector   => { "count"  => @collection_name,
+                                 "query"  => {},
+                                 "fields" => nil } }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:count)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_group
+    payload = { :database   => @database_name,
+                :collection => "$cmd",
+                :limit      => -1,
+                :selector   => { "group" => { "ns"      => @collection_name,
+                                              "$reduce" => stub("BSON::Code"),
+                                              "cond"    => {},
+                                              "initial" => {:count=>0},
+                                              "key"     => {"name"=>1}}}}
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:group)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_aggregate
+    payload = { :database   => @database_name,
+                :collection => "$cmd",
+                :limit      => -1,
+                :selector   =>  { "aggregate" => @collection_name,
+                                  "pipeline" => [{"$group" => {:_id => "$says", :total => {"$sum" => 1}}}]}}
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:aggregate)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_mapreduce
+    payload = { :database   => @database_name,
+                :collection => "$cmd",
+                :limit      => -1,
+                :selector   =>  { "mapreduce" => @collection_name,
+                                  "map" => stub("BSON::Code"),
+                                  "reduce" => stub("BSON::Code"),
+                                  :out => "results"}}
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:mapreduce)
+
+    assert_equal expected, metrics
+  end
+
+
+  def test_metrics_for_find_and_modify
+    payload = { :database   => @database_name,
+                :collection => "$cmd",
+                :limit      => -1,
+                :selector   => { :findandmodify => @collection_name,
+                                 :query         => { "name" => "soterios johnson" },
+                                 :update        => {"name" => "codemonkey" } } }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:findAndModify)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_find_and_remove
+    payload = { :database   => @database_name,
+                :collection => "$cmd",
+                :limit      => -1,
+                :selector   => { :findandmodify => @collection_name,
+                                 :query         => { "name" => "soterios johnson" },
+                                 :remove        => true } }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:findAndRemove)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_create_index
+    payload = { :database   => @database_name,
+                :collection => "system.indexes",
+                :documents  => [ { :name => "name_1",
+                                    :ns   => "#{@database_name}.#{@collection_name}",
+                                    :key  => { "name" => 1 } } ] }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:insert, payload)
+    expected = build_test_metrics(:createIndex)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_drop_indexes
+    payload = { :database   => @database_name,
+                :collection => "$cmd",
+                :limit      => -1,
+                :selector => { :deleteIndexes => @collection_name,
+                               :index         => "*" } }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:dropIndexes)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_drop_index
+    payload = { :database => @database_name,
+                :collection => "$cmd",
+                :limit => -1,
+                :selector => { :deleteIndexes => @collection_name,
+                               :index => "name_1" } }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:dropIndex)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_reindex
+    payload = { :database => @database_name,
+                :collection => "$cmd",
+                :limit => -1,
+                :selector => { :reIndex=> @collection_name } }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:reIndex)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_drop_collection
+    payload = { :database   => @database_name,
+                :collection =>"$cmd",
+                :limit      => -1,
+                :selector   => { :drop => @collection_name } }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:drop)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_rename_collection
+    payload = { :database   => @database_name,
+                :collection => "$cmd",
+                :limit      => -1,
+                :selector   => { :renameCollection => "#{@database_name}.#{@collection_name}",
+                                 :to=>"#{@database_name}.renamed_#{@collection_name}" } }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:renameCollection)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_ismaster
+    payload = { :database   => @database_name,
+                :collection => "$cmd",
+                :limit      => -1,
+                :selector   => { :ismaster => 1 } }
+
+    @collection_name = "1"
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:ismaster)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_collstats
+    payload = { :database   => @database_name,
+                :collection =>"$cmd",
+                :limit      => -1,
+                :selector   => { :collstats => @collection_name } }
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:collstats)
+
+    assert_equal expected, metrics
+  end
+
+  def test_metrics_for_unknown_command
+    payload = { :database => @database_name,
+                :collection => "$cmd",
+                :limit => -1,
+                :selector => { :mongomongomongo => @collection_name } }
+
+    @collection_name = "UnknownCollection"
+
+    metrics = NewRelic::Agent::Datastores::Mongo::MetricTranslator.metrics_for(:find, payload)
+    expected = build_test_metrics(:UnknownCommand)
+
+    assert_equal expected, metrics
+    assert_metrics_recorded(["Supportability/Mongo/UnknownCommand"])
+  end
+
+end

data/test/new_relic/agent/datastores/mongo/obfuscator_test.rb

@@ -0,0 +1,91 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+require 'new_relic/agent/datastores/mongo/obfuscator'
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','..','test_helper'))
+
+module NewRelic
+  module Agent
+    module Datastores
+      module Mongo
+        class ObfuscatorTest < Test::Unit::TestCase
+          def test_obfuscator_removes_values_from_statement
+            selector = {
+              'name'     => 'soterios johnson',
+              :operation => :find,
+              :_id       => "BSON::ObjectId('?')"
+            }
+
+            expected = {
+              'name'     => '?',
+              :operation => :find,
+              :_id       => '?'
+            }
+
+            obfuscated = Obfuscator.obfuscate_statement(selector)
+            assert_equal expected, obfuscated
+          end
+
+          def test_obfuscate_selector_values_skips_whitelisted_keys
+            selector   = {
+              :benign    => 'bland data',
+              :operation => :find,
+              :_id       => "BSON::ObjectId('?')"
+            }
+
+            expected   = {
+              :benign    => 'bland data',
+              :operation => :find,
+              :_id       => '?'
+            }
+
+            obfuscated = Obfuscator.obfuscate_statement(selector, [:benign, :operation])
+            assert_equal expected, obfuscated
+          end
+
+          def test_obfuscate_nested_hashes
+            selector = {
+              "group" => {
+                "ns"      => "tribbles",
+                "$reduce" => stub("BSON::Code"),
+                "cond"    => {},
+                "initial" => { :count => 0 },
+                "key"     => { "name" => 1 }
+              }
+            }
+
+            expected = {
+              "group" => {
+                "ns"      => "?",
+                "$reduce" => "?",
+                "cond"    => {},
+                "initial" => { :count => "?" },
+                "key"     => { "name" => "?" }
+              }
+            }
+
+            obfuscated = Obfuscator.obfuscate_statement(selector)
+            assert_equal expected, obfuscated
+          end
+
+          def test_obfuscate_nested_arrays
+            selector = {
+              "aggregate" => "mongeese",
+              "pipeline"  => [{"$group"=>{:_id=>"$says", :total=>{"$sum"=>1}}}]
+            }
+
+            expected = {
+              "aggregate" => "?",
+              "pipeline"  => [{"$group"=>{:_id=>"?", :total=>{"$sum"=>"?"}}}]
+            }
+
+            obfuscated = Obfuscator.obfuscate_statement(selector)
+            assert_equal expected, obfuscated
+          end
+
+        end
+      end
+    end
+  end
+end

data/test/new_relic/agent/datastores/mongo/statement_formatter_test.rb

@@ -0,0 +1,71 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','..','test_helper'))
+require 'new_relic/agent/datastores/mongo/statement_formatter'
+
+module NewRelic
+  module Agent
+    module Datastores
+      module Mongo
+        class StatementFormatterTest < Test::Unit::TestCase
+          DOC_STATEMENT = { :database   => "multiverse",
+                            :collection => "tribbles",
+                            :operation  => :insert,
+                            :fields     => ["field_name"],
+                            :skip       => 1,
+                            :limit      => -1,
+                            :order      => :ascending,
+
+                            :ignored    => "we're whitelisted!",
+                            :documents  => [ { "name" => "soterios johnson",
+                                               :_id   => "BSON::ObjectId()" } ] }.freeze
+
+
+          SELECTOR_STATEMENT = { :database   => 'multiverse',
+                                 :collection => 'tribbles',
+                                 :selector   => { 'name'     => 'soterios johnson',
+                                                  :operation => :find,
+                                                  :_id       => "BSON::ObjectId('?')" } }.freeze
+
+          def test_doesnt_modify_incoming_statement
+            formatted = StatementFormatter.format(DOC_STATEMENT)
+            assert_not_same DOC_STATEMENT, formatted
+          end
+
+          def test_statement_formatter_removes_unwhitelisted_keys
+            formatted = StatementFormatter.format(DOC_STATEMENT)
+            assert_equal_unordered(formatted.keys, StatementFormatter::PLAINTEXT_KEYS)
+          end
+
+          def test_can_disable_statement_capturing_queries
+            with_config(:'mongo.capture_queries' => false) do
+              formatted = StatementFormatter.format(DOC_STATEMENT)
+              assert_nil formatted
+            end
+          end
+
+          def test_statement_formatter_obfuscates_by_default
+            expected = { :database   => 'multiverse',
+                         :collection => 'tribbles',
+                         :selector   => { 'name'     => '?',
+                                          :operation => :find,
+                                          :_id       => '?' } }
+
+            result = StatementFormatter.format(SELECTOR_STATEMENT)
+            assert_equal expected, result
+          end
+
+          def test_statement_formatter_raw_selectors
+            with_config(:'mongo.obfuscate_queries' => false) do
+              result = StatementFormatter.format(SELECTOR_STATEMENT)
+              assert_equal SELECTOR_STATEMENT, result
+            end
+          end
+
+        end
+      end
+    end
+  end
+end