newrelic_rpm 3.6.6.147 → 3.6.7.152

data/test/new_relic/agent/browser_token_test.rb

@@ -0,0 +1,52 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','test_helper'))
+require 'new_relic/agent/browser_token'
+
+module NewRelic::Agent
+  class BrowserTokenTest < Test::Unit::TestCase
+    def assert_token(expected, cookies)
+      request = stub(:cookies => cookies)
+      assert_equal(expected, BrowserToken.get_token(request))
+    end
+
+    def test_get_token_safe_token_returned_untouched
+      assert_token("12345678", 'NRAGENT' => 'tk=12345678')
+    end
+
+    def test_get_token_with_embedded_tags_sanitized
+      assert_token("", 'NRAGENT' => 'tk=1234<tag>evil</tag>5678')
+    end
+
+    def test_get_token_with_embedded_utf8_js_sanitized
+      assert_token("1234&amp;#34&amp;#93&amp;#41&amp;#595678", 'NRAGENT' => "tk=1234&#34&#93&#41&#595678")
+    end
+
+    def test_get_token_replaces_double_quoted_token_with_empty_string
+      assert_token("", 'NRAGENT' => 'tk="""deadbeef"""')
+    end
+
+    def test_get_token_replaces_single_quoted_token_with_empty_string
+      assert_token("", 'NRAGENT' => "tk='''deadbeef'''")
+    end
+
+    def test_get_token_replaces_token_started_with_multiple_Lt_with_empty_string
+      assert_token("", 'NRAGENT' => 'tk=<<<deadbeef')
+    end
+
+    def test_get_token_replaces_token_started_with_multiple_gt_with_empty_string
+      assert_token("", 'NRAGENT' => 'tk=>>>deadbeef')
+    end
+
+    def test_get_token_bare_value_replaced_with_nil
+      assert_token(nil, 'NRAGENT' => 0xdeadbeef)
+    end
+
+    def test_get_token_nil_token_returns_nil_token
+      assert_token(nil, 'NRAGENT' => nil)
+    end
+
+  end
+end

data/test/new_relic/agent/busy_calculator_test.rb

@@ -91,7 +91,7 @@ class NewRelic::Agent::BusyCalculatorTest < Test::Unit::TestCase
   end
 
   def test_finishing_without_starting_doesnt_raise
-    Thread.current[:busy_entries] = nil
+    NewRelic::Agent::TransactionState.clear
     assert_nothing_raised do
       NewRelic::Agent::BusyCalculator.dispatcher_finish
     end

data/test/new_relic/agent/commands/agent_command_router_test.rb

@@ -0,0 +1,98 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
+require 'new_relic/agent/commands/agent_command_router'
+
+class AgentCommandRouterTest < Test::Unit::TestCase
+
+  DEFAULT_ARGS = {
+    "profile_id" => 42
+  }
+
+  BAZZLE_ID = 123
+  BAZZLE = [BAZZLE_ID,{
+    "name" => "bazzle",
+    "arguments" => DEFAULT_ARGS
+  }]
+
+  BOOM_ID = 666
+  BOOM = [BOOM_ID,{
+    "name" => "boom",
+    "arguments" => DEFAULT_ARGS
+  }]
+
+  UNRECOGNIZED_ID = 42
+  UNRECOGNIZED = [UNRECOGNIZED_ID, {
+    "name" => "JIBBERISH",
+    "arguments" => {}
+  }]
+
+  attr_reader :service, :agent_commands, :calls
+
+  def setup
+    @service = stub
+    @calls = []
+
+    @agent_commands = NewRelic::Agent::Commands::AgentCommandRouter.new(@service, nil)
+    @agent_commands.handlers["bazzle"] = Proc.new { |args| handle_bazzle_command(args) }
+    @agent_commands.handlers["boom"]   = Proc.new { |args| handle_boom_command(args) }
+  end
+
+  def test_handle_agent_commands_dispatches_command
+    service.stubs(:get_agent_commands).returns([BAZZLE])
+    service.stubs(:agent_command_results)
+
+    agent_commands.handle_agent_commands
+
+    assert_equal [DEFAULT_ARGS], calls
+  end
+
+  def test_handle_agent_commands_generates_results
+    service.stubs(:get_agent_commands).returns([BAZZLE])
+    service.expects(:agent_command_results).with({ BAZZLE_ID.to_s => {} })
+
+    agent_commands.handle_agent_commands
+  end
+
+  def test_handle_agent_commands_dispatches_with_error
+    service.stubs(:get_agent_commands).returns([BOOM])
+    service.expects(:agent_command_results).with({ BOOM_ID.to_s => { "error" => "BOOOOOM" }})
+
+    agent_commands.handle_agent_commands
+  end
+
+  def test_handle_agent_commands_allows_multiple
+    service.stubs(:get_agent_commands).returns([BAZZLE, BOOM])
+    service.expects(:agent_command_results).with({ BAZZLE_ID.to_s => {},
+                                                   BOOM_ID.to_s => { "error" => "BOOOOOM" }})
+    agent_commands.handle_agent_commands
+  end
+
+  def test_handle_agent_commands_doesnt_call_results_if_no_commands
+    service.stubs(:get_agent_commands).returns([])
+    service.expects(:agent_command_results).never
+
+    agent_commands.handle_agent_commands
+  end
+
+  def test_unrecognized_commands
+    service.stubs(:get_agent_commands).returns([UNRECOGNIZED])
+    service.stubs(:agent_command_results)
+
+    expects_logging(:debug, regexp_matches(/unrecognized/i))
+
+    agent_commands.handle_agent_commands
+  end
+
+  # Helpers
+
+  def handle_bazzle_command(command)
+    calls << command.arguments
+  end
+
+  def handle_boom_command(command)
+    raise NewRelic::Agent::Commands::AgentCommandRouter::AgentCommandError.new("BOOOOOM")
+  end
+end

data/test/new_relic/agent/commands/agent_command_test.rb

@@ -0,0 +1,37 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
+require 'new_relic/agent/commands/agent_command'
+
+module NewRelic::Agent::Commands
+  class AgentCommandTest < Test::Unit::TestCase
+    ID = 123
+    NAME = 'nuke_it_from_orbit'
+    ARGUMENTS = { "profile_id" => 42 }
+
+    NUKE_IT_FROM_ORBIT = [ID,{
+      "name" => NAME,
+      "arguments" => ARGUMENTS
+    }]
+
+    def test_destructures_name_from_collector_command
+      command = AgentCommand.new(NUKE_IT_FROM_ORBIT)
+      expected = NAME
+      assert_equal expected, command.name
+    end
+
+    def test_destructures_id_from_collector_command
+      command = AgentCommand.new(NUKE_IT_FROM_ORBIT)
+      expected = ID
+      assert_equal expected, command.id
+    end
+
+    def test_destructures_arguments_from_collector_command
+      command = AgentCommand.new(NUKE_IT_FROM_ORBIT)
+      expected = ARGUMENTS
+      assert_equal expected, command.arguments
+    end
+  end
+end

data/test/new_relic/agent/commands/thread_profiler_test.rb

@@ -0,0 +1,177 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
+require 'base64'
+require 'thread'
+require 'timeout'
+require 'zlib'
+require 'new_relic/agent/threading/threaded_test_case'
+require 'new_relic/agent/commands/thread_profiler'
+#require 'test/new_relic/agent/commands/agent_command_test'
+
+module ThreadProfilerTestHelpers
+  START = {
+    "profile_id" => 42,
+    "sample_period" => 0.02,
+    "duration" => 0.025,
+    "only_runnable_threads" => false,
+    "only_request_threads" => false,
+    "profile_agent_code" => false,
+  }
+  STOP = {
+    "profile_id" => 42,
+    "report_data" => true,
+  }
+
+  STOP_AND_DISCARD = {
+    "profile_id" => 42,
+    "report_data" => false,
+  }
+
+  def start_command
+    create_agent_command(START)
+  end
+
+  def stop_command
+    create_agent_command(STOP)
+  end
+
+  def stop_and_discard_command
+    create_agent_command(STOP_AND_DISCARD)
+  end
+end
+
+if !NewRelic::Agent::Commands::ThreadProfiler.is_supported?
+
+  class ThreadProfilerUnsupportedTest < Test::Unit::TestCase
+    include ThreadProfilerTestHelpers
+
+    def setup
+      @profiler = NewRelic::Agent::Commands::ThreadProfiler.new
+    end
+
+    def test_thread_profiling_isnt_supported
+      assert_equal false, NewRelic::Agent::Commands::ThreadProfiler.is_supported?
+    end
+
+    def test_stop_is_safe_when_not_supported
+      @profiler.start(start_command)
+      @profiler.stop(true)
+    end
+
+    def test_wont_start_and_reports_error
+      errors = nil
+      assert_raise NewRelic::Agent::Commands::AgentCommandRouter::AgentCommandError do
+        @profiler.handle_start_command(start_command)
+      end
+      assert_equal false, @profiler.running?
+    end
+
+  end
+
+else
+
+  require 'json'
+
+  class ThreadProfilerTest < ThreadedTestCase
+    include ThreadProfilerTestHelpers
+
+    def setup
+      super
+      @profiler = NewRelic::Agent::Commands::ThreadProfiler.new
+    end
+
+    def test_is_supported
+      assert NewRelic::Agent::Commands::ThreadProfiler.is_supported?
+    end
+
+    def test_is_not_running
+      assert !@profiler.running?
+    end
+
+    def test_is_running
+      @profiler.start(start_command)
+      assert @profiler.running?
+    end
+
+    def test_is_not_finished_if_no_profile_started
+      assert !@profiler.finished?
+    end
+
+    def test_can_stop_a_running_profile
+      @profiler.start(start_command)
+      assert @profiler.running?
+
+      @profiler.stop(true)
+
+      assert @profiler.finished?
+      assert_not_nil @profiler.harvest
+    end
+
+    def test_can_stop_a_running_profile_and_discard
+      @profiler.start(start_command)
+      assert @profiler.running?
+
+      @profiler.stop(false)
+
+      assert_nil @profiler.harvest
+    end
+
+    def test_wont_crash_if_stopping_when_not_started
+      @profiler.stop(true)
+      assert_equal false, @profiler.running?
+    end
+
+    def test_handle_start_command_starts_running
+      @profiler.handle_start_command(start_command)
+      assert_equal true, @profiler.running?
+    end
+
+    def test_handle_stop_command
+      @profiler.start(start_command)
+      assert @profiler.running?
+
+      @profiler.handle_stop_command(stop_command)
+      assert_equal true, @profiler.finished?
+    end
+
+    def test_handle_stop_command_and_discard
+      @profiler.start(start_command)
+      assert @profiler.running?
+
+      @profiler.handle_stop_command(stop_and_discard_command)
+      assert_nil @profiler.harvest
+    end
+
+    def test_handle_start_command_wont_start_second_profile
+      @profiler.handle_start_command(start_command)
+      original_profile = @profiler.instance_variable_get(:@profile)
+
+      begin
+        @profiler.handle_start_command(start_command)
+      rescue NewRelic::Agent::Commands::AgentCommandRouter::AgentCommandError
+      end
+
+      assert_equal original_profile, @profiler.harvest
+    end
+
+    def test_start_command_sent_twice_raises_error
+      @profiler.handle_start_command(start_command)
+
+      assert_raise NewRelic::Agent::Commands::AgentCommandRouter::AgentCommandError do
+        @profiler.handle_start_command(start_command)
+      end
+    end
+
+    def test_command_attributes_passed_along
+      @profiler.handle_start_command(start_command)
+      profile = @profiler.harvest
+      assert_equal 42,  profile.profile_id
+      assert_equal 0.02, profile.interval
+      assert_equal false, profile.profile_agent_code
+    end
+
+  end
+end

data/test/new_relic/agent/configuration/default_source_test.rb

@@ -0,0 +1,81 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
+require 'new_relic/agent/configuration/default_source'
+
+module NewRelic::Agent::Configuration
+  class DefaultSourceTest < Test::Unit::TestCase
+    def setup
+      @default_source = DefaultSource.new
+      @defaults = ::NewRelic::Agent::Configuration::DEFAULTS
+    end
+
+    def test_default_values_have_a_public_setting
+      @defaults.each do |config_setting, config_value|
+        assert_not_nil config_value[:public], "Config setting: #{config_setting}"
+      end
+    end
+
+    def test_default_values_have_types
+      @defaults.each do |config_setting, config_value|
+        assert_not_nil config_value[:type], "Config setting: #{config_setting}"
+      end
+    end
+
+    def test_default_values_have_descriptions
+      @defaults.each do |config_setting, config_value|
+        assert_not_nil config_value[:description]
+        assert config_value[:description].length > 0, "Config setting: #{config_setting}"
+      end
+    end
+
+    def test_declared_types_match_default_values
+      NewRelic::Control.instance.local_env.stubs(:discovered_dispatcher).returns(:unicorn)
+
+      @default_source.keys.each do |key|
+        default_value_class = get_config_value_class(fetch_config_value(key))
+        assert_equal @defaults[key][:type], default_value_class, "Config setting #{key} does not have the correct type."
+      end
+    end
+
+    def test_default_values_maps_keys_to_their_default_values
+      default_values = @default_source.default_values
+
+      @defaults.each do |key, value|
+        assert_equal value[:default], default_values[key]
+      end
+    end
+
+    def fetch_config_value(key)
+      accessor = key.to_sym
+      config = @default_source
+
+      if config.has_key?(accessor)
+        if config[accessor].respond_to?(:call)
+          value = config[accessor]
+
+          while value.respond_to?(:call)
+            value = config.instance_eval(&value)
+          end
+
+          return value
+        else
+          return config[accessor]
+        end
+      end
+      nil
+    end
+
+    def get_config_value_class(value)
+      type = value.class
+
+      if type == TrueClass || type == FalseClass
+        Boolean
+      else
+        type
+      end
+    end
+  end
+end