newrelic_rpm 3.5.7.59 → 3.5.8.64.beta

data/test/new_relic/agent/error_collector_test.rb

@@ -162,10 +162,10 @@ class NewRelic::Agent::ErrorCollectorTest < Test::Unit::TestCase
 
   def test_exclude_block
     @error_collector.ignore_error_filter &wrapped_filter_proc
-        
+
     @error_collector.notice_error(IOError.new("message"), :metric => 'path', :request_params => {:x => 'y'})
     @error_collector.notice_error(StandardError.new("message"), :metric => 'path', :request_params => {:x => 'y'})
-    
+
     errors = @error_collector.harvest_errors([])
 
     assert_equal 1, errors.length
@@ -192,6 +192,30 @@ class NewRelic::Agent::ErrorCollectorTest < Test::Unit::TestCase
     end
   end
 
+  def test_increment_error_count_record_summary_and_txn_metric
+    txn_info = NewRelic::Agent::TransactionInfo.new
+    txn_info.transaction_name = 'Controller/class/method'
+    NewRelic::Agent::TransactionInfo.stubs(:get).returns(txn_info)
+
+    stats_engine = NewRelic::Agent.instance.stats_engine
+    stats_engine.reset_stats
+    @error_collector.increment_error_count!(StandardError.new('Boo'))
+    assert_equal(1, stats_engine.get_stats('Errors/all').call_count,
+                 'Missing Errors/all metric')
+    assert_equal(1, stats_engine.get_stats('Errors/Controller/class/method').call_count,
+                 'Missing Errors/Controller/class/method metric')
+  end
+
+  def test_doesnt_increment_error_count_on_transaction_if_nameless
+    txn_info = NewRelic::Agent::TransactionInfo.new
+    NewRelic::Agent::TransactionInfo.stubs(:get).returns(txn_info)
+
+    stats_engine = NewRelic::Agent.instance.stats_engine
+    stats_engine.reset_stats
+    @error_collector.increment_error_count!(StandardError.new('Boo'))
+    assert_equal(0, stats_engine.get_stats('Errors/(unknown)').call_count)
+  end
+
   private
 
   def expects_error_count_increase(increase)
@@ -203,7 +227,7 @@ class NewRelic::Agent::ErrorCollectorTest < Test::Unit::TestCase
   def get_error_stats
     NewRelic::Agent.get_stats("Errors/all").call_count
   end
-  
+
   def wrapped_filter_proc
     Proc.new do |e|
       if e.is_a? IOError
@@ -213,7 +237,7 @@ class NewRelic::Agent::ErrorCollectorTest < Test::Unit::TestCase
       end
     end
   end
-  
+
   def silence_stream(*args)
     super
   rescue NoMethodError

data/test/new_relic/agent/event_listener_test.rb

@@ -14,6 +14,24 @@ class EventListenerTest < Test::Unit::TestCase
     end
   end
 
+
+  #
+  # Helpers
+  #
+
+  def assert_was_called
+    assert @called, "Event wasn't called"
+  end
+
+  def assert_was_not_called
+    assert !@called, "Event was called"
+  end
+
+
+  #
+  # Tests
+  #
+
   def test_notifies
     @events.subscribe(:before_call, &@check_method)
     @events.notify(:before_call, :env => "env")
@@ -37,9 +55,12 @@ class EventListenerTest < Test::Unit::TestCase
     @events.subscribe(:my_event) {}
   end
 
+  def test_clear
+    @events.subscribe(:after_call, &@check_method)
+    @events.clear
+    @events.notify(:after_call)
 
-  def assert_was_called
-    assert @called, "Event wasn't called"
+    assert_was_not_called
   end
 
 end

data/test/new_relic/agent/instrumentation/controller_instrumentation_test.rb

@@ -36,4 +36,57 @@ class NewRelic::Agent::Instrumentation::ControllerInstrumentationTest < Test::Un
       .with({:request => 'headers'}, start_time).raises("an error")
     assert_equal(start_time, @object.send(:_detect_upstream_wait, start_time))
   end
+
+  def test_transaction_name_calls_newrelic_metric_path
+    @object.stubs(:newrelic_metric_path).returns('some/wacky/path')
+    assert_equal('Controller/some/wacky/path', @object.send(:transaction_name))
+  end
+
+  def test_transaction_name_applies_category_and_path
+    assert_equal('Controller/metric/path',
+                 @object.send(:transaction_name,
+                              :category => :controller,
+                              :path => 'metric/path'))
+    assert_equal('OtherTransaction/Background/metric/path',
+                 @object.send(:transaction_name,
+                              :category => :task, :path => 'metric/path'))
+    assert_equal('Controller/Rack/metric/path',
+                 @object.send(:transaction_name,
+                              :category => :rack, :path => 'metric/path'))
+    assert_equal('Controller/metric/path',
+                 @object.send(:transaction_name,
+                              :category => :uri, :path => 'metric/path'))
+    assert_equal('Controller/Sinatra/metric/path',
+                 @object.send(:transaction_name,
+                              :category => :sinatra,
+                              :path => 'metric/path'))
+    assert_equal('Blarg/metric/path',
+                 @object.send(:transaction_name,
+                              :category => 'Blarg', :path => 'metric/path'))
+
+  end
+
+  def test_transaction_name_uses_class_name_if_path_not_specified
+    assert_equal('Controller/NewRelic::Agent::Instrumentation::ControllerInstrumentationTest::TestObject',
+                 @object.send(:transaction_name, :category => :controller))
+  end
+
+  def test_transaction_name_applies_action_name_if_specified_and_not_path
+    assert_equal('Controller/NewRelic::Agent::Instrumentation::ControllerInstrumentationTest::TestObject/action',
+                 @object.send(:transaction_name, :category => :controller,
+                              :name => 'action'))
+  end
+
+  def test_transaction_name_applies_name_rules
+    rule = NewRelic::Agent::RulesEngine::Rule.new('match_expression' => '[0-9]+',
+                                                  'replacement'      => '*',
+                                                  'replace_all'      => true)
+    NewRelic::Agent.instance.transaction_rules << rule
+    assert_equal('foo/*/bar/*',
+                 @object.send(:transaction_name, :category => 'foo',
+                              :path => '1/bar/22'))
+  ensure
+    NewRelic::Agent.instance.instance_variable_set(:@transaction_rules,
+                                              NewRelic::Agent::RulesEngine.new)
+  end
 end

data/test/new_relic/agent/instrumentation/metric_frame_test.rb

@@ -53,4 +53,99 @@ class NewRelic::Agent::Instrumentation::MetricFrameTest < Test::Unit::TestCase
     f.start = 1500
     assert_equal 500, f.queue_time
   end
+
+  def test_update_apdex_records_failed_when_specified
+    stats = NewRelic::Agent::Stats.new
+    NewRelic::Agent::Instrumentation::MetricFrame.update_apdex(stats, 0.1, true)
+    assert_equal 0, stats.apdex_s
+    assert_equal 0, stats.apdex_t
+    assert_equal 1, stats.apdex_f
+  end
+
+  def test_update_apdex_records_satisfying
+    stats = NewRelic::Agent::Stats.new
+    with_config(:apdex_t => 1) do
+      NewRelic::Agent::Instrumentation::MetricFrame.update_apdex(stats, 0.5, false)
+    end
+    assert_equal 1, stats.apdex_s
+    assert_equal 0, stats.apdex_t
+    assert_equal 0, stats.apdex_f
+  end
+
+  def test_update_apdex_records_tolerating
+    stats = NewRelic::Agent::Stats.new
+    with_config(:apdex_t => 1) do
+      NewRelic::Agent::Instrumentation::MetricFrame.update_apdex(stats, 1.5, false)
+    end
+    assert_equal 0, stats.apdex_s
+    assert_equal 1, stats.apdex_t
+    assert_equal 0, stats.apdex_f
+  end
+
+  def test_update_apdex_records_failing
+    stats = NewRelic::Agent::Stats.new
+    with_config(:apdex_t => 1) do
+      NewRelic::Agent::Instrumentation::MetricFrame.update_apdex(stats, 4.5, false)
+    end
+    assert_equal 0, stats.apdex_s
+    assert_equal 0, stats.apdex_t
+    assert_equal 1, stats.apdex_f
+  end
+
+  def test_update_apdex_records_correct_apdex_for_key_transaction
+    txn_info = NewRelic::Agent::TransactionInfo.get
+    stats = NewRelic::Agent::Stats.new
+    config = {
+      :web_transactions_apdex => {
+        'Controller/slow/txn' => 4,
+        'Controller/fast/txn' => 0.1,
+      },
+      :apdex => 1
+    }
+
+    txn_info.transaction_name = 'Controller/slow/txn'
+    with_config(config, :do_not_cast => true) do
+      NewRelic::Agent::Instrumentation::MetricFrame.update_apdex(stats, 3.5, false)
+      NewRelic::Agent::Instrumentation::MetricFrame.update_apdex(stats, 5.5, false)
+      NewRelic::Agent::Instrumentation::MetricFrame.update_apdex(stats, 16.5, false)
+    end
+    assert_equal 1, stats.apdex_s
+    assert_equal 1, stats.apdex_t
+    assert_equal 1, stats.apdex_f
+
+    txn_info.transaction_name = 'Controller/fast/txn'
+    with_config(config, :do_not_cast => true) do
+      NewRelic::Agent::Instrumentation::MetricFrame.update_apdex(stats, 0.05, false)
+      NewRelic::Agent::Instrumentation::MetricFrame.update_apdex(stats, 0.2, false)
+      NewRelic::Agent::Instrumentation::MetricFrame.update_apdex(stats, 0.5, false)
+    end
+    assert_equal 2, stats.apdex_s
+    assert_equal 2, stats.apdex_t
+    assert_equal 2, stats.apdex_f
+
+    txn_info.transaction_name = 'Controller/other/txn'
+    with_config(config, :do_not_cast => true) do
+      NewRelic::Agent::Instrumentation::MetricFrame.update_apdex(stats, 0.5, false)
+      NewRelic::Agent::Instrumentation::MetricFrame.update_apdex(stats, 2, false)
+      NewRelic::Agent::Instrumentation::MetricFrame.update_apdex(stats, 5, false)
+    end
+    assert_equal 3, stats.apdex_s
+    assert_equal 3, stats.apdex_t
+    assert_equal 3, stats.apdex_f
+  end
+
+  def test_record_apdex_stores_apdex_t_in_min_and_max
+    stats_engine = NewRelic::Agent.instance.stats_engine
+    stats_engine.reset_stats
+    metric = stub(:apdex_metric_path => 'Apdex/Controller/some/txn')
+    NewRelic::Agent.instance.instance_variable_set(:@stats_engine, stats_engine)
+
+    with_config(:apdex_t => 2.5) do
+      NewRelic::Agent::Instrumentation::MetricFrame.record_apdex(metric, 1, 1, false)
+    end
+    assert_equal 2.5, stats_engine.lookup_stats('Apdex').min_call_time
+    assert_equal 2.5, stats_engine.lookup_stats('Apdex').max_call_time
+    assert_equal 2.5, stats_engine.lookup_stats('Apdex/Controller/some/txn').min_call_time
+    assert_equal 2.5, stats_engine.lookup_stats('Apdex/Controller/some/txn').max_call_time
+  end
 end

data/test/new_relic/agent/instrumentation/net_instrumentation_test.rb

@@ -1,84 +1,439 @@
-unless ENV['FAST_TESTS']
-  require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
+#!/usr/bin/env ruby
+# encoding: utf-8
 
-  class NewRelic::Agent::Instrumentation::NetInstrumentationTest < Test::Unit::TestCase
-    include NewRelic::Agent::Instrumentation::ControllerInstrumentation
-    def setup
-      NewRelic::Agent.manual_start
-      @engine = NewRelic::Agent.instance.stats_engine
-      @engine.clear_stats
+require 'net/http'
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
+require 'new_relic/agent/cross_app_tracing'
+
+# Add some stuff to Net::HTTP::HTTPResponse to facilitate building response data
+class Net::HTTPResponse
+  def to_s
+    buf = ''
+    buf << "HTTP/%s %d %s\r\n" % [ self.http_version, self.code, self.message ]
+    self.each_capitalized {|k,v| buf << k << ': ' << v << "\r\n" }
+    buf << "\r\n"
+    buf << @body if @body
+    return buf
+  end
+  def initialize_copy( original )
+    @http_version = @http_version.dup
+    @code         = @code.dup
+    @message      = @message.dup
+    @body         = @body.dup
+    @read         = false
+    @header       = @header.dup
+  end
+
+  unless instance_methods.map {|name| name.to_sym }.include?( :body= )
+    def body=( newbody )
+      @body = newbody
     end
+  end
+end
+    
+
+class NewRelic::Agent::Instrumentation::NetInstrumentationTest < Test::Unit::TestCase
+  include NewRelic::Agent::Instrumentation::ControllerInstrumentation,
+          NewRelic::Agent::CrossAppMonitor::EncodingFunctions,
+          NewRelic::Agent::CrossAppTracing
+
+  CANNED_RESPONSE = Net::HTTPOK.new( '1.1', '200', 'OK' )
+  CANNED_RESPONSE.body = 
+    '<html><head><title>Canned Response</title></head><body>Canned response.</body></html>'
+  CANNED_RESPONSE['content-type'] = 'text/html; charset=UTF-8'
+  CANNED_RESPONSE['date'] = 'Tue, 29 Jan 2013 21:52:04 GMT'
+  CANNED_RESPONSE['expires'] = '-1'
+  CANNED_RESPONSE['server'] = 'gws'
+  CANNED_RESPONSE.freeze
+
+  TRANSACTION_GUID = 'BEC1BC64675138B9'
+
+
+  def setup
+    NewRelic::Agent.manual_start(
+      :"cross_application_tracer.enabled" => false,
+      :"transaction_tracer.enabled"       => true,
+      :cross_process_id                   => '269975#22824',
+      :encoding_key                       => 'gringletoes'
+    )
+
+    # $stderr.puts '', '---', ''
+    # NewRelic::Agent.logger = NewRelic::Agent::AgentLogger.new( {:log_level => 'debug'}, '', Logger.new($stderr) )
+
+    @engine = NewRelic::Agent.instance.stats_engine
+    @engine.clear_stats
+
+    @engine.start_transaction( 'test' )
+    NewRelic::Agent::TransactionInfo.get.guid = TRANSACTION_GUID
+
+    @sampler = NewRelic::Agent.instance.transaction_sampler
+    @sampler.notice_first_scope_push( Time.now.to_f )
+    @sampler.notice_transaction( '/path', '/path', {} )
+    @sampler.notice_push_scope "Controller/sandwiches/index"
+    @sampler.notice_sql("SELECT * FROM sandwiches WHERE bread = 'wheat'", nil, 0)
+    @sampler.notice_push_scope "ab"
+    @sampler.notice_sql("SELECT * FROM sandwiches WHERE bread = 'white'", nil, 0)
+    @sampler.notice_push_scope "fetch_external_service"
+
+    @response = CANNED_RESPONSE.clone
+    @socket = fixture_tcp_socket( @response )
+  end
+
+  def teardown
+    NewRelic::Agent.instance.transaction_sampler.reset!
+    Thread::current[:newrelic_scope_stack] = nil
+    NewRelic::Agent.instance.stats_engine.end_transaction
+  end
+
+
+  #
+  # Helpers
+  #
+
+  def fixture_tcp_socket( response )
+
+    # Don't actually talk to Google.
+    socket = stub("socket") do
+      stubs(:closed?).returns(false)
+      stubs(:close)
+
+      # Simulate a bunch of socket-ey stuff since Mocha doesn't really
+      # provide any other way to do it
+      class << self
+        attr_accessor :response, :write_checker
+      end
+
+      def self.check_write
+        self.write_checker = Proc.new
+      end
+
+      def self.write( buf )
+        self.write_checker.call( buf ) if self.write_checker
+        buf.length
+      end
+      
+      def self.sysread( size, buf='' )
+        @data ||= response.to_s
+        raise EOFError if @data.empty?
+        buf.replace @data.slice!( 0, size )
+        buf
+      end
+      class << self
+        alias_method :read_nonblock, :sysread
+      end
 
-    def metrics_without_gc
-      @engine.metrics - ['GC/cumulative']
     end
 
-    private :metrics_without_gc
+    socket.response = response
+    TCPSocket.stubs( :open ).returns( socket )
+
+    return socket
+  end
+
+
+  def make_app_data_payload( *args )
+    return obfuscate_with_key( 'gringletoes', args.to_json ).gsub( /\n/, '' ) + "\n"
+  end
+
+
+  def find_last_segment
+    builder = NewRelic::Agent.agent.transaction_sampler.builder
+    last_segment = nil
+    builder.current_segment.each_segment {|s| last_segment = s }
 
-    def test_get
+    return last_segment
+  end
+
+
+
+  #
+  # Tests
+  #
+
+  def test_get
+    url = URI.parse('http://www.google.com/index.html')
+    res = Net::HTTP.start(url.host, url.port) {|http|
+      http.get('/index.html')
+    }
+      
+    assert_match %r/<head>/i, res.body
+    assert_includes @engine.metrics, 'External/all'
+    assert_includes @engine.metrics, 'External/www.google.com/Net::HTTP/GET'
+    assert_includes @engine.metrics, 'External/allOther'
+    assert_includes @engine.metrics, 'External/www.google.com/all'
+
+    assert_not_includes @engine.metrics, 'External/allWeb'
+  end
+
+  def test_background
+    res = nil
+
+    perform_action_with_newrelic_trace("task", :category => :task) do
       url = URI.parse('http://www.google.com/index.html')
       res = Net::HTTP.start(url.host, url.port) {|http|
         http.get('/index.html')
       }
-      assert_match /<head>/i, res.body
-      assert_equal %w[External/all External/www.google.com/Net::HTTP/GET External/allOther External/www.google.com/all].sort,
-      metrics_without_gc.sort
-    end
-
-    def test_background
-      perform_action_with_newrelic_trace("task", :category => :task) do
-        url = URI.parse('http://www.google.com/index.html')
-        res = Net::HTTP.start(url.host, url.port) {|http|
-          http.get('/index.html')
-        }
-        assert_match /<head>/i, res.body
-      end
-      assert_equal %w[External/all External/www.google.com/Net::HTTP/GET External/allOther External/www.google.com/all
-       External/www.google.com/Net::HTTP/GET:OtherTransaction/Background/NewRelic::Agent::Instrumentation::NetInstrumentationTest/task].sort, metrics_without_gc.select{|m| m =~ /^External/}.sort
     end
 
-    def test_transactional
-      perform_action_with_newrelic_trace("task") do
-        url = URI.parse('http://www.google.com/index.html')
-        res = Net::HTTP.start(url.host, url.port) {|http|
-          http.get('/index.html')
-        }
-        assert_match /<head>/i, res.body
-      end
-      assert_equal %w[External/all External/www.google.com/Net::HTTP/GET External/allWeb External/www.google.com/all
-       External/www.google.com/Net::HTTP/GET:Controller/NewRelic::Agent::Instrumentation::NetInstrumentationTest/task].sort, metrics_without_gc.select{|m| m =~ /^External/}.sort
-    end
-    def test_get__simple
-      Net::HTTP.get URI.parse('http://www.google.com/index.html')
-      assert_equal metrics_without_gc.sort,
-      %w[External/all External/www.google.com/Net::HTTP/GET External/allOther External/www.google.com/all].sort
-    end
-    def test_ignore
-      NewRelic::Agent.disable_all_tracing do
-        url = URI.parse('http://www.google.com/index.html')
-        res = Net::HTTP.start(url.host, url.port) {|http|
-          http.post('/index.html','data')
-        }
-      end
-      assert_equal 0, metrics_without_gc.size
-    end
-    def test_head
+    assert_match %r/<head>/i, res.body
+
+    assert_includes @engine.metrics, 'External/all'
+    assert_includes @engine.metrics, 'External/www.google.com/Net::HTTP/GET'
+    assert_includes @engine.metrics, 'External/allOther'
+    assert_includes @engine.metrics, 'External/www.google.com/all'
+    assert_includes @engine.metrics,
+      'OtherTransaction/Background/NewRelic::Agent::Instrumentation::NetInstrumentationTest/task'
+
+    assert_not_includes @engine.metrics, 'External/allWeb'
+  end
+
+  def test_transactional
+    res = nil
+
+    perform_action_with_newrelic_trace("task") do
       url = URI.parse('http://www.google.com/index.html')
       res = Net::HTTP.start(url.host, url.port) {|http|
-        http.head('/index.html')
+        http.get('/index.html')
       }
-      assert_equal %w[External/all External/www.google.com/Net::HTTP/HEAD External/allOther External/www.google.com/all].sort,
-      metrics_without_gc.sort
     end
 
-    def test_post
+    assert_match %r/<head>/i, res.body
+
+    assert_includes @engine.metrics, 'External/all'
+    assert_includes @engine.metrics, 'External/www.google.com/Net::HTTP/GET'
+    assert_includes @engine.metrics, 'External/allWeb'
+    assert_includes @engine.metrics, 'External/www.google.com/all'
+    assert_includes @engine.metrics,
+      'Controller/NewRelic::Agent::Instrumentation::NetInstrumentationTest/task'
+
+    assert_not_includes @engine.metrics, 'External/allOther'
+  end
+
+  def test_get__simple
+    Net::HTTP.get URI.parse('http://www.google.com/index.html')
+
+    assert_includes @engine.metrics, 'External/all'
+    assert_includes @engine.metrics, 'External/www.google.com/Net::HTTP/GET'
+    assert_includes @engine.metrics, 'External/allOther'
+    assert_includes @engine.metrics, 'External/www.google.com/all'
+
+    assert_not_includes @engine.metrics, 'External/allWeb'
+  end
+
+  def test_ignore
+    NewRelic::Agent.disable_all_tracing do
       url = URI.parse('http://www.google.com/index.html')
       res = Net::HTTP.start(url.host, url.port) {|http|
         http.post('/index.html','data')
       }
-      assert_equal %w[External/all External/www.google.com/Net::HTTP/POST External/allOther External/www.google.com/all].sort,
-      metrics_without_gc.sort
     end
 
+    assert_not_includes @engine.metrics, 'External/all'
+    assert_not_includes @engine.metrics, 'External/www.google.com/Net::HTTP/GET'
+    assert_not_includes @engine.metrics, 'External/allOther'
+    assert_not_includes @engine.metrics, 'External/www.google.com/all'
+
+    assert_not_includes @engine.metrics, 'External/allWeb'
+  end
+    
+  def test_head
+    url = URI.parse('http://www.google.com/index.html')
+    res = Net::HTTP.start(url.host, url.port) {|http|
+      http.head('/index.html')
+    }
+
+    assert_includes @engine.metrics, 'External/all'
+    assert_includes @engine.metrics, 'External/www.google.com/Net::HTTP/HEAD'
+    assert_includes @engine.metrics, 'External/allOther'
+    assert_includes @engine.metrics, 'External/www.google.com/all'
+
+    assert_not_includes @engine.metrics, 'External/allWeb'
+  end
+
+  def test_post
+    url = URI.parse('http://www.google.com/index.html')
+    res = Net::HTTP.start(url.host, url.port) {|http|
+      http.post('/index.html','data')
+    }
+
+    assert_includes @engine.metrics, 'External/all'
+    assert_includes @engine.metrics, 'External/www.google.com/Net::HTTP/POST'
+    assert_includes @engine.metrics, 'External/allOther'
+    assert_includes @engine.metrics, 'External/www.google.com/all'
+
+    assert_not_includes @engine.metrics, 'External/allWeb'
   end
+
+  # When an http call is made, the agent should add a request header named
+  # X-NewRelic-ID with a value equal to the encoded cross_app_id.
+
+  def test_adds_a_request_header_to_outgoing_requests_if_xp_enabled
+    @socket.check_write do |data|
+      assert_match /(?i:x-newrelic-id): VURQV1BZRkZdXUFT/, data
+    end
+
+    with_config(:"cross_application_tracer.enabled" => true) do
+      Net::HTTP.get URI.parse('http://www.google.com/index.html')
+    end
+  end
+
+  def test_adds_a_request_header_to_outgoing_requests_if_old_xp_config_is_present
+    @socket.check_write do |data|
+      assert_match /(?i:x-newrelic-id): VURQV1BZRkZdXUFT/, data
+    end
+
+    with_config(:cross_application_tracing => true) do
+      Net::HTTP.get URI.parse('http://www.google.com/index.html')
+    end
+  end
+
+  def test_agent_doesnt_add_a_request_header_to_outgoing_requests_if_xp_disabled
+    @socket.check_write do |data|
+      assert_no_match /(?i:x-newrelic-id): VURQV1BZRkZdXUFT/, data
+    end
+
+    Net::HTTP.get URI.parse('http://www.google.com/index.html')
+  end
+
+
+  def test_instrumentation_with_crossapp_enabled_records_normal_metrics_if_no_header_present
+    with_config(:"cross_application_tracer.enabled" => true) do
+      Net::HTTP.get URI.parse('http://www.google.com/index.html')
+    end
+
+    assert_equal 5, @engine.metrics.length
+
+    assert_includes @engine.metrics, 'External/all'
+    assert_includes @engine.metrics, 'External/allOther'
+    assert_includes @engine.metrics, 'External/www.google.com/Net::HTTP/GET'
+    assert_includes @engine.metrics, 'External/www.google.com/all'
+    assert_includes @engine.metrics, 'External/www.google.com/Net::HTTP/GET:test'
+
+    assert_not_includes @engine.metrics, 'ExternalApp/www.google.com/18#1884/all'
+    assert_not_includes @engine.metrics, 'ExternalTransaction/www.google.com/18#1884/txn-name'
+    assert_not_includes @engine.metrics, 'External/allWeb'
+  end
+
+
+  def test_instrumentation_with_crossapp_disabled_records_normal_metrics_even_if_header_is_present
+    @response[ NR_APPDATA_HEADER ] = 
+      make_app_data_payload( '18#1884', 'txn-name', 2, 8, 0, TRANSACTION_GUID )
+
+    Net::HTTP.get URI.parse('http://www.google.com/index.html')
+
+    assert_equal 5, @engine.metrics.length
+
+    assert_includes @engine.metrics, 'External/all'
+    assert_includes @engine.metrics, 'External/allOther'
+    assert_includes @engine.metrics, 'External/www.google.com/Net::HTTP/GET'
+    assert_includes @engine.metrics, 'External/www.google.com/all'
+    assert_includes @engine.metrics, 'External/www.google.com/Net::HTTP/GET:test'
+
+    assert_not_includes @engine.metrics, 'ExternalApp/www.google.com/18#1884/all'
+    assert_not_includes @engine.metrics, 'ExternalTransaction/www.google.com/18#1884/txn-name'
+    assert_not_includes @engine.metrics, 'External/allWeb'
+  end
+
+
+  def test_instrumentation_with_crossapp_enabled_records_crossapp_metrics_if_header_present
+    @response[ NR_APPDATA_HEADER ] = 
+      make_app_data_payload( '18#1884', 'txn-name', 2, 8, 0, TRANSACTION_GUID )
+
+    with_config(:"cross_application_tracer.enabled" => true) do
+      Net::HTTP.get URI.parse('http://www.google.com/index.html')
+    end
+
+    assert_equal 6, @engine.metrics.length
+
+    assert_includes @engine.metrics, 'External/all'
+    assert_includes @engine.metrics, 'External/allOther'
+    assert_includes @engine.metrics, 'ExternalApp/www.google.com/18#1884/all'
+    assert_includes @engine.metrics, 'ExternalTransaction/www.google.com/18#1884/txn-name'
+    assert_includes @engine.metrics, 'External/www.google.com/all'
+    assert_includes @engine.metrics, 'ExternalTransaction/www.google.com/18#1884/txn-name:test'
+
+    assert_not_includes @engine.metrics, 'External/www.google.com/Net::HTTP/GET'
+    assert_not_includes @engine.metrics, 'External/allWeb'
+
+    last_segment = find_last_segment()
+
+    assert_includes last_segment.params.keys, :transaction_guid
+    assert_equal TRANSACTION_GUID, last_segment.params[:transaction_guid]
+  end
+
+  def test_crossapp_metrics_allow_valid_utf8_characters
+    @response[ NR_APPDATA_HEADER ] = 
+      make_app_data_payload( '12#1114', '世界線航跡蔵', 18.0, 88.1, 4096, TRANSACTION_GUID )
+
+    with_config(:"cross_application_tracer.enabled" => true) do
+      Net::HTTP.get URI.parse('http://www.google.com/index.html')
+    end
+
+    assert_equal 6, @engine.metrics.length
+
+    assert_includes @engine.metrics, 'External/all'
+    assert_includes @engine.metrics, 'External/allOther'
+    assert_includes @engine.metrics, 'ExternalApp/www.google.com/12#1114/all'
+    assert_includes @engine.metrics, 'ExternalTransaction/www.google.com/12#1114/世界線航跡蔵'
+    assert_includes @engine.metrics, 'External/www.google.com/all'
+    assert_includes @engine.metrics, 'ExternalTransaction/www.google.com/12#1114/世界線航跡蔵:test'
+
+    assert_not_includes @engine.metrics, 'External/www.google.com/Net::HTTP/GET'
+    assert_not_includes @engine.metrics, 'External/allWeb'
+
+    last_segment = find_last_segment()
+
+    assert_includes last_segment.params.keys, :transaction_guid
+    assert_equal TRANSACTION_GUID, last_segment.params[:transaction_guid]
+  end
+
+  def test_crossapp_metrics_ignores_crossapp_header_with_malformed_crossprocess_id
+    @response[ NR_APPDATA_HEADER ] = 
+      make_app_data_payload( '88#88#88', 'invalid', 1, 2, 4096, TRANSACTION_GUID )
+
+    with_config(:"cross_application_tracer.enabled" => true) do
+      Net::HTTP.get URI.parse('http://www.google.com/index.html')
+    end
+
+    assert_equal 5, @engine.metrics.length
+
+    assert_includes @engine.metrics, 'External/all'
+    assert_includes @engine.metrics, 'External/allOther'
+    assert_includes @engine.metrics, 'External/www.google.com/Net::HTTP/GET'
+    assert_includes @engine.metrics, 'External/www.google.com/all'
+    assert_includes @engine.metrics, 'External/www.google.com/Net::HTTP/GET:test'
+
+    assert_not_includes @engine.metrics, 'ExternalApp/www.google.com/88#88#88/all'
+    assert_not_includes @engine.metrics, 'ExternalTransaction/www.google.com/88#88#88/invalid'
+    assert_not_includes @engine.metrics, 'External/allWeb'
+  end
+
+  def test_doesnt_affect_the_request_if_an_exception_is_raised_while_setting_up_tracing
+    res = nil
+    NewRelic::Agent.instance.stats_engine.stubs( :push_scope ).
+      raises( NoMethodError, "undefined method `push_scope'" )
+
+    with_config(:"cross_application_tracer.enabled" => true) do
+      assert_nothing_raised do
+        res = Net::HTTP.get URI.parse('http://www.google.com/index.html')
+      end
+    end
+
+    assert_equal res, CANNED_RESPONSE.instance_variable_get( :@body )
+  end
+
+  def test_doesnt_affect_the_request_if_an_exception_is_raised_while_finishing_tracing
+    res = nil
+    NewRelic::Agent.instance.stats_engine.stubs( :pop_scope ).
+      raises( NoMethodError, "undefined method `pop_scope'" )
+
+    with_config(:"cross_application_tracer.enabled" => true) do
+      assert_nothing_raised do
+        res = Net::HTTP.get URI.parse('http://www.google.com/index.html')
+      end
+    end
+
+    assert_equal res, CANNED_RESPONSE.instance_variable_get( :@body )
+  end
+
 end