RubyGems - newrelic_rpm - Versions diffs - 3.5.2.17 → 3.5.3.24 - Mend

newrelic_rpm 3.5.2.17 → 3.5.3.24

Potentially problematic release.

This version of newrelic_rpm might be problematic. Click here for more details.

Files changed (134) hide show

data/test/multiverse/suites/rails_3_queue_time/queue_time_test.rb ADDED

@@ -0,0 +1,75 @@
+# https://newrelic.atlassian.net/browse/RUBY-927
+ENV['NEW_RELIC_DISPATCHER'] = 'test'
+require 'action_controller/railtie'
+require 'rails/test_unit/railtie'
+require 'rails/test_help'
+require 'test/unit'
+# BEGIN RAILS APP
+class MyApp < Rails::Application
+  # We need a secret token for session, cookies, etc.
+  config.active_support.deprecation = :log
+  config.secret_token = "49837489qkuweoiuoqwehisuakshdjksadhaisdy78o34y138974xyqp9rmye8yrpiokeuioqwzyoiuxftoyqiuxrhm3iou1hrzmjk"
+end
+MyApp.initialize!
+MyApp.routes.draw do
+  match '/:controller(/:action(/:id))'
+end
+class ApplicationController < ActionController::Base; end
+class TestController < ApplicationController
+  include Rails.application.routes.url_helpers
+  def queued
+    respond_to do |format|
+      format.html { render :text => "<html><head></head><body>Queued</body></html>" }
+    end
+  end
+end
+# END RAILS APP
+class QueueTimeTest < ActionDispatch::IntegrationTest
+  def setup
+    NewRelic::Agent.config.apply_config({
+      :beacon => "beacon",
+      :browser_key => "key"})
+    @agent = NewRelic::Agent::Agent.new
+    NewRelic::Agent::Agent.instance_variable_set(:@instance, @agent)
+    NewRelic::Agent.manual_start
+    @agent.finish_setup({})
+  end
+  def teardown
+    NewRelic::Agent::Agent.instance.shutdown if NewRelic::Agent::Agent.instance
+  end
+  def test_should_track_queue_time_metric
+    get_queued
+    stat = @agent.stats_engine.lookup_stats('WebFrontend/QueueTime')
+    assert_equal 1, stat.call_count
+    assert stat.total_call_time > 0, "Should track some queue time"
+  end
+  def test_should_see_queue_time_in_rum
+    get_queued
+    assert extract_queue_time_from_response > 0, "Queue time was missing or zero"
+  end
+  def get_queued(header="HTTP_X_QUEUE_START")
+    get('/test/queued', nil, \
+        header => "t=#{(Time.now.to_i * 1_000_000) - 1_000}")
+  end
+  def extract_queue_time_from_response
+    @response.body =~ /key\",,\".*\",(\d+.*),\d+,new Date/
+    $1.to_i
+  end
+end

data/test/multiverse/suites/rails_3_views/.gitignore ADDED

@@ -0,0 +1,3 @@
+*.swp
+log/
+Gemfile.lock

data/test/multiverse/suites/rails_3_views/Envfile ADDED

@@ -0,0 +1,16 @@
+suite_condition("Rails 3 not compatible with 1.8.6") do
+  RUBY_VERSION != '1.8.6'
+end
+gemfile <<-RB
+  gem 'rails', '~>3.2.0'
+  gem 'haml'
+RB
+gemfile <<-RB
+  gem 'rails', '~>3.1.0'
+  gem 'haml'
+RB
+gemfile <<-RB
+  gem 'rails', '~>3.0.0'
+  gem 'haml'
+RB

data/test/multiverse/suites/rails_3_views/app/views/foos/_foo.html.haml ADDED

	@@ -0,0 +1 @@
1	+ = foo.inspect

data/test/multiverse/suites/rails_3_views/app/views/test/_a_partial.html.erb ADDED

	@@ -0,0 +1 @@
1	+ This is a partial

data/test/multiverse/suites/rails_3_views/app/views/test/_mid_partial.html.erb ADDED

	@@ -0,0 +1 @@
1	+ <%= render 'a_partial' %>

data/test/multiverse/suites/rails_3_views/app/views/test/_top_partial.html.erb ADDED

@@ -0,0 +1,3 @@
+<% (1..10).each do |i| %>
+  <%= render 'mid_partial', :i => i %>
+<% end %>

data/test/multiverse/suites/rails_3_views/app/views/test/deep_partial.html.erb ADDED

@@ -0,0 +1,3 @@
+<%- 10.times do |i| %>
+  <%= render 'top_partial' %>
+<%- end %>

data/test/multiverse/suites/rails_3_views/app/views/test/haml_view.html.haml ADDED

@@ -0,0 +1,6 @@
+!!!
+%html
+  %head
+    %title Hello
+  %body
+    hello from haml

data/test/multiverse/suites/rails_3_views/app/views/test/index.html.erb ADDED

@@ -0,0 +1,4 @@
+<%- 3.times do |i| %>
+<%= render "a_partial" %>
+<%- end%>

data/test/multiverse/suites/rails_3_views/config/newrelic.yml ADDED

@@ -0,0 +1,164 @@
+#
+# This file configures the NewRelic RPM Agent, NewRelic RPM monitors Rails
+# applications with deep visibility and low overhead.  For more information,
+# visit www.newrelic.com.
+#
+#
+#
+# here are the settings that are common to all environments
+common: &default_settings
+  # ============================== LICENSE KEY ===============================
+  # You must specify the licence key associated with your New Relic account.
+  # This key binds your Agent's data to your account in the New Relic RPM service.
+  #license_key: 'bootstrap_newrelic_admin_license_key_000'
+  #host: localhost
+  #port: 3000
+  license_key: 'bd0e1d52adade840f7ca727d29a86249e89a6f1c'
+  host: localhost
+  # Agent Enabled
+  # Use this setting to force the agent to run or not run.
+  # Default is 'auto' which means the agent will install and run only if a
+  # valid dispatcher such as Mongrel is running.  This prevents it from running
+  # with Rake or the console.  Set to false to completely turn the agent off
+  # regardless of the other settings.  Valid values are true, false and auto.
+  # agent_enabled: auto
+  # Application Name
+  # Set this to be the name of your application as you'd like it show up in RPM.
+  # RPM will then auto-map instances of your application into a RPM "application"
+  # on your home dashboard page. This setting does not prevent you from manually
+  # defining applications.
+  app_name: Rails 3 view test ap
+  # When 'enabled' is turned on, the agent collects performance data by inserting lightweight
+  # tracers on key methods inside the rails framework and asynchronously aggregating
+  # and reporting this performance data to the NewRelic RPM service at newrelic.com.
+  enabled: false
+  # The newrelic agent generates its own log file to keep its logging information
+  # separate from that of your application.  Specify its log level here.
+  log_level: debug
+  # The newrelic agent communicates with the RPM service via http by default.
+  # If you want to communicate via https to increase security, then turn on
+  # SSL by setting this value to true.  Note, this will result in increased
+  # CPU overhead to perform the encryption involved in SSL communication, but this
+  # work is done asynchronously to the threads that process your application code, so
+  # it should not impact response times.
+  ssl: false
+  # Set your application's Apdex threshold value with the 'apdex_t' setting, in seconds. The
+  # apdex_t value determines the buckets used to compute your overall Apdex score. Requests
+  # that take less than apdex_t seconds to process will be classified as Satisfying transactions;
+  # more than apdex_t seconds as Tolerating transactions; and more than four times the apdex_t
+  # value as Frustrating transactions. For more
+  # about the Apdex standard, see http://support.newrelic.com/faqs/general/apdex
+  apdex_t: 1.0
+  # Proxy settings for connecting to the RPM server.
+  #
+  # If a proxy is used, the host setting is required.  Other settings are optional.  Default
+  # port is 8080.
+  #
+  # proxy_host: hostname
+  # proxy_port: 8080
+  # proxy_user:
+  # proxy_pass:
+  # Tells transaction tracer and error collector (when enabled) whether or not to capture HTTP params.
+  # When true, the RoR filter_parameter_logging mechanism is used so that sensitive parameters are not recorded
+  capture_params: false
+  # Transaction tracer captures deep information about slow
+  # transactions and sends this to the RPM service once a minute. Included in the
+  # transaction is the exact call sequence of the transactions including any SQL statements
+  # issued.
+  transaction_tracer:
+    # Transaction tracer is enabled by default. Set this to false to turn it off. This feature
+    # is only available at the Silver and above product levels.
+    enabled: true
+    # Threshold in seconds for when to collect a transaction trace. When the response time of
+    # a controller action exceeds this threshold, a transaction trace will be recorded and sent
+    # to RPM. Valid values are any float value, or (default) "apdex_f", which will use the
+    # threshold for an dissatisfying Apdex controller action - four times the Apdex T value.
+    transaction_threshold: apdex_f
+    # When transaction tracer is on, SQL statements can optionally be recorded. The recorder
+    # has three modes, "off" which sends no SQL, "raw" which sends the SQL statement in its
+    # original form, and "obfuscated", which strips out numeric and string literals
+    record_sql: obfuscated
+    # Threshold in seconds for when to collect stack trace for a SQL call. In other words,
+    # when SQL statements exceed this threshold, then capture and send to RPM the current
+    # stack trace. This is helpful for pinpointing where long SQL calls originate from
+    stack_trace_threshold: 0.500
+  # Error collector captures information about uncaught exceptions and sends them to RPM for
+  # viewing
+  error_collector:
+    # Error collector is enabled by default. Set this to false to turn it off. This feature
+    # is only available at the Silver and above product levels
+    enabled: true
+    # Tells error collector whether or not to capture a source snippet around the place of the
+    # error when errors are View related.
+    capture_source: true
+    # To stop specific errors from reporting to RPM, set this property to comma separated
+    # values
+    #
+    #ignore_errors: ActionController::RoutingError, ...
+  # (Advanced) Uncomment this to ensure the cpu and memory samplers won't run.  Useful when you
+  # are using the agent to monitor an external resource
+  # disable_samplers: true
+# override default settings based on your application's environment
+# NOTE if your application has other named environments, you should
+# provide newrelic conifguration settings for these enviromnents here.
+development:
+  <<: *default_settings
+  # turn off communication to RPM service in development mode.
+  # NOTE: for initial evaluation purposes, you may want to temporarily turn
+  # the agent on in development mode.
+  enabled: true
+  # When running in Developer Mode, the New Relic Agent will present
+  # performance information on the last 100 transactions you have
+  # executed since starting the mongrel.  to view this data, go to
+  # http://localhost:3000/newrelic
+  developer: true
+test:
+  <<: *default_settings
+  # it almost never makes sense to turn on the agent when running unit, functional or
+  # integration tests or the like.
+  enabled: true
+  log_level: debug
+# Turn on the agent in production for 24x7 monitoring.  NewRelic testing shows
+# an average performance impact of < 5 ms per transaction, you you can leave this on
+# all the time without incurring any user-visible performance degredation.
+production:
+  <<: *default_settings
+  enabled: true
+# many applications have a staging environment which behaves identically to production.
+# Support for that environment is provided here.  By default, the staging environment has
+# the agent turned on.
+staging:
+  <<: *default_settings
+  enabled: true
+  app_name: My Application (Staging)

data/test/multiverse/suites/rails_3_views/view_instrumentation_test.rb ADDED

@@ -0,0 +1,245 @@
+require "action_controller/railtie"
+require "rails/test_unit/railtie"
+require 'rails/test_help'
+require 'test/unit'
+# BEGIN RAILS APP
+ActionController::Base.view_paths = ['app/views']
+class MyApp < Rails::Application
+  # We need a secret token for session, cookies, etc.
+  config.active_support.deprecation = :log
+  config.secret_token = "49837489qkuweoiuoqwehisuakshdjksadhaisdy78o34y138974xyqp9rmye8yrpiokeuioqwzyoiuxftoyqiuxrhm3iou1hrzmjk"
+  config.after_initialize do
+    NewRelic::Agent.manual_start
+  end
+end
+MyApp.initialize!
+MyApp.routes.draw do
+  match '/:controller(/:action(/:id))'
+end
+class ApplicationController < ActionController::Base; end
+# a basic active model compliant model we can render
+class Foo
+  extend ActiveModel::Naming
+  def to_model
+    self
+  end
+  def valid?()      true end
+  def new_record?() true end
+  def destroyed?()  true end
+  def errors
+    obj = Object.new
+    def obj.[](key)         [] end
+    def obj.full_messages() [] end
+    obj
+  end
+end
+class TestController < ApplicationController
+  include Rails.application.routes.url_helpers
+  def template_render_with_3_partial_renders
+    render 'index'
+  end
+  def deep_partial_render
+    render 'deep_partial'
+  end
+  def text_render
+    render :text => "Yay"
+  end
+  def json_render
+    render :json => {"a" => "b"}
+  end
+  def xml_render
+    render :xml => {"a" => "b"}
+  end
+  def js_render
+    render :js => 'alert("this is js");'
+  end
+  def file_render
+    render :file => File.expand_path(__FILE__), :content_type => 'text/plain', :layout => false
+  end
+  def nothing_render
+    render :nothing => true
+  end
+  def inline_render
+    render :inline => "<% Time.now %><p><%= Time.now %></p>"
+  end
+  def haml_render
+    render 'haml_view'
+  end
+  def no_template
+    render []
+  end
+  def collection_render
+    render((1..3).map{|x| Foo.new })
+  end
+  # proc rendering isn't available in rails 3 but you can do nonsense like this
+  # and assign an enumerable object to the response body.
+  def proc_render
+    streamer = Class.new
+    def each
+      10_000.times do |i|
+        yield "This is line #{i}\n"
+      end
+    end
+    self.response_body = streamer.new
+  end
+  def raise_render
+    raise "this is an uncaught RuntimeError"
+  end
+end
+# END RAILS APP
+class TestControllerTest < ActionController::TestCase
+  tests TestController
+  def setup
+    @controller = TestController.new
+  end
+end
+# SANITY TESTS - Make sure nothing raises errors,
+# unless it's supposed to
+class SanityTest < TestControllerTest
+  # assert we can call any of these renders with no errors
+  # (except the one that does raise an error)
+  (TestController.action_methods - ["raise_render"]).each do |method|
+    test "should not raise errors on GET to #{method.inspect}" do
+      get method.dup
+    end
+    test "should not raise errors on POST to #{method.inspect}" do
+      post method.dup
+    end
+  end
+  test "should allow an uncaught exception to propogate" do
+    assert_raise RuntimeError do
+      get :raise_render
+    end
+  end
+end
+# A controller action that renders 1 template and the same partial 3 times
+class NormalishRenderTest < TestControllerTest
+  test "should count all the template and partial segments" do
+    get :template_render_with_3_partial_renders
+    sample = NewRelic::Agent.agent.transaction_sampler.samples.last
+    assert_equal 5, sample.count_segments, "should be a node for the controller action, the template, and 3 partials (5)"
+  end
+  test "should have 3 segments with the metric name 'View/test/_a_partial.html.erb/Partial'" do
+    get :template_render_with_3_partial_renders
+    sample = NewRelic::Agent.agent.transaction_sampler.samples.last
+    partial_segments = sample.root_segment.called_segments.first.called_segments.first.called_segments
+    assert_equal 3, partial_segments.size, "sanity check"
+    assert_equal ['View/test/_a_partial.html.erb/Partial'], partial_segments.map(&:metric_name).uniq
+  end
+end
+class TextRenderTest < TestControllerTest
+  # it doesn't seem worth it to get consistent behavior here.
+  if Rails::VERSION::MINOR.to_i == 0
+    test "should not instrument rendering of text" do
+      get :text_render
+      sample = NewRelic::Agent.agent.transaction_sampler.samples.last
+      assert_equal [], sample.root_segment.called_segments.first.called_segments
+    end
+  else
+    test "should create a metric for the rendered text" do
+      get :text_render
+      sample = NewRelic::Agent.agent.transaction_sampler.samples.last
+      text_segment = sample.root_segment.called_segments.first.called_segments.first
+      assert_equal 'View/text template/Rendering', text_segment.metric_name
+    end
+  end
+end
+class InlineTemplateRenderTest < TestControllerTest
+  test "should create a metric for the rendered inline template" do
+    get :inline_render
+    sample = NewRelic::Agent.agent.transaction_sampler.samples.last
+    text_segment = sample.root_segment.called_segments.first.called_segments.first
+    assert_equal 'View/inline template/Rendering', text_segment.metric_name
+  end
+end
+class HamlRenderTest < TestControllerTest
+  test "should create a metric for the rendered haml template" do
+    get :haml_render
+    sample = NewRelic::Agent.agent.transaction_sampler.samples.last
+    text_segment = sample.root_segment.called_segments.first.called_segments.first
+    assert_equal 'View/test/haml_view.html.haml/Rendering', text_segment.metric_name
+  end
+end
+class MissingTemplateTest < TestControllerTest
+  # Rails 3.0 has different behavior for rendering an empty array.  We're okay with this.
+  if Rails::VERSION::MINOR.to_i == 0
+    test "should create an proper metric when the template is unknown" do
+      get :no_template
+      sample = NewRelic::Agent.agent.transaction_sampler.samples.last
+      text_segment = sample.root_segment.called_segments.first.called_segments.first
+      assert_nil text_segment
+    end
+  else
+    test "should create an proper metric when the template is unknown" do
+      get :no_template
+      sample = NewRelic::Agent.agent.transaction_sampler.samples.last
+      text_segment = sample.root_segment.called_segments.first.called_segments.first
+      assert_equal 'View/(unknown)/Partial', text_segment.metric_name
+    end
+  end
+end
+class CollectionTemplateTest < TestControllerTest
+  test "should create a proper metric when we render a collection" do
+    get :collection_render
+    sample = NewRelic::Agent.agent.transaction_sampler.samples.last
+    text_segment = sample.root_segment.called_segments.first.called_segments.first
+    assert_equal "View/foos/_foo.html.haml/Partial", text_segment.metric_name
+  end
+end
+class UninstrumentedRendersTest < TestControllerTest
+  [:js_render, :xml_render, :proc_render, :json_render ].each do |action|
+    test "should not instrument rendering of #{action.inspect}" do
+      get action
+      sample = NewRelic::Agent.agent.transaction_sampler.samples.last
+      assert_equal [], sample.root_segment.called_segments.first.called_segments
+    end
+  end
+end
+class FileRenderTest < TestControllerTest
+  test "should create a metric for rendered file that does not include the filename so it doesn't metric explode" do
+    get :file_render
+    sample = NewRelic::Agent.agent.transaction_sampler.samples.last
+    text_segment = sample.root_segment.called_segments.first.called_segments.first
+    assert_equal 'View/file/Rendering', text_segment.metric_name
+  end
+end