newrelic_rpm 3.16.0.318 → 3.16.1.320

data/test/new_relic/agent/transaction/abstract_segment_test.rb

@@ -0,0 +1,94 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
+
+require 'new_relic/agent/transaction'
+require 'new_relic/agent/transaction/abstract_segment'
+
+module NewRelic
+  module Agent
+    class Transaction
+      class AbstractSegmentTest < Minitest::Test
+        class BasicSegment < AbstractSegment
+          def record_metrics
+            metric_cache.record_scoped_and_unscoped name, duration, exclusive_duration
+            metric_cache.record_unscoped "Basic/all", duration, exclusive_duration
+          end
+        end
+
+        def setup
+          freeze_time
+        end
+
+        def teardown
+          NewRelic::Agent.drop_buffered_data
+        end
+
+        def test_segment_is_nameable
+          segment = BasicSegment.new  "Custom/basic/segment"
+          assert_equal "Custom/basic/segment", segment.name
+        end
+
+        def test_segment_tracks_timing_information
+          segment = BasicSegment.new "Custom/basic/segment"
+          segment.start
+          assert_equal Time.now, segment.start_time
+
+          advance_time 1.0
+          segment.finish
+
+          assert_equal Time.now, segment.end_time
+          assert_equal 1.0, segment.duration
+          assert_equal 1.0, segment.exclusive_duration
+        end
+
+        def test_segment_records_metrics
+          segment = BasicSegment.new "Custom/basic/segment"
+          segment.start
+          advance_time 1.0
+          segment.finish
+
+          assert_metrics_recorded ["Custom/basic/segment", "Basic/all"]
+        end
+
+        def test_segment_records_metrics_in_local_cache_if_part_of_transaction
+          segment = BasicSegment.new "Custom/basic/segment"
+          txn = in_transaction "test_transaction" do
+            segment.transaction = txn
+            segment.start
+            advance_time 1.0
+            segment.finish
+
+            refute_metrics_recorded ["Custom/basic/segment", "Basic/all"]
+          end
+
+          #local metrics will be merged into global store at the end of the transction
+          assert_metrics_recorded ["Custom/basic/segment", "Basic/all"]
+        end
+
+        # this preserves a strange case that is currently present in the agent where for some
+        # segments we would like to create a TT node for the segment, but not record
+        # metrics
+        def test_segments_will_not_record_metrics_when_turned_off
+          segment = BasicSegment.new "Custom/basic/segment"
+          segment.record_metrics = false
+          segment.start
+          advance_time 1.0
+          segment.finish
+
+          refute_metrics_recorded ["Custom/basic/segment", "Basic/all"]
+        end
+
+        def test_segment_complete_callback_executes_when_segment_finished
+          segment = BasicSegment.new "Custom/basic/segment"
+          segment.expects(:segment_complete)
+          segment.start
+          advance_time 1.0
+          segment.finish
+        end
+      end
+    end
+  end
+end

data/test/new_relic/agent/transaction/datastore_segment_test.rb

@@ -0,0 +1,99 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
+
+require 'new_relic/agent/transaction/datastore_segment'
+
+module NewRelic
+  module Agent
+    class Transaction
+      class DatastoreSegmentTest < Minitest::Test
+        def setup
+          freeze_time
+        end
+
+        def teardown
+          NewRelic::Agent.drop_buffered_data
+        end
+
+        def test_datastore_segment_name_with_collection
+          segment = DatastoreSegment.new "SQLite", "insert", "Blog"
+          assert_equal "Datastore/statement/SQLite/Blog/insert", segment.name
+        end
+
+        def test_datastore_segment_name_with_operation
+          segment = DatastoreSegment.new "SQLite", "select"
+          assert_equal "Datastore/operation/SQLite/select", segment.name
+        end
+
+        def test_segment_records_expected_metrics
+          Transaction.stubs(:recording_web_transaction?).returns(true)
+
+          segment = DatastoreSegment.new "SQLite", "insert", "Blog"
+          segment.start
+          advance_time 1
+          segment.finish
+
+          assert_metrics_recorded [
+            "Datastore/statement/SQLite/Blog/insert",
+            "Datastore/operation/SQLite/insert",
+            "Datastore/SQLite/allWeb",
+            "Datastore/SQLite/all",
+            "Datastore/allWeb",
+            "Datastore/all"
+          ]
+        end
+
+        def test_segment_records_expected_metrics_without_collection
+          Transaction.stubs(:recording_web_transaction?).returns(true)
+
+          segment = DatastoreSegment.new "SQLite", "select"
+          segment.start
+          advance_time 1
+          segment.finish
+
+          assert_metrics_recorded [
+            "Datastore/operation/SQLite/select",
+            "Datastore/SQLite/allWeb",
+            "Datastore/SQLite/all",
+            "Datastore/allWeb",
+            "Datastore/all"
+          ]
+        end
+
+        def test_notice_sql
+          in_transaction do
+            segment = NewRelic::Agent::Transaction.start_datastore_segment "SQLite", "select"
+            segment.notice_sql "select * from blogs"
+            advance_time 2.0
+            Agent.instance.transaction_sampler.expects(:notice_sql_statement).with(segment.sql_statement, 2.0)
+            Agent.instance.sql_sampler.expects(:notice_sql_statement) do |statement, name, duration|
+              assert_equal segment.sql_statement.sql, statement.sql_statement
+              assert_equal segment.name, name
+              assert_equal duration, 2.0
+            end
+            segment.finish
+          end
+        end
+
+        def test_internal_notice_sql
+          explainer = stub(:explainer)
+          in_transaction do
+            segment = NewRelic::Agent::Transaction.start_datastore_segment "SQLite", "select"
+            segment._notice_sql "select * from blogs", {:adapter => :sqlite}, explainer
+            advance_time 2.0
+            Agent.instance.transaction_sampler.expects(:notice_sql_statement).with(segment.sql_statement, 2.0)
+            Agent.instance.sql_sampler.expects(:notice_sql_statement) do |statement, name, duration|
+              assert_equal segment.sql_statement.sql, statement.sql_statement
+              assert_equal segment.name, name
+              assert_equal duration, 2.0
+            end
+            segment.finish
+          end
+        end
+      end
+    end
+  end
+end

data/test/new_relic/agent/transaction/segment_test.rb

@@ -0,0 +1,53 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
+
+require 'new_relic/agent/transaction/segment'
+
+module NewRelic
+  module Agent
+    class Transaction
+      class SegmentTest < Minitest::Test
+        def setup
+          freeze_time
+        end
+
+        def teardown
+          NewRelic::Agent.drop_buffered_data
+        end
+
+        def test_assigns_unscoped_metrics
+          segment = Segment.new  "Custom/simple/segment", "Segment/all"
+          assert_equal "Custom/simple/segment", segment.name
+          assert_equal "Segment/all", segment.unscoped_metrics
+        end
+
+        def test_assigns_unscoped_metrics_as_array
+          segment = Segment.new  "Custom/simple/segment", ["Segment/all", "Other/all"]
+          assert_equal "Custom/simple/segment", segment.name
+          assert_equal ["Segment/all", "Other/all"], segment.unscoped_metrics
+        end
+
+        def test_segment_records_metrics
+          segment = Segment.new  "Custom/simple/segment", "Segment/all"
+          segment.start
+          advance_time 1.0
+          segment.finish
+
+          assert_metrics_recorded ["Custom/simple/segment", "Segment/all"]
+        end
+
+        def test_segment_records_metrics_when_given_as_array
+          segment = Segment.new  "Custom/simple/segment", ["Segment/all", "Other/all"]
+          segment.start
+          advance_time 1.0
+          segment.finish
+
+          assert_metrics_recorded ["Custom/simple/segment", "Segment/all", "Other/all"]
+        end
+      end
+    end
+  end
+end

data/test/new_relic/agent/transaction/tracing_test.rb

@@ -0,0 +1,121 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+require File.expand_path(File.join(File.dirname(__FILE__),'..','..','..','test_helper'))
+
+require 'new_relic/agent/transaction'
+
+module NewRelic
+  module Agent
+    class Transaction
+      class TracingTest < Minitest::Test
+        def setup
+          freeze_time
+        end
+
+        def teardown
+          NewRelic::Agent.drop_buffered_data
+        end
+
+        def test_segment_without_transaction_records_metrics
+          segment = Transaction.start_segment  "Custom/simple/segment", "Segment/all"
+          segment.start
+          advance_time 1.0
+          segment.finish
+
+          assert_metrics_recorded ["Custom/simple/segment", "Segment/all"]
+        end
+
+        def test_segment_bound_to_transaction_records_metrics
+          in_transaction "test_txn" do
+            segment = Transaction.start_segment  "Custom/simple/segment", "Segment/all"
+            segment.start
+            advance_time 1.0
+            segment.finish
+
+            refute_metrics_recorded ["Custom/simple/segment", "Segment/all"]
+          end
+
+          assert_metrics_recorded ["Custom/simple/segment", "Segment/all"]
+        end
+
+        def test_segment_bound_to_transaction_invokes_complete_callback_when_finished
+          in_transaction "test_txn" do |txn|
+            segment = Transaction.start_segment  "Custom/simple/segment", "Segment/all"
+            txn.expects(:segment_complete).with(segment)
+            segment.start
+            advance_time 1.0
+            segment.finish
+          end
+        end
+
+        def test_segment_data_is_copied_to_trace
+          segment = nil
+          segment_name = "Custom/simple/segment"
+          in_transaction "test_txn" do
+            segment = Transaction.start_segment  segment_name, "Segment/all"
+            segment.start
+            advance_time 1.0
+            segment.finish
+          end
+
+          trace = last_transaction_trace
+          node = find_node_with_name(trace, segment_name)
+
+          refute_nil node, "Expected trace to have node with name: #{segment_name}"
+          assert_equal segment.duration, node.duration
+        end
+
+        def test_start_segment
+          in_transaction "test_txn" do |txn|
+            segment = Transaction.start_segment "Custom/segment/method"
+            assert_equal Time.now, segment.start_time
+            assert_equal txn, segment.transaction
+
+            advance_time 1
+            segment.finish
+            assert_equal Time.now, segment.end_time
+          end
+        end
+
+        def test_start_datastore_segment
+          in_transaction "test_txn" do |txn|
+            segment = Transaction.start_datastore_segment "SQLite", "insert", "Blog"
+            assert_equal Time.now, segment.start_time
+            assert_equal txn, segment.transaction
+
+            advance_time 1
+            segment.finish
+            assert_equal Time.now, segment.end_time
+          end
+        end
+
+        def test_start_segment_with_tracing_disabled_in_transaction
+          segment = nil
+          in_transaction "test_txn" do |txn|
+            NewRelic::Agent.disable_all_tracing do
+              segment = Transaction.start_segment "Custom/segment/method", "Custom/all"
+              advance_time 1
+              segment.finish
+            end
+          end
+          assert_nil segment.transaction, "Did not expect segment to associated with a transaction"
+          refute_metrics_recorded ["Custom/segment/method", "Custom/all"]
+        end
+
+        def test_start_segment_with_tracing_disabled_outside_transaction
+          segment = nil
+          NewRelic::Agent.disable_all_tracing do
+            segment = Transaction.start_segment "Custom/segment/method", "Custom/all"
+            advance_time 1
+            segment.finish
+          end
+          assert_nil segment.transaction, "Did not expect segment to associated with a transaction"
+          refute_metrics_recorded ["Custom/segment/method", "Custom/all"]
+        end
+      end
+    end
+  end
+end
+

data/test/new_relic/agent/transaction_sampler_test.rb

@@ -202,6 +202,19 @@ class NewRelic::Agent::TransactionSamplerTest < Minitest::Test
     @sampler.notice_sql('some sql', {:config => 'a config'}, 1.0, @state)
   end
 
+  def test_notice_sql_statment_recording_sql
+    @state.record_sql = true
+    builder = @sampler.tl_builder
+    @sampler.expects(:notice_extra_data).with do |sample_builder, message, duration, key|
+      sample_builder == builder &&
+      message.sql == 'some sql' &&
+      duration == 1.0 &&
+      key == :sql
+    end
+    statement = NewRelic::Agent::Database::Statement.new 'some sql', {:config => 'a config'}
+    @sampler.notice_sql_statement(statement, 1.0)
+  end
+
   def test_notice_nosql
     builder = @sampler.tl_builder
     @sampler.expects(:notice_extra_data).with(builder, 'a key', 1.0, :key)

data/test/new_relic/noticed_error_test.rb

@@ -173,6 +173,13 @@ class NewRelic::Agent::NoticedErrorTest < Minitest::Test
     end
   end
 
+  def test_handles_exception_with_nil_cause
+    e = Exception.new('Buffy FOREVER')
+    e.stubs(:cause).returns(nil)
+    error = NewRelic::NoticedError.new(@path, e, @time)
+    assert_equal(error.message.to_s, 'Buffy FOREVER')
+  end
+
   def test_handles_exception_with_nil_original_exception
     e = Exception.new('Buffy FOREVER')
     e.stubs(:original_exception).returns(nil)

data/test/performance/suites/datastores.rb

@@ -0,0 +1,59 @@
+# encoding: utf-8
+# This file is distributed under New Relic's license terms.
+# See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
+
+class DatastoresPerfTest < Performance::TestCase
+  class FauxDB
+    def self.query
+      "foo"
+    end
+  end
+
+  def test_instrumentation_via_trace
+    db_class = Class.new do
+      def query
+        "foo"
+      end
+    end
+
+    NewRelic::Agent::Datastores.trace(db_class, "query", "FakeDB")
+    db = db_class.new
+
+    measure do
+      in_transaction do
+        db.query
+      end
+    end
+  end
+
+  def test_wrap
+    product = "FauxDB".freeze
+    operation = "query".freeze
+    collection = "collection".freeze
+
+    measure do
+      in_transaction do
+        NewRelic::Agent::Datastores.wrap product, operation, collection do
+          FauxDB.query
+        end
+      end
+    end
+  end
+
+  SQL = "select * from users".freeze
+  METRIC_NAME = "Datastore/statement/MySQL/users/select".freeze
+
+  def test_notice_sql
+    measure do
+      NewRelic::Agent::Datastores.notice_sql(SQL, METRIC_NAME, 3.0)
+    end
+  end
+
+  def test_segment_notice_sql
+    segment = NewRelic::Agent::Transaction::DatastoreSegment.new "MySQL", "select", "users"
+    conf = {:adapter => :mysql}
+    measure do
+      segment._notice_sql SQL, conf
+    end
+  end
+end