newrelic_rpm 3.10.0.279 → 3.11.0.283

data/test/multiverse/suites/agent_only/labels_test.rb

@@ -2,9 +2,7 @@
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
 
-require File.join(File.dirname(__FILE__), '..', '..', '..', 'agent_helper')
 require 'fake_collector'
-require 'multiverse_helpers'
 
 class LabelsTest < Minitest::Test
   include MultiverseHelpers

data/test/multiverse/suites/agent_only/logging_test.rb

@@ -9,7 +9,6 @@
 require 'logger'
 require 'newrelic_rpm'
 require 'fake_collector'
-require 'multiverse_helpers'
 
 class LoggingTest < Minitest::Test
 

data/test/multiverse/suites/agent_only/marshaling_test.rb

@@ -5,7 +5,6 @@
 # https://newrelic.atlassian.net/wiki/display/eng/The+Terror+and+Glory+of+Transaction+Traces
 # https://newrelic.atlassian.net/browse/RUBY-914
 require 'ostruct'
-require 'multiverse_helpers'
 
 class MarshalingTest < Minitest::Test
   include MultiverseHelpers

data/test/multiverse/suites/agent_only/pipe_manager_test.rb

@@ -4,8 +4,6 @@
 
 # https://newrelic.atlassian.net/browse/RUBY-669
 
-require 'multiverse_helpers'
-
 class PipeManagerTest < Minitest::Test
   include MultiverseHelpers
 

data/test/multiverse/suites/agent_only/rename_rule_test.rb

@@ -2,8 +2,6 @@
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
 
-require 'multiverse_helpers'
-
 class RenameRuleTest < Minitest::Test
 
   include MultiverseHelpers
@@ -41,12 +39,12 @@ class RenameRuleTest < Minitest::Test
   def test_transaction_names_rules
     TestWidget.new.txn
 
-    metric_names = NewRelic::Agent.instance.stats_engine.metrics
-
-    assert_includes(metric_names, 'Controller/Class::TestWidget/txn')
-    assert_includes(metric_names, 'Apdex/Class::TestWidget/txn')
+    assert_metrics_recorded([
+      'Controller/Class::TestWidget/txn',
+      'Apdex/Class::TestWidget/txn'
+    ])
 
-    assert_not_includes(metric_names, 'Controller/RenameRuleTest::TestWidget/txn')
+    refute_metrics_recorded('Controller/RenameRuleTest::TestWidget/txn')
   end
 
   def test_metric_name_rules

data/test/multiverse/suites/agent_only/rum_instrumentation_test.rb

@@ -5,7 +5,6 @@
 require 'rack/test'
 require 'new_relic/rack/browser_monitoring'
 require './testing_app'
-require 'multiverse_helpers'
 
 class RumAutoTest < Minitest::Test
 

data/test/multiverse/suites/agent_only/set_transaction_name_test.rb

@@ -2,8 +2,6 @@
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
 
-require 'multiverse_helpers'
-
 class SetTransactionNameTest < Minitest::Test
   include NewRelic::Agent::MethodTracer
 

data/test/multiverse/suites/agent_only/ssl_test.rb

@@ -2,8 +2,6 @@
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
 
-require 'multiverse_helpers'
-
 class SSLTest < Minitest::Test
 
   include MultiverseHelpers

data/test/multiverse/suites/agent_only/synthetics_test.rb

@@ -3,7 +3,6 @@
 # See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
 
 require 'rack/test'
-require 'multiverse_helpers'
 require 'new_relic/rack/agent_hooks'
 require './testing_app'
 

data/test/multiverse/suites/agent_only/testing_app.rb

@@ -30,4 +30,25 @@ class TestingApp
     sleep(params['sleep'].to_f) if params['sleep']
     [200, headers, [response]]
   end
+
+end
+
+class TestingBackgroundJob
+  FIRST_NAME = "OtherTransaction/Custom/TestingBackgroundJob/first"
+  SECOND_NAME = "OtherTransaction/Custom/TestingBackgroundJob/second"
+
+  def first(awhile=nil)
+    job(FIRST_NAME, awhile)
+  end
+
+  def second(awhile=nil)
+    job(SECOND_NAME, awhile)
+  end
+
+  def job(name, awhile)
+    state = ::NewRelic::Agent::TransactionState.tl_get
+    ::NewRelic::Agent::Transaction.wrap(state, name, :other) do
+      sleep(awhile) if awhile
+    end
+  end
 end

data/test/multiverse/suites/agent_only/thread_profiling_test.rb

@@ -8,7 +8,6 @@
 if RUBY_VERSION >= '1.9'
 
 require 'thread'
-require 'multiverse_helpers'
 
 class ThreadProfilingTest < Minitest::Test
 
@@ -131,7 +130,7 @@ class ThreadProfilingTest < Minitest::Test
   end
 
   def let_it_finish
-    wait_for_backtrace_service_poll(:timeout => 10.0, :iterations => 10)
+    wait_for_backtrace_service_poll(:timeout => 10.0, :iterations => 1)
     harvest
     join_background_threads
   end

data/test/multiverse/suites/agent_only/transaction_ignoring_test.rb

@@ -2,8 +2,6 @@
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
 
-require File.join(File.dirname(__FILE__), '..', '..', '..', 'agent_helper')
-require 'multiverse_helpers'
 require 'transaction_ignoring_test_cases'
 
 class TransactionIgnoringTest < Minitest::Test

data/test/multiverse/suites/agent_only/utilization_data_collection_test.rb

@@ -3,7 +3,6 @@
 # See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
 
 require 'newrelic_rpm'
-require 'multiverse_helpers'
 require 'fake_instance_metadata_service'
 
 class UtilizationDataCollectionTest < Minitest::Test

data/test/multiverse/suites/agent_only/xray_sessions_test.rb

@@ -8,7 +8,6 @@
 if RUBY_VERSION >= '1.9'
 
 require 'rack/test'
-require 'multiverse_helpers'
 require './testing_app'
 
 class XraySessionsTest < Minitest::Test
@@ -35,16 +34,9 @@ class XraySessionsTest < Minitest::Test
     session = build_xray_session('key_transaction_name' => 'Controller/Rack/A')
     with_xray_sessions(session) do
       5.times { get '/?transaction_name=A' }
-      trigger_harvest
     end
 
-    posts = $collector.calls_for('transaction_sample_data')
-    assert_equal(1, posts.size, "Expected exactly one transaction_sample_data post")
-
-    traces = posts.first.samples
-    assert_equal(5, traces.size)
-    assert traces.all? { |t| t.metric_name == 'Controller/Rack/A' }
-    assert traces.all? { |t| t.xray_id == session['x_ray_id'] }
+    assert_traced_transactions('Controller/Rack/A' => [5, session])
   end
 
   def test_does_not_collect_traces_for_non_xrayed_transactions
@@ -52,14 +44,10 @@ class XraySessionsTest < Minitest::Test
     with_xray_sessions(session) do
       get '/?transaction_name=OtherThing'
       get '/?transaction_name=A'
-      trigger_harvest
     end
 
-    posts = $collector.calls_for('transaction_sample_data')
-    assert_equal(1, posts.size, "Expected exactly one transaction_sample_data post")
-
     # We expect exactly one transaction trace, for A only
-    assert_equal(1, posts.first.samples.size)
+    assert_traced_transactions('Controller/Rack/A' => [1, session])
   end
 
   def test_gathers_transaction_traces_from_multiple_concurrent_xray_sessions
@@ -71,19 +59,10 @@ class XraySessionsTest < Minitest::Test
         get '/?transaction_name=A'
         get '/?transaction_name=B'
       end
-      trigger_harvest
     end
 
-    posts = $collector.calls_for('transaction_sample_data')
-    assert_equal(1, posts.size, "Expected exactly one transaction_sample_data post")
-
-    traces = posts.first.samples
-    assert_equal(4, traces.size)
-
-    tracesA = traces.select { |t| t.metric_name == 'Controller/Rack/A' }
-    tracesB = traces.select { |t| t.metric_name == 'Controller/Rack/B' }
-    assert_equal(2, tracesA.size, "Expected 2 traces for transaction A")
-    assert_equal(2, tracesB.size, "Expected 2 traces for transaction B")
+    assert_traced_transactions('Controller/Rack/A' => [2, sessionA],
+                               'Controller/Rack/B' => [2, sessionB])
   end
 
   def test_gathers_thread_profiles
@@ -91,16 +70,42 @@ class XraySessionsTest < Minitest::Test
     with_xray_sessions(session) do
       wait_for_backtrace_service_poll
       get '/?transaction_name=A&sleep=1'
-      trigger_harvest
     end
 
-    # assert that a thread profile was submitted
-    posts = $collector.calls_for('profile_data')
-    assert_equal(1, posts.size, "Expected exactly one profile_data post")
+    assert_profile_submitted('REQUEST')
+  end
+
+  def test_tags_background_transaction_traces_with_xray_id
+    session = build_xray_session('key_transaction_name' => TestingBackgroundJob::FIRST_NAME)
+    with_xray_sessions(session) do
+      5.times { TestingBackgroundJob.new.first }
+    end
+
+    assert_traced_transactions(TestingBackgroundJob::FIRST_NAME => [5, session])
+  end
+
+
+  def test_tags_background_transaction_traces_concurrently
+    session1 = build_xray_session('key_transaction_name' => TestingBackgroundJob::FIRST_NAME)
+    session2 = build_xray_session('key_transaction_name' => TestingBackgroundJob::SECOND_NAME)
+
+    with_xray_sessions(session1, session2) do
+      2.times { TestingBackgroundJob.new.first }
+      2.times { TestingBackgroundJob.new.second }
+    end
+
+    assert_traced_transactions(TestingBackgroundJob::FIRST_NAME  => [2, session1],
+                               TestingBackgroundJob::SECOND_NAME => [2, session2])
+  end
+
+  def test_gathers_thread_profiles_for_background
+    session = build_xray_session('key_transaction_name' => TestingBackgroundJob::FIRST_NAME)
+    with_xray_sessions(session) do
+      wait_for_backtrace_service_poll
+      TestingBackgroundJob.new.first(1)
+    end
 
-    profile_data_post = posts.first
-    assert(profile_data_post.sample_count > 1, "Expected at least one sample")
-    assert_saw_traces(profile_data_post, 'REQUEST')
+    assert_profile_submitted('BACKGROUND')
   end
 
   ## Helpers
@@ -143,6 +148,8 @@ class XraySessionsTest < Minitest::Test
 
     yield
 
+    agent.send(:transmit_data)
+
     deactivate_cmd = build_active_xrays_command([])
     issue_command(deactivate_cmd)
   end
@@ -152,13 +159,41 @@ class XraySessionsTest < Minitest::Test
     agent.send(:check_for_and_handle_agent_commands)
   end
 
-  def trigger_harvest
-    agent.send(:transmit_data)
+  def single_transaction_sample_post
+    posts = $collector.calls_for('transaction_sample_data')
+    assert_equal(1, posts.size, "Expected exactly one transaction_sample_data post")
+
+    posts.first
+  end
+
+  def single_profile_post
+    posts = $collector.calls_for('profile_data')
+    assert_equal(1, posts.size, "Expected exactly one profile_data post")
+    posts.first
   end
 
   def assert_saw_traces(profile_data, type)
     assert !profile_data.traces[type].empty?, "Missing #{type} traces"
   end
 
+  def assert_profile_submitted(type)
+    assert(single_profile_post.sample_count > 1, "Expected at least one sample")
+    assert_saw_traces(single_profile_post, type)
+  end
+
+  def assert_traced_transactions(txns)
+    traces = single_transaction_sample_post.samples
+
+    total_count = txns.inject(0) { |prior, (_, (count, *_))| prior + count }
+
+    assert_equal(total_count, traces.size)
+
+    txns.each do |name, (count, session)|
+      check_traces = traces.select { |t| t.metric_name == name }
+      assert_equal(count, check_traces.size, "Transaction #{name}")
+      assert check_traces.all? { |t| t.xray_id == session['x_ray_id'] }
+    end
+  end
+
 end
 end

data/test/multiverse/suites/capistrano/deployment_test.rb

@@ -3,7 +3,6 @@
 # See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
 
 require 'fake_rpm_site'
-require 'multiverse_helpers'
 require 'new_relic/cli/command'
 
 class DeploymentTest < Minitest::Test

data/test/multiverse/suites/capistrano2/deployment_test.rb

@@ -3,7 +3,6 @@
 # See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
 
 require 'fake_rpm_site'
-require 'multiverse_helpers'
 
 class DeploymentTest < Minitest::Test
   def setup

data/test/multiverse/suites/config_file_loading/config_file_loading_test.rb

@@ -14,8 +14,6 @@
 # If this fails the agent will attempt to dial Lew Cirne's cell phone and ask
 # that he verbally describe how it should be configured.
 
-require 'multiverse_helpers'
-
 class ConfigFileLoadingTest < Minitest::Test
   include MultiverseHelpers
 

data/test/multiverse/suites/curb/curb_test.rb

@@ -8,8 +8,6 @@ require 'newrelic_rpm'
 require 'http_client_test_cases'
 require 'new_relic/agent/http_clients/curb_wrappers'
 
-require File.join(File.dirname(__FILE__), "..", "..", "..", "agent_helper")
-
 class CurbTest < Minitest::Test
 
   #

data/test/multiverse/suites/datamapper/Envfile

@@ -1,7 +1,30 @@
-omit_collector!
+adapter_gems = <<-RB
+  gem 'dm-sqlite-adapter'
+
+  # Pin this version as the adapter breaks with later ones
+  gem 'jdbc-sqlite3', '~> 3.7.2.1', :platforms => [:jruby]
+
+  # Needed for the fake collector
+  gem 'rack'
+RB
 
 gemfile <<-RB
   gem 'json', '>= 1.8.1'
-  gem 'datamapper'
-  gem 'dm-sqlite-adapter'
+  gem 'datamapper', '~> 1.2.0', :require => 'data_mapper'
+  gem 'dm-ar-finders', '~> 1.2.0'
+  #{adapter_gems}
+RB
+
+if RUBY_VERSION < '2.0.0'
+gemfile <<-RB
+  gem 'datamapper', '~> 1.1.0'
+  gem 'dm-ar-finders', '~> 1.1.0'
+  #{adapter_gems}
+RB
+
+gemfile <<-RB
+  gem 'datamapper', '~> 1.0.2'
+  gem 'dm-ar-finders', '~> 1.0.2'
+  #{adapter_gems}
 RB
+end

data/test/multiverse/suites/datamapper/config/newrelic.yml

@@ -10,6 +10,7 @@ development:
   app_name: test
   host: 127.0.0.1
   api_host: 127.0.0.1
+  port: <%= $collector && $collector.port %>
   transaction_tracer:
     record_sql: obfuscated
     enabled: true

data/test/multiverse/suites/datamapper/datamapper_test.rb

@@ -2,11 +2,6 @@
 # This file is distributed under New Relic's license terms.
 # See https://github.com/newrelic/rpm/blob/master/LICENSE for complete details.
 
-require 'data_mapper'
-
-require File.join(File.dirname(__FILE__), '..', '..', '..', 'agent_helper')
-require 'multiverse_helpers'
-
 DataMapper::Logger.new("/dev/null", :debug)
 DataMapper.setup(:default, 'sqlite::memory:')
 class Post
@@ -32,55 +27,272 @@ class DataMapperTest < Minitest::Test
 
   setup_and_teardown_agent
 
-  def test_basic_metrics
-    post = Post.create(:title => "Dummy post", :body => "whatever, man")
-    post = Post.get(post.id)
-    post.update(:title => 'other title')
-    post.destroy
+  def test_create
+    # DM 1.0 generates a create method on inclusion of a module that internally
+    # calls the instance #save method, so that's all we see on that version.
+    expected_metric = DataMapper::VERSION < "1.1" ? :save : :create
+    assert_basic_metrics(expected_metric) do
+      Post.create(:title => "Dummy post", :body => "whatever, man")
+    end
+  end
+
+  def test_create!
+    assert_basic_metrics(:create) do
+      Post.create!(:title => "Dummy post", :body => "whatever, man")
+    end
+  end
+
+  def test_get
+    assert_against_record(:get) do |post|
+      Post.get(post.id)
+    end
+  end
+
+  def test_get!
+    assert_against_record(:get) do |post|
+      Post.get!(post.id)
+    end
+  end
+
+  def test_first
+    assert_against_record(:first) do
+      Post.first
+    end
+  end
+
+  def test_all
+    assert_against_record(:all) do
+      Post.all
+    end
+  end
+
+  def test_last
+    assert_against_record(:last) do
+      Post.last
+    end
+  end
+
+  def test_bulk_update
+    assert_against_record(:update) do
+      Post.update(:title => 'other title')
+    end
+  end
+
+  def test_bulk_update!
+    assert_against_record(:update) do
+      Post.update!(:title => 'other title')
+    end
+  end
+
+  def test_instance_update
+    assert_against_record(:update) do |post|
+      post.update(:title => 'other title')
+    end
+  end
+
+  def test_bulk_update!
+    assert_against_record(:update) do |post|
+      post.update!(:title => 'other title')
+    end
+  end
+
+  def test_bulk_destroy
+    assert_against_record(:destroy) do
+      Post.destroy
+    end
+  end
+
+  def test_bulk_destroy!
+    assert_against_record(:destroy) do
+      Post.destroy!
+    end
+  end
+
+  def test_instance_destroy
+    assert_against_record(:destroy) do |post|
+      post.destroy
+    end
+  end
+
+  def test_instance_destroy!
+    assert_against_record(:destroy) do |post|
+      post.destroy!
+    end
+  end
+
+  def test_save
+    assert_against_record(:save) do |post|
+      post.save
+    end
+  end
+
+  def test_save!
+    assert_against_record(:save) do |post|
+      post.save!
+    end
+  end
+
+  def test_aggregate
+    assert_against_record(:aggregate) do
+      Post.aggregate(:title, :all.count)
+    end
+  end
+
+  def test_find
+    assert_against_record(:find) do
+      Post.find(1)
+    end
+  end
+
+  def test_find_by_sql
+    assert_against_record(:find_by_sql) do
+      Post.find_by_sql('select * from posts')
+    end
+  end
+
+  def test_in_web_transaction
+    in_web_transaction("dm4evr") do
+      Post.all
+    end
+
+    assert_metrics_recorded([
+      'Datastore/all',
+      'Datastore/allWeb',
+      'Datastore/DataMapper/all',
+      'Datastore/DataMapper/allWeb',
+      'Datastore/operation/DataMapper/all',
+      'Datastore/statement/DataMapper/Post/all',
+      ['Datastore/statement/DataMapper/Post/all', 'dm4evr']
+    ])
+  end
+
+  def test_collection_get
+    assert_against_record(:get) do
+      Post.all.get(1)
+    end
+  end
+
+  def test_collection_first
+    assert_against_record(:first) do
+      Post.all.first
+    end
+  end
+
+  def test_collection_last
+    assert_against_record(:last) do
+      Post.all.last
+    end
+  end
+
+  def test_collection_all
+    assert_against_record(:all) do
+      Post.all.all # sic
+    end
+
     assert_metrics_recorded(
-      'ActiveRecord/Post/save' => { :call_count => 2 },
-      'ActiveRecord/Post/get'  => { :call_count => 1 },
-      'ActiveRecord/Post/update'  => { :call_count => 1 },
-      'ActiveRecord/Post/destroy' => { :call_count => 1 }
+      'Datastore/statement/DataMapper/Post/all' => { :call_count => 2 }
     )
   end
 
-  def test_rollup_metrics_for_create
-    post = Post.create(:title => 'foo', :body => 'bar')
-    post.save
-    assert_metrics_recorded(['ActiveRecord/save'])
+  def test_collection_lazy_load
+    assert_against_record(:lazy_load) do
+      Post.all.send(:lazy_load)
+    end
+  end
+
+  def test_collection_create
+    assert_against_record(:create) do
+      Post.all.create(:title => "The Title", :body => "Body")
+    end
+  end
+
+  def test_collection_create!
+    assert_against_record(:create) do
+      Post.all.create!(:title => "The Title", :body => "Body")
+    end
+  end
+
+  def test_collection_update
+    assert_against_record(:update) do
+      Post.all.update(:title => "Another")
+    end
+  end
+
+  def test_collection_update!
+    assert_against_record(:update) do
+      Post.all.update!(:title => "Another")
+    end
+  end
+
+  def test_collection_destroy
+    assert_against_record(:destroy) do
+      Post.all.destroy
+    end
   end
 
-  def test_rollup_metrics_for_update
-    post = Post.create(:title => 'foo', :body => 'bar')
-    post.body = 'baz'
-    post.save
-    assert_metrics_recorded('ActiveRecord/save' => { :call_count => 2 })
+  def test_collection_destroy!
+    assert_against_record(:destroy) do
+      Post.all.destroy!
+    end
   end
 
-  def test_rollup_metrics_for_destroy
-    post = Post.create(:title => 'foo', :body => 'bar')
-    post.save
-    post.destroy
-    assert_metrics_recorded(['ActiveRecord/destroy'])
+  def test_collection_aggregate
+    assert_against_record(:aggregate) do
+      Post.all.aggregate(:title, :all.count)
+    end
   end
 
-  def test_rollup_metrics_should_include_all_if_in_web_transaction
+  def test_notices_sql
     in_web_transaction do
-      Post.create(:title => 'foo', :body => 'bar').save
+      Post.get(42)
+    end
+
+    sql_segment = find_last_transaction_segment(last_transaction_trace)
+    refute_nil sql_segment.obfuscated_sql
+  end
+
+  def test_direct_select_on_adapter
+    in_web_transaction('dm4evr') do
+      DataMapper.repository.adapter.select('select * from posts limit 1')
+    end
+
+    assert_metrics_recorded([
+      'Datastore/all',
+      'Datastore/allWeb',
+      'Datastore/DataMapper/all',
+      'Datastore/DataMapper/allWeb',
+      'Datastore/operation/DataMapper/select',
+      ['Datastore/operation/DataMapper/select', 'dm4evr'],
+    ])
+  end
+
+  def test_direct_execute_on_adapter
+    in_transaction('background') do
+      DataMapper.repository.adapter.execute('update posts set title=title')
     end
+
     assert_metrics_recorded([
-      'ActiveRecord/save',
-      'ActiveRecord/all'
+      'Datastore/all',
+      'Datastore/allOther',
+      'Datastore/DataMapper/all',
+      'Datastore/DataMapper/allOther',
+      'Datastore/operation/DataMapper/execute',
+      ['Datastore/operation/DataMapper/execute', 'background'],
     ])
   end
 
-  def test_rollup_metrics_should_omit_all_if_not_in_web_transaction
-    in_transaction do
-      Post.create(:title => 'foo', :body => 'bar').save
+  def test_datamapper_transaction_commit
+    Post.transaction do |t|
+      Post.destroy!
     end
-    assert_metrics_recorded(['ActiveRecord/save'])
-    assert_metrics_not_recorded(['ActiveRecord/all'])
+
+    assert_metrics_recorded([
+      'Datastore/all',
+      'Datastore/allOther',
+      'Datastore/DataMapper/all',
+      'Datastore/DataMapper/allOther',
+      'Datastore/operation/DataMapper/commit'
+    ])
   end
 
   # https://support.newrelic.com/tickets/2101
@@ -98,4 +310,26 @@ class DataMapperTest < Minitest::Test
     assert_equal false, msg.query.valid_encoding? if RUBY_VERSION >= '1.9'
     db.send(:log, msg)
   end
+
+  def assert_against_record(operation)
+    post = Post.create!(:title => "Dummy post", :body => "whatever, man")
+
+    # Want to ignore our default record's creation for these tests
+    NewRelic::Agent.drop_buffered_data
+
+    assert_basic_metrics(operation) do
+      yield(post)
+    end
+  end
+
+  def assert_basic_metrics(operation)
+    yield
+    assert_metrics_recorded([
+      "Datastore/all",
+      "Datastore/allOther",
+      "Datastore/operation/DataMapper/#{operation}",
+      "Datastore/statement/DataMapper/Post/#{operation}"
+    ])
+  end
+
 end