newrelic_f5_plugin 1.0.12 → 1.0.15

data/lib/newrelic_f5_plugin/nodes.rb

@@ -8,7 +8,7 @@ module NewRelic
   module F5Plugin
 
     class Nodes
-      attr_accessor :vs_names, :snmp_manager
+      attr_accessor :snmp_manager
 
       NODE_MONITOR_STATES = {
         0  => 'unchecked',
@@ -40,6 +40,19 @@ module NewRelic
       end
 
 
+
+      #
+      # Perform polling and reportings of metrics
+      #
+      def poll(agent, snmp)
+        @snmp_manager = snmp
+
+        node_status = get_status
+        node_status.each_key { |m| agent.report_metric m, node_status[m][:label], node_status[m][:count] } unless node_status.nil?
+      end
+
+
+
       #
       # Node Naming in SNMP
       #

data/lib/newrelic_f5_plugin/pools.rb

@@ -40,8 +40,9 @@ module NewRelic
   module F5Plugin
 
     class Pools
-      attr_accessor :pool_names, :snmp_manager
+      attr_accessor :names, :snmp_manager
 
+      MAX_RESULTS                        = 150
       OID_LTM_POOLS                      = "1.3.6.1.4.1.3375.2.2.5"
       OID_LTM_POOL_STAT                  = "#{OID_LTM_POOLS}.2"
       OID_LTM_POOL_ENTRY                 = "#{OID_LTM_POOL_STAT}.3.1"
@@ -60,7 +61,8 @@ module NewRelic
       # Init
       #
       def initialize(snmp = nil)
-        @pool_names = [ ]
+        @names    = [ ]
+        @f5_agent = nil
 
         if snmp
           @snmp_manager = snmp
@@ -71,6 +73,26 @@ module NewRelic
 
 
 
+      #
+      # Perform polling and reportings of metrics
+      #
+      def poll(agent, snmp)
+        @snmp_manager = snmp
+        @f5_agent     = agent
+
+        unless get_names.empty?
+          get_requests
+          get_conns_current
+          get_conns_total
+          get_packets_in
+          get_packets_out
+          get_throughput_in
+          get_throughput_out
+        end
+      end
+
+
+
       #
       # Get the list of Pool names
       #
@@ -78,20 +100,20 @@ module NewRelic
         snmp = snmp_manager unless snmp
 
         if snmp
-          @pool_names.clear
+          @names.clear
 
           begin
             snmp.walk([OID_LTM_POOL_STAT_NAME]) do |row|
               row.each do |vb|
-                @pool_names.push(vb.value)
+                @names.push(vb.value)
               end
             end
           rescue Exception => e
             NewRelic::PlatformLogger.error("Unable to gather Pool names with error: #{e}")
           end
 
-          NewRelic::PlatformLogger.debug("Pools: Found #{@pool_names.size} pools")
-          return @pool_names
+          NewRelic::PlatformLogger.debug("Pools: Found #{@names.size} pools, reporting the top #{MAX_RESULTS} (max)")
+          return @names
         end
       end
 
@@ -101,12 +123,26 @@ module NewRelic
       # Gather Total Requests
       #
       def get_requests(snmp = nil)
+        @req_rate ||= { }
+        report      = { }
         snmp = snmp_manager unless snmp
 
-        get_names(snmp) if @pool_names.empty?
-        res = gather_snmp_metrics_by_name("Pools/Requests", @pool_names, OID_LTM_POOL_STAT_TOT_REQUESTS, snmp)
-        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@pool_names.size} Request metrics")
-        return res
+        get_names(snmp) if @names.empty?
+        res = gather_snmp_metrics_by_name("Pools/Requests", @names, OID_LTM_POOL_STAT_TOT_REQUESTS, snmp)
+        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@names.size} Request metrics")
+
+        unless res.nil?
+          res.each_key do |metric|
+            @req_rate[metric] ||= NewRelic::Processor::EpochCounter.new
+            report[metric] = @req_rate[metric].process(res[metric])
+          end
+
+          sorted_report = report.sort_by { |k,v| v }.reverse
+          sorted_report.each_with_index do |row, index|
+            @f5_agent.report_metric row[0], "req/sec", row[1]
+            break if index >= (MAX_RESULTS - 1)
+          end
+        end
       end
 
 
@@ -117,10 +153,17 @@ module NewRelic
       def get_conns_current(snmp = nil)
         snmp = snmp_manager unless snmp
 
-        get_names(snmp) if @pool_names.empty?
-        res = gather_snmp_metrics_by_name("Pools/Current Connections", @pool_names, OID_LTM_POOL_STAT_SERVER_CUR_CONNS, snmp)
-        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@pool_names.size} Current Connection metrics")
-        return res
+        get_names(snmp) if @names.empty?
+        res = gather_snmp_metrics_by_name("Pools/Current Connections", @names, OID_LTM_POOL_STAT_SERVER_CUR_CONNS, snmp)
+        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@names.size} Current Connection metrics")
+
+        unless res.nil?
+          sorted_report = res.sort_by { |k,v| v }.reverse
+          sorted_report.each_with_index do |row, index|
+            @f5_agent.report_metric row[0], "conns", row[1]
+            break if index >= (MAX_RESULTS - 1)
+          end
+        end
       end
 
 
@@ -129,12 +172,26 @@ module NewRelic
       # Gather Connection rate
       #
       def get_conns_total(snmp = nil)
+        @conn_rate ||= { }
+        report       = { }
         snmp = snmp_manager unless snmp
 
-        get_names(snmp) if @pool_names.empty?
-        res = gather_snmp_metrics_by_name("Pools/Connection Rate", @pool_names, OID_LTM_POOL_STAT_SERVER_TOT_CONNS, snmp)
-        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@pool_names.size} Connection Rate metrics")
-        return res
+        get_names(snmp) if @names.empty?
+        res = gather_snmp_metrics_by_name("Pools/Connection Rate", @names, OID_LTM_POOL_STAT_SERVER_TOT_CONNS, snmp)
+        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@names.size} Connection Rate metrics")
+
+        unless res.nil?
+          res.each_key do |metric|
+            @conn_rate[metric] ||= NewRelic::Processor::EpochCounter.new
+            report[metric] = @conn_rate[metric].process(res[metric])
+          end
+
+          sorted_report = report.sort_by { |k,v| v }.reverse
+          sorted_report.each_with_index do |row, index|
+            @f5_agent.report_metric row[0], "conn/sec", row[1]
+            break if index >= (MAX_RESULTS - 1)
+          end
+        end
       end
 
 
@@ -143,13 +200,26 @@ module NewRelic
       # Gather Packets Inbound
       #
       def get_packets_in(snmp = nil)
+        @packet_in_rate ||= { }
+        report            = { }
         snmp = snmp_manager unless snmp
 
-        get_names(snmp) if @pool_names.empty?
-        res = gather_snmp_metrics_by_name("Pools/Packets/In", @pool_names, OID_LTM_POOL_STAT_SERVER_PKTS_IN, snmp)
-        res = res.each_key { |n| res[n] *= 8 }
-        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@pool_names.size} Inbound Packet metrics")
-        return res
+        get_names(snmp) if @names.empty?
+        res = gather_snmp_metrics_by_name("Pools/Packets/In", @names, OID_LTM_POOL_STAT_SERVER_PKTS_IN, snmp)
+        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@names.size} Inbound Packet metrics")
+
+        unless res.nil?
+          res.each_key do |metric|
+            @packet_in_rate[metric] ||= NewRelic::Processor::EpochCounter.new
+            report[metric] = @packet_in_rate[metric].process(res[metric] * 8)
+          end
+
+          sorted_report = report.sort_by { |k,v| v }.reverse
+          sorted_report.each_with_index do |row, index|
+            @f5_agent.report_metric row[0], "packets/sec", row[1]
+            break if index >= (MAX_RESULTS - 1)
+          end
+        end
       end
 
 
@@ -158,13 +228,26 @@ module NewRelic
       # Gather Packets Outbound
       #
       def get_packets_out(snmp = nil)
+        @packet_out_rate ||= { }
+        report             = { }
         snmp = snmp_manager unless snmp
 
-        get_names(snmp) if @pool_names.empty?
-        res = gather_snmp_metrics_by_name("Pools/Packets/Out", @pool_names, OID_LTM_POOL_STAT_SERVER_PKTS_OUT, snmp)
-        res = res.each_key { |n| res[n] *= 8 }
-        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@pool_names.size} Outbound Packet metrics")
-        return res
+        get_names(snmp) if @names.empty?
+        res = gather_snmp_metrics_by_name("Pools/Packets/Out", @names, OID_LTM_POOL_STAT_SERVER_PKTS_OUT, snmp)
+        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@names.size} Outbound Packet metrics")
+
+        unless res.nil?
+          res.each_key do |metric|
+            @packet_out_rate[metric] ||= NewRelic::Processor::EpochCounter.new
+            report[metric] = @packet_out_rate[metric].process(res[metric] * 8)
+          end
+
+          sorted_report = report.sort_by { |k,v| v }.reverse
+          sorted_report.each_with_index do |row, index|
+            @f5_agent.report_metric row[0], "packets/sec", row[1]
+            break if index >= (MAX_RESULTS - 1)
+          end
+        end
       end
 
 
@@ -173,13 +256,26 @@ module NewRelic
       # Gather Throughput Inbound (returns in bits)
       #
       def get_throughput_in(snmp = nil)
+        @throughput_in_rate ||= { }
+        report                = { }
         snmp = snmp_manager unless snmp
 
-        get_names(snmp) if @pool_names.empty?
-        res = gather_snmp_metrics_by_name("Pools/Throughput/In", @pool_names, OID_LTM_POOL_STAT_SERVER_BYTES_IN, snmp)
-        res = res.each_key { |n| res[n] *= 8 }
-        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@pool_names.size} Inbound Throughput metrics")
-        return res
+        get_names(snmp) if @names.empty?
+        res = gather_snmp_metrics_by_name("Pools/Throughput/In", @names, OID_LTM_POOL_STAT_SERVER_BYTES_IN, snmp)
+        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@names.size} Inbound Throughput metrics")
+
+        unless res.nil?
+          res.each_key do |metric|
+            @throughput_in_rate[metric] ||= NewRelic::Processor::EpochCounter.new
+            report[metric] = @throughput_in_rate[metric].process(res[metric] * 8)
+          end
+
+          sorted_report = report.sort_by { |k,v| v }.reverse
+          sorted_report.each_with_index do |row, index|
+            @f5_agent.report_metric row[0], "bits/sec", row[1]
+            break if index >= (MAX_RESULTS - 1)
+          end
+        end
       end
 
 
@@ -188,13 +284,26 @@ module NewRelic
       # Gather Throughput Outbound (returns in bits)
       #
       def get_throughput_out(snmp = nil)
+        @throughput_out_rate ||= { }
+        report                 = { }
         snmp = snmp_manager unless snmp
 
-        get_names(snmp) if @pool_names.empty?
-        res = gather_snmp_metrics_by_name("Pools/Throughput/Out", @pool_names, OID_LTM_POOL_STAT_SERVER_BYTES_OUT, snmp)
-        res = res.each_key { |n| res[n] *= 8 }
-        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@pool_names.size} Outbound Throughput metrics")
-        return res
+        get_names(snmp) if @names.empty?
+        res = gather_snmp_metrics_by_name("Pools/Throughput/Out", @names, OID_LTM_POOL_STAT_SERVER_BYTES_OUT, snmp)
+        NewRelic::PlatformLogger.debug("Pools: Got #{res.size}/#{@names.size} Outbound Throughput metrics")
+
+        unless res.nil?
+          res.each_key do |metric|
+            @throughput_out_rate[metric] ||= NewRelic::Processor::EpochCounter.new
+            report[metric] = @throughput_out_rate[metric].process(res[metric] * 8)
+          end
+
+          sorted_report = report.sort_by { |k,v| v }.reverse
+          sorted_report.each_with_index do |row, index|
+            @f5_agent.report_metric row[0], "bits/sec", row[1]
+            break if index >= (MAX_RESULTS - 1)
+          end
+        end
       end
 
     end

data/lib/newrelic_f5_plugin/rules.rb

@@ -19,7 +19,7 @@ module NewRelic
   module F5Plugin
 
     class Rules
-      attr_accessor :rule_names, :snmp_manager
+      attr_accessor :names, :snmp_manager
 
       OID_LTM_RULES                 = "1.3.6.1.4.1.3375.2.2.8"
       OID_LTM_RULE_STAT             = "#{OID_LTM_RULES}.3"
@@ -37,7 +37,7 @@ module NewRelic
       # Init
       #
       def initialize(snmp = nil)
-        @rule_names = [ ]
+        @names = [ ]
 
         if snmp
           @snmp_manager = snmp
@@ -48,6 +48,28 @@ module NewRelic
 
 
 
+      #
+      # Perform polling and reportings of metrics
+      #
+      def poll(agent, snmp)
+        @snmp_manager = snmp
+
+        unless get_names.empty?
+          rule_execs = get_executions
+          rule_execs.each_key { |m| agent.report_counter_metric m, "execs/sec", rule_execs[m] } unless rule_execs.nil?
+
+          rule_failures = get_failures
+          rule_failures.each_key { |m| agent.report_counter_metric m, "failures/sec", rule_failures[m] } unless rule_failures.nil?
+
+          rule_aborts = get_aborts
+          rule_aborts.each_key { |m| agent.report_counter_metric m, "aborts/sec", rule_aborts[m] } unless rule_aborts.nil?
+
+          rule_cycles = get_average_cycles
+          rule_cycles.each_key { |m| agent.report_metric m, "cycles", rule_cycles[m] } unless rule_cycles.nil?
+        end
+      end
+
+
       #
       # Get the list of iRule names
       #
@@ -55,18 +77,18 @@ module NewRelic
         snmp = snmp_manager unless snmp
 
         if snmp
-          @rule_names.clear
+          @names.clear
 
           begin
             snmp.walk([OID_LTM_RULE_STAT_NAME, OID_LTM_RULE_STAT_TYPE]) do |rule, func|
-              @rule_names.push("#{rule.value}/#{func.value}")
+              @names.push("#{rule.value}/#{func.value}")
             end
           rescue Exception => e
             NewRelic::PlatformLogger.error("Unable to gather iRule names with error: #{e}")
           end
 
-          NewRelic::PlatformLogger.debug("Rules: Found #{@rule_names.size} iRules")
-          return @rule_names
+          NewRelic::PlatformLogger.debug("Rules: Found #{@names.size} iRules")
+          return @names
         end
       end
 
@@ -78,9 +100,9 @@ module NewRelic
       def get_executions(snmp = nil)
         snmp = snmp_manager unless snmp
 
-        get_names(snmp) if @rule_names.empty?
-        res = gather_snmp_metrics_by_name("Rules/Executions", @rule_names, OID_LTM_RULE_STAT_TOT_EXEC, snmp)
-        NewRelic::PlatformLogger.debug("Rules: Got #{res.size}/#{@rule_names.size} Execution metrics")
+        get_names(snmp) if @names.empty?
+        res = gather_snmp_metrics_by_name("Rules/Executions", @names, OID_LTM_RULE_STAT_TOT_EXEC, snmp)
+        NewRelic::PlatformLogger.debug("Rules: Got #{res.size}/#{@names.size} Execution metrics")
         return res
       end
 
@@ -92,9 +114,9 @@ module NewRelic
       def get_failures(snmp = nil)
         snmp = snmp_manager unless snmp
 
-        get_names(snmp) if @rule_names.empty?
-        res = gather_snmp_metrics_by_name("Rules/Failures", @rule_names, OID_LTM_RULE_STAT_FAILURES, snmp)
-        NewRelic::PlatformLogger.debug("Rules: Got #{res.size}/#{@rule_names.size} Failure metrics")
+        get_names(snmp) if @names.empty?
+        res = gather_snmp_metrics_by_name("Rules/Failures", @names, OID_LTM_RULE_STAT_FAILURES, snmp)
+        NewRelic::PlatformLogger.debug("Rules: Got #{res.size}/#{@names.size} Failure metrics")
         return res
       end
 
@@ -106,9 +128,9 @@ module NewRelic
       def get_aborts(snmp = nil)
         snmp = snmp_manager unless snmp
 
-        get_names(snmp) if @rule_names.empty?
-        res = gather_snmp_metrics_by_name("Rules/Aborts", @rule_names, OID_LTM_RULE_STAT_ABORTS, snmp)
-        NewRelic::PlatformLogger.debug("Rules: Got #{res.size}/#{@rule_names.size} Abort metrics")
+        get_names(snmp) if @names.empty?
+        res = gather_snmp_metrics_by_name("Rules/Aborts", @names, OID_LTM_RULE_STAT_ABORTS, snmp)
+        NewRelic::PlatformLogger.debug("Rules: Got #{res.size}/#{@names.size} Abort metrics")
         return res
       end
 
@@ -120,9 +142,9 @@ module NewRelic
       def get_average_cycles(snmp = nil)
         snmp = snmp_manager unless snmp
 
-        get_names(snmp) if @rule_names.empty?
-        res = gather_snmp_metrics_by_name("Rules/Time", @rule_names, OID_LTM_RULE_STAT_AVG_CYCLES, snmp)
-        NewRelic::PlatformLogger.debug("Rules: Got #{res.size}/#{@rule_names.size} Average Cycle metrics")
+        get_names(snmp) if @names.empty?
+        res = gather_snmp_metrics_by_name("Rules/Time", @names, OID_LTM_RULE_STAT_AVG_CYCLES, snmp)
+        NewRelic::PlatformLogger.debug("Rules: Got #{res.size}/#{@names.size} Average Cycle metrics")
         return res
       end
 

data/lib/newrelic_f5_plugin/snatpools.rb

@@ -52,6 +52,38 @@ module NewRelic
 
 
 
+      #
+      # Perform polling and reportings of metrics
+      #
+      def poll(agent, snmp)
+        @snmp_manager = snmp
+
+        unless get_names.empty?
+          snatpool_conns_max = get_conns_max
+          snatpool_conns_max.each_key { |m| agent.report_metric m, "conns", snatpool_conns_max[m] } unless snatpool_conns_max.nil?
+
+          snatpool_conns_current = get_conns_current
+          snatpool_conns_current.each_key { |m| agent.report_metric m, "conns", snatpool_conns_current[m] } unless snatpool_conns_current.nil?
+
+          snatpool_conns_total = get_conns_total
+          snatpool_conns_total.each_key { |m| agent.report_counter_metric m, "conn/sec", snatpool_conns_total[m] } unless snatpool_conns_total.nil?
+
+          snatpool_throughput_in = get_throughput_in
+          snatpool_throughput_in.each_key { |m| agent.report_counter_metric m, "bits/sec", snatpool_throughput_in[m] } unless snatpool_throughput_in.nil?
+
+          snatpool_throughput_out = get_throughput_out
+          snatpool_throughput_out.each_key { |m| agent.report_counter_metric m, "bits/sec", snatpool_throughput_out[m] } unless snatpool_throughput_out.nil?
+
+          snatpool_packets_in = get_packets_in
+          snatpool_packets_in.each_key { |m| agent.report_counter_metric m, "pkts/sec", snatpool_packets_in[m] } unless snatpool_packets_in.nil?
+
+          snatpool_packets_out = get_packets_out
+          snatpool_packets_out.each_key { |m| agent.report_counter_metric m, "pkts/sec", snatpool_packets_out[m] } unless snatpool_packets_out.nil?
+        end
+      end
+
+
+
       #
       # Get the list of Pool names
       #