newrelic-manticore 0.1.2-java → 1.1.0.rc1-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 384a5c873ddc6183ca9179c5b2060f408a3141666bef46a35f996bfc0349daff
-  data.tar.gz: c9a3a04cb32931f85253933438f0740a3c499717cdbd50b587127945041283e9
+  metadata.gz: 992e45039a34ef8e4e8168c83e951345e5a559d920ed680c7c6c0374089b8670
+  data.tar.gz: 5cc926e4df4c6722bc7aef5dcd599aab455e369921421630280e6b68e48b934a
 SHA512:
-  metadata.gz: de7ccebfc9d7c74c6074f3f661c3586cdadc419a0ca3901b4fe5ae5e896d5cc48759f8ec2ee46ace4833beb9be351aab18952d401e2a69940a3999f877a9c5fb
-  data.tar.gz: fdc1a23c186692fbabc731902f4e84444022d62d7a4da55f30b7183798c8613f72c1607185f12e5ba5720756ea33f23e21e9cc0bda26a0a014c5e6b5249cbc11
+  metadata.gz: 88325bcca1f71ad112af0be285426abc95298bcd1972155569b15e3f824a66be120e9725c8fffc2d1a22265808121ff4d1e8d2de92f71dfaed5234e362776bc3
+  data.tar.gz: fe8ce0b4badf517d3127a28cdbc3d305da41b1cd13e45d95967b0b97a16f24bf77ca2349b5a3287ae0e720ea68d542bc60a9a067e24169b16cdafa91c8c8774f

data/.rubocop.yml

@@ -1,7 +1,7 @@
 require: rt_rubocop_defaults
 
 AllCops:
-  TargetRubyVersion: 2.2
+  TargetRubyVersion: 2.4
 
 Metrics/BlockLength:
   Exclude:
@@ -10,3 +10,6 @@ Metrics/BlockLength:
 Metrics/ClassLength:
   Exclude:
     - test/**/*
+
+Gemspec/RequiredRubyVersion:
+  Enabled: false

data/.travis.yml

@@ -1,6 +1,5 @@
 language: ruby
 rvm:
-  - jruby-9.1.17.0 # ruby 2.3
   - jruby-9.2.0.0 # ruby 2.5
 jobs:
   include:

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,69 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to making participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, sex characteristics, gender identity and expression,
+level of experience, education, socio-economic status, nationality, personal
+appearance, race, religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment
+include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or
+  advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community. Examples of
+representing a project or community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
+
+## Enforcement
+
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
+available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
+
+[homepage]: https://www.contributor-covenant.org
+
+For answers to common questions about this code of conduct, see
+https://www.contributor-covenant.org/faq

data/Changelog.md

@@ -4,6 +4,25 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+### Added
+- Record response status on external request span
+
+### Changed
+- Require ruby > 2.0.0
+
+### Fixed
+- Added manticore as dependency
+
+## [1.0.1] - 2020-04-30
+### Added
+- Compatibility with agent versions ~> 6.10
+
+## [1.0.0] - 2019-03-12
+### Changed
+- Update newrelic agent dependency to major version 6.
+- Replace deprecated calls to internal agent API.
+
 ## [0.1.2] - 2018-10-11
 ### Fixed
 Detection whether manticore is used inside a database segment was not reliable and is now more robust

data/README.md

@@ -1,33 +1,54 @@
-[travis]: https://travis-ci.org/runtastic/newrelic-manticore
-[rubygems]: https://rubygems.org/gems/newrelic-manticore
-[manticore]: https://gitlab.com/cheald/manticore
-[mit]: http://opensource.org/licenses/MIT
-[cc]: http://contributor-covenant.org
-
-# NewrelicManticore
+# Newrelic-Manticore
 
-[![Build Status](https://travis-ci.org/runtastic/newrelic-manticore.svg?branch=master)][travis] [![Gem Version](https://badge.fury.io/rb/newrelic-manticore.svg)][rubygems]
+[![Build Status](https://travis-ci.org/runtastic/newrelic-manticore.svg?branch=master)][travis]
+[![Gem Version](https://badge.fury.io/rb/newrelic-manticore.svg)][rubygems]
 
 Adds NewRelic instrumentation for the [Manticore JRuby HTTP client][manticore].
 
 ## Installation
 Add this line to your application's Gemfile:
 
-`$ gem 'newrelic-manticore'`
+```ruby
+gem 'newrelic-manticore'
+```
 
 And then execute:
 
-`$ bundle`
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install newrelic-manticore
+
+## Usage
 
-## How it works
 When `newrelic/manticore` is required (e.g. automatically by Bundler), the gem becomes active.
-It hooks itself into `Manticore::Client#request` and traces your HTTP calls as external requests,
+It wraps `Manticore::Response#call` and traces your HTTP calls as external requests,
 adding also the necessary headers for cross application tracing.
 
+### What about parallel requests?
+The NewRelic agent is currently not set up to support multithreaded requests. As [any of the other client integrations](https://docs.newrelic.com/docs/agents/ruby-agent/features/http-client-tracing-ruby#typhoeus),
+_newrelic-manticore_ will trace all parallel requests as [one external service call](https://github.com/runtastic/newrelic-manticore/blob/master/test/new_relic/manticore/instrumentation_test.rb#L50).
+
+### What about async "background" requests?
+Those are traced normally as any other request would be.
+
+## Development
+
+After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+
+To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+
 ## Contributing
 Bug reports and pull requests are welcome on GitHub at https://github.com/runtastic/newrelic-manticore.
-This project is intended to be a safe, welcoming space for collaboration, and contributors are expected
-to adhere to the [Contributor Covenant code of conduct][cc].
+This project is intended to be a safe, welcoming space for collaboration, and
+contributors are expected to adhere to the [code of conduct][cc].
 
 ## License
 The gem is available as open source under [the terms of the MIT License][mit].
+
+[travis]: https://travis-ci.org/runtastic/newrelic-manticore
+[rubygems]: https://rubygems.org/gems/newrelic-manticore
+[manticore]: https://gitlab.com/cheald/manticore
+[mit]: http://opensource.org/licenses/MIT
+[cc]: ../CODE_OF_CONDUCT.md

data/lib/new_relic/manticore/instrumentation.rb

@@ -3,7 +3,6 @@
 require "ostruct"
 
 require "new_relic/agent/method_tracer"
-require "new_relic/agent/http_clients/abstract_request"
 
 require "new_relic/manticore/wrapped_request"
 require "new_relic/manticore/wrapped_response"
@@ -19,8 +18,7 @@ module NewRelic
     # operation
     def self.create_segment?
       state = NewRelic::Agent::TransactionState.tl_get
-      return false unless state &&
-                          state.current_transaction
+      return false unless state&.current_transaction
 
       return true unless state.current_transaction.current_segment
 
@@ -57,8 +55,8 @@ module NewRelic
           def execute_with_newrelic_trace!
             if NewRelic::Manticore.create_segment?
               segment = NewRelic::Agent::External.start_segment(
-                library: "Manticore",
-                uri: @async_requests.first.request.uri.to_s,
+                library:   "Manticore",
+                uri:       @async_requests.first.request.uri.to_s,
                 procedure: "Parallel batch"
               )
               segment.add_request_headers(PARALLEL_REQUEST_DUMMY)
@@ -84,7 +82,7 @@ module NewRelic
               segment.add_request_headers(WrappedRequest.new(@request))
               on_complete do |response|
                 begin
-                  segment.read_response_headers(WrappedResponse.new(response))
+                  segment.process_response_headers(WrappedResponse.new(response))
                 ensure
                   segment.finish
                 end
@@ -101,9 +99,9 @@ module NewRelic
           alias_method :call, :call_with_newrelic_trace
 
           def create_newrelic_segment
-            NewRelic::Agent::External.start_segment(
-              library: "Manticore",
-              uri: @request.uri.to_s,
+            NewRelic::Agent::Tracer.start_external_request_segment(
+              library:   "Manticore",
+              uri:       @request.uri.to_s,
               procedure: @request.method
             ).tap do |segment|
               segment.record_metrics = false if segment.parent.is_a?(::NewRelic::Agent::Transaction::DatastoreSegment)

data/lib/new_relic/manticore/wrapped_request.rb

@@ -1,3 +1,14 @@
+# frozen_string_literal: true
+
+# Check version to account for a breaking path change
+# introduced in 6.10
+#
+if NewRelic::VERSION::MAJOR == 6 && NewRelic::VERSION::MINOR < 10
+  require "new_relic/agent/http_clients/abstract_request"
+else
+  require "new_relic/agent/http_clients/abstract"
+end
+
 module NewRelic
   module Manticore
     class WrappedRequest < Agent::HTTPClients::AbstractRequest

data/lib/new_relic/manticore/wrapped_response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module NewRelic
   module Manticore
     class WrappedResponse

data/lib/newrelic/manticore.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 # Necessary for bundler auto require (as gem name does not match namespace)
 require "new_relic/manticore"

data/lib/newrelic/manticore/version.rb

@@ -2,6 +2,6 @@
 
 module Newrelic
   module Manticore
-    VERSION = "0.1.2".freeze
+    VERSION = "1.1.0.rc1"
   end
 end

data/newrelic-manticore.gemspec

@@ -27,14 +27,16 @@ Gem::Specification.new do |gem|
   gem.executables   = gem.files.grep(%r{^exe/}) { |f| File.basename(f) }
   gem.require_paths = ["lib"]
 
-  gem.add_runtime_dependency     "newrelic_rpm", "~> 5"
+  gem.required_ruby_version = ">= 2.0.0"
 
-  gem.add_development_dependency "bundler", "~> 1.13"
+  gem.add_runtime_dependency     "manticore", "~> 0.6", ">= 0.6.4"
+  gem.add_runtime_dependency     "newrelic_rpm", "~> 6"
+
+  gem.add_development_dependency "bundler"
   gem.add_development_dependency "faraday", "~> 0"
-  gem.add_development_dependency "manticore", "~> 0"
   gem.add_development_dependency "minitest"
   gem.add_development_dependency "pry"
-  gem.add_development_dependency "rake", "~> 10.0"
+  gem.add_development_dependency "rake", "~> 12.3", ">= 12.3.3"
   gem.add_development_dependency "rspec", "~> 3.0"
   gem.add_development_dependency "rt_rubocop_defaults", "~> 1"
   gem.add_development_dependency "rubocop_runner", "~> 2"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: newrelic-manticore
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 1.1.0.rc1
 platform: java
 authors:
 - Dominik Goltermann
@@ -9,48 +9,54 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2018-10-12 00:00:00.000000000 Z
+date: 2020-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5'
-  name: newrelic_rpm
-  prerelease: false
+        version: '0.6'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.6.4
+  name: manticore
   type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '0.6'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.6.4
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
-  name: bundler
+        version: '6'
+  name: newrelic_rpm
+  type: :runtime
   prerelease: false
-  type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '6'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  name: faraday
-  prerelease: false
+  name: bundler
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -59,9 +65,9 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
-  name: manticore
-  prerelease: false
+  name: faraday
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -74,8 +80,8 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
   name: minitest
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -88,8 +94,8 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
   name: pry
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -100,15 +106,21 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 12.3.3
   name: rake
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
@@ -116,8 +128,8 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.0'
   name: rspec
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -130,8 +142,8 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '1'
   name: rt_rubocop_defaults
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -144,8 +156,8 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2'
   name: rubocop_runner
-  prerelease: false
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -163,6 +175,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
+- CODE_OF_CONDUCT.md
 - Changelog.md
 - Gemfile
 - LICENSE
@@ -189,15 +202,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubyforge_project:
-rubygems_version: 2.7.6
+rubygems_version: 3.0.6
 signing_key:
 specification_version: 4
 summary: Newrelic support for manticore