newrelic-manticore 0.1.2-java → 1.0.0-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 384a5c873ddc6183ca9179c5b2060f408a3141666bef46a35f996bfc0349daff
-  data.tar.gz: c9a3a04cb32931f85253933438f0740a3c499717cdbd50b587127945041283e9
+  metadata.gz: beb2d3219e744b60a994ed584157e1eb84d6418c5a25e59b8832cb98a2c916ff
+  data.tar.gz: 1db486a5d91524f4d41ca0e090c600399c4b558ca6bcb77983f0ec54b6ef3cca
 SHA512:
-  metadata.gz: de7ccebfc9d7c74c6074f3f661c3586cdadc419a0ca3901b4fe5ae5e896d5cc48759f8ec2ee46ace4833beb9be351aab18952d401e2a69940a3999f877a9c5fb
-  data.tar.gz: fdc1a23c186692fbabc731902f4e84444022d62d7a4da55f30b7183798c8613f72c1607185f12e5ba5720756ea33f23e21e9cc0bda26a0a014c5e6b5249cbc11
+  metadata.gz: efeca68b6ba35ae88ac95e7d3117c379751248dae758c73ba515dd842576a5982ed2025e3652fb5ce2b09cafd7e9410547dd6451ba852ba8a39801143bc65df4
+  data.tar.gz: 1ec84cdfc32381e4930656758e23efc01bdbcd9180f8699cb5d7dabad859393f8864a221d22b859db2aea8b10f7df34347165baf8af3598021d0dc1fa178cbf6

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,69 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+In the interest of fostering an open and welcoming environment, we as
+contributors and maintainers pledge to making participation in our project and
+our community a harassment-free experience for everyone, regardless of age, body
+size, disability, ethnicity, sex characteristics, gender identity and expression,
+level of experience, education, socio-economic status, nationality, personal
+appearance, race, religion, or sexual identity and orientation.
+
+## Our Standards
+
+Examples of behavior that contributes to creating a positive environment
+include:
+
+* Using welcoming and inclusive language
+* Being respectful of differing viewpoints and experiences
+* Gracefully accepting constructive criticism
+* Focusing on what is best for the community
+* Showing empathy towards other community members
+
+Examples of unacceptable behavior by participants include:
+
+* The use of sexualized language or imagery and unwelcome sexual attention or
+  advances
+* Trolling, insulting/derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or electronic
+  address, without explicit permission
+* Other conduct which could reasonably be considered inappropriate in a
+  professional setting
+
+## Our Responsibilities
+
+Project maintainers are responsible for clarifying the standards of acceptable
+behavior and are expected to take appropriate and fair corrective action in
+response to any instances of unacceptable behavior.
+
+Project maintainers have the right and responsibility to remove, edit, or
+reject comments, commits, code, wiki edits, issues, and other contributions
+that are not aligned to this Code of Conduct, or to ban temporarily or
+permanently any contributor for other behaviors that they deem inappropriate,
+threatening, offensive, or harmful.
+
+## Scope
+
+This Code of Conduct applies both within project spaces and in public spaces
+when an individual is representing the project or its community. Examples of
+representing a project or community include using an official project e-mail
+address, posting via an official social media account, or acting as an appointed
+representative at an online or offline event. Representation of a project may be
+further defined and clarified by project maintainers.
+
+## Enforcement
+
+Project maintainers who do not follow or enforce the Code of Conduct in good
+faith may face temporary or permanent repercussions as determined by other
+members of the project's leadership.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4,
+available at https://www.contributor-covenant.org/version/1/4/code-of-conduct.html
+
+[homepage]: https://www.contributor-covenant.org
+
+For answers to common questions about this code of conduct, see
+https://www.contributor-covenant.org/faq

data/Changelog.md

@@ -4,6 +4,11 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.0.0] - 2019-03-12
+### Changed
+- Update newrelic agent dependency to major version 6.
+- Replace deprecated calls to internal agent API.
+
 ## [0.1.2] - 2018-10-11
 ### Fixed
 Detection whether manticore is used inside a database segment was not reliable and is now more robust

data/README.md

@@ -1,33 +1,54 @@
-[travis]: https://travis-ci.org/runtastic/newrelic-manticore
-[rubygems]: https://rubygems.org/gems/newrelic-manticore
-[manticore]: https://gitlab.com/cheald/manticore
-[mit]: http://opensource.org/licenses/MIT
-[cc]: http://contributor-covenant.org
-
-# NewrelicManticore
+# Newrelic-Manticore
 
-[![Build Status](https://travis-ci.org/runtastic/newrelic-manticore.svg?branch=master)][travis] [![Gem Version](https://badge.fury.io/rb/newrelic-manticore.svg)][rubygems]
+[![Build Status](https://travis-ci.org/runtastic/newrelic-manticore.svg?branch=master)][travis]
+[![Gem Version](https://badge.fury.io/rb/newrelic-manticore.svg)][rubygems]
 
 Adds NewRelic instrumentation for the [Manticore JRuby HTTP client][manticore].
 
 ## Installation
 Add this line to your application's Gemfile:
 
-`$ gem 'newrelic-manticore'`
+```ruby
+gem 'newrelic-manticore'
+```
 
 And then execute:
 
-`$ bundle`
+    $ bundle
+
+Or install it yourself as:
+
+    $ gem install newrelic-manticore
+
+## Usage
 
-## How it works
 When `newrelic/manticore` is required (e.g. automatically by Bundler), the gem becomes active.
-It hooks itself into `Manticore::Client#request` and traces your HTTP calls as external requests,
+It wraps `Manticore::Response#call` and traces your HTTP calls as external requests,
 adding also the necessary headers for cross application tracing.
 
+### What about parallel requests?
+The NewRelic agent is currently not set up to support multithreaded requests. As [any of the other client integrations](https://docs.newrelic.com/docs/agents/ruby-agent/features/http-client-tracing-ruby#typhoeus),
+_newrelic-manticore_ will trace all parallel requests as [one external service call](https://github.com/runtastic/newrelic-manticore/blob/master/test/new_relic/manticore/instrumentation_test.rb#L50).
+
+### What about async "background" requests?
+Those are traced normally as any other request would be.
+
+## Development
+
+After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+
+To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+
 ## Contributing
 Bug reports and pull requests are welcome on GitHub at https://github.com/runtastic/newrelic-manticore.
-This project is intended to be a safe, welcoming space for collaboration, and contributors are expected
-to adhere to the [Contributor Covenant code of conduct][cc].
+This project is intended to be a safe, welcoming space for collaboration, and
+contributors are expected to adhere to the [code of conduct][cc].
 
 ## License
 The gem is available as open source under [the terms of the MIT License][mit].
+
+[travis]: https://travis-ci.org/runtastic/newrelic-manticore
+[rubygems]: https://rubygems.org/gems/newrelic-manticore
+[manticore]: https://gitlab.com/cheald/manticore
+[mit]: http://opensource.org/licenses/MIT
+[cc]: ../CODE_OF_CONDUCT.md

data/lib/new_relic/manticore/instrumentation.rb

@@ -20,7 +20,7 @@ module NewRelic
     def self.create_segment?
       state = NewRelic::Agent::TransactionState.tl_get
       return false unless state &&
-                          state.current_transaction
+        state.current_transaction
 
       return true unless state.current_transaction.current_segment
 
@@ -57,8 +57,8 @@ module NewRelic
           def execute_with_newrelic_trace!
             if NewRelic::Manticore.create_segment?
               segment = NewRelic::Agent::External.start_segment(
-                library: "Manticore",
-                uri: @async_requests.first.request.uri.to_s,
+                library:   "Manticore",
+                uri:       @async_requests.first.request.uri.to_s,
                 procedure: "Parallel batch"
               )
               segment.add_request_headers(PARALLEL_REQUEST_DUMMY)
@@ -101,9 +101,9 @@ module NewRelic
           alias_method :call, :call_with_newrelic_trace
 
           def create_newrelic_segment
-            NewRelic::Agent::External.start_segment(
-              library: "Manticore",
-              uri: @request.uri.to_s,
+            NewRelic::Agent::Tracer.start_external_request_segment(
+              library:   "Manticore",
+              uri:       @request.uri.to_s,
               procedure: @request.method
             ).tap do |segment|
               segment.record_metrics = false if segment.parent.is_a?(::NewRelic::Agent::Transaction::DatastoreSegment)

data/lib/newrelic/manticore/version.rb

@@ -2,6 +2,6 @@
 
 module Newrelic
   module Manticore
-    VERSION = "0.1.2".freeze
+    VERSION = "1.0.0".freeze
   end
 end

data/newrelic-manticore.gemspec

@@ -27,9 +27,9 @@ Gem::Specification.new do |gem|
   gem.executables   = gem.files.grep(%r{^exe/}) { |f| File.basename(f) }
   gem.require_paths = ["lib"]
 
-  gem.add_runtime_dependency     "newrelic_rpm", "~> 5"
+  gem.add_runtime_dependency     "newrelic_rpm", "~> 6"
 
-  gem.add_development_dependency "bundler", "~> 1.13"
+  gem.add_development_dependency "bundler"
   gem.add_development_dependency "faraday", "~> 0"
   gem.add_development_dependency "manticore", "~> 0"
   gem.add_development_dependency "minitest"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: newrelic-manticore
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 1.0.0
 platform: java
 authors:
 - Dominik Goltermann
@@ -9,14 +9,14 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2018-10-12 00:00:00.000000000 Z
+date: 2019-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '6'
   name: newrelic_rpm
   prerelease: false
   type: :runtime
@@ -24,21 +24,21 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '6'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '0'
   name: bundler
   prerelease: false
   type: :development
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '0'
 - !ruby/object:Gem::Dependency
   requirement: !ruby/object:Gem::Requirement
     requirements:
@@ -163,6 +163,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".travis.yml"
+- CODE_OF_CONDUCT.md
 - Changelog.md
 - Gemfile
 - LICENSE