neuron-client 0.4.5 → 0.4.6

data/lib/neuron-client/model/zone.rb

@@ -58,7 +58,17 @@ module Neuron
         Ad.find(ad_id)
       end
 
-      STATISTIC_TYPES = %w(requests blocks defaults unitloads selections undeliveries impressions redirects clicks)
+      STATISTIC_TYPES = {
+        'requests' => [],
+        'blocks' => ['reason'],
+        'defaults' => [],
+        'unitloads' => [],
+        'selections' => ['ad'],
+        'undeliveries' => ['ad'],
+        'impressions' => ['ad'],
+        'redirects' => ['ad'],
+        'clicks' => ['ad']
+      }
 
       def recent(statistic, parameters={})
         connected_to_admin!
@@ -73,7 +83,7 @@ module Neuron
           unless STATISTIC_TYPES.include?(statistic.to_s)
             raise "Unsupported statistic: #{statistic}"
           end
-          unless by.blank? || by == 'zone'
+          unless by.blank? || STATISTIC_TYPES[statistic.to_s].include?(by.to_s)
             raise "Unsupported by: #{by}"
           end
           unless minutes.blank? || minutes.to_i > 0

data/lib/neuron-client/version.rb

@@ -1,5 +1,5 @@
 module Neuron
   module Client
-    VERSION = "0.4.5"
+    VERSION = "0.4.6"
   end
 end

data/spec/lib/admin_connection_spec.rb

@@ -99,18 +99,22 @@ module Neuron
       end
 
       describe "create" do
-        it "should return nil when errors occur" do
+        it "should return object with errors when they occur" do
           @connection.should_receive(:post).with("test_models", {'test_model' => {}}) do
             throw :errors, {:error => "is_required"}
           end
-
-          TestModel.create({}).should be_nil
+          created = TestModel.create({})
+          created.should be_a TestModel
+          created.errors.should_not be_empty
+          created.id.should be_nil
         end
 
         it "should return the created object when no errors occur" do
           @connection.should_receive(:post).with("test_models", {'test_model' => {}}).and_return({'test_model' => {:id => 1}})
 
-          TestModel.create({}).should be_a TestModel
+          created = TestModel.create({})
+          created.should be_a TestModel
+          created.id.should == 1
         end
       end
 

data/spec/lib/model/zone_spec.rb

@@ -113,9 +113,9 @@ module Neuron
         describe "recent(statistic, by=nil)" do
           it "should call the expected method and return the expected result" do
             zone = Zone.new(@minimal_attributes.merge('id' => 'z99'))
-            @connection.should_receive(:get).with('zones/z99/recent/impressions', {'by' => 'zone'}).and_return('return_value')
+            @connection.should_receive(:get).with('zones/z99/recent/impressions', {'by' => 'ad'}).and_return('return_value')
 
-            zone.recent('impressions', :by => 'zone').should == 'return_value'
+            zone.recent('impressions', :by => 'ad').should == 'return_value'
           end
         end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: neuron-client
 version: !ruby/object:Gem::Version 
-  hash: 5
+  hash: 3
   prerelease: 
   segments: 
   - 0
   - 4
-  - 5
-  version: 0.4.5
+  - 6
+  version: 0.4.6
 platform: ruby
 authors: 
 - RMM Online
@@ -15,8 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-03-12 00:00:00 -05:00
-default_executable: 
+date: 2012-03-12 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rest-client
@@ -451,7 +450,6 @@ files:
 - spec/lib/schema/s3_file_spec.rb
 - spec/lib/schema/zone_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
 homepage: http://github.com/rmm/neuron-client
 licenses: []
 
@@ -481,7 +479,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: neuron-client
-rubygems_version: 1.6.2
+rubygems_version: 1.8.10
 signing_key: 
 specification_version: 3
 summary: Neuron Admin Client Gem