neu-mods 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: afd81033ef60fdd497880f538d3730d1518a37b362307028a165a1f93105bdd2
-  data.tar.gz: 3f6e1aa77c231d6622dceb4d4ae66d500329776659bf4feb2cb4ea8ded455932
+  metadata.gz: d7e678073c1e18b2626473e1e8fcec32052a2a33075d34cea6fe96dca40e8315
+  data.tar.gz: 5d3d44f6bf9ee5600dfdaded3a9d2119472e86c1aa6621fbcd92ea8358619738
 SHA512:
-  metadata.gz: 6b643273728275f712a266a33a64cf34bbe078fa405ca29ffd59af52f0e9ee7c9102f3867f6d4129bcbb5b050d28c9a00995190ec5568fea6761ee1af87254c4
-  data.tar.gz: b86248e24362d8e1436c47c4a0decf5254207ad587791f8fb0434ac7560e4d7a79e3e429464d89ad50dcc92d208e63ad456235a0c94a6c328b7b6efc0951d22f
+  metadata.gz: ce304892f19636ecc57c487810a2ef2932f253d9702dcce6974a16c8e047b56ceeffb3ae25750bf2e5937345523567dd9d598ef59c32e671dcc80d62541748c8
+  data.tar.gz: a31247bacadff8b81b4789c2dc69647b2036b98e246af02492d1ecdfb14e1a625e1deb2f7c7ad7afff5298d531a6b6bcacfa803ab3ea7629ecea623e45e06667

data/.version

@@ -1 +1 @@
-0.7.0
+0.7.1

data/lib/neu/mods/projection.rb

@@ -116,9 +116,7 @@ module NEU
 
       # Every <topic> under any top-level <subject> (the access-copy projection,
       # equivalent to Atlas's extract_topical_subjects).
-      def topical_subjects
-        doc.xpath("/mods:mods/mods:subject/mods:topic", NAMESPACE).map { |t| clean(t.text) }
-      end
+      def topical_subjects = texts_at("/mods:mods/mods:subject/mods:topic")
 
       # The other subject axes. Cerberus's IPTC ingest writes subject/geographic
       # from the IPTC City and State fields, so this one was also being written
@@ -190,9 +188,7 @@ module NEU
       def extent = texts_at("/mods:mods/mods:physicalDescription/mods:extent")
       def digital_origin = texts_at("/mods:mods/mods:physicalDescription/mods:digitalOrigin")
 
-      def genres
-        doc.xpath("/mods:mods/mods:genre", NAMESPACE).map { |g| clean(g.text) }
-      end
+      def genres = texts_at("/mods:mods/mods:genre")
 
       # originInfo repeats, and so do publisher and edition within one. Cerberus's
       # IPTC ingest writes the publisher from the IPTC Source field on every batch,
@@ -263,9 +259,7 @@ module NEU
         end
       end
 
-      def identifiers
-        doc.xpath("/mods:mods/mods:identifier", NAMESPACE).map { |i| clean(i.text) }
-      end
+      def identifiers = texts_at("/mods:mods/mods:identifier")
 
       def permanent_url
         node = doc.at_xpath("/mods:mods/mods:identifier[@type='hdl']", NAMESPACE)
@@ -467,8 +461,11 @@ module NEU
         node ? NEU::MODS.canonical_ws(node.text) : ""
       end
 
-      # The :many counterpart of #text_at. Blank members drop out rather than
-      # arriving as nil, so a consumer mapping over the array cannot trip on one.
+      # The :many counterpart of #text_at, and the one way this file builds a
+      # string array. Blank members drop out rather than arriving as nil: a
+      # record template that seeds an empty <topic> for an edit form to fill --
+      # which is exactly what Atlas's MODSBuilder writes -- otherwise projects
+      # [nil], and every consumer of that array has to guard for it.
       def texts_at(xpath)
         doc.xpath(xpath, NAMESPACE).filter_map { |node| clean(node.text) }
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: neu-mods
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - David Cliff