neu-mods 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ab1cb07bf4122e98017ded99c790824865f68fb8ccdfdcbb3b5fc8e7d72cbf55
-  data.tar.gz: 6d3b467da6fde096e0ea26f9e76c447ea24c563c6cc5fd1a47e06b8f18d72aca
+  metadata.gz: fb4c30744c189d3e0b4bfc0f84bb75175685bcb142dd6dc35dc55cfbcbdaf0a2
+  data.tar.gz: a5cd73f764edf2da97e05787788124bed168c9dba8caf997307fc53591f05661
 SHA512:
-  metadata.gz: 4c9b5a6006cf0ab3faced2d60f49f703ab482f28f2208d39c5225bd7af769c4f6bba634b0808d83d3b5ac3f2210efca07f8b1ad37976e0ed17d1175d666fcccf
-  data.tar.gz: 2c92060d9faddce439bb9b462982fbb186f6d792f5fc86cfa9702a7cf1c2118c06a3236a5e0875c2499e5593083f531a5668c841696168d330c6527728ca56a7
+  metadata.gz: 785e3c7485886be0fd7946b61463e2e2b66319cf4c4f30980b6e4b2b0b8ed2ae4348be41a48caa9fbad536901a89e9c73d4d4fd005283bc2cc0dc9c9102d6ff6
+  data.tar.gz: 7a331ed220702dbab23bd6d16637f33a3da2f431a17939647ee7d1fd21898b9cf76a4594b26300eb01f8c9ad1b50d0cabcd298cdbff9c363a01a7f7bba6229a7

data/.version

@@ -1 +1 @@
-0.1.0
+0.2.0

data/README.md

@@ -34,12 +34,33 @@ doc.topical_subjects # => ["Civil society", ...]   (every <topic>, for the acces
 doc.keywords       # => [...]   (only the editable attribute-free keyword subjects)
 doc.to_h           # => full projection, keyed to Atlas's Metadata::MODS attributes
 
+# Pure title composition (no document needed) — for callers that already hold
+# the parts (e.g. Atlas's access-copy model) and must not re-parse XML on read.
+NEU::MODS.compose_title(non_sort: "", title: "What's New",
+                        part_name: "How We Respond to Disaster", part_number: "Episode 1")
+# => "What's New - How We Respond to Disaster, Episode 1"   (== doc.plain_title)
+
 # Selectors (live nodes — for editing)
 node = doc.primary_title_info.at_xpath("mods:title", NEU::MODS::NAMESPACE)
 node.content = "New Title" unless NEU::MODS.whitespace_equivalent?(node.text, "New Title")
 doc.to_xml
+
+# Editable creators (for an "advanced metadata" form): structured read,
+# node selection (for replace-on-save), and structure-aware build.
+doc.editable_personal_creators   # => [{ given:, family: }]  (plain, Creator role)
+doc.editable_corporate_creators  # => [{ name: }]
+doc.preserved_names              # => [{ name:, role: }]  (authority-bearing / non-Creator — read-only)
+doc.editable_creator_nodes("personal")            # => live <name> nodes to replace
+doc.build_personal_name(given: "Jenny", family: "Smith")      # => a plain personal <name> node
+doc.build_corporate_name(name: "Northeastern University")     # => a plain corporate <name> node
 ```
 
+The "editable creator" set is plain names — **no `@authority`/`@authorityURI`/
+`@valueURI`** — with a **Creator** role; everything else (authority-controlled or
+other-role names) is `preserved_names`, shown read-only. This mirrors the
+keyword-subject curated-vs-editable split. `build_*_name`'s `role:` defaults to
+`"Creator"` but is parameterised, so a later role-selectable form is non-breaking.
+
 ## Two normalizers, two jobs
 
 - `NEU::MODS.whitespace_equivalent?` / `.canonical_ws` — the **no-op guard**: did an

data/lib/neu/mods/projection.rb

@@ -31,13 +31,21 @@ module NEU
       # Composed display title (the former Atlas MODSDecoration#plain_title), driven
       # off the scoped primary title.
       def plain_title
-        p = title_parts
-        return "" if blank?(p[:title])
+        Projection.compose_title(title_parts)
+      end
 
-        "#{p[:non_sort]}#{p[:title]}" +
-          prefix(": ", p[:subtitle]) +
-          prefix(" - ", p[:part_name]) +
-          prefix(", ", p[:part_number])
+      # Pure title composition over a parts hash, factored out of #plain_title so
+      # callers that already hold the parts -- e.g. Atlas's access-copy model --
+      # can compose the display title WITHOUT re-parsing XML on the read path
+      # (reaching for Nokogiri in a decorator is the smell this avoids). Keys:
+      # :non_sort :title :subtitle :part_name :part_number (nil or "" for absent).
+      # Returns "" when there is no title. Exposed as NEU::MODS.compose_title.
+      def self.compose_title(parts)
+        return "" if parts[:title].to_s.strip.empty?
+
+        optional = { ": " => parts[:subtitle], " - " => parts[:part_name], ", " => parts[:part_number] }
+        suffix = optional.filter_map { |sep, val| "#{sep}#{val}" unless val.to_s.strip.empty? }.join
+        "#{parts[:non_sort]}#{parts[:title]}#{suffix}"
       end
 
       # --- Abstract / access ---------------------------------------------------
@@ -76,6 +84,28 @@ module NEU
         end
       end
 
+      # Editable (depositor-managed) creators: the plain names (no authority
+      # markers) with a Creator role, as STRUCTURED parts for form pre-fill --
+      # distinct from #names, which composes display strings for the access copy.
+      def editable_personal_creators
+        editable_creator_nodes("personal").map do |node|
+          { given: clean_part(joined_parts(node, "given")), family: clean_part(joined_parts(node, "family")) }
+        end
+      end
+
+      def editable_corporate_creators
+        editable_creator_nodes("corporate").map { |node| { name: clean_part(non_date_parts_joined(node)) } }
+      end
+
+      # Names the editable form does NOT manage (authority-bearing or non-Creator)
+      # -- for read-only display ("these exist; edit via the XML tab"). Composed
+      # display string + role, like #names but filtered to the preserved set.
+      def preserved_names
+        doc.xpath("/mods:mods/mods:name", NAMESPACE)
+           .reject { |node| editable_creator_name?(node) }
+           .map { |node| { name: name_display_value_w_date(node), role: name_role(node) } }
+      end
+
       # --- Scalars / simple arrays --------------------------------------------
 
       def languages
@@ -176,12 +206,10 @@ module NEU
         v.empty? ? nil : v
       end
 
-      def blank?(str)
-        str.nil? || str.strip.empty?
-      end
-
-      def prefix(sep, val)
-        blank?(val) ? "" : "#{sep}#{val}"
+      # canonical_ws keeping "" for blank -- for structured form-field values
+      # (an empty given/family/org renders as an empty input, not a dropped key).
+      def clean_part(str)
+        NEU::MODS.canonical_ws(str)
       end
 
       def join_paragraphs(nodes)

data/lib/neu/mods/selectors.rb

@@ -39,6 +39,39 @@ module NEU
         node
       end
 
+      # The "editable creator" <name> nodes of a given @type ("personal" /
+      # "corporate") that the Advanced form manages: plain names (no authority
+      # markers) with a Creator role. The write-path counterpart to the
+      # editable_*_creators projections; everything else (authority-bearing or
+      # non-Creator) is curated and left untouched. Mirrors keyword_subjects.
+      def editable_creator_nodes(type)
+        doc.xpath("/mods:mods/mods:name[@type='#{type}']", NAMESPACE)
+           .select { |n| editable_creator_name?(n) }
+      end
+
+      # Build a plain personal-creator <name> node: namePart[@type=given]/[family]
+      # + a text roleTerm. No authority/valueURI (the editable set). `role` is
+      # parameterised (default "Creator") so a later role-selectable form is a
+      # non-breaking change.
+      def build_personal_name(given:, family:, role: "Creator")
+        name = build_node("name")
+        name["type"] = "personal"
+        name.add_child(name_part(given, "given")) unless given.to_s.strip.empty?
+        name.add_child(name_part(family, "family")) unless family.to_s.strip.empty?
+        name.add_child(role_node(role))
+        name
+      end
+
+      # Build a plain corporate-creator <name> node: a single namePart + a text
+      # roleTerm. No authority/valueURI.
+      def build_corporate_name(name:, role: "Creator")
+        node = build_node("name")
+        node["type"] = "corporate"
+        node.add_child(name_part(name)) unless name.to_s.strip.empty?
+        node.add_child(role_node(role))
+        node
+      end
+
       private
 
       def keyword_subject?(subject)
@@ -47,6 +80,28 @@ module NEU
         topics = subject.element_children
         topics.any? && topics.all? { |c| c.name == "topic" }
       end
+
+      # A name is "editable" (depositor-managed) when it carries no authority
+      # markers and resolves to a Creator role. Shared by editable_creator_nodes
+      # (write/select) and the editable_*_creators projections (read).
+      def editable_creator_name?(node)
+        %w[authority authorityURI valueURI].none? { |attr| node[attr] } &&
+          name_role(node) == "Creator"
+      end
+
+      def name_part(text, type = nil)
+        np = build_node("namePart", text.to_s.strip)
+        np["type"] = type if type
+        np
+      end
+
+      def role_node(role)
+        role_el = build_node("role")
+        term = build_node("roleTerm", role)
+        term["type"] = "text"
+        role_el.add_child(term)
+        role_el
+      end
     end
   end
 end

data/lib/neu-mods.rb

@@ -33,5 +33,10 @@ module NEU
     # Curator-freetext normalization for the access copy (see TextNormalizer).
     def normalize(str) = TextNormalizer.normalize(str)
     def normalize_paragraphs(str) = TextNormalizer.normalize_paragraphs(str)
+
+    # Pure display-title composition over a primary-title parts hash (see
+    # Projection.compose_title). Lets a caller that already holds the parts --
+    # e.g. Atlas's access-copy model -- compose the title without parsing XML.
+    def compose_title(parts) = Projection.compose_title(parts)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: neu-mods
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - David Cliff
@@ -14,42 +14,42 @@ dependencies:
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.13'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.13'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3.12'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.60'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.60'
 description: 'Nokogiri-native, dependency-light reading/projection contract over MODS
@@ -62,7 +62,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .version
+- ".version"
 - Gemfile
 - README.md
 - Rakefile
@@ -83,16 +83,16 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '3.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.9
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: Northeastern-flavored MODS XML projection + selection for the DRS.