netzke-basepack 0.6.3 → 0.6.4

data/CHANGELOG.rdoc

@@ -1,3 +1,20 @@
+= v0.6.4 - 2011-02-26
+* API changes
+  * The combo field able to talk to the server has changed its xtype from combobox to netzkeremotecombo. When getting values from the server via AJAX, it expects a 2-dimensional array now, where the first value is the real value (which gets submitted), and the second value is the display value.
+  * xdatetime is no more. datetimefield is used instead.
+
+* enhancements
+  * Components updated to use Ext.Direct (by @pschyska)
+  * New, improved advanced search for GridPanel and PagingFormPanel.
+  * One-to-many association support in Form/GridPanel reworked to use the foreign id instead of a string. This gives us more flexibility about what to display in the association column/field, and also provides for performance improvements (no more need to search for the associated record based on the value provided from the column/field).
+  * GridPanel now memorizes its columns visibility, position and size (when :persistence is set to true)
+  * I18n for GridPanel
+  * A default value can now also be assigned to association column/field (the value must be the associated record's ID)
+  * Slightly optimized selenium tests (no artificial sleeping whenever possible)
+
+* bug fix
+  * Long-standing visual issues with datetime columns in grid panel are solved.
+
 = v0.6.3 - 2011-01-14
 * compatibility with netzke-core 0.6.5
 

data/README.rdoc

@@ -33,7 +33,7 @@ For more examples, see http://demo.netzke.com, and look into test/rails_app
 
 == Running tests
 
-Netzke-basepack is bundled with automated tests. To run them, you need to set up test/rails_app a similar way as you did with your own Rails app that is using Netzke, i.e.: 1) link Ext JS into the "public" folder, 2) link netzke-core into vendor/plugins, 3) run migrations and clone the development database structure into the test database.
+Netzke-basepack is bundled with automated tests. To run them, you need to set up test/rails_app a similar way as you did with your own Rails app that is using Netzke, i.e.: 1) link Ext JS into the "public" folder, 2) link your copy of netzke-core and netzke-basepack into vendor/gems, 3) run migrations and clone the development database structure into the test database.
 
 After this you may run (*from the netzke-basepack folder*):
 

data/Rakefile

@@ -19,6 +19,9 @@ begin
 
            Thanks for installing netzke-basepack!
 
+  Don't forget to run "rails generate netzke:baspack" to copy necessary
+  assets to your public folder!
+
   Netzke home page:     http://netzke.org
   Netzke Google Groups: http://groups.google.com/group/netzke
   Netzke tutorials:     http://blog.writelesscode.com

data/TODO.rdoc

@@ -1,11 +1,8 @@
 == Priority
-* Make GridPanel show the mask straight after pressing "Apply"
+* Commit persistence migrations in the test app
 * DataAccessor#to_array should not rescue exceptions, but rather check the availability of the attributes; `respond_to_with_basepack?` should be extended to also return true for association columns
 * GridPanel's read_only vs editable (doesn't work now) options
 * Find a way to print the grid nicely (along with the column and rows that don't fit on the screen)
 
 == Foolproof
 * Should not be possible to put the "ID" field on any place but first for grids (otherwise record ID is not correct)
-
-== Optimizations
-* Check persistent_config-related queries (aren't they too many?)

data/features/form_panel.feature

@@ -19,7 +19,8 @@ Scenario: Editing the record
   When I go to the UserForm test page
   And I fill in "First name:" with "Salvador"
   And I fill in "Last name:" with "Dali"
-  And I fill in "Role name:" with "painter"
+  And I expand combobox "Role name"
+  And I select "painter" from combobox "Role name"
   And I press "Apply"
   And I go to the UserForm test page
   Then I should see "Salvador"

data/features/grid_panel.feature

@@ -32,6 +32,7 @@ Scenario: Updating a record via "Edit in form"
   And I fill in "First name:" with "Maxim"
   And I fill in "Last name:" with "Osminogov"
   And I press "OK"
+  And I wait for the response from the server
   Then I should see "Maxim"
   And I should see "Osminogov"
   And a user should not exist with first_name: "Carlos"
@@ -43,7 +44,8 @@ Scenario: Deleting a record
   When I go to the UserGrid test page
   And I select all rows in the grid
   And I press "Delete"
-  And I press "Yes"
+  Then I should see "Are you sure?"
+  When I press "Yes"
   Then I should see "Deleted 2 record(s)"
   Then a user should not exist with first_name: "Anton"
   And a user should not exist with first_name: "Maxim"
@@ -87,11 +89,18 @@ Scenario: Grid with strong_default_attrs
 
 @javascript
 Scenario: Grid with columns with default values
-  Given I am on the BookGridWithDefaultValues test page
+  Given an author exists with last_name: "Nabokov"
+  And I am on the BookGridWithDefaultValues test page
+  When I press "Add"
+  Then I should see "Nabokov"
+  And I press "Apply"
+  And I wait for the response from the server
+  Then a book should exist with title: "Lolita", exemplars: 100, digitized: true, author: that author
+
   When I press "Add in form"
   And I press "OK"
-  And I sleep 1 second
-  Then a book should exist with title: "Lolita", exemplars: 100
+  And I wait for the response from the server
+  Then 2 books should exist with title: "Lolita", exemplars: 100, digitized: true, author: that author
 
 @javascript
 Scenario: Inline editing
@@ -99,7 +108,127 @@ Scenario: Inline editing
   When I go to the BookGrid test page
   And I edit row 1 of the grid with title: "Collector", exemplars: 200
   And I press "Apply"
-  And I sleep 1 second
+  And I wait for the response from the server
   Then the grid should have 0 modified records
   And a book should exist with title: "Collector", exemplars: 200
   But a book should not exist with title: "Magus"
+
+@javascript
+Scenario: Column filters
+  Given the following books exist:
+  | title               | exemplars | digitized | notes        |
+  | Journey to Ixtlan   | 10        | true      | A must-read  |
+  | Lolita              | 5         | false     | To read      |
+  | Getting Things Done | 3         | true      | Productivity |
+  When I go to the BookGrid test page
+  And I enable filter on column "exemplars" with value "{gt:6}"
+  And I sleep 1 second
+  Then the grid should show 1 records
+
+  When I clear all filters in the grid
+  And I enable filter on column "notes" with value "'read'"
+  And I sleep 1 second
+  Then the grid should show 2 records
+
+  When I clear all filters in the grid
+  And I enable filter on column "digitized" with value "false"
+  And I sleep 1 second
+  Then the grid should show 1 records
+
+  When I clear all filters in the grid
+  And I enable filter on column "digitized" with value "true"
+  And I sleep 1 second
+  Then the grid should show 2 records
+
+@javascript
+Scenario: Inline editing of association
+  Given an author exists with first_name: "Vladimir", last_name: "Nabokov"
+  And a book exists with title: "Lolita", author: that author
+  And an author exists with first_name: "Herman", last_name: "Hesse"
+  When I go to the BookGrid test page
+  And I expand combobox "author__name" in row 1 of the grid
+  And I wait for the response from the server
+  And I select "Hesse, Herman" in combobox "author__name" in row 1 of the grid
+  And I edit row 1 of the grid with title: "Demian"
+  And I stop editing the grid
+  Then I should see "Hesse, Herman" within "#book_grid"
+
+  When I press "Apply"
+  And I wait for the response from the server
+  Then a book should exist with title: "Demian", author: that author
+  But a book should not exist with title: "Lolita"
+
+@javascript
+Scenario: Inline adding of records
+  Given an author: "Nabokov" exists with first_name: "Vladimir", last_name: "Nabokov"
+  And an author: "Hesse" exists with first_name: "Herman", last_name: "Hesse"
+
+  When I go to the BookGrid test page
+  And I press "Add"
+  And I expand combobox "author__name" in row 1 of the grid
+  And I wait for the response from the server
+  And I select "Hesse, Herman" in combobox "author__name" in row 1 of the grid
+  And I edit row 1 of the grid with title: "Demian"
+
+  And I press "Add"
+  And I expand combobox "author__name" in row 2 of the grid
+  And I wait for the response from the server
+  And I select "Nabokov, Vladimir" in combobox "author__name" in row 2 of the grid
+  And I edit row 2 of the grid with title: "Lolita"
+
+  And I stop editing the grid
+  And I press "Apply"
+  And I wait for the response from the server
+  Then a book should exist with title: "Lolita", author: author "Nabokov"
+  And a book should exist with title: "Demian", author: author "Hesse"
+
+@javascript
+Scenario: Inline adding of records in GridPanel with default values
+  Given an author: "Nabokov" exists with first_name: "Vladimir", last_name: "Nabokov"
+  And an author: "Hesse" exists with first_name: "Herman", last_name: "Hesse"
+
+  When I go to the BookGridWithDefaultValues test page
+  And I press "Add"
+  And I expand combobox "author__last_name" in row 1 of the grid
+  And I wait for the response from the server
+  And I select "Hesse" in combobox "author__last_name" in row 1 of the grid
+  And I edit row 1 of the grid with title: "Demian"
+
+  And I stop editing the grid
+  And I press "Apply"
+  And I wait for the response from the server
+  Then a book should exist with title: "Demian", author: author "Hesse"
+
+@javascript
+Scenario: Renderers for association columns should take effect
+  Given an author exists with first_name: "Vladimir", last_name: "Nabokov"
+  And a book exists with title: "Lolita", author: that author
+  When I go to the BookGridWithCustomColumns test page
+  Then I should see "NABOKOV"
+
+@javascript
+Scenario: Reloading grid data
+  Given a book exists with title: "Magus"
+  When I go to the BookGrid test page
+  And I reload the grid
+  And I reload the grid
+  Then I should not see "Internal Server Error"
+
+@javascript
+Scenario: Advanced search window should be hidable after loading grid panel dynamically second time
+  Given I am on the BookGridLoader test page
+  When I press "Load one"
+  And I wait for the response from the server
+  And I press "Search"
+  And I press "Cancel"
+
+  When I press "Load two"
+  And I wait for the response from the server
+
+  When I press "Load one"
+  And I wait for the response from the server
+
+  And I press "Search" within "#book_grid_loader__book_grid_one"
+  And I wait for the response from the server
+  And I press "Cancel" within "#book_grid_loader__book_grid_one__search_form"
+  Then the "book_grid_loader__book_grid_one__search_form" component should be hidden

data/features/nested_attributes.feature

@@ -8,7 +8,10 @@ Scenario: Grid with nested attributes
   Given an author exists with first_name: "Vlad", last_name: "Nabokoff"
   And a book exists with title: "Lola", author: that author
   When I go to the BookGridWithNestedAttributes test page
-  And I select first row in the grid
+  Then I should see "Vlad" within "#book_grid_with_nested_attributes"
+  And I should see "Nabokoff" within "#book_grid_with_nested_attributes"
+
+  When I select first row in the grid
   And I press "Edit in form"
   And I fill in "Author first name:" with "Vladimir"
   And I fill in "Author last name:" with "Nabokov"

data/features/paging_form_panel.feature

@@ -0,0 +1,41 @@
+Feature: Paging form panel
+  In order to value
+  As a role
+  I want feature
+
+@javascript
+Scenario: Paging through records
+  Given the following books exist:
+  | title               |
+  | Journey to Ixtlan   |
+  | Lolita              |
+  | Getting Things Done |
+
+  When I go to the BookPagingFormPanel test page
+  Then I should see "Journey to Ixtlan"
+
+  When I go forward one page
+  Then the form should show title: "Lolita"
+
+  When I go forward one page
+  Then the form should show title: "Getting Things Done"
+
+@javascript
+Scenario: Searching
+  Given the following books exist:
+  | title               | exemplars | digitized | notes        |
+  | Journey to Ixtlan   | 10        | true      | A must-read  |
+  | Lolita              | 5         | false     | To read      |
+  | Getting Things Done | 3         | true      | Productivity |
+
+  When I go to the BookPagingFormPanel test page
+  And I press "Search"
+  And I wait for the response from the server
+  And I expand combobox "undefined_attr"
+  And I select "Exemplars" from combobox "undefined_attr"
+  And I expand combobox "exemplars_operator"
+  And I select "Less than" from combobox "exemplars_operator"
+  And I fill in "exemplars_value" with "5"
+  And I press "Search" within "#book_paging_form_panel__search_form"
+  And I wait for the response from the server
+  Then the form should show title: "Getting Things Done"

data/features/search_in_grid.feature

@@ -22,14 +22,27 @@ Feature: Search
     Then the grid should show 4 records
 
     When I press "Search"
-    And I fill in "First name like:" with "ai"
+    And I wait for the response from the server
+    And I expand combobox "undefined_attr"
+    And I select "First name" from combobox "undefined_attr"
+    And I fill in "first_name_value" with "ai"
     And I press "Search" within "#user_grid__search_form"
     And I sleep 1 second
     Then the grid should show 2 records
 
-    When I press "Search"
-    And I fill in "Role name like:" with "adm"
-    And I fill in "First name like:" with ""
-    And I press "Search" within "#user_grid__search_form"
-    And I sleep 1 second
-    Then the grid should show 3 records
+    # When I press "Search"
+    # And I follow "+"
+    # And I expand combobox "undefined_attr"
+    # And I select "First name" from combobox "undefined_attr"
+    # And I fill in "first_name_value" with "in"
+    # And I press "Search" within "#user_grid__search_form"
+    # And I sleep 1 second
+    # Then the grid should show 3 records
+
+    # Search on association column not supported yet
+    # When I press "Search"
+    # And I fill in "Role name like:" with "adm"
+    # And I fill in "First name like:" with ""
+    # And I press "Search" within "#user_grid__search_form"
+    # And I sleep 1 second
+    # Then the grid should show 3 records

data/features/step_definitions/form_panel_steps.rb

@@ -0,0 +1,35 @@
+When /^I expand combobox "([^"]*)"$/ do |combo_label|
+  page.driver.browser.execute_script <<-JS
+    var combo = Ext.ComponentMgr.all.filter('fieldLabel', '#{combo_label}').first();
+    combo = combo || Ext.ComponentMgr.all.filter('name', '#{combo_label}').first();
+    combo.onTriggerClick();
+  JS
+
+  When "I wait for the response from the server"
+end
+
+When /^I select "([^"]*)" from combobox "([^"]*)"$/ do |value, combo_label|
+  page.driver.browser.execute_script <<-JS
+    var combo = Ext.ComponentMgr.all.filter('fieldLabel', '#{combo_label}').first();
+    combo = combo || Ext.ComponentMgr.all.filter('name', '#{combo_label}').first();
+    var index = combo.getStore().find('field2', '#{value}');
+    combo.select(index);
+    combo.onViewClick(false);
+  JS
+end
+
+Then /the form should show #{capture_fields}$/ do |fields|
+  fields = ActiveSupport::JSON.decode("{#{fields}}")
+  page.driver.browser.execute_script(<<-JS).should == true
+    var components = [];
+    for (var cmp in Netzke.page) { components.push(cmp); }
+    var form = Netzke.page[components[0]].getForm();
+    var result = true;
+    var values = #{fields.to_json};
+    for (var fieldName in values) {
+      result = form.findField(fieldName).getValue() === values[fieldName];
+      return result;
+    }
+    return result;
+  JS
+end

data/features/step_definitions/generic_steps.rb

@@ -12,4 +12,23 @@ end
 
 When /I sleep (\d+) seconds?/ do |arg1|
   sleep arg1.to_i
-end
+end
+
+When /^I wait for the response from the server$/ do
+  page.wait_until{ page.driver.browser.execute_script("return !Ext.Ajax.isLoading();") }
+end
+
+When /^I go forward one page$/ do
+  page.driver.browser.execute_script(<<-JS)
+    var toolbar = Ext.ComponentMgr.all.find(function(c){ return c.getXType() === 'paging'});
+    toolbar.moveNext();
+  JS
+  page.wait_until{ page.driver.browser.execute_script("return !Ext.Ajax.isLoading();") }
+end
+
+Then /^the "([^"]*)" component should be hidden$/ do |id|
+  page.driver.browser.execute_script(<<-JS).should be_false
+    var cmp = Ext.ComponentMgr.get("#{id}");
+    return cmp.isVisible();
+  JS
+end

data/features/step_definitions/grid_panel_steps.rb

@@ -47,3 +47,66 @@ Then /^the grid should have (\d+) modified records$/ do |n|
     return grid.getStore().getModifiedRecords().length;
   JS
 end
+
+When /^I enable filter on column "([^"]*)" with value "([^"]*)"$/ do |column, value|
+  page.driver.browser.execute_script <<-JS
+    var components = [];
+    for (var cmp in Netzke.page) { components.push(cmp); }
+    var grid = Netzke.page[components[0]];
+    var filter = grid.filters.getFilter(grid.getColumnModel().getDataIndex(grid.getColumnModel().findColumnIndex('#{column}')));
+    filter.setValue(#{value});
+    filter.setActive(true);
+  JS
+end
+
+When /^I clear all filters in the grid$/ do
+  page.driver.browser.execute_script <<-JS
+    var components = [];
+    for (var cmp in Netzke.page) { components.push(cmp); }
+    var grid = Netzke.page[components[0]];
+    grid.filters.clearFilters();
+  JS
+end
+
+When /^I expand combobox "([^"]*)" in row (\d+) of the grid$/ do |field, row|
+  page.driver.browser.execute_script <<-JS
+    var components = [];
+    for (var cmp in Netzke.page) { components.push(cmp); }
+    var grid = Netzke.page[components[0]];
+    var colId = grid.getColumnModel().findColumnIndex("#{field}");
+    var col = grid.getColumnModel().getColumnById(colId);
+    grid.startEditing(#{row.to_i - 1}, colId);
+    col.editor.onTriggerClick();
+  JS
+end
+
+When /^I select "([^"]*)" in combobox "([^"]*)" in row (\d+) of the grid$/ do |value, field, row|
+  page.driver.browser.execute_script <<-JS
+    var components = [];
+    for (var cmp in Netzke.page) { components.push(cmp); }
+    var grid = Netzke.page[components[0]];
+    var colId = grid.getColumnModel().findColumnIndex("#{field}");
+    var col = grid.getColumnModel().getColumnById(colId);
+    var index = col.editor.getStore().find('field2', '#{value}');
+    col.editor.setValue(col.editor.getStore().getAt(index).get('field1'));
+    col.editor.onTriggerClick();
+  JS
+end
+
+When /^I stop editing the grid$/ do
+  page.driver.browser.execute_script <<-JS
+    var components = [];
+    for (var cmp in Netzke.page) { components.push(cmp); }
+    var grid = Netzke.page[components[0]];
+    grid.stopEditing();
+  JS
+end
+
+When /^I reload the grid$/ do
+  page.driver.browser.execute_script <<-JS
+    var components = [];
+    for (var cmp in Netzke.page) { components.push(cmp); }
+    var grid = Netzke.page[components[0]];
+    grid.getStore().reload();
+  JS
+end