network_resiliency 0.7.14 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8515a542f0e3d22b8e562187dcc23325c8c89866c2e708cf540cb73894195471
-  data.tar.gz: 30cd44b2ad019321587b8d29f0afc28cde9070f88ded257799e1bcb1aa3dc7e1
+  metadata.gz: a2a0b6dd58bb024a582f951fd5aa8105506a8c2ffee8dddac284128a09fc844a
+  data.tar.gz: 7b978707f7788382cca10421190942c7395423d363eb222ddb0e5d1f5f1d734d
 SHA512:
-  metadata.gz: 0530fb98688ef75f2cccd2bbe4e75c835bbf20ca3cbdec307c26f9ed9bc04462361867f96ecbf001dc81c36675b1024dca2e09f80b0fa8e71fc623d0540849d2
-  data.tar.gz: 2de979e7c792a32f7993625a529d31a7b35616c51c17aedea97acd2884f0a589144ec2bbb81cf6cb0f8a50591c3bc414cff7e3253643cb46c266ecf0cb8d2458
+  metadata.gz: ae2e38bf103409e575f31245634fca438992e9a50415b5c1d0bfa16e75016513a378ad2f0a9c2adef3c22a6392ef2ed1d9da67c26fff745b799bad2c83806e74
+  data.tar.gz: aad0e97f32f64ecb254ee5095375119bf0ff307ab578a7566280e93994c6a59ea3eb3d135a2e1a89bef4ae3f90d4ab94af149dd274594c9f1bcda76f777c2b0e

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+###  v0.8.0  (2024-03-12)
+- secondary timeout
+- cover http socket error
+
+###  v0.7.15  (2024-03-08)
+- higher def timeouts
+
 ###  v0.7.14  (2024-03-07)
 - lower dynamic timeout
 - timeout-min

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    network_resiliency (0.7.14)
+    network_resiliency (0.8.0)
 
 GEM
   remote: https://rubygems.org/

data/lib/network_resiliency/adapter/http.rb

@@ -6,10 +6,11 @@ module NetworkResiliency
       extend self
 
       ERRORS = [
-        Timeout::Error,
         IOError,
-        SystemCallError,
         (OpenSSL::OpenSSLError if defined?(OpenSSL::SSL)),
+        SocketError,
+        SystemCallError,
+        Timeout::Error,
       ].compact
 
       REQUEST_TIMEOUT_HEADER = "X-Request-Timeout"

data/lib/network_resiliency/version.rb

@@ -1,3 +1,3 @@
 module NetworkResiliency
-  VERSION = "0.7.14"
+  VERSION = "0.8.0"
 end

data/lib/network_resiliency.rb

@@ -21,7 +21,7 @@ module NetworkResiliency
   ADAPTERS = [ :http, :faraday, :redis, :mysql, :postgres, :rails ].freeze
   DEFAULT_TIMEOUT_MIN = 10 # ms
   MODE = [ :observe, :resilient ].freeze
-  RESILIENCY_THRESHOLD = 300
+  RESILIENCY_THRESHOLD = 100
   SAMPLE_RATE = {
     timeout: 0.1,
     stats: 0.1,
@@ -271,7 +271,7 @@ module NetworkResiliency
       key = [ adapter, action, destination ].join(":")
       stats = StatsEngine.add(key, duration)
 
-      if stats.n > RESILIENCY_THRESHOLD * 4
+      if stats.n > RESILIENCY_THRESHOLD * 5
         # downsample to age out old stats
         stats.scale!(50)
       end
@@ -338,8 +338,17 @@ module NetworkResiliency
       destination: destination,
     }
 
-    # p99 = (stats.avg + stats.stdev * 2).order_of_magnitude(ceil: true)
-    p99 = (stats.avg + stats.stdev * 3).power_ceil
+    p99 = (stats.avg + stats.stdev * 3)
+
+    # add margin of error / normalize
+    p99 = if stats.n >= RESILIENCY_THRESHOLD * 2
+      p99.power_ceil
+    else
+      # larger margin of error
+      p99.order_of_magnitude(ceil: true)
+    end
+
+    # enforce minimum timeout
     p99 = [ p99, timeout_min ].max
 
     timeouts = []
@@ -350,11 +359,16 @@ module NetworkResiliency
       if p99 < max
         timeouts << p99
 
-        # fallback attempt
-        if max - p99 > p99
+        # make a second, more lenient attempt
+
+        if p99 * 100 < max
+          # max is excessively high
+          timeouts << p99 * 100
+        elsif p99 * 10 < max
           # use remaining time for second attempt
           timeouts << max - p99
         else
+          # max is smallish
           timeouts << max
 
           NetworkResiliency.statsd&.increment(
@@ -376,10 +390,8 @@ module NetworkResiliency
     else
       timeouts << p99
 
-      # timeouts << p99 * 10 if NetworkResiliency.mode(action) == :resolute
-
-      # unbounded second attempt
-      timeouts << nil
+      # second attempt
+      timeouts << p99 * 100
 
       NetworkResiliency.statsd&.increment(
         "network_resiliency.timeout.missing",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: network_resiliency
 version: !ruby/object:Gem::Version
-  version: 0.7.14
+  version: 0.8.0
 platform: ruby
 authors:
 - Daniel Pepper
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-07 00:00:00.000000000 Z
+date: 2024-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: byebug