network-client 1.0.0 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 30beca79e944d3f7f1d9a042d502593a24cd28dc
-  data.tar.gz: 43176302a9f186c38ee982e962085812c324e749
+  metadata.gz: 4c30beae6ba69e4282f6aeb92bcb3db1b67e7cda
+  data.tar.gz: b826bdcd9e33e89f4397ba62080c1fbebb26dc68
 SHA512:
-  metadata.gz: 1e92a959db3b863d6d196551a6f3497fe0db2903c643354b059009d6cbb25a7996a2531f7af2b4c2fd502286b5546f64883b29ad63b2d2f4ae659e0018cc565f
-  data.tar.gz: 0c6d55ca68c2c5cfe8a577c2d730ab0b414776930908df0b9a7982d816f6020a88c9178fcf3c84da4b011dc4cfcfa600e7e6a9d25cd2576f2ce3ef3cfb7da80a
+  metadata.gz: a912d6b5dd5e72d3f14233c64bb452839e600eb3e23c84627d7d00cf4307a3080e2eae327359b5004e4d8e621fb262d8308edcdc4e902db5d34732221f2dc5c1
+  data.tar.gz: 87e4d7ce29b3988e6db193e148e24e08b11e7ad6a77df17952318d4eea46cdeb37c921c81038915f6126d22abbd330a76dfec1a3b6796d57378b39bda9e0c5e0

data/.travis.yml

@@ -1,7 +1,6 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.2.0
   - 2.2.4
   - 2.3.1
   - 2.4.0

data/Gemfile.lock

@@ -11,8 +11,8 @@ GEM
       i18n (~> 0.7)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
-    codeclimate-test-reporter (1.0.8)
-      simplecov (<= 0.13)
+    codeclimate-test-reporter (1.0.7)
+      simplecov
     concurrent-ruby (1.0.5)
     diff-lcs (1.3)
     docile (1.1.5)
@@ -35,7 +35,7 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.6.0)
     rspec-support (3.6.0)
-    simplecov (0.13.0)
+    simplecov (0.14.1)
       docile (~> 1.1.0)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
@@ -49,12 +49,12 @@ PLATFORMS
 
 DEPENDENCIES
   bundler (~> 1.14)
-  codeclimate-test-reporter (~> 1.0.0)
+  codeclimate-test-reporter (~> 1.0)
   factory_girl (~> 4.5)
   network-client!
   rake (~> 10.0)
   rspec (~> 3.6)
-  simplecov
+  simplecov (~> 0.14.1)
 
 BUNDLED WITH
    1.14.6

data/README.md

@@ -1,7 +1,10 @@
 # Network Client
 [![Gem Version](https://badge.fury.io/rb/network-client.svg)](https://rubygems.org/gems/network-client)
 [![Build Status](https://travis-ci.org/abarrak/network-client.svg?branch=master)](https://travis-ci.org/abarrak/network-client)
-
+[![Dependency Status](https://gemnasium.com/badges/github.com/abarrak/network-client.svg)](https://gemnasium.com/github.com/abarrak/network-client)
+[![Test Coverage](https://codeclimate.com/github/abarrak/network-client/badges/coverage.svg)](https://codeclimate.com/github/abarrak/network-client/coverage)
+[![Code Climate](https://lima.codeclimate.com/github/abarrak/network-client/badges/gpa.svg)](https://lima.codeclimate.com/github/abarrak/network-client)
+[![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
 
 ## Installation
 
@@ -34,4 +37,3 @@ Bug reports and pull requests are very much appreciated at [Github](https://gith
 
 ## License
 [MIT](http://opensource.org/licenses/MIT).
-

data/lib/network-client/core.rb

@@ -24,6 +24,7 @@ module NetworkClient
     def initialize(endpoint:, tries: 1)
       @uri = URI.parse(endpoint)
       @tries = tries
+
       set_http_client
       set_logger
       set_response_struct
@@ -45,6 +46,18 @@ module NetworkClient
       request_json :delete, path, params
     end
 
+    def set_logger
+      @logger = if defined?(Rails)
+        Rails.logger
+      elsif block_given?
+        yield
+      else
+        logger = Logger.new(STDOUT)
+        logger.level = Logger::DEBUG
+        logger
+      end
+    end
+
     private
 
     def set_http_client
@@ -53,18 +66,6 @@ module NetworkClient
       @http.verify_mode = OpenSSL::SSL::VERIFY_NONE
     end
 
-    def set_logger
-      @logger ||= begin
-        if block_given?
-          yield
-        else
-          logger = Logger.new(STDOUT)
-          logger.level = Logger::DEBUG
-          logger
-        end
-      end
-    end
-
     def set_response_struct
       @response_struct = Struct.new(:code, :body)
     end
@@ -73,7 +74,7 @@ module NetworkClient
       response = request(http_method, path, params)
       body = JSON.parse(response.body)
 
-      @response_struct.new(:code => response.code, :body => body)
+      @response_struct.new(response.code, body)
 
     rescue JSON::ParserError => error
       @logger.error "parsing response body as json failed.\n Details: \n #{error.message}"
@@ -81,21 +82,22 @@ module NetworkClient
     end
 
     def request(http_method, path, params = {})
+      headers = { 'accept' => 'application/json', 'Content-Type' => 'application/json' }
       case http_method
       when :get
         full_path = encode_path_params(path, params)
-        request = HTTP_VERBS[http_method].new(full_path)
+        request = HTTP_VERBS[http_method].new(full_path, headers)
       else
-        request = HTTP_VERBS[http_method].new(path)
+        request = HTTP_VERBS[http_method].new(path, headers)
         request.set_form_data(params)
       end
 
       response = http_request(request)
-      case code = response.code
+      case response
       when Net::HTTPSuccess
         true
       else
-        @logger.error "example endpoint responded with a non-success #{code} code."
+        @logger.error "endpoint responded with a non-success #{code} code."
       end
 
       response
@@ -106,8 +108,8 @@ module NetworkClient
         tries_count ||= @tries
         response = @http.request(request)
       rescue Errno::ECONNREFUSED, Net::ReadTimeout, Net::OpenTimeout => error
-        @logger.warn(error)
-        retry unless (tries_count -= 1).zero?
+        @logger.warn(error.message)
+        (tries_count -= 1).zero? ? raise : retry
       else
         response
       end

data/lib/network-client/version.rb

@@ -1,3 +1,3 @@
 module NetworkClient
-  VERSION = "1.0.0"
+  VERSION = "1.0.5"
 end

data/network-client.gemspec

@@ -28,6 +28,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.6"
   spec.add_development_dependency "factory_girl", "~> 4.5"
-  spec.add_development_dependency "simplecov", '~> 0'
-  spec.add_development_dependency 'codeclimate-test-reporter', '~> 1.0', '>= 1.0.0'
+  spec.add_development_dependency "simplecov", "~> 0.14.1"
+  spec.add_development_dependency "codeclimate-test-reporter", "~> 1.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: network-client
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.5
 platform: ruby
 authors:
 - Abdullah Barrak (abarrak)
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.14.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.14.1
 - !ruby/object:Gem::Dependency
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
@@ -87,9 +87,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -97,9 +94,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.0.0
 description: network-client gem is almost a drop-in thin layer around Net::HTTP classes                         with
   simple error handling and retry functionality implemented.
 email: