netsuite_rails 0.3.3 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 02de40385dbc5f58b5ff3e4f5a30d5d861e6d6e8
-  data.tar.gz: 6f7428c068be19459b754c577b6cbecff2e7ac25
+  metadata.gz: f2f2197544aa8884365eda94c0b6d23069430e0e
+  data.tar.gz: 65012b398bc868048b9de452df38820ac102f383
 SHA512:
-  metadata.gz: 9ed7e6ee9237efe96e3a4930085773b0cd0b689844eb9ab3dfe0ec23bb2bed3c42023a28feaf7305cb79052f8388f4069acf3c9ce7cdf68f6945b1b648b02dfb
-  data.tar.gz: 35ab8e616e0f090aff659ea5564b918b00720da78de6404534f5b3dd5dc82d634d79ccedf5387544d3edade71a9c874d230a4c709ec86e646de5ef3920e89a86
+  metadata.gz: c486c007a6d97f0633e82a2d37a7b57321de8115e0a99c80331978b86137b649820bc7bd28c17c6223adfaca23ccf11c1df2fcf2cc1dca4f8409362cdce2b6f2
+  data.tar.gz: 87ef0a329e7ed7af87244d1b058dde0f390e5d887628dc200ee0f49c8d79f4aec525c879da73111003ced628549294d35261315adf0c453e0c0d27264b073423

data/Gemfile

@@ -11,7 +11,4 @@ group :test do
 
   gem 'rspec-rails', '~> 3.4.2'
   gem 'pry-nav'
-
-  gem 'rerun'
-  gem 'rb-fsevent'
 end

data/lib/netsuite_rails/record_sync.rb

@@ -18,6 +18,8 @@ module NetSuiteRails
 
         cattr_accessor :netsuite_custom_record_type_id
         cattr_accessor :netsuite_sync_options
+
+        self.netsuite_sync_options = {}
       end
 
       klass.send(:extend, ClassMethods)

data/lib/netsuite_rails/record_sync/poll_manager.rb

@@ -60,7 +60,7 @@ module NetSuiteRails
         search_criteria = {
           criteria: {
             basic: poll_basic_criteria(klass, opts)
-          }
+          }.merge(poll_join_criteria(klass, opts))
         }
 
         if opts[:saved_search_id]
@@ -85,7 +85,7 @@ module NetSuiteRails
         }.merge(opts)
 
         # allow custom criteria to be passed directly to the sync call
-        criteria = opts[:criteria] || []
+        criteria = extract_basic_search_criteria(opts[:criteria])
 
         # allow custom criteria from the model level
         criteria += klass.netsuite_sync_options[:criteria] || []
@@ -112,6 +112,35 @@ module NetSuiteRails
         criteria
       end
 
+      def poll_join_criteria(klass, opts)
+        extract_advanced_search_criteria(opts[:criteria])
+      end
+
+      def extract_advanced_search_criteria(criteria_option)
+        if criteria_option.is_a?(Hash)
+          criteria_option = criteria_option.dup
+          criteria_option.delete(:basic)
+
+          criteria_option
+        elsif criteria_option.is_a?(Array) || criteria_option.nil?
+          {}
+        else
+          # TODO unhandled criteria type
+        end
+      end
+
+      def extract_basic_search_criteria(criteria_option)
+        # TODO use `kind_of?` instead?
+
+        if criteria_option.is_a?(Hash)
+          criteria_option[:basic] || []
+        elsif criteria_option.is_a?(Array)
+          criteria_option
+        else
+          # TODO unhandled criteria class
+        end
+      end
+
       def process_search_results(klass, opts, search)
         opts = {
           skip_existing: false,

data/lib/netsuite_rails/sync_trigger.rb

@@ -79,6 +79,7 @@ module NetSuiteRails
 
       sync_options = local.netsuite_sync_options
 
+      # TODO should migrate to push_if for better self-documentation
       # :if option is a block that returns a boolean
       return if sync_options.has_key?(:if) && !local.instance_exec(&sync_options[:if])
 

data/lib/netsuite_rails/transformations.rb

@@ -49,8 +49,11 @@ module NetSuiteRails
             return nil
           end
 
-          # an error will be thrown if period is on the end of a sentence
-          email = email.gsub(/[^A-Za-z]+$/, '')
+          email = email.
+            # an error will be thrown if period is on the end of a sentence
+            gsub(/[^A-Za-z]+$/, '').
+            # any commas in the email with throw an error
+            gsub(',', '')
 
           email
         else

data/lib/netsuite_rails/url_helper.rb

@@ -62,6 +62,8 @@ module NetSuiteRails
         "/accounting/transactions/transaction.nl?id=#{internal_id}"
       elsif NetSuite::Records::Account == record_class
         "/accounting/account/account.nl?id=#{internal_id}"
+      elsif NetSuite::Records::Subsidiary == record_class
+        "/common/otherlists/subsidiarytype.nl?id=#{internal_id}"
       else
         # TODO unsupported record type error?
       end

data/netsuite_rails.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |s|
   s.name          = "netsuite_rails"
-  s.version       = "0.3.3"
+  s.version       = "0.3.4"
   s.authors       = ["Michael Bianco"]
   s.email         = ["mike@cliffsidemedia.com"]
   s.summary       = %q{Write Rails applications that integrate with NetSuite}

data/spec/models/poll_manager_spec.rb

@@ -22,7 +22,8 @@ describe NetSuiteRails::RecordSync::PollManager do
   end
 
   it "should poll list sync objects" do
-  	allow(NetSuite::Records::CustomList).to receive(:get).and_return(OpenStruct.new(custom_value_list: OpenStruct.new(custom_value: [])))
+  	allow(NetSuite::Records::CustomList).to receive(:get)
+      .and_return(OpenStruct.new(custom_value_list: OpenStruct.new(custom_value: [])))
 
   	StandardList.netsuite_poll(import_all: true)
 
@@ -51,4 +52,70 @@ describe NetSuiteRails::RecordSync::PollManager do
 
     expect(record).to have_received(:netsuite_pull)
   end
+
+  describe 'custom search criteria' do
+    let(:basic_search_field) do
+      {
+        field: 'type',
+        operator: 'anyOf',
+        value: [ '_itemFulfillment' ]
+      }
+    end
+
+    let(:advanced_search_criteria) do
+      {
+        createdFromJoin: [
+          {
+            field: 'type',
+            operator: 'anyOf',
+            value: [ '_transferOrder' ]
+          }
+        ]
+      }
+    end
+
+    it 'should merge basic search criteria' do
+      expect(NetSuite::Records::Customer).to receive(:search)
+        .with(hash_including(
+          criteria: hash_including(
+            basic: array_including(
+              basic_search_field
+            )
+          )
+        ))
+        .and_return(OpenStruct.new(results: []))
+
+      NetSuiteRails::RecordSync::PollManager.poll(StandardRecord,
+        criteria: [ basic_search_field ]
+      )
+    end
+
+    it 'merges advanced and basic criteria' do
+      expect(NetSuite::Records::Customer).to receive(:search)
+        .with(hash_including(
+          criteria: {
+            basic: array_including(
+              basic_search_field
+            )
+          }.merge(advanced_search_criteria)
+        ))
+        .and_return(OpenStruct.new(results: []))
+
+      NetSuiteRails::RecordSync::PollManager.poll(StandardRecord,
+        criteria: {
+          basic: [ basic_search_field ]
+        }.merge(advanced_search_criteria)
+      )
+    end
+
+    it 'should merge join/advanced criteria' do
+      expect(NetSuite::Records::Customer).to receive(:search)
+        .with(hash_including(criteria: hash_including(advanced_search_criteria)))
+        .and_return(OpenStruct.new(results: []))
+
+      NetSuiteRails::RecordSync::PollManager.poll(StandardRecord,
+        criteria: advanced_search_criteria
+      )
+    end
+  end
 end

data/spec/models/transformations_spec.rb

@@ -58,5 +58,9 @@ describe NetSuiteRails::Transformations do
     netsuite_email = ' example+second@example.family. '
     transformed_netsuite_email = NetSuiteRails::Transformations.email(netsuite_email, :push)
     expect(transformed_netsuite_email.to_s).to eq('example+second@example.family')
+
+    netsuite_email = ' example,second@example.com '
+    transformed_netsuite_email = NetSuiteRails::Transformations.email(netsuite_email, :push)
+    expect(transformed_netsuite_email.to_s).to eq('examplesecond@example.com')
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: netsuite_rails
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - Michael Bianco
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-15 00:00:00.000000000 Z
+date: 2016-05-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: netsuite