netsuite_rails 0.2.2 → 0.3.1

data/lib/netsuite_rails/sync_trigger.rb

@@ -8,6 +8,10 @@ module NetSuiteRails
     #      if a model has a pending/complete state we might want to only push on complete
 
     def attach(klass)
+      # don't attach to non-AR backed models
+      # it is the user's responsibility to trigger `Model#netsuite_push` when ActiveRecord isn't used
+      return unless klass.ancestors.include?(ActiveRecord::Base)
+
       if klass.include?(SubListSync)
         klass.after_save { SyncTrigger.sublist_trigger(self) }
         klass.after_destroy { SyncTrigger.sublist_trigger(self) }
@@ -17,20 +21,26 @@ module NetSuiteRails
         klass.before_save do
           @netsuite_sync_record_import = self.new_record? && self.netsuite_id.present?
 
+          if @netsuite_sync_record_import
+            # pull the record down if it has't been pulled yet
+            # this is useful when this is triggered by a save on a parent record which has this
+            # record as a related record
+
+            if !self.netsuite_pulled? && !self.netsuite_async_jobs?
+              SyncTrigger.record_pull_trigger(self)
+            end
+          end
+
           # if false record will not save
           true
         end
 
         klass.after_save do
-          # need to implement this conditional on the save hook level
+          # this conditional is implemented as a save hook
           # because the coordination class doesn't know about model persistence state
 
           if @netsuite_sync_record_import
-            # pull the record down if it has't been pulled yet
-            # this is useful when this is triggered by a save on a parent record which has this
-            # record as a related record
-
-            unless self.netsuite_pulled?
+            if !self.netsuite_pulled? && self.netsuite_async_jobs?
               SyncTrigger.record_pull_trigger(self)
             end
           else
@@ -47,24 +57,32 @@ module NetSuiteRails
     def record_pull_trigger(local)
       return if NetSuiteRails::Configuration.netsuite_pull_disabled
 
+      sync_options = local.netsuite_sync_options
+
+      return if sync_options.has_key?(:pull_if) && !local.instance_exec(&sync_options[:pull_if])
+
       record_trigger_action(local, :netsuite_pull)
     end
 
-    def record_push_trigger(netsuite_record_rep)
+    def record_push_trigger(local)
       # don't update when fields are updated because of a netsuite_pull
-      return if netsuite_record_rep.netsuite_pulling?
+      if local.netsuite_pulling?
+        Rails.logger.info "NetSuite: Push Stopped. Record is pulling. " +
+                          "local_record=#{local.class}, local_record_id=#{local.id}"
+        return
+      end
 
       return if NetSuiteRails::Configuration.netsuite_push_disabled
 
       # don't update if a read only record
-      return if netsuite_record_rep.netsuite_sync == :read
+      return if local.netsuite_sync == :read
 
-      sync_options = netsuite_record_rep.netsuite_sync_options
+      sync_options = local.netsuite_sync_options
 
       # :if option is a block that returns a boolean
-      return if sync_options.has_key?(:if) && !netsuite_record_rep.instance_exec(&sync_options[:if])
+      return if sync_options.has_key?(:if) && !local.instance_exec(&sync_options[:if])
 
-      record_trigger_action(netsuite_record_rep, :netsuite_push)
+      record_trigger_action(local, :netsuite_push)
     end
 
     def record_trigger_action(local, action)
@@ -79,15 +97,15 @@ module NetSuiteRails
       end
 
       # TODO need to pass off the credentials to the NS push command
-      
+
       # You can force sync mode in different envoirnments with the global configuration variables
 
-      if sync_options[:mode] == :sync || NetSuiteRails::Configuration.netsuite_sync_mode == :sync
+      if !local.netsuite_async_jobs?
         local.send(action, action_options)
       else
         action_options[:modified_fields] = NetSuiteRails::RecordSync::PushManager.modified_local_fields(local).keys
 
-        # TODO support the rails4 DJ implementation
+        # TODO support ActiveJob
 
         if local.respond_to?(:delay)
           local.delay.send(action, action_options)
@@ -98,12 +116,17 @@ module NetSuiteRails
     end
 
     def sublist_trigger(sublist_item_rep)
+      # TODO don't trigger a push if the parent record is still pulling
+      # often sublists are managed in a after_pull hook; we want to prevent auto-pushing
+      # if sublist records are being updated. However, the netsuite_pulling? state is not persisted
+      # so there is no gaurentee that it isn't being pulled by checking parent.netsuite_pulling?
+
       parent = sublist_item_rep.send(sublist_item_rep.class.netsuite_sublist_parent)
-      
+
       if parent.class.include?(RecordSync)
         record_push_trigger(parent)
       end
     end
 
   end
-end
+end

data/lib/netsuite_rails/tasks/netsuite.rb

@@ -5,11 +5,11 @@ namespace :netsuite do
       skip_existing: ENV['SKIP_EXISTING'].present? && ENV['SKIP_EXISTING'] == "true"
     }
 
-    if ENV['RECORD_MODELS'].present?
+    if !ENV['RECORD_MODELS'].nil?
       opts[:record_models] = ENV['RECORD_MODELS'].split(',').map(&:constantize)
     end
 
-    if ENV['LIST_MODELS'].present?
+    if !ENV['LIST_MODELS'].nil?
       opts[:list_models] = ENV['LIST_MODELS'].split(',').map(&:constantize)
     end
 
@@ -25,12 +25,15 @@ namespace :netsuite do
 
   desc "Sync all NetSuite records using import_all"
   task :fresh_sync => :environment do
-    NetSuiteRails::PollTimestamp.delete_all
-
     if ENV['SKIP_EXISTING'].blank?
       ENV['SKIP_EXISTING'] = "true"
     end
 
+    opts = generate_options
+    opts[:record_models].each do |record_model|
+      NetSuiteRails::PollTimestamp.for_class(record_model).delete
+    end
+
     Rake::Task["netsuite:sync"].invoke
   end
 
@@ -47,4 +50,30 @@ namespace :netsuite do
     NetSuiteRails::PollTrigger.update_local_records(generate_options)
   end
 
+  task field_usage_report: :environment do |t|
+    Rails.application.eager_load!
+
+    NetSuiteRails::PollTrigger.instance_variable_get('@record_models').each do |record_model|
+      puts record_model.to_s
+
+      # TODO add the ability to document which fields
+
+      standard_fields = record_model.netsuite_field_map.values - [record_model.netsuite_field_map[:custom_field_list]]
+      custom_fields = record_model.netsuite_field_map[:custom_field_list].values
+
+      standard_fields.reject! { |f| f.is_a?(Proc) }
+      custom_fields.reject! { |f| f.is_a?(Proc) }
+
+      if custom_fields.present?
+        puts "Custom Fields: #{custom_fields.join(', ')}"
+      end
+
+      if standard_fields.present?
+        puts "Standard Fields: #{standard_fields.join(', ')}"
+      end
+
+      puts ""
+    end
+  end
+
 end

data/lib/netsuite_rails/transformations.rb

@@ -2,43 +2,83 @@ module NetSuiteRails
   module Transformations
     class << self
 
-      def transform(type, value)
-        self.send(type, value)
+      def transform(type, value, direction)
+        self.send(type, value, direction)
       end
 
       # NS limits firstname fields to 33 characters
-      def firstname(firstname)
-        firstname[0..33]
+      def firstname(firstname, direction = :push)
+        if direction == :push
+          firstname[0..33]
+        else
+          firstname
+        end
       end
 
-      def phone(phone)
-        formatted_phone = phone.strip
-          .gsub(/ext(ension)?/, 'x')
-          .gsub(/[^0-9x ]/, '')
-          .gsub(/[ ]{2,}/m, ' ')
-        
-        formatted_phone.gsub!(/x.*$/, '') if formatted_phone.size > 22
+      def phone(phone, direction = :push)
+        if direction == :push
+          formatted_phone = phone.
+            strip.
+            gsub(/ext(ension)?/, 'x').
+            # remove anything that isn't a extension indicator or a number
+            gsub(/[^0-9x]/, '').
+            # if the first part of the phone # is 10 characters long and starts with a 1 the 22 char error is thrown
+            gsub(/^1([0-9]{10})/, '\1')
 
-        formatted_phone
+          # eliminate the extension if the number is still too long
+          formatted_phone.gsub!(/x.*$/, '') if formatted_phone.size > 22
+
+          formatted_phone
+        else
+          phone
+        end
       end
 
       # NS will throw an error if whitespace bumpers the email string
-      def email(email)
-        email.strip
+      def email(email, direction = :push)
+        if direction == :push
+          # any whitespace will cause netsuite to throw a fatal error
+          email = email.gsub(' ', '')
+
+          # TODO consider throwing an exception instead of returning nil?
+          # netsuite will throw a fatal error if a valid email address is not sent
+          # http://stackoverflow.com/questions/742451/what-is-the-simplest-regular-expression-to-validate-emails-to-not-accept-them-bl
+          if email !~ /.+@.+\..+/
+            return nil
+          end
+
+          # an error will be thrown if period is on the end of a sentence
+          email = email.gsub(/[^A-Za-z]+$/, '')
+
+          email
+        else
+          email
+        end
       end
 
       # https://www.reinteractive.net/posts/168-dealing-with-timezones-effectively-in-rails
       # http://stackoverflow.com/questions/16818180/ruby-rails-how-do-i-change-the-timezone-of-a-time-without-changing-the-time
       # http://alwayscoding.ca/momentos/2013/08/22/handling-dates-and-timezones-in-ruby-and-rails/
 
-      def date(date)
-        date.change(offset: "-07:00", hour: 24 - (8 + NetSuiteRails::Configuration.netsuite_instance_time_zone_offset))
+      def date(date, direction = :push)
+        if direction == :push
+          # setting the hour to noon eliminates the chance that some strange timezone offset
+          # shifting would cause the date to drift into the next or previous day
+          date.to_datetime.change(offset: "-07:00", hour: 12)
+        else
+          date.change(offset: Time.zone.formatted_offset)
+        end
       end
 
-      def datetime(datetime)
-        datetime.change(offset: "-08:00") - (8 + NetSuiteRails::Configuration.netsuite_instance_time_zone_offset).hours
+      def datetime(datetime, direction = :push)
+        if direction == :push
+          datetime.change(offset: "-08:00", year: 1970, day: 01, month: 01) - (8 + NetSuiteRails::Configuration.netsuite_instance_time_zone_offset).hours
+        else
+          datetime = datetime.change(offset: Time.zone.formatted_offset) + (8 + NetSuiteRails::Configuration.netsuite_instance_time_zone_offset).hours
+          datetime
+        end
       end
 
     end
   end
-end
+end

data/lib/netsuite_rails/url_helper.rb

@@ -4,7 +4,8 @@ module NetSuiteRails
     # TODO create a xxx_netsuite_url helper generator
 
     def self.netsuite_url(record = self)
-      prefix = "https://system#{".sandbox" if NetSuite::Configuration.sandbox}.netsuite.com/app"
+      domain = NetSuite::Configuration.wsdl_domain.sub('webservices.', 'system.')
+      prefix = "https://#{domain}/app"
 
       if record.class.to_s.start_with?('NetSuite::Records')
         record_class = record.class
@@ -21,19 +22,51 @@ module NetSuiteRails
       # https://system.sandbox.netsuite.com/app/common/scripting/scriptrecordlist.nl
       # https://system.sandbox.netsuite.com/app/common/scripting/script.nl
 
-      if is_custom_record
-        "#{prefix}/common/custom/custrecordentry.nl?id=#{internal_id}&rectype=#{record.class.netsuite_custom_record_type_id}"
-      elsif [ NetSuite::Records::InventoryItem, NetSuite::Records::NonInventorySaleItem, NetSuite::Records::AssemblyItem].include?(record_class)
-        "#{prefix}/common/item/item.nl?id=#{internal_id}"
+      # dependent record links
+      # https://system.na1.netsuite.com/core/pages/itemchildrecords.nl?id=12413&t=InvtItem%05ProjectCostCategory&rectype=-10
+      # https://system.na1.netsuite.com/app/accounting/transactions/payments.nl?id=91964&label=Customer+Refund&type=custrfnd&alllinks=T
+
+      suffix = if is_custom_record
+        "/common/custom/custrecordentry.nl?id=#{internal_id}&rectype=#{record.class.netsuite_custom_record_type_id}"
+      elsif [
+        NetSuite::Records::InventoryItem,
+        NetSuite::Records::NonInventorySaleItem,
+        NetSuite::Records::AssemblyItem,
+        NetSuite::Records::ServiceSaleItem,
+        NetSuite::Records::DiscountItem,
+      ].include?(record_class)
+        "/common/item/item.nl?id=#{internal_id}"
       elsif record_class == NetSuite::Records::Task
-        "#{prefix}/crm/calendar/task.nl?id=#{internal_id}"
-      elsif record_class == NetSuite::Records::Customer
-        "#{prefix}/common/entity/custjob.nl?id=#{internal_id}"
-      elsif record_class == NetSuite::Records::Contact
-        "#{prefix}/common/entity/contact.nl?id=#{internal_id}"
-      elsif [ NetSuite::Records::SalesOrder, NetSuite::Records::Invoice, NetSuite::Records::CustomerRefund ].include?(record_class)
-        "#{prefix}/accounting/transactions/transaction.nl?id=#{internal_id}"
+        "/crm/calendar/task.nl?id=#{internal_id}"
+      elsif record_class == NetSuite::Records::Roles
+        "/setup/role.nl?id=#{internal_id}"
+      elsif [
+        NetSuite::Records::Contact,
+        NetSuite::Records::Customer,
+        NetSuite::Records::Vendor,
+        NetSuite::Records::Partner,
+        NetSuite::Records::Employee
+      ].include?(record_class)
+        "/common/entity/entity.nl?id=#{internal_id}"
+      elsif [
+        NetSuite::Records::SalesOrder,
+        NetSuite::Records::Invoice,
+        NetSuite::Records::CustomerRefund,
+        NetSuite::Records::CashSale,
+        NetSuite::Records::ItemFulfillment,
+        NetSuite::Records::CustomerDeposit,
+        NetSuite::Records::CustomerPayment,
+        NetSuite::Records::CreditMemo,
+        NetSuite::Records::Deposit
+        ].include?(record_class)
+        "/accounting/transactions/transaction.nl?id=#{internal_id}"
+      elsif NetSuite::Records::Account == record_class
+        "/accounting/account/account.nl?id=#{internal_id}"
+      else
+        # TODO unsupported record type error?
       end
+
+      prefix + suffix
     end
 
   end

data/netsuite_rails.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |s|
   s.name          = "netsuite_rails"
-  s.version       = "0.2.2"
+  s.version       = "0.3.1"
   s.authors       = ["Michael Bianco"]
   s.email         = ["mike@cliffsidemedia.com"]
   s.summary       = %q{Write Rails applications that integrate with NetSuite}
@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
   s.test_files    = s.files.grep(%r{^(test|spec|features)/})
   s.require_paths = ["lib"]
 
-  s.add_dependency 'netsuite', '~> 0.3.2'
+  s.add_dependency 'netsuite', '> 0.5.2'
   s.add_dependency 'rails', '>= 3.2.16'
 
   s.add_development_dependency "bundler", "~> 1.6"

data/spec/models/configuration_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe NetSuiteRails::Configuration do
+  it 'should disable netsuite push and pull' do
+    NetSuiteRails::Configuration.netsuite_push_disabled true
+    NetSuiteRails::Configuration.netsuite_pull_disabled false
+
+    expect(NetSuiteRails::Configuration.netsuite_pull_disabled).to eq(false)
+    expect(NetSuiteRails::Configuration.netsuite_push_disabled).to eq(true)
+  end
+end

data/spec/models/poll_manager_spec.rb

@@ -30,9 +30,10 @@ describe NetSuiteRails::RecordSync::PollManager do
   end
 
   it "should sync only available local records" do
-    NetSuiteRails::Configuration.netsuite_push_disabled true
+    # disabling NS pull since this is treated as a record import (NS ID = exists, new_record? == true)
+    NetSuiteRails::Configuration.netsuite_pull_disabled true
     StandardRecord.create! netsuite_id: 123
-    NetSuiteRails::Configuration.netsuite_push_disabled false
+    NetSuiteRails::Configuration.netsuite_pull_disabled false
 
     allow(NetSuite::Records::Customer).to receive(:get_list).and_return([OpenStruct.new(internal_id: 123)])
     allow(NetSuiteRails::RecordSync::PollManager).to receive(:process_search_result_item)
@@ -42,4 +43,12 @@ describe NetSuiteRails::RecordSync::PollManager do
     expect(NetSuite::Records::Customer).to have_received(:get_list)
   end
 
+  it 'runs netsuite_pull on a newly created record with a netsuite_id defined' do
+    record = StandardRecord.new netsuite_id: 123
+    allow(record).to receive(:netsuite_pull)
+
+    record.save!
+
+    expect(record).to have_received(:netsuite_pull)
+  end
 end

data/spec/models/poll_trigger_spec.rb

@@ -4,23 +4,43 @@ describe NetSuiteRails::PollTrigger do
   include ExampleModels
 
   it "should properly sync for the first time" do
-  	allow(StandardRecord).to receive(:netsuite_poll).with(hash_including(:import_all => true))
+    allow(NetSuiteRails::RecordSync::PollManager).to receive(:poll)
 
-  	NetSuiteRails::PollTrigger.sync list_models: []
+    NetSuiteRails::PollTrigger.sync list_models: [], record_models: [ StandardRecord ]
 
-  	expect(StandardRecord).to have_received(:netsuite_poll)
+    expect(NetSuiteRails::RecordSync::PollManager).to have_received(:poll)
   end
 
-  it "should trigger syncing when the time has passed is greater than frequency" do
-  	allow(StandardRecord).to receive(:netsuite_poll)
+  it "should trigger syncing is triggered from the model when time passed is greater than frequency" do
+    allow(StandardRecord).to receive(:netsuite_poll)
+    allow(StandardRecord.netsuite_record_class).to receive(:search).and_return(OpenStruct.new(results: []))
 
-  	StandardRecord.netsuite_sync_options[:frequency] = 5.minutes
-  	timestamp = NetSuiteRails::PollTimestamp.for_class(StandardRecord)
-  	timestamp.value = DateTime.now - 7.minutes
-  	timestamp.save!
+    StandardRecord.netsuite_sync_options[:frequency] = 5.minutes
 
-  	NetSuiteRails::PollTrigger.sync list_models: []
+    timestamp = NetSuiteRails::PollTimestamp.for_class(StandardRecord)
+    timestamp.value = DateTime.now - 6.minutes
+    timestamp.save!
 
-  	expect(StandardRecord).to have_received(:netsuite_poll)
+    NetSuiteRails::PollTrigger.sync list_models: [], record_models: [ StandardRecord ]
+
+    expect(StandardRecord).to have_received(:netsuite_poll)
+  end
+
+  it 'should not change the poll timestamp when sync does not occur' do
+    allow(StandardRecord).to receive(:netsuite_poll)
+
+    StandardRecord.netsuite_sync_options[:frequency] = 5.minutes
+
+    last_timestamp = DateTime.now - 3.minutes
+
+    timestamp = NetSuiteRails::PollTimestamp.for_class(StandardRecord)
+    timestamp.value = last_timestamp
+    timestamp.save!
+
+    NetSuiteRails::PollTrigger.sync list_models: [], record_models: [ StandardRecord ]
+
+    expect(StandardRecord).to_not have_received(:netsuite_poll)
+    timestamp = NetSuiteRails::PollTimestamp.find(timestamp.id)
+    expect(timestamp.value).to eq(last_timestamp)
   end
 end

data/spec/models/record_sync/push_manager_spec.rb

@@ -0,0 +1,51 @@
+describe NetSuiteRails::RecordSync::PushManager do
+  include ExampleModels
+
+  it 'should handle a modified field with a Proc instead of a netsuite field key' do
+    record = StandardRecord.new netsuite_id: 234
+    allow(record).to receive(:new_netsuite_record?).and_return(false)
+
+    ns_record = record.netsuite_record_class.new
+
+    NetSuiteRails::RecordSync::PushManager.push(record, { modified_fields: [ :company ] })
+  end
+
+  it 'should ignore modified fields if the record has not yet been pushed to NetSuite' do
+    record = StandardRecord.new
+
+    expect(NetSuiteRails::RecordSync::PushManager).to receive(:push_add).once
+    expect(NetSuiteRails::RecordSync::PushManager).to receive(:build_netsuite_record).with(instance_of(StandardRecord), hash_including({
+      :modified_fields => hash_including(:phone, :company)
+    }))
+
+    NetSuiteRails::RecordSync::PushManager.push(record, { modified_fields: [ :company ] })
+  end
+
+  context "AR" do
+    xit "should look at the NS ID of a has_one relationship on the record sync model"
+
+    xit "should properly determine the changed attributes"
+  end
+
+  context "not AR" do
+    xit "should execute properly for a simple active model class"
+
+  end
+
+  context 'record building' do
+    it "should properly handle custom records" do
+      custom = CustomRecord.new netsuite_id: 234
+      record = NetSuiteRails::RecordSync::PushManager.build_netsuite_record_reference(custom)
+
+      expect(record.internal_id).to eq(234)
+      expect(record.rec_type.internal_id).to eq(123)
+    end
+
+    it "should properly handle records using external ID" do
+      local = ExternalIdRecord.new(netsuite_id: 123, phone: "234")
+      record = NetSuiteRails::RecordSync::PushManager.build_netsuite_record_reference(local, { use_external_id: true })
+
+      expect(record.external_id).to eq(local.netsuite_external_id)
+    end
+  end
+end

data/spec/models/record_sync_spec.rb

@@ -0,0 +1,16 @@
+require 'spec_helper'
+
+describe NetSuiteRails::RecordSync do
+  include ExampleModels
+  
+  context 'custom records' do
+    it "should properly pull the NS rep" do
+      allow(NetSuite::Records::CustomRecord).to receive(:get).with(hash_including(:internal_id => 234, type_id: 123))
+
+      custom_record = CustomRecord.new netsuite_id: 234
+      custom_record.netsuite_pull_record
+
+      expect(NetSuite::Records::CustomRecord).to have_received(:get)
+    end
+  end
+end

data/spec/models/spec_helper_spec.rb

@@ -2,8 +2,7 @@ require 'spec_helper'
 
 require 'netsuite_rails/spec/spec_helper'
 
-describe NetSuiteRails::TestHelpers do
-  include NetSuiteRails::TestHelpers
+describe 'netsuite_rails test helpers' do
   include ExampleModels
 
   let(:fake_search_results) { OpenStruct.new(results: [ OpenStruct.new(internal_id: 0) ]) }

data/spec/models/transformations_spec.rb

@@ -0,0 +1,62 @@
+require 'spec_helper'
+
+# TODO https://github.com/NetSweet/netsuite_rails/issues/16
+# there are still some unresolved issues with NS datetime/date conversions
+# the tests + implementation may still not be correct.
+
+describe NetSuiteRails::Transformations do
+  before do
+    ENV['TZ'] = 'EST'
+    Rails.configuration.time_zone = 'Eastern Time (US & Canada)'
+    Time.zone = ActiveSupport::TimeZone[-5]
+
+    NetSuiteRails::Configuration.netsuite_instance_time_zone_offset -6
+  end
+
+  it 'handles very long phone numbers' do
+    long_phone_number = '+1 (549)-880-4834 ext. 51077'
+
+    expect(NetSuiteRails::Transformations.phone(long_phone_number)).to eq('5498804834x51077')
+
+    weird_long_phone_number = '12933901964x89914'
+    expect(NetSuiteRails::Transformations.phone(weird_long_phone_number)).to eq('2933901964x89914')
+  end
+
+  it "translates local date into NS date" do
+    # from what I can tell, NetSuite stores dates with a -07:00 offset
+    # and subtracts (PST - NS instance timezone) hours from the stored datetime
+
+    local_date = DateTime.parse("2015-07-24T00:00:00.000-05:00")
+    transformed_date = NetSuiteRails::Transformations.date(local_date, :push)
+    expect(transformed_date.to_s).to eq("2015-07-24T12:00:00-07:00")
+  end
+
+  it "translates local datetime into NS datetime" do
+    # TODO set local timezone
+    local_date = DateTime.parse('Fri May 29 11:52:47 EDT 2015')
+    NetSuiteRails::Configuration.netsuite_instance_time_zone_offset -6
+
+    transformed_date = NetSuiteRails::Transformations.datetime(local_date, :push)
+    # TODO this will break as PDT daylight savings is switched; need to freeze the system time for testing
+    expect(transformed_date.to_s).to eq('1970-01-01T09:52:47-08:00')
+  end
+
+  it 'transforms a datetime value pulled from netsuite correctly' do
+    # assuming that the date in CST is displayed as 5am
+    # in the rails backend we want to store the date as EST with a CST hour
+
+    netsuite_time = DateTime.parse('1970-01-01T03:00:00.000-08:00')
+    transformed_netsuite_time = NetSuiteRails::Transformations.datetime(netsuite_time, :pull)
+    expect(transformed_netsuite_time.to_s).to eq('1970-01-01T05:00:00-05:00')
+  end
+
+  it 'transforms a invalid email' do
+    netsuite_email = ' hey@example.com. '
+    transformed_netsuite_email = NetSuiteRails::Transformations.email(netsuite_email, :push)
+    expect(transformed_netsuite_email.to_s).to eq('hey@example.com')
+
+    netsuite_email = ' example+second@example.family. '
+    transformed_netsuite_email = NetSuiteRails::Transformations.email(netsuite_email, :push)
+    expect(transformed_netsuite_email.to_s).to eq('example+second@example.family')
+  end
+end

data/spec/models/url_helper_spec.rb

@@ -1,23 +1,34 @@
 require 'spec_helper'
 
 describe NetSuiteRails::UrlHelper do
-	include ExampleModels
+  include ExampleModels
 
   it 'should handle a netsuite record' do
-  	c = NetSuite::Records::Customer.new internal_id: 123
-  	url = NetSuiteRails::UrlHelper.netsuite_url(c)
+    NetSuite::Configuration.sandbox = true
+    c = NetSuite::Records::Customer.new internal_id: 123
+    url = NetSuiteRails::UrlHelper.netsuite_url(c)
 
-  	expect(url).to include("cust")
+    expect(url).to eq('https://system.sandbox.netsuite.com/app/common/entity/entity.nl?id=123')
   end
 
   it "should handle a record sync enabled record" do
-  	s = StandardRecord.new netsuite_id: 123
-  	url = NetSuiteRails::UrlHelper.netsuite_url(s)
+    NetSuite::Configuration.sandbox = true
+    s = StandardRecord.new netsuite_id: 123
+    url = NetSuiteRails::UrlHelper.netsuite_url(s)
 
-  	expect(url).to include("cust")
+    expect(url).to eq('https://system.sandbox.netsuite.com/app/common/entity/entity.nl?id=123')
   end
 
-  it "should handle a list sync enabled record" do
-  	
+  xit "should handle a list sync enabled record" do
+
+  end
+
+  it 'should change the prefix URL when a non-sandbox datacenter is in use' do
+    NetSuite::Configuration.sandbox = false
+
+    s = StandardRecord.new netsuite_id: 123
+    url = NetSuiteRails::UrlHelper.netsuite_url(s)
+
+    expect(url).to eq('https://system.netsuite.com/app/common/entity/entity.nl?id=123')
   end
 end