netsuite_rails 0.2.1 → 0.2.2

data/lib/netsuite_rails/netsuite_configure.rb

@@ -3,11 +3,11 @@
 NetSuite.configure do
   reset!
   
-  email         ENV['NETSUITE_EMAIL']
-  password      ENV['NETSUITE_PASSWORD']
-  account       ENV['NETSUITE_ACCOUNT']
-  role          ENV['NETSUITE_ROLE']
-  api_version   ENV['NETSUITE_API']
+  email         ENV['NETSUITE_EMAIL']     if ENV['NETSUITE_EMAIL'].present?
+  password      ENV['NETSUITE_PASSWORD']  if ENV['NETSUITE_PASSWORD'].present?
+  account       ENV['NETSUITE_ACCOUNT']   if ENV['NETSUITE_ACCOUNT'].present?
+  role          ENV['NETSUITE_ROLE']      if ENV['NETSUITE_ROLE'].present?
+  api_version   ENV['NETSUITE_API']       if ENV['NETSUITE_API'].present?
   sandbox       (ENV['NETSUITE_PRODUCTION'].blank? || ENV['NETSUITE_PRODUCTION'] != 'true')
 
   read_timeout  100000

data/lib/netsuite_rails/record_sync.rb

@@ -130,7 +130,8 @@ module NetSuiteRails
         @netsuite_pulled ||= false
       end
 
-      def netsuite_pull
+      def netsuite_pull(opts = {})
+        # TODO need to support the opts hash
         netsuite_extract_from_record(netsuite_pull_record)
       end
 
@@ -149,6 +150,7 @@ module NetSuiteRails
         NetSuiteRails::RecordSync::PushManager.push(self, opts)
       end
 
+      # TODO move this login into separate service object
       def netsuite_extract_from_record(netsuite_record)
         @netsuite_pulling = true
 

data/lib/netsuite_rails/sync_trigger.rb

@@ -83,7 +83,7 @@ module NetSuiteRails
       # You can force sync mode in different envoirnments with the global configuration variables
 
       if sync_options[:mode] == :sync || NetSuiteRails::Configuration.netsuite_sync_mode == :sync
-        local.send(action)
+        local.send(action, action_options)
       else
         action_options[:modified_fields] = NetSuiteRails::RecordSync::PushManager.modified_local_fields(local).keys
 

data/netsuite_rails.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |s|
   s.name          = "netsuite_rails"
-  s.version       = "0.2.1"
+  s.version       = "0.2.2"
   s.authors       = ["Michael Bianco"]
   s.email         = ["mike@cliffsidemedia.com"]
   s.summary       = %q{Write Rails applications that integrate with NetSuite}

data/spec/models/sync_trigger_spec.rb

@@ -8,55 +8,71 @@ describe NetSuiteRails::SyncTrigger do
     allow(NetSuiteRails::RecordSync::PushManager).to receive(:push_update)
   end
 
-  it "should push new record when saved" do
-    s = StandardRecord.new
-    s.phone = Faker::PhoneNumber.phone_number
-    s.save!
+  context 'push' do
+    it "should push new record when saved" do
+      s = StandardRecord.new
+      s.phone = Faker::PhoneNumber.phone_number
+      s.save!
 
-    expect(NetSuiteRails::RecordSync::PushManager).to have_received(:push_add)
-    expect(NetSuiteRails::RecordSync::PushManager).to_not have_received(:push_update)
-  end
+      expect(NetSuiteRails::RecordSync::PushManager).to have_received(:push_add)
+      expect(NetSuiteRails::RecordSync::PushManager).to_not have_received(:push_update)
+    end
 
-  it "should not push update on a pull record" do
-    s = StandardRecord.new netsuite_id: 123
-    allow(s).to receive(:netsuite_pull)
-    s.save!
+    it "should not push update on a pull record" do
+      s = StandardRecord.new netsuite_id: 123
+      allow(s).to receive(:netsuite_pull)
+      s.save!
 
-    expect(s).to have_received(:netsuite_pull)
-    expect(NetSuiteRails::RecordSync::PushManager).to_not have_received(:push_add)
-    expect(NetSuiteRails::RecordSync::PushManager).to_not have_received(:push_update)
-  end
+      expect(s).to have_received(:netsuite_pull)
+      expect(NetSuiteRails::RecordSync::PushManager).to_not have_received(:push_add)
+      expect(NetSuiteRails::RecordSync::PushManager).to_not have_received(:push_update)
+    end
 
-  it "should push an update on an existing record" do
-    s = StandardRecord.new netsuite_id: 123
-    allow(s).to receive(:netsuite_pull)
-    s.save!
+    it "should push an update on an existing record" do
+      s = StandardRecord.new netsuite_id: 123
+      allow(s).to receive(:netsuite_pull)
+      s.save!
 
-    s.phone = Faker::PhoneNumber.phone_number
-    s.save!
+      s.phone = Faker::PhoneNumber.phone_number
+      s.save!
 
-    expect(NetSuiteRails::RecordSync::PushManager).to_not have_received(:push_add)
-    expect(NetSuiteRails::RecordSync::PushManager).to have_received(:push_update)
-  end
+      expect(NetSuiteRails::RecordSync::PushManager).to_not have_received(:push_add)
+      expect(NetSuiteRails::RecordSync::PushManager).to have_received(:push_update)
+    end
+
+    it "should push the modified attributes to the model" do
+      s = StandardRecord.new netsuite_id: 123
+      allow(s).to receive(:netsuite_pull)
+      s.save!
 
-  it "should push the modified attributes to the model" do
-    s = StandardRecord.new netsuite_id: 123
-    allow(s).to receive(:netsuite_pull)
-    s.save!
+      # delayed_job isn't included in this gem; hack it into the current record instance
+      s.instance_eval { def delay; self; end }
+      allow(s).to receive(:delay).and_return(s)
 
-    # delayed_job isn't included in this gem; hack it into the current record instance
-    s.instance_eval { def delay; self; end }
-    allow(s).to receive(:delay).and_return(s)
+      NetSuiteRails::Configuration.netsuite_sync_mode :async
 
-    NetSuiteRails::Configuration.netsuite_sync_mode :async
+      s.phone = Faker::PhoneNumber.phone_number
+      s.save!
+
+      NetSuiteRails::Configuration.netsuite_sync_mode :sync
+
+      expect(s).to have_received(:delay)
+      expect(NetSuiteRails::RecordSync::PushManager).to have_received(:push_update).with(anything, anything, {:modified_fields=>{:phone=> :phone}})
+    end
+  end
 
-    s.phone = Faker::PhoneNumber.phone_number
-    s.save!
+  context 'pull' do
+    it 'should pull down a new record with a NS ID set on save' do
+      s = StandardRecord.new netsuite_id: 123
+      allow(s).to receive(:netsuite_pull_record).and_return(NetSuite::Records::Customer.new(phone: '1231231234'))
+      allow(s).to receive(:netsuite_extract_from_record)
 
-    NetSuiteRails::Configuration.netsuite_sync_mode :sync
+      s.save!
 
-    expect(s).to have_received(:delay)
-    expect(NetSuiteRails::RecordSync::PushManager).to have_received(:push_update).with(anything, anything, {:modified_fields=>{:phone=> :phone}})
+      expect(NetSuiteRails::RecordSync::PushManager).to_not have_received(:push_add)
+      expect(NetSuiteRails::RecordSync::PushManager).to_not have_received(:push_update)
+      expect(s).to have_received(:netsuite_extract_from_record)
+    end
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netsuite_rails
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-13 00:00:00.000000000 Z
+date: 2015-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: netsuite