netsuite 0.9.2 → 0.9.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5aad2f60c62b40aaa3e86460dc81283d470a3293d1568fe41d78e431b3d6ec61
-  data.tar.gz: 411b9bbfaa28f9c76ad886245afe83334758d5b3b360d70e405bd1897a0c1a53
+  metadata.gz: 954fbfc75bb1bbce5dcae995d19a5cfc6cf862dc5b70c71ef445bdfb05321629
+  data.tar.gz: 959ea56ff63e5da0dfdb602a422dc8fd2dab8aecaf5742910f3d85e9333f7649
 SHA512:
-  metadata.gz: 72ace4cda9656efd8592ed824ccb788c136aac912c5d9ec2fac38b817f00658979a29dae19c7a298108be49c9d1c386598a7476e05a61a25a05d18a53232c930
-  data.tar.gz: 3fb702a8c3cca1c6896603769027022136b38af973820ae7f098d68f8ec0e4f07f45175d4b4cfd5fb8b189079f7a5ba5255becf166d0640bee5d067430ac3fe4
+  metadata.gz: 3470bae8218194017073f9ff4d52e781d0f5390b3d4b1c44e766fee8d13737da52f891f5f4ae9ce8e865d99d55fb47ebef0cedd115c64a908628ab65077a8940
+  data.tar.gz: ba3d6369e168926b02d51b2faa045bed59a7d4f45874e4a17dedec74f5f3c09d2ba356c962671b977c49412b4397d60017936323efc80a6340ed3fda119e6da4

data/.github/workflows/main.yml

@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: [3.1, 3.0, 2.7, 2.6, 2.5, 2.4, 2.3, 2.2, 2.1]
+        ruby-version: [3.2, 3.1, 3.0, 2.7, 2.6, 2.5, 2.4, 2.3, 2.2, 2.1]
         bundle-tzinfo: [true, false]
     env:
       BUNDLE_TZINFO: "${{ matrix.bundle-tzinfo }}"

data/HISTORY.md

@@ -1,13 +1,45 @@
 ## Unreleased
 
+### Added
+
+### Fixed
+
+### Breaking Changes
+
+## v0.9.3
+
+### Added
+* Create abstract action parent class by @andrewdicken-stripe in https://github.com/NetSweet/netsuite/pull/568
+
+### Fixed
+* Add department, klass and location EstimateItem/record_refs by @nickdufresne in https://github.com/NetSweet/netsuite/pull/572
+* Invoice shipping_tax_code should be a record_ref by @stevewoodcock in https://github.com/NetSweet/netsuite/pull/573
+* dont crash if suitetalk returns empty <platformCore:searchRowList/> by @ericcj in https://github.com/NetSweet/netsuite/pull/574
+* Add :klass field to record VendorReturnAuthorizationItem & VendorReturnAuthorization by @shubhrathasetty in https://github.com/NetSweet/netsuite/pull/576
+* Optionally pass in `proxy` parameter to Savon by @dbecker-stripe in https://github.com/NetSweet/netsuite/pull/548
+
+## v0.9.2
+
+### Fixed
+
+* Update rspec requirement from ~> 3.11.0 to ~> 3.12.0 by @dependabot in https://github.com/NetSweet/netsuite/pull/567
+* [Adding UK country mapping](https://github.com/NetSweet/netsuite/commit/5fe96ed28fb8341b6926e169cf50d817632b5b8d)
+
+### Breaking Changes
+
+* [remove country mapping hack for old API versions](https://github.com/NetSweet/netsuite/commit/a0357f0a9e08eb3a4a80f1d1e7a37f95bcb17d4f)
+
+## v0.9.1
 
 ### Added
 * Add `Configuration#multi_tenant!` for opting into multi-tentant support where configuration/caching is per-thread (#556)
 
 ### Fixed
 * Avoid Savon version `2.13.0` to prevent generating invalid envelopes. (#558, #563)
+* Retry on `HTTPI::SSLError` and `HTTPI::TimeoutError` in backoff (#566)
 
 ### Breaking Changes
+* Update default API version to 2016_2 from 2015_1 when `api_version` is not explicitly set (#554)
 
 ## 0.9.0
 
@@ -21,6 +53,9 @@ The following were removed as `fields` since their sublist class is not yet impl
 * Add `update` action to `File` records (#544)
 * Expose `errors` after calls to `delete` action (#545)
 * Add `update_list` action where missing on supported item records (#546)
+* Add `proxy` attribute to `NetSuite::Configuration` to set a proxy used by the savon client (#547)
+
+### Fixed
 * Ignore `after_submit_failed` status details (>= 2018.2) when collating errors in add action (#550)
 * Add `NullFieldList` to `SalesOrder` (#552)
 * Add thread safety to NetSuite configuration and utilities (#549)

data/README.md

@@ -1,5 +1,5 @@
 [![Ruby](https://github.com/NetSweet/netsuite/actions/workflows/main.yml/badge.svg)](https://github.com/NetSweet/netsuite/actions/workflows/main.yml)
-[![Slack Status](https://opensuite-slackin.herokuapp.com/badge.svg)](http://opensuite-slackin.herokuapp.com)
+[![Slack Status](https://netsuite-slackin.fly.dev/badge.svg)](https://netsuite-slackin.fly.dev)
 [![Gem Version](https://badge.fury.io/rb/netsuite.svg)](http://badge.fury.io/rb/netsuite)
 
 # NetSuite SuiteTalk API Ruby Gem
@@ -10,7 +10,7 @@
 
 # Help & Support
 
-Join the [Slack channel](http://opensuite-slackin.herokuapp.com) for help with any NetSuite issues. Please do not post usage questions as issues in GitHub.
+Join the [Slack channel](https://netsuite-slackin.fly.dev) for help with any NetSuite issues. Please do not post usage questions as issues in GitHub.
 
 There is some additional helpful resources for NetSuite development [listed here](https://dashboard.suitesync.io/docs/resources#netsuite).
 

data/lib/netsuite/actions/abstract_action.rb

@@ -0,0 +1,32 @@
+module NetSuite
+  module Actions
+    class AbstractAction
+      def request(credentials={})
+        NetSuite::Configuration.connection(request_options, credentials, soap_header_extra_info).call(action_name, message: request_body)
+      end
+
+      protected
+
+      def action_name
+        raise NotImplementedError, 'Not implemented on abstract class'
+      end
+
+      def initialize
+        raise NotImplementedError, 'Not implemented on abstract class'
+      end
+
+      def request_body
+        raise NotImplementedError, 'Not implemented on abstract class'
+      end
+
+      def request_options
+        {}
+      end
+
+      def soap_header_extra_info
+        {}
+      end
+    end
+  end
+end
+  

data/lib/netsuite/actions/add.rb

@@ -1,7 +1,7 @@
 # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/add.html
 module NetSuite
   module Actions
-    class Add
+    class Add < AbstractAction
       include Support::Requests
 
       attr_reader :response_hash
@@ -12,10 +12,6 @@ module NetSuite
 
       private
 
-      def request(credentials={})
-        NetSuite::Configuration.connection({}, credentials).call(:add, :message => request_body)
-      end
-
       # <soap:Body>
       #   <platformMsgs:add>
       #     <platformMsgs:record xsi:type="listRel:Customer">
@@ -66,6 +62,10 @@ module NetSuite
         @response_hash ||= @response.to_hash[:add_response][:write_response]
       end
 
+      def action_name
+        :add
+      end
+
       def errors
         error_obj = response_hash[:status][:status_detail]
         error_obj = [error_obj] if error_obj.class == Hash

data/lib/netsuite/actions/attach_file.rb

@@ -1,6 +1,6 @@
 module NetSuite
   module Actions
-    class AttachFile
+    class AttachFile < AbstractAction
       include Support::Requests
 
       def initialize(object, file)
@@ -10,10 +10,6 @@ module NetSuite
 
       private
 
-      def request(credentials = {})
-        NetSuite::Configuration.connection({}, credentials).call(:attach, :message => request_body)
-      end
-
       # <soap:Body>
       #   <platformMsgs:attach>
       #     <platformCore:attachReference xsi:type="platformCore:AttachContactReference">
@@ -60,6 +56,10 @@ module NetSuite
         @response_hash ||= @response.to_hash[:attach_response][:write_response]
       end
 
+      def action_name
+        :attach
+      end
+
       def errors
         error_obj = response_hash[:status][:status_detail]
         error_obj = [error_obj] if error_obj.class == Hash

data/lib/netsuite/actions/delete.rb

@@ -1,7 +1,7 @@
 # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/delete.html
 module NetSuite
   module Actions
-    class Delete
+    class Delete < AbstractAction
       include Support::Requests
 
       def initialize(object = nil, options = {})
@@ -11,15 +11,6 @@ module NetSuite
 
       private
 
-      def request(credentials={})
-        NetSuite::Configuration.connection(
-          {namespaces: {
-            'xmlns:platformMsgs' => "urn:messages_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
-            'xmlns:platformCore' => "urn:core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com"
-          }}, credentials
-        ).call :delete, message: request_body
-      end
-
       def soap_type
         NetSuite::Support::Records.netsuite_type(@object)
       end
@@ -71,6 +62,19 @@ module NetSuite
         end
       end
 
+      def request_options
+        {
+          namespaces: {
+          'xmlns:platformMsgs' => "urn:messages_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
+          'xmlns:platformCore' => "urn:core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com"
+          }
+        }
+      end
+
+      def action_name
+        :delete
+      end
+
       def errors
         error_obj = response_hash[:status][:status_detail]
         error_obj = [error_obj] if error_obj.class == Hash

data/lib/netsuite/actions/delete_list.rb

@@ -1,6 +1,6 @@
 module NetSuite
   module Actions
-    class DeleteList
+    class DeleteList < AbstractAction
       include Support::Requests
 
       def initialize(klass, options = { })
@@ -10,15 +10,6 @@ module NetSuite
 
       private
 
-      def request(credentials={})
-        NetSuite::Configuration.connection(
-          {namespaces: {
-            'xmlns:platformMsgs' => "urn:messages_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
-            'xmlns:platformCore' => "urn:core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com"
-          }}, credentials
-        ).call :delete_list, message: request_body
-      end
-
       # <soap:Body>
       #   <platformMsgs:deleteList>
       #     <platformMsgs:baseRef internalId="1" type="customer" xsi:type="platformCore:RecordRef"/>
@@ -71,6 +62,19 @@ module NetSuite
         end
       end
 
+      def request_options
+        {
+          namespaces: {
+          'xmlns:platformMsgs' => "urn:messages_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
+          'xmlns:platformCore' => "urn:core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com"
+          }
+        }
+      end
+
+      def action_name
+        :delete_list
+      end
+
       def errors
         errors = response_list.select { |r| r[:status] && r[:status][:status_detail] }.map do |obj|
           error_obj = obj[:status][:status_detail]

data/lib/netsuite/actions/get.rb

@@ -1,7 +1,7 @@
 # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/get.html
 module NetSuite
   module Actions
-    class Get
+    class Get < AbstractAction
       include Support::Requests
 
       def initialize(klass, options = {})
@@ -11,15 +11,6 @@ module NetSuite
 
       private
 
-      def request(credentials={})
-        NetSuite::Configuration.connection(
-          {namespaces: {
-            'xmlns:platformMsgs' => "urn:messages_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
-            'xmlns:platformCore' => "urn:core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com"
-          }}, credentials
-        ).call :get, message: request_body
-      end
-
       def soap_type
         NetSuite::Support::Records.netsuite_type(@klass)
       end
@@ -56,6 +47,19 @@ module NetSuite
         @response_hash = @response.body[:get_response][:read_response]
       end
 
+      def request_options
+        {
+          namespaces: {
+          'xmlns:platformMsgs' => "urn:messages_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
+          'xmlns:platformCore' => "urn:core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com"
+          }
+        }
+      end
+
+      def action_name
+        :get
+      end
+
       module Support
 
         def self.included(base)

data/lib/netsuite/actions/get_all.rb

@@ -1,7 +1,7 @@
 # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/getAll.html
 module NetSuite
   module Actions
-    class GetAll
+    class GetAll < AbstractAction
       include Support::Requests
 
       def initialize(klass)
@@ -10,12 +10,6 @@ module NetSuite
 
       private
 
-      def request(credentials={})
-        NetSuite::Configuration.connection(
-          { element_form_default: :unqualified }, credentials
-        ).call(:get_all, message: request_body)
-      end
-
       # <soap:Body>
       #   <platformMsgs:getAll>
       #     <record>
@@ -49,6 +43,16 @@ module NetSuite
         @response_hash ||= @response.body[:get_all_response][:get_all_result]
       end
 
+      def request_options
+        {
+          element_form_default: :unqualified
+        }
+      end
+
+      def action_name
+        :get_all
+      end
+
       module Support
 
         def self.included(base)

data/lib/netsuite/actions/get_deleted.rb

@@ -1,6 +1,6 @@
 module NetSuite
   module Actions
-    class GetDeleted
+    class GetDeleted < AbstractAction
       include Support::Requests
 
       def initialize(object = nil, options = {})
@@ -10,15 +10,6 @@ module NetSuite
 
       private
 
-      def request(credentials={})
-        NetSuite::Configuration.connection(
-          {namespaces: {
-            'xmlns:platformMsgs' => "urn:messages_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
-            'xmlns:platformCore' => "urn:core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com"
-          }}, credentials
-        ).call :get_deleted, message: request_body
-      end
-
       def soap_type
         NetSuite::Support::Records.netsuite_type(@object)
       end
@@ -72,6 +63,19 @@ module NetSuite
         @response_body ||= response_hash[:get_deleted_result]
       end
 
+      def request_options
+        {
+          namespaces: {
+            'xmlns:platformMsgs' => "urn:messages_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
+            'xmlns:platformCore' => "urn:core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com"
+          }
+        }
+      end
+
+      def action_name
+        :get_deleted
+      end
+
       module Support
         def self.included(base)
           base.extend(ClassMethods)

data/lib/netsuite/actions/get_list.rb

@@ -1,7 +1,7 @@
 # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/getList.html
 module NetSuite
   module Actions
-    class GetList
+    class GetList < AbstractAction
       include Support::Requests
 
       def initialize(klass, options = { })
@@ -11,10 +11,6 @@ module NetSuite
 
       private
 
-      def request(credentials={})
-        NetSuite::Configuration.connection({}, credentials).call(:get_list, :message => request_body)
-      end
-
       def request_body
         # list of all netsuite types; useful for debugging
         # https://webservices.netsuite.com/xsd/platform/v2014_1_0/coreTypes.xsd
@@ -64,6 +60,10 @@ module NetSuite
         @response_body
       end
 
+      def action_name
+        :get_list
+      end
+
       def success?
         # each returned record has its own status; 
         if @options[:allow_incomplete] 

data/lib/netsuite/actions/get_select_value.rb

@@ -1,7 +1,7 @@
 # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/getSelectValue.html
 module NetSuite
   module Actions
-    class GetSelectValue
+    class GetSelectValue < AbstractAction
       include Support::Requests
 
       def initialize(klass, options = {})
@@ -11,13 +11,8 @@ module NetSuite
 
       private
 
-      def request(credentials={})
-        NetSuite::Configuration.connection(
-          {namespaces: {
-            'xmlns:platformMsgs' => "urn:messages_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
-            'xmlns:platformCore' => "urn:core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com"
-          }}, credentials
-        ).call :get_select_value, :message => @options
+      def request_body
+        @options
       end
 
       def success?
@@ -32,6 +27,19 @@ module NetSuite
         @response_hash = @response.body[:get_select_value_response][:get_select_value_result]
       end
 
+      def request_options
+        {
+          namespaces: {
+            'xmlns:platformMsgs' => "urn:messages_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
+            'xmlns:platformCore' => "urn:core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com"
+          }
+        }
+      end
+
+      def action_name
+        :get_select_value
+      end
+
       module Support
 
         def self.included(base)

data/lib/netsuite/actions/initialize.rb

@@ -1,7 +1,7 @@
 # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/initializeinitializeList.html
 module NetSuite
   module Actions
-    class Initialize
+    class Initialize < AbstractAction
       include Support::Requests
 
       def initialize(klass, object)
@@ -9,16 +9,6 @@ module NetSuite
         @object = object
       end
 
-      def request(credentials={})
-        NetSuite::Configuration.connection(
-          {namespaces: {
-            'xmlns:platformMsgs'    => "urn:messages_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
-            'xmlns:platformCore'    => "urn:core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
-            'xmlns:platformCoreTyp' => "urn:types.core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
-          }}, credentials
-        ).call :initialize, :message => request_body
-      end
-
       # <platformMsgs:initializeRecord>
       #   <platformCore:type>invoice</platformCore:type>
       #   <platformCore:reference internalId="1513" type="salesOrder">
@@ -52,6 +42,20 @@ module NetSuite
         @response_body ||= response_hash[:record]
       end
 
+      def request_options
+        {
+          namespaces: {
+            'xmlns:platformMsgs'    => "urn:messages_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
+            'xmlns:platformCore'    => "urn:core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
+            'xmlns:platformCoreTyp' => "urn:types.core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
+          }
+        }
+      end
+
+      def action_name
+        :initialize
+      end
+
       module Support
 
         def self.included(base)

data/lib/netsuite/actions/search.rb

@@ -1,7 +1,7 @@
 # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/search.html
 module NetSuite
   module Actions
-    class Search
+    class Search < AbstractAction
       include Support::Requests
 
       def initialize(klass, options = { })
@@ -18,24 +18,6 @@ module NetSuite
       end
 
       private
-      def request(credentials={})
-        # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/SettingSearchPreferences.html
-        # https://webservices.netsuite.com/xsd/platform/v2012_2_0/messages.xsd
-
-        preferences = NetSuite::Configuration.auth_header(credentials)
-          .update(NetSuite::Configuration.soap_header)
-          .merge(
-            (@options.delete(:preferences) || {}).inject({'platformMsgs:SearchPreferences' => {}}) do |h, (k, v)|
-              h['platformMsgs:SearchPreferences'][NetSuite::Utilities::Strings.lower_camelcase(k.to_s)] = v
-              h
-            end
-          )
-
-        NetSuite::Configuration
-          .connection({ soap_header: preferences }, credentials)
-          .call (@options.has_key?(:search_id)? :search_more_with_id : :search), :message => request_body
-      end
-
       # basic search XML
 
       # <soap:Body>
@@ -239,6 +221,21 @@ module NetSuite
         end[:search_result]
       end
 
+      def action_name
+        @options.has_key?(:search_id)? :search_more_with_id : :search
+      end
+
+      def soap_header_extra_info
+        # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/SettingSearchPreferences.html
+        # https://webservices.netsuite.com/xsd/platform/v2012_2_0/messages.xsd
+
+        (@options.delete(:preferences) || {})
+          .inject({'platformMsgs:SearchPreferences' => {}}) do |h, (k, v)|
+            h['platformMsgs:SearchPreferences'][NetSuite::Utilities::Strings.lower_camelcase(k.to_s)] = v
+            h
+          end
+      end
+
       def success?
         @success ||= search_result[:status][:@is_success] == 'true'
       end

data/lib/netsuite/actions/update.rb

@@ -1,7 +1,7 @@
 # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/update.html
 module NetSuite
   module Actions
-    class Update
+    class Update < AbstractAction
       include Support::Requests
 
       attr_reader :response_hash
@@ -11,10 +11,6 @@ module NetSuite
         @attributes = attributes
       end
 
-      def request(credentials={})
-        NetSuite::Configuration.connection({}, credentials).call :update, :message => request_body
-      end
-
       # <platformMsgs:update>
       #   <platformMsgs:record internalId="980" xsi:type="listRel:Customer">
       #     <listRel:companyName>Shutter Fly Corporation</listRel:companyName>
@@ -69,6 +65,10 @@ module NetSuite
         end
       end
 
+      def action_name
+        :update
+      end
+
       module Support
         def update(options = {}, credentials={})
           options[:internal_id] = internal_id if respond_to?(:internal_id) && internal_id

data/lib/netsuite/actions/update_list.rb

@@ -1,7 +1,7 @@
 # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/updateList.html
 module NetSuite
   module Actions
-    class UpdateList
+    class UpdateList < AbstractAction
       include Support::Requests
 
       def initialize(*objects)
@@ -10,12 +10,6 @@ module NetSuite
 
       private
 
-      def request(credentials={})
-        NetSuite::Configuration.connection(
-          { element_form_default: :unqualified }, credentials
-        ).call(:update_list, message: request_body)
-      end
-
       # <soap:Body>
       #   <updateList>
       #     <record xsi:type="listRel:Customer" externalId="ext1">
@@ -79,6 +73,16 @@ module NetSuite
         @success ||= response_hash.all? { |h| h[:status][:@is_success] == 'true' }
       end
 
+      def request_options
+        {
+          element_form_default: :unqualified
+        }
+      end
+
+      def action_name
+        :update_list
+      end
+
       module Support
 
         def self.included(base)

data/lib/netsuite/actions/upsert.rb

@@ -1,7 +1,7 @@
 # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/upsert.html
 module NetSuite
   module Actions
-    class Upsert
+    class Upsert < AbstractAction
       include Support::Requests
 
       attr_reader :response_hash
@@ -12,10 +12,6 @@ module NetSuite
 
       private
 
-      def request(credentials={})
-        NetSuite::Configuration.connection({}, credentials).call :upsert, :message => request_body
-      end
-
       # <soap:Body>
       #   <platformMsgs:upsert>
       #     <platformMsgs:record xsi:type="listRel:Customer">
@@ -68,6 +64,10 @@ module NetSuite
         end
       end
 
+      def action_name
+        :upsert
+      end
+
       module Support
         def upsert(credentials={})
           response = NetSuite::Actions::Upsert.call([self], credentials)

data/lib/netsuite/actions/upsert_list.rb

@@ -1,7 +1,7 @@
 # https://system.netsuite.com/help/helpcenter/en_US/Output/Help/SuiteCloudCustomizationScriptingWebServices/SuiteTalkWebServices/upsertList.html
 module NetSuite
   module Actions
-    class UpsertList
+    class UpsertList < AbstractAction
       include Support::Requests
 
       def initialize(*objects)
@@ -10,12 +10,6 @@ module NetSuite
 
       private
 
-      def request(credentials={})
-        NetSuite::Configuration.connection(
-          { element_form_default: :unqualified }, credentials
-        ).call(:upsert_list, message: request_body)
-      end
-
       # <soap:Body>
       #   <upsertList>
       #     <record xsi:type="listRel:Customer" externalId="ext1">
@@ -75,6 +69,16 @@ module NetSuite
         @success ||= response_hash.all? { |h| h[:status][:@is_success] == 'true' }
       end
 
+      def request_options
+        {
+          element_form_default: :unqualified
+        }
+      end
+
+      def action_name
+        :upsert_list
+      end
+
       module Support
 
         def self.included(base)

data/lib/netsuite/configuration.rb

@@ -18,21 +18,21 @@ module NetSuite
       end
     end
 
-    def connection(params={}, credentials={})
+    def connection(params={}, credentials={}, soap_header_extra_info={})
       client = Savon.client({
         wsdl: cached_wsdl || wsdl,
         endpoint: endpoint,
         read_timeout: read_timeout,
         open_timeout: open_timeout,
         namespaces: namespaces,
-        soap_header: auth_header(credentials).update(soap_header),
+        soap_header: auth_header(credentials).update(soap_header).merge(soap_header_extra_info),
         pretty_print_xml: true,
         filters: filters,
         logger: logger,
         log_level: log_level,
         log: !silent, # turn off logging entirely if configured
-        proxy: proxy,
       }.update(params))
+      client.globals.proxy(proxy) if proxy
       cache_wsdl(client)
       return client
     end

data/lib/netsuite/records/estimate_item.rb

@@ -13,7 +13,14 @@ module NetSuite
 
       field :custom_field_list, CustomFieldList
 
-      record_refs :item, :job, :price, :tax_code, :units
+      record_refs :department,
+        :item,
+        :job,
+        :klass,
+        :location,
+        :price,
+        :tax_code,
+        :units
 
       def initialize(attributes_or_record = {})
         case attributes_or_record

data/lib/netsuite/records/invoice.rb

@@ -25,7 +25,7 @@ module NetSuite
         :other_ref_num, :partners_list, :rev_rec_end_date,
         :rev_rec_on_rev_commitment, :rev_rec_schedule, :rev_rec_start_date, :revenue_status, :sales_effective_date,
         :sales_group, :sales_team_list, :ship_date, :ship_group_list,
-        :shipping_cost, :shipping_tax_1_rate, :shipping_tax_2_rate, :shipping_tax_code, :source, :start_date,
+        :shipping_cost, :shipping_tax_1_rate, :shipping_tax_2_rate, :source, :start_date,
         :status, :sync_partner_teams, :sync_sales_teams, :tax_2_total,
         :tax_total, :time_disc_amount, :time_disc_print, :time_disc_rate, :time_disc_tax_1_amt, :time_disc_taxable,
         :time_discount, :time_list, :time_tax_code, :time_tax_rate_1, :time_tax_rate_2, :to_be_emailed, :to_be_faxed,
@@ -138,7 +138,8 @@ module NetSuite
 
       record_refs :account, :bill_address_list, :custom_form, :department, :entity, :klass, :partner,
                   :posting_period, :ship_address_list, :terms, :location, :sales_rep, :tax_item, :created_from,
-                  :ship_method, :lead_source, :promo_code, :subsidiary, :currency, :approval_status, :job, :discount_item
+                  :ship_method, :lead_source, :promo_code, :subsidiary, :currency, :approval_status, :job, :discount_item,
+                  :shipping_tax_code
 
       attr_reader   :internal_id
       attr_accessor :external_id

data/lib/netsuite/records/vendor_return_authorization.rb

@@ -9,7 +9,7 @@ module NetSuite
 
       actions :get, :get_list, :add, :initialize, :delete, :update, :upsert, :search
 
-      fields :billing_address, :created_date, :memo, :tran_date, :tran_id
+      fields :billing_address, :created_date, :memo, :tran_date, :tran_id, :klass
 
       record_refs :bill_address_list, :department, :entity, :location
 

data/lib/netsuite/records/vendor_return_authorization_item.rb

@@ -8,7 +8,7 @@ module NetSuite
 
       fields :amortization_end_date, :amortization_residual, :amount, :bin_numbers, :description,
       :gross_amt, :is_billable, :is_closed, :is_drop_shipment, :line, :order_line, :quantity,
-      :rate, :vendor_name
+      :rate, :vendor_name, :klass
 
       field :inventory_detail, InventoryDetail
 

data/lib/netsuite/support/requests.rb

@@ -22,10 +22,6 @@ module NetSuite
 
       private
 
-      def request
-        raise NotImplementedError, 'Please implement a #request method'
-      end
-
       def build_response
         Response.new(success: success?, header: response_header, body: response_body, errors: response_errors)
       end

data/lib/netsuite/support/search_result.rb

@@ -48,7 +48,8 @@ module NetSuite
             end
           elsif response.body.has_key? :search_row_list
             # advanced search results
-            record_list = response.body[:search_row_list][:search_row]
+            record_list = response.body[:search_row_list]
+            record_list = record_list ? record_list[:search_row] : []
             record_list = [record_list] unless record_list.is_a?(Array)
 
             record_list.each do |record|

data/lib/netsuite/utilities.rb

@@ -56,12 +56,12 @@ module NetSuite
       ns_record
     end
 
-    def netsuite_server_time
-      server_time_response = NetSuite::Utilities.backoff { NetSuite::Configuration.connection.call(:get_server_time) }
+    def netsuite_server_time(credentials={})
+      server_time_response = NetSuite::Utilities.backoff { NetSuite::Configuration.connection({}, credentials).call(:get_server_time) }
       server_time_response.body[:get_server_time_response][:get_server_time_result][:server_time]
     end
 
-    def netsuite_data_center_urls(account_id)
+    def netsuite_data_center_urls(account_id, credentials={})
       data_center_call_response = NetSuite::Configuration.connection({
         # NOTE force a production WSDL so the sandbox settings are ignored
         #      as of 1/20/18 NS will start using the account ID to determine
@@ -75,7 +75,7 @@ module NetSuite
         },
 
         soap_header: {}
-      }).call(:get_data_center_urls, message: {
+      }, credentials).call(:get_data_center_urls, message: {
         'platformMsgs:account' => account_id
       })
 

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module NetSuite
-  VERSION = '0.9.2'
+  VERSION = '0.9.3'
 end

data/lib/netsuite.rb

@@ -48,6 +48,7 @@ module NetSuite
   end
 
   module Actions
+    autoload :AbstractAction,    'netsuite/actions/abstract_action'
     autoload :Add,              'netsuite/actions/add'
     autoload :AttachFile,       'netsuite/actions/attach_file'
     autoload :Delete,           'netsuite/actions/delete'

data/spec/netsuite/actions/search_spec.rb

@@ -5,22 +5,29 @@ describe NetSuite::Actions::Search do
   after(:all) { savon.unmock! }
 
   it "handles custom auth credentials" do
-    allow(NetSuite::Configuration).to receive(:connection).and_return(double().as_null_object)
-
     credentials = {
       email: 'fake@domain.com',
       password: 'fake'
     }
-    NetSuite::Records::Customer.search({}, credentials)
 
-    expect(NetSuite::Configuration).to have_received(:connection).with({:soap_header=>{
+    connection = NetSuite::Configuration.connection({}, credentials)
+
+    soap_header = {
       "platformMsgs:passport"=>{
         "platformCore:email"=>"fake@domain.com",
         "platformCore:password"=>"fake",
         "platformCore:account"=>"1234",
         "platformCore:role"=>{:@internalId=>"3"}
-      }, "platformMsgs:SearchPreferences"=>{}}}, credentials
-    )
+      }
+    }
+
+    expect(connection.instance_variable_get('@globals')[:soap_header]).to eq soap_header
+
+    allow(NetSuite::Configuration).to receive(:connection).and_return(double().as_null_object)
+
+    NetSuite::Records::Customer.search({}, credentials)
+
+    expect(NetSuite::Configuration).to have_received(:connection).with({}, credentials, { "platformMsgs:SearchPreferences"=>{} })
   end
 
   context "search class name" do
@@ -193,30 +200,6 @@ describe NetSuite::Actions::Search do
       expect(search.results.first.location_re_order_point).to eq('2565.0')
       expect(search.results.first.location_quantity_on_order).to eq('40000.0')
     end
-
-    it "should handle an ID search with basic non-field result columns" do
-      response = File.read('spec/support/fixtures/search/saved_search_item_2.xml')
-      savon.expects(:search)
-        .with(message: {
-          "searchRecord"=>{
-            "@xsi:type"      =>"listAcct:ItemSearchAdvanced",
-            "@savedSearchId" =>42,
-            :content!        =>{"listAcct:criteria"=>{}},
-          }
-        }).returns(response)
-
-      search = NetSuite::Records::InventoryItem.search(saved: 42)
-
-      results = search.results
-      custom_fields = results.map do |record|
-        record.custom_field_list.custom_fields.map(&:internal_id)
-      end.flatten.uniq
-      [
-        :location_quantity_available,
-        :location_re_order_point,
-        :location_quantity_on_order,
-      ].each {|field| expect(custom_fields).to include(field)}
-    end
   end
 
   context "advanced search" do

data/spec/netsuite/configuration_spec.rb

@@ -519,13 +519,21 @@ describe NetSuite::Configuration do
       expect(config.proxy).to be_nil
     end
 
+    it 'does not pass in nil proxy to savon' do
+      connection = config.connection
+
+      expect(connection.globals.include?(:proxy)).to eql(false)
+    end
+
     it 'can be set with proxy=' do
       config.proxy = "https://my-proxy"
 
       expect(config.proxy).to eql("https://my-proxy")
 
       # ensure no exception is raised
-      config.connection
+      connection = config.connection
+
+      expect(connection.globals.include?(:proxy)).to eql(true)
     end
 
     it 'can be set with proxy(value)' do

data/spec/netsuite/records/estimate_item_spec.rb

@@ -16,7 +16,14 @@ describe NetSuite::Records::EstimateItem do
 
   it 'has all the right record refs' do
     [
-      :item, :job, :price, :tax_code, :units
+      :department,
+      :item,
+      :job,
+      :klass,
+      :location,
+      :price,
+      :tax_code,
+      :units,
     ].each do |record_ref|
       expect(item).to have_record_ref(record_ref)
     end

data/spec/netsuite/records/invoice_spec.rb

@@ -21,7 +21,7 @@ describe NetSuite::Records::Invoice do
       :other_ref_num, :partners_list, :rev_rec_end_date,
       :rev_rec_on_rev_commitment, :rev_rec_schedule, :rev_rec_start_date, :revenue_status, :sales_effective_date,
       :sales_group, :sales_team_list, :ship_address, :ship_date, :ship_group_list,
-      :shipping_cost, :shipping_tax_1_rate, :shipping_tax_2_rate, :shipping_tax_code, :source, :start_date,
+      :shipping_cost, :shipping_tax_1_rate, :shipping_tax_2_rate, :source, :start_date,
       :status, :sync_partner_teams, :sync_sales_teams, :tax_2_total,
       :tax_total, :time_disc_amount, :time_disc_print, :time_disc_rate, :time_disc_tax_1_amt, :time_disc_taxable,
       :time_discount, :time_list, :time_tax_code, :time_tax_rate_1, :time_tax_rate_2, :to_be_emailed, :to_be_faxed,
@@ -151,7 +151,8 @@ describe NetSuite::Records::Invoice do
   it 'has the right record_refs' do
     [
       :account, :bill_address_list, :job, :custom_form, :department, :entity, :klass, :posting_period, :ship_address_list, :terms,
-      :created_from, :location, :sales_rep, :ship_method, :tax_item, :partner, :lead_source, :promo_code, :subsidiary, :discount_item
+      :created_from, :location, :sales_rep, :ship_method, :tax_item, :partner, :lead_source, :promo_code, :subsidiary, :discount_item,
+      :shipping_tax_code
     ].each do |record_ref|
       expect(invoice).to have_record_ref(record_ref)
     end

data/spec/netsuite/support/search_result_spec.rb

@@ -22,6 +22,23 @@ describe NetSuite::Support::SearchResult do
         results = described_class.new(response, NetSuite::Actions::Search, {}).results
         expect(results).to eq []
       end
+
+      it 'returns empty search_row_list' do
+        response_body = {
+          :status => {:@is_success=>"true"},
+          :total_records => "242258",
+          :page_size => "10",
+          :total_pages => "24226",
+          :page_index => "99",
+          :search_id => "WEBSERVICES_4132604_SB1_051620191060155623420663266_336cbf12",
+          :search_row_list => nil,
+          :"@xmlns:platform_core" => "urn:core_2016_2.platform.webservices.netsuite.com"
+        }
+        response = NetSuite::Response.new(body: response_body)
+
+        results = described_class.new(response, NetSuite::Actions::Search, {}).results
+        expect(results).to eq []
+      end
     end
 
     it 'handles a recordList with a single element' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netsuite
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.9.3
 platform: ruby
 authors:
 - Ryan Moran
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-23 00:00:00.000000000 Z
+date: 2023-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -83,6 +83,7 @@ files:
 - README.md
 - Rakefile
 - lib/netsuite.rb
+- lib/netsuite/actions/abstract_action.rb
 - lib/netsuite/actions/add.rb
 - lib/netsuite/actions/attach_file.rb
 - lib/netsuite/actions/delete.rb