netsuite 0.9.0 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53e37d7468526bab26109064a50e3d393735e7fbb0758b56867de985e3230170
-  data.tar.gz: 318ed153297d54f2d19c821677e5d8bfffe89d7f688ea31aa324f93e1293f411
+  metadata.gz: 5aad2f60c62b40aaa3e86460dc81283d470a3293d1568fe41d78e431b3d6ec61
+  data.tar.gz: 411b9bbfaa28f9c76ad886245afe83334758d5b3b360d70e405bd1897a0c1a53
 SHA512:
-  metadata.gz: 0df38ba22afe3361daace766b033e947f20962ab0ac6d0f336e706b2bbd06bfae091478c856ce9b33ff18f28f07a3e796a774d1a78a1fc6766348538b89afb0a
-  data.tar.gz: c3021d78e3718dd30332accc69de70e3f88df394e33648a49eb995d4d9a5177ad669c5fdb269485a75cd29c13a186c5b863e84a83dfee8eb88ea7c7ba4c9765e
+  metadata.gz: 72ace4cda9656efd8592ed824ccb788c136aac912c5d9ec2fac38b817f00658979a29dae19c7a298108be49c9d1c386598a7476e05a61a25a05d18a53232c930
+  data.tar.gz: 3fb702a8c3cca1c6896603769027022136b38af973820ae7f098d68f8ec0e4f07f45175d4b4cfd5fb8b189079f7a5ba5255becf166d0640bee5d067430ac3fe4

data/Gemfile

@@ -11,3 +11,10 @@ if ENV.fetch('BUNDLE_TZINFO', 'false') == 'true'
   # optional dependency for more accurate timezone conversion
   gem 'tzinfo', '>= 1.2.5'
 end
+
+if RUBY_VERSION >= '3.1.0'
+  # Savon v2.13 adds a dependency on mail, which has an implicit dependency on
+  # net-smtp. Ruby 3.1 removed net-smtp as a default gem. mail v2.8.0.rc1 is the
+  # first to make that dependency explicit to support Ruby 3.1.
+  gem 'mail', '>= 2.8.0.rc1'
+end

data/HISTORY.md

@@ -2,7 +2,11 @@
 
 
 ### Added
+* Add `Configuration#multi_tenant!` for opting into multi-tentant support where configuration/caching is per-thread (#556)
+
 ### Fixed
+* Avoid Savon version `2.13.0` to prevent generating invalid envelopes. (#558, #563)
+
 ### Breaking Changes
 
 ## 0.9.0

data/README.md

@@ -159,6 +159,32 @@ NetSuite.configure do
 end
 ```
 
+### Multi-Tenancy
+
+If you're interacting with multiple NetSuite accounts, each in separate threads, you can enable multi-tenancy to prevent your configuration and caches from being shared between threads.
+
+From your main thread, you'd want to enable multi-tenancy:
+
+```ruby
+NetSuite.configure do
+  multi_tentant!
+end
+```
+
+Note that `multi_tenant!` is a special configuration option which is _not_ effected by `reset!`.
+
+Then in each child thread, you'd perform any configuration specific to the NetSuite account you're interacting with for that thread, all of which will be specific to that thread only:
+
+```ruby
+NetSuite.configure do
+  reset!
+
+  account ENV['NETSUITE_ACCOUNT']
+
+  # The rest of your usual configuration...
+end
+```
+
 # Usage
 
 ## CRUD Operations

data/lib/netsuite/configuration.rb

@@ -11,7 +11,11 @@ module NetSuite
     end
 
     def attributes
-      Thread.current[:netsuite_gem_attributes] ||= {}
+      if multi_tenant?
+        Thread.current[:netsuite_gem_attributes] ||= {}
+      else
+        @attributes ||= {}
+      end
     end
 
     def connection(params={}, credentials={})
@@ -51,11 +55,19 @@ module NetSuite
     end
 
     def wsdl_cache
-      Thread.current[:netsuite_gem_wsdl_cache] ||= {}
+      if multi_tenant?
+        Thread.current[:netsuite_gem_wsdl_cache] ||= {}
+      else
+        @wsdl_cache ||= {}
+      end
     end
 
     def clear_wsdl_cache
-      Thread.current[:netsuite_gem_wsdl_cache] = {}
+      if multi_tenant?
+        Thread.current[:netsuite_gem_wsdl_cache] = {}
+      else
+        @wsdl_cache = {}
+      end
     end
 
     def cached_wsdl
@@ -83,7 +95,7 @@ module NetSuite
       if version
         self.api_version = version
       else
-        attributes[:api_version] ||= '2015_1'
+        attributes[:api_version] ||= '2016_2'
       end
     end
 
@@ -407,5 +419,13 @@ module NetSuite
         attributes[:proxy]
       end
     end
+
+    def multi_tenant!
+      @multi_tenant = true
+    end
+
+    def multi_tenant?
+      @multi_tenant
+    end
   end
 end

data/lib/netsuite/support/country.rb

@@ -240,6 +240,7 @@ module NetSuite
         'UA' => '_ukraine',
         'AE' => '_unitedArabEmirates',
         'GB' => '_unitedKingdom',
+        'UK' => '_unitedKingdom',
         'US' => '_unitedStates',
         'UY' => '_uruguay',
         'UM' => '_uSMinorOutlyingIslands',
@@ -280,12 +281,7 @@ module NetSuite
       end
 
       def iso_to_netsuite
-        # NOTE GB country code changed on 2016_1
-        if NetSuite::Configuration.api_version <= "2015_2"
-          ISO_TO_NETSUITE.merge({ 'GB' => '_unitedKingdomGB' })
-        else
-          ISO_TO_NETSUITE
-        end
+        ISO_TO_NETSUITE
       end
 
     end

data/lib/netsuite/utilities.rb

@@ -7,18 +7,31 @@ module NetSuite
     # TODO need structured logger for various statements
 
     def clear_cache!
-      Thread.current[:netsuite_gem_netsuite_get_record_cache] = {}
-      Thread.current[:netsuite_gem_netsuite_find_record_cache] = {}
+      if NetSuite::Configuration.multi_tenant?
+        Thread.current[:netsuite_gem_netsuite_get_record_cache] = {}
+        Thread.current[:netsuite_gem_netsuite_find_record_cache] = {}
+      else
+        @netsuite_get_record_cache = {}
+        @netsuite_find_record_cache = {}
+      end
 
       DataCenter.clear_cache!
     end
 
     def netsuite_get_record_cache
-      Thread.current[:netsuite_gem_netsuite_get_record_cache] ||= {}
+      if NetSuite::Configuration.multi_tenant?
+        Thread.current[:netsuite_gem_netsuite_get_record_cache] ||= {}
+      else
+        @netsuite_get_record_cache ||= {}
+      end
     end
 
     def netsuite_find_record_cache
-      Thread.current[:netsuite_gem_netsuite_find_record_cache] ||= {}
+      if NetSuite::Configuration.multi_tenant?
+        Thread.current[:netsuite_gem_netsuite_find_record_cache] ||= {}
+      else
+        @netsuite_find_record_cache ||= {}
+      end
     end
 
     def append_memo(ns_record, added_memo, opts = {})
@@ -112,6 +125,8 @@ module NetSuite
         exceptions_to_retry << OpenSSL::SSL::SSLErrorWaitReadable if defined?(OpenSSL::SSL::SSLErrorWaitReadable)
 
         # depends on the http library chosen
+        exceptions_to_retry << HTTPI::SSLError if defined?(HTTPI::SSLError)
+        exceptions_to_retry << HTTPI::TimeoutError if defined?(HTTPI::TimeoutError)
         exceptions_to_retry << HTTPClient::TimeoutError if defined?(HTTPClient::TimeoutError)
         exceptions_to_retry << HTTPClient::ConnectTimeoutError if defined?(HTTPClient::ConnectTimeoutError)
         exceptions_to_retry << HTTPClient::ReceiveTimeoutError if defined?(HTTPClient::ReceiveTimeoutError)

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module NetSuite
-  VERSION = '0.9.0'
+  VERSION = '0.9.2'
 end

data/netsuite.gemspec

@@ -3,8 +3,8 @@ require File.expand_path('../lib/netsuite/version', __FILE__)
 
 Gem::Specification.new do |gem|
   gem.licenses      = ['MIT']
-  gem.authors       = ['Ryan Moran', 'Michael Bianco']
-  gem.email         = ['ryan.moran@gmail.com', 'mike@mikebian.co']
+  gem.authors       = ['Ryan Moran', 'Michael Bianco', 'Chris Gunther']
+  gem.email         = ['ryan.moran@gmail.com', 'mike@mikebian.co', 'chris@room118solutions.com']
   gem.description   = %q{NetSuite SuiteTalk API Wrapper}
   gem.summary       = %q{NetSuite SuiteTalk API (SOAP) Wrapper}
   gem.homepage      = 'https://github.com/NetSweet/netsuite'
@@ -20,8 +20,8 @@ Gem::Specification.new do |gem|
   gem.metadata['mailing_list_uri'] = 'http://opensuite-slackin.herokuapp.com'
   gem.metadata['rubygems_mfa_required'] = 'true'
 
-  gem.add_dependency 'savon', '>= 2.3.0'
+  gem.add_dependency 'savon', '>= 2.3.0', '!= 2.13.0'
 
-  gem.add_development_dependency 'rspec', '~> 3.11.0'
+  gem.add_development_dependency 'rspec', '~> 3.12.0'
   gem.add_development_dependency 'rake', '~> 12.3.3'
 end

data/spec/netsuite/configuration_spec.rb

@@ -15,18 +15,42 @@ describe NetSuite::Configuration do
       expect(config.attributes).to be_empty
     end
 
-    it 'ensures that attributes are not shared between threads' do
+    it 'treats attributes as shared/global in default single tenant mode' do
       config.attributes[:blah] = 'something'
       expect(config.attributes[:blah]).to eq('something')
 
       thread = Thread.new {
+        expect(config.attributes[:blah]).to eq('something')
+
         config.attributes[:blah] = 'something_else'
         expect(config.attributes[:blah]).to eq('something_else')
       }
 
       thread.join
 
-      expect(config.attributes[:blah]).to eq('something')
+      expect(config.attributes[:blah]).to eq('something_else')
+    end
+
+    it 'treats attributes as thread-local in multi-tenant mode, which each thread starting with empty attributes' do
+      begin
+        config.multi_tenant!
+
+        config.attributes[:blah] = 'something'
+        expect(config.attributes[:blah]).to eq('something')
+
+        thread = Thread.new {
+          expect(config.attributes[:blah]).to be_nil
+
+          config.attributes[:blah] = 'something_else'
+          expect(config.attributes[:blah]).to eq('something_else')
+        }
+
+        thread.join
+
+        expect(config.attributes[:blah]).to eq('something')
+      ensure
+        config.instance_variable_set(:@multi_tenant, false)
+      end
     end
   end
 
@@ -101,7 +125,7 @@ describe NetSuite::Configuration do
 
     context 'when the wsdl has not been set' do
       it 'returns a path to the WSDL to use for the API' do
-        expect(config.wsdl).to eq("https://webservices.netsuite.com/wsdl/v2015_1_0/netsuite.wsdl")
+        expect(config.wsdl).to eq("https://webservices.netsuite.com/wsdl/v2016_2_0/netsuite.wsdl")
       end
     end
 
@@ -351,8 +375,8 @@ describe NetSuite::Configuration do
 
   describe '#api_version' do
     context 'when no api_version is defined' do
-      it 'defaults to 2015_1' do
-        expect(config.api_version).to eq('2015_1')
+      it 'defaults to 2016_2' do
+        expect(config.api_version).to eq('2016_2')
       end
     end
   end

data/spec/netsuite/records/address_spec.rb

@@ -134,16 +134,6 @@ describe NetSuite::Records::Address do
       expect(addressbook.country.to_record).to eql ""
       expect(addressbook.to_record["platformCommon:country"]).to eql ""
     end
-
-    it 'changes the netsuite identifier based on the current API version' do
-      NetSuite::Configuration.api_version = '2015_1'
-      addressbook = NetSuite::Records::Address.new country: "GB"
-      expect(addressbook.to_record["platformCommon:country"]).to eql "_unitedKingdomGB"
-      NetSuite::Configuration.api_version = '2018_1'
-
-      addressbook = NetSuite::Records::Address.new country: "GB"
-      expect(addressbook.to_record["platformCommon:country"]).to eql "_unitedKingdom"
-    end
   end
 
 end

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: netsuite
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 0.9.2
 platform: ruby
 authors:
 - Ryan Moran
 - Michael Bianco
-autorequire:
+- Chris Gunther
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-07-11 00:00:00.000000000 Z
+date: 2022-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -18,6 +19,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 2.13.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -25,20 +29,23 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 2.13.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.11.0
+        version: 3.12.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.11.0
+        version: 3.12.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -57,6 +64,7 @@ description: NetSuite SuiteTalk API Wrapper
 email:
 - ryan.moran@gmail.com
 - mike@mikebian.co
+- chris@room118solutions.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -616,7 +624,7 @@ metadata:
   changelog_uri: https://github.com/netsweet/netsuite/blob/master/HISTORY.md
   mailing_list_uri: http://opensuite-slackin.herokuapp.com
   rubygems_mfa_required: 'true'
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -631,8 +639,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.11
-signing_key:
+rubygems_version: 3.1.6
+signing_key: 
 specification_version: 4
 summary: NetSuite SuiteTalk API (SOAP) Wrapper
 test_files: