netsuite 0.8.9 → 0.8.12

data/lib/netsuite/support/records.rb

@@ -6,8 +6,8 @@ module NetSuite
 
       def to_record
         attributes.reject { |k,v| self.class.read_only_fields.include?(k) || self.class.search_only_fields.include?(k) }.inject({}) do |hash, (k,v)|
-          kname = "#{record_namespace}:"
-          kname += k == :klass ? 'class' : k.to_s.lower_camelcase
+          kname = "#{v.is_a?(NetSuite::Records::NullFieldList) ? v.record_namespace : record_namespace}:"
+          kname += k == :klass ? 'class' : NetSuite::Utilities::Strings.lower_camelcase(k.to_s)
 
           to_attributes!(hash, kname, v)
 
@@ -38,18 +38,26 @@ module NetSuite
         if v.kind_of?(NetSuite::Records::RecordRef) && v.type
           hash[:attributes!] ||= {}
           hash[:attributes!][kname] ||= {}
-          hash[:attributes!][kname]['type'] = v.type.lower_camelcase
+          hash[:attributes!][kname]['type'] = NetSuite::Utilities::Strings.lower_camelcase(v.type)
         end
 
         if v.kind_of?(NetSuite::Records::CustomRecordRef) && v.type_id
           hash[:attributes!] ||= {}
           hash[:attributes!][kname] ||= {}
-          hash[:attributes!][kname]['typeId'] = v.type_id.lower_camelcase
+          hash[:attributes!][kname]['typeId'] = NetSuite::Utilities::Strings.lower_camelcase(v.type_id)
         end
       end
 
       def record_type
-        "#{record_namespace}:#{self.class.to_s.split('::').last}"
+        "#{record_namespace}:#{record_type_without_namespace}"
+      end
+
+      def netsuite_type
+        Records.netsuite_type(self)
+      end
+
+      def record_type_without_namespace
+        Records.record_type_without_namespace(self)
       end
 
       def refresh(credentials = {})
@@ -67,6 +75,15 @@ module NetSuite
         self
       end
 
+      def self.netsuite_type(obj)
+        NetSuite::Utilities::Strings.lower_camelcase(record_type_without_namespace(obj))
+      end
+
+      def self.record_type_without_namespace(obj)
+        klass = obj.is_a?(Class) ? obj : obj.class
+        "#{klass.to_s.split('::').last}"
+      end
+
     end
   end
 end

data/lib/netsuite/support/sublist.rb

@@ -35,7 +35,7 @@ module NetSuite
       end
 
       def to_record
-        rec = { "#{record_namespace}:#{sublist_key.to_s.lower_camelcase}" => send(self.sublist_key).map(&:to_record) }
+        rec = { "#{record_namespace}:#{NetSuite::Utilities::Strings.lower_camelcase(sublist_key.to_s)}" => send(self.sublist_key).map(&:to_record) }
 
         if !replace_all.nil?
           rec["#{record_namespace}:replaceAll"] = !!replace_all

data/lib/netsuite/utilities/strings.rb

@@ -0,0 +1,15 @@
+module NetSuite
+  module Utilities
+    module Strings
+      class << self
+        def lower_camelcase(obj)
+          str = obj.is_a?(String) ? obj.dup : obj.to_s
+          str.gsub!(/\/(.?)/) { "::#{$1.upcase}" }
+          str.gsub!(/(?:_+|-+)([a-z]|[0-9])/) { $1.upcase }
+          str.gsub!(/(\A|\s)([A-Z])/) { $1 + $2.downcase }
+          str
+        end
+      end
+    end
+  end
+end

data/lib/netsuite/utilities.rb

@@ -103,6 +103,10 @@ module NetSuite
         exceptions_to_retry << OpenSSL::SSL::SSLErrorWaitReadable if defined?(OpenSSL::SSL::SSLErrorWaitReadable)
 
         # depends on the http library chosen
+        exceptions_to_retry << HTTPClient::TimeoutError if defined?(HTTPClient::TimeoutError)
+        exceptions_to_retry << HTTPClient::ConnectTimeoutError if defined?(HTTPClient::ConnectTimeoutError)
+        exceptions_to_retry << HTTPClient::ReceiveTimeoutError if defined?(HTTPClient::ReceiveTimeoutError)
+        exceptions_to_retry << HTTPClient::SendTimeoutError if defined?(HTTPClient::SendTimeoutError)
         exceptions_to_retry << Excon::Error::Timeout if defined?(Excon::Error::Timeout)
         exceptions_to_retry << Excon::Error::Socket if defined?(Excon::Error::Socket)
 
@@ -170,6 +174,7 @@ module NetSuite
       ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::DiscountItem, ns_item_internal_id, opts)
       ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::OtherChargeSaleItem, ns_item_internal_id, opts)
       ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::ServiceSaleItem, ns_item_internal_id, opts)
+      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::ServiceResaleItem, ns_item_internal_id, opts)
       ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::GiftCertificateItem, ns_item_internal_id, opts)
       ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::KitItem, ns_item_internal_id, opts)
       ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::SerializedInventoryItem, ns_item_internal_id, opts)

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module NetSuite
-  VERSION = '0.8.9'
+  VERSION = '0.8.12'
 end

data/lib/netsuite.rb

@@ -5,9 +5,9 @@ require 'netsuite/version'
 require 'netsuite/errors'
 require 'netsuite/utilities'
 require 'netsuite/utilities/data_center'
+require 'netsuite/utilities/strings'
 require 'netsuite/rest/utilities/roles'
 require 'netsuite/rest/utilities/request'
-require 'netsuite/core_ext/string/lower_camelcase'
 
 module NetSuite
   autoload :Configuration, 'netsuite/configuration'
@@ -49,6 +49,7 @@ module NetSuite
 
   module Actions
     autoload :Add,              'netsuite/actions/add'
+    autoload :AttachFile,       'netsuite/actions/attach_file'
     autoload :Delete,           'netsuite/actions/delete'
     autoload :DeleteList,       'netsuite/actions/delete_list'
     autoload :Get,              'netsuite/actions/get'
@@ -200,6 +201,7 @@ module NetSuite
     autoload :ItemGroup,                        'netsuite/records/item_group'
     autoload :ItemMember,                       'netsuite/records/item_member'
     autoload :ItemMemberList,                   'netsuite/records/item_member_list'
+    autoload :ItemOptionCustomField,            'netsuite/records/item_option_custom_field'
     autoload :ItemReceipt,                      'netsuite/records/item_receipt'
     autoload :ItemReceiptItemList,              'netsuite/records/item_receipt_item_list'
     autoload :ItemReceiptItem,                  'netsuite/records/item_receipt_item'
@@ -223,6 +225,7 @@ module NetSuite
     autoload :NonInventoryResaleItem,           'netsuite/records/non_inventory_resale_item'
     autoload :Note,                             'netsuite/records/note'
     autoload :NoteType,                         'netsuite/records/note_type'
+    autoload :NullFieldList,                    'netsuite/records/null_field_list'
     autoload :Opportunity,                      'netsuite/records/opportunity'
     autoload :OpportunityItem,                  'netsuite/records/opportunity_item'
     autoload :OpportunityItemList,              'netsuite/records/opportunity_item_list'
@@ -283,6 +286,8 @@ module NetSuite
     autoload :TransferOrder,                    'netsuite/records/transfer_order'
     autoload :TransferOrderItemList,            'netsuite/records/transfer_order_item_list'
     autoload :TransferOrderItem,                'netsuite/records/transfer_order_item'
+    autoload :Translation,                      'netsuite/records/translation'
+    autoload :TranslationList,                  'netsuite/records/translation_list'
     autoload :UnitsType,                        'netsuite/records/units_type'
     autoload :UnitsTypeUomList,                 'netsuite/records/units_type_uom_list'
     autoload :UnitsTypeUom,                     'netsuite/records/units_type_uom'

data/netsuite.gemspec

@@ -15,9 +15,10 @@ Gem::Specification.new do |gem|
   gem.name          = 'netsuite'
   gem.require_paths = ['lib']
   gem.version       = NetSuite::VERSION
+  gem.metadata['changelog_uri'] = 'https://github.com/netsweet/netsuite/blob/master/HISTORY.md'
 
-  gem.add_dependency 'savon', '>= 2.3.0', '<= 2.11.1'
+  gem.add_dependency 'savon', '>= 2.3.0'
 
-  gem.add_development_dependency 'rspec', '~> 3.10.0'
-  gem.add_development_dependency 'rake'
+  gem.add_development_dependency 'rspec', '~> 3.11.0'
+  gem.add_development_dependency 'rake', '~> 12.3.3'
 end

data/spec/netsuite/actions/add_spec.rb

@@ -114,4 +114,40 @@ describe NetSuite::Actions::Add do
     end
   end
 
+  context 'File' do
+    let(:file) do
+      NetSuite::Records::File.new(name: 'foo.pdf', content: 'abc123')
+    end
+
+    context 'when successful' do
+      before do
+        savon.expects(:add).with(:message => {
+          'platformMsgs:record' => {
+            :content! => {
+              'fileCabinet:name' => 'foo.pdf',
+              'fileCabinet:content' => 'abc123',
+            },
+            '@xsi:type' => 'fileCabinet:File'
+          },
+        }).returns(File.read('spec/support/fixtures/add/add_file.xml'))
+      end
+
+      it 'makes a valid request to the NetSuite API' do
+        NetSuite::Actions::Add.call([file])
+      end
+
+      it 'returns a valid Response object' do
+        response = NetSuite::Actions::Add.call([file])
+        expect(response).to be_kind_of(NetSuite::Response)
+        expect(response).to be_success
+      end
+
+      it 'properly extracts internal ID from response' do
+        file.add
+
+        expect(file.internal_id).to eq('23556')
+      end
+    end
+  end
+
 end

data/spec/netsuite/actions/attach_file_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe NetSuite::Actions::AttachFile do
+  before(:all) { savon.mock! }
+  after(:all) { savon.unmock! }
+
+  let(:sales_order) { NetSuite::Records::SalesOrder.new(internal_id: 999) }
+  let(:file) {  double('file', internal_id: 111) }
+  let(:message) do
+    {
+      'platformCore:attachReference' => {
+        '@xsi:type' => 'platformCore:AttachBasicReference',
+        'platformCore:attachTo' => {
+          '@internalId' => sales_order.internal_id,
+          '@type' => 'salesOrder',
+          '@xsi:type' => 'platformCore:RecordRef'
+        },
+        'platformCore:attachedRecord' => {
+          '@internalId' => file.internal_id,
+          '@type' => 'file',
+          '@xsi:type' => 'platformCore:RecordRef'
+        }
+      }
+    }
+  end
+
+  before do
+    savon.expects(:attach).with(:message => message).returns(envelope)
+  end
+
+  context 'when successful' do
+    let(:envelope) { File.read('spec/support/fixtures/attach/attach_file_to_sales_order.xml') }
+
+    it 'returns a valid Response object' do
+      response = NetSuite::Actions::AttachFile.call([sales_order, file])
+      expect(response).to be_kind_of(NetSuite::Response)
+      expect(response).to be_success
+    end
+  end
+
+  context 'when not successful' do
+    let(:envelope) { File.read('spec/support/fixtures/attach/attach_file_to_sales_order_error.xml') }
+
+    it 'provides an error method on the object with details about the error' do
+      sales_order.attach_file(file)
+      error = sales_order.errors.first
+
+      expect(error).to be_kind_of(NetSuite::Error)
+      expect(error.type).to eq('ERROR')
+      expect(error.code).to eq('INVALID')
+      expect(error.message).to eq('Invalid request.')
+    end
+
+    it 'provides an error method on the response' do
+      response = NetSuite::Actions::AttachFile.call([sales_order, file])
+      expect(response.errors.first).to be_kind_of(NetSuite::Error)
+    end
+  end
+end

data/spec/netsuite/actions/search_spec.rb

@@ -193,6 +193,30 @@ describe NetSuite::Actions::Search do
       expect(search.results.first.location_re_order_point).to eq('2565.0')
       expect(search.results.first.location_quantity_on_order).to eq('40000.0')
     end
+
+    it "should handle an ID search with basic non-field result columns" do
+      response = File.read('spec/support/fixtures/search/saved_search_item_2.xml')
+      savon.expects(:search)
+        .with(message: {
+          "searchRecord"=>{
+            "@xsi:type"      =>"listAcct:ItemSearchAdvanced",
+            "@savedSearchId" =>42,
+            :content!        =>{"listAcct:criteria"=>{}},
+          }
+        }).returns(response)
+
+      search = NetSuite::Records::InventoryItem.search(saved: 42)
+
+      results = search.results
+      custom_fields = results.map do |record|
+        record.custom_field_list.custom_fields.map(&:internal_id)
+      end.flatten.uniq
+      [
+        :location_quantity_available,
+        :location_re_order_point,
+        :location_quantity_on_order,
+      ].each {|field| expect(custom_fields).to include(field)}
+    end
   end
 
   context "advanced search" do
@@ -201,6 +225,187 @@ describe NetSuite::Actions::Search do
   end
 
   context "basic search" do
+    it "should handle a basic search matching on RecordRef using internalId" do
+      response = File.read('spec/support/fixtures/search/basic_search_contact.xml')
+      savon.expects(:search)
+        .with(message: {
+          "searchRecord" => {
+            :content! => {
+              "listRel:basic" => {
+                "platformCommon:company" => {
+                  "@operator" => "anyOf",
+                  "@xsi:type" => "platformCore:SearchMultiSelectField",
+                  "platformCore:searchValue" => [
+                    {
+                      :content! => {},
+                      "@xsi:type" => "platformCore:RecordRef",
+                      "@type" => "account",
+                      "@internalId" => 7497,
+                    },
+                    {
+                      :content! => {},
+                      "@xsi:type" => "platformCore:RecordRef",
+                      "@type" => "account",
+                      "@internalId" => 7270,
+                    },
+                  ],
+                },
+              },
+            },
+            "@xsi:type" => "listRel:ContactSearch",
+          },
+        }).returns(response)
+
+      search = NetSuite::Records::Contact.search(
+        basic: [{
+          field: 'company',
+          operator: 'anyOf',
+          value: [
+            NetSuite::Records::RecordRef.new(internal_id: 7497),
+            NetSuite::Records::RecordRef.new(internal_id: 7270),
+          ],
+        }],
+      )
+
+      expect(search.results.size).to eq(1)
+    end
+
+    it "should handle a basic search matching on RecordRef using externalId" do
+      response = File.read('spec/support/fixtures/search/basic_search_contact.xml')
+      savon.expects(:search)
+        .with(message: {
+          "searchRecord" => {
+            :content! => {
+              "listRel:basic" => {
+                "platformCommon:company" => {
+                  "@operator" => "anyOf",
+                  "@xsi:type" => "platformCore:SearchMultiSelectField",
+                  "platformCore:searchValue" => [
+                    {
+                      :content! => {},
+                      "@xsi:type" => "platformCore:RecordRef",
+                      "@type" => "account",
+                      "@externalId" => "external_abc",
+                    },
+                    {
+                      :content! => {},
+                      "@xsi:type" => "platformCore:RecordRef",
+                      "@type" => "account",
+                      "@externalId" => "external_xyz",
+                    },
+                  ],
+                },
+              },
+            },
+            "@xsi:type" => "listRel:ContactSearch",
+          },
+        }).returns(response)
+
+      search = NetSuite::Records::Contact.search(
+        basic: [{
+          field: 'company',
+          operator: 'anyOf',
+          value: [
+            NetSuite::Records::RecordRef.new(external_id: "external_abc"),
+            NetSuite::Records::RecordRef.new(external_id: "external_xyz"),
+          ],
+        }],
+      )
+
+      expect(search.results.size).to eq(1)
+    end
+
+    it "should handle a basic search matching on RecordRef using mix of internalId and externalId" do
+      response = File.read('spec/support/fixtures/search/basic_search_contact.xml')
+      savon.expects(:search)
+        .with(message: {
+          "searchRecord" => {
+            :content! => {
+              "listRel:basic" => {
+                "platformCommon:company" => {
+                  "@operator" => "anyOf",
+                  "@xsi:type" => "platformCore:SearchMultiSelectField",
+                  "platformCore:searchValue" => [
+                    {
+                      :content! => {},
+                      "@xsi:type" => "platformCore:RecordRef",
+                      "@type" => "account",
+                      "@internalId" => 7497,
+                    },
+                    {
+                      :content! => {},
+                      "@xsi:type" => "platformCore:RecordRef",
+                      "@type" => "account",
+                      "@externalId" => "external_xyz",
+                    },
+                  ],
+                },
+              },
+            },
+            "@xsi:type" => "listRel:ContactSearch",
+          },
+        }).returns(response)
+
+      search = NetSuite::Records::Contact.search(
+        basic: [{
+          field: 'company',
+          operator: 'anyOf',
+          value: [
+            NetSuite::Records::RecordRef.new(internal_id: 7497),
+            NetSuite::Records::RecordRef.new(external_id: "external_xyz"),
+          ],
+        }],
+      )
+
+      expect(search.results.size).to eq(1)
+    end
+
+    it "should handle a basic search matching on RecordRef using both internalId and externalId" do
+      response = File.read('spec/support/fixtures/search/basic_search_contact.xml')
+      savon.expects(:search)
+        .with(message: {
+          "searchRecord" => {
+            :content! => {
+              "listRel:basic" => {
+                "platformCommon:company" => {
+                  "@operator" => "anyOf",
+                  "@xsi:type" => "platformCore:SearchMultiSelectField",
+                  "platformCore:searchValue" => [
+                    {
+                      :content! => {},
+                      "@xsi:type" => "platformCore:RecordRef",
+                      "@type" => "account",
+                      "@internalId" => 7497,
+                      "@externalId" => "external_abc",
+                    },
+                    {
+                      :content! => {},
+                      "@xsi:type" => "platformCore:RecordRef",
+                      "@type" => "account",
+                      "@externalId" => 7270,
+                    },
+                  ],
+                },
+              },
+            },
+            "@xsi:type" => "listRel:ContactSearch",
+          },
+        }).returns(response)
+
+      search = NetSuite::Records::Contact.search(
+        basic: [{
+          field: 'company',
+          operator: 'anyOf',
+          value: [
+            NetSuite::Records::RecordRef.new(internal_id: 7497, external_id: "external_abc"),
+            NetSuite::Records::RecordRef.new(external_id: 7270),
+          ],
+        }],
+      )
+
+      expect(search.results.size).to eq(1)
+    end
+
     skip "should handle searching basic fields"
     skip "should handle searching with joined fields"
   end

data/spec/netsuite/records/cash_refund_item_spec.rb

@@ -5,7 +5,7 @@ describe NetSuite::Records::CashRefundItem do
 
   it 'has all the right fields' do
     [
-      :amount
+      :amount, :gross_amt, :rate, :quantity, :is_taxable, :order_line, :line, :description
     ].each do |field|
       expect(item).to have_field(field)
     end

data/spec/netsuite/records/credit_memo_spec.rb

@@ -20,6 +20,20 @@ describe NetSuite::Records::CreditMemo do
     end
   end
 
+  it 'has all the right fields with specific classes' do
+    {
+      custom_field_list: NetSuite::Records::CustomFieldList,
+      item_list: NetSuite::Records::CreditMemoItemList,
+      apply_list: NetSuite::Records::CreditMemoApplyList,
+      ship_group_list: NetSuite::Records::SalesOrderShipGroupList,
+      null_field_list: NetSuite::Records::NullFieldList,
+      transaction_bill_address: NetSuite::Records::BillAddress,
+      billing_address: NetSuite::Records::Address,
+    }.each do |field, klass|
+      expect(memo).to have_field(field, klass)
+    end
+  end
+
   it 'has all the right record refs' do
     [
       :account, :bill_address_list, :created_from, :custom_form, :department, :discount_item, :entity, :gift_cert,

data/spec/netsuite/records/estimate_spec.rb

@@ -7,27 +7,117 @@ describe NetSuite::Records::Estimate do
 
   it 'has all the right fields' do
     [
-      :alt_handling_cost, :alt_shipping_cost, 
-      :balance, :bill_address, :created_date, :currency_name, 
-      :discount_rate, :email, :end_date, :est_gross_profit, 
+      :alt_handling_cost,
+      :alt_sales_total,
+      :alt_shipping_cost,
+      :can_have_stackable,
+      :contrib_pct,
+      :created_date,
+      :currency_name,
+      :discount_rate,
+      :discount_total,
+      :due_date,
+      :email,
+      :end_date,
+      :est_gross_profit,
+      :est_gross_profit_percent,
       :exchange_rate,
-      :handling_cost, :handling_tax1_rate, :is_taxable,
-      :last_modified_date, :memo, :message, :other_ref_num, 
-      :shipping_cost, :shipping_tax1_rate,
-      :source, :start_date, :status, :sync_partner_teams,
-      :sync_sales_teams, :to_be_emailed, :to_be_faxed, :to_be_printed,
-      :total_cost_estimate, :tran_date, :tran_id
+      :expected_close_date,
+      :fax,
+      :fob,
+      :handling_cost,
+      :handling_tax1_rate,
+      :handling_tax2_rate,
+      :include_in_forecast,
+      :is_taxable,
+      :last_modified_date,
+      :linked_tracking_numbers,
+      :memo,
+      :message,
+      :one_time,
+      :other_ref_num,
+      :probability,
+      :recur_annually,
+      :recur_monthly,
+      :recur_quarterly,
+      :recur_weekly,
+      :ship_date,
+      :ship_is_residential,
+      :shipping_cost,
+      :shipping_tax1_rate,
+      :shipping_tax2_rate,
+      :source,
+      :start_date,
+      :status,
+      :sub_total,
+      :sync_partner_teams,
+      :sync_sales_teams,
+      :tax2_total,
+      :tax_details_override,
+      :tax_point_date,
+      :tax_rate,
+      :tax_reg_override,
+      :tax_total,
+      :title,
+      :to_be_emailed,
+      :to_be_faxed,
+      :to_be_printed,
+      :total,
+      :total_cost_estimate,
+      :tracking_numbers,
+      :tran_date,
+      :tran_id,
+      :vat_reg_num,
+      :visible_to_customer,
     ].each do |field|
       expect(estimate).to have_field(field)
     end
   end
 
+  it 'has all the right fields with specific classes' do
+    {
+      billing_address: NetSuite::Records::Address,
+      custom_field_list: NetSuite::Records::CustomFieldList,
+      item_list: NetSuite::Records::EstimateItemList,
+      promotions_list: NetSuite::Records::PromotionsList,
+      shipping_address: NetSuite::Records::Address,
+    }.each do |field, klass|
+      expect(estimate).to have_field(field, klass)
+    end
+  end
+
   it 'has all the right record refs' do
     [
-      :bill_address_list, :created_from, :currency, :custom_form, :department, :discount_item,
-      :entity, :handling_tax_code, :job, :klass, :lead_source, :location, :message_sel,
-      :opportunity, :partner, :promo_code, :sales_group, :sales_rep,
-      :ship_method, :shipping_tax_code, :subsidiary
+      :bill_address_list,
+      :billing_schedule,
+      :klass,
+      :created_from,
+      :currency,
+      :custom_form,
+      :department,
+      :discount_item,
+      :entity,
+      :entity_status,
+      :entity_tax_reg_num,
+      :forecast_type,
+      :handling_tax_code,
+      :job,
+      :lead_source,
+      :location,
+      :message_sel,
+      :nexus,
+      :opportunity,
+      :partner,
+      :promo_code,
+      :sales_group,
+      :sales_rep,
+      :ship_address_list,
+      :ship_method,
+      :shipping_tax_code,
+      :subsidiary,
+      :subsidiary_tax_reg_num,
+      :tax_item,
+      :terms,
     ].each do |record_ref|
       expect(estimate).to have_record_ref(record_ref)
     end