netsuite 0.8.8 → 0.8.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: acf21d9a2b7a9ee0eedee971c7ebd1af50c05c28a1a5a03dea740fc1eb22529c
-  data.tar.gz: 6b740ed5e9b8d76926d63ca2895d0370b11b0c0656bd2581f15b9133f7d7edec
+  metadata.gz: 6137faebee57aa9e3bdaa9cca35d82765f5e9943075eb09bc8bd867b1893ad6b
+  data.tar.gz: 8ee0308ee67c2dcd440ea17a1107220e394b5b1e15829f76b47ca2769d4be9f2
 SHA512:
-  metadata.gz: 2a7d9f98b1574b63a6da20d65376e1edb936f8d16d44019871b8d7e2e7f1354956eac101d038f756bc8a2256977c6afbd0742c7f7badbd6ec89a8165fdde77f8
-  data.tar.gz: 6a268c38ec15d63e50f5c713363b7cf9f8b5faf67b1a4f40c4cdadc8728a27b1d2928d36debab70db278b26d36661d5e908ba04a3235464f0b23487ac1c6b91c
+  metadata.gz: a297cc64a543bdf34c086432c78a36b038205998794ae67a968c3c9bdd506a99bfd7a1048bb8aec821fd2edd1c2d89ce715719f035e1a09e5f4b38b560df98b6
+  data.tar.gz: a536956ed7da89d0fa0e7ec2dcaeba3539ec5dcbddbb3c9249a3b17b93caadaa13b9cba9b7cbe6f0a9b9de786541e4bc190e2771bef03c6cec71d1881c79f7e9

data/.github/FUNDING.yml

@@ -0,0 +1 @@
+github: [NetSweet]

data/.github/dependabot.yml

@@ -0,0 +1,14 @@
+version: 2
+updates:
+
+  # Maintain dependencies for GitHub Actions
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "daily"
+
+  # Maintain dependencies for rubygems
+  - package-ecosystem: "bundler"
+    directory: "/"
+    schedule:
+      interval: "daily"

data/.github/workflows/codeql-analysis.yml

@@ -0,0 +1,70 @@
+# For most projects, this workflow file will not need changing; you simply need
+# to commit it to your repository.
+#
+# You may wish to alter this file to override the set of languages analyzed,
+# or to provide custom queries or build logic.
+#
+# ******** NOTE ********
+# We have attempted to detect the languages in your repository. Please check
+# the `language` matrix defined below to confirm you have the correct set of
+# supported CodeQL languages.
+#
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ master ]
+  schedule:
+    - cron: '32 15 * * 6'
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'ruby' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+        # Learn more about CodeQL language support at https://git.io/codeql-language-support
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v2
+
+    # Initializes the CodeQL tools for scanning.
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v1
+      with:
+        languages: ${{ matrix.language }}
+        # If you wish to specify custom queries, you can do so here or in a config file.
+        # By default, queries listed here will override any specified in a config file.
+        # Prefix the list here with "+" to use these queries and those in the config file.
+        # queries: ./path/to/local/query, your-org/your-repo/queries@main
+
+    # Autobuild attempts to build any compiled languages  (C/C++, C#, or Java).
+    # If this step fails, then you should remove it and run the build manually (see below)
+    - name: Autobuild
+      uses: github/codeql-action/autobuild@v1
+
+    # ℹ️ Command-line programs to run using the OS shell.
+    # 📚 https://git.io/JvXDl
+
+    # ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
+    #    and modify them (or add more) to build your code if your project
+    #    uses a compiled language
+
+    #- run: |
+    #   make bootstrap
+    #   make release
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v1

data/.github/workflows/main.yml

@@ -1,15 +1,18 @@
 name: Ruby
 
-on: [push,pull_request]
+on: [push, pull_request]
 
 jobs:
   build:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: [2.7, 2.6, 2.5, 2.4, 2.3, 2.2, 2.1]
+        ruby-version: [3.1, 3.0, 2.7, 2.6, 2.5, 2.4, 2.3, 2.2, 2.1]
+        bundle-tzinfo: [true, false]
+    env:
+      BUNDLE_TZINFO: "${{ matrix.bundle-tzinfo }}"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
       - name: Set up Ruby ${{ matrix.ruby-version }}
         uses: ruby/setup-ruby@v1
         with:
@@ -17,4 +20,4 @@ jobs:
       - name: Install dependencies
         run: bundle install
       - name: Run tests
-        run: bundle exec rake
+        run: bundle exec rake

data/Gemfile

@@ -6,6 +6,8 @@ gem 'simplecov', :require => false
 gem 'pry-nav'
 gem 'pry-rescue'
 
-# optional dependency for more accurate timezone conversion
-gem 'tzinfo', '1.2.5'
-# gem 'tzinfo', '2.0.0'
+
+if ENV.fetch('BUNDLE_TZINFO', 'false') == 'true'
+  # optional dependency for more accurate timezone conversion
+  gem 'tzinfo', '>= 1.2.5'
+end

data/HISTORY.md

@@ -2,13 +2,50 @@
 
 ### Added
 
-*
-*
+### Fixed
+
+## 0.8.11
+
+### Added
+
+* Update ServiceResaleItem record fields/record refs for 2021.2. `item_options_list`, `presentation_item_list`, `site_category_list`, `translations_list` were all removed as fields as the are not simple fields, they require special classes. (#500)
+* Dependabot to CI
+* CI run for Ruby 3.0 & 3.1
+* Add CI run for an environment with and without `tzinfo` installed
+* Update NonInventorySaleItem record fields/record refs for 2021.2. `item_options_list`, `presentation_item_list`, `product_feed_list`, `site_category_list`, `translations_list` were all removed as fields as the are not simple fields, they require special classes. (#503)
+* Implement MatrixOptionList#to_record (#504)
+* Update ItemVendor record fields/record refs for 2021.1. `vendor` is now a record_ref instead of a field. (#505)
+* Update InventoryItem record fields/record refs for 2021.2. `member_list` was removed as a field as it doesn't belong to InventoryItem. (#506)
+* Update LotNumberedInventoryItem record fields/record refs for 2021.2. (#507)
+* Update NonInventoryResaleItem record fields/record refs for 2021.2. `item_options_list`, `presentation_item_list`, `product_feed_list`, `site_category_list`, `translations_list` were all removed as fields as the are not simple fields, they require special classes. (#508)
+* Add `attach_file` action for Invoice and SalesOrder. (#509)
+* Add ItemOptionCustomField recrd (#512)
+* Add Ship Address to Return Authorization (#525)
+* Support translations records (#516)
+
+### Fixed
+
+* Fix "undefined method `[]` for #<Nori::StringIOFile>" when adding File (#495)
+* Moved definition of `search_joins` attribute from records to search action. The attribute was removed for AssemblyComponent, SerializedInventoryItemLocation, and WorkOrderItem as they don't offer the search action. (#511)
+* Consider externalId in search criteria when using RecordRef as value (#517)
+* Retry http client error subclasses
+* Add upsert list action for cash sales (#523)
+
+## 0.8.10
+
+### Added
+
+* Update Estimate record fields/record refs for 2021.2. `balance`, `bill_address`, `bill_is_residential`, and `is_multi_ship_to` were all removed as fields as either being incorrect, outdated, or a search-only field. (#496)
+
+### Fixed
+
+* Savon 2.12 supported
+
+## 0.8.9
 
 ### Fixed
 
-*
-*
+* Fixed issue where search only fields could be specified when an existing field exists. https://github.com/NetSweet/netsuite/pull/488
 
 ## 0.8.8
 
@@ -23,4 +60,4 @@
 * Fix accessing custom field values returned in advanced search results (#480)
 * Fixing bug where single-selection custom multi select fields would incorrectly be parsed 3377c971d0cb727d81f4b4bc6e30edfbdfaccfd1
 * Fixed some field definitions on serialized assembly item
-* Properly extract external_id from advanced search results (#478)
+* Properly extract external_id from advanced search results (#478)

data/README.md

@@ -1,21 +1,3 @@
-<!-- START doctoc generated TOC please keep comment here to allow auto update -->
-<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
-**Table of Contents**
-
-- [NetSuite SuiteTalk API Ruby Gem](#netsuite-suitetalk-api-ruby-gem)
-- [Help & Support](#help--support)
-- [Testing](#testing)
-- [Installation](#installation)
-  - [Configuration](#configuration)
-    - [Token based Authentication](#token-based-authentication)
-- [Usage](#usage)
-  - [CRUD Operations](#crud-operations)
-  - [Custom Records & Fields](#custom-records--fields)
-  - [Searching](#searching)
-  - [Non-standard Operations](#non-standard-operations)
-
-<!-- END doctoc generated TOC please keep comment here to allow auto update -->
-
 [![Ruby](https://github.com/NetSweet/netsuite/actions/workflows/main.yml/badge.svg)](https://github.com/NetSweet/netsuite/actions/workflows/main.yml)
 [![Slack Status](https://opensuite-slackin.herokuapp.com/badge.svg)](http://opensuite-slackin.herokuapp.com)
 [![Gem Version](https://badge.fury.io/rb/netsuite.svg)](http://badge.fury.io/rb/netsuite)
@@ -215,7 +197,7 @@ task.update(message: 'New Message')
 task.delete
 
 # refresh/reload a record (helpful after adding the record for the first time)
-task.reload
+task.refresh
 
 # using get_select_value with a standard record
 NetSuite::Records::BaseRefList.get_select_value(
@@ -238,6 +220,19 @@ options = NetSuite::Records::BaseRefList.get_select_value(
 options.base_refs.map(&:name)
 ```
 
+## Uploading/Attaching Files
+
+```ruby
+file = NetSuite::Records::File.new(
+  content: Base64.encode64(File.read('/path/to/file')),
+  name: 'Invoice.pdf',
+)
+file.add
+
+invoice = NetSuite::Records::Invoice.get(internal_id: 1)
+invoice.attach_file(NetSuite::Records::RecordRef.new(internal_id: file.internal_id))
+```
+
 ## Custom Records & Fields
 
 ```ruby
@@ -421,7 +416,10 @@ NetSuite::Records::SalesOrder.search({
     'tranSales:basic' => [
       'platformCommon:internalId/' => {},
       'platformCommon:email/' => {},
-      'platformCommon:tranDate/' => {}
+      'platformCommon:tranDate/' => {},
+      # If you include columns that are only part of the *SearchRowBasic (ie. TransactionSearchRowBasic), 
+      # they'll be readable on the resulting record just like regular fields (my_record.close_date).
+      'platformCommon:closeDate/' => {}
     ],
     'tranSales:accountJoin' => [
       'platformCommon:internalId/' => {}

data/lib/netsuite/actions/add.rb

@@ -49,7 +49,11 @@ module NetSuite
       end
 
       def response_body
-        @response_body ||= response_hash[:base_ref]
+        @response_body ||= if response_hash[:base_ref].is_a?(Nori::StringIOFile)
+          { :@internal_id => Nokogiri::XML(@response.to_s).remove_namespaces!.at_xpath('//baseRef')[:internalId] }
+        else
+          response_hash[:base_ref]
+        end
       end
 
       def response_errors

data/lib/netsuite/actions/attach_file.rb

@@ -0,0 +1,87 @@
+module NetSuite
+  module Actions
+    class AttachFile
+      include Support::Requests
+
+      def initialize(object, file)
+        @object = object
+        @file   = file
+      end
+
+      private
+
+      def request(credentials = {})
+        NetSuite::Configuration.connection({}, credentials).call(:attach, :message => request_body)
+      end
+
+      # <soap:Body>
+      #   <platformMsgs:attach>
+      #     <platformCore:attachReference xsi:type="platformCore:AttachContactReference">
+      #       <platformCore::attachTo internalId="176" type="customer" xsi:type="platformCore::RecordRef">
+      #       </platformCore:attachTo>
+      #       <platformCore:attachRecord internalId="1467" type="file" xsi:type="platformCore:RecordRef"/>
+      #     </platformCore:attachReference>
+      #   </platformMsgs:attach>
+      # </soap:Body>
+
+      def request_body
+        {
+          'platformCore:attachReference' => {
+            '@xsi:type' => 'platformCore:AttachBasicReference',
+            'platformCore:attachTo' => {
+              '@internalId' => @object.internal_id,
+              '@type' => @object.netsuite_type,
+              '@xsi:type' => 'platformCore:RecordRef'
+            },
+            'platformCore:attachedRecord' => {
+              '@internalId' => @file.internal_id,
+              '@type' => 'file',
+              '@xsi:type' => 'platformCore:RecordRef'
+            }
+          }
+        }
+      end
+
+      def success?
+        @success ||= response_hash[:status][:@is_success] == 'true'
+      end
+
+      def response_body
+        @response_body ||= response_hash[:base_ref]
+      end
+
+      def response_errors
+        if response_hash[:status] && response_hash[:status][:status_detail]
+          @response_errors ||= errors
+        end
+      end
+
+      def response_hash
+        @response_hash ||= @response.to_hash[:attach_response][:write_response]
+      end
+
+      def errors
+        error_obj = response_hash[:status][:status_detail]
+        error_obj = [error_obj] if error_obj.class == Hash
+        error_obj.map do |error|
+          NetSuite::Error.new(error)
+        end
+      end
+
+      module Support
+        def attach_file(file, credentials = {})
+          response = NetSuite::Actions::AttachFile.call([self, file], credentials)
+
+          @errors = response.errors
+
+          if response.success?
+            @internal_id = response.body[:@internal_id]
+            true
+          else
+            false
+          end
+        end
+      end
+    end
+  end
+end

data/lib/netsuite/actions/search.rb

@@ -144,12 +144,23 @@ module NetSuite
                 h[element_name] = {
                   '@operator' => condition[:operator],
                   '@xsi:type' => 'platformCore:SearchMultiSelectField',
-                  "platformCore:searchValue" => {
-                    :content! => condition[:value].map(&:to_record),
-                    '@internalId' => condition[:value].map(&:internal_id),
-                    '@xsi:type' => 'platformCore:RecordRef',
-                    '@type' => 'account'
-                  }
+                  "platformCore:searchValue" => condition[:value].map do |value|
+                    search_value = {
+                      :content! => value.to_record,
+                      '@xsi:type' => 'platformCore:RecordRef',
+                      '@type' => 'account'
+                    }
+
+                    if value.internal_id
+                      search_value['@internalId'] = value.internal_id
+                    end
+
+                    if value.external_id
+                      search_value['@externalId'] = value.external_id
+                    end
+
+                    search_value
+                  end
                 }
               elsif condition[:value].is_a?(Array) && condition[:type] == 'SearchDateField'
                 # date ranges are handled via searchValue (start range) and searchValue2 (end range)
@@ -235,6 +246,8 @@ module NetSuite
       module Support
         def self.included(base)
           base.extend(ClassMethods)
+
+          attr_accessor :search_joins
         end
 
         module ClassMethods

data/lib/netsuite/records/account.rb

@@ -18,7 +18,6 @@ module NetSuite
 
       attr_reader :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/accounting_period.rb

@@ -13,7 +13,7 @@ module NetSuite
       record_refs :parent
 
       attr_reader :internal_id
-      attr_accessor :external_id, :search_joins
+      attr_accessor :external_id
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/assembly_component.rb

@@ -15,7 +15,6 @@ module NetSuite
 
       attr_reader   :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
@@ -25,4 +24,3 @@ module NetSuite
     end
   end
 end
-

data/lib/netsuite/records/assembly_item.rb

@@ -50,7 +50,6 @@ module NetSuite
 
       attr_reader :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/assembly_unbuild.rb

@@ -12,7 +12,7 @@ module NetSuite
         :search
 
       fields :bin_numbers, :built, :created_date, :expiration_date,
-        :last_modified_date, :memo, :quantity, :serial_numbers, :total,
+        :last_modified_date, :memo, :quantity, :serial_numbers,
         :tran_date, :tran_id
 
 	  read_only_fields :total
@@ -26,7 +26,6 @@ module NetSuite
 
       attr_reader   :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
@@ -36,5 +35,3 @@ module NetSuite
     end
   end
 end
-
-

data/lib/netsuite/records/cash_refund.rb

@@ -115,7 +115,6 @@ module NetSuite
 
       attr_reader :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/cash_sale.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::TranSales
 
-      actions :get, :add, :initialize, :delete, :update, :upsert, :search
+      actions :get, :add, :initialize, :delete, :update, :upsert, :upsert_list, :search
 
       fields :alt_handling_cost, :alt_shipping_cost, :auth_code, :bill_address, :cc_approved, :cc_expire_date, :cc_is_purchase_card_bin,
         :cc_name, :cc_number, :cc_process_as_purchas_card, :cc_security_code, :cc_street, :cc_zip_code, :charge_it, :contrib_pct, :created_date,
@@ -36,7 +36,6 @@ module NetSuite
 
       attr_reader :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/contact.rb

@@ -24,7 +24,6 @@ module NetSuite
 
       attr_reader   :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/credit_memo.rb

@@ -38,7 +38,6 @@ module NetSuite
 
       attr_reader :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/currency_rate.rb

@@ -12,7 +12,7 @@ module NetSuite
 
       actions :get, :get_list, :search
 
-      fields :base_currency, :effective_date, :exchange_rate, :transaction_currency
+      fields :effective_date, :exchange_rate
 
       record_refs :base_currency, :transaction_currency
 
@@ -21,7 +21,6 @@ module NetSuite
 
       attr_reader :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/custom_record.rb

@@ -17,12 +17,12 @@ module NetSuite
         :show_last_modified, :show_notes, :show_owner, :show_owner_allow_change, :show_owner_on_list, :use_permissions
 
       field :custom_field_list, CustomFieldList
+      field :translations_list, TranslationList
 
       record_refs :custom_form, :owner, :rec_type, :parent
 
       attr_reader :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/customer.rb

@@ -44,7 +44,6 @@ module NetSuite
 
       attr_reader   :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/customer_deposit.rb

@@ -29,7 +29,6 @@ module NetSuite
 
       attr_reader :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/customer_payment.rb

@@ -28,7 +28,6 @@ module NetSuite
 
       attr_reader   :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/customer_refund.rb

@@ -24,7 +24,6 @@ module NetSuite
 
       attr_reader :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/deposit.rb

@@ -20,7 +20,6 @@ module NetSuite
 
       attr_reader   :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/deposit_application.rb

@@ -37,7 +37,6 @@ module NetSuite
 
       attr_reader :internal_id
       attr_accessor :external_id
-      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/description_item.rb

@@ -15,7 +15,7 @@ module NetSuite
       
       field :custom_field_list, CustomFieldList
       field :subsidiary_list, RecordRefList
-      # TODO field :translations_list, TranslationList
+      field :translations_list, TranslationList
 
       attr_reader :internal_id
       attr_accessor :external_id