netsuite 0.8.6 → 0.8.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3c52f30c1f82b68e1ac2e078d81eed79f6c34ec0cc5937dd4251a53cb9a5a5c0
-  data.tar.gz: 4208277a164ec0b92520cef24b19367538788ecce870cd37f683ddb9fb85143e
+  metadata.gz: dbeff776d5c83998c7a1f32ede92f9dc5e23dc9779edb7f468c9069f78d45e2c
+  data.tar.gz: ae0a8d348549c9bfbdd069b2430ceb14d4d9934e5f3af32a2b9cfd4841c7a03b
 SHA512:
-  metadata.gz: bd8c7a34e1ecced72b398715f17978677bc87021e0bc9581449299f918b51993770d956eb3553775c1631ef16c8e488e6ffe682d9575665d81434106635f7e53
-  data.tar.gz: f40134f2aaf8824e9b51f9dba00a8a4d9b3b1e935df0d0d07f100018becf8180f6b603f63e52331e65877bbeb135de491fed75a9c5af0928e7409eedbc2f62b4
+  metadata.gz: e832952fe6eba8acb9f2126d6bc378a534a7d081c0f0007c995eebb9d4fe6c11e16a4a5ed8cacfb9135f2e4309d74ffa8535cb6e5825606788f9acff7f980e7b
+  data.tar.gz: 104588f1bba07662f374d67940ff06fb0cb9b8ffc30cebf402791113d2d8eda023812978025a07dfabd1677108228d6810564c5638fd87cffb1bbc4bb7c04c7b

data/.ruby-version

@@ -1 +1 @@
-2.6.6
+2.7.3

data/.tool-versions

@@ -0,0 +1 @@
+ruby 2.7.3

data/Gemfile

@@ -9,8 +9,4 @@ gem 'pry-rescue'
 
 # optional dependency for more accurate timezone conversion
 gem 'tzinfo', '1.2.5'
-# gem 'tzinfo', '2.0.0'
-
-# required for CircleCI to build properly with ruby 1.9.3
-gem 'json', '~> 2.3.0'
-gem 'rack', '~> 2.1.4'
+# gem 'tzinfo', '2.0.0'

data/README.md

@@ -1,6 +1,6 @@
 <!-- START doctoc generated TOC please keep comment here to allow auto update -->
 <!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
-**Table of Contents**  *generated with [DocToc](https://github.com/thlorenz/doctoc)*
+**Table of Contents**
 
 - [NetSuite SuiteTalk API Ruby Gem](#netsuite-suitetalk-api-ruby-gem)
 - [Help & Support](#help--support)
@@ -13,7 +13,6 @@
   - [Custom Records & Fields](#custom-records--fields)
   - [Searching](#searching)
   - [Non-standard Operations](#non-standard-operations)
-- [About SuiteSync](#about-suitesync)
 
 <!-- END doctoc generated TOC please keep comment here to allow auto update -->
 
@@ -24,24 +23,23 @@
 # NetSuite SuiteTalk API Ruby Gem
 
 * This gem will act as a wrapper around the NetSuite SuiteTalk WebServices API.
-* The gem does not cover the entire API, only the subset contributors have used so far.
-* NetSuite is a complex system. There's a lot to learn and sparse resources available to learn from. Here's a list of [NetSuite Development Resources](https://github.com/NetSweet/netsuite/wiki/NetSuite-Development-Resources) that might make things a bit less painful.
+* The gem does not cover the entire API, only the subset contributors have used so far. Please submit a PR for any functionality that's missing!
+* NetSuite is a complex system. There's a lot to learn and sparse resources available to learn from. Here's a list of [NetSuite Development Resources](https://github.com/NetSweet/netsuite/wiki/NetSuite-Development-Resources).
 
 # Help & Support
 
 Join the [slack channel](http://opensuite-slackin.herokuapp.com) for help with any NetSuite issues. Please do not post usage questions as issues in GitHub.
 
-Messages in the Slack ground are [archived here](https://suitechat.slackarchive.io). Search the archives to see if your question has been answered before.
-
 There is some additional helpful resources for NetSuite development [listed here](https://dashboard.suitesync.io/docs/resources#netsuite).
 
 # Testing
 
 Before contributing a patch make sure all existing tests pass.
 
-```
+```shell
 git clone git://github.com/NetSweet/netsuite.git
 cd netsuite
+
 bundle
 bundle exec rspec
 ```
@@ -56,28 +54,44 @@ gem 'netsuite'
 
 If you'd like more accurate time conversion support, include the `tzinfo` gem.
 
-This gem is built for ruby 1.9.x+, checkout the [1-8-stable](https://github.com/NetSweet/netsuite/tree/1-8-stable) branch for ruby 1.8.x support.
+This gem is built for ruby 2.6.x+, but should work on older versions down to 1.9. There's a [1-8-stable](https://github.com/NetSweet/netsuite/tree/1-8-stable) branch for ruby 1.8.x support.
 
 ## Configuration
 
 The most important thing you'll need is your NetSuite account ID. Not sure how to find your account id? [Here's a guide.](http://mikebian.co/find-netsuite-web-services-account-number/)
 
-For most use-cases, the following configuration will be sufficient:
+How you connect to NetSuite has changed a lot over the years and differs between API versions. For instance:
+
+* Older API versions (~2015) allowed authentication via username and password
+* Newever API versions (> 2016) still allowed for username and password authentication, but required an application ID
+* "OAuth", which requires four separate keys to be manually generated, was supported sometime after 2015
+* API versions greater than 2018_2 require `endpoint` to be set directly ([more info](https://github.com/NetSweet/netsuite/pull/473))
+
+Here's an example connection configuration. You don't want to actually use username + password config; token based authentication is detailed below in a separate section:
 
 ```ruby
 NetSuite.configure do
   reset!
 
+  # production & sandbox account numbers will differ
   account  'TSTDRV1576318'
   api_version '2018_2'
 
+  # password-based login information
+  # in most cases you should use token based authentication instead
   email 'email@example.com'
   password 'password'
   role 10
 
-  # use `NetSuite::Utilities.data_center_url('TSTDRV1576318')` to retrieve the URL
+  # recent API versions require a account-specific endpoint o be set
+  # use `NetSuite::Utilities.data_center_url('TSTDRV1576318')` to retrieve wsdl URL
   # you'll want to do this in a background process and strip the protocol out of the return string
   wsdl_domain 'tstdrv1576318.suitetalk.api.netsuite.com'
+
+  # the endpoint indicated in the > 2018_2 wsdl is invalid
+  # you must set the endpoint directly
+  # https://github.com/NetSweet/netsuite/pull/473
+  endpoint "#{wsdl_domain}/services/NetSuitePort_#{api_version}"
 end
 ```
 
@@ -115,6 +129,7 @@ NetSuite.configure do
   # log_level   :debug
 
   # password-based login information
+  # in most cases you should use token based authentication instead
   email    	  'email@domain.com'
   password 	  'password'
   account   	'12345'
@@ -127,9 +142,9 @@ NetSuite.configure do
 end
 ```
 
-If you'd like to use a API endpoints greater than 2015_1 you'll need to specify an application ID:
+If are using username + password authentication (which you shouldn't be!) *and* you'd like to use a API endpoints greater than 2015_1 you'll need to specify an application ID:
 
-```
+```ruby
 NetSuite::Configuration.soap_header = {
    'platformMsgs:ApplicationInfo' => {
       'platformMsgs:applicationId' => 'your-netsuite-app-id'
@@ -139,7 +154,7 @@ NetSuite::Configuration.soap_header = {
 
 ### Token based Authentication
 
-OAuth credentials are also supported. [Learn more about how to set up token based authentication here](http://mikebian.co/using-netsuites-token-based-authentication-with-suitetalk/).
+OAuth credentials are supported and the recommended authentication approach. [Learn more about how to set up token based authentication here](http://mikebian.co/using-netsuites-token-based-authentication-with-suitetalk/).
 
 ```ruby
 NetSuite.configure do
@@ -154,6 +169,11 @@ NetSuite.configure do
 
   # oauth does not work with API versions less than 2015_2
   api_version      '2016_2'
+
+  # the endpoint indicated in the > 2018_2 wsdl is invalid
+  # you must set the endpoint directly
+  # https://github.com/NetSweet/netsuite/pull/473
+  endpoint "#{wsdl_domain}/services/NetSuitePort_#{api_version}"
 end
 ```
 
@@ -593,7 +613,3 @@ states = NetSuite::Configuration.connection.call(:get_all, message: {
 })
 states.to_array.first[:get_all_response][:get_all_result][:record_list][:record].map { |r| { country: r[:country], abbr: r[:shortname], name: r[:full_name] } }
 ```
-
-# About SuiteSync
-
-[SuiteSync, the Stripe-NetSuite integration](http://suitesync.io) uses this gem and funds the majority of it's development and maintenance.

data/circle.yml

@@ -3,7 +3,7 @@ version: 2.1
 orbs:
   # orbs are basically bundles of pre-written build scripts that work for common cases
   # https://github.com/CircleCI-Public/ruby-orb
-  ruby: circleci/ruby@1.1
+  ruby: circleci/ruby@1.1.2
 
 jobs:
   # skipping build step because Gemfile.lock is not included in the source
@@ -17,8 +17,11 @@ jobs:
     steps:
       - checkout
       - ruby/install-deps:
-          bundler-version: '1.17.2'
+          bundler-version: '2.1.4'
           with-cache: false
+          # without specifying a non-standard path `--deployment` will be used when running bundler
+          # which causes the bundler to fail
+          path: './vendor/custom_bundle'
       - ruby/rspec-test
 
 # strangely, there seems to be very little documentation about exactly how martix builds work.

data/lib/netsuite.rb

@@ -123,6 +123,8 @@ module NetSuite
     autoload :CustomerPayment,                  'netsuite/records/customer_payment'
     autoload :CustomerPaymentApply,             'netsuite/records/customer_payment_apply'
     autoload :CustomerPaymentApplyList,         'netsuite/records/customer_payment_apply_list'
+    autoload :CustomerPaymentCredit,            'netsuite/records/customer_payment_credit'
+    autoload :CustomerPaymentCreditList,        'netsuite/records/customer_payment_credit_list'
     autoload :CustomerPartner,                  'netsuite/records/customer_partner'
     autoload :CustomerRefund,                   'netsuite/records/customer_refund'
     autoload :CustomerRefundApply,              'netsuite/records/customer_refund_apply'
@@ -297,6 +299,8 @@ module NetSuite
     autoload :VendorCreditItemList,             'netsuite/records/vendor_credit_item_list'
     autoload :VendorCreditExpense,              'netsuite/records/vendor_credit_expense'
     autoload :VendorCreditExpenseList,          'netsuite/records/vendor_credit_expense_list'
+    autoload :VendorCurrencyList,               'netsuite/records/vendor_currency_list'
+    autoload :VendorCurrency,                   'netsuite/records/vendor_currency'
     autoload :VendorReturnAuthorization,        'netsuite/records/vendor_return_authorization'
     autoload :VendorReturnAuthorizationItem,    'netsuite/records/vendor_return_authorization_item'
     autoload :VendorReturnAuthorizationItemList, 'netsuite/records/vendor_return_authorization_item_list'

data/lib/netsuite/configuration.rb

@@ -17,6 +17,7 @@ module NetSuite
     def connection(params={}, credentials={})
       client = Savon.client({
         wsdl: cached_wsdl || wsdl,
+        endpoint: endpoint,
         read_timeout: read_timeout,
         open_timeout: open_timeout,
         namespaces: namespaces,
@@ -94,6 +95,18 @@ module NetSuite
       attributes[:api_version] = version
     end
 
+    def endpoint=(endpoint)
+      attributes[:endpoint] = endpoint
+    end
+
+    def endpoint(endpoint=nil)
+      if endpoint
+        self.endpoint = endpoint
+      else
+        attributes[:endpoint]
+      end
+    end
+
     def sandbox=(flag)
       if attributes[:sandbox] != flag
         attributes[:wsdl] = nil

data/lib/netsuite/records/accounting_period.rb

@@ -8,12 +8,12 @@ module NetSuite
 
       actions :get, :get_list, :add, :delete, :upsert, :search
 
-      fields :allow_non_gl_changes, :end_date, :is_adjust, :is_quarter, :is_year, :period_name, :start_date
+      fields :allow_non_gl_changes, :end_date, :is_adjust, :is_quarter, :is_year, :period_name, :start_date, :closed
 
       record_refs :parent
 
       attr_reader :internal_id
-      attr_accessor :external_id
+      attr_accessor :external_id, :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/contact.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListRel
 
-      actions :get, :get_list, :add, :delete, :delete_list, :search, :update, :upsert
+      actions :get, :get_deleted, :get_list, :add, :delete, :delete_list, :search, :update, :upsert, :upsert_list
 
       fields :salutation, :first_name, :middle_name, :last_name, :title, :phone, :fax, :email, :default_address,
              :entity_id, :phonetic_name, :alt_email, :office_phone, :home_phone, :mobile_phone, :supervisor_phone,

data/lib/netsuite/records/credit_memo.rb

@@ -17,7 +17,7 @@ module NetSuite
         :sales_effective_date, :shipping_cost, :shipping_tax1_rate, :shipping_tax2_rate, :source, :status,
         :sync_partner_teams, :sync_sales_teams, :tax2_total, :tax_rate, :to_be_emailed, :to_be_faxed,
         :to_be_printed, :total_cost_estimate, :tran_date, :tran_id, :tran_is_vsoe_bundle, :vat_reg_num,
-        :vsoe_auto_calc
+        :vsoe_auto_calc, :tax_details_override, :tax_reg_override
 
       field :custom_field_list,        CustomFieldList
       field :item_list,                CreditMemoItemList

data/lib/netsuite/records/customer_deposit.rb

@@ -21,11 +21,11 @@ module NetSuite
       field :apply_list,        CustomerDepositApplyList
       # accountingBookDetailList
 
-      record_refs :customer, :sales_order, :account, :department, :payment_method,
-                  :custom_form, :currency, :posting_period, :subsidiary, :location,
-
-                  # only available in an advanced search result
-                  :deposit_transaction
+      record_refs :customer, :sales_order, :account, :department,
+        :payment_method, :payment_option, :custom_form, :currency,
+        :posting_period, :subsidiary, :location,
+        # only available in an advanced search result
+        :deposit_transaction
 
       attr_reader :internal_id
       attr_accessor :external_id

data/lib/netsuite/records/customer_payment.rb

@@ -17,11 +17,14 @@ module NetSuite
 
       field :custom_field_list, CustomFieldList
       field :apply_list,        CustomerPaymentApplyList
+      field :credit_list,       CustomerPaymentCreditList
 
       read_only_fields :applied, :balance, :pending, :total, :unapplied
 
-      record_refs :account, :ar_acct, :credit_card, :credit_card_processor, :custom_form, :customer, :department, :klass,
-        :location, :payment_method, :posting_period, :subsidiary, :currency
+      record_refs :account, :ar_acct, :credit_card, :credit_card_processor,
+        :custom_form, :customer, :department, :klass, :location,
+        :payment_method, :payment_option, :posting_period, :subsidiary,
+        :currency
 
       attr_reader   :internal_id
       attr_accessor :external_id

data/lib/netsuite/records/customer_payment_credit.rb

@@ -0,0 +1,17 @@
+module NetSuite
+  module Records
+    class CustomerPaymentCredit
+      include Support::Fields
+      include Support::Records
+      include Namespaces::TranCust
+
+      fields :amount, :applied_to, :apply, :credit_date, :currency, :doc, :due, :line,
+        :ref_num, :total, :type
+
+      def initialize(attributes = {})
+        initialize_from_attributes_hash(attributes)
+      end
+
+    end
+  end
+end

data/lib/netsuite/records/customer_payment_credit_list.rb

@@ -0,0 +1,12 @@
+module NetSuite
+  module Records
+    class CustomerPaymentCreditList < Support::Sublist
+      include Namespaces::TranCust
+
+      sublist :credit, CustomerPaymentCredit
+
+      alias :credits :credit
+
+    end
+  end
+end

data/lib/netsuite/records/inventory_item.rb

@@ -51,7 +51,8 @@ module NetSuite
         :parent, :preferred_location, :pricing_group, :purchase_price_variance_acct, :purchase_tax_code, :purchase_unit,
         :quantity_pricing_schedule, :rev_rec_schedule, :sale_unit, :sales_tax_code, :ship_package, :soft_descriptor,
         :stock_unit, :store_display_image, :store_display_thumbnail, :store_item_template, :supply_lot_sizing_method,
-        :supply_replenishment_method, :supply_type, :tax_schedule, :units_type, :vendor
+        :supply_replenishment_method, :supply_type, :tax_schedule, :units_type, :vendor, :create_revenue_plans_on,
+        :revenue_recognition_rule, :rev_rec_forecast_rule
 
       field :pricing_matrix, PricingMatrix
       field :custom_field_list, CustomFieldList

data/lib/netsuite/records/partner.rb

@@ -8,15 +8,17 @@ module NetSuite
       include Support::RecordRefs
       include Namespaces::ListRel
 
-      # https://system.netsuite.com/help/helpcenter/en_US/srbrowser/Browser2014_1/schema/record/partner.html
+      # https://system.netsuite.com/help/helpcenter/en_US/srbrowser/Browser2020_2/schema/record/partner.html
 
       actions :get, :get_list, :add, :update, :upsert, :upsert_list, :delete, :search
 
-      fields :phone, :home_phone, :first_name, :last_name, :alt_name, :is_inactive, :email, :give_access,
-             :partner_code, :is_person, :company_name, :eligible_for_commission, :entity_id, :last_modified_date,
-             :date_created, :title, :mobile_phone, :comments, :middle_name, :send_email, :password, :password2
+      fields :alt_email, :alt_name, :bcn, :comments, :company_name, :date_created, :default_address,
+             :eligible_for_commission, :email, :entity_id, :fax, :first_name, :give_access, :home_phone, :is_inactive,
+             :is_person, :last_modified_date, :last_name, :login_as, :middle_name, :mobile_phone, :partner_code,
+             :password, :password2, :phone, :phonetic_name, :print_on_check_as, :referring_url, :require_pwd_change,
+             :salutation, :send_email, :sub_partner_login, :tax_id_num, :title, :url, :vat_reg_number
 
-      record_refs :klass, :access_role, :department, :subsidiary
+      record_refs :access_role, :klass, :custom_form, :default_tax_reg, :department, :image, :location, :parent, :subsidiary
 
       attr_reader   :internal_id
       attr_accessor :external_id

data/lib/netsuite/records/vendor.rb

@@ -11,7 +11,7 @@ module NetSuite
 
       fields :account_number, :alt_email, :alt_name, :alt_phone, :balance,
              :balance_primary, :bcn, :bill_pay, :comments, :company_name, :credit_limit,
-             :currency_list, :date_created, :default_address, :eligible_for_commission,
+             :date_created, :default_address, :eligible_for_commission,
              :email, :email_preference, :email_transactions, :entity_id, :fax, :fax_transactions,
              :first_name, :give_access, :global_subscription_status, :home_phone, :is1099_eligible,
              :is_accountant, :is_inactive, :is_job_resource_vend, :is_person, :labor_cost,
@@ -22,6 +22,7 @@ module NetSuite
              :url, :vat_reg_number
 
       field :custom_field_list, CustomFieldList
+      field :currency_list, VendorCurrencyList
       # TODO should change name to VendorAddressBookList
       field :addressbook_list, CustomerAddressbookList
 

data/lib/netsuite/records/vendor_currency.rb

@@ -0,0 +1,26 @@
+module NetSuite
+  module Records
+    class VendorCurrency
+      include Support::Fields
+      include Support::RecordRefs
+      include Support::Records
+      include Namespaces::ListRel
+
+      fields :balance, :consol_balance, :consol_deposit_balance, :consol_overdue_balance,
+             :consol_unbilled_orders, :deposit_balance, :display_symbol, :overdue_balance,
+             :override_currency_format, :symbol_placement, :unbilled_orders
+
+      record_refs :currency
+
+      def initialize(attributes_or_record = {})
+        case attributes_or_record
+        when Hash
+          initialize_from_attributes_hash(attributes_or_record)
+        when self.class
+          initialize_from_record(attributes_or_record)
+        end
+      end
+
+    end
+  end
+end

data/lib/netsuite/records/vendor_currency_list.rb

@@ -0,0 +1,9 @@
+module NetSuite
+  module Records
+    class VendorCurrencyList < Support::Sublist
+      include Namespaces::ListRel
+
+      sublist :vendor_currency, NetSuite::Records::VendorCurrency
+    end
+  end
+end

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module NetSuite
-  VERSION = '0.8.6'
+  VERSION = '0.8.7'
 end

data/spec/netsuite/configuration_spec.rb

@@ -29,10 +29,12 @@ describe NetSuite::Configuration do
   end
 
   describe '#connection' do
+    EXAMPLE_ENDPOINT = 'https://1023.suitetalk.api.netsuite.com/services/NetSuitePort_2020_2'
     before(:each) do
       # reset clears out the password info
       config.email       'me@example.com'
       config.password    'me@example.com'
+      config.endpoint    EXAMPLE_ENDPOINT
       config.account     1023
       config.wsdl        "my_wsdl"
       config.api_version "2012_2"
@@ -57,6 +59,19 @@ describe NetSuite::Configuration do
 
       expect(config).to have_received(:cached_wsdl)
     end
+
+    it 'sets the endpoint on the Savon client' do
+      # this is ugly/brittle, but it's hard to see how else to test this
+      savon_configs = config.connection.globals.instance_eval {@options}
+      expect(savon_configs.fetch(:endpoint)).to eq(EXAMPLE_ENDPOINT)
+    end
+
+    it 'handles a nil endpoint' do
+      config.endpoint = nil
+      # this is ugly/brittle, but it's hard to see how else to test this
+      savon_configs = config.connection.globals.instance_eval {@options}
+      expect(savon_configs.fetch(:endpoint)).to eq(nil)
+    end
   end
 
   describe '#wsdl' do
@@ -166,6 +181,23 @@ describe NetSuite::Configuration do
     end
   end
 
+  describe '#endpoint' do
+    it 'can be set with endpoint=' do
+      config.endpoint = 42
+      expect(config.endpoint).to eq(42)
+    end
+
+    it 'can be set with just endpoint(value)' do
+      config.endpoint(42)
+      expect(config.endpoint).to eq(42)
+    end
+
+    it 'supports nil endpoints' do
+      config.endpoint = nil
+      expect(config.endpoint).to eq(nil)
+    end
+  end
+
   describe '#auth_header' do
     context 'when doing user authentication' do
       before do

data/spec/netsuite/records/basic_record_spec.rb

@@ -1,6 +1,7 @@
 require 'spec_helper'
 
 describe 'basic records' do
+  # all records with internal IDs should be added to this list
   let(:basic_record_list) {
     [
       NetSuite::Records::Currency,
@@ -49,6 +50,7 @@ describe 'basic records' do
       NetSuite::Records::SerializedInventoryItem,
       NetSuite::Records::DepositApplication,
       NetSuite::Records::InventoryAdjustment,
+      NetSuite::Records::Vendor,
       NetSuite::Records::VendorReturnAuthorization,
       NetSuite::Records::AssemblyBuild,
       NetSuite::Records::AssemblyUnbuild,
@@ -61,6 +63,7 @@ describe 'basic records' do
       NetSuite::Records::BinTransfer,
       NetSuite::Records::SerializedAssemblyItem,
       NetSuite::Records::CustomerStatus,
+      NetSuite::Records::CustomerPayment,
       NetSuite::Records::TransactionBodyCustomField,
       NetSuite::Records::TransactionColumnCustomField,
       NetSuite::Records::EntityCustomField
@@ -108,8 +111,12 @@ describe 'basic records' do
 
       if !sublist_fields.empty?
         sublist_fields.each do |sublist_field|
+          sublist = record_instance.send(sublist_field)
+
           # TODO make a sublist entry with some fields valid for that sublist item
-          record_instance.send(sublist_field) << {}
+          sublist << {}
+
+          expect(sublist.send(sublist.sublist_key).count).to be(1)
         end
       end
 

data/spec/netsuite/records/customer_payment_credit_list_spec.rb

@@ -0,0 +1,26 @@
+require 'spec_helper'
+
+describe NetSuite::Records::CustomerPaymentCreditList do
+  let(:list) { NetSuite::Records::CustomerPaymentCreditList.new }
+  let(:apply) { NetSuite::Records::CustomerPaymentCredit.new }
+
+  it 'can have credits be added to it' do
+    list.credits << apply
+    credit_list = list.credits
+    expect(credit_list).to be_kind_of(Array)
+    expect(credit_list.length).to eql(1)
+    credit_list.each { |i| expect(i).to be_kind_of(NetSuite::Records::CustomerPaymentCredit) }
+  end
+
+  describe '#to_record' do
+    it 'can represent itself as a SOAP record' do
+      record = {
+          'tranCust:credit' => [{},{}]
+      }
+
+      list.credits.concat([apply, apply])
+      expect(list.to_record).to eql(record)
+    end
+  end
+
+end

data/spec/netsuite/records/customer_payment_spec.rb

@@ -18,7 +18,7 @@ describe NetSuite::Records::CustomerPayment do
 
   it 'has all the right record refs' do
     [
-      :account, :ar_acct, :credit_card, :credit_card_processor, :custom_form, :customer, :department, :klass, :location, :payment_method, :posting_period, :subsidiary
+      :account, :ar_acct, :credit_card, :credit_card_processor, :custom_form, :customer, :department, :klass, :location, :payment_method, :payment_option, :posting_period, :subsidiary
     ].each do |record_ref|
       expect(payment).to have_record_ref(record_ref)
     end
@@ -49,11 +49,6 @@ describe NetSuite::Records::CustomerPayment do
     it 'can be set from a CustomerPaymentApplyList object'
   end
 
-  describe '#credit_list' do
-    it 'can be set from attributes'
-    it 'can be set from a CustomerPaymentCreditList object'
-  end
-
   describe '#deposit_list' do
     it 'can be set from attributes'
     it 'can be set from a CustomerPaymentDepositList object'

data/spec/netsuite/records/partner_spec.rb

@@ -5,9 +5,11 @@ describe NetSuite::Records::Partner do
 
   it 'has all the right fields' do
     [
-        :phone, :home_phone, :first_name, :last_name, :alt_name, :is_inactive, :email, :give_access,
-        :partner_code, :is_person, :company_name, :eligible_for_commission, :entity_id, :last_modified_date,
-        :date_created, :title, :mobile_phone, :comments, :middle_name, :send_email, :password, :password2
+        :alt_email, :alt_name, :bcn, :comments, :company_name, :date_created, :default_address,
+        :eligible_for_commission, :email, :entity_id, :fax, :first_name, :give_access, :home_phone, :is_inactive,
+        :is_person, :last_modified_date, :last_name, :login_as, :middle_name, :mobile_phone, :partner_code,
+        :password, :password2, :phone, :phonetic_name, :print_on_check_as, :referring_url, :require_pwd_change,
+        :salutation, :send_email, :sub_partner_login, :tax_id_num, :title, :url, :vat_reg_number
     ].each do |field|
       expect(partner).to have_field(field)
     end
@@ -15,7 +17,7 @@ describe NetSuite::Records::Partner do
 
   it 'has all the right record refs' do
     [
-        :klass, :access_role, :department, :subsidiary
+        :access_role, :klass, :custom_form, :default_tax_reg, :department, :image, :location, :parent, :subsidiary
     ].each do |record_ref|
       expect(partner).to have_record_ref(record_ref)
     end

data/spec/netsuite/records/vendor_spec.rb

@@ -7,7 +7,7 @@ describe NetSuite::Records::Vendor do
     [
         :account_number, :alt_email, :alt_name, :alt_phone, :balance,
         :balance_primary, :bcn, :bill_pay, :comments, :company_name, :credit_limit,
-        :currency_list, :date_created, :default_address, :eligible_for_commission,
+        :date_created, :default_address, :eligible_for_commission,
         :email, :email_preference, :email_transactions, :entity_id, :fax, :fax_transactions,
         :first_name, :give_access, :global_subscription_status, :home_phone, :is1099_eligible,
         :is_accountant, :is_inactive, :is_job_resource_vend, :is_person, :labor_cost,

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: netsuite
 version: !ruby/object:Gem::Version
-  version: 0.8.6
+  version: 0.8.7
 platform: ruby
 authors:
 - Ryan Moran
 - Michael Bianco
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-23 00:00:00.000000000 Z
+date: 2021-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -56,6 +56,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".ruby-version"
+- ".tool-versions"
 - Gemfile
 - LICENSE
 - README.md
@@ -168,6 +169,8 @@ files:
 - lib/netsuite/records/customer_payment.rb
 - lib/netsuite/records/customer_payment_apply.rb
 - lib/netsuite/records/customer_payment_apply_list.rb
+- lib/netsuite/records/customer_payment_credit.rb
+- lib/netsuite/records/customer_payment_credit_list.rb
 - lib/netsuite/records/customer_refund.rb
 - lib/netsuite/records/customer_refund_apply.rb
 - lib/netsuite/records/customer_refund_apply_list.rb
@@ -331,6 +334,8 @@ files:
 - lib/netsuite/records/vendor_credit_expense_list.rb
 - lib/netsuite/records/vendor_credit_item.rb
 - lib/netsuite/records/vendor_credit_item_list.rb
+- lib/netsuite/records/vendor_currency.rb
+- lib/netsuite/records/vendor_currency_list.rb
 - lib/netsuite/records/vendor_payment.rb
 - lib/netsuite/records/vendor_payment_apply.rb
 - lib/netsuite/records/vendor_payment_apply_list.rb
@@ -407,6 +412,7 @@ files:
 - spec/netsuite/records/customer_addressbook_spec.rb
 - spec/netsuite/records/customer_credit_cards_list_spec.rb
 - spec/netsuite/records/customer_payment_apply_list_spec.rb
+- spec/netsuite/records/customer_payment_credit_list_spec.rb
 - spec/netsuite/records/customer_payment_spec.rb
 - spec/netsuite/records/customer_refund_apply_list_spec.rb
 - spec/netsuite/records/customer_refund_apply_spec.rb
@@ -556,7 +562,7 @@ homepage: https://github.com/NetSweet/netsuite
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -571,8 +577,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.6
+signing_key:
 specification_version: 4
 summary: NetSuite SuiteTalk API (SOAP) Wrapper
 test_files:
@@ -627,6 +633,7 @@ test_files:
 - spec/netsuite/records/customer_addressbook_spec.rb
 - spec/netsuite/records/customer_credit_cards_list_spec.rb
 - spec/netsuite/records/customer_payment_apply_list_spec.rb
+- spec/netsuite/records/customer_payment_credit_list_spec.rb
 - spec/netsuite/records/customer_payment_spec.rb
 - spec/netsuite/records/customer_refund_apply_list_spec.rb
 - spec/netsuite/records/customer_refund_apply_spec.rb