netsuite 0.8.4 → 0.8.8

data/lib/netsuite/utilities.rb

@@ -78,7 +78,7 @@ module NetSuite
       begin
         count += 1
         yield
-      rescue Exception => e
+      rescue StandardError => e
         exceptions_to_retry = [
           Errno::ECONNRESET,
           Errno::ETIMEDOUT,
@@ -115,6 +115,7 @@ module NetSuite
           # https://github.com/stripe/stripe-netsuite/issues/815
           if !e.message.include?("Only one request may be made against a session at a time") &&
             !e.message.include?('java.util.ConcurrentModificationException') &&
+            !e.message.include?('java.lang.NullPointerException') &&
             !e.message.include?('java.lang.IllegalStateException') &&
             !e.message.include?('java.lang.reflect.InvocationTargetException') &&
             !e.message.include?('com.netledger.common.exceptions.NLDatabaseOfflineException') &&
@@ -172,7 +173,9 @@ module NetSuite
       ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::GiftCertificateItem, ns_item_internal_id, opts)
       ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::KitItem, ns_item_internal_id, opts)
       ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::SerializedInventoryItem, ns_item_internal_id, opts)
+      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::SerializedAssemblyItem, ns_item_internal_id, opts)
       ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::LotNumberedAssemblyItem, ns_item_internal_id, opts)
+      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::LotNumberedInventoryItem, ns_item_internal_id, opts)
 
       if ns_item.nil?
         fail NetSuite::RecordNotFound, "item with ID #{ns_item_internal_id} not found"
@@ -277,16 +280,25 @@ module NetSuite
       # NetSuite requires that the time be passed to the API with the PDT TZ offset
       # of the time passed in (i.e. not the current TZ offset of PDT)
 
-      offset = Rational(-7, 24)
-      
       if defined?(TZInfo)
-        time = TZInfo::Timezone.get("America/Los_Angeles").utc_to_local(time)
-        offset = time.offset
+        # if no version is defined, less than 2.0
+        # https://github.com/tzinfo/tzinfo/blob/master/CHANGES.md#added
+        if !defined?(TZInfo::VERSION)
+          # https://stackoverflow.com/questions/2927111/ruby-get-time-in-given-timezone
+          offset = TZInfo::Timezone.get("America/Los_Angeles").period_for_utc(time).utc_total_offset_rational
+          time = time.new_offset(offset)
+        else
+          time = TZInfo::Timezone.get("America/Los_Angeles").utc_to_local(time)
+          offset = time.offset
+        end
       else
+        # if tzinfo is not installed, let's give it our best guess: -7
+        offset = Rational(-7, 24)
         time = time.new_offset("-07:00")
       end
 
-      (time + (offset * -1)).iso8601
+      time = (time + (offset * -1))
+      time.iso8601
     end
 
   end

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module NetSuite
-  VERSION = '0.8.4'
+  VERSION = '0.8.8'
 end

data/netsuite.gemspec

@@ -2,8 +2,9 @@
 require File.expand_path('../lib/netsuite/version', __FILE__)
 
 Gem::Specification.new do |gem|
+  gem.licenses      = ['MIT']
   gem.authors       = ['Ryan Moran', 'Michael Bianco']
-  gem.email         = ['ryan.moran@gmail.com', 'mike@cliffsidemedia.com']
+  gem.email         = ['ryan.moran@gmail.com', 'mike@mikebian.co']
   gem.description   = %q{NetSuite SuiteTalk API Wrapper}
   gem.summary       = %q{NetSuite SuiteTalk API (SOAP) Wrapper}
   gem.homepage      = 'https://github.com/NetSweet/netsuite'
@@ -15,7 +16,8 @@ Gem::Specification.new do |gem|
   gem.require_paths = ['lib']
   gem.version       = NetSuite::VERSION
 
-  gem.add_dependency 'savon', '>= 2.3.0'
+  gem.add_dependency 'savon', '>= 2.3.0', '<= 2.11.1'
 
-  gem.add_development_dependency 'rspec', '~> 3.1.0'
+  gem.add_development_dependency 'rspec', '~> 3.10.0'
+  gem.add_development_dependency 'rake'
 end

data/spec/netsuite/actions/search_spec.rb

@@ -168,9 +168,31 @@ describe NetSuite::Actions::Search do
 
       expect(search.results.size).to eq(2)
       expect(search.current_page).to eq(1)
+      expect(search.results.first.internal_id).to eq('123')
+      expect(search.results.first.external_id).to eq('456')
       expect(search.results.first.alt_name).to eq('A Awesome Name')
+      expect(search.results.first.custom_field_list.custitem_stringfield.value).to eq('sample string value')
+      expect(search.results.first.custom_field_list.custitem_apcategoryforsales.value.internal_id).to eq('4')
       expect(search.results.last.email).to eq('alessawesome@gmail.com')
     end
+
+    it "should handle an ID search with basic search only field result columns" do
+      response = File.read('spec/support/fixtures/search/saved_search_item.xml')
+      savon.expects(:search)
+        .with(message: {
+          "searchRecord"=>{
+            "@xsi:type"      =>"listAcct:ItemSearchAdvanced",
+            "@savedSearchId" =>42,
+            :content!        =>{"listAcct:criteria"=>{}},
+          }
+        }).returns(response)
+
+      search = NetSuite::Records::InventoryItem.search(saved: 42)
+
+      expect(search.results.first.location_quantity_available).to eq('3307.0')
+      expect(search.results.first.location_re_order_point).to eq('2565.0')
+      expect(search.results.first.location_quantity_on_order).to eq('40000.0')
+    end
   end
 
   context "advanced search" do

data/spec/netsuite/configuration_spec.rb

@@ -29,10 +29,12 @@ describe NetSuite::Configuration do
   end
 
   describe '#connection' do
+    EXAMPLE_ENDPOINT = 'https://1023.suitetalk.api.netsuite.com/services/NetSuitePort_2020_2'
     before(:each) do
       # reset clears out the password info
       config.email       'me@example.com'
       config.password    'me@example.com'
+      config.endpoint    EXAMPLE_ENDPOINT
       config.account     1023
       config.wsdl        "my_wsdl"
       config.api_version "2012_2"
@@ -57,6 +59,19 @@ describe NetSuite::Configuration do
 
       expect(config).to have_received(:cached_wsdl)
     end
+
+    it 'sets the endpoint on the Savon client' do
+      # this is ugly/brittle, but it's hard to see how else to test this
+      savon_configs = config.connection.globals.instance_eval {@options}
+      expect(savon_configs.fetch(:endpoint)).to eq(EXAMPLE_ENDPOINT)
+    end
+
+    it 'handles a nil endpoint' do
+      config.endpoint = nil
+      # this is ugly/brittle, but it's hard to see how else to test this
+      savon_configs = config.connection.globals.instance_eval {@options}
+      expect(savon_configs.fetch(:endpoint)).to eq(nil)
+    end
   end
 
   describe '#wsdl' do
@@ -166,6 +181,23 @@ describe NetSuite::Configuration do
     end
   end
 
+  describe '#endpoint' do
+    it 'can be set with endpoint=' do
+      config.endpoint = 42
+      expect(config.endpoint).to eq(42)
+    end
+
+    it 'can be set with just endpoint(value)' do
+      config.endpoint(42)
+      expect(config.endpoint).to eq(42)
+    end
+
+    it 'supports nil endpoints' do
+      config.endpoint = nil
+      expect(config.endpoint).to eq(nil)
+    end
+  end
+
   describe '#auth_header' do
     context 'when doing user authentication' do
       before do
@@ -326,15 +358,11 @@ describe NetSuite::Configuration do
 
   describe "#credentials" do
     context "when none are defined" do
-      skip "should properly create the auth credentials" do
-
-      end
+      skip "should properly create the auth credentials"
     end
 
     context "when they are defined" do
-      it "should properly replace the default auth credentials" do
-
-      end
+      skip "should properly replace the default auth credentials"
     end
   end
 
@@ -371,4 +399,81 @@ describe NetSuite::Configuration do
     end
   end
 
+  describe "#log" do
+    it 'allows a file path to be set as the log destination' do
+      file_path = Tempfile.new('tmplog').path
+      config.log = file_path
+      config.logger.info "foo"
+
+      log_contents = open(file_path).read
+      expect(log_contents).to include("foo")
+    end
+
+    it 'allows an IO device to bet set as the log destination' do
+      stream = StringIO.new
+      config.log = stream
+      config.logger.info "foo"
+
+      expect(stream.string).to include("foo")
+    end
+  end
+
+  describe '#log_level' do
+    it 'defaults to :debug' do
+      expect(config.log_level).to eq(:debug)
+    end
+
+    it 'can be initially set to any log level' do
+      config.log_level(:info)
+
+      expect(config.log_level).to eq(:info)
+    end
+
+    it 'can override itself' do
+      config.log_level = :info
+
+      expect(config.log_level).to eq(:info)
+
+      config.log_level(:debug)
+
+      expect(config.log_level).to eq(:debug)
+    end
+  end
+
+  describe '#log_level=' do
+    it 'can set the initial log_level' do
+      config.log_level = :info
+
+      expect(config.log_level).to eq(:info)
+    end
+
+    it 'can override a previously set log level' do
+      config.log_level = :info
+
+      expect(config.log_level).to eq(:info)
+
+      config.log_level = :debug
+
+      expect(config.log_level).to eq(:debug)
+    end
+  end
+
+  describe 'timeouts' do
+    it 'has defaults' do
+      expect(config.read_timeout).to eql(60)
+      expect(config.open_timeout).to be_nil
+    end
+
+    it 'sets timeouts' do
+      config.read_timeout = 100
+      config.open_timeout = 60
+
+      expect(config.read_timeout).to eql(100)
+      expect(config.open_timeout).to eql(60)
+
+      # ensure no exception is raised
+      config.connection
+    end
+  end
+
 end

data/spec/netsuite/records/basic_record_spec.rb

@@ -1,6 +1,7 @@
 require 'spec_helper'
 
 describe 'basic records' do
+  # all records with internal IDs should be added to this list
   let(:basic_record_list) {
     [
       NetSuite::Records::Currency,
@@ -25,6 +26,7 @@ describe 'basic records' do
       NetSuite::Records::CustomerDeposit,
       NetSuite::Records::NonInventoryPurchaseItem,
       NetSuite::Records::NonInventoryResaleItem,
+      NetSuite::Records::LotNumberedInventoryItem,
       NetSuite::Records::TaxGroup,
       NetSuite::Records::Folder,
       NetSuite::Records::CustomerCategory,
@@ -48,6 +50,7 @@ describe 'basic records' do
       NetSuite::Records::SerializedInventoryItem,
       NetSuite::Records::DepositApplication,
       NetSuite::Records::InventoryAdjustment,
+      NetSuite::Records::Vendor,
       NetSuite::Records::VendorReturnAuthorization,
       NetSuite::Records::AssemblyBuild,
       NetSuite::Records::AssemblyUnbuild,
@@ -60,6 +63,7 @@ describe 'basic records' do
       NetSuite::Records::BinTransfer,
       NetSuite::Records::SerializedAssemblyItem,
       NetSuite::Records::CustomerStatus,
+      NetSuite::Records::CustomerPayment,
       NetSuite::Records::TransactionBodyCustomField,
       NetSuite::Records::TransactionColumnCustomField,
       NetSuite::Records::EntityCustomField
@@ -107,8 +111,12 @@ describe 'basic records' do
 
       if !sublist_fields.empty?
         sublist_fields.each do |sublist_field|
+          sublist = record_instance.send(sublist_field)
+
           # TODO make a sublist entry with some fields valid for that sublist item
-          record_instance.send(sublist_field) << {}
+          sublist << {}
+
+          expect(sublist.send(sublist.sublist_key).count).to be(1)
         end
       end
 

data/spec/netsuite/records/classification_spec.rb

@@ -5,12 +5,21 @@ describe NetSuite::Records::Classification do
 
   it 'has all the right fields' do
     [
-      :name, :include_children, :is_inactive, :class_translation_list, :custom_field_list
+      :name, :include_children, :is_inactive, :class_translation_list
     ].each do |field|
       expect(classification).to have_field(field)
     end
 
     expect(classification.subsidiary_list.class).to eq(NetSuite::Records::RecordRefList)
+    expect(classification.custom_field_list.class).to eq(NetSuite::Records::CustomFieldList)
+  end
+
+  it 'has all the right record refs' do
+    [
+      :parent
+    ].each do |record_ref|
+      expect(classification).to have_record_ref(record_ref)
+    end
   end
 
   describe '.get' do

data/spec/netsuite/records/cost_category_spec.rb

@@ -0,0 +1,105 @@
+require 'spec_helper'
+
+describe NetSuite::Records::CostCategory do
+  let(:cost_category) { described_class.new }
+
+  it 'has all the right fields' do
+    [
+      :is_inactive,
+      :item_cost_type,
+      :name,
+    ].each do |field|
+      expect(cost_category).to have_field(field)
+    end
+  end
+
+  it 'has all the right record refs' do
+    [
+      :account,
+    ].each do |record_ref|
+      expect(cost_category).to have_record_ref(record_ref)
+    end
+  end
+
+  describe '.get' do
+    context 'when the response is successful' do
+      let(:response) { NetSuite::Response.new(:success => true, :body => { :name => 'CostCategory 1' }) }
+
+      it 'returns a CostCategory instance populated with the data from the response object' do
+        expect(NetSuite::Actions::Get).to receive(:call).with([described_class, {:external_id => 1}], {}).and_return(response)
+        cost_category = described_class.get(:external_id => 1)
+        expect(cost_category).to be_kind_of(described_class)
+        expect(cost_category.name).to eql('CostCategory 1')
+      end
+    end
+
+    context 'when the response is unsuccessful' do
+      let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
+
+      it 'raises a RecordNotFound exception' do
+        expect(NetSuite::Actions::Get).to receive(:call).with([described_class, {:external_id => 1}], {}).and_return(response)
+        expect {
+          described_class.get(:external_id => 1)
+        }.to raise_error(NetSuite::RecordNotFound,
+          /NetSuite::Records::CostCategory with OPTIONS=(.*) could not be found/)
+      end
+    end
+  end
+
+  describe '#add' do
+    let(:test_data) { { :name => 'Test CostCategory' } }
+
+    context 'when the response is successful' do
+      let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
+
+      it 'returns true' do
+        cost_category = described_class.new(test_data)
+        expect(NetSuite::Actions::Add).to receive(:call).
+            with([cost_category], {}).
+            and_return(response)
+        expect(cost_category.add).to be_truthy
+      end
+    end
+
+    context 'when the response is unsuccessful' do
+      let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
+
+      it 'returns false' do
+        cost_category = described_class.new(test_data)
+        expect(NetSuite::Actions::Add).to receive(:call).
+            with([cost_category], {}).
+            and_return(response)
+        expect(cost_category.add).to be_falsey
+      end
+    end
+  end
+
+  describe '#delete' do
+    let(:test_data) { { :internal_id => '1' } }
+
+    context 'when the response is successful' do
+      let(:response)  { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
+
+      it 'returns true' do
+        cost_category = described_class.new(test_data)
+        expect(NetSuite::Actions::Delete).to receive(:call).
+            with([cost_category], {}).
+            and_return(response)
+        expect(cost_category.delete).to be_truthy
+      end
+    end
+
+    context 'when the response is unsuccessful' do
+      let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
+
+      it 'returns false' do
+        cost_category = described_class.new(test_data)
+        expect(NetSuite::Actions::Delete).to receive(:call).
+            with([cost_category], {}).
+            and_return(response)
+        expect(cost_category.delete).to be_falsey
+      end
+    end
+  end
+
+end