netsuite 0.8.4 → 0.8.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4706d84cf53e7897cc7f420a4af5c22230f764d0
-  data.tar.gz: a0e4db30c9a0288633a73988b7bd74916a3dbc20
+  metadata.gz: 89b1dc6dad276f5db8f657634a3d125643ca198b
+  data.tar.gz: 586f0a9f83e7b1919a637a34f2d8fce536b8f2b4
 SHA512:
-  metadata.gz: 2afc60b0287c25b4a9cb4d271a363da58c5089ee0eb60d10d6f2334b06ac1bd1bbd902fce592034f53f0fe0a600147184a51668b3bf7c903513d3a1c1e310069
-  data.tar.gz: 5dadd1b9eae507ff201e01f3ab7f2d49e6e6a930d5ec1825fcc7ee2dd8087b71025a9e66700aa491b598a61606085b2c37a1f2f6f29457ade3693fe2809db925
+  metadata.gz: 76be28871d569715347328833f9521f8178879f17b93bb940fc10b9c960ef70652110ee85c4a277d02c6c21128f52c7cd762913331edcdacdc1463c853b81c7a
+  data.tar.gz: a9b49255201b452651df24646fc4d96e96b6d90b1b723a4170eb7f3fc276ea2f9281c609c440702be11e732f1a6e9145cfa67fdcb8537fca3c8f48d94d4057bb

data/.gitignore

@@ -16,3 +16,4 @@ test/tmp
 test/version_tmp
 tmp
 vendor/
+.tags*

data/Gemfile

@@ -7,7 +7,8 @@ gem 'pry-nav'
 gem 'pry-rescue'
 
 # optional dependency for more accurate timezone conversion
-gem 'tzinfo'
+gem 'tzinfo', '1.2.5'
+# gem 'tzinfo', '2.0.0'
 
 # required for CircleCI to build properly with ruby 1.9.3
 gem 'json', '~> 1.8.3'

data/README.md

@@ -60,14 +60,36 @@ This gem is built for ruby 1.9.x+, checkout the [1-8-stable](https://github.com/
 
 ## Configuration
 
-Not sure how to find your account id? Search for "web service preferences" in the NetSuite global search.
+The most important thing you'll need is your NetSuite account ID. Not sure how to find your account id? [Here's a guide.](http://mikebian.co/find-netsuite-web-services-account-number/)
+
+For most use-cases, the following configuration will be sufficient:
 
 ```ruby
 NetSuite.configure do
   reset!
 
-  # optional, defaults to 2011_2
-  api_version	'2012_1'
+  account  'TSTDRV1576318'
+  api_version '2018_2'
+
+  email 'email@example.com'
+  password 'password'
+  role 10
+
+  # use `NetSuite::Utilities.netsuite_data_center_urls('TSTDRV1576318')` to retrieve the URL
+  # you'll want to do this in a background proces and strip the protocol out of the return string
+  wsdl_domain 'tstdrv1576318.suitetalk.api.netsuite.com'
+end
+```
+
+The `wsdl_domain` configuration is most important. Note that if you use `wsdl` or other configuration options below, you'll want to look at the configuration source to understand more about how the different options interact with each other. Some of the configuration options will mutate the state of other options.
+
+Here's the various options that are are available for configuration:
+
+```ruby
+NetSuite.configure do
+  reset!
+
+  api_version	'2018_2'
 
   # optionally specify full wsdl URL (to switch to sandbox, for example)
   wsdl          "https://webservices.sandbox.netsuite.com/wsdl/v#{api_version}_0/netsuite.wsdl"
@@ -79,21 +101,18 @@ NetSuite.configure do
   # construct the full wsdl location - e.g. "https://#{wsdl_domain}/wsdl/v#{api_version}_0/netsuite.wsdl"
   wsdl_domain   "webservices.na2.netsuite.com"
 
-  # or specify the sandbox flag if you don't want to deal with specifying a full URL
-  sandbox       true
-
   # often the netsuite servers will hang which would cause a timeout exception to be raised
-  # if you don't mind waiting (e.g. processing NS via DJ), increasing the timeout should fix the issue
-  read_timeout  100000
+  # if you don't mind waiting (e.g. processing NS via a background worker), increasing the timeout should fix the issue
+  read_timeout  100_000
 
   # you can specify a file or file descriptor to send the log output to (defaults to STDOUT)
   log           File.join(Rails.root, 'log/netsuite.log')
 
-  # login information
-  email    	'email@domain.com'
-  password 	'password'
+  # password-based login information
+  email    	  'email@domain.com'
+  password 	  'password'
   account   	'12345'
-  role      	1111
+  role        1111
 
   # optional, ensures that read-only fields don't cause API errors
   soap_header	'platformMsgs:preferences' => {

data/lib/netsuite.rb

@@ -206,8 +206,10 @@ module NetSuite
     autoload :Location,                         'netsuite/records/location'
     autoload :LocationsList,                    'netsuite/records/locations_list'
     autoload :LotNumberedAssemblyItem,          'netsuite/records/lot_numbered_assembly_item'
+    autoload :LotNumberedInventoryItem,         'netsuite/records/lot_numbered_inventory_item'
     autoload :MatrixOptionList,                 'netsuite/records/matrix_option_list'
     autoload :MemberList,                       'netsuite/records/member_list'
+    autoload :Message,                          'netsuite/records/message'
     autoload :NonInventorySaleItem,             'netsuite/records/non_inventory_sale_item'
     autoload :NonInventoryPurchaseItem,         'netsuite/records/non_inventory_purchase_item'
     autoload :NonInventoryResaleItem,           'netsuite/records/non_inventory_resale_item'
@@ -261,6 +263,7 @@ module NetSuite
     autoload :Subsidiary,                       'netsuite/records/subsidiary'
     autoload :SubtotalItem,                     'netsuite/records/subtotal_item'
     autoload :SupportCase,                      'netsuite/records/support_case'
+    autoload :SupportCaseType,                  'netsuite/records/support_case_type'
     autoload :TaxType,                          'netsuite/records/tax_type'
     autoload :TaxGroup,                         'netsuite/records/tax_group'
     autoload :Task,                             'netsuite/records/task'
@@ -309,23 +312,4 @@ module NetSuite
     NetSuite::Configuration.instance_eval(&block)
   end
 
-  def self.configure_from_env(&block)
-    NetSuite.configure do
-      reset!
-
-      email         ENV['NETSUITE_EMAIL']     unless ENV['NETSUITE_EMAIL'].nil?
-      password      ENV['NETSUITE_PASSWORD']  unless ENV['NETSUITE_PASSWORD'].nil?
-      account       ENV['NETSUITE_ACCOUNT']   unless ENV['NETSUITE_ACCOUNT'].nil?
-      role          ENV['NETSUITE_ROLE']      unless ENV['NETSUITE_ROLE'].nil?
-      api_version   ENV['NETSUITE_API']       unless ENV['NETSUITE_API'].nil?
-      sandbox       (ENV['NETSUITE_PRODUCTION'].nil? || ENV['NETSUITE_PRODUCTION'] != 'true')
-      wsdl          ENV['NETSUITE_WSDL']      unless ENV['NETSUITE_WSDL'].nil?
-      silent        (!ENV['NETSUITE_SILENT'].nil? && ENV['NETSUITE_SILENT'] == 'true')
-
-      read_timeout  100_000
-    end
-
-    self.configure(&block) if block
-  end
-
 end

data/lib/netsuite/actions/login.rb

@@ -28,6 +28,14 @@ module NetSuite
       # </platformCore:wsRoleList>
 
       def self.call(credentials)
+
+        soap_header = {}
+        if !credentials[:application_id].nil? && !credentials[:application_id].empty?
+          soap_header = NetSuite::Configuration.soap_header.dup
+          soap_header['platformMsgs:ApplicationInfo'] ||= {}
+          soap_header['platformMsgs:ApplicationInfo']['platformMsgs:applicationId'] = credentials[:application_id]
+        end
+
         passport = NetSuite::Configuration.auth_header.dup
 
 
@@ -39,13 +47,13 @@ module NetSuite
         if passport['platformMsgs:tokenPassport']
           passport['platformMsgs:passport']['platformCore:account'] ||= passport['platformMsgs:tokenPassport']['platformCore:account']
         end
-        
+
         passport['platformMsgs:passport']['platformCore:account'] = credentials[:account] if !credentials[:account].nil?
 
         passport.delete('platformMsgs:tokenPassport')
 
         begin
-          response = NetSuite::Configuration.connection(soap_header: {}).call :login, message: passport
+          response = NetSuite::Configuration.connection(soap_header: soap_header).call :login, message: passport
         rescue Savon::SOAPFault => e
           error_details = e.to_hash[:fault]
 

data/lib/netsuite/actions/upsert.rb

@@ -37,6 +37,8 @@ module NetSuite
           hash['platformMsgs:record']['@platformMsgs:externalId'] = @object.external_id
         end
 
+        # setting the internal ID on upsert will result in `CANT_SET_INTERNALID`
+
         hash
       end
 

data/lib/netsuite/configuration.rb

@@ -18,6 +18,7 @@ module NetSuite
       client = Savon.client({
         wsdl: cached_wsdl || wsdl,
         read_timeout: read_timeout,
+        open_timeout: open_timeout,
         namespaces: namespaces,
         soap_header: auth_header(credentials).update(soap_header),
         pretty_print_xml: true,
@@ -326,6 +327,18 @@ module NetSuite
       end
     end
 
+    def open_timeout=(timeout)
+      attributes[:open_timeout] = timeout
+    end
+
+    def open_timeout(timeout = nil)
+      if timeout
+        self.open_timeout = timeout
+      else
+        attributes[:open_timeout]
+      end
+    end
+
     def log=(path)
       attributes[:log] = path
     end

data/lib/netsuite/records/lot_numbered_inventory_item.rb

@@ -0,0 +1,116 @@
+module NetSuite
+  module Records
+    class LotNumberedInventoryItem
+      include Support::Fields
+      include Support::RecordRefs
+      include Support::Records
+      include Support::Actions
+      include Namespaces::ListAcct
+
+      # http://www.netsuite.com/help/helpcenter/en_US/srbrowser/Browser2018_2/schema/record/lotnumberedinventoryitem.html
+
+      # TODO
+      # countryOfManufacture	Country
+      # hazmatPackingGroup	HazmatPackingGroup
+      # accountingBookDetailList	ItemAccountingBookDetailList
+      # costEstimateType	ItemCostEstimateType
+      # costingMethod	ItemCostingMethod
+      # invtClassification	ItemInvtClassification
+      # matrixType	ItemMatrixType
+      # itemOptionsList	ItemOptionsList
+      # outOfStockBehavior	ItemOutOfStockBehavior
+      # overallQuantityPricingType	ItemOverallQuantityPricingType
+      # preferenceCriterion	ItemPreferenceCriterion
+      # itemVendorList	ItemVendorList
+      # weightUnit	ItemWeightUnit
+      # hierarchyVersionsList	LotNumberedInventoryItemHierarchyVersionsList
+      # numbersList	LotNumberedInventoryItemNumbersList
+      # periodicLotSizeType	PeriodicLotSizeType
+      # presentationItemList	PresentationItemList
+      # productFeedList	ProductFeedList
+
+      field :pricing_matrix, PricingMatrix
+      field :custom_field_list, CustomFieldList
+      field :bin_number_list, BinNumberList
+      field :locations_list, LocationsList
+      field :item_vendor_list, ItemVendorList
+      field :matrix_option_list, MatrixOptionList
+      field :subsidiary_list, RecordRefList
+
+      actions :get, :get_list, :add, :delete, :search, :update, :upsert, :update_list
+
+      record_refs :alternate_demand_source_item, :asset_account, :bill_exch_rate_variance_acct,
+                  :billing_schedule, :bill_price_variance_acct, :bill_qty_variance_acct,
+                  :klass, :cogs_account, :cost_category, :create_revenue_plans_on,
+                  :custom_form, :default_item_ship_method, :deferred_revenue_account,
+                  :demand_source, :department, :dropship_expense_account, :gain_loss_account,
+                  :income_account, :interco_cogs_account, :interco_income_account,
+                  :issue_product, :item_revenue_category, :location, :parent, :preferred_location,
+                  :pricing_group, :purchase_price_variance_acct, :purchase_tax_code, :purchase_unit,
+                  :quantity_pricing_schedule, :revenue_allocation_group, :revenue_recognition_rule,
+                  :rev_rec_forecast_rule, :rev_rec_schedule, :sales_tax_code, :sale_unit,
+                  :ship_package, :soft_descriptor, :stock_unit, :store_display_image,
+                  :store_display_thumbnail, :store_item_template, :supply_lot_sizing_method,
+                  :supply_replenishment_method, :supply_type, :tax_schedule, :units_type, :vendor
+
+      # TODO
+      # itemNumberOptionsList	RecordRefList
+      # itemShipMethodList	RecordRefList
+      # subsidiaryList	RecordRefList
+      # scheduleBCode	ScheduleBCode
+      # itemCarrier	ShippingCarrier
+      # siteCategoryList	SiteCategoryList
+      # sitemapPriority	SitemapPriority
+      # translationsList	TranslationList
+      # vsoeDeferral	VsoeDeferral
+      # vsoePermitDiscount	VsoePermitDiscount
+      # vsoeSopGroup	VsoeSopGroup
+
+      fields  :auto_lead_time, :auto_preferred_stock_level, :auto_reorder_point, :available_to_partners,
+              :copy_description, :direct_revenue_posting, :dont_show_price, :enforce_min_qty_internally,
+              :exclude_from_sitemap, :include_children, :is_donation_item, :is_drop_ship_item, :is_gco_compliant,
+              :is_hazmat_item, :is_inactive, :is_online, :is_special_order_item, :is_store_pickup_allowed,
+              :is_taxable, :match_bill_to_receipt, :mult_manufacture_addr, :offer_support, :on_special,
+              :prices_include_tax, :producer, :round_up_as_component, :seasonal_demand, :ship_individually,
+              :show_default_donation_amount, :track_landed_cost, :use_bins, :use_marginal_rates, :vsoe_delivered,
+              :created_date, :expiration_date, :last_invt_count_date, :last_modified_date, :next_invt_count_date,
+              :average_cost, :cost, :cost_estimate, :default_return_cost, :demand_modifier, :fixed_lot_size,
+              :handling_cost, :hazmat_item_units_qty, :last_purchase_price, :max_donation_amount,
+              :on_hand_value_mli, :preferred_stock_level, :preferred_stock_level_days, :purchase_order_amount,
+              :purchase_order_quantity, :purchase_order_quantity_diff, :quantity_available,
+              :quantity_back_ordered, :quantity_committed, :quantity_on_hand, :quantity_on_order,
+              :rate, :receipt_amount, :receipt_quantity, :receipt_quantity_diff, :reorder_point,
+              :safety_stock_level, :shipping_cost, :total_value, :transfer_price, :vsoe_price,
+              :weight, :backward_consumption_days, :demand_time_fence, :forward_consumption_days,
+              :invt_count_interval, :lead_time, :maximum_quantity, :minimum_quantity, :periodic_lot_size_days,
+              :reorder_multiple, :reschedule_in_days, :reschedule_out_days, :safety_stock_level_days,
+              :schedule_b_quantity, :shopzilla_category_id, :supply_time_fence, :costing_method_display,
+              :cost_units, :currency, :display_name, :featured_description, :handling_cost_units,
+              :hazmat_hazard_class, :hazmat_id, :hazmat_item_units, :hazmat_shipping_name, :item_id,
+              :manufacturer, :manufacturer_addr1, :manufacturer_city, :manufacturer_state,
+              :manufacturer_tariff, :manufacturer_tax_id, :manufacturer_zip, :matrix_item_name_template,
+              :meta_tag_html, :minimum_quantity_units, :mpn, :nex_tag_category, :no_price_message,
+              :out_of_stock_message, :page_title, :preferred_stock_level_units, :purchase_description,
+              :quantity_on_hand_units, :quantity_reorder_units, :related_items_description,
+              :reorder_point_units, :safety_stock_level_units, :sales_description, :schedule_b_number,
+              :search_keywords, :serial_numbers, :shipping_cost_units, :shopping_dot_com_category,
+              :specials_description, :stock_description, :store_description, :store_detailed_description,
+              :store_display_name, :upc_code, :url_component, :vendor_name, :weight_units
+
+
+      attr_reader :internal_id
+      attr_accessor :external_id, :search_joins
+
+      def initialize(attributes = {})
+        @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
+        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
+        initialize_from_attributes_hash(attributes)
+      end
+
+      def self.search_class_name
+        "Item"
+      end
+
+    end
+  end
+end

data/lib/netsuite/records/matrix_option_list.rb

@@ -15,10 +15,14 @@ module NetSuite
       #
       #   <listAcct:matrixOptionList>
       #     <listAcct:matrixOption internalId="45" scriptId="custitem13">
-      #       <platformCore:value internalId="4" typeId="28"/>
+      #       <platformCore:value internalId="4" typeId="28">
+      #         <platformCore:name>foo</platformCore:name>
+      #       </platformCore:value>
       #     </listAcct:matrixOption>
       #     <listAcct:matrixOption internalId="46" scriptId="custitem14">
-      #       <platformCore:value internalId="1" typeId="29"/>
+      #       <platformCore:value internalId="1" typeId="29">
+      #         <platformCore:name>bar</platformCore:name>
+      #       </platformCore:value>
       #     </listAcct:matrixOption>
       #   </listAcct:matrixOptionList>
       #
@@ -27,13 +31,17 @@ module NetSuite
         when Hash
           options << OpenStruct.new(
             type_id: attributes[:matrix_option][:value][:'@type_id'],
-            value_id: attributes[:matrix_option][:value][:'@internal_id']
+            value_id: attributes[:matrix_option][:value][:'@internal_id'],
+            script_id: attributes[:matrix_option][:@script_id],
+            name: attributes[:matrix_option][:value][:name]
           )
         when Array
           attributes[:matrix_option].each do |option|
             options << OpenStruct.new(
               type_id: option[:value][:'@type_id'],
-              value_id: option[:value][:'@internal_id']
+              value_id: option[:value][:'@internal_id'],
+              script_id: option[:@script_id],
+              name: option[:value][:name]
             )
           end
         end

data/lib/netsuite/records/message.rb

@@ -0,0 +1,30 @@
+module NetSuite
+  module Records
+    class Message
+      include Support::Fields
+      include Support::RecordRefs
+      include Support::Records
+      include Support::Actions
+      include Namespaces::CommGeneral
+
+      actions :get, :add, :delete, :search
+      
+      fields :bcc, :cc, :compress_attachments, :date_time, :emailed, :incoming,
+             :message, :record_name, :record_type_name, :subject
+
+      read_only_fields :last_modified_date, :message_date
+
+      record_refs :activity, :author, :recipient, :transaction
+
+      attr_reader :internal_id
+      attr_accessor :external_id
+
+      def initialize(attributes_or_record = {})
+        @internal_id = attributes_or_record.delete(:internal_id) || attributes_or_record.delete(:@internal_id)
+        @external_id = attributes_or_record.delete(:external_id) || attributes_or_record.delete(:@external_id)
+        initialize_from_attributes_hash(attributes_or_record)
+      end
+
+    end
+  end
+end

data/lib/netsuite/records/non_inventory_sale_item.rb

@@ -10,7 +10,7 @@ module NetSuite
       actions :get, :get_list, :add, :delete, :search, :update, :upsert
 
       fields :available_to_partners, :cost_estimate, :cost_estimate_type, :cost_estimate_units, :country_of_manufacture,
-        :created_date, :display_name, :dont_show_price, :enforce_min_qty_internally, :exclude_from_sitemap,
+        :created_date, :direct_revenue_posting, :display_name, :dont_show_price, :enforce_min_qty_internally, :exclude_from_sitemap,
         :featured_description, :handling_cost, :handling_cost_units, :include_children, :is_donation_item, :is_fulfillable,
         :is_gco_compliant, :is_inactive, :is_online, :is_taxable, :item_id, :last_modified_date, :manufacturer,
         :manufacturer_addr1, :manufacturer_city, :manufacturer_state, :manufacturer_tariff, :manufacturer_tax_id,

data/lib/netsuite/records/other_charge_sale_item.rb

@@ -52,11 +52,11 @@ module NetSuite
                   :units_type, :sales_tax_code, :sale_unit, :tax_schedule, :parent
 
       field :custom_field_list, CustomFieldList
-      # :pricing_matrix,
+      field :pricing_matrix, PricingMatrix
       # :translations_list,
       # :matrix_option_list,
       # :item_options_list
-      # :subsidiary_list,
+      field :subsidiary_list, RecordRefList
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/support_case_type.rb

@@ -0,0 +1,26 @@
+module NetSuite
+  module Records
+    class SupportCaseType
+      include Support::Fields
+      include Support::RecordRefs
+      include Support::Records
+      include Support::Actions
+      include Namespaces::ListSupport
+
+      actions :get
+
+      fields :description, :is_inactive, :name
+      
+      record_refs :insert_before
+
+      attr_reader   :internal_id
+      attr_accessor :external_id
+
+      def initialize(attributes = {})
+        @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
+        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
+        initialize_from_attributes_hash(attributes)
+      end
+    end
+  end
+end

data/lib/netsuite/records/tax_group.rb

@@ -7,8 +7,8 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      # NOTE `get_all` is not available in recent API versions ~2017_2
-      #      `search` is only available in recent API versions
+      # NOTE `get_all` is not available API > 2017_1
+      #      `search` is available API > 2016_2
       actions :get, :get_list, :add, :initialize, :delete, :update, :upsert, :search, :get_all
 
       fields :city, :county, :description, :include_children, :is_default, :is_inactive,

data/lib/netsuite/support/search_result.rb

@@ -29,8 +29,19 @@ module NetSuite
         if @total_records > 0
           if response.body.has_key?(:record_list)
             # basic search results
-            record_list = response.body[:record_list][:record]
-            record_list = [record_list] unless record_list.is_a?(Array)
+
+            #  `recordList` node can contain several nested `record` nodes, only one node or be empty
+            #  so we have to handle all these cases:
+            #    * { record_list: nil }
+            #    * { record_list: { record: => {...} } }
+            #    * { record_list: { record: => [{...}, {...}, ...] } }
+            record_list = if response.body[:record_list].nil?
+              []
+            elsif response.body[:record_list][:record].is_a?(Array)
+              response.body[:record_list][:record]
+            else
+              [response.body[:record_list][:record]]
+            end
 
             record_list.each do |record|
               results << result_class.new(record)

data/lib/netsuite/utilities.rb

@@ -115,6 +115,7 @@ module NetSuite
           # https://github.com/stripe/stripe-netsuite/issues/815
           if !e.message.include?("Only one request may be made against a session at a time") &&
             !e.message.include?('java.util.ConcurrentModificationException') &&
+            !e.message.include?('java.lang.NullPointerException') &&
             !e.message.include?('java.lang.IllegalStateException') &&
             !e.message.include?('java.lang.reflect.InvocationTargetException') &&
             !e.message.include?('com.netledger.common.exceptions.NLDatabaseOfflineException') &&
@@ -173,6 +174,7 @@ module NetSuite
       ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::KitItem, ns_item_internal_id, opts)
       ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::SerializedInventoryItem, ns_item_internal_id, opts)
       ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::LotNumberedAssemblyItem, ns_item_internal_id, opts)
+      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::LotNumberedInventoryItem, ns_item_internal_id, opts)
 
       if ns_item.nil?
         fail NetSuite::RecordNotFound, "item with ID #{ns_item_internal_id} not found"
@@ -277,16 +279,25 @@ module NetSuite
       # NetSuite requires that the time be passed to the API with the PDT TZ offset
       # of the time passed in (i.e. not the current TZ offset of PDT)
 
-      offset = Rational(-7, 24)
-      
       if defined?(TZInfo)
-        time = TZInfo::Timezone.get("America/Los_Angeles").utc_to_local(time)
-        offset = time.offset
+        # if no version is defined, less than 2.0
+        # https://github.com/tzinfo/tzinfo/blob/master/CHANGES.md#added
+        if !defined?(TZInfo::VERSION)
+          # https://stackoverflow.com/questions/2927111/ruby-get-time-in-given-timezone
+          offset = TZInfo::Timezone.get("America/Los_Angeles").period_for_utc(time).utc_total_offset_rational
+          time = time.new_offset(offset)
+        else
+          time = TZInfo::Timezone.get("America/Los_Angeles").utc_to_local(time)
+          offset = time.offset
+        end
       else
+        # if tzinfo is not installed, let's give it our best guess: -7
+        offset = Rational(-7, 24)
         time = time.new_offset("-07:00")
       end
 
-      (time + (offset * -1)).iso8601
+      time = (time + (offset * -1))
+      time.iso8601
     end
 
   end

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module NetSuite
-  VERSION = '0.8.4'
+  VERSION = '0.8.5'
 end

data/netsuite.gemspec

@@ -17,5 +17,5 @@ Gem::Specification.new do |gem|
 
   gem.add_dependency 'savon', '>= 2.3.0'
 
-  gem.add_development_dependency 'rspec', '~> 3.1.0'
+  gem.add_development_dependency 'rspec', '~> 3.8.0'
 end

data/spec/netsuite/configuration_spec.rb

@@ -371,4 +371,22 @@ describe NetSuite::Configuration do
     end
   end
 
+  describe 'timeouts' do
+    it 'has defaults' do
+      expect(config.read_timeout).to eql(60)
+      expect(config.open_timeout).to be_nil
+    end
+
+    it 'sets timeouts' do
+      config.read_timeout = 100
+      config.open_timeout = 60
+
+      expect(config.read_timeout).to eql(100)
+      expect(config.open_timeout).to eql(60)
+
+      # ensure no exception is raised
+      config.connection
+    end
+  end
+
 end

data/spec/netsuite/records/basic_record_spec.rb

@@ -25,6 +25,7 @@ describe 'basic records' do
       NetSuite::Records::CustomerDeposit,
       NetSuite::Records::NonInventoryPurchaseItem,
       NetSuite::Records::NonInventoryResaleItem,
+      NetSuite::Records::LotNumberedInventoryItem,
       NetSuite::Records::TaxGroup,
       NetSuite::Records::Folder,
       NetSuite::Records::CustomerCategory,

data/spec/netsuite/records/matrix_option_list_spec.rb

@@ -5,20 +5,30 @@ module NetSuite
   module Records
     describe MatrixOptionList do
       it "deals with hash properly" do
-        hash = {:value=>{:@internal_id=>"1", :@type_id=>"36"}}
+        hash = {:value=>{:@internal_id=>"1", :@type_id=>"36", :name=>"some value"}, :@script_id=>'cust_field_1'}
 
         list = described_class.new({ matrix_option: hash })
-        expect(list.options.first.value_id).to eq "1"
+        option = list.options.first
+        expect(option.value_id).to eq "1"
+        expect(option.type_id).to eq "36"
+        expect(option.name).to eq "some value"
+        expect(option.script_id).to eq "cust_field_1"
       end
 
       it "deals with arrays properly" do
         array = [
-          {:value=>{:@internal_id=>"2", :@type_id=>"28"}},
-          {:value=>{:@internal_id=>"1", :@type_id=>"29"}}
+          {:value=>{:@internal_id=>"2", :@type_id=>"28", :name=>"some value 28"}, :@script_id=>'cust_field_28'},
+          {:value=>{:@internal_id=>"1", :@type_id=>"29", :name=>"some value 29"}, :@script_id=>'cust_field_29'}
         ]
 
         list = described_class.new({ matrix_option: array })
-        expect(list.options.first.value_id).to eq "2"
+        expect(list.options.count).to eq 2
+
+        option = list.options.first
+        expect(option.value_id).to eq "2"
+        expect(option.type_id).to eq "28"
+        expect(option.name).to eq "some value 28"
+        expect(option.script_id).to eq "cust_field_28"
       end
     end
   end

data/spec/netsuite/records/message_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe NetSuite::Records::Message do
+  let(:message) { NetSuite::Records::Message.new }
+
+  it 'has all the right fields' do
+    [
+      :bcc, :cc, :compress_attachments, :date_time, :emailed,
+      :incoming, :message, :record_name, :record_type_name, :subject,
+      :last_modified_date, :message_date
+    ].each do |field|
+      expect(message).to have_field(field)
+    end
+  end
+
+  it 'has the right record_refs' do
+    [
+      :activity, :author, :recipient, :transaction
+    ].each do |record_ref|
+      expect(message).to have_record_ref(record_ref)
+    end
+  end
+
+  describe '.get' do
+    context 'when the response is successful' do
+      let(:response) { NetSuite::Response.new(:success => true, :body => {message: 'message text'})}
+
+      it 'returns a Message instance populated with data from the response object' do
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Message, :external_id => 1], {}).and_return(response)
+
+        message = NetSuite::Records::Message.get(:external_id => 1)
+        expect(message).to be_kind_of(NetSuite::Records::Message)
+        expect(message.message).to eq('message text')
+      end
+    end
+
+    context 'when response is unsuccessful' do
+      let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
+      it 'raises a RecordNotFound exception' do
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Message, :external_id => 1], {}).and_return(response)
+        expect {
+          NetSuite::Records::Message.get(:external_id => 1)
+        }.to raise_error(NetSuite::RecordNotFound,
+                         /NetSuite::Records::Message with OPTIONS=(.*) could not be found/)
+      end
+    end
+  end
+
+end

data/spec/netsuite/records/non_inventory_sale_item_spec.rb

@@ -6,7 +6,7 @@ describe NetSuite::Records::NonInventorySaleItem do
   it 'has the right fields' do
     [
       :available_to_partners, :cost_estimate, :cost_estimate_type, :cost_estimate_units, :country_of_manufacture, :created_date,
-      :display_name, :dont_show_price, :enforce_min_qty_internally, :exclude_from_sitemap,
+      :direct_revenue_posting, :display_name, :dont_show_price, :enforce_min_qty_internally, :exclude_from_sitemap,
       :featured_description, :handling_cost, :handling_cost_units, :include_children, :is_donation_item, :is_fulfillable,
       :is_gco_compliant, :is_inactive, :is_online, :is_taxable, :item_id, :last_modified_date, :manufacturer, :manufacturer_addr1,
       :manufacturer_city, :manufacturer_state, :manufacturer_tariff, :manufacturer_tax_id, :manufacturer_zip, :matrix_option_list,

data/spec/netsuite/records/support_case_type_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe NetSuite::Records::SupportCaseType do
+  let(:support_case_type) { NetSuite::Records::SupportCaseType.new }
+
+  it 'has all the right fields' do
+    [
+      :description, :is_inactive, :name
+    ].each do |field|
+      expect(support_case_type).to have_field(field)
+    end
+  end
+
+  it 'has the right record_refs' do
+    [
+      :insert_before
+    ].each do |record_ref|
+      expect(support_case_type).to have_record_ref(record_ref)
+    end
+  end
+
+end

data/spec/netsuite/support/search_result_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe NetSuite::Support::SearchResult do
+  describe '#results' do
+    context 'empty page' do
+      it 'returns empty array' do
+        response_body = {
+          :status => {:@is_success=>"true"},
+          :total_records => "242258",
+          :page_size => "10",
+          :total_pages => "24226",
+          :page_index => "99",
+          :search_id => "WEBSERVICES_4132604_SB1_051620191060155623420663266_336cbf12",
+          :record_list => nil,
+          :"@xmlns:platform_core" => "urn:core_2016_2.platform.webservices.netsuite.com"
+        }
+        response = NetSuite::Response.new(body: response_body)
+
+        results = described_class.new(response, NetSuite::Actions::Search, {}).results
+        expect(results).to eq []
+      end
+    end
+  end
+end

data/spec/netsuite/utilities_spec.rb

@@ -3,24 +3,29 @@ require 'spec_helper'
 describe NetSuite::Utilities do
   describe 'time utilities' do
     it '#normalize_time_to_netsuite_date' do
-      stamp = DateTime.parse('Wed, 27 Jul 2016 00:00:00 -0000')
-      formatted_date = NetSuite::Utilities.normalize_time_to_netsuite_date(stamp.to_time.to_i)
-      expect(formatted_date).to eq('2016-07-27T00:00:00-07:00')
+      ['Etc/UTC', 'America/Los_Angeles', 'America/Denver'].each do |zone|
+        ENV['TZ'] = zone
+        puts "In zone: #{zone}"
 
-      no_dst_stamp = DateTime.parse('Sun, November 6 2017 00:00:00 -0000')
-      formatted_date = NetSuite::Utilities.normalize_time_to_netsuite_date(no_dst_stamp.to_time.to_i)
-      expect(formatted_date).to eq('2017-11-06T00:00:00-08:00')
+        stamp = DateTime.parse('Wed, 27 Jul 2016 00:00:00 -0000')
+        formatted_date = NetSuite::Utilities.normalize_time_to_netsuite_date(stamp.to_time.to_i)
+        expect(formatted_date).to eq('2016-07-27T00:00:00-07:00')
 
-      no_dst_stamp_with_time = DateTime.parse('Sun, November 6 2017 12:11:10 -0000')
-      formatted_date = NetSuite::Utilities.normalize_time_to_netsuite_date(no_dst_stamp_with_time.to_time.to_i)
-      expect(formatted_date).to eq('2017-11-06T00:00:00-08:00')
+        no_dst_stamp = DateTime.parse('Sun, November 6 2017 00:00:00 -0000')
+        formatted_date = NetSuite::Utilities.normalize_time_to_netsuite_date(no_dst_stamp.to_time.to_i)
+        expect(formatted_date).to eq('2017-11-06T00:00:00-08:00')
+
+        no_dst_stamp_with_time = DateTime.parse('Sun, November 6 2017 12:11:10 -0000')
+        formatted_date = NetSuite::Utilities.normalize_time_to_netsuite_date(no_dst_stamp_with_time.to_time.to_i)
+        expect(formatted_date).to eq('2017-11-06T00:00:00-08:00')
+      end
     end
   end
 
   it "#netsuite_data_center_urls" do
     domains = NetSuite::Utilities.netsuite_data_center_urls('TSTDRV1576318')
-    expect(domains[:webservices_domain]).to eq('https://webservices.netsuite.com')
-    expect(domains[:system_domain]).to eq('https://system.netsuite.com')
+    expect(domains[:webservices_domain]).to eq('https://tstdrv1576318.suitetalk.api.netsuite.com')
+    expect(domains[:system_domain]).to eq('https://tstdrv1576318.app.netsuite.com')
 
     # ensure domains returned don't change when sandbox is enabled
     NetSuite.configure do
@@ -29,8 +34,8 @@ describe NetSuite::Utilities do
     end
 
     domains = NetSuite::Utilities.netsuite_data_center_urls('TSTDRV1576318')
-    expect(domains[:webservices_domain]).to eq('https://webservices.netsuite.com')
-    expect(domains[:system_domain]).to eq('https://system.netsuite.com')
+    expect(domains[:webservices_domain]).to eq('https://tstdrv1576318.suitetalk.api.netsuite.com')
+    expect(domains[:system_domain]).to eq('https://tstdrv1576318.app.netsuite.com')
 
     NetSuite.configure do
       reset!
@@ -38,8 +43,8 @@ describe NetSuite::Utilities do
     end
 
     domains = NetSuite::Utilities.netsuite_data_center_urls('TSTDRV1576318')
-    expect(domains[:webservices_domain]).to eq('https://webservices.netsuite.com')
-    expect(domains[:system_domain]).to eq('https://system.netsuite.com')
+    expect(domains[:webservices_domain]).to eq('https://tstdrv1576318.suitetalk.api.netsuite.com')
+    expect(domains[:system_domain]).to eq('https://tstdrv1576318.app.netsuite.com')
 
     domains = NetSuite::Utilities.netsuite_data_center_urls('4810331')
     expect(domains[:webservices_domain]).to eq('https://4810331.suitetalk.api.netsuite.com')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netsuite
 version: !ruby/object:Gem::Version
-  version: 0.8.4
+  version: 0.8.5
 platform: ruby
 authors:
 - Ryan Moran
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-08 00:00:00.000000000 Z
+date: 2019-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -31,14 +31,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.8.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.8.0
 description: NetSuite SuiteTalk API Wrapper
 email:
 - ryan.moran@gmail.com
@@ -234,8 +234,10 @@ files:
 - lib/netsuite/records/location.rb
 - lib/netsuite/records/locations_list.rb
 - lib/netsuite/records/lot_numbered_assembly_item.rb
+- lib/netsuite/records/lot_numbered_inventory_item.rb
 - lib/netsuite/records/matrix_option_list.rb
 - lib/netsuite/records/member_list.rb
+- lib/netsuite/records/message.rb
 - lib/netsuite/records/non_inventory_purchase_item.rb
 - lib/netsuite/records/non_inventory_resale_item.rb
 - lib/netsuite/records/non_inventory_sale_item.rb
@@ -289,6 +291,7 @@ files:
 - lib/netsuite/records/subsidiary.rb
 - lib/netsuite/records/subtotal_item.rb
 - lib/netsuite/records/support_case.rb
+- lib/netsuite/records/support_case_type.rb
 - lib/netsuite/records/task.rb
 - lib/netsuite/records/tax_group.rb
 - lib/netsuite/records/tax_type.rb
@@ -436,6 +439,7 @@ files:
 - spec/netsuite/records/kit_item_spec.rb
 - spec/netsuite/records/location_spec.rb
 - spec/netsuite/records/matrix_option_list_spec.rb
+- spec/netsuite/records/message_spec.rb
 - spec/netsuite/records/non_inventory_sale_item_spec.rb
 - spec/netsuite/records/note_spec.rb
 - spec/netsuite/records/note_type_spec.rb
@@ -458,6 +462,7 @@ files:
 - spec/netsuite/records/site_category_spec.rb
 - spec/netsuite/records/subsidiary_spec.rb
 - spec/netsuite/records/support_case_spec.rb
+- spec/netsuite/records/support_case_type_spec.rb
 - spec/netsuite/records/tax_type_spec.rb
 - spec/netsuite/records/term_spec.rb
 - spec/netsuite/records/transaction_body_custom_field_spec.rb
@@ -485,6 +490,7 @@ files:
 - spec/netsuite/support/record_refs_spec.rb
 - spec/netsuite/support/records_spec.rb
 - spec/netsuite/support/requests_spec.rb
+- spec/netsuite/support/search_result_spec.rb
 - spec/netsuite/support/sublist_spec.rb
 - spec/netsuite/utilities/data_center_spec.rb
 - spec/netsuite/utilities/request_spec.rb
@@ -646,6 +652,7 @@ test_files:
 - spec/netsuite/records/kit_item_spec.rb
 - spec/netsuite/records/location_spec.rb
 - spec/netsuite/records/matrix_option_list_spec.rb
+- spec/netsuite/records/message_spec.rb
 - spec/netsuite/records/non_inventory_sale_item_spec.rb
 - spec/netsuite/records/note_spec.rb
 - spec/netsuite/records/note_type_spec.rb
@@ -668,6 +675,7 @@ test_files:
 - spec/netsuite/records/site_category_spec.rb
 - spec/netsuite/records/subsidiary_spec.rb
 - spec/netsuite/records/support_case_spec.rb
+- spec/netsuite/records/support_case_type_spec.rb
 - spec/netsuite/records/tax_type_spec.rb
 - spec/netsuite/records/term_spec.rb
 - spec/netsuite/records/transaction_body_custom_field_spec.rb
@@ -695,6 +703,7 @@ test_files:
 - spec/netsuite/support/record_refs_spec.rb
 - spec/netsuite/support/records_spec.rb
 - spec/netsuite/support/requests_spec.rb
+- spec/netsuite/support/search_result_spec.rb
 - spec/netsuite/support/sublist_spec.rb
 - spec/netsuite/utilities/data_center_spec.rb
 - spec/netsuite/utilities/request_spec.rb