netsuite 0.8.3 → 0.8.4

data/lib/netsuite/records/service_sale_item.rb

@@ -26,7 +26,7 @@ module NetSuite
       record_refs :billing_schedule, :cost_category, :custom_form, :deferred_revenue_account, :department, :income_account,
         :issue_product, :item_options_list, :klass, :location, :parent, :pricing_group, :purchase_tax_code,
         :quantity_pricing_schedule, :rev_rec_schedule, :sale_unit, :sales_tax_code, :store_display_image,
-        :store_display_thumbnail, :store_item_template, :tax_schedule, :units_type
+        :store_display_thumbnail, :store_item_template, :tax_schedule, :units_type, :revenue_recognition_rule
 
       field :pricing_matrix, PricingMatrix
       field :custom_field_list, CustomFieldList

data/lib/netsuite/records/tax_group.rb

@@ -7,8 +7,8 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      # NOTE search not available on TaxGroup!
-
+      # NOTE `get_all` is not available in recent API versions ~2017_2
+      #      `search` is only available in recent API versions
       actions :get, :get_list, :add, :initialize, :delete, :update, :upsert, :search, :get_all
 
       fields :city, :county, :description, :include_children, :is_default, :is_inactive,

data/lib/netsuite/records/transaction_body_custom_field.rb

@@ -0,0 +1,61 @@
+module NetSuite
+  module Records
+    class TransactionBodyCustomField
+      include Support::Fields
+      include Support::RecordRefs
+      include Support::Records
+      include Support::Actions
+      include Namespaces::SetupCustom
+
+      actions :get, :get_list, :add, :delete, :update, :upsert, :upsert_list
+
+      # http://www.netsuite.com/help/helpcenter/en_US/srbrowser/Browser2017_1/schema/record/transactionbodycustomfield.html
+      fields(
+        :label,
+        :store_value,
+        :display_type,
+        :is_mandatory,
+        :default_checked,
+        :is_formula,
+        :body_assembly_build,
+        :body_bom,
+        :body_b_tegata,
+        :body_customer_payment,
+        :body_deposit,
+        :body_expense_report,
+        :body_inventory_adjustment,
+        :body_item_fulfillment,
+        :body_item_fulfillment_order,
+        :body_item__receipt,
+        :body_item__receipt_order,
+        :body_journal,
+        :body_opportunity,
+        :body_other_transaction,
+        :body_picking_ticket,
+        :body_print_flag,
+        :body_print_packing_slip,
+        :body_print_statement,
+        :body_purchase,
+        :body_sale,
+        :body_store,
+        :body_transfer_order,
+        :body_vendor_payment,
+        :access_level,
+        :search_level,
+        :field_type,
+        :script_id
+      )
+
+      record_refs :owner
+
+      attr_reader :internal_id
+      attr_accessor :external_id
+
+      def initialize(attributes = {})
+        @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
+        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
+        initialize_from_attributes_hash(attributes)
+      end
+    end
+  end
+end

data/lib/netsuite/records/transaction_column_custom_field.rb

@@ -0,0 +1,59 @@
+module NetSuite
+  module Records
+    class TransactionColumnCustomField
+      include Support::Fields
+      include Support::RecordRefs
+      include Support::Records
+      include Support::Actions
+      include Namespaces::SetupCustom
+
+      actions :get, :get_list, :add, :delete, :update, :upsert, :upsert_list
+
+      # http://www.netsuite.com/help/helpcenter/en_US/srbrowser/Browser2017_1/schema/record/transactioncolumncustomfield.html
+      fields(
+        :label,
+        :store_value,
+        :display_type,
+        :is_mandatory,
+        :default_checked,
+        :is_formula,
+        :col_expense,
+        :col_purchase,
+        :col_sale,
+        :col_opportunity,
+        :col_store,
+        :col_store_hidden,
+        :col_journal,
+        :col_expense_report,
+        :col_time,
+        :col_transfer_order,
+        :col_item_receipt,
+        :col_item_receipt_order,
+        :col_item_fulfillment,
+        :col_item_fulfillment_order,
+        :col_print_flag,
+        :col_picking_ticket,
+        :col_packing_slip,
+        :col_return_form,
+        :col_store_with_groups,
+        :col_group_on_invoices,
+        :col_kit_item,
+        :access_level,
+        :search_level,
+        :field_type,
+        :script_id
+      )
+
+      record_refs :owner
+
+      attr_reader :internal_id
+      attr_accessor :external_id
+
+      def initialize(attributes = {})
+        @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
+        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
+        initialize_from_attributes_hash(attributes)
+      end
+    end
+  end
+end

data/lib/netsuite/records/vendor_credit.rb

@@ -33,9 +33,11 @@ module NetSuite
       field :custom_field_list,  CustomFieldList
 
       attr_reader :internal_id
+      attr_accessor :external_id
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
+        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
         initialize_from_attributes_hash(attributes)
       end
 

data/lib/netsuite/records/work_order.rb

@@ -33,6 +33,14 @@ module NetSuite
         @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
         initialize_from_attributes_hash(attributes)
       end
+
+      def self.search_class_name
+        "Transaction"
+      end
+
+      def self.search_class_namespace
+        'tranSales'
+      end
     end
   end
 end

data/lib/netsuite/support/country.rb

@@ -4,6 +4,7 @@ module NetSuite
 
       ISO_TO_NETSUITE = {
         'AF' => '_afghanistan',
+        'AX' => '_alandIslands',
         'AL' => '_albania',
         'DZ' => '_algeria',
         'AS' => '_americanSamoa',
@@ -29,6 +30,7 @@ module NetSuite
         'BM' => '_bermuda',
         'BT' => '_bhutan',
         'BO' => '_bolivia',
+        'BQ' => '_bonaireSaintEustatiusAndSaba',
         'BA' => '_bosniaAndHerzegovina',
         'BW' => '_botswana',
         'BV' => '_bouvetIsland',
@@ -41,9 +43,11 @@ module NetSuite
         'KH' => '_cambodia',
         'CM' => '_cameroon',
         'CA' => '_canada',
-        'CV' => '_capVerde',
+        'IC' => '_canaryIslands',
+        'CV' => '_capeVerde',
         'KY' => '_caymanIslands',
         'CF' => '_centralAfricanRepublic',
+        'EA' => '_ceutaAndMelilla',
         'TD' => '_chad',
         'CL' => '_chile',
         'CN' => '_china',
@@ -65,7 +69,7 @@ module NetSuite
         'DJ' => '_djibouti',
         'DM' => '_dominica',
         'DO' => '_dominicanRepublic',
-        'TP' => '_eastTimor',
+        'TL' => '_eastTimor',
         'EC' => '_ecuador',
         'EG' => '_egypt',
         'SV' => '_elSalvador',
@@ -73,7 +77,7 @@ module NetSuite
         'ER' => '_eritrea',
         'EE' => '_estonia',
         'ET' => '_ethiopia',
-        'FK' => '_falklandIslandsMalvina',
+        'FK' => '_falklandIslands',
         'FO' => '_faroeIslands',
         'FJ' => '_fiji',
         'FI' => '_finland',
@@ -121,6 +125,7 @@ module NetSuite
         'KI' => '_kiribati',
         'KP' => '_koreaDemocraticPeoplesRepublic',
         'KR' => '_koreaRepublicOf',
+        'XK' => '_kosovo',
         'KW' => '_kuwait',
         'KG' => '_kyrgyzstan',
         'LA' => '_laoPeoplesDemocraticRepublic',
@@ -128,7 +133,7 @@ module NetSuite
         'LB' => '_lebanon',
         'LS' => '_lesotho',
         'LR' => '_liberia',
-        'LY' => '_libyanArabJamahiriya',
+        'LY' => '_libya',
         'LI' => '_liechtenstein',
         'LT' => '_lithuania',
         'LU' => '_luxembourg',
@@ -159,7 +164,6 @@ module NetSuite
         'NR' => '_nauru',
         'NP' => '_nepal',
         'NL' => '_netherlands',
-        'AN' => '_netherlandsAntilles',
         'NC' => '_newCaledonia',
         'NZ' => '_newZealand',
         'NI' => '_nicaragua',
@@ -172,7 +176,7 @@ module NetSuite
         'OM' => '_oman',
         'PK' => '_pakistan',
         'PW' => '_palau',
-        'PS' => '_palestinianTerritories',
+        'PS' => '_stateOfPalestine',
         'PA' => '_panama',
         'PG' => '_papuaNewGuinea',
         'PY' => '_paraguay',
@@ -185,18 +189,19 @@ module NetSuite
         'QA' => '_qatar',
         'RE' => '_reunionIsland',
         'RO' => '_romania',
-        'RS' => '_serbia',
         'RU' => '_russianFederation',
         'RW' => '_rwanda',
         'BL' => '_saintBarthelemy',
+        'SH' => '_saintHelena',
         'KN' => '_saintKittsAndNevis',
         'LC' => '_saintLucia',
+        'MF' => '_saintMartin',
         'VC' => '_saintVincentAndTheGrenadines',
         'SM' => '_sanMarino',
         'ST' => '_saoTomeAndPrincipe',
         'SA' => '_saudiArabia',
         'SN' => '_senegal',
-        'CS' => '_serbia',
+        'RS' => '_serbia',
         'SC' => '_seychelles',
         'SL' => '_sierraLeone',
         'SG' => '_singapore',
@@ -207,9 +212,9 @@ module NetSuite
         'SO' => '_somalia',
         'ZA' => '_southAfrica',
         'GS' => '_southGeorgia',
+        'SS' => '_southSudan',
         'ES' => '_spain',
         'LK' => '_sriLanka',
-        'SH' => '_stHelena',
         'PM' => '_stPierreAndMiquelon',
         'SD' => '_sudan',
         'SR' => '_suriname',
@@ -234,8 +239,7 @@ module NetSuite
         'UG' => '_uganda',
         'UA' => '_ukraine',
         'AE' => '_unitedArabEmirates',
-        # NOTE GB country code changed on 2016_1
-        'GB' => NetSuite::Configuration.api_version <= "2015_2" ? '_unitedKingdomGB' : '_unitedKingdom',
+        'GB' => '_unitedKingdom',
         'US' => '_unitedStates',
         'UY' => '_uruguay',
         'UM' => '_uSMinorOutlyingIslands',
@@ -247,16 +251,15 @@ module NetSuite
         'VI' => '_virginIslandsUSA',
         'WF' => '_wallisAndFutunaIslands',
         'EH' => '_westernSahara',
-        'WS' => '_westernSamoa',
+        'WS' => '_samoa',
         'YE' => '_yemen',
-        'YU' => '_yugoslavia',
         'ZM' => '_zambia',
         'ZW' => '_zimbabwe'
       }
 
       def initialize(iso_or_name = '')
         if iso_or_name =~ /^[A-Z]{2}/
-          @id = ISO_TO_NETSUITE.fetch(iso_or_name)
+          @id = iso_to_netsuite.fetch(iso_or_name)
         else
           @id = iso_or_name
         end
@@ -269,13 +272,22 @@ module NetSuite
       alias :eql? :==
 
       def to_iso
-        ISO_TO_NETSUITE.key(@id)
+        iso_to_netsuite.key(@id)
       end
 
       def to_record
         @id
       end
 
+      def iso_to_netsuite
+        # NOTE GB country code changed on 2016_1
+        if NetSuite::Configuration.api_version <= "2015_2"
+          ISO_TO_NETSUITE.merge({ 'GB' => '_unitedKingdomGB' })
+        else
+          ISO_TO_NETSUITE
+        end
+      end
+
     end
   end
 end

data/lib/netsuite/utilities.rb

@@ -1,3 +1,5 @@
+require 'date'
+
 module NetSuite
   module Utilities
     extend self
@@ -40,6 +42,9 @@ module NetSuite
     def netsuite_data_center_urls(account_id)
       data_center_call_response = NetSuite::Configuration.connection({
         # NOTE force a production WSDL so the sandbox settings are ignored
+        #      as of 1/20/18 NS will start using the account ID to determine
+        #      if a account is sandbox (123_SB1) as opposed to using a sandbox domain
+
         wsdl: 'https://webservices.netsuite.com/wsdl/v2017_2_0/netsuite.wsdl',
 
         # NOTE don't inherit default namespace settings, it includes the API version
@@ -59,6 +64,11 @@ module NetSuite
       end
     end
 
+    # TODO consider what to dop with this duplicate data center implementation
+    def data_center_url(*args)
+      DataCenter.get(*args)
+    end
+
     def backoff(options = {})
       # TODO the default backoff attempts should be customizable the global config
       options[:attempts] ||= 8
@@ -105,6 +115,8 @@ module NetSuite
           # https://github.com/stripe/stripe-netsuite/issues/815
           if !e.message.include?("Only one request may be made against a session at a time") &&
             !e.message.include?('java.util.ConcurrentModificationException') &&
+            !e.message.include?('java.lang.IllegalStateException') &&
+            !e.message.include?('java.lang.reflect.InvocationTargetException') &&
             !e.message.include?('com.netledger.common.exceptions.NLDatabaseOfflineException') &&
             !e.message.include?('com.netledger.database.NLConnectionUtil$NoCompanyDbsOnlineException') &&
             !e.message.include?('com.netledger.cache.CacheUnavailableException') &&
@@ -112,6 +124,7 @@ module NetSuite
             !e.message.include?('An unexpected error occurred.') &&
             !e.message.include?('An unexpected error has occurred.  Technical Support has been alerted to this problem.') &&
             !e.message.include?('Session invalidation is in progress with different thread') &&
+            !e.message.include?('[missing resource APP:ERRORMESSAGE:WS_AN_UNEXPECTED_ERROR_OCCURRED] [missing resource APP:ERRORMESSAGE:ERROR_ID_1]') &&
             !e.message.include?('SuiteTalk concurrent request limit exceeded. Request blocked.') &&
             # maintenance is the new outage: this message is being used for intermittent errors
             !e.message.include?('The account you are trying to access is currently unavailable while we undergo our regularly scheduled maintenance.') &&
@@ -135,15 +148,16 @@ module NetSuite
 
     def request_failed?(ns_object)
       return false if ns_object.errors.nil? || ns_object.errors.empty?
+      ns_object.errors.any? { |x| x.type == "ERROR" }
+    end
 
-      warnings = ns_object.errors.select { |x| x.type == "WARN" }
-      errors = ns_object.errors.select { |x| x.type == "ERROR" }
-
-      # warnings.each do |warn|
-      #   log.warn(warn.message, code: warn.code)
-      # end
+    def get_field_options(recordType, fieldName)
+      options = NetSuite::Records::BaseRefList.get_select_value(
+        field: fieldName,
+        recordType: recordType
+      )
 
-      return errors.size > 0
+      options.base_refs
     end
 
     def get_item(ns_item_internal_id, opts = {})
@@ -222,7 +236,11 @@ module NetSuite
           field_name = 'email'
         end
 
-        field_name ||= 'name'
+        field_name ||= if record.to_s.end_with?('Item')
+          'displayName'
+        else
+          'name'
+        end
 
         # TODO remove backoff when it's built-in to search
         search = backoff { record.search({
@@ -243,25 +261,32 @@ module NetSuite
       nil
     end
 
-    def data_center_url(*args)
-      DataCenter.get(*args)
-    end
-
     # http://mikebian.co/notes-on-dates-timezones-with-netsuites-suitetalk-api/
+    # https://wyeworks.com/blog/2016/6/22/behavior-changes-in-ruby-2.4
+    # https://github.com/rails/rails/commit/c9c5788a527b70d7f983e2b4b47e3afd863d9f48
+
     # assumes UTC0 unix timestamp
     def normalize_time_to_netsuite_date(unix_timestamp)
       # convert to date to eliminate hr/min/sec
-      time = Time.at(unix_timestamp).utc.to_date.to_datetime
-
-      offset = 8
-      time = time.new_offset("-08:00")
-
-      if time.to_time.dst?
-        offset = 7
+      time = Time.at(unix_timestamp).
+        utc.
+        to_date.
+        to_datetime
+
+      # tzinfo allows us to determine the dst status of the time being passed in
+      # NetSuite requires that the time be passed to the API with the PDT TZ offset
+      # of the time passed in (i.e. not the current TZ offset of PDT)
+
+      offset = Rational(-7, 24)
+      
+      if defined?(TZInfo)
+        time = TZInfo::Timezone.get("America/Los_Angeles").utc_to_local(time)
+        offset = time.offset
+      else
         time = time.new_offset("-07:00")
       end
 
-      (time + Rational(offset, 24)).iso8601
+      (time + (offset * -1)).iso8601
     end
 
   end