netsuite 0.8.2 → 0.8.6

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module NetSuite
-  VERSION = '0.8.2'
+  VERSION = '0.8.6'
 end

data/netsuite.gemspec

@@ -2,8 +2,9 @@
 require File.expand_path('../lib/netsuite/version', __FILE__)
 
 Gem::Specification.new do |gem|
+  gem.licenses      = ['MIT']
   gem.authors       = ['Ryan Moran', 'Michael Bianco']
-  gem.email         = ['ryan.moran@gmail.com', 'mike@cliffsidemedia.com']
+  gem.email         = ['ryan.moran@gmail.com', 'mike@mikebian.co']
   gem.description   = %q{NetSuite SuiteTalk API Wrapper}
   gem.summary       = %q{NetSuite SuiteTalk API (SOAP) Wrapper}
   gem.homepage      = 'https://github.com/NetSweet/netsuite'
@@ -15,7 +16,7 @@ Gem::Specification.new do |gem|
   gem.require_paths = ['lib']
   gem.version       = NetSuite::VERSION
 
-  gem.add_dependency 'savon', '>= 2.3.0'
+  gem.add_dependency 'savon', '>= 2.3.0', '<= 2.11.1'
 
-  gem.add_development_dependency 'rspec', '~> 3.1.0'
+  gem.add_development_dependency 'rspec', '~> 3.8.0'
 end

data/spec/netsuite/actions/login_spec.rb

@@ -41,4 +41,27 @@ describe NetSuite::Actions::Login do
       role: 234
     }) }.to raise_error(Savon::SOAPFault)
   end
+
+  it 'handles a login call when token based auth is in place' do
+    NetSuite.configure do
+      consumer_key '123'
+      consumer_secret '123'
+      token_id '123'
+      token_secret '123'
+
+      api_version '2017_2'
+    end
+
+    message = {"platformMsgs:passport"=>{"platformCore:email"=>"email", "platformCore:password"=>"password", "platformCore:account"=>"1234", "platformCore:role"=>234}}
+    savon.expects(:login).with(:message => message).returns(File.read('spec/support/fixtures/login/success.xml'))
+
+    result = NetSuite::Actions::Login.call({
+      email: 'email',
+      password: 'password',
+      role: 234
+    })
+
+    expect(result.success?).to eq(true)
+    expect(result.body[:user_id]).to_not be_nil
+  end
 end

data/spec/netsuite/actions/update_list_spec.rb

@@ -0,0 +1,107 @@
+require 'spec_helper'
+
+describe NetSuite::Actions::UpdateList do
+  before { savon.mock! }
+  after { savon.unmock! }
+
+  context 'Items' do
+    context 'one item' do
+      let(:item) do
+        [
+          NetSuite::Records::InventoryItem.new(internal_id: '624113', item_id: 'Target', upccode: 'Target')
+        ]
+      end
+
+      before do
+        savon.expects(:update_list).with(:message =>
+          {
+            'record' => [{
+              'listAcct:itemId' => 'Target',
+              '@xsi:type' => 'listAcct:InventoryItem',
+              '@internalId' => '624113'
+            }]
+          }).returns(File.read('spec/support/fixtures/update_list/update_list_one_item.xml'))
+      end
+
+      it 'makes a valid request to the NetSuite API' do
+        NetSuite::Actions::UpdateList.call(item)
+      end
+
+      it 'returns a valid Response object' do
+        response = NetSuite::Actions::UpdateList.call(item)
+        expect(response).to be_kind_of(NetSuite::Response)
+        expect(response).to be_success
+      end
+    end
+
+    context 'two items' do
+      let(:items) do
+        [
+          NetSuite::Records::InventoryItem.new(internal_id: '624172', item_id: 'Shutter Fly', upccode: 'Shutter Fly, Inc.'),
+          NetSuite::Records::InventoryItem.new(internal_id: '624113', item_id: 'Target', upccode: 'Target')
+        ]
+      end
+
+      before do
+        savon.expects(:update_list).with(:message =>
+          {
+            'record' => [{
+                'listAcct:itemId' => 'Shutter Fly',
+                '@xsi:type' => 'listAcct:InventoryItem',
+                '@internalId' => '624172'
+              },
+              {
+                'listAcct:itemId' => 'Target',
+                '@xsi:type' => 'listAcct:InventoryItem',
+                '@internalId' => '624113'
+              }
+            ]
+          }).returns(File.read('spec/support/fixtures/update_list/update_list_items.xml'))
+      end
+
+      it 'makes a valid request to the NetSuite API' do
+        NetSuite::Actions::UpdateList.call(items)
+      end
+
+      it 'returns a valid Response object' do
+        response = NetSuite::Actions::UpdateList.call(items)
+        expect(response).to be_kind_of(NetSuite::Response)
+        expect(response).to be_success
+      end
+    end
+  end
+
+  context 'with errors' do
+    let(:items) do
+      [
+        NetSuite::Records::InventoryItem.new(internal_id: '624172-bad', item_id: 'Shutter Fly', upccode: 'Shutter Fly, Inc.'),
+        NetSuite::Records::InventoryItem.new(internal_id: '624113-bad', item_id: 'Target', upccode: 'Target')
+      ]
+    end
+
+    before do
+      savon.expects(:update_list).with(:message =>
+        {
+          'record' => [{
+            'listAcct:itemId' => 'Shutter Fly',
+            '@xsi:type' => 'listAcct:InventoryItem',
+            '@internalId' => '624172-bad'
+          },
+          {
+            'listAcct:itemId' => 'Target',
+            '@xsi:type' => 'listAcct:InventoryItem',
+            '@internalId' => '624113-bad'
+          }
+          ]
+        }).returns(File.read('spec/support/fixtures/update_list/update_list_with_errors.xml'))
+    end
+
+    it 'constructs error objects' do
+      response = NetSuite::Actions::UpdateList.call(items)
+      expect(response.errors.keys).to match_array(['624172', '624113'])
+      expect(response.errors['624172'].first.code).to eq('USER_ERROR')
+      expect(response.errors['624172'].first.message).to eq('Please enter value(s) for: ItemId')
+      expect(response.errors['624172'].first.type).to eq('ERROR')
+    end
+  end
+end

data/spec/netsuite/actions/update_spec.rb

@@ -19,6 +19,48 @@ describe NetSuite::Actions::Update do
       }
     end
 
+    describe 'updating the external ID' do
+      let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
+
+      # https://github.com/NetSweet/netsuite/pull/416
+      #   if the external ID is set, and the external ID field is ommitted on an update, the external ID field does not change
+      #   if the external_id field is set to nil, it should not be passed to netsuite
+      #   passing an empty string to the external ID field does not remove it
+
+      it 'does not pass the external ID to an update call if not modified or included in update options' do
+        expect(NetSuite::Actions::Update).to receive(:call).
+            with([customer.class, {}], {}).
+            and_return(response)
+
+        expect(customer.update).to be_truthy
+      end
+
+      it 'should update the external ID when the attribute on the record is set' do
+        expect(NetSuite::Actions::Update).to receive(:call).
+            with([customer.class, {external_id: 'foo'}], {}).
+            and_return(response)
+
+        customer.external_id = 'foo'
+        expect(customer.update).to be_truthy
+      end
+
+      it 'should update the external ID to nil when the attribute on the record is set' do
+        expect(NetSuite::Actions::Update).to receive(:call).
+            with([customer.class, {external_id: nil}], {}).
+            and_return(response)
+
+        expect(customer.update(external_id: nil)).to be_truthy
+      end
+
+      it 'should update the external ID to the options value not the attribute value' do
+        expect(NetSuite::Actions::Update).to receive(:call).
+            with([customer.class, {external_id: 'bar'}], {}).
+            and_return(response)
+
+        customer.external_id = 'foo'
+        expect(customer.update(external_id: 'bar')).to be_truthy
+      end
+    end
 
     context 'when successful' do
 

data/spec/netsuite/configuration_spec.rb

@@ -326,15 +326,11 @@ describe NetSuite::Configuration do
 
   describe "#credentials" do
     context "when none are defined" do
-      skip "should properly create the auth credentials" do
-
-      end
+      skip "should properly create the auth credentials"
     end
 
     context "when they are defined" do
-      it "should properly replace the default auth credentials" do
-
-      end
+      skip "should properly replace the default auth credentials"
     end
   end
 
@@ -371,4 +367,81 @@ describe NetSuite::Configuration do
     end
   end
 
+  describe "#log" do
+    it 'allows a file path to be set as the log destination' do
+      file_path = Tempfile.new.path
+      config.log = file_path
+      config.logger.info "foo"
+
+      log_contents = open(file_path).read
+      expect(log_contents).to include("foo")
+    end
+
+    it 'allows an IO device to bet set as the log destination' do
+      stream = StringIO.new
+      config.log = stream
+      config.logger.info "foo"
+
+      expect(stream.string).to include("foo")
+    end
+  end
+
+  describe '#log_level' do
+    it 'defaults to :debug' do
+      expect(config.log_level).to eq(:debug)
+    end
+
+    it 'can be initially set to any log level' do
+      config.log_level(:info)
+
+      expect(config.log_level).to eq(:info)
+    end
+
+    it 'can override itself' do
+      config.log_level = :info
+
+      expect(config.log_level).to eq(:info)
+
+      config.log_level(:debug)
+
+      expect(config.log_level).to eq(:debug)
+    end
+  end
+
+  describe '#log_level=' do
+    it 'can set the initial log_level' do
+      config.log_level = :info
+
+      expect(config.log_level).to eq(:info)
+    end
+
+    it 'can override a previously set log level' do
+      config.log_level = :info
+
+      expect(config.log_level).to eq(:info)
+
+      config.log_level = :debug
+
+      expect(config.log_level).to eq(:debug)
+    end
+  end
+
+  describe 'timeouts' do
+    it 'has defaults' do
+      expect(config.read_timeout).to eql(60)
+      expect(config.open_timeout).to be_nil
+    end
+
+    it 'sets timeouts' do
+      config.read_timeout = 100
+      config.open_timeout = 60
+
+      expect(config.read_timeout).to eql(100)
+      expect(config.open_timeout).to eql(60)
+
+      # ensure no exception is raised
+      config.connection
+    end
+  end
+
 end

data/spec/netsuite/records/address_spec.rb

@@ -134,6 +134,16 @@ describe NetSuite::Records::Address do
       expect(addressbook.country.to_record).to eql ""
       expect(addressbook.to_record["platformCommon:country"]).to eql ""
     end
+
+    it 'changes the netsuite identifier based on the current API version' do
+      NetSuite::Configuration.api_version = '2015_1'
+      addressbook = NetSuite::Records::Address.new country: "GB"
+      expect(addressbook.to_record["platformCommon:country"]).to eql "_unitedKingdomGB"
+      NetSuite::Configuration.api_version = '2018_1'
+
+      addressbook = NetSuite::Records::Address.new country: "GB"
+      expect(addressbook.to_record["platformCommon:country"]).to eql "_unitedKingdom"
+    end
   end
 
 end

data/spec/netsuite/records/basic_record_spec.rb

@@ -25,6 +25,7 @@ describe 'basic records' do
       NetSuite::Records::CustomerDeposit,
       NetSuite::Records::NonInventoryPurchaseItem,
       NetSuite::Records::NonInventoryResaleItem,
+      NetSuite::Records::LotNumberedInventoryItem,
       NetSuite::Records::TaxGroup,
       NetSuite::Records::Folder,
       NetSuite::Records::CustomerCategory,
@@ -53,7 +54,16 @@ describe 'basic records' do
       NetSuite::Records::AssemblyUnbuild,
       NetSuite::Records::AssemblyComponent,
       NetSuite::Records::InventoryNumber,
-      NetSuite::Records::LotNumberedAssemblyItem
+      NetSuite::Records::PriceLevel,
+      NetSuite::Records::LotNumberedAssemblyItem,
+      NetSuite::Records::InboundShipment,
+      NetSuite::Records::InterCompanyJournalEntry,
+      NetSuite::Records::BinTransfer,
+      NetSuite::Records::SerializedAssemblyItem,
+      NetSuite::Records::CustomerStatus,
+      NetSuite::Records::TransactionBodyCustomField,
+      NetSuite::Records::TransactionColumnCustomField,
+      NetSuite::Records::EntityCustomField
     ]
   }
 

data/spec/netsuite/records/bin_number_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe NetSuite::Records::BinNumber do
+  it "has all the right fields" do
+    bin_number = described_class.new
+
+    [:preferred_bin, :location].each do |field|
+      expect(bin_number).to have_field(field)
+    end
+  end
+
+  it "has all the right record refs" do
+    bin_number = described_class.new
+
+    expect(bin_number).to have_record_ref(:bin_number)
+  end
+
+  it "has the right namespace" do
+    bin_number = described_class.new
+
+    expect(bin_number.record_namespace).to eq('listAcct')
+  end
+end

data/spec/netsuite/records/classification_spec.rb

@@ -5,12 +5,21 @@ describe NetSuite::Records::Classification do
 
   it 'has all the right fields' do
     [
-      :name, :include_children, :is_inactive, :class_translation_list, :custom_field_list
+      :name, :include_children, :is_inactive, :class_translation_list
     ].each do |field|
       expect(classification).to have_field(field)
     end
 
     expect(classification.subsidiary_list.class).to eq(NetSuite::Records::RecordRefList)
+    expect(classification.custom_field_list.class).to eq(NetSuite::Records::CustomFieldList)
+  end
+
+  it 'has all the right record refs' do
+    [
+      :parent
+    ].each do |record_ref|
+      expect(classification).to have_record_ref(record_ref)
+    end
   end
 
   describe '.get' do

data/spec/netsuite/records/custom_field_list_spec.rb

@@ -37,9 +37,11 @@ describe NetSuite::Records::CustomFieldList do
   context 'writing convience methods' do
     it "should create a custom field entry when none exists" do
       list.custrecord_somefield = 'a value'
-      list.custom_fields.size.should == 1
-      list.custom_fields.first.value.should == 'a value'
-      list.custom_fields.first.type.should == 'platformCore:StringCustomFieldRef'
+      custom_fields = list.custom_fields
+
+      expect(custom_fields.size).to eq(1)
+      expect(custom_fields.first.value).to eq('a value')
+      expect(custom_fields.first.type).to eq('platformCore:StringCustomFieldRef')
     end
 
     # https://github.com/NetSweet/netsuite/issues/325
@@ -116,7 +118,7 @@ describe NetSuite::Records::CustomFieldList do
           end
 
           it "should raise an error if custom field entry does not exist" do
-            expect{ list.nonexisting_custom_field }.to raise_error
+            expect{ list.nonexisting_custom_field }.to raise_error(NoMethodError)
           end
         end
       end
@@ -180,6 +182,20 @@ describe NetSuite::Records::CustomFieldList do
               script_id: "custbody_salesclassification",
               type: "platformCore:StringCustomFieldRef",
               value: "foobar"
+            },
+            {
+              script_id: 'custbody_multipleselectfield',
+              type: "platformCore:MultiSelectCustomFieldRef",
+              value: [
+                {
+                  internal_id: 405,
+                  type_id: 157
+                },
+                {
+                  internal_id: 419,
+                  type_id: 157
+                }
+              ]
             }
           ]
         }
@@ -200,9 +216,28 @@ describe NetSuite::Records::CustomFieldList do
               "@xsi:type" => "platformCore:StringCustomFieldRef",
               "platformCore:value" => "foobar",
             },
+            {
+              '@scriptId' => 'custbody_multipleselectfield',
+              '@xsi:type' => 'platformCore:MultiSelectCustomFieldRef',
+              'platformCore:value' => [
+                {
+                  :@internalId => 405,
+                  :@typeId => "157"
+                },
+                {
+                  :@internalId => 419,
+                  :@typeId => "157"
+                }
+              ]
+            }
           ]
         }
 
+        # field accessors are tested elsewhere, but let's run tests here to check various field types
+        expect(list).to respond_to(:custbody_multipleselectfield)
+        expect(list).to respond_to(:custbody_salesclassification)
+        expect(list).to respond_to(:custentity_registeredonline)
+
         expect(list.to_record).to eql(record)
         expect(list.to_record.length).to eq(1)
       end