netsuite 0.7.6 → 0.7.7

data/circle.yml

@@ -0,0 +1,16 @@
+# https://leonid.shevtsov.me/post/multiple-rubies-on-circleci/
+
+machine:
+  environment:
+    RUBY_VERSIONS: 2.0.0,2.1.10,2.2.5,2.3.1,2.4.0
+
+dependencies:
+  override:
+    - rvm get head
+    - rvm install $RUBY_VERSIONS
+    - rvm $RUBY_VERSIONS --verbose do gem install bundler
+    - rvm $RUBY_VERSIONS --verbose do bundle install
+
+test:
+  override:
+    - rvm $RUBY_VERSIONS --verbose do bundle exec rspec spec

data/lib/netsuite/records/account.rb

@@ -10,7 +10,7 @@ module NetSuite
       actions :get, :get_list, :add, :update, :delete, :search, :upsert
 
       fields :acct_name, :acct_number, :acct_type, :cash_flow_rate, :cur_doc_num, :description, :eliminate, :exchange_rate,
-        :general_rate, :include_children, :inventory, :is_inactive, :opening_balance, :revalue, :tran_date
+        :general_rate, :include_children, :inventory, :is_inactive, :opening_balance, :revalue, :tran_date, :balance
 
       record_refs :billable_expenses_acct, :category1099misc, :currency, :deferral_acct, :department, :klass, :location, :parent
 
@@ -18,6 +18,7 @@ module NetSuite
 
       attr_reader :internal_id
       attr_accessor :external_id
+      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/customer_deposit.rb

@@ -10,8 +10,7 @@ module NetSuite
       include Support::Records
       include Namespaces::TranCust
 
-
-      actions :get, :get_list, :initialize, :add, :delete, :update, :upsert
+      actions :get, :get_list, :initialize, :add, :delete, :update, :upsert, :search
 
       fields :created_date, :last_modified_date, :status, :payment, :tran_date, :exchange_rate, :undep_funds, :memo,
              :check_num, :klass, :currency_name, :is_recurring_payment, :charge_it
@@ -29,6 +28,14 @@ module NetSuite
         @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
         initialize_from_attributes_hash(attributes)
       end
+
+      def self.search_class_name
+        "Transaction"
+      end
+
+      def self.search_class_namespace
+        'tranSales'
+      end
     end
   end
 end

data/lib/netsuite/records/service_sale_item.rb

@@ -26,7 +26,7 @@ module NetSuite
       record_refs :billing_schedule, :cost_category, :custom_form, :deferred_revenue_account, :department, :income_account,
         :issue_product, :item_options_list, :klass, :location, :parent, :pricing_group, :purchase_tax_code,
         :quantity_pricing_schedule, :rev_rec_schedule, :sale_unit, :sales_tax_code, :store_display_image,
-        :store_display_thumbnail, :store_item_template, :tax_schedule, :units_type, :subsidiary
+        :store_display_thumbnail, :store_item_template, :tax_schedule, :units_type
 
       field :pricing_matrix, PricingMatrix
       field :custom_field_list, CustomFieldList

data/lib/netsuite/utilities.rb

@@ -33,21 +33,64 @@ module NetSuite
     end
 
     def backoff(options = {})
+      # TODO the default backoff attempts should be customizable the global config
+      options[:attempts] ||= 8
+
       count = 0
+
       begin
         count += 1
         yield
-      rescue options[:exception] || Savon::SOAPFault => e
-        if !e.message.include?("Only one request may be made against a session at a time") &&
-           !e.message.include?('java.util.ConcurrentModificationException') &&
-           !e.message.include?('SuiteTalk concurrent request limit exceeded. Request blocked.')
-          raise e
+      rescue Exception => e
+        exceptions_to_retry = [
+          Errno::ECONNRESET,
+          Errno::ETIMEDOUT,
+          Errno::EHOSTUNREACH,
+          EOFError,
+          Wasabi::Resolver::HTTPError,
+          Savon::SOAPFault,
+          Savon::InvalidResponseError,
+          Zlib::BufError,
+          Savon::HTTPError
+        ]
+
+        # available in ruby > 1.9
+        if defined?(Net::ReadTimeout)
+          exceptions_to_retry << Net::ReadTimeout
+        end
+
+        # available in ruby > 2.2.0
+        if defined?(OpenSSL::SSL::SSLErrorWaitReadable)
+          exceptions_to_retry << OpenSSL::SSL::SSLErrorWaitReadable
+        end
+
+        if !exceptions_to_retry.include?(e.class)
+          raise
+        end
+
+        # whitelist certain SOAPFaults; all other network errors should automatically retry
+        if e.is_a?(Savon::SOAPFault)
+          # https://github.com/stripe/stripe-netsuite/issues/815
+          if !e.message.include?("Only one request may be made against a session at a time") &&
+            !e.message.include?('java.util.ConcurrentModificationException') &&
+            !e.message.include?('com.netledger.common.exceptions.NLDatabaseOfflineException') &&
+            !e.message.include?('An unexpected error occurred.') &&
+            !e.message.include?('Session invalidation is in progress with different thread') &&
+            !e.message.include?('SuiteTalk concurrent request limit exceeded. Request blocked.') &&
+            !e.message.include?('The Connection Pool is not intialized.') &&
+            # it looks like NetSuite mispelled their error message...
+            !e.message.include?('The Connection Pool is not intiialized.')
+            raise
+          end
         end
-        if count >= (options[:attempts] || 8)
-          raise e
+
+        if count >= options[:attempts]
+          raise
         end
+
         # log.warn("concurrent request failure", sleep: count, attempt: count)
         sleep(count)
+
         retry
       end
     end
@@ -92,8 +135,8 @@ module NetSuite
         @netsuite_get_record_cache ||= {}
         @netsuite_get_record_cache[record_klass.to_s] ||= {}
 
-        if cached_record = @netsuite_get_record_cache[record_klass.to_s][id.to_i]
-          return cached_record
+        if @netsuite_get_record_cache[record_klass.to_s].has_key?(id.to_i)
+          return @netsuite_get_record_cache[record_klass.to_s][id.to_i]
         end
       end
 
@@ -113,6 +156,10 @@ module NetSuite
         return ns_record
       rescue ::NetSuite::RecordNotFound
         # log.warn("record not found", ns_record_type: record_klass.name, ns_record_id: id)
+        if opts[:cache]
+          @netsuite_get_record_cache[record_klass.to_s][id.to_i] = nil
+        end
+
         return nil
       end
     end

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module Netsuite
-  VERSION = '0.7.6'
+  VERSION = '0.7.7'
 end

data/spec/netsuite/utilities_spec.rb

@@ -2,17 +2,36 @@ require 'spec_helper'
 
 describe NetSuite::Utilities do
   describe '#get_record' do
-    it 'does not hit the netsuite API when caching is enabled' do
-      ns_account_id = 123
-      allow(NetSuite::Records::Account).to receive(:get).with(ns_account_id).once.and_return(
-        NetSuite::Records::Account.new(internal_id: ns_account_id)
-      )
+    context 'caching' do
+      it 'does not hit the netsuite API' do
+        ns_account_id = 123
+        allow(NetSuite::Records::Account).to receive(:get).with(ns_account_id).once.and_return(
+          NetSuite::Records::Account.new(internal_id: ns_account_id)
+        )
 
-      ns_account = NetSuite::Utilities.get_record(NetSuite::Records::Account, ns_account_id, cache: true)
-      expect(ns_account.internal_id).to eq(ns_account_id)
+        ns_account = NetSuite::Utilities.get_record(NetSuite::Records::Account, ns_account_id, cache: true)
+        expect(ns_account.internal_id).to eq(ns_account_id)
 
-      ns_account = NetSuite::Utilities.get_record(NetSuite::Records::Account, ns_account_id, cache: true)
-      expect(ns_account.internal_id).to eq(ns_account_id)
+        ns_account = NetSuite::Utilities.get_record(NetSuite::Records::Account, ns_account_id, cache: true)
+        expect(ns_account.internal_id).to eq(ns_account_id)
+      end
+
+      it 'works on missing records' do
+        ns_account_id = 123
+        allow(NetSuite::Records::Account).to receive(:get).with(ns_account_id) do
+          raise NetSuite::RecordNotFound
+        end
+
+        20.times do
+          expect(
+            NetSuite::Utilities.get_record(
+              NetSuite::Records::Account, ns_account_id, cache: true
+            )
+          ).to eq nil
+        end
+
+        expect(NetSuite::Records::Account).to have_received(:get).exactly(1).times
+      end
     end
 
     it 'pulls a record by internal id' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netsuite
 version: !ruby/object:Gem::Version
-  version: 0.7.6
+  version: 0.7.7
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-01 00:00:00.000000000 Z
+date: 2017-02-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon