netsuite 0.7.5 → 0.7.6

data/lib/netsuite.rb

@@ -4,6 +4,7 @@ require 'savon'
 require 'netsuite/version'
 require 'netsuite/errors'
 require 'netsuite/utilities'
+require 'netsuite/utilities/data_center'
 require 'netsuite/rest/utilities/roles'
 require 'netsuite/rest/utilities/request'
 require 'netsuite/core_ext/string/lower_camelcase'
@@ -51,6 +52,7 @@ module NetSuite
     autoload :Delete,           'netsuite/actions/delete'
     autoload :DeleteList,       'netsuite/actions/delete_list'
     autoload :Get,              'netsuite/actions/get'
+    autoload :GetDeleted,       'netsuite/actions/get_deleted'
     autoload :GetAll,           'netsuite/actions/get_all'
     autoload :GetList,          'netsuite/actions/get_list'
     autoload :GetSelectValue,   'netsuite/actions/get_select_value'

data/lib/netsuite/actions/get_deleted.rb

@@ -0,0 +1,88 @@
+module NetSuite
+  module Actions
+    class GetDeleted
+      include Support::Requests
+
+      def initialize(object = nil, options = {})
+        @object  = object
+        @options = options
+      end
+
+      private
+
+      def request(credentials={})
+        NetSuite::Configuration.connection(
+          {namespaces: {
+            'xmlns:platformMsgs' => "urn:messages_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com",
+            'xmlns:platformCore' => "urn:core_#{NetSuite::Configuration.api_version}.platform.webservices.netsuite.com"
+          }}, credentials
+        ).call :get_deleted, message: request_body
+      end
+
+      def soap_type
+        @object.class.to_s.split('::').last.lower_camelcase
+      end
+
+      # <soap:Body>
+      #   <platformMsgs:getDeleted>
+      #     <platformMsgs:pageIndex>1</platformMsgs:pageIndex>
+      #     <platformMsgs:getDeletedFilter>
+      #       <platformCore:deletedDate operator="within">
+      #         <platformCore:searchValue>2016-12-01T00:00:00</platformCore:searchValue>
+      #         <platformCore:searchValue2>2016-12-20T00:00:00</platformCore:searchValue2>
+      #       </platformCore:deletedDate>
+      #       <platformCore:type operator="anyOf">
+      #         <platformCore:searchValue>invoice</platformCore:searchValue>
+      #       </platformCore:type>
+      #     </platformMsgs:getDeletedFilter>
+      #   </platformMsgs:getDeleted>
+      # </soap:Body>
+      def request_body
+        criteria = @options[:criteria] || @options
+        filter_elements = {}
+
+        criteria.each do |c|
+          searchValue = { "@operator" => c[:operator] }
+
+          if c[:value].is_a?(Array) && c[:type] == 'SearchDateField'
+            searchValue["platformCore:searchValue"] = c[:value][0].to_s
+            searchValue["platformCore:searchValue2"] = c[:value][1].to_s
+          else
+            searchValue["platformCore:searchValue"] = c[:value]
+          end
+
+          filter_elements["platformCore:#{c[:field]}"] = searchValue
+        end
+
+        {
+          'platformMsgs:pageIndex' => @options.fetch(:page, 1),
+          'platformMsgs:getDeletedFilter' => filter_elements
+        }
+      end
+
+      def response_hash
+        @response.body[:get_deleted_response]
+      end
+
+      def success?
+        @success ||= response_body[:status][:@is_success] == 'true'
+      end
+
+      def response_body
+        @response_body ||= response_hash[:get_deleted_result]
+      end
+
+      module Support
+        def self.included(base)
+          base.extend(ClassMethods)
+        end
+
+        module ClassMethods
+          def get_deleted(options = { }, credentials={})
+            NetSuite::Actions::GetDeleted.call([self, options], credentials)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/netsuite/configuration.rb

@@ -4,6 +4,7 @@ module NetSuite
 
     def reset!
       NetSuite::Utilities.clear_cache!
+      clear_wsdl_cache
 
       attributes.clear
     end
@@ -13,8 +14,8 @@ module NetSuite
     end
 
     def connection(params={}, credentials={})
-      Savon.client({
-        wsdl: wsdl,
+      client = Savon.client({
+        wsdl: cached_wsdl || wsdl,
         read_timeout: read_timeout,
         namespaces: namespaces,
         soap_header: auth_header(credentials).update(soap_header),
@@ -24,6 +25,8 @@ module NetSuite
         log_level: log_level,
         log: !silent, # turn off logging entirely if configured
       }.update(params))
+      cache_wsdl(client)
+      return client
     end
 
     def filters(list = nil)
@@ -43,6 +46,35 @@ module NetSuite
       attributes[:filters] = list
     end
 
+    def wsdl_cache
+      @wsdl_cache ||= {}
+    end
+
+    def clear_wsdl_cache
+      @wsdl_cache = {}
+    end
+
+    def cached_wsdl
+      cached = wsdl_cache.fetch([api_version, wsdl], nil)
+      if cached.is_a? String
+        cached
+      elsif cached.is_a? Savon::Client
+        wsdl_cache[[api_version, wsdl]] = cached.instance_eval { @wsdl.xml }
+      end
+    end
+
+    def cache_wsdl(client)
+      # NOTE the Savon::Client doesn't pull the wsdl content upon
+      # instantiation; it pulls it when it recieves the #call method.
+      # If we force it to pull the wsdl here, it will duplicate the call later.
+      # So, we stash the entire client and fetch just the wsdl from it after
+      # it completes its call
+      # For reference, see:
+      # https://github.com/savonrb/savon/blob/d64925d3add33fa5531577ce9e3a28a7a93618b1/lib/savon/client.rb#L35-L37
+      # https://github.com/savonrb/savon/blob/d64925d3add33fa5531577ce9e3a28a7a93618b1/lib/savon/operation.rb#L22
+      wsdl_cache[[api_version, wsdl]] ||= client
+    end
+
     def api_version(version = nil)
       if version
         self.api_version = version

data/lib/netsuite/records/credit_memo.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::TranCust
 
-      actions :get, :get_list, :add, :initialize, :delete, :update, :upsert, :search
+      actions :get, :get_deleted, :get_list, :add, :initialize, :delete, :update, :upsert, :search
 
       fields :alt_handling_cost, :alt_shipping_cost, :amount_paid, :amount_remaining, :auto_apply, :balance,
         :bill_address, :contrib_pct, :created_date, :currency_name, :deferred_revenue, :discount_rate, :email,
@@ -34,7 +34,7 @@ module NetSuite
 
       record_refs :account, :bill_address_list, :created_from, :custom_form, :department, :discount_item, :entity, :gift_cert,
         :handling_tax_code, :job, :klass, :lead_source, :location, :message_sel, :partner, :posting_period, :promo_code,
-        :sales_group, :sales_rep, :ship_method, :shipping_tax_code, :subsidiary, :tax_item
+        :sales_group, :sales_rep, :ship_method, :shipping_tax_code, :subsidiary, :tax_item, :currency
 
       attr_reader :internal_id
       attr_accessor :external_id

data/lib/netsuite/records/customer.rb

@@ -22,8 +22,8 @@ module NetSuite
         :opening_balance, :opening_balance_account, :opening_balance_date,
         :password, :password2, :phone, :phonetic_name, :pref_cc_processor, :print_on_check_as,
         :print_transactions, :referrer, :reminder_days, :representing_subsidiary, :require_pwd_change, :resale_number,
-        :sales_group, :sales_readiness, :sales_team_list, :salutation, :send_email, :ship_complete, :shipping_item,
-        :stage, :start_date, :sync_partner_teams, :tax_exempt, :tax_item, :taxable,
+        :sales_group, :sales_readiness, :sales_team_list, :salutation, :send_email, :ship_complete,
+        :stage, :start_date, :sync_partner_teams, :tax_exempt, :taxable,
         :third_party_acct, :third_party_country, :third_party_zipcode, :title, :url,
         :vat_reg_number, :visits, :web_lead
 
@@ -32,14 +32,14 @@ module NetSuite
       field :contact_roles_list, ContactAccessRolesList
       field :currency_list, CustomerCurrencyList
       field :partners_list, CustomerPartnersList
-      
+
       # TODO subscriptions_list
 
       read_only_fields :balance, :consol_balance, :deposit_balance, :consol_deposit_balance, :overdue_balance,
         :consol_overdue_balance, :unbilled_orders, :consol_unbilled_orders
 
       record_refs :access_role, :custom_form, :currency, :entity_status, :partner, :category, :lead_source,
-        :price_level,:sales_rep, :subsidiary, :terms, :parent, :territory
+        :price_level,:sales_rep, :subsidiary, :terms, :parent, :territory, :tax_item, :shipping_item
 
       attr_reader   :internal_id
       attr_accessor :external_id

data/lib/netsuite/records/invoice.rb

@@ -9,7 +9,7 @@ module NetSuite
 
       # https://system.netsuite.com/help/helpcenter/en_US/srbrowser/Browser2014_1/schema/record/invoice.html?mode=package
 
-      actions :get, :get_list, :initialize, :add, :update, :delete, :upsert, :search
+      actions :get, :get_deleted, :get_list, :initialize, :add, :update, :delete, :upsert, :search
 
       fields :balance, :bill_address,
         :billing_schedule, :contrib_pct, :created_date, :currency_name, :custom_field_list,

data/lib/netsuite/records/item_receipt.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::TranPurch
 
-      actions :get, :get_list, :add, :initialize, :delete, :update, :upsert, :search
+      actions :get, :get_deleted, :get_list, :add, :initialize, :delete, :update, :upsert, :search
 
       fields :created_date, :currency_name, :exchange_rate, :landed_cost_per_line,
              :last_modified_date, :memo, :tran_date, :tran_id

data/lib/netsuite/records/non_inventory_sale_item.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::ListAcct
 
-      actions :get, :get_list, :add, :delete, :search, :upsert
+      actions :get, :get_list, :add, :delete, :search, :update, :upsert
 
       fields :available_to_partners, :cost_estimate, :cost_estimate_type, :cost_estimate_units, :country_of_manufacture,
         :created_date, :display_name, :dont_show_price, :enforce_min_qty_internally, :exclude_from_sitemap,

data/lib/netsuite/records/service_sale_item.rb

@@ -26,7 +26,7 @@ module NetSuite
       record_refs :billing_schedule, :cost_category, :custom_form, :deferred_revenue_account, :department, :income_account,
         :issue_product, :item_options_list, :klass, :location, :parent, :pricing_group, :purchase_tax_code,
         :quantity_pricing_schedule, :rev_rec_schedule, :sale_unit, :sales_tax_code, :store_display_image,
-        :store_display_thumbnail, :store_item_template, :tax_schedule, :units_type
+        :store_display_thumbnail, :store_item_template, :tax_schedule, :units_type, :subsidiary
 
       field :pricing_matrix, PricingMatrix
       field :custom_field_list, CustomFieldList

data/lib/netsuite/records/transfer_order.rb

@@ -13,7 +13,7 @@ module NetSuite
              :handling_tax2_rate, :last_modified_date, :linked_tracking_numbers,
              :memo, :ship_complete, :ship_date, :ship_is_residential, :shipping_cost,
              :shipping_tax1_rate, :shipping_tax2_rate, :source, :status, :sub_total,
-             :total, :tracking_numbers, :tran_date, :tran_id, :order_status
+             :total, :tracking_numbers, :tran_date, :tran_id, :order_status, :use_item_cost_as_transfer_cost
 
       record_refs :transfer_location, :shipping_tax_code, :subsidiary, :shipping_address,
                   :ship_method, :employee, :handling_tax_code,

data/lib/netsuite/support/actions.rb

@@ -22,6 +22,8 @@ module NetSuite
             self.send(:include, NetSuite::Actions::Get::Support)
           when :get_all
             self.send(:include, NetSuite::Actions::GetAll::Support)
+          when :get_deleted
+            self.send(:include, NetSuite::Actions::GetDeleted::Support)
           when :get_list
             self.send(:include, NetSuite::Actions::GetList::Support)
           when :get_select_value

data/lib/netsuite/support/records.rb

@@ -56,7 +56,12 @@ module NetSuite
         fresh_record = self.class.get(self.internal_id, credentials)
 
         self.attributes = fresh_record.send(:attributes)
-        self.external_id = fresh_record.external_id
+
+        # gift cards do not have an external ID
+        if fresh_record.respond_to?(:external_id)
+          self.external_id = fresh_record.external_id
+        end
+
         self.errors = nil
 
         self

data/lib/netsuite/support/search_result.rb

@@ -20,7 +20,7 @@ module NetSuite
       def initialize(response, result_class)
         @result_class = result_class
         @response = response
-        
+
         @total_records = response.body[:total_records].to_i
         @total_pages = response.body[:total_pages].to_i
         @current_page = response.body[:page_index].to_i
@@ -52,12 +52,23 @@ module NetSuite
                   # extract the value from <SearchValue/> to make results easier to work with
 
                   if v.is_a?(Hash) && v.has_key?(:search_value)
-                    # search return values that are just internalIds are stored as attributes on the searchValue element
-                    if v[:search_value].is_a?(Hash) && v[:search_value].has_key?(:'@internal_id')
-                      record[search_group][k] = v[:search_value][:'@internal_id']
-                    else
-                      record[search_group][k] = v[:search_value]
-                    end
+                    # Here's an example of a record ref and string response
+
+                    # <platformCommon:entity>
+                    #   <platformCore:searchValue internalId="446515"/>
+                    # </platformCommon:entity>
+                    # <platformCommon:status>
+                    #   <platformCore:searchValue>open</platformCore:searchValue>
+                    # </platformCommon:status>
+
+                    # in both cases, header-level field's value should be set to the
+                    # child `searchValue` result: if it's a record ref, the internalId
+                    # attribute will be transitioned to the parent, and in the case
+                    # of a string response the parent node's value will be to the string
+
+                    record[search_group][k] = v[:search_value]
+                  else
+                    # NOTE need to understand this case more, in testing, only the namespace definition hits this condition
                   end
                 end
               end
@@ -97,4 +108,4 @@ module NetSuite
 
     end
   end
-end
+end

data/lib/netsuite/utilities.rb

@@ -7,6 +7,7 @@ module NetSuite
     def clear_cache!
       @netsuite_get_record_cache = {}
       @netsuite_find_record_cache = {}
+      DataCenter.clear_cache!
     end
 
     def append_memo(ns_record, added_memo, opts = {})
@@ -64,19 +65,18 @@ module NetSuite
       return errors.size > 0
     end
 
-
-    def get_item(ns_item_internal_id)
+    def get_item(ns_item_internal_id, opts = {})
       # TODO add additional item types!
-      ns_item = NetSuite::Utilities.get_record(NetSuite::Records::InventoryItem, ns_item_internal_id)
-      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::AssemblyItem, ns_item_internal_id)
-      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::NonInventorySaleItem, ns_item_internal_id)
-      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::NonInventoryResaleItem, ns_item_internal_id)
-      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::DiscountItem, ns_item_internal_id)
-      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::OtherChargeSaleItem, ns_item_internal_id)
-      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::ServiceSaleItem, ns_item_internal_id)
-      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::GiftCertificateItem, ns_item_internal_id)
-      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::KitItem, ns_item_internal_id)
-      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::SerializedInventoryItem, ns_item_internal_id)
+      ns_item = NetSuite::Utilities.get_record(NetSuite::Records::InventoryItem, ns_item_internal_id, opts)
+      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::AssemblyItem, ns_item_internal_id, opts)
+      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::NonInventorySaleItem, ns_item_internal_id, opts)
+      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::NonInventoryResaleItem, ns_item_internal_id, opts)
+      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::DiscountItem, ns_item_internal_id, opts)
+      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::OtherChargeSaleItem, ns_item_internal_id, opts)
+      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::ServiceSaleItem, ns_item_internal_id, opts)
+      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::GiftCertificateItem, ns_item_internal_id, opts)
+      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::KitItem, ns_item_internal_id, opts)
+      ns_item ||= NetSuite::Utilities.get_record(NetSuite::Records::SerializedInventoryItem, ns_item_internal_id, opts)
 
       if ns_item.nil?
         fail NetSuite::RecordNotFound, "item with ID #{ns_item_internal_id} not found"
@@ -157,27 +157,8 @@ module NetSuite
       nil
     end
 
-    def data_center_url(netsuite_account)
-      begin
-        data_center_call_response = NetSuite::Configuration.connection({}, {
-          email: '',
-          password: '',
-          account: ''
-        }).call(:get_data_center_urls, message: {
-          'platformMsgs:account' => netsuite_account
-        })
-
-        if data_center_call_response.success?
-          return data_center_call_response.body[:get_data_center_urls_response][:get_data_center_urls_result][:data_center_urls][:webservices_domain]
-        else
-          # log.error "error getting data center url"
-        end
-      rescue Exception => e
-        # log.error "error determining correct datacenter for account #{netsuite_account}. #{e.message}"
-
-        # TODO silence this later: for now we need to investigate when this would occur
-        raise(e)
-      end
+    def data_center_url(*args)
+      DataCenter.get(*args)
     end
 
     # Warning this was developed with a Web Services user whose time zone was set to CST

data/lib/netsuite/utilities/data_center.rb

@@ -0,0 +1,57 @@
+module NetSuite
+  module Utilities
+    class DataCenter
+      class << self
+
+        def clear_cache!
+          @cache = {}
+        end
+
+        def get(netsuite_account, opts = {})
+          if opts[:cache] && wsdl=fetch_from_cache(netsuite_account)
+            return wsdl
+          end
+
+          response = make_data_center_call(netsuite_account)
+          if response.success?
+            wsdl = extract_wsdl_from_response(response)
+            cache[netsuite_account.to_s] = wsdl if opts[:cache]
+            return wsdl
+          else
+            return nil
+          end
+        end
+
+        private
+
+          def cache
+            @cache ||= {}
+          end
+
+          def make_data_center_call(netsuite_account)
+            NetSuite::Configuration.connection({}, {
+              email: '',
+              password: '',
+              account: ''
+            }).call(:get_data_center_urls, message: {
+              'platformMsgs:account' => netsuite_account
+            })
+            # allow errors to bubble up, log if patterns emerge
+          end
+
+          def fetch_from_cache(netsuite_account)
+            return cache.fetch(netsuite_account.to_s, nil)
+          end
+
+          def extract_wsdl_from_response(response)
+            response.body
+              .fetch(:get_data_center_urls_response)
+              .fetch(:get_data_center_urls_result)
+              .fetch(:data_center_urls)
+              .fetch(:webservices_domain)
+          end
+
+      end
+    end
+  end
+end

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module Netsuite
-  VERSION = '0.7.5'
+  VERSION = '0.7.6'
 end

data/spec/netsuite/actions/get_deleted_spec.rb

@@ -0,0 +1,60 @@
+require 'spec_helper'
+
+describe NetSuite::Actions::GetDeleted do
+  before(:all) { savon.mock!  }
+  after(:all) { savon.unmock! }
+
+  describe 'Invoice' do
+    before do
+      savon.expects(:get_deleted).with(:message => {
+        'platformMsgs:pageIndex' => 1,
+        'platformMsgs:getDeletedFilter' => {
+          "platformCore:type" => {
+            "@operator" =>"anyOf",
+            "platformCore:searchValue" => ["invoice"],
+          },
+          "platformCore:deletedDate" => {
+            "@operator" =>"within",
+            "platformCore:searchValue" => "2016-12-01T00:00:00",
+            "platformCore:searchValue2" => "2016-12-02T00:00:00",
+          }
+        }
+      }).returns(File.read('spec/support/fixtures/get_deleted/get_deleted_invoices.xml'))
+    end
+
+    it 'makes a valid request to the NetSuite API' do
+      NetSuite::Actions::GetDeleted.call([NetSuite::Records::Invoice, { page: 1, criteria: [
+        {
+          field: 'type',
+          operator: 'anyOf',
+          type: 'SearchEnumMultiSelectField',
+          value: ["invoice"]
+        },
+        {
+          field: 'deletedDate',
+          operator: "within",
+          type: 'SearchDateField',
+          value: ["2016-12-01T00:00:00","2016-12-02T00:00:00"]
+        }
+      ]}])
+    end
+
+    it 'returns a valid Response object' do
+      response = NetSuite::Actions::GetDeleted.call([NetSuite::Records::Invoice, { page: 1, criteria: [
+        {
+          field: 'type',
+          operator: 'anyOf',
+          type: 'SearchEnumMultiSelectField',
+          value: ["invoice"]
+        },
+        {
+          field: 'deletedDate',
+          operator: "within",
+          type: 'SearchDateField',
+          value: ["2016-12-01T00:00:00","2016-12-02T00:00:00"]
+        }
+      ]}])
+      expect(response).to be_kind_of(NetSuite::Response)
+    end
+  end
+end

data/spec/netsuite/configuration_spec.rb

@@ -29,14 +29,34 @@ describe NetSuite::Configuration do
   end
 
   describe '#connection' do
-    it 'returns a Savon::Client object that allows requests to the service' do
+    before(:each) do
       # reset clears out the password info
-      config.email 'me@example.com'
-      config.password 'me@example.com'
-      config.account 1023
+      config.email       'me@example.com'
+      config.password    'me@example.com'
+      config.account     1023
+      config.wsdl        "my_wsdl"
+      config.api_version "2012_2"
+    end
 
+    it 'returns a Savon::Client object that allows requests to the service' do
       expect(config.connection).to be_kind_of(Savon::Client)
     end
+
+    it 'caches the client' do
+      expect(config.wsdl_cache).to be_empty
+      conn = config.connection
+
+      expect(
+        config.wsdl_cache.fetch([config.api_version, config.wsdl])
+      ).to eq(conn)
+    end
+
+    it 'uses cached wsdls' do
+      allow(config).to receive(:cached_wsdl)
+      config.connection
+
+      expect(config).to have_received(:cached_wsdl)
+    end
   end
 
   describe '#wsdl' do
@@ -73,6 +93,77 @@ describe NetSuite::Configuration do
         expect(config.wsdl).to eql('https://system.na1.netsuite.com/wsdl/v2014_1_0/netsuite.wsdl')
       end
     end
+
+    context '#cache_wsdl' do
+      it 'stores the client' do
+        expect(config.wsdl_cache).to be_empty
+        config.cache_wsdl("whatevs")
+        expect(config.wsdl_cache).to eq(
+          {[config.api_version, config.wsdl] => "whatevs"}
+        )
+      end
+
+      it 'doesnt write over old values' do
+        config.class_exec(config.api_version, config.wsdl) do |api, wsdl|
+          wsdl_cache[[api, wsdl]] = "old value"
+        end
+        config.cache_wsdl("new value")
+
+        expect(config.wsdl_cache.values.first).to eq("old value")
+      end
+
+      it 'handles a nil cache' do
+        config.class_eval { @wsdl_cache = nil }
+        config.cache_wsdl("whatevs")
+        expect(config.wsdl_cache).to eq(
+          {[config.api_version, config.wsdl] => "whatevs"}
+        )
+      end
+
+      it 'can cache multiple values' do
+        config.class_exec("2020_2", "fake wsdl") do |api, wsdl|
+          wsdl_cache[[api, wsdl]] = "old value"
+        end
+        expect(config.wsdl_cache.keys.count).to eq 1
+        config.cache_wsdl("new value")
+
+        expect(config.wsdl_cache.keys.count).to eq 2
+      end
+    end
+
+    context '#cached_wsdl' do
+      it 'returns wsdl (xml)' do
+        config.class_exec(config.api_version, config.wsdl) do |api, wsdl|
+          wsdl_cache[[api, wsdl]] = "xml wsdl string"
+        end
+        expect( config.cached_wsdl ).to eq "xml wsdl string"
+      end
+
+      it 'stores client xml' do
+        client = double(:savon_client)
+        allow(client).to receive(:is_a?).with(String).and_return(false)
+        allow(client).to receive(:is_a?).with(Savon::Client).and_return(true)
+        wsdl_dbl = double(:wsdl, xml: "xml wsdl")
+        client.instance_exec(wsdl_dbl) {|wsdl| @wsdl = wsdl }
+        config.class_exec(config.api_version, config.wsdl, client) do |api, wsdl, c|
+          wsdl_cache[[api, wsdl]] = c
+        end
+
+        expect( config.wsdl_cache.values.first ).to eq client
+        expect( config.cached_wsdl ).to eq "xml wsdl"
+        expect( config.wsdl_cache.values.first ).to eq "xml wsdl"
+      end
+
+      it 'handles a nil cache' do
+        config.class_eval { @wsdl_cache = nil }
+        expect( config.cached_wsdl ).to eq nil
+      end
+
+      it 'handles an empty cache' do
+        expect(config.wsdl_cache).to be_empty
+        expect( config.cached_wsdl ).to eq nil
+      end
+    end
   end
 
   describe '#auth_header' do

data/spec/netsuite/records/customer_spec.rb

@@ -17,8 +17,8 @@ describe NetSuite::Records::Customer do
       :opening_balance, :opening_balance_account, :opening_balance_date, :overdue_balance,
       :password, :password2, :phone, :phonetic_name, :pref_cc_processor,:print_on_check_as,
       :print_transactions, :referrer, :reminder_days, :representing_subsidiary, :require_pwd_change, :resale_number,
-      :sales_group, :sales_readiness, :sales_team_list, :salutation, :send_email, :ship_complete, :shipping_item,
-      :stage, :start_date, :sync_partner_teams, :tax_exempt, :tax_item, :taxable,
+      :sales_group, :sales_readiness, :sales_team_list, :salutation, :send_email, :ship_complete,
+      :stage, :start_date, :sync_partner_teams, :tax_exempt, :taxable,
       :third_party_acct, :third_party_country, :third_party_zipcode, :title, :unbilled_orders, :url,
       :vat_reg_number, :visits, :web_lead
     ].each do |field|
@@ -28,7 +28,7 @@ describe NetSuite::Records::Customer do
 
   it 'has the right record_refs' do
     [
-      :access_role, :currency, :custom_form, :entity_status, :partner, :sales_rep, :terms, :parent, :territory
+      :access_role, :currency, :custom_form, :entity_status, :partner, :sales_rep, :terms, :parent, :territory, :shipping_item, :tax_item
     ].each do |record_ref|
       expect(customer).to have_record_ref(record_ref)
     end

data/spec/netsuite/records/non_inventory_sale_item_spec.rb

@@ -91,6 +91,32 @@ describe NetSuite::Records::NonInventorySaleItem do
     end
   end
 
+  describe '#update' do
+    context 'when the response is successful' do
+      let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
+
+      it 'returns true' do
+        expect(NetSuite::Actions::Update).to receive(:call).
+            with([item.class, {external_id: 'foo'}], {}).
+            and_return(response)
+        item.external_id = 'foo'
+        expect(item.update).to be_truthy
+      end
+    end
+
+    context 'when the response is unsuccessful' do
+      let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
+
+      it 'returns false' do
+        expect(NetSuite::Actions::Update).to receive(:call).
+            with([item.class, {external_id: 'foo'}], {}).
+            and_return(response)
+        item.external_id = 'foo'
+        expect(item.update).to be_falsey
+      end
+    end
+  end
+
   describe '#delete' do
     context 'when the response is successful' do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }

data/spec/netsuite/utilities/data_center_spec.rb

@@ -0,0 +1,110 @@
+require 'spec_helper'
+
+describe NetSuite::Utilities::DataCenter do
+  describe '#get' do
+    let(:wsdl) { "https://webservices.na1.netsuite.com" }
+    let(:account) { "BOGUSACCT" }
+    let(:response) do
+      double(
+        success?: true,
+        body: {
+          get_data_center_urls_response: {
+            get_data_center_urls_result: {
+              data_center_urls: { webservices_domain: wsdl }
+            }
+          }
+        }
+      )
+    end
+
+    context 'without caching' do
+      it 'hits the API more than once' do
+        allow(described_class).to receive(:make_data_center_call)
+          .with(account)
+          .and_return(response)
+        10.times { described_class.get(account) }
+
+        expect(described_class).to have_received(:make_data_center_call)
+          .with(account).exactly(10).times
+      end
+
+    end
+
+    context 'when caching is enabled' do
+
+      it 'doesnt hit the API when cached response is present' do
+        described_class.class_exec(account) {|acct| cache[acct] = "wsdl" }
+        allow(described_class).to receive(:make_data_center_call)
+        described_class.get(account, cache: true)
+
+        expect(described_class).to_not have_received(:make_data_center_call)
+      end
+
+      it 'hits the API at most once' do
+        allow(described_class).to receive(:make_data_center_call)
+          .with(account)
+          .and_return(response)
+        10.times { described_class.get(account, cache: true) }
+
+        expect(described_class).to have_received(:make_data_center_call)
+          .with(account).exactly(1).times
+      end
+
+      it 'hits the API after its cache is cleared' do
+        described_class.class_exec(account) {|acct| cache[acct] = "wsdl" }
+        allow(described_class).to receive(:make_data_center_call)
+          .with(account)
+          .and_return(response)
+        described_class.get(account, cache: true)
+
+        expect(described_class).to_not have_received(:make_data_center_call)
+
+        described_class.clear_cache!
+        described_class.get(account, cache: true)
+
+        expect(described_class).to have_received(:make_data_center_call)
+          .with(account).exactly(1).times
+      end
+
+      it 'hits the API if the cache contains another response' do
+        described_class.class_eval { cache["BOGUS"] = "wsdl" }
+        allow(described_class).to receive(:make_data_center_call)
+          .with(account)
+          .and_return(response)
+        expect(account).to_not eq("BOGUS")
+        described_class.get(account, cache: true)
+
+        expect(described_class).to have_received(:make_data_center_call)
+          .with(account).exactly(1).times
+      end
+    end
+
+    context 'when cache is empty' do
+
+      it 'does hit the API' do
+        expect( described_class.class_eval { cache }).to eq({})
+        allow(described_class).to receive(:make_data_center_call)
+          .with(account)
+          .and_return(response)
+
+        described_class.get(account, cache: true)
+
+        expect(described_class).to have_received(:make_data_center_call)
+          .with(account).exactly(1).times
+      end
+
+      it 'stores API response' do
+        expect( described_class.class_eval { cache }).to eq({})
+        allow(described_class).to receive(:make_data_center_call)
+          .with(account)
+          .and_return(response)
+
+        described_class.get(account, cache: true)
+
+        expect( described_class.class_eval { cache }).to eq(
+          { account => wsdl }
+        )
+      end
+    end
+  end
+end

data/spec/support/fixtures/get_deleted/get_deleted_invoices.xml

@@ -0,0 +1,38 @@
+<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <soapenv:Header>
+    <platformMsgs:documentInfo xmlns:platformMsgs="urn:messages_2016_1.platform.webservices.netsuite.com">
+      <platformMsgs:nsId>WEBSERVICES_3868171_122020162073815481885806769_24761121647f</platformMsgs:nsId>
+    </platformMsgs:documentInfo>
+  </soapenv:Header>
+  <soapenv:Body>
+    <getDeletedResponse xmlns="urn:messages_2016_1.platform.webservices.netsuite.com">
+      <platformCore:getDeletedResult xmlns:platformCore="urn:core_2016_1.platform.webservices.netsuite.com">
+        <platformCore:status isSuccess="true"/>
+        <platformCore:totalRecords>3</platformCore:totalRecords>
+        <platformCore:pageSize>1000</platformCore:pageSize>
+        <platformCore:totalPages>1</platformCore:totalPages>
+        <platformCore:pageIndex>1</platformCore:pageIndex>
+        <platformCore:deletedRecordList>
+          <platformCore:deletedRecord>
+            <platformCore:deletedDate>2016-12-15T15:00:00.000-08:00</platformCore:deletedDate>
+            <platformCore:record internalId="1" type="invoice" xsi:type="platformCore:RecordRef">
+              <platformCore:name>REDACTED</platformCore:name>
+            </platformCore:record>
+          </platformCore:deletedRecord>
+          <platformCore:deletedRecord>
+            <platformCore:deletedDate>2016-12-09T13:00:00.000-08:00</platformCore:deletedDate>
+            <platformCore:record internalId="2" type="invoice" xsi:type="platformCore:RecordRef">
+              <platformCore:name>REDACTED</platformCore:name>
+            </platformCore:record>
+          </platformCore:deletedRecord>
+          <platformCore:deletedRecord>
+            <platformCore:deletedDate>2016-12-15T15:00:00.000-08:00</platformCore:deletedDate>
+            <platformCore:record internalId="3" type="invoice" xsi:type="platformCore:RecordRef">
+              <platformCore:name>REDACTED</platformCore:name>
+            </platformCore:record>
+          </platformCore:deletedRecord>
+        </platformCore:deletedRecordList>
+      </platformCore:getDeletedResult>
+    </getDeletedResponse>
+  </soapenv:Body>
+</soapenv:Envelope>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netsuite
 version: !ruby/object:Gem::Version
-  version: 0.7.5
+  version: 0.7.6
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-17 00:00:00.000000000 Z
+date: 2017-01-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -66,6 +66,7 @@ files:
 - lib/netsuite/actions/delete_list.rb
 - lib/netsuite/actions/get.rb
 - lib/netsuite/actions/get_all.rb
+- lib/netsuite/actions/get_deleted.rb
 - lib/netsuite/actions/get_list.rb
 - lib/netsuite/actions/get_select_value.rb
 - lib/netsuite/actions/initialize.rb
@@ -291,11 +292,13 @@ files:
 - lib/netsuite/support/search_result.rb
 - lib/netsuite/support/sublist.rb
 - lib/netsuite/utilities.rb
+- lib/netsuite/utilities/data_center.rb
 - lib/netsuite/version.rb
 - netsuite.gemspec
 - spec/netsuite/actions/add_spec.rb
 - spec/netsuite/actions/delete_list_spec.rb
 - spec/netsuite/actions/delete_spec.rb
+- spec/netsuite/actions/get_deleted_spec.rb
 - spec/netsuite/actions/get_list_spec.rb
 - spec/netsuite/actions/get_spec.rb
 - spec/netsuite/actions/initialize_spec.rb
@@ -421,6 +424,7 @@ files:
 - spec/netsuite/support/records_spec.rb
 - spec/netsuite/support/requests_spec.rb
 - spec/netsuite/support/sublist_spec.rb
+- spec/netsuite/utilities/data_center_spec.rb
 - spec/netsuite/utilities/request_spec.rb
 - spec/netsuite/utilities/roles_spec.rb
 - spec/netsuite/utilities_spec.rb
@@ -438,6 +442,7 @@ files:
 - spec/support/fixtures/delete_list/delete_list_customers_with_errors.xml
 - spec/support/fixtures/get/get_customer.xml
 - spec/support/fixtures/get/get_invoice.xml
+- spec/support/fixtures/get_deleted/get_deleted_invoices.xml
 - spec/support/fixtures/initialize/initialize_invoice_from_customer.xml
 - spec/support/fixtures/login/failure_concurrent_requests.xml
 - spec/support/fixtures/login/failure_invalid_credentials.xml
@@ -486,6 +491,7 @@ test_files:
 - spec/netsuite/actions/add_spec.rb
 - spec/netsuite/actions/delete_list_spec.rb
 - spec/netsuite/actions/delete_spec.rb
+- spec/netsuite/actions/get_deleted_spec.rb
 - spec/netsuite/actions/get_list_spec.rb
 - spec/netsuite/actions/get_spec.rb
 - spec/netsuite/actions/initialize_spec.rb
@@ -611,6 +617,7 @@ test_files:
 - spec/netsuite/support/records_spec.rb
 - spec/netsuite/support/requests_spec.rb
 - spec/netsuite/support/sublist_spec.rb
+- spec/netsuite/utilities/data_center_spec.rb
 - spec/netsuite/utilities/request_spec.rb
 - spec/netsuite/utilities/roles_spec.rb
 - spec/netsuite/utilities_spec.rb
@@ -628,6 +635,7 @@ test_files:
 - spec/support/fixtures/delete_list/delete_list_customers_with_errors.xml
 - spec/support/fixtures/get/get_customer.xml
 - spec/support/fixtures/get/get_invoice.xml
+- spec/support/fixtures/get_deleted/get_deleted_invoices.xml
 - spec/support/fixtures/initialize/initialize_invoice_from_customer.xml
 - spec/support/fixtures/login/failure_concurrent_requests.xml
 - spec/support/fixtures/login/failure_invalid_credentials.xml