netsuite 0.7.4 → 0.7.5

data/README.md

@@ -124,25 +124,23 @@ task.update :message => 'New Message'
 
 task.delete
 
-# using get_select_value with a custom record
-NetSuite::Records::BaseRefList.get_select_value(
-  field: 'custrecord_something',
-  customRecordType: {
-    '@internalId' => 10,
-    '@xsi:type' => 'customRecord'
-  }
-)
-
 # using get_select_value with a standard record
 NetSuite::Records::BaseRefList.get_select_value(
   recordType: 'serviceSaleItem',
   field: 'taxSchedule'
 )
 
-# updating a custom field list
+```
+
+#### Custom Records & Fields
+
+```ruby
+# updating a custom field list on a record
+
 # you need to push ALL the values of ALL of the custom fields that you want set on the record
 # you can't just push the values of the fields that you want to update: all of the values of
 # other fields will then fall back to their default values
+
 contact = NetSuite::Records::Contact.get(12345)
 contact.custom_field_list.custentity_alistfield = { internal_id: 1 }
 contact.custom_field_list.custentity_abooleanfield = true
@@ -175,6 +173,14 @@ record = NetSuite::Records::CustomRecord.new(internal_id: 100)
 record.custom_field_list.custrecord_locationstate = "New Jersey"
 record.update(custom_field_list: record.custom_field_list, rec_type: NetSuite::Records::CustomRecord.new(internal_id: 10))
 
+# using get_select_value with a custom record
+NetSuite::Records::BaseRefList.get_select_value(
+  field: 'custrecord_something',
+  customRecordType: {
+    '@internalId' => 10,
+    '@xsi:type' => 'customRecord'
+  }
+)
 ```
 
 #### Searching

data/lib/netsuite/configuration.rb

@@ -3,6 +3,8 @@ module NetSuite
     extend self
 
     def reset!
+      NetSuite::Utilities.clear_cache!
+
       attributes.clear
     end
 
@@ -286,13 +288,17 @@ module NetSuite
     end
 
     def logger(value = nil)
-      attributes[:logger] = if value.nil?
-        ::Logger.new((log && !log.empty?) ? log : $stdout)
+      if value.nil?
+        attributes[:logger] ||= ::Logger.new((log && !log.empty?) ? log : $stdout)
       else
-        value
+        attributes[:logger] = value
       end
     end
 
+    def logger=(value)
+      attributes[:logger] = value
+    end
+
     def silent(value=nil)
       self.silent = value if !value.nil?
       attributes[:silent]

data/lib/netsuite/records/credit_memo.rb

@@ -20,11 +20,16 @@ module NetSuite
         :vsoe_auto_calc
 
       field :custom_field_list,        CustomFieldList
-      field :transaction_bill_address, BillAddress
       field :item_list,                CreditMemoItemList
       field :apply_list,               CreditMemoApplyList
       field :ship_group_list,          SalesOrderShipGroupList
 
+      # field :bill_address_list,
+      field :transaction_bill_address, BillAddress
+
+      # NOTE only available on API > 2014_1
+      field :billing_address, Address
+
       read_only_fields :applied, :discount_total, :sub_total, :tax_total, :total, :unapplied
 
       record_refs :account, :bill_address_list, :created_from, :custom_form, :department, :discount_item, :entity, :gift_cert,

data/lib/netsuite/records/invoice.rb

@@ -44,7 +44,7 @@ module NetSuite
 
       record_refs :account, :bill_address_list, :custom_form, :department, :entity, :klass, :partner,
                   :posting_period, :ship_address_list, :terms, :location, :sales_rep, :tax_item, :created_from,
-                  :ship_method, :lead_source, :promo_code, :subsidiary, :currency
+                  :ship_method, :lead_source, :promo_code, :subsidiary, :currency, :approval_status
 
       attr_reader   :internal_id
       attr_accessor :external_id

data/lib/netsuite/records/pricing_matrix.rb

@@ -1,23 +1,11 @@
 module NetSuite
   module Records
-    class PricingMatrix
+    class PricingMatrix < Support::Sublist
       include Namespaces::PlatformCore
 
-      def initialize(attributes = {})
-        attributes[:pricing] = [attributes[:pricing]] unless
-          attributes[:pricing].is_a? Array
-        attributes[:pricing].each do |pricing|
-          prices << RecordRef.new(pricing)
-        end if attributes[:pricing]
-      end
+      sublist :pricing, RecordRef
 
-      def prices
-        @prices ||= []
-      end
-
-      def to_record
-        { "#{record_namespace}:item" => prices.map(&:to_record) }
-      end
+      alias :prices :pricing
     end
   end
 end

data/lib/netsuite/rest/utilities/request.rb

@@ -32,8 +32,15 @@ module NetSuite
 
             http = Net::HTTP.new(uri.hostname, uri.port)
             http.use_ssl      = USE_SSL
+            http.ssl_version = :TLSv1_2
             http.read_timeout = DEFAULT_TIMEOUT
-            http.start {|http| http.request(method)}
+
+            # TODO username + password will be outputted to STDOUT if this is enabled
+            # if !NetSuite::Configuration.silent
+            #   http.set_debug_output(NetSuite::Configuration.logger)
+            # end
+
+            http.start { |http| http.request(method) }
           end
 
           def auth_header(email, signature)
@@ -45,10 +52,7 @@ module NetSuite
           end
 
           def encode(unencoded_string)
-            URI.escape(
-              unencoded_string,
-              /[#{URI::PATTERN::RESERVED}]/
-            )
+            CGI.escape(unencoded_string)
           end
 
         end

data/lib/netsuite/utilities.rb

@@ -4,6 +4,11 @@ module NetSuite
 
     # TODO need structured logger for various statements
 
+    def clear_cache!
+      @netsuite_get_record_cache = {}
+      @netsuite_find_record_cache = {}
+    end
+
     def append_memo(ns_record, added_memo, opts = {})
       opts[:skip_if_exists] ||= false
 
@@ -83,14 +88,29 @@ module NetSuite
     def get_record(record_klass, id, opts = {})
       opts[:external_id] ||= false
 
+      if opts[:cache]
+        @netsuite_get_record_cache ||= {}
+        @netsuite_get_record_cache[record_klass.to_s] ||= {}
+
+        if cached_record = @netsuite_get_record_cache[record_klass.to_s][id.to_i]
+          return cached_record
+        end
+      end
+
       begin
         # log.debug("get record", netsuite_record_type: record_klass.name, netsuite_record_id: id)
 
-        if opts[:external_id]
-          return backoff { record_klass.get(external_id: id) }
+        ns_record = if opts[:external_id]
+          backoff { record_klass.get(external_id: id) }
         else
-          return backoff { record_klass.get(id) }
+          backoff { record_klass.get(id) }
+        end
+
+        if opts[:cache]
+          @netsuite_get_record_cache[record_klass.to_s][id.to_i] = ns_record
         end
+
+        return ns_record
       rescue ::NetSuite::RecordNotFound
         # log.warn("record not found", ns_record_type: record_klass.name, ns_record_id: id)
         return nil

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module Netsuite
-  VERSION = '0.7.4'
+  VERSION = '0.7.5'
 end

data/spec/netsuite/configuration_spec.rb

@@ -261,4 +261,16 @@ describe NetSuite::Configuration do
     expect(config.wsdl_domain).to eq('webservices.sandbox.netsuite.com')
   end
 
+  describe '#logger=' do
+    let(:logger) { Logger.new(nil) }
+
+    before do
+      config.logger = logger
+    end
+
+    it 'sets logger' do
+      expect(config.logger).to eql(logger)
+    end
+  end
+
 end

data/spec/netsuite/utilities_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+
+describe NetSuite::Utilities do
+  describe '#get_record' do
+    it 'does not hit the netsuite API when caching is enabled' do
+      ns_account_id = 123
+      allow(NetSuite::Records::Account).to receive(:get).with(ns_account_id).once.and_return(
+        NetSuite::Records::Account.new(internal_id: ns_account_id)
+      )
+
+      ns_account = NetSuite::Utilities.get_record(NetSuite::Records::Account, ns_account_id, cache: true)
+      expect(ns_account.internal_id).to eq(ns_account_id)
+
+      ns_account = NetSuite::Utilities.get_record(NetSuite::Records::Account, ns_account_id, cache: true)
+      expect(ns_account.internal_id).to eq(ns_account_id)
+    end
+
+    it 'pulls a record by internal id' do
+      ns_account_id = 123
+      ns_account_external_id = "abc"
+      allow(NetSuite::Records::Account).to receive(:get).with({ external_id: ns_account_external_id }).once.and_return(
+        NetSuite::Records::Account.new(internal_id: ns_account_id)
+      )
+
+      ns_account = NetSuite::Utilities.get_record(NetSuite::Records::Account, ns_account_external_id, external_id: true)
+      expect(ns_account.internal_id).to eq(ns_account_id)
+    end
+
+    it 'pulls a record by external id' do
+      ns_account_id = 123
+      allow(NetSuite::Records::Account).to receive(:get).with(ns_account_id).once.and_return(
+        NetSuite::Records::Account.new(internal_id: ns_account_id)
+      )
+
+      ns_account = NetSuite::Utilities.get_record(NetSuite::Records::Account, ns_account_id)
+      expect(ns_account.internal_id).to eq(ns_account_id)
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netsuite
 version: !ruby/object:Gem::Version
-  version: 0.7.4
+  version: 0.7.5
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-01 00:00:00.000000000 Z
+date: 2016-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -423,6 +423,7 @@ files:
 - spec/netsuite/support/sublist_spec.rb
 - spec/netsuite/utilities/request_spec.rb
 - spec/netsuite/utilities/roles_spec.rb
+- spec/netsuite/utilities_spec.rb
 - spec/netsuite_spec.rb
 - spec/spec_helper.rb
 - spec/support/2015.wsdl
@@ -612,6 +613,7 @@ test_files:
 - spec/netsuite/support/sublist_spec.rb
 - spec/netsuite/utilities/request_spec.rb
 - spec/netsuite/utilities/roles_spec.rb
+- spec/netsuite/utilities_spec.rb
 - spec/netsuite_spec.rb
 - spec/spec_helper.rb
 - spec/support/2015.wsdl