netsuite 0.6.1 → 0.6.2

data/lib/netsuite.rb

@@ -34,7 +34,6 @@ module NetSuite
   module Support
     autoload :Actions,    'netsuite/support/actions'
     autoload :Attributes, 'netsuite/support/attributes'
-    autoload :Base,       'netsuite/support/base'
     autoload :Fields,     'netsuite/support/fields'
     autoload :Sublist,    'netsuite/support/sublist'
     autoload :RecordRefs, 'netsuite/support/record_refs'

data/lib/netsuite/records/bin.rb

@@ -1,7 +1,9 @@
 module NetSuite
   module Records
-    
-    class Bin < NetSuite::Support::Base
+
+    class Bin
+      include Support::Records
+      include Support::Fields
       include Support::RecordRefs
       include Support::Actions
       include Namespaces::ListAcct
@@ -16,7 +18,13 @@ module NetSuite
       fields :bin_number, :is_inactive, :location, :memo
 
       field :custom_field_list, NetSuite::Records::CustomFieldList
+
+      def initialize(attributes = {})
+        @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
+        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
+        initialize_from_attributes_hash(attributes)
+      end
     end
 
   end
-end
+end

data/lib/netsuite/records/contact_access_roles.rb

@@ -1,6 +1,8 @@
 module NetSuite
   module Records
-    class ContactAccessRoles < NetSuite::Support::Base
+    class ContactAccessRoles
+      include Support::Records
+      include Support::Fields
       include Support::RecordRefs
       include Namespaces::ListRel
 
@@ -9,6 +11,13 @@ module NetSuite
       fields :email, :give_access, :password, :password2, :send_email
 
       record_refs :contact, :role
+
+      def initialize(attributes = {})
+        @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
+        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
+        initialize_from_attributes_hash(attributes)
+      end
+
     end
   end
 end

data/lib/netsuite/records/credit_memo.rb

@@ -38,6 +38,14 @@ module NetSuite
         initialize_from_attributes_hash(attributes)
       end
 
+      def self.search_class_name
+        "Transaction"
+      end
+
+      def self.search_class_namespace
+        'tranSales'
+      end
+
     end
   end
 end

data/lib/netsuite/records/credit_memo_apply_list.rb

@@ -13,4 +13,3 @@ module NetSuite
     end
   end
 end
-\

data/lib/netsuite/records/custom_list_custom_value.rb

@@ -1,6 +1,8 @@
 module NetSuite
   module Records
-    class CustomListCustomValue < Support::Base
+    class CustomListCustomValue
+      include Support::Records
+      include Support::Fields
       include Namespaces::SetupCustom
 
       # https://system.netsuite.com/help/helpcenter/en_US/srbrowser/Browser2014_1/schema/other/customlistcustomvalue.html?mode=package
@@ -9,6 +11,12 @@ module NetSuite
 
       # field valueLanguageValueList
 
+      def initialize(attributes = {})
+        @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
+        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
+        initialize_from_attributes_hash(attributes)
+      end
+
     end
   end
-end
+end

data/lib/netsuite/records/employee.rb

@@ -1,6 +1,8 @@
 module NetSuite
   module Records
-    class Employee < Support::Base
+    class Employee
+      include Support::Records
+      include Support::Fields
       include Support::Actions
       include Support::RecordRefs
       include Namespaces::ListEmp
@@ -24,6 +26,12 @@ module NetSuite
       attr_reader :internal_id
       attr_accessor :external_id
 
+      def initialize(attributes = {})
+        @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
+        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
+        initialize_from_attributes_hash(attributes)
+      end
+
       def self.search_class_name
         'Employee'
       end

data/lib/netsuite/records/file.rb

@@ -1,6 +1,8 @@
 module NetSuite
   module Records
-    class File < NetSuite::Support::Base
+    class File
+      include Support::Records
+      include Support::Fields
       include Support::RecordRefs
       include Support::Actions
       include Namespaces::FileCabinet
@@ -9,7 +11,7 @@ module NetSuite
 
       actions :get, :add, :delete, :search, :get_list
 
-      fields :content, :description, :name, :media_type_name, :file_type, :text_file_encoding
+      fields :content, :description, :name, :media_type_name, :file_type, :text_file_encoding, :created_date, :last_modified_date
 
       record_refs :folder, :klass
 
@@ -17,7 +19,13 @@ module NetSuite
 
       attr_reader   :internal_id
       attr_accessor :external_id
+
+      def initialize(attributes = {})
+        @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
+        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
+        initialize_from_attributes_hash(attributes)
+      end
+
     end
   end
 end
-

data/lib/netsuite/records/payment_method.rb

@@ -3,6 +3,7 @@ module NetSuite
     class PaymentMethod
       include Support::Fields
       include Support::RecordRefs
+      include Support::Records
       include Support::Actions
       include Namespaces::ListAcct
 

data/lib/netsuite/records/roles.rb

@@ -1,10 +1,17 @@
 module NetSuite
   module Records
-    class Roles < NetSuite::Support::Base
+    class Roles
+      include Support::Records
+      include Support::Fields
       include Support::RecordRefs
       include Namespaces::ListEmp
 
       record_refs :selected_role
+
+      def initialize(attributes = {})
+        initialize_from_attributes_hash(attributes)
+      end
+
     end
   end
 end

data/lib/netsuite/support/fields.rb

@@ -60,13 +60,6 @@ module NetSuite
           read_only_fields << name_sym
           field name
         end
-
-        # a bit of trickery: this is for classes which inherit from other classes
-        # i.e. the AssemblyItem, KitItem, etc; this copies the superclass's fields over
-        def inherited(klass)
-          klass.instance_variable_set("@fields", self.fields)
-          klass.instance_variable_set("@read_only_fields", self.read_only_fields)
-        end
       end
 
     end

data/lib/netsuite/support/sublist.rb

@@ -3,6 +3,12 @@ module NetSuite
     class Sublist
       include Support::Fields
 
+      def self.inherited(subclass)
+        subclass.class_eval do
+          field :replace_all
+        end
+      end
+
       class << self
 
         def sublist(key, klass)
@@ -24,8 +30,6 @@ module NetSuite
 
       end
 
-      field :replace_all
-
       def initialize(attributes = {})
         initialize_from_attributes_hash(attributes)
       end

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module Netsuite
-  VERSION = '0.6.1'
+  VERSION = '0.6.2'
 end

data/spec/netsuite/records/basic_record_spec.rb

@@ -24,6 +24,7 @@ describe 'basic records' do
       NetSuite::Records::TaxGroup,
       NetSuite::Records::Folder,
       NetSuite::Records::CustomerCategory,
+      NetSuite::Records::File,
     ]
   }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netsuite
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.2
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-06 00:00:00.000000000 Z
+date: 2016-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -245,7 +245,6 @@ files:
 - lib/netsuite/response.rb
 - lib/netsuite/support/actions.rb
 - lib/netsuite/support/attributes.rb
-- lib/netsuite/support/base.rb
 - lib/netsuite/support/country.rb
 - lib/netsuite/support/fields.rb
 - lib/netsuite/support/record_refs.rb

data/lib/netsuite/support/base.rb

@@ -1,21 +0,0 @@
-# https://github.com/NetSweet/netsuite/pull/129#discussion_r19126261
-
-module NetSuite
-  module Support
-
-    class Base
-      include Support::Records
-      include Support::Fields
-
-      def initialize(attributes = {})
-        # not all records have external/internal ID
-        # we extract them here, but it's up to the subclass to create the accessors
-
-        @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
-        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
-        initialize_from_attributes_hash(attributes)
-      end
-    end
-    
-  end
-end