netsuite 0.5.1 → 0.5.2

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NDI2Mzg2OGE2MDk3ZDc1ZTAyNzI4ODRkZmNiYzY2ZGRmNTk3YTk1OA==
+    ZDZjNmUwOTA5NzlmODQ4YWE0ZTk2ZmQzNDJmYTg1ZDI5ZjVhMjY3MA==
   data.tar.gz: !binary |-
-    NTA4Y2I5ZDE2Y2EwZTBkODE4MWEyYTU4MjRjMzViNjgwZjY5ZGUwNQ==
+    MThmZWIzZjgzNjdhNmJiMDgzY2FhZjAwOGY0M2Q3ZjZiNzQ0YTZkNQ==
 SHA512:
   metadata.gz: !binary |-
-    ODY4MjZhYWFjMDVlNjA1ZjI2MmUzODkxNTllZDYyYmQxYzQ1OTM0ZWZjYTBj
-    NWQwY2UwZTA4NWU5MzE2N2IzZWUwYTM3MDRlMDhiNDRmYmRmNThmOWYwNDI0
-    MmJmN2Q3N2FlNTMxMWQwZmYzNDEzOTY4NmQ0YTk0MmM1ZGZjY2M=
+    Y2JkOThlMGJlNGQ5Mzg4OTVlMTcyYmQwOGY5NjJmYWZjMGM1MmI0ZDQwMTdm
+    YzU1YzY0OGRmNDg4OWYzNTIyODA0MTZhMTlkNzA3MzY3NTBmMzcxYWFmMzkz
+    NzU2NzY4YTRlMDBjMTZlZTBkMDY2NzVjZThlNjRmODY0NjFiMzg=
   data.tar.gz: !binary |-
-    OWM1YTkzZmUzZTUxYTZkZDZhZmFlZDIxODQyYWViNGE0YjJhYTlhMWFiNmQw
-    YzRmYTk4Njc0YjAwZTM1YjM2MzdiNzIxODViM2U1ZDJjMDM0YmYwZjBmZWZh
-    ZTJlOGE0NGRhMWE0MDkxYmM0NDM4YTRjOGViMmNmMzc2MzE5N2I=
+    MjM5NWFiMzRlMjRjNWFiNTExMzFkYzE5OGRmYWJlM2ViMGE1N2RlNGZkNjky
+    NzE3ZWI2MDQ5ZTljZTlkNGVkZGI5ZDRmMzU4ZjVlYWM2ODdhZGU0NWMzYzdj
+    NWI0ZGJhMjJmYzFmOWFjMGMzMGUwZjgwMzY3YjYwY2YwZDdhOTk=

data/lib/netsuite.rb

@@ -167,6 +167,7 @@ module NetSuite
     autoload :RecordRef,                        'netsuite/records/record_ref'
     autoload :RecordRefList,                    'netsuite/records/record_ref_list'
     autoload :RevRecTemplate,                   'netsuite/records/rev_rec_template'
+    autoload :RevRecSchedule,                   'netsuite/records/rev_rec_schedule'
     autoload :RoleList,                         'netsuite/records/role_list'
     autoload :SalesOrder,                       'netsuite/records/sales_order'
     autoload :SalesOrderItem,                   'netsuite/records/sales_order_item'

data/lib/netsuite/actions/login.rb

@@ -38,14 +38,18 @@ module NetSuite
         rescue Savon::SOAPFault => e
           error_details = e.to_hash[:fault]
 
-          return NetSuite::Response.new(
-            success: false,
-            errors: [ NetSuite::Error.new(
-              code: error_details[:detail][:invalid_credentials_fault][:code],
-              message: error_details[:faultstring]
-            )],
-            body: error_details
-          )
+          if error_details[:detail].has_key?(:invalid_credentials_fault)
+            return NetSuite::Response.new(
+              success: false,
+              errors: [ NetSuite::Error.new(
+                code: error_details[:detail][:invalid_credentials_fault][:code],
+                message: error_details[:faultstring]
+              )],
+              body: error_details
+            )
+          else
+            raise(e)
+          end
         end
 
         # include more data in body; leave it up to the user to pull the data they are looking for

data/lib/netsuite/records/account.rb

@@ -14,6 +14,8 @@ module NetSuite
 
       record_refs :billable_expenses_acct, :category1099misc, :currency, :deferral_acct, :department, :klass, :location, :parent
 
+      field :subsidiary_list, RecordRefList
+
       attr_reader :internal_id
       attr_accessor :external_id
 

data/lib/netsuite/records/cash_refund.rb

@@ -9,7 +9,7 @@ module NetSuite
 
       actions :add, :get, :delete, :initialize, :upsert
 
-      fields :tran_date, :to_be_emailed, :memo, :total, :currency_name, :exchange_rate, :source, :tax_rate
+      fields :tran_id, :tran_date, :to_be_emailed, :memo, :total, :currency_name, :exchange_rate, :source, :tax_rate
 
       field :item_list, CashRefundItemList
       field :custom_field_list, CustomFieldList

data/lib/netsuite/records/journal_entry.rb

@@ -5,7 +5,7 @@ module NetSuite
       include Support::RecordRefs
       include Support::Records
       include Support::Actions
-      include Namespaces::TranSales
+      include Namespaces::TranGeneral
 
       actions :get, :get_list, :add, :delete, :search, :upsert
 
@@ -39,6 +39,10 @@ module NetSuite
         "Transaction"
       end
 
+      def self.search_class_namespace
+        "tranSales"
+      end
+
     end
   end
 end

data/lib/netsuite/records/rev_rec_schedule.rb

@@ -0,0 +1,32 @@
+# https://system.netsuite.com/help/helpcenter/en_US/srbrowser/Browser2015_1/schema/record/revrecschedule.html
+
+module NetSuite
+  module Records
+    class RevRecSchedule
+      include Support::Fields
+      include Support::RecordRefs
+      include Support::Records
+      include Support::Actions
+      include Namespaces::ListAcct
+
+      actions :get, :get_list, :add, :update, :upsert, :delete, :search
+
+      fields :initial_amount, :is_inactive, :name, :period_offset, :rev_rec_offset,
+             :amortization_period
+
+      record_refs :amortization_type, :recog_interval_src, :recurrence_type
+
+      # recurrenceList	RevRecScheduleRecurrenceList	0..1
+
+      attr_reader :internal_id
+      attr_accessor :external_id
+
+      def initialize(attributes = {})
+        @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
+        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
+        initialize_from_attributes_hash(attributes)
+      end
+
+    end
+  end
+end

data/lib/netsuite/records/vendor_bill_item.rb

@@ -8,7 +8,8 @@ module NetSuite
 
       fields  :amortization_end_date, :amortization_residual, :amortiz_start_date, :bin_numbers,  :bill_variance_status,
               :description, :expiration_date, :gross_amt, :inventory_detail, :is_billable, :landed_cost, :line,
-              :order_doc, :order_line, :quantity, :serial_numbers, :tax_rate_1, :tax_rate_2, :tax_1_amt, :vendor_name
+              :order_doc, :order_line, :quantity, :serial_numbers, :tax_rate_1, :tax_rate_2, :tax_1_amt, :vendor_name,
+              :rate
 
       field :bill_receipts_list,  RecordRefList
       field :custom_field_list,   CustomFieldList

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module Netsuite
-  VERSION = '0.5.1'
+  VERSION = '0.5.2'
 end

data/spec/netsuite/actions/login_spec.rb

@@ -4,10 +4,9 @@ describe NetSuite::Actions::Login do
   before { savon.mock! }
   after { savon.unmock! }
 
-  it 'properly executes a login call' do
+  it 'handles a successful login call' do
     message = {"platformMsgs:passport"=>{"platformCore:email"=>"email", "platformCore:password"=>"password", "platformCore:account"=>"1234", "platformCore:role"=>234}}
-
-    savon.expects(:login).with(:message => message).returns(File.read('spec/support/fixtures/login.xml'))
+    savon.expects(:login).with(:message => message).returns(File.read('spec/support/fixtures/login/success.xml'))
 
     result = NetSuite::Actions::Login.call({
       email: 'email',
@@ -18,4 +17,28 @@ describe NetSuite::Actions::Login do
     expect(result.success?).to eq(true)
     expect(result.body[:user_id]).to_not be_nil
   end
+
+  it 'handles a failed login call because of a concurrent request error' do
+    message = {"platformMsgs:passport"=>{"platformCore:email"=>"email", "platformCore:password"=>"password", "platformCore:account"=>"1234", "platformCore:role"=>234}}
+    savon.expects(:login).with(:message => message).returns(File.read('spec/support/fixtures/login/failure_invalid_credentials.xml'))
+
+    result = NetSuite::Actions::Login.call({
+      email: 'email',
+      password: 'password',
+      role: 234
+    })
+
+    expect(result.success?).to eq(false)
+  end
+
+  it 'handles a failed login call because of a concurrent request error' do
+    message = {"platformMsgs:passport"=>{"platformCore:email"=>"email", "platformCore:password"=>"password", "platformCore:account"=>"1234", "platformCore:role"=>234}}
+    savon.expects(:login).with(:message => message).returns(File.read('spec/support/fixtures/login/failure_concurrent_requests.xml'))
+
+    expect { NetSuite::Actions::Login.call({
+      email: 'email',
+      password: 'password',
+      role: 234
+    }) }.to raise_error(Savon::SOAPFault)
+  end
 end

data/spec/netsuite/records/basic_record_spec.rb

@@ -13,6 +13,9 @@ describe 'basic records' do
       NetSuite::Records::Opportunity,
       NetSuite::Records::VendorCategory,
       NetSuite::Records::Deposit,
+      NetSuite::Records::RevRecTemplate,
+      NetSuite::Records::RevRecSchedule,
+      NetSuite::Records::JournalEntry,
     ]
   }
 

data/spec/netsuite/records/cash_refund_spec.rb

@@ -6,7 +6,7 @@ describe NetSuite::Records::CashRefund do
 
   it 'has all the right fields' do
     [
-      :tran_date, :to_be_emailed, :memo
+      :tran_date, :to_be_emailed, :memo, :tran_id
     ].each do |field|
       expect(cashrefund).to have_field(field)
     end

data/spec/netsuite/records/journal_entry_spec.rb

@@ -141,15 +141,15 @@ describe NetSuite::Records::JournalEntry do
 
     it 'returns a hash of attributes that can be used in a SOAP request' do
       expect(entry.to_record).to eql({
-        'tranSales:tranId'   => '1234',
-        'tranSales:approved' => true
+        'tranGeneral:tranId'   => '1234',
+        'tranGeneral:approved' => true
       })
     end
   end
 
   describe '#record_type' do
     it 'returns a string type for the record to be used in a SOAP request' do
-      expect(entry.record_type).to eql('tranSales:JournalEntry')
+      expect(entry.record_type).to eql('tranGeneral:JournalEntry')
     end
   end
 

data/spec/netsuite/records/vendor_bill_item_spec.rb

@@ -7,7 +7,7 @@ describe NetSuite::Records::VendorBillItem do
     [
       :amortization_end_date, :amortization_residual, :amortiz_start_date, :bin_numbers,  :bill_variance_status,
       :description, :expiration_date, :gross_amt, :inventory_detail, :is_billable, :landed_cost, :line,
-      :order_doc, :order_line, :quantity, :serial_numbers, :tax_rate_1, :tax_rate_2, :tax_1_amt, :vendor_name
+      :order_doc, :order_line, :quantity, :serial_numbers, :tax_rate_1, :tax_rate_2, :tax_1_amt, :vendor_name, :rate
     ].each do |field|
       expect(item).to have_field(field)
     end

data/spec/support/fixtures/login/failure_concurrent_requests.xml

@@ -0,0 +1,15 @@
+<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <soapenv:Body>
+    <soapenv:Fault>
+      <faultcode>soapenv:Server.userException</faultcode>
+      <faultstring>Only one request may be made against a session at a time</faultstring>
+      <detail>
+        <platformFaults:exceededRequestLimitFault xmlns:platformFaults="urn:faults_2011_2.platform.webservices.netsuite.com">
+          <platformFaults:code>WS_CONCUR_SESSION_DISALLWD</platformFaults:code>
+          <platformFaults:message>Only one request may be made against a session at a time</platformFaults:message>
+        </platformFaults:exceededRequestLimitFault>
+        <ns1:hostname xmlns:ns1="http://xml.apache.org/axis/">partners-java10003.bos.netledger.com</ns1:hostname>
+      </detail>
+    </soapenv:Fault>
+  </soapenv:Body>
+</soapenv:Envelope>

data/spec/support/fixtures/login/failure_invalid_credentials.xml

@@ -0,0 +1,15 @@
+<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <soapenv:Body>
+    <soapenv:Fault>
+      <faultcode>soapenv:Server.userException</faultcode>
+      <faultstring>Only one request may be made against a session at a time</faultstring>
+      <detail>
+        <platformFaults:invalidCredentialsFault xmlns:platformFaults="urn:faults_2011_2.platform.webservices.netsuite.com">
+          <platformFaults:code>INVALID_LOGIN_CREDENTIALS</platformFaults:code>
+          <platformFaults:message>You have entered an invalid email address or account number. Please try again.</platformFaults:message>
+        </platformFaults:invalidCredentialsFault>
+        <ns1:hostname xmlns:ns1="http://xml.apache.org/axis/">partners-java10003.bos.netledger.com</ns1:hostname>
+      </detail>
+    </soapenv:Fault>
+  </soapenv:Body>
+</soapenv:Envelope>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netsuite
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors:
 - Ryan Moran
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-28 00:00:00.000000000 Z
+date: 2015-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -194,6 +194,7 @@ files:
 - lib/netsuite/records/promotion_code.rb
 - lib/netsuite/records/record_ref.rb
 - lib/netsuite/records/record_ref_list.rb
+- lib/netsuite/records/rev_rec_schedule.rb
 - lib/netsuite/records/rev_rec_template.rb
 - lib/netsuite/records/role_list.rb
 - lib/netsuite/records/roles.rb
@@ -369,7 +370,9 @@ files:
 - spec/support/fixtures/get/get_customer.xml
 - spec/support/fixtures/get/get_invoice.xml
 - spec/support/fixtures/initialize/initialize_invoice_from_customer.xml
-- spec/support/fixtures/login.xml
+- spec/support/fixtures/login/failure_concurrent_requests.xml
+- spec/support/fixtures/login/failure_invalid_credentials.xml
+- spec/support/fixtures/login/success.xml
 - spec/support/fixtures/search/saved_search_customer.xml
 - spec/support/fixtures/search/saved_search_joined_custom_customer.xml
 - spec/support/fixtures/update/update_customer.xml
@@ -540,7 +543,9 @@ test_files:
 - spec/support/fixtures/get/get_customer.xml
 - spec/support/fixtures/get/get_invoice.xml
 - spec/support/fixtures/initialize/initialize_invoice_from_customer.xml
-- spec/support/fixtures/login.xml
+- spec/support/fixtures/login/failure_concurrent_requests.xml
+- spec/support/fixtures/login/failure_invalid_credentials.xml
+- spec/support/fixtures/login/success.xml
 - spec/support/fixtures/search/saved_search_customer.xml
 - spec/support/fixtures/search/saved_search_joined_custom_customer.xml
 - spec/support/fixtures/update/update_customer.xml