netsuite 0.4.3 → 0.4.4

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZjcyMjQzYWViZjVhMTVhZjJjODQyMzYxYTAwNTYyMDhmMTBjMmJjZA==
+    YjY3MzQ4ZTcwOTU2YjM1YzE1YmFkMWVjMGI3YmE0NWMzNWFmYzE2Zg==
   data.tar.gz: !binary |-
-    MThjNDBjNzc1MzkwZDhkODhlNmRiMjM5NjlhZDg3ZWIxZDA2NjJlNA==
+    NzgzZTEyNjNhYTVmNjMwZjIyNDc2YmU2ZjhjZTRlNGVmYzk4NmI1Mw==
 SHA512:
   metadata.gz: !binary |-
-    MDUwZWUzYmMzNGMxNDJiMDQyODdjNGVjNzRiMTFkY2IxN2JiYTgwM2ZmNDQw
-    MzZiZjUwOGU3NGI5ZTM4MGJiMzg1ODYwOTU0MTQyOWZlY2M4YTQzOWM3ZmU1
-    YWViNDE1MjFlNmQ5OTIwYzFkNDhhMGJjZmY1ZDE1NGQwMTg4MTE=
+    Mzc1ZDMwMzFjMzhkNzQxMmIyZmYzNmY5ZGQzN2I5NWM2MmU0YTBmYTcwZTM4
+    Y2Q3OGExNTlmMDYyNTNmZWI0YThkMzk2YzZlNjk2ZDA1ODk4ZjNmNTFiZDlm
+    MmY5ODY5MGVhOTAzZDAxZTcxODczNzc1NmVhYmFiYWM3ZTFhYTk=
   data.tar.gz: !binary |-
-    MjQxNTlkMmVhODZhMjlkYTRiZTQxNzU5ZDE2NzhiZDk4ZjRlOTQ4OTM3NWU5
-    NWMzY2U3MTc1NTExYjZlZTVmZGI0ZjAwOGY1ZWMzMmU1YTQ4YWJhMGIyZDdh
-    OWU5NDc0MDU5MGQwMDVjN2ZiYTk5NjhiM2ZkNGJlNjY1Y2I5OTM=
+    ODUzZjFhMGVjMGY2MjhmYzdiMTU5NGZmYmRhYzhkOWEwZDhjMWU3NTVmZGJh
+    OTU1YjlhMTg4YzQ3ZGMyNWQzOTFmYWFjZDMwZjYzZDcxMWYyMGVjNzY1OTU5
+    NmEwNjk0NjgyOTg1ZDJlNDk1ZDc1ZGViYTM1YTc3OTEzZjFlZjc=

data/lib/netsuite.rb

@@ -194,7 +194,7 @@ module NetSuite
   def self.configure_from_env(&block)
     NetSuite.configure do
       reset!
-
+      
       email         ENV['NETSUITE_EMAIL']     unless ENV['NETSUITE_EMAIL'].nil?
       password      ENV['NETSUITE_PASSWORD']  unless ENV['NETSUITE_PASSWORD'].nil?
       account       ENV['NETSUITE_ACCOUNT']   unless ENV['NETSUITE_ACCOUNT'].nil?

data/lib/netsuite/actions/search.rb

@@ -223,14 +223,10 @@ module NetSuite
         @success ||= search_result[:status][:@is_success] == 'true'
       end
 
-      # TODO need to figure out a way for the user to access this
-      def errors
-        error_obj = response_hash[:status][:status_detail]
-        error_obj = [error_obj] if error_obj.class == Hash
-        error_obj.map do |error|
-          NetSuite::Error.new(error)
+      protected
+        def method_name
+
         end
-      end
 
       module Support
         def self.included(base)

data/lib/netsuite/records/custom_field_list.rb

@@ -10,13 +10,11 @@ module NetSuite
         when Array
           attributes[:custom_field].each { |custom_field| extract_custom_field(custom_field) }
         end
-        
+
         @custom_fields_assoc = Hash.new
         custom_fields.each do |custom_field|
-          reference_id = custom_field.script_id || custom_field.internal_id
-
           # not all custom fields have an id; https://github.com/NetSweet/netsuite/issues/182
-          if reference_id
+          if reference_id = custom_field.send(reference_id_type)
             @custom_fields_assoc[reference_id.to_sym] = custom_field
           end
         end
@@ -27,7 +25,7 @@ module NetSuite
       end
 
       def delete_custom_field(field)
-        custom_fields.delete_if { |c| c.internal_id.to_sym == field }
+        custom_fields.delete_if { |c| c.send(reference_id_type).to_sym == field }
         @custom_fields_assoc.delete(field)
       end
 
@@ -38,7 +36,7 @@ module NetSuite
       def custom_fields_by_type(type)
         custom_fields.select { |field| field.type == "platformCore:#{type}" }
       end
-      
+
       def method_missing(sym, *args, &block)
         # read custom field if already set
         if @custom_fields_assoc.include?(sym)
@@ -93,6 +91,10 @@ module NetSuite
       end
 
       private
+        def reference_id_type
+          @reference_id_type ||= Configuration.api_version >= '2013_2' ? :script_id : :internal_id
+        end
+
         def extract_custom_field(custom_field_data)
           # TODO this seems brittle, but might sufficient, watch out for this if something breaks
           if custom_field_data[:"@xsi:type"] == "platformCore:SelectCustomFieldRef"
@@ -102,7 +104,7 @@ module NetSuite
           custom_fields << CustomField.new(custom_field_data)
         end
 
-        def create_custom_field(internal_id, field_value)
+        def create_custom_field(reference_id, field_value)
           # all custom fields need types; infer type based on class sniffing
           field_type = case
           when field_value.is_a?(Array)
@@ -123,7 +125,7 @@ module NetSuite
           # TODO seems like DateTime doesn't need the iso8601 call
           #      not sure if this is specific to my env though
 
-          custom_field_value = case 
+          custom_field_value = case
           when field_value.is_a?(Hash)
             CustomRecordRef.new(field_value)
           when field_value.is_a?(Date)
@@ -146,13 +148,13 @@ module NetSuite
           end
 
           custom_field = CustomField.new(
-            internal_id: internal_id,
-            value: custom_field_value,
-            type: "#{record_namespace}:#{field_type}"
+            reference_id_type => reference_id,
+            :value => custom_field_value,
+            :type  => "#{record_namespace}:#{field_type}"
           )
 
           custom_fields << custom_field
-          @custom_fields_assoc[internal_id.to_sym] = custom_field
+          @custom_fields_assoc[reference_id.to_sym] = custom_field
         end
     end
   end

data/lib/netsuite/records/employee.rb

@@ -24,6 +24,10 @@ module NetSuite
       attr_reader :internal_id
       attr_accessor :external_id
 
+      def self.search_class_name
+        'Employee'
+      end
+
     end
   end
 end

data/lib/netsuite/records/invoice.rb

@@ -7,7 +7,7 @@ module NetSuite
       include Support::Actions
       include Namespaces::TranSales
 
-      actions :get, :get_list, :initialize, :add, :delete, :upsert, :search
+      actions :get, :get_list, :initialize, :add, :update, :delete, :upsert, :search
 
       fields :balance, :bill_address,
         :billing_schedule, :contrib_pct, :created_date, :currency_name, :custom_field_list,

data/lib/netsuite/records/location.rb

@@ -3,6 +3,7 @@ module NetSuite
     class Location
       include Support::Fields
       include Support::RecordRefs
+      include Support::Records
       include Support::Actions
       include Namespaces::ListAcct
 

data/lib/netsuite/support/search_result.rb

@@ -20,7 +20,7 @@ module NetSuite
       def initialize(response, result_class)
         @result_class = result_class
         @response = response
-
+        
         @total_records = response.body[:total_records].to_i
         @total_pages = response.body[:total_pages].to_i
         @current_page = response.body[:page_index].to_i
@@ -48,7 +48,7 @@ module NetSuite
                 next if search_group.to_s.start_with?('@')
 
                 record[search_group].each_pair do |k, v|
-                  # all return values of joined searchs are wrapped in a <SearchValue/>
+                  # all return values are wrapped in a <SearchValue/>
                   # extract the value from <SearchValue/> to make results easier to work with
 
                   if v.is_a?(Hash) && v.has_key?(:search_value)
@@ -63,7 +63,6 @@ module NetSuite
               end
 
               result_wrapper = result_class.new(record.delete(:basic))
-              # TODO if custom record search the type id should be copied over
               result_wrapper.search_joins = record
               results << result_wrapper
             end
@@ -98,4 +97,4 @@ module NetSuite
 
     end
   end
-end
+end

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module Netsuite
-  VERSION = '0.4.3'
+  VERSION = '0.4.4'
 end

data/spec/netsuite/records/custom_field_list_spec.rb

@@ -7,31 +7,77 @@ describe NetSuite::Records::CustomFieldList do
     expect(list.custom_fields).to be_kind_of(Array)
   end
 
-  context 'writing convience methods' do
-    it "should create a custom field entry when none exists" do
-      list.custrecord_somefield = 'a value'
-      expect(list.custom_fields.size).to eq(1)
-      expect(list.custom_fields.first.value).to eq('a value')
-      expect(list.custom_fields.first.type).to eq('platformCore:StringCustomFieldRef')
-    end
+  context 'custom field internalId-to-scriptId transition at WSDL 2013_2:' do
+    before(:context) { @reset = NetSuite::Configuration.api_version }
+    after(:context)  { NetSuite::Configuration.api_version = @reset }
 
-    it "should handle date custom field creation" do
-      list.custrecord_somefield = Date.parse("12/12/2012")
-      expect(list.custom_fields.first.value).to eq('2012-12-12T00:00:00+00:00')
-    end
+    transition_version = '2013_2'
 
-    it "should handle datetime custom field creation" do
-      list.custrecord_somefield = DateTime.parse("12/12/2012 10:05am")
-      expect(list.custom_fields.first.value).to eq('2012-12-12T10:05:00+00:00')
-    end
+    ['2012_2', '2013_2', '2014_2'].each do |version|
+
+      comparison = ['==', '>', '<'][version <=> transition_version]
+
+      context "when WSDL version #{comparison} #{transition_version}," do
+        before { NetSuite::Configuration.api_version = version }
+
+        context 'convenience methods' do
+          reference_id_type = version < transition_version ? :internal_id : :script_id
+
+          it "should create a custom field entry when none exists" do
+            list.some_custom_field = 'a value'
+
+            expect(list.custom_fields.size).to eq(1)
+            expect(list.custom_fields.first.value).to eq('a value')
+            expect(list.custom_fields.first.type).to eq('platformCore:StringCustomFieldRef')
+          end
+
+          it "should set #{reference_id_type} to method name when creating a custom field" do
+            list.some_custom_field = 'a value'
+
+            expect(list.some_custom_field.send(reference_id_type)).to eq('some_custom_field')
+          end
+
+          it "should update a custom field's value when one exists" do
+            list.existing_custom_field = 'old value'
+            list.existing_custom_field = 'new value'
+
+            expect(list.existing_custom_field.value).to eq('new value')
+          end
+
+          it "should handle date custom field creation" do
+            list.some_custom_field = Date.parse("12/12/2012")
+
+            expect(list.custom_fields.first.value).to eq('2012-12-12T00:00:00+00:00')
+          end
+
+          it "should handle datetime custom field creation" do
+            list.some_custom_field = DateTime.parse("12/12/2012 10:05am")
+
+            expect(list.custom_fields.first.value).to eq('2012-12-12T10:05:00+00:00')
+          end
+
+          it "should convert a list of numbers into a list of custom field refs" do
+            list.some_custom_field = [1,2]
+
+            expect(list.custom_fields.first.type).to eq('platformCore:MultiSelectCustomFieldRef')
+            expect(list.custom_fields.first.value.map(&:to_record)).to eql([
+              NetSuite::Records::CustomRecordRef.new(:internal_id => 1),
+              NetSuite::Records::CustomRecordRef.new(:internal_id => 2)
+            ].map(&:to_record))
+          end
+
+          it "should return custom field record when entry exists" do
+            list.existing_custom_field = 'a value'
+
+            expect(list.existing_custom_field).to be_a(NetSuite::Records::CustomField)
+            expect(list.existing_custom_field.value).to eq('a value')
+          end
 
-    it "should convert a list of numbers into a list of custom field refs" do
-      list.custrecord_somefield = [1,2]
-      expect(list.custom_fields.first.type).to eq('platformCore:MultiSelectCustomFieldRef')
-      expect(list.custom_fields.first.value.map(&:to_record)).to eql([
-        NetSuite::Records::CustomRecordRef.new(:internal_id => 1),
-        NetSuite::Records::CustomRecordRef.new(:internal_id => 2)
-      ].map(&:to_record))
+          it "should raise an error if custom field entry does not exist" do
+            expect{ list.nonexisting_custom_field }.to raise_error
+          end
+        end
+      end
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netsuite
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - Ryan Moran
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-08-12 00:00:00.000000000 Z
+date: 2015-08-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon