netsuite 0.4.2 → 0.4.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NzlhZWFlM2M2MWNjZTg0OWYxYzc1NjIyYmE5ZDcxZjk1ZTBlOTQ3Zg==
+    ZjcyMjQzYWViZjVhMTVhZjJjODQyMzYxYTAwNTYyMDhmMTBjMmJjZA==
   data.tar.gz: !binary |-
-    MGNiMWI4YTkzNjMzNWUzMzMyM2M4YjU0OTExOTg0YjhjN2MyMmRlNQ==
+    MThjNDBjNzc1MzkwZDhkODhlNmRiMjM5NjlhZDg3ZWIxZDA2NjJlNA==
 SHA512:
   metadata.gz: !binary |-
-    NzlmODk4MmI0YjMyNWQxNDA2ZTAxZWNkZjdiMzk5Yzg5Nzc2ZmZkM2UyOGMz
-    OGJjYzBhYmUxZTFiZTUyYzFiZGY3ZTk2NzYxMjVkZDIxZWM5ZGZkZWU1MzE3
-    ZmQ3OTUzYTJlM2JiNTQ4MDFiZjM1YzRhMGViOGRhZTQ0NTJjMDQ=
+    MDUwZWUzYmMzNGMxNDJiMDQyODdjNGVjNzRiMTFkY2IxN2JiYTgwM2ZmNDQw
+    MzZiZjUwOGU3NGI5ZTM4MGJiMzg1ODYwOTU0MTQyOWZlY2M4YTQzOWM3ZmU1
+    YWViNDE1MjFlNmQ5OTIwYzFkNDhhMGJjZmY1ZDE1NGQwMTg4MTE=
   data.tar.gz: !binary |-
-    MWY4YzFlZDc3ODBlYTdhYjU0ODAwZWI2OTI4ZjU5NjQxMGFjYzYyZGNjZDcz
-    ZDU0N2M1Y2VkNTEzNzM2MWI1YzY2ODNjYWVmZTg2MWY1MmM1YTExN2E1MWJj
-    ZmFiMTBkM2QzZWU2NTFlZjE0NTRjMTJhYzVjM2Q1N2EzOTEwODU=
+    MjQxNTlkMmVhODZhMjlkYTRiZTQxNzU5ZDE2NzhiZDk4ZjRlOTQ4OTM3NWU5
+    NWMzY2U3MTc1NTExYjZlZTVmZGI0ZjAwOGY1ZWMzMmU1YTQ4YWJhMGIyZDdh
+    OWU5NDc0MDU5MGQwMDVjN2ZiYTk5NjhiM2ZkNGJlNjY1Y2I5OTM=

data/README.md

@@ -48,6 +48,9 @@ NetSuite.configure do
   # optionally specify full wsdl URL (to switch to sandbox, for example)
   wsdl          "https://webservices.sandbox.netsuite.com/wsdl/v#{api_version}_0/netsuite.wsdl"
 
+  # if your datacenter is being switched, you'll have to manually set your wsdl location
+  wsdl "https://webservices.na2.netsuite.com/wsdl/v#{api_version}_0/netsuite.wsdl"
+
   # or specify the sandbox flag if you don't want to deal with specifying a full URL
   sandbox	true
 
@@ -100,6 +103,8 @@ task.add
 
 task.update :message => 'New Message'
 
+task.delete
+
 # using get_select_value with a custom record
 NetSuite::Records::BaseRefList.get_select_value(
   field: 'custrecord_something',

data/lib/netsuite.rb

@@ -108,6 +108,7 @@ module NetSuite
     autoload :Contact,                          'netsuite/records/contact'
     autoload :ContactAccessRoles,               'netsuite/records/contact_access_roles'
     autoload :ContactAccessRolesList,           'netsuite/records/contact_access_roles_list'
+    autoload :Currency,                         'netsuite/records/currency'
     autoload :Department,                       'netsuite/records/department'
     autoload :Deposit,                          'netsuite/records/deposit'
     autoload :DepositPayment,                   'netsuite/records/deposit_payment'
@@ -151,6 +152,7 @@ module NetSuite
     autoload :PhoneCall,                        'netsuite/records/phone_call'
     autoload :PricingMatrix,                    'netsuite/records/pricing_matrix'
     autoload :PromotionCode,                    'netsuite/records/promotion_code'
+    autoload :Roles,                            'netsuite/records/roles'
     autoload :RecordRef,                        'netsuite/records/record_ref'
     autoload :RecordRefList,                    'netsuite/records/record_ref_list'
     autoload :RevRecTemplate,                   'netsuite/records/rev_rec_template'
@@ -192,7 +194,7 @@ module NetSuite
   def self.configure_from_env(&block)
     NetSuite.configure do
       reset!
-      
+
       email         ENV['NETSUITE_EMAIL']     unless ENV['NETSUITE_EMAIL'].nil?
       password      ENV['NETSUITE_PASSWORD']  unless ENV['NETSUITE_PASSWORD'].nil?
       account       ENV['NETSUITE_ACCOUNT']   unless ENV['NETSUITE_ACCOUNT'].nil?

data/lib/netsuite/actions/search.rb

@@ -223,10 +223,14 @@ module NetSuite
         @success ||= search_result[:status][:@is_success] == 'true'
       end
 
-      protected
-        def method_name
-
+      # TODO need to figure out a way for the user to access this
+      def errors
+        error_obj = response_hash[:status][:status_detail]
+        error_obj = [error_obj] if error_obj.class == Hash
+        error_obj.map do |error|
+          NetSuite::Error.new(error)
         end
+      end
 
       module Support
         def self.included(base)

data/lib/netsuite/configuration.rb

@@ -47,6 +47,10 @@ module NetSuite
       end
     end
 
+    def sandbox?
+      !!sandbox
+    end
+
     def wsdl=(wsdl)
       attributes[:wsdl] = wsdl
     end
@@ -59,13 +63,29 @@ module NetSuite
           wsdl_path = "https://webservices.sandbox.netsuite.com/wsdl/v#{api_version}_0/netsuite.wsdl"
         else
           wsdl_path = File.expand_path("../../../wsdl/#{api_version}.wsdl", __FILE__)
-          wsdl_path = "https://webservices.netsuite.com/wsdl/v#{api_version}_0/netsuite.wsdl" unless File.exists? wsdl_path
+
+          unless File.exists? wsdl_path
+            wsdl_path = "https://#{wsdl_domain}/wsdl/v#{api_version}_0/netsuite.wsdl"
+          end
         end
 
         attributes[:wsdl] ||= wsdl_path
       end
     end
 
+    def wsdl_domain(wsdl_domain = nil)
+      if wsdl_domain
+        self.wsdl_domain = wsdl_domain
+      else
+        # if sandbox, this parameter is ignored
+        attributes[:wsdl_domain] ||= 'webservices.netsuite.com'
+      end
+    end
+
+    def wsdl_domain=(wsdl_domain)
+      attributes[:wsdl_domain] = wsdl_domain
+    end
+
     def soap_header=(headers)
       attributes[:soap_header] = headers
     end

data/lib/netsuite/records/cash_sale.rb

@@ -12,7 +12,7 @@ module NetSuite
       fields :alt_handling_cost, :alt_shipping_cost, :auth_code, :bill_address, :cc_approved, :cc_expire_date, :cc_is_purchase_card_bin,
         :cc_name, :cc_number, :cc_process_as_purchas_card, :cc_security_code, :cc_street, :cc_zip_code, :charge_it, :contrib_pct, :created_date,
         :currency_name, :debit_card_issue_no, :deferred_revenue, :discount_rate, :discount_total, :email, :end_date, :est_gross_profit,
-        :est_gross_profit_percent, :exchange_rate, :exclude_commission, :exp_cost_disc_amount, :exp_cost_discount, :exp_cost_discprint,
+        :est_gross_profit_percent, :exchange_rate, :exclude_commission, :exp_cost_disc_amount, :exp_cost_discprint,
         :exp_cost_disc_rate, :exp_cost_disc_tax1_amt, :exp_cost_disc_taxable, :exp_cost_tax_rate1, :exp_cost_tax_rate2, :fax, :fob,
         :gift_cert_applied, :handling_cost, :handling_tax1_rate, :handling_tax2_rate, :ignore_avs, :is_recurring_payment, :is_taxable,
         :item_cost_disc_amount, :item_cost_disc_print, :item_cost_disc_rate, :item_cost_disc_tax1_amt, :item_cost_disc_taxable, :item_cost_tax_rate1,
@@ -20,7 +20,7 @@ module NetSuite
         :pay_pal_status, :pay_pay_tran_id, :pn_ref_num, :recognized_revenue, :rev_rec_end_date, :rev_rec_on_rev_commitment, :rev_rec_state_date,
         :sales_effective_date, :ship_address, :ship_date, :shipping_cost, :shipping_tax1_rate, :shipping_tax2_rate, :source, :start_date, :status,
         :sub_total, :sync_partners_teams, :sync_sales_teams, :tax2_total, :tax_rate, :tax_total, :three_d_status_code, :time_disc_amount, :time_disc_print,
-        :time_disc_rate, :time_disc_tax1_amt, :time_disc_taxable, :time_tax_rate1, :time_tax_rate2, :to_be_emailed, :to_be_faxed, :total,
+        :time_disc_rate, :time_disc_tax1_amt, :time_disc_taxable, :time_tax_rate1, :time_tax_rate2, :to_be_emailed, :to_be_printed, :to_be_faxed, :total,
         :total_cost_estimate, :tracking_numbers, :tran_date, :tran_id, :tan_is_vsoe_bundle, :undep_funds, :valid_from, :vat_reg_num, :vsoe_auto_calc
 
 

data/lib/netsuite/records/classification.rb

@@ -6,7 +6,9 @@ module NetSuite
 
       actions :get, :get_list, :delete, :upsert
 
-      fields :name, :include_children, :is_inactive, :class_translation_list, :subsidiary_list, :custom_field_list
+      fields :name, :include_children, :is_inactive, :class_translation_list, :custom_field_list
+
+      field :subsidiary_list, RecordRefList
 
       attr_reader   :internal_id
       attr_accessor :external_id

data/lib/netsuite/records/credit_memo_apply_list.rb

@@ -1,24 +1,16 @@
 module NetSuite
   module Records
-    class CreditMemoApplyList
+    class CreditMemoApplyList < Support::Sublist
       include Namespaces::TranCust
 
-      def initialize(attributes = {})
-        case attributes[:apply]
-        when Hash
-          applies << CreditMemoApply.new(attributes[:apply])
-        when Array
-          attributes[:apply].each { |apply| applies << CreditMemoApply.new(apply) }
-        end
-      end
+      sublist :apply, CreditMemoApply
 
+      # for backward compatibility
       def applies
-        @applies ||= []
+        self.apply
       end
 
-      def to_record
-        { "#{record_namespace}:apply" => applies.map(&:to_record) }
-      end
     end
   end
 end
+\

data/lib/netsuite/records/currency.rb

@@ -0,0 +1,30 @@
+module NetSuite
+  module Records
+    class Currency
+      include Support::Records
+      include Support::Fields
+
+      include Support::Actions
+      include Support::RecordRefs
+      include Namespaces::ListAcct
+
+      # https://system.netsuite.com/help/helpcenter/en_US/srbrowser/Browser2014_1/schema/record/currency.html
+
+      actions :get, :get_list, :get_all, :add, :update, :upsert, :upsert_list, :delete
+
+      fields :name, :symbol, :is_base_currency, :is_inactive, :override_currency_format, :display_symbol, :symbol_placement,
+             :locale, :formatSample, :exchangeRate, :fx_rate_update_timezone, :incl_in_fx_rate_updates, :currency_precision
+
+      attr_reader :internal_id
+      attr_accessor :external_id
+
+      def initialize(attributes = {})
+        @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
+        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
+
+        initialize_from_attributes_hash(attributes)
+      end
+
+    end
+  end
+end

data/lib/netsuite/records/custom_record.rb

@@ -22,6 +22,7 @@ module NetSuite
 
       attr_reader :internal_id
       attr_accessor :external_id
+      attr_accessor :search_joins
 
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)

data/lib/netsuite/records/discount_item.rb

@@ -14,9 +14,10 @@ module NetSuite
 
       record_refs :account, :custom_form, :deferred_revenue_account, :department, :expense_account,
         :income_account, :issue_product, :klass, :location, :parent, :rev_rec_schedule, :sales_tax_code,
-        :subsidiary_list, :tax_schedule
+        :tax_schedule
 
       field :custom_field_list, CustomFieldList
+      field :subsidiary_list, RecordRefList
 
       attr_reader   :internal_id
       attr_accessor :external_id

data/lib/netsuite/records/employee.rb

@@ -1,7 +1,6 @@
 module NetSuite
   module Records
     class Employee < Support::Base
-      include Support::RecordRefs
       include Support::Actions
       include Support::RecordRefs
       include Namespaces::ListEmp

data/lib/netsuite/records/invoice.rb

@@ -24,7 +24,7 @@ module NetSuite
         :rev_rec_on_rev_commitment, :rev_rec_schedule, :rev_rec_start_date, :revenue_status, :sales_effective_date,
         :sales_group, :sales_team_list, :ship_address, :ship_date, :ship_group_list,
         :shipping_cost, :shipping_tax_1_rate, :shipping_tax_2_rate, :shipping_tax_code, :source, :start_date,
-        :status, :subsidiary, :sync_partner_teams, :sync_sales_teams, :tax_2_total,
+        :status, :sync_partner_teams, :sync_sales_teams, :tax_2_total,
         :tax_total, :time_disc_amount, :time_disc_print, :time_disc_rate, :time_disc_tax_1_amt, :time_disc_taxable,
         :time_discount, :time_list, :time_tax_code, :time_tax_rate_1, :time_tax_rate_2, :to_be_emailed, :to_be_faxed,
         :to_be_printed, :total_cost_estimate, :tracking_numbers, :tran_date, :tran_id, :tran_is_vsoe_bundle,
@@ -40,7 +40,7 @@ module NetSuite
 
       record_refs :account, :bill_address_list, :custom_form, :department, :entity, :klass, :partner,
                   :posting_period, :ship_address_list, :terms, :location, :sales_rep, :tax_item, :created_from,
-                  :ship_method, :lead_source, :promo_code
+                  :ship_method, :lead_source, :promo_code, :subsidiary
 
       attr_reader   :internal_id
       attr_accessor :external_id

data/lib/netsuite/records/non_inventory_sale_item.rb

@@ -28,12 +28,13 @@ module NetSuite
       record_refs :billing_schedule, :cost_category, :custom_form, :deferred_revenue_account, :department, :income_account,
         :issue_product, :item_options_list, :klass, :location, :parent, :pricing_group, :purchase_tax_code,
         :quantity_pricing_schedule, :rev_rec_schedule, :sale_unit, :sales_tax_code, :ship_package, :store_display_image,
-        :store_display_thumbnail, :store_item_template, :subsidiary_list, :tax_schedule, :units_type
+        :store_display_thumbnail, :store_item_template, :tax_schedule, :units_type
 
-      field :pricing_matrix, PricingMatrix
       field :custom_field_list, CustomFieldList
       field :pricing_matrix, PricingMatrix
-      
+      field :subsidiary_list, RecordRefList
+
+
       attr_reader   :internal_id
       attr_accessor :external_id
 

data/lib/netsuite/records/role_list.rb

@@ -1,9 +1,9 @@
 module NetSuite
   module Records
     class RoleList < Support::Sublist
-      include Namespaces::PlatformCommon
+      include Namespaces::ListEmp
 
-      sublist :roles, RecordRef
+      sublist :roles, Roles
 
       # role list is undocumented and has pretty funky XML:
 
@@ -19,7 +19,6 @@ module NetSuite
       #     </listEmp:selectedRole>
       #   </listEmp:roles>
       # </listEmp:rolesList>
-
     end
   end
 end

data/lib/netsuite/records/roles.rb

@@ -0,0 +1,10 @@
+module NetSuite
+  module Records
+    class Roles < NetSuite::Support::Base
+      include Support::RecordRefs
+      include Namespaces::ListEmp
+
+      record_refs :selected_role
+    end
+  end
+end

data/lib/netsuite/records/service_sale_item.rb

@@ -26,10 +26,11 @@ module NetSuite
       record_refs :billing_schedule, :cost_category, :custom_form, :deferred_revenue_account, :department, :income_account,
         :issue_product, :item_options_list, :klass, :location, :parent, :pricing_group, :purchase_tax_code,
         :quantity_pricing_schedule, :rev_rec_schedule, :sale_unit, :sales_tax_code, :store_display_image,
-        :store_display_thumbnail, :store_item_template, :subsidiary_list, :tax_schedule, :units_type
+        :store_display_thumbnail, :store_item_template, :tax_schedule, :units_type
 
       field :pricing_matrix, PricingMatrix
       field :custom_field_list, CustomFieldList
+      field :subsidiary_list, RecordRefList
 
       attr_reader   :internal_id
       attr_accessor :external_id

data/lib/netsuite/support/country.rb

@@ -69,7 +69,7 @@ module NetSuite
         'EC' => '_ecuador',
         'EG' => '_egypt',
         'SV' => '_elSalvador',
-        'GU' => '_equatorialGuinea',
+        'GQ' => '_equatorialGuinea',
         'ER' => '_eritrea',
         'EE' => '_estonia',
         'ET' => '_ethiopia',

data/lib/netsuite/support/search_result.rb

@@ -20,7 +20,7 @@ module NetSuite
       def initialize(response, result_class)
         @result_class = result_class
         @response = response
-        
+
         @total_records = response.body[:total_records].to_i
         @total_pages = response.body[:total_pages].to_i
         @current_page = response.body[:page_index].to_i
@@ -48,7 +48,7 @@ module NetSuite
                 next if search_group.to_s.start_with?('@')
 
                 record[search_group].each_pair do |k, v|
-                  # all return values are wrapped in a <SearchValue/>
+                  # all return values of joined searchs are wrapped in a <SearchValue/>
                   # extract the value from <SearchValue/> to make results easier to work with
 
                   if v.is_a?(Hash) && v.has_key?(:search_value)
@@ -63,6 +63,7 @@ module NetSuite
               end
 
               result_wrapper = result_class.new(record.delete(:basic))
+              # TODO if custom record search the type id should be copied over
               result_wrapper.search_joins = record
               results << result_wrapper
             end
@@ -97,4 +98,4 @@ module NetSuite
 
     end
   end
-end
+end

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module Netsuite
-  VERSION = '0.4.2'
+  VERSION = '0.4.3'
 end

data/spec/netsuite/configuration_spec.rb

@@ -51,6 +51,16 @@ describe NetSuite::Configuration do
         expect(config.wsdl).to eql('https://webservices.netsuite.com/wsdl/v2013_1_0/netsuite.wsdl')
       end
     end
+
+    context 'when the API and wsdl domain have been set' do
+      it 'should correctly modify the full wsdl path' do
+        config.sandbox = false
+        config.api_version '2014_1'
+        config.wsdl_domain = 'system.na1.netsuite.com'
+
+        expect(config.wsdl).to eql('https://system.na1.netsuite.com/wsdl/v2014_1_0/netsuite.wsdl')
+      end
+    end
   end
 
   describe '#auth_header' do
@@ -192,13 +202,13 @@ describe NetSuite::Configuration do
   describe "#credentials" do
     context "when none are defined" do
       skip "should properly create the auth credentials" do
-        
+
       end
     end
 
     context "when they are defined" do
       it "should properly replace the default auth credentials" do
-        
+
       end
     end
   end

data/spec/netsuite/records/cash_sale_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+describe NetSuite::Records::CashSale do
+  it 'has all the right fields' do
+    [
+      :alt_handling_cost, :alt_shipping_cost, :auth_code, :bill_address, :cc_approved, :cc_expire_date, :cc_is_purchase_card_bin,
+      :cc_name, :cc_number, :cc_process_as_purchas_card, :cc_security_code, :cc_street, :cc_zip_code, :charge_it, :contrib_pct, :created_date,
+      :currency_name, :debit_card_issue_no, :deferred_revenue, :discount_rate, :discount_total, :email, :end_date, :est_gross_profit,
+      :est_gross_profit_percent, :exchange_rate, :exclude_commission, :exp_cost_disc_amount, :exp_cost_discprint,
+      :exp_cost_disc_rate, :exp_cost_disc_tax1_amt, :exp_cost_disc_taxable, :exp_cost_tax_rate1, :exp_cost_tax_rate2, :fax, :fob,
+      :gift_cert_applied, :handling_cost, :handling_tax1_rate, :handling_tax2_rate, :ignore_avs, :is_recurring_payment, :is_taxable,
+      :item_cost_disc_amount, :item_cost_disc_print, :item_cost_disc_rate, :item_cost_disc_tax1_amt, :item_cost_disc_taxable, :item_cost_tax_rate1,
+      :item_cost_tax_rate2, :last_modified_date, :linked_tracking_numbers, :memo, :message, :other_ref_num, :paypal_auth_id, :paypal_process,
+      :pay_pal_status, :pay_pay_tran_id, :pn_ref_num, :recognized_revenue, :rev_rec_end_date, :rev_rec_on_rev_commitment, :rev_rec_state_date,
+      :sales_effective_date, :ship_address, :ship_date, :shipping_cost, :shipping_tax1_rate, :shipping_tax2_rate, :source, :start_date, :status,
+      :sub_total, :sync_partners_teams, :sync_sales_teams, :tax2_total, :tax_rate, :tax_total, :three_d_status_code, :time_disc_amount, :time_disc_print,
+      :time_disc_rate, :time_disc_tax1_amt, :time_disc_taxable, :time_tax_rate1, :time_tax_rate2, :to_be_emailed, :to_be_printed, :to_be_faxed, :total,
+      :total_cost_estimate, :tracking_numbers, :tran_date, :tran_id, :tan_is_vsoe_bundle, :undep_funds, :valid_from, :vat_reg_num, :vsoe_auto_calc
+    ].each do |field|
+      expect(subject).to have_field(field)
+    end
+  end
+
+  it 'has all the right record refs' do
+    [
+      :account, :bill_address_list, :billing_schedule, :created_from, :credit_card, :credit_card_processor, :currency, :custom_form,
+      :department, :discount_item, :entity, :exp_cost_discount, :exp_cost_tax_code, :handling_tax_code, :item_cost_discount, :item_cost_tax_code,
+      :job, :klass, :lead_source, :location, :message_sel, :opportunity, :partner, :payment_method, :posting_period, :promo_code, :rev_rec_schedule,
+      :sales_group, :sales_rep, :ship_address_list, :ship_method, :shipping_tax_code, :subsidiary, :tax_item, :time_discount, :time_tax_code
+    ].each do |record_ref|
+      expect(subject).to have_record_ref(record_ref)
+    end
+  end
+end

data/spec/netsuite/records/classification_spec.rb

@@ -5,10 +5,12 @@ describe NetSuite::Records::Classification do
 
   it 'has all the right fields' do
     [
-      :name, :include_children, :is_inactive, :class_translation_list, :subsidiary_list, :custom_field_list
+      :name, :include_children, :is_inactive, :class_translation_list, :custom_field_list
     ].each do |field|
       expect(classification).to have_field(field)
     end
+
+    expect(classification.subsidiary_list.class).to eq(NetSuite::Records::RecordRefList)
   end
 
   describe '.get' do

data/spec/netsuite/records/credit_memo_apply_list_spec.rb

@@ -21,7 +21,7 @@ describe NetSuite::Records::CreditMemoApplyList do
         }]
       }
 
-      expect(list.to_record.should).to eq(record)
+      expect(list.to_record).to eq(record)
     end
   end
 end

data/spec/netsuite/records/credit_memo_item_list_spec.rb

@@ -20,7 +20,7 @@ describe NetSuite::Records::CreditMemoItemList do
           'tranCust:rate' => 10
         }]
       }
-      list.to_record.should eql(record)
+      expect(list.to_record).to eql(record)
     end
   end
 end

data/spec/netsuite/records/currency_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe NetSuite::Records::Account do
+  let(:currency) { NetSuite::Records::Currency.new }
+
+  it 'can be initialized and has fields' do
+    expect(currency.class.fields.size).to be > 0
+
+    currency.class.fields.each { |f| expect(currency).to have_field(f) }
+  end
+end

data/spec/netsuite/records/customer_addressbook_list_spec.rb

@@ -19,18 +19,18 @@ describe NetSuite::Records::CustomerAddressbookList do
 
   describe "#replace_all" do
     it "returns true by default" do
-      list.replace_all.should eql(true)
+      expect(list.replace_all).to eql(true)
     end
 
     it "can be changed via accessor" do
       list.replace_all = false
 
-      list.replace_all.should eql(false)
+      expect(list.replace_all).to eql(false)
     end
 
     it "coerces to a boolean" do
       list.replace_all = "goober"
-      list.replace_all.should eql(true)
+      expect(list.replace_all).to eql(true)
     end
   end
 

data/spec/netsuite/records/customer_addressbook_spec.rb

@@ -99,30 +99,30 @@ describe NetSuite::Records::CustomerAddressbook do
     context "when it's specified as a 2 character ISO code" do
       it "is converted to the appropriate NetSuite enum value" do
         addressbook = NetSuite::Records::CustomerAddressbook.new country: "US"
-        addressbook.to_record["listRel:country"].should eql "_unitedStates"
+        expect(addressbook.to_record["listRel:country"]).to eql "_unitedStates"
       end
     end
 
     context "when the country code is a YAML reserved word (NO)" do
       it "is converted to the appropriate NetSuite enum value" do
         addressbook = NetSuite::Records::CustomerAddressbook.new country: "NO"
-        addressbook.to_record["listRel:country"].should eql "_norway"
+        expect(addressbook.to_record["listRel:country"]).to eql "_norway"
       end
     end
 
     it "can be specified as the NetSuite enum value" do
       addressbook = NetSuite::Records::CustomerAddressbook.new country: "_unitedStates"
-      addressbook.to_record["listRel:country"].should eql "_unitedStates"
+      expect(addressbook.to_record["listRel:country"]).to eql "_unitedStates"
 
       # country with two uppercase letters (looks like ISO2)
       addressbook = NetSuite::Records::CustomerAddressbook.new country: "_unitedKingdomGB"
-      addressbook.to_record["listRel:country"].should eql "_unitedKingdomGB"
+      expect(addressbook.to_record["listRel:country"]).to eql "_unitedKingdomGB"
     end
 
     it "can be unspecified" do
       addressbook = NetSuite::Records::CustomerAddressbook.new country: ''
-      addressbook.country.to_record.should eql ""
-      addressbook.to_record["listRel:country"].should eql ""
+      expect(addressbook.country.to_record).to eql ""
+      expect(addressbook.to_record["listRel:country"]).to eql ""
     end
   end
 

data/spec/netsuite/records/customer_refund_apply_list_spec.rb

@@ -18,7 +18,7 @@ describe NetSuite::Records::CustomerRefundApplyList do
           'tranCust:amount' => 10
         }]
       }
-      list.to_record.should eql(record)
+      expect(list.to_record).to eql(record)
     end
   end
 

data/spec/netsuite/records/discount_item_spec.rb

@@ -13,13 +13,14 @@ describe NetSuite::Records::DiscountItem do
 
     # TODO there is a probably a more robust way to test this
     expect(item.custom_field_list.class).to eq(NetSuite::Records::CustomFieldList)
+    expect(item.subsidiary_list.class).to eq(NetSuite::Records::RecordRefList)
   end
 
   it 'has the right record_refs' do
     [
       :account, :custom_form, :deferred_revenue_account, :department, :expense_account,
       :income_account, :issue_product, :klass, :location, :parent, :rev_rec_schedule, :sales_tax_code,
-      :subsidiary_list, :tax_schedule
+      :tax_schedule
     ].each do |record_ref|
       expect(item).to have_record_ref(record_ref)
     end

data/spec/netsuite/records/inventory_assignment_list_spec.rb

@@ -4,7 +4,7 @@ describe NetSuite::Records::InventoryAssignmentList do
   let(:list) { NetSuite::Records::InventoryAssignmentList.new }
 
   it 'has an assignments attribute' do
-    list.inventory_assignment.should be_kind_of(Array)
+    expect(list.inventory_assignment).to be_kind_of(Array)
   end
 
   describe '#to_record' do
@@ -17,24 +17,24 @@ describe NetSuite::Records::InventoryAssignmentList do
     it 'can represent itself as a SOAP record' do
 
       record = {
-        'tranInvt:inventoryAssignment' => [{
+        'platformCommon:inventoryAssignment' => [{
           'platformCommon:quantity' => 1
         }]
       }
-      list.to_record.should eql(record)
+      expect(list.to_record).to eql(record)
     end
 
     it 'can represent replacing all' do
       list.replace_all = true
 
       record = {
-        'tranInvt:inventoryAssignment' => [{
+        'platformCommon:inventoryAssignment' => [{
           'platformCommon:quantity' => 1
         }],
         :@replaceAll => true,
       }
 
-      list.to_record.should eql(record)
+      expect(list.to_record).to eql(record)
     end
 
     it 'accepts a false replacing all' do
@@ -47,13 +47,13 @@ describe NetSuite::Records::InventoryAssignmentList do
       list.replace_all = false
 
       record = {
-        'tranInvt:inventoryAssignment' => [{
+        'platformCommon:inventoryAssignment' => [{
           'platformCommon:quantity' => 1
         }],
         :@replaceAll => false,
       }
 
-      list.to_record.should eql(record)
+      expect(list.to_record).to eql(record)
     end
   end
 end

data/spec/netsuite/records/inventory_assignment_spec.rb

@@ -7,7 +7,7 @@ describe NetSuite::Records::InventoryAssignment do
     [
       :expiration_date, :quantity, :quantity_available, :receipt_inventory_number
     ].each do |field|
-      item.should have_field(field)
+      expect(item).to have_field(field)
     end
   end
 
@@ -15,7 +15,7 @@ describe NetSuite::Records::InventoryAssignment do
     [
       :bin_number, :issue_inventory_number, :to_bin_number
     ].each do |record_ref|
-      item.should have_record_ref(record_ref)
+      expect(item).to have_record_ref(record_ref)
     end
   end
 end

data/spec/netsuite/records/inventory_detail_spec.rb

@@ -7,7 +7,7 @@ describe NetSuite::Records::InventoryDetail do
     [
       :custom_form
     ].each do |record_ref|
-      item.should have_record_ref(record_ref)
+      expect(item).to have_record_ref(record_ref)
     end
   end
 end

data/spec/netsuite/records/invoice_spec.rb

@@ -22,7 +22,7 @@ describe NetSuite::Records::Invoice do
       :rev_rec_on_rev_commitment, :rev_rec_schedule, :rev_rec_start_date, :revenue_status, :sales_effective_date,
       :sales_group, :sales_team_list, :ship_address, :ship_date, :ship_group_list,
       :shipping_cost, :shipping_tax_1_rate, :shipping_tax_2_rate, :shipping_tax_code, :source, :start_date,
-      :status, :subsidiary, :sync_partner_teams, :sync_sales_teams, :tax_2_total,
+      :status, :sync_partner_teams, :sync_sales_teams, :tax_2_total,
       :tax_total, :time_disc_amount, :time_disc_print, :time_disc_rate, :time_disc_tax_1_amt, :time_disc_taxable,
       :time_discount, :time_list, :time_tax_code, :time_tax_rate_1, :time_tax_rate_2, :to_be_emailed, :to_be_faxed,
       :to_be_printed, :total_cost_estimate, :tracking_numbers, :tran_date, :tran_id, :tran_is_vsoe_bundle,
@@ -44,7 +44,7 @@ describe NetSuite::Records::Invoice do
   it 'has the right record_refs' do
     [
       :account, :bill_address_list, :custom_form, :department, :entity, :klass, :posting_period, :ship_address_list, :terms,
-      :created_from, :location, :sales_rep, :ship_method, :tax_item, :partner, :lead_source, :promo_code
+      :created_from, :location, :sales_rep, :ship_method, :tax_item, :partner, :lead_source, :promo_code, :subsidiary
     ].each do |record_ref|
       expect(invoice).to have_record_ref(record_ref)
     end

data/spec/netsuite/records/non_inventory_sale_item_spec.rb

@@ -26,6 +26,7 @@ describe NetSuite::Records::NonInventorySaleItem do
     # TODO there is a probably a more robust way to test this
     expect(item.custom_field_list.class).to eq(NetSuite::Records::CustomFieldList)
     expect(item.pricing_matrix.class).to eq(NetSuite::Records::PricingMatrix)
+    expect(item.subsidiary_list.class).to eq(NetSuite::Records::RecordRefList)
   end
 
   it 'has the right record_refs' do
@@ -33,7 +34,7 @@ describe NetSuite::Records::NonInventorySaleItem do
       :billing_schedule, :cost_category, :custom_form, :deferred_revenue_account, :department, :income_account, :issue_product,
       :item_options_list, :klass, :location, :parent, :pricing_group, :purchase_tax_code, :quantity_pricing_schedule,
       :rev_rec_schedule, :sale_unit, :sales_tax_code, :ship_package, :store_display_image, :store_display_thumbnail,
-      :store_item_template, :subsidiary_list, :tax_schedule, :units_type
+      :store_item_template, :tax_schedule, :units_type
     ].each do |record_ref|
       expect(item).to have_record_ref(record_ref)
     end

data/spec/netsuite/records/service_sale_item_spec.rb

@@ -22,6 +22,7 @@ describe NetSuite::Records::ServiceSaleItem do
     # TODO there is a probably a more robust way to test this
     expect(item.custom_field_list.class).to eq(NetSuite::Records::CustomFieldList)
     expect(item.pricing_matrix.class).to eq(NetSuite::Records::PricingMatrix)
+    expect(item.subsidiary_list.class).to eq(NetSuite::Records::RecordRefList)
   end
 
   it 'has the right record_refs' do
@@ -29,7 +30,7 @@ describe NetSuite::Records::ServiceSaleItem do
       :billing_schedule, :cost_category, :custom_form, :deferred_revenue_account, :department, :income_account,
       :issue_product, :item_options_list, :klass, :location, :parent, :pricing_group, :purchase_tax_code,
       :quantity_pricing_schedule, :rev_rec_schedule, :sale_unit, :sales_tax_code, :store_display_image,
-      :store_display_thumbnail, :store_item_template, :subsidiary_list, :tax_schedule, :units_type
+      :store_display_thumbnail, :store_item_template, :tax_schedule, :units_type
     ].each do |record_ref|
       expect(item).to have_record_ref(record_ref)
     end

data/spec/netsuite/records/vendor_spec.rb

@@ -17,7 +17,7 @@ describe NetSuite::Records::Vendor do
         :send_email, :subscriptions_list, :tax_id_num, :title, :unbilled_orders, :unbilled_orders_primary,
         :url, :vat_reg_number
     ].each do |field|
-      vendor.should have_field(field)
+      expect(vendor).to have_field(field)
     end
   end
 
@@ -27,7 +27,7 @@ describe NetSuite::Records::Vendor do
         :expense_account, :payables_account, :terms, :opening_balance_account, :currency, :work_calendar,
         :tax_item
     ].each do |record_ref|
-      vendor.should have_record_ref(record_ref)
+      expect(vendor).to have_record_ref(record_ref)
     end
   end
 
@@ -40,14 +40,14 @@ describe NetSuite::Records::Vendor do
           }
       }
       vendor.custom_field_list = attributes
-      vendor.custom_field_list.should be_kind_of(NetSuite::Records::CustomFieldList)
-      vendor.custom_field_list.custom_fields.length.should eql(1)
+      expect(vendor.custom_field_list).to be_kind_of(NetSuite::Records::CustomFieldList)
+      expect(vendor.custom_field_list.custom_fields.length).to eql(1)
     end
 
     it 'can be set from a CustomFieldList object' do
       custom_field_list        = NetSuite::Records::CustomFieldList.new
       vendor.custom_field_list = custom_field_list
-      vendor.custom_field_list.should eql(custom_field_list)
+      expect(vendor.custom_field_list).to eql(custom_field_list)
     end
   end
 
@@ -56,10 +56,10 @@ describe NetSuite::Records::Vendor do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :is_person => true }) }
 
       it 'returns a Vendor instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Vendor, { :external_id => 1 }], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Vendor, { :external_id => 1 }], {}).and_return(response)
         vendor = NetSuite::Records::Vendor.get(:external_id => 1)
-        vendor.should be_kind_of(NetSuite::Records::Vendor)
-        vendor.is_person.should be_truthy
+        expect(vendor).to be_kind_of(NetSuite::Records::Vendor)
+        expect(vendor.is_person).to be_truthy
       end
     end
 
@@ -67,10 +67,10 @@ describe NetSuite::Records::Vendor do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Vendor, { :external_id => 1 }], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Vendor, { :external_id => 1 }], {}).and_return(response)
+        expect(lambda {
           NetSuite::Records::Vendor.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }).to raise_error(NetSuite::RecordNotFound,
                              /NetSuite::Records::Vendor with OPTIONS=(.*) could not be found/)
       end
     end
@@ -83,10 +83,10 @@ describe NetSuite::Records::Vendor do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([vendor], {}).
             and_return(response)
-        vendor.add.should be_truthy
+        expect(vendor.add).to be_truthy
       end
     end
 
@@ -94,10 +94,10 @@ describe NetSuite::Records::Vendor do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([vendor], {}).
             and_return(response)
-        vendor.add.should be_falsey
+        expect(vendor.add).to be_falsey
       end
     end
   end
@@ -107,10 +107,10 @@ describe NetSuite::Records::Vendor do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([vendor], {}).
             and_return(response)
-        vendor.delete.should be_truthy
+        expect(vendor.delete).to be_truthy
       end
     end
 
@@ -118,10 +118,10 @@ describe NetSuite::Records::Vendor do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([vendor], {}).
             and_return(response)
-        vendor.delete.should be_falsey
+        expect(vendor.delete).to be_falsey
       end
     end
   end
@@ -130,7 +130,7 @@ describe NetSuite::Records::Vendor do
     let(:vendor) { NetSuite::Records::Vendor.new(:entity_id => 'TEST VENDOR', :is_person => true) }
 
     it 'returns a hash of attributes that can be used in a SOAP request' do
-      vendor.to_record.should eql({
+      expect(vendor.to_record).to eql({
                                         'listRel:entityId' => 'TEST VENDOR',
                                         'listRel:isPerson' => true
                                     })
@@ -139,7 +139,7 @@ describe NetSuite::Records::Vendor do
 
   describe '#record_type' do
     it 'returns a string type for the record to be used in a SOAP request' do
-      vendor.record_type.should eql('listRel:Vendor')
+      expect(vendor.record_type).to eql('listRel:Vendor')
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netsuite
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Ryan Moran
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-01 00:00:00.000000000 Z
+date: 2015-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon
@@ -117,6 +117,7 @@ files:
 - lib/netsuite/records/credit_memo_apply_list.rb
 - lib/netsuite/records/credit_memo_item.rb
 - lib/netsuite/records/credit_memo_item_list.rb
+- lib/netsuite/records/currency.rb
 - lib/netsuite/records/custom_field.rb
 - lib/netsuite/records/custom_field_list.rb
 - lib/netsuite/records/custom_list.rb
@@ -184,6 +185,7 @@ files:
 - lib/netsuite/records/record_ref_list.rb
 - lib/netsuite/records/rev_rec_template.rb
 - lib/netsuite/records/role_list.rb
+- lib/netsuite/records/roles.rb
 - lib/netsuite/records/sales_order.rb
 - lib/netsuite/records/sales_order_item.rb
 - lib/netsuite/records/sales_order_item_list.rb
@@ -253,12 +255,14 @@ files:
 - spec/netsuite/records/cash_refund_spec.rb
 - spec/netsuite/records/cash_sale_item_list_spec.rb
 - spec/netsuite/records/cash_sale_item_spec.rb
+- spec/netsuite/records/cash_sale_spec.rb
 - spec/netsuite/records/classification_spec.rb
 - spec/netsuite/records/credit_memo_apply_list_spec.rb
 - spec/netsuite/records/credit_memo_apply_spec.rb
 - spec/netsuite/records/credit_memo_item_list_spec.rb
 - spec/netsuite/records/credit_memo_item_spec.rb
 - spec/netsuite/records/credit_memo_spec.rb
+- spec/netsuite/records/currency_spec.rb
 - spec/netsuite/records/custom_field_list_spec.rb
 - spec/netsuite/records/custom_field_spec.rb
 - spec/netsuite/records/custom_list_spec.rb
@@ -420,12 +424,14 @@ test_files:
 - spec/netsuite/records/cash_refund_spec.rb
 - spec/netsuite/records/cash_sale_item_list_spec.rb
 - spec/netsuite/records/cash_sale_item_spec.rb
+- spec/netsuite/records/cash_sale_spec.rb
 - spec/netsuite/records/classification_spec.rb
 - spec/netsuite/records/credit_memo_apply_list_spec.rb
 - spec/netsuite/records/credit_memo_apply_spec.rb
 - spec/netsuite/records/credit_memo_item_list_spec.rb
 - spec/netsuite/records/credit_memo_item_spec.rb
 - spec/netsuite/records/credit_memo_spec.rb
+- spec/netsuite/records/currency_spec.rb
 - spec/netsuite/records/custom_field_list_spec.rb
 - spec/netsuite/records/custom_field_spec.rb
 - spec/netsuite/records/custom_list_spec.rb