netsuite 0.0.33 → 0.0.34

data/lib/netsuite/actions/add.rb

@@ -62,6 +62,13 @@ module NetSuite
         @response_hash ||= @response.to_hash[:add_response][:write_response]
       end
 
+      module Support
+        def add
+          response = NetSuite::Actions::Add.call(self)
+          response.success?
+        end
+      end
+
     end
   end
 end

data/lib/netsuite/actions/delete.rb

@@ -62,6 +62,17 @@ module NetSuite
         @response_body ||= response_hash[:base_ref]
       end
 
+      module Support
+        def delete(options = {})
+          response =  if options.empty?
+                        NetSuite::Actions::Delete.call(self)
+                      else
+                        NetSuite::Actions::Delete.call(self, options)
+                      end
+          response.success?
+        end
+      end
+
     end
   end
 end

data/lib/netsuite/actions/get.rb

@@ -58,6 +58,17 @@ module NetSuite
         @response_hash = @response[:get_response][:read_response]
       end
 
+      module Support
+        def get(options = {})
+          response = NetSuite::Actions::Get.call(self, options)
+          if response.success?
+           new(response.body)
+          else
+           raise RecordNotFound, "#{self} with OPTIONS=#{options.inspect} could not be found"
+          end
+        end
+      end
+
     end
   end
 end

data/lib/netsuite/actions/initialize.rb

@@ -51,6 +51,17 @@ module NetSuite
         @response_body ||= response_hash[:record]
       end
 
+      module Support
+        def initialize(object)
+          response = NetSuite::Actions::Initialize.call(self, object)
+          if response.success?
+            new(response.body)
+          else
+            raise InitializationError, "#{self}.initialize with #{object} failed."
+          end
+        end
+      end
+
     end
   end
 end

data/lib/netsuite/actions/update.rb

@@ -62,6 +62,15 @@ module NetSuite
         @response_hash ||= @response.to_hash[:update_response][:write_response]
       end
 
+      module Support
+        def update(options = {})
+          options.merge!(:internal_id => internal_id) if respond_to?(:internal_id) && internal_id
+          options.merge!(:external_id => external_id) if respond_to?(:external_id) && external_id
+          response = NetSuite::Actions::Update.call(self.class, options)
+          response.success?
+        end
+      end
+
     end
   end
 end

data/lib/netsuite/records/customer_refund.rb

@@ -9,7 +9,7 @@ module NetSuite
 
       actions :get, :initialize, :add, :delete
 
-      fields :address, :balance, :cc_approved, :cc_expire_date, :cc_name, :cc_number, :cc_street, :cc_zip_code, :charge_it,
+      fields :address, :cc_approved, :cc_expire_date, :cc_name, :cc_number, :cc_street, :cc_zip_code, :charge_it,
         :created_date, :currency_name, :debit_card_issue_no, :exchange_rate, :last_modified_date, :memo, :pn_ref_num, :status,
         :to_be_printed, :tran_date, :tran_id, :valid_from
 
@@ -17,7 +17,7 @@ module NetSuite
       field :apply_list,        CustomerRefundApplyList
       field :deposit_list,      CustomerRefundDepositList
 
-      read_only_fields :total
+      read_only_fields :balance, :total
 
       record_refs :account, :ar_acct, :credit_card, :credit_card_processor, :custom_form, :customer, :department, :klass,
         :location, :payment_method, :posting_period, :subsidiary, :void_journal

data/lib/netsuite/support/actions.rb

@@ -9,95 +9,30 @@ module NetSuite
       module ClassMethods
 
         def actions(*args)
-          instance_module = Module.new
-          class_module    = Module.new
           args.each do |action|
-            define_action(instance_module, class_module, action)
+            action(action)
           end
-          self.send(:include, instance_module)
-          self.send(:extend, class_module)
         end
 
-        def define_action(instance_module, class_module, action)
-          case action
+        def action(name)
+          case name
           when :get
-            define_get(class_module)
+            self.extend(NetSuite::Actions::Get::Support)
           when :add
-            define_add(instance_module)
-          when :initialize
-            define_initialize(class_module)
+            self.send(:include, NetSuite::Actions::Add::Support)
           when :delete
-            define_delete(instance_module)
+            self.send(:include, NetSuite::Actions::Delete::Support)
           when :update
-            define_update(instance_module)
-          else
-            raise "Unknown action: #{action.inspect}"
-          end
-        end
-
-        def define_get(class_module)
-          class_module.module_eval do
-            define_method :get do |*args|
-              options, *ignored = *args
-              response = NetSuite::Actions::Get.call(self, options)
-              if response.success?
-               new(response.body)
-              else
-               raise RecordNotFound, "#{self} with OPTIONS=#{options.inspect} could not be found"
-              end
-            end
-          end
-        end
-
-        def define_add(instance_module)
-          instance_module.module_eval do
-            define_method :add do
-              response = NetSuite::Actions::Add.call(self)
-              response.success?
-            end
-          end
-        end
-
-        def define_initialize(class_module)
-          (class << self; self; end).instance_eval do
-            define_method :initialize do |*args|
-              super(*args)
-            end
-          end
-
-          class_module.module_eval do
-            define_method :initialize do |object|
-              response = NetSuite::Actions::Initialize.call(self, object)
-              if response.success?
-                new(response.body)
-              else
-                raise InitializationError, "#{self}.initialize with #{object} failed."
+            self.send(:include, NetSuite::Actions::Update::Support)
+          when :initialize
+            (class << self; self; end).instance_eval do # We have to do this because Class has a private
+              define_method :initialize do |*args|      # #initialize method that this method will override.
+                super(*args)
               end
             end
-          end
-        end
-
-        def define_delete(instance_module)
-          instance_module.module_eval do
-            define_method :delete do |*options|
-              response = if options.empty?
-                           NetSuite::Actions::Delete.call(self)
-                         else
-                          NetSuite::Actions::Delete.call(self, *options)
-                         end
-              response.success?
-            end
-          end
-        end
-
-        def define_update(instance_module)
-          instance_module.module_eval do
-            define_method :update do |options|
-              options.merge!(:internal_id => internal_id) if respond_to?(:internal_id) && internal_id
-              options.merge!(:external_id => external_id) if respond_to?(:external_id) && external_id
-              response = NetSuite::Actions::Update.call(self.class, options)
-              response.success?
-            end
+            self.extend(NetSuite::Actions::Initialize::Support)
+          else
+            raise "Unknown action: #{name.inspect}"
           end
         end
 

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module Netsuite
-  VERSION = '0.0.33'
+  VERSION = '0.0.34'
 end

data/spec/netsuite/records/customer_refund_spec.rb

@@ -177,13 +177,13 @@ describe NetSuite::Records::CustomerRefund do
 
   describe '#to_record' do
     before do
-      refund.memo    = 'This is a memo'
-      refund.balance = 100
+      refund.memo       = 'This is a memo'
+      refund.cc_zip_code = '10101'
     end
     it 'can represent itself as a SOAP record' do
       record = {
-        'tranCust:memo'    => 'This is a memo',
-        'tranCust:balance' => 100
+        'tranCust:memo'      => 'This is a memo',
+        'tranCust:ccZipCode' => '10101'
       }
       refund.to_record.should eql(record)
     end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: netsuite
 version: !ruby/object:Gem::Version 
-  hash: 93
+  hash: 91
   prerelease: 
   segments: 
   - 0
   - 0
-  - 33
-  version: 0.0.33
+  - 34
+  version: 0.0.34
 platform: ruby
 authors: 
 - Ryan Moran